Changes by R. David Murray :
--
stage: -> patch review
versions: +Python 3.4 -Python 3.3
___
Python tracker
<http://bugs.python.org/issue17189>
___
___
Python-
R. David Murray added the comment:
I don't understand what you mean by removing dead code leading to loss of
functionality, unless you mean that the removal of the call to the quoting code
in Python3 led to a loss of functionality relative to Python2, in which case I
agree. It also l
R. David Murray added the comment:
It would be simpler, but it would also be useless for the actual use case for
which this issue was opened.
--
___
Python tracker
<http://bugs.python.org/issue18
R. David Murray added the comment:
You are conceptualizing this very differently. In our view, this data
structure is for cases where the original key is the most important piece of
information (about the keys). The transformation in the lookup process is
entirely in the service of looking
R. David Murray added the comment:
We don't generally backport tests unless they are part of a bug fix. It's not
a blanket prohibition, but normally the risk of false positives in a
maintenance release on platforms not covered by our buildbots outweighs the
benefits of adding
R. David Murray added the comment:
It would be great if this could get a review by MAL, since it looks like a
non-trivial change.
Also, you have some (commented out) debug prints in there.
--
___
Python tracker
<http://bugs.python.org/issue5
R. David Murray added the comment:
Ah, I see. I only scanned the patch quickly, obviously.
--
___
Python tracker
<http://bugs.python.org/issue5815>
___
___
Pytho
R. David Murray added the comment:
If they are part of a bug fix, then sure. That wasn't clear from this issue,
though. On the other hand, if the tests in that other issue cover the actual
bug, and these have any chance of *introducing* test failures (especially if
they are heisen
R. David Murray added the comment:
See also issue 13541?
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue19009>
___
___
Python-bugs-list m
R. David Murray added the comment:
Just to be clear: the reason I am opposed is that the audience for Misc/NEWS is
different from the audience for commit messages, and I would prefer that the
text reflect that. Mine do :)
--
___
Python tracker
R. David Murray added the comment:
I am opposed to generating NEWS from the commit messages. I thought Antoine
was too.
--
___
Python tracker
<http://bugs.python.org/issue18
R. David Murray added the comment:
The test needs to be fixed so that it runs even when the LICENSE file exists.
(It is also missing the skip when the network resource is not asserted.) I
have a patched test, and a fix for the 3.4 problem, but I can't apply it
because the 3.4.0 license
R. David Murray added the comment:
As I said, not exactly any of the above.
I'll get back to this after I finish the new email code (which should happen
before the end of the month). I need to take some time to look over the RFCs
and real world examples and come up with the most approp
R. David Murray added the comment:
The getaddrinfo error message should *not* refer to proxies, because
getaddrinfo does not do anything involving proxy configuration.
Presumably the error occurred when liburl2 tried to resolve the proxy. So, it
is liburl2 that needs to make sure that
R. David Murray added the comment:
You are right, there was a further typo in the 3.4 URL that I missed.
Yes, requires_resource('network') is what I was referring to (though using
transient_internet is also a very good idea :). I also changed the urllib call
to only do a HEAD re
R. David Murray added the comment:
It was checked in as an optimization, but if it fixes a bug I don't see why it
couldn't be backported. A unit test would be helpful, if you feel like writing
one.
--
nosy: +r.david.murray
versions: -Python 3.1,
R. David Murray added the comment:
Doesn't this confusion (here and in 19011) arise from the fact that the enum
class does *not* have CUTE_CAT attribute? That is, the error message is
correct, but surprising. Because, frankly, Enums are surprising in many ways ;)
--
R. David Murray added the comment:
I'm not sure what Serhiy means by "is blocked", but the second half makes
sense: readline(0) on a file will return the empty string, but here it will
read one character and return it. Like he says, it doesn't break anything in
the con
R. David Murray added the comment:
For the security fix, the check should only be done if the file is the the
default .netrc. (Which would also make your error message correct...otherwise
it is not :) Also, it would make more sense for the 'prop =' to be inside the
'if posix
R. David Murray added the comment:
Note that I'll test it by hand before applying, and will write a test for 3.3
(where Mock is available to make testing practical).
--
___
Python tracker
<http://bugs.python.org/is
R. David Murray added the comment:
Here is a 2.6 specific patch. I've hand tested this.
--
keywords: +patch
Added file: http://bugs.python.org/file31776/netrc-2.6.patch
___
Python tracker
<http://bugs.python.org/is
R. David Murray added the comment:
I could write a 2.6 test for the permissions part, but not for the incorrect
owner part. Do you want one without the other?
--
___
Python tracker
<http://bugs.python.org/issue14
R. David Murray added the comment:
Hmm. Answering the doc question caused me to run into something that calls the
whole patch into question:
http://www.unix.com/unix-dummies-questions-answers/11326-netrc-refuses-password.html.
In that example, the ftp program only rejected reading the
R. David Murray added the comment:
Here is an updated patch, with docs and test.
Turns out it actually wasn't necessary to move the check to the password, but
I'm leaving it that way anyway. The reason it wasn't necessary is that we
don't actually parse the .netrc file c
Changes by R. David Murray :
Removed file: http://bugs.python.org/file31779/netrc-2.6.patch
___
Python tracker
<http://bugs.python.org/issue14984>
___
___
Python-bug
Changes by R. David Murray :
Added file: http://bugs.python.org/file31780/netrc-2.6.patch
___
Python tracker
<http://bugs.python.org/issue14984>
___
___
Python-bugs-list m
R. David Murray added the comment:
Yes, you did :) I was using "permissions check" to cover both tests, since as
you say, if the file is owned by someone other than the user running the
processes, a user other than the one running the process has permission to
modify it.
posix-&g
R. David Murray added the comment:
Thank you for working on the patches, Claudiu, but...
The backward compatibility concern is valid.
Furthermore, I did a bunch of googling looking for examples. I did not turn up
any examples of APIs that were documented to use parameters without '=&#
R. David Murray added the comment:
Special casing Enum in inspect has a code smell to it. There may not be a
better option, but it sure feels ugly.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue19
R. David Murray added the comment:
So the real problem is that inspect depends on dir? Isn't there already a bug
open for that issue?
--
___
Python tracker
<http://bugs.python.org/is
R. David Murray added the comment:
My vote is no separators. But I'm just one vote :)
--
___
Python tracker
<http://bugs.python.org/issue18975>
___
___
Pytho
R. David Murray added the comment:
We have FreeBSD buildbots.
Python 3.0 is an ancient version of Python3 (in Internet years, at least :)
Please try again with python 3.3, the current stable version of Python3.
If that doesn't work, you should contact the pc-bsd support, since Py
R. David Murray added the comment:
Well, I was planning to merge it, since 2.7 needs the fix as well.
--
___
Python tracker
<http://bugs.python.org/issue14
R. David Murray added the comment:
Oops, didn't mean to assign this to anyone.
--
assignee: lemburg ->
nosy: +haypo
___
Python tracker
<http://bugs.python.org
R. David Murray added the comment:
Can you provide more information about the circumstances in which this is a
problem? Presumably there is a reason why the code is currently the way it is,
especially since it is done this way in several of the source files, and has
been that way for a *long
R. David Murray added the comment:
The patch for 3.1 is very close to the 2.7 patch, and is attached.
Benjamin and Georg, I'd like to apply this to 3.1 and merge it up through
default. May I and can I?
--
Added file: http://bugs.python.org/file31800/netrc-py3.1.
R. David Murray added the comment:
I suspect this isn't the only place where the change in what is considered a
(unicode) line ending character between 2.6 and 2.7/python3 is an issue. As
you observe, it causes very subtle bugs. I'm going to have to go trolling
through the pyt
R. David Murray added the comment:
That sounds reasonable. Would you be interested in trying your hand at a
patch, ideally with a test?
--
components: +email
nosy: +barry, r.david.murray
___
Python tracker
<http://bugs.python.org/issue19
R. David Murray added the comment:
Removing 2.6 and 2.7 from versions since it is now fixed there. I'll work on
porting it to python3.
--
versions: -Python 2.6, Python 2.7
___
Python tracker
<http://bugs.python.org/is
Changes by R. David Murray :
--
nosy: -lemburg
___
Python tracker
<http://bugs.python.org/issue19036>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
So the real problem is that the setlocale call is outside the ifdef, which
means Victor is the right person to look at this, since it was his patch that
introduced the code in question. I'll remove MAL from nosy, since I only added
him by acc
R. David Murray added the comment:
Hopefully a 2.7 patch would also apply to 3.3, so yes, start there.
For the test, I was thinking that in 3.3+ we could use mock to introduce a
delay. But looking at the code again it isn't obvious that there is a
meaningful way to do it that is wort
R. David Murray added the comment:
This appears to be resulting in buildbot lib2to3 test failures. ex:
http://buildbot.python.org/all/builders/x86%20Ubuntu%20Shared%202.7/builds/2319/steps/test/logs/stdio
http://buildbot.python.org/all/builders/PPC64%20PowerLinux%202.7/builds/206/steps/test
R. David Murray added the comment:
Because most often the time at which you want the original key is the point at
which you are about to re-serialize the data...so you need the value too.
--
___
Python tracker
<http://bugs.python.org/issue18
R. David Murray added the comment:
urllib2 is a python2 stdlib module, yes.
Can you provide a traceback? I would have thought that the traceback would
give a clue as to what the real problem was, so I'm very curious to see it.
Maybe it only gives a clue if you already know what yo
R. David Murray added the comment:
I do think getitem is the most natural name for the method.
--
___
Python tracker
<http://bugs.python.org/issue18986>
___
___
R. David Murray added the comment:
This is a Sphinx issue and should be reported on the Sphinx tracker...although
I think Sphinx uses a 3rd party tool for the sorting, so it might go back up
even a level further :).
I don't think there's any reason to keep this issue open here
R. David Murray added the comment:
You are correct, this is not likely to be a problem with Python itself (the
interactive prompt in your screen capture doesn't look like what Python would
produce by itself). So, since it is almost certainly not a bug in Python, it's
not appropriat
R. David Murray added the comment:
Well, I got the answer to the "may" question, but not the "can" question. The
answer to that question is "no":
remote: - changeset 6396d1fc72da on disallowed branch '3.1'!
remote: * Please strip the offending changese
R. David Murray added the comment:
Thanks, Benjamin. And Thank you, Bruno.
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
Janzert: Thanks for the patch. A contributor agreement is not needed for this
patch, since it just moves code around, but you might want to submit one in
case you make any other contributions. Also let us know what name to use in
the Misc/ACKS file
Changes by R. David Murray :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
Snakebite is live, and python committers can get shell access on the bots, as
originally planned. Some of the bots are offline, but most are running. I
don't see any OS X servers in the list, though, unless Antoine deleted them
(but there are several
R. David Murray added the comment:
See also issue 1346874. It seems that we do not currently handle 'continue'
correctly in general.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.o
R. David Murray added the comment:
I think we can fix this in maintenance releases without breaking anyone's code,
so a patch against both 2.7 and 3.3 would be ideal. A patch against 3.2 will
probably apply cleanly to 3.3, so that should be fine as well.
Thanks for working on this, and
R. David Murray added the comment:
You are making perfect sense. My point in referencing that issue was that you
are not crazy, we do indeed not handle continue correctly ;)
--
___
Python tracker
<http://bugs.python.org/issue19
R. David Murray added the comment:
No need to apologize for missing the issue. I missed it too, and I was looking
for it because I thought I remembered something...but only found the one I
referenced and assumed that that was what I was remembering.
--
stage: -> committed/rejec
R. David Murray added the comment:
The documentation is correct and unambiguous. Regular expressions just aren't
very intuitive.
The documentation says "Causes the resulting RE to match 0 or more repetitions
of the preceding RE, as many repetitions as are possible." "as
R. David Murray added the comment:
I would guess that if you did a network trace you'd find out there really was a
packet that did not arrive (a timeout). Note that detecting this is
complicated by the fact that ssl is involved. (I don't know the details, but I
remember someone s
R. David Murray added the comment:
Ah, that's a very good question. So perhaps the print command should be
renamed 'pprint'.
Anyone else have thoughts about the API? Do we instead need to fix the print
command, for backward compat
New submission from R. David Murray:
The new OS X buildbot is failing in test_posix:
==
FAIL: test_getgroups (test.test_posix.PosixTester)
--
Traceback (most
Changes by R. David Murray :
--
assignee: -> ronaldoussoren
components: +Macintosh
nosy: +ronaldoussoren
___
Python tracker
<http://bugs.python.org/issu
R. David Murray added the comment:
I've spun up a 10.6.8 OS X buildbot.
--
___
Python tracker
<http://bugs.python.org/issue19019>
___
___
Python-bugs-list m
R. David Murray added the comment:
Yes, the problem turned out to be that the buildslave process was running under
group 'daemon' (1), but the buildbot userid that it was running under was not
part of that group. So I changed the run group to 'staff', which buildbot is a
Changes by R. David Murray :
--
resolution: out of date -> invalid
___
Python tracker
<http://bugs.python.org/issue19059>
___
___
Python-bugs-list mai
R. David Murray added the comment:
I set LC_CTYPE to en_US.utf-8 on the buildbot, which I think is the better
setting for that buildbot, so the test doesn't fail there anymore. However,
the test should still be fixed (and maybe we should have a buildbot running
with no language set a
R. David Murray added the comment:
Well, there are two problems here, I think (it's been a while since I looked at
this): we should indeed be adding a crlf between mime boundary lines. But also
the clients should technically be handling it not being there, as well as the
case of
R. David Murray added the comment:
Heh, rather than "not conformant" I should have said that the two RFCs are in
conflict, in my opinion.
--
___
Python tracker
<http://bugs.python.o
R. David Murray added the comment:
Stephen: my post crossed yours. Yes, I agree with your logic, having re-read
the spec (the trailing CR is clearly part of the boundary). But I still think
the logic of the signing/validation is an invitation for running into problems
like this
R. David Murray added the comment:
There is definitely a bug here, but 8bit would also be wrong, since you are
calling as_string. It *should* be producing a 7bit CTE with a base64 encoded
part in that case.
--
components: +email
nosy: +barry, r.david.murray
versions: +Python 3.2
R. David Murray added the comment:
You are, but you are also calling as_string. Unicode can not handle 8bit data,
therefore the email package must down-transform all data to 7bit when
converting it to a string, just like a mail server trying to send to another
mail server that can only
R. David Murray added the comment:
__del__ methods are in general tricky because they are in the general case run
asynchronously. Therefore any proposal to "attach" the message to another
message is a non-starter.
If a __del__ method depends on attributes set in the __init__
R. David Murray added the comment:
No, that is not a good fix. It would mask other programming errors. There is
a *reason* the error/traceback is printed when an error occurs.
The fact that the Popen logic may be a bit complex is not an argument in favor
of a fix that hides errors
Changes by R. David Murray :
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue19065>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by R. David Murray :
--
nosy: +gregorlingl
___
Python tracker
<http://bugs.python.org/issue19075>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
Looks good to me.
This seems like a mistake in the python3 port to me. I'm in favor of fixing it
as a bug. As release manager and pdb expert, what do you think, Georg?
--
___
Python tracker
R. David Murray added the comment:
Sure :)
If you want some bonus points, can you figure out whether or not the test in
test_xmlrpc_net is worth moving to test_xmlrpc using a similar local-server
approach, or if it is redundant and should just be deleted?
(time.xmlrcp.com has come and gone
R. David Murray added the comment:
Also note that on OS X I believe the fsencoding is always utf-8, but the locale
can of course be something else.
--
___
Python tracker
<http://bugs.python.org/issue19
R. David Murray added the comment:
Yeah, a new issue is probably a good idea. If the dotted attribute feature is
not tested by test_xmlrpc, then the test is probably worth migrating.
I'm not sure what to do about the docs, and that should be a separate issue as
R. David Murray added the comment:
FYI this defect was mentioned (by Antoine) in Issue17530, though that issue is
about bytes.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue19
Changes by R. David Murray :
--
assignee: theller ->
versions: +Python 3.4 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue5710>
___
___
Python-
R. David Murray added the comment:
No, Senthil is correct.
My original liking for this idea came from my mistaken impression that a value
without an '=' was different from a value with an '='. But clearly the
practice in the industry (the de facto standard) is that th
R. David Murray added the comment:
I like it. If it isn't too difficult, I'd suggest that compact mode also
indent the string continuation lines:
['one string', 'other string',
'very very long string which is continued on '
'several lines&#x
R. David Murray added the comment:
If we were making this decision de novo, we might decide it that way. However,
the current behavior has been in place for a long time, so backward
compatibility concerns raise the bar high enough that the costs of the change
outweigh any benefits, even if
R. David Murray added the comment:
As noted in the review, I'm not as keen on having dictionaries displayed in
compact form.
--
___
Python tracker
<http://bugs.python.org/is
R. David Murray added the comment:
You must have a different 'open' in your namespace when you execute that.
Dropping a keyword argument like that is something we would never do without a
deprecation period.
Your example works fine for me.
--
nosy: +r.david.murray
R. David Murray added the comment:
It is a known issue that the Python build infrastructure does not currently
support cross compiling. There are a number of issues and patches in this
tracker that address pieces of this puzzle. Help sorting it all out will be
welcome.
--
nosy
R. David Murray added the comment:
I have no idea, frankly :)
I guess my point is that the tool chain was not designed with cross compilation
in mind, so sorting out how to make it work and writing a howto is something
that needs to be done. The patches that have already been applied address
R. David Murray added the comment:
Sorry I missed this on the review, but you are missing versionchanged tags (or
versionadded, whichever you prefer :) and a what's new entry.
--
___
Python tracker
<http://bugs.python.org/is
Changes by R. David Murray :
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue19154>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
I think we are unlikely to do this, as pdb is a very simple text interface.
I'm sure a patch would be considered if one was offered, but the increase in
complexity of the codebase would need to be minimal for it to be accepted, and
I suspect the fe
R. David Murray added the comment:
Indeed, this is already fixed. This issue is a duplicate of issue 1777412.
The bug will not be fixed in earlier versions for the reasons discussed in that
issue.
--
nosy: +r.david.murray
resolution: -> duplicate
stage: -> committed/re
R. David Murray added the comment:
Well, you could writing a streaming codec. Even if it didn't get accepted for
the stdlib, you could put it up on pypi.
--
___
Python tracker
<http://bugs.python.org/is
R. David Murray added the comment:
s/httplib/urllib/
--
___
Python tracker
<http://bugs.python.org/issue19154>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
It seems to me that there is indeed an issue of some sort here, but its locus
is (to me) unclear. I haven't commented before this because I wanted to read
the docs...but I haven't had time yet :)
One question is, is it even expected that passing
R. David Murray added the comment:
make touch avoids rebuilding "pgen and stuff", and just uses what was checked
out or provided in the tarball. The release tarballs are supposed to have the
time stamps in the correct order so that the compiletime/boostrapping utilities
don&#
New submission from R. David Murray:
You two may know what this is about, but I have no clue :) A few more details
would help if someone wants to try their hand at a patch.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.
R. David Murray added the comment:
There is a decent chance this is a bug in sqlite. Have you checked?
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue19
R. David Murray added the comment:
FYI: the development documentation tracks the tip of the default branch, so it
sometimes documents features that have not yet been released even in an alpha.
When we hit the first beta, *then* if the code doesn't match the docs there is
R. David Murray added the comment:
I believe that's the correct usage, in which case there must be a bug in the
process somewhere. My guess would be that it is looking for a file in the
"wrong" place when doing a cross compile, but that
5501 - 5600 of 10554 matches
Mail list logo
