R. David Murray added the comment:
You are welcome, and thanks for your contribution.
--
components: +Library (Lib) -Tests
___
Python tracker
<http://bugs.python.org/issue15
R. David Murray added the comment:
Thanks, Arnaud and Mike. (And Steven, of course :)
--
nosy: +r.david.murray
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by R. David Murray :
--
hgrepos: -147
___
Python tracker
<http://bugs.python.org/issue15795>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
Since it is a bugfix it can be applied at any time now. Checkins to default
will end up in 3.3.1 and 3.4. (Only features need to wait until after 3.3 is
branched in the main repo.)
--
___
Python tracker
<h
R. David Murray added the comment:
I don't think this closure was appropriate. The idea was accepted twice and
argued against once, so it isn't dead (it's just resting).
--
assignee: barry ->
nosy: +r.david.murray
resolution: wont fix ->
status: closed -> op
R. David Murray added the comment:
I've modified your patch slightly (cosmetic only).
When I run it on default I get the following:
/home/rdmurray/python/p33/Lib/os.py:263: BytesWarning: Comparison between bytes
and string
if tail == curdir: # xxx/newdir/. exists if xxx/n
R. David Murray added the comment:
Added some review comments on issue-15510-4.patch.
--
___
Python tracker
<http://bugs.python.org/issue15510>
___
___
Python-bug
R. David Murray added the comment:
I wonder if this is problematic enough that it should be treated as a
regression and fixed in the next RC?
--
___
Python tracker
<http://bugs.python.org/issue15
R. David Murray added the comment:
Let's see what Georg thinks.
--
nosy: +benjamin.peterson, georg.brandl
priority: normal -> release blocker
___
Python tracker
<http://bugs.python.org
R. David Murray added the comment:
Given their signatures in the docs, I suspect it is more complicated than that.
Perhaps the error messages are even correct. What does the code implement?
--
nosy: +r.david.murray
___
Python tracker
<h
R. David Murray added the comment:
Can you report a specific error and a recipe to reproduce it?
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue15
R. David Murray added the comment:
Thanks, Anton.
I took your last patch just a bit further, mostly to make it easy to break up
the test methods that test multiple things into test methods that test just one
thing. I also made the test insensitive to the order of the options on the
command
R. David Murray added the comment:
I did indeed.
--
Added file: http://bugs.python.org/file27110/test_webbrowser.patch
___
Python tracker
<http://bugs.python.org/issue15
R. David Murray added the comment:
Given the logic of webbrowser, I think Anton's patch is correct. The null
strings are produced by the somewhat twisted logic of UnixBrowser.open, and the
problem doesn't apply to the other cases of argument list generation. (In
those other case
Changes by R. David Murray :
--
title: webbrowser.open sometimes passes zero-length argument to the browser. ->
UnixBrowser.open sometimes passes zero-length argument to the browser.
___
Python tracker
<http://bugs.python.org/issu
R. David Murray added the comment:
Thanks, Anton.
--
resolution: -> fixed
stage: test needed -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
Thanks, Anton.
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
Thanks, Anton. And thank you Chris for the initial reviews.
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
Hmm. For some reason I did not get emailed these review comments, and I did
not see your note before I did the checkin. I will take a look.
--
___
Python tracker
<http://bugs.python.org/issue15
R. David Murray added the comment:
Yeah, you make some good points, but I think I may already have spent more time
on this that is justified by the amount of usage webbrowser gets :) So I think
I'm going to leave it as is, as being 'g
R. David Murray added the comment:
Oh, I see. I did get the email, it's just that my email filter put it into a
different folder from what I was expected.
--
___
Python tracker
<http://bugs.python.org/is
R. David Murray added the comment:
No, it always has an effect. It means that the name 'int' is bound in locals
instead of being looked up via globals. That is what makes it a
micro-optimization (LOAD_FAST vs LOAD_GLOBAL, if you do a dis on the two
R. David Murray added the comment:
Oh, I see what you are saying. The lookup of int is only done if random is not
None. Yes, that is true.
--
___
Python tracker
<http://bugs.python.org/issue15
R. David Murray added the comment:
If the optimization is actually useful, it can be preserved by just putting
'int=int' (with an 'optimization' comment :) before the loop.
--
___
Python tracker
<http://bug
R. David Murray added the comment:
Ezio: I don't really care whether or not it would be too meta, if you look at
the two versions, it is a *lot* clearer what is being tested in the try/except
version than it is in the assertRaises ve
R. David Murray added the comment:
Unless I misunderstand you, you are importing the module using two different
names, so loading it twice would be the correct behavior. That is,
'foo.bar.baz' is a different thing from 'bar.baz' from Python's point of view.
---
R. David Murray added the comment:
It isn't the file things are defined in that matters, it is how the module
object is named. As I said, foo.bar.baz and bar.baz are different objects from
Python's point of view, as you found out.
--
resolution: -> invalid
stage:
R. David Murray added the comment:
The index is available on every page via the link in the upper right corner.
An index-specific search might be interesting, though I usually just click the
'index on one page' link and do a text search. But that is a two step process
and does
Changes by R. David Murray :
--
versions: -Python 2.6, Python 2.7, Python 3.1, Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/issue15
Changes by R. David Murray :
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue15873>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
I'm not sure this is a good idea. $BAR is supported on the command line
because your shell supports it. To support it in files, argparse would have to
(re)implement shell parsing, and while we do have a parser in the stdlib that
can do some of this (
R. David Murray added the comment:
I had forgotten all about os.path.expandvars. Note, however, that that
function is very naive:
>>> os.path.expandvars("'$HOME'")
"'/home/rdmurray'"
That is, it is doing unconditional substitution, no
R. David Murray added the comment:
It is probably true that this is a bug, but subclasses of mutable classes do
not normally override __new__. (I'm curious what your use case is for doing
so.)
--
nosy: +benjamin.peterson, r.david.murray
___
P
R. David Murray added the comment:
Thanks, Zbyszek. I'm glad you caught this.
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.pyth
R. David Murray added the comment:
Thanks, Chris.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
Looks like reitveld doesn't recognize your patch format, Petri.
Instead of having the write_line flag, how about doing the newline write in the
if body? A 'lastline=line' at the end of the loop in the buffer loop case is
probably less expen
R. David Murray added the comment:
I incorporated your ideas into the update I made, including at least one that
Ezio may have rejected...he can blame me :)
Thanks, Mike.
--
resolution: -> fixed
stage: -> committed/rejected
status: open -&g
R. David Murray added the comment:
OK, 3.2 passes now, but when I merge to 3.3 I get failures.
test_zipimport_support doesn't work on 2.7 either, but there we could just not
backport the tests.
--
___
Python tracker
<http://bugs.py
R. David Murray added the comment:
Ah, my mistake. I forgot to do the hg add for the new files.
--
___
Python tracker
<http://bugs.python.org/issue14649>
___
___
R. David Murray added the comment:
I have separate working directories for 3.2 vs 3.3. If you have a single
working directory, the files would continue to be present even without the add.
The add is definitely needed for a correctly committed changeset
R. David Murray added the comment:
This is a duplicate of issue 1705520. Since Michael obviously hasn't gotten to
it yet, a proposed patch might move things along.
--
nosy: +r.david.murray
stage: -> committed/rejected
status: open -> closed
superseder: -> API for exc
Changes by R. David Murray :
--
nosy: +Julian
stage: test needed -> needs patch
versions: +Python 3.4 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue1
R. David Murray added the comment:
It occurs to me that ignoring the user's selected umask could be considered a
bug by some people. A package manager for a distribution should presumably
ensure the correct umask during install, but if a user is doing a direct
install, it seems reasonab
R. David Murray added the comment:
Thanks, Chris.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by R. David Murray :
--
nosy: +bethard
___
Python tracker
<http://bugs.python.org/issue15906>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by R. David Murray :
--
nosy: +sbt
___
Python tracker
<http://bugs.python.org/issue15914>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
Thanks Masato.
--
nosy: +r.david.murray
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
I rewrote the section a bit differently than you did in your patch...if you
think my changes are not an improvement please let me know.
--
nosy: +r.david.murray
resolution: -> fixed
stage: -> committed/rejected
status: open -&g
R. David Murray added the comment:
turtle uses it because that was the file that I made work when I was playing
with 'make doctest'. I think being able to use the testsetup directive would
be good. It could also them be used (I think!) to put resource directives in
the docs
Changes by R. David Murray :
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue15917>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
I believe you've identified the broken part of the change, Chris. So to
restore previous behavior we need to add that back correctly.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/is
Changes by R. David Murray :
--
priority: high -> deferred blocker
___
Python tracker
<http://bugs.python.org/issue15906>
___
___
Python-bugs-list mai
R. David Murray added the comment:
To repeat: there is no change to be made for 3.3. 3.3.0 will go out the door
with the pre-12776 behavior. So any backward compatibility concerns that apply
to 2.7 and 3.2 also apply to 3.3. Thus I suggest we restore the string check,
and consider an
R. David Murray added the comment:
What is proxy? Perhaps it does not implement readline correctly.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue15
R. David Murray added the comment:
It would probably be better to have the namespace object support subscripting
in order to satisfy this use case. You can use getattr to do it now. (Note
that the namespace object should probably use a real dict and a __getattr__
method, since I don't
R. David Murray added the comment:
I agree with Chris here. We also need to add the various tests he's come up
with. IMO the easiest way to restore the original behavior and the preserve
the fixes is to make the following single line change:
diff --git a/Lib/argparse.py b/Lib/argpar
R. David Murray added the comment:
Oh, it wasn't CPython that that comment was directed at. But I think you are
right: because CPython supports it, I think other implementations will as well,
whatever the language spec says or doesn't say (I didn't double check, I'm
goi
R. David Murray added the comment:
The correct fix has not been applied yet.
--
___
Python tracker
<http://bugs.python.org/issue15906>
___
___
Python-bugs-list m
R. David Murray added the comment:
*No* code should depend on it: this fix is very recent and is not in any
released version of Python, not even the RCs.
The bogus test should be removed. When I committed that patch I did not
understand the correct (documented) semantics of default
R. David Murray added the comment:
Actually, no, the test should not be removed, it should be reversed so as to
test the documented behavior.
--
___
Python tracker
<http://bugs.python.org/issue15
Changes by R. David Murray :
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue15931>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
Looks good to me.
--
___
Python tracker
<http://bugs.python.org/issue15906>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
All three of those sound like good ideas (testing string conversion, clarifying
docs, adding the no-double conversion test). Do you want to prepare the patch,
Chris? Barry can apply his any time and yours can be a followup.
We should also make a doc update
R. David Murray added the comment:
That isn't a valid Python program, and you appear to be reporting a bug in a
third party tool. You should report your problem to the appropriate community
for your IDE tool.
--
nosy: +r.david.murray
resolution: -> invalid
stage: ->
R. David Murray added the comment:
Thanks for wanting to help. If the PyScripter folks trace it back to a problem
with Python, please feel free to reopen this issue.
--
___
Python tracker
<http://bugs.python.org/issue15
R. David Murray added the comment:
Yes, that looks better.
I haven't worked through the rest of the logic in detail, I'll trust your
months of cogitation and the tests on that part.
--
___
Python tracker
<http://bugs.python.o
R. David Murray added the comment:
Since localtime() returns numbers, it is trivially true that localtime is not
affected by locale.
Your more specific phrasing is correct, I think.
--
nosy: +r.david.murray
___
Python tracker
<h
Changes by R. David Murray :
--
stage: needs patch -> test needed
___
Python tracker
<http://bugs.python.org/issue9253>
___
___
Python-bugs-list mailing list
Un
R. David Murray added the comment:
It seems to me this is more likely a bug in cygwin and/or the cygwin Python
port, since I find it hard to believe our windows users would be putting up
with getting incorrect localtime results.
--
nosy: +belopolsky, r.david.murray, terry.reedy
R. David Murray added the comment:
Perhaps that is the problem then: running a non-cygwin python from a cygwin
environment? I don't really know, which is why I added Terry to the nosy
list...he's got more Windows experience, though maybe not cygwin experience. I
myself no longer h
R. David Murray added the comment:
I'm not sure it can be. Windows is screwed up in the way it handles time.
Last I looked they still didn't support having the BIOS clock set to UTC (but
is has been a while since I looked).
--
___
Pyth
R. David Murray added the comment:
OK, I'm going to close this, then.
--
resolution: -> invalid
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.pyth
R. David Murray added the comment:
This is a duplicate of issue 12849. I'm not sure that we support keep-alive
using urllib. We do using httplib, if I understand correctly.
--
nosy: +r.david.murray
resolution: -> duplicate
stage: -> committed/rejected
status: ope
R. David Murray added the comment:
I've closed issue 15943 as a duplicate of this one. As I said there, I'm not
sure that we (can?) support keep-alive in urllib, though we do in httplib
(which is the http package in python3).
--
nosy: +r.david.murray, sanxiago
versions: +
Changes by R. David Murray :
--
title: urllib2 headers issue -> Cannot override 'connection: close' in urllib2
headers
___
Python tracker
<http://bugs.pytho
R. David Murray added the comment:
I believe this is a Windows...feature? We have lots of trouble with this
ourselves in the test suite, if I understand correctly.
--
nosy: +brian.curtin, r.david.murray, tim.golden
___
Python tracker
<h
R. David Murray added the comment:
It detects whether a string contains any characters have been surrogate escaped
by the surrogate escape handler. I disliked using it, but I didn't know of any
better way to do that detection. It's on my long list of things to come back
to even
R. David Murray added the comment:
Considering how often that test is done, I would consider the compiled version
of the short regex the clear winner based on your numbers. I wonder if we
could precompile the regex and load it from a pickle
R. David Murray added the comment:
I don't think so. We don't try to protect people from all their mistakes, and
a file descriptor of 1 is valid, and True == 1.
--
nosy: +r.david.murray
resolution: -> wont fix
stage: -> committed/rejected
status
R. David Murray added the comment:
Here is a patch.
Georg, this unfortunately represents a regression from 3.2 and should be fixed.
--
keywords: +patch
stage: -> commit review
Added file: http://bugs.python.org/file27205/parsedate_invalid.pa
R. David Murray added the comment:
Hmm. Not sure why Georg didn't get auto-added.
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/is
R. David Murray added the comment:
Oh, and I'm purposely allowing parsedate_to_datetime throw exceptions. I
suppose that should be documented, but that's a separate issue.
--
title: email.utils.parsedate(), email.utils.parsedate_tz() and
email.utils.parsedate_to_datetim
R. David Murray added the comment:
Format with unicode is a bit of a mess in 2.7. It would be consistent with the
rest of python2 for
>>> f.format("{0}", u"a")
u'a'
to be correct.
See also issue 7300 and issue 15276.
-
R. David Murray added the comment:
Note that I didn't say it was correct, I just said it was consistent :)
And no, breaking stuff that current works is a non-starter for 2.7.
--
___
Python tracker
<http://bugs.python.org/is
R. David Murray added the comment:
I've given this some more thought, and I'm leaning toward Antoine's POV here.
The point of running the doctests in the docs is not to test python, but to
test the docs. Sphinx has a facility to do that: make doctest. So I think it
is better
R. David Murray added the comment:
We should improve the unittest help, then :) I will also note that the couple
of times I tried it I couldn't figure out how to use the regrtest test
selection :)
What we probably need for regrtest is a way to pass through a "selection
string
Changes by R. David Murray :
--
stage: -> committed/rejected
___
Python tracker
<http://bugs.python.org/issue8542>
___
___
Python-bugs-list mailing list
Un
Changes by R. David Murray :
--
nosy: +larry
___
Python tracker
<http://bugs.python.org/issue15965>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
Cleanup on test failure is supposed to be done. Cleanup on crash or buildbot
timeout isn't done as far as I know (and that was a concern I had with the
changes made to support.TESTFN and the cwd, but I didn't articulate it very
well).
If you
R. David Murray added the comment:
I actually agree with Julian here. I much prefer patch.object and do my best
to avoid mock.patch. support.patch is also equivalent to patch.object and not
patch. That doesn't change the fact that other people prefer mock.patch, of
course.
I
R. David Murray added the comment:
Ah, of course. I should have reread the whole issue :)
The backward compatibility is the big concern here. Regardless of what we do
about that, we should at least fix this in 3.4.
--
___
Python tracker
<h
R. David Murray added the comment:
On linux it segfaults for me in the debug interpreter. On default tip.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue15
R. David Murray added the comment:
So by your measurements the short search is the clear winner?
--
___
Python tracker
<http://bugs.python.org/issue11454>
___
___
R. David Murray added the comment:
This issue may be about reducing the startup time, but this function is a hot
spot in the email package so I would prefer to sacrifice startup time
optimization for an increase in speed.
However, given the improvements to import locking in 3.3, what about a
R. David Murray added the comment:
It passed the email test suite. Patch attached.
--
Added file: http://bugs.python.org/file27226/email_import_speedup.patch
___
Python tracker
<http://bugs.python.org/issue11
R. David Murray added the comment:
This has already been fixed, and the change is visible in the online
documentation.
--
nosy: +r.david.murray
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
superseder: -> confusing docs with regard
R. David Murray added the comment:
The mention of NotImplemented in library/stdtypes cross references to the
'comparisions' section of the reference guide chapter on expressions. That
might be a useful cross link in the datamodel section as well.
--
nosy: +r.da
R. David Murray added the comment:
I don't think it is worth the extra code to convert the TypeError into a
ValueError. We aren't very strict about the distinction between those two.
Leaving this open for Georg to transplant it to 3.3.0.
--
assignee: -> georg.bran
Changes by R. David Murray :
--
components: +email -Library (Lib)
nosy: +barry, r.david.murray
___
Python tracker
<http://bugs.python.org/issue16005>
___
___
Pytho
R. David Murray added the comment:
I believe that Google is technically out of compliance with the SMTP spec here.
What they are doing is not unreasonable, since they don't have any reason to
want to waste resources on talking to a server they think is spamming them.
Making this work
4601 - 4700 of 10554 matches
Mail list logo
