Changes by R. David Murray :
--
components: +email -Library (Lib)
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue11783>
___
___
Python-bugs-list m
R. David Murray added the comment:
I'm finally getting back around to this. Torsten, could you submit a
contributor agreement, please? (http://www.python.org/psf/contrib/)
And to answer the question you had about the 'still failing' test, parseaddr
isn't currently do
Changes by R. David Murray :
--
assignee: r.david.murray ->
___
Python tracker
<http://bugs.python.org/issue11783>
___
___
Python-bugs-list mailing list
Un
R. David Murray added the comment:
My original fix for this for email6 got lost in a refactoring. Here is a patch
that fixes it in the code I recently checked in. It may not cover all the
headers that should be unique, since I haven't implemented parsers for all
structured headers yet
R. David Murray added the comment:
Committed. It is almost never the right thing to do to allow duplicates of
unique headers, but an application that does need it can create a policy
subclass and override the header_max_count method.
--
resolution: -> fixed
stage: test nee
R. David Murray added the comment:
Why would you expect it to?
>>> 'a\nb'.splitlines()
['a', 'b']
>>> 'a\nb\n'.splitlines()
['a', 'b']
>>> 'a\nb\n\n'.splitlines()
['a', '
R. David Murray added the comment:
That's why it's a different function :) (Well, that and universal newline
support). But I can see that explaining the difference between split and
splitlines would be worthwhile.
--
___
Python trac
R. David Murray added the comment:
Thanks, Oleg.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
I think it is up to each embedding application to decide if it wants to respect
the environment variables or not. I don't think that's a decision that core
can make.
Now, if we aren't providing an easy way for an embedding applicatio
R. David Murray added the comment:
An informational PEP sounds like exactly what I said: each application needs to
decide. The PEP would provide the information on which to base that decision,
and suggestions for how to do it.
An informational PEP on best practices for embedding sounds like
Changes by R. David Murray :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue14943>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by R. David Murray :
--
components: +email -Library (Lib)
nosy: +barry, r.david.murray
___
Python tracker
<http://bugs.python.org/issue14922>
___
___
Pytho
R. David Murray added the comment:
The buildbots seem happy.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue14796>
___
___
Python-
R. David Murray added the comment:
No it shouldn't. As mentioned in the Fedora thread you linked, this is no
different than the user setting LD_LIBRARY_PATH to something that screws up a
system installed program.
--
___
Python tracker
R. David Murray added the comment:
People interested in this issue might be interested in changeset e6a33938b03f.
I use parameterized unit tests in email a lot, and was annoyed by the fact that
I couldn't run the tests individually using the unittest CLI. The fix for that
turned out
R. David Murray added the comment:
I don't think this is documented anywhere (and should be). I believe what you
need to do is use functools.wraps on your wrapper function.
--
assignee: -> docs@python
components: +Documentation -None
nosy: +docs@python, michael.foord, r.davi
R. David Murray added the comment:
This is doubtless a result of the way the class namespace scope is handled,
coupled with the fact that in Python3 list comprehensions have a local scope.
The class scope is a somewhat unique beast. I agree that this is unfortunate,
but I have a feeling
R. David Murray added the comment:
Hmm. It seems to me this is an edge case as far as backward compatibility
goes. On the one hand it does seem like an RFC violation (ie: bug), on the
other hand there could be user programs depending on the current behavior. I'm
inclined toward tre
Changes by R. David Murray :
--
assignee: -> ronaldoussoren
components: +Macintosh
nosy: +ronaldoussoren
versions: +Python 3.3 -Python 3.4
___
Python tracker
<http://bugs.python.org/issu
Changes by R. David Murray :
--
assignee: ronaldoussoren -> nobody
nosy: +ned.deily, nobody
___
Python tracker
<http://bugs.python.org/issue14981>
___
___
Py
R. David Murray added the comment:
It is fixed. It was not backported.
--
nosy: +r.david.murray
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
I updated the tests to Python3, and attempted to replicate the fix using the
new importlib qualname support. Even if it had worked, this would not have
finished the patch, since Michael wants to generate a failing test instead of
raising the import error
R. David Murray added the comment:
Thanks. I added an example, too, since split has some.
--
nosy: +r.david.murray
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
type: -> behavior
___
Python tr
R. David Murray added the comment:
The doc changes should be part of the patch. I forget, though, if we
completely delete deprecated stuff from the docs or if we keep a deprecation
stub in place.
Note that it is possible (although in this case probably not too likely) that
the code will
R. David Murray added the comment:
A mac expert can confirm, but I think that just means that the default
mac_roman encoding (which is made the default by the OS, if I understand
correctly) can't handle that character. I believe it will work if you use
utf-8. And no, I don't know
R. David Murray added the comment:
Then either the signer or the verifier (or both) are broken per RFC 2046
(unless there has been an update that isn't referenced from the RFC). Section
http://tools.ietf.org/html/rfc2046#section-5.1.1 clearly indicates that the
ending delimiter ends a
Changes by R. David Murray :
--
versions: +Python 2.7, Python 3.3
___
Python tracker
<http://bugs.python.org/issue14983>
___
___
Python-bugs-list mailin
R. David Murray added the comment:
Looking at your stackoverflow post, you might be able to fix this by doing an
rstrip on the string body before signing it. But then if we add a CRLF between
the boundaries, the verifiers might start failing again. What do you think?
Probably adding the
Changes by R. David Murray :
--
title: [patch] email.generator should always add newlines after closing
boundaries -> email.generator should always add newlines after closing
boundaries
___
Python tracker
<http://bugs.python.org/issu
R. David Murray added the comment:
I do plan to add something like that at some point. You could open a new issue
for it if you like, and propose a formal patch.
--
___
Python tracker
<http://bugs.python.org/issue14
R. David Murray added the comment:
Sorry, I wasn't clear. By 'body' I actually meant the multipart part you are
signing. I haven't looked at your script really, but I was thinking of
something along the lines of make_sig(str(fullmsg.get_payload(0)).rstrip()).
But
R. David Murray added the comment:
Hmm. So that means the verifiers are not paying attention to the MIME RFC?
That's unfortunate.
--
___
Python tracker
<http://bugs.python.org/is
R. David Murray added the comment:
This seems like something we should fix for the default file read. There is a
backward compatibility concern, but I think the security aspect overrides that.
--
components: +Library (Lib)
nosy: +r.david.murray
priority: normal -> high
t
R. David Murray added the comment:
Review, including a code-but-not-algorithm review :), posted.
--
___
Python tracker
<http://bugs.python.org/issue1521
R. David Murray added the comment:
Here's a patch.
--
components: +Library (Lib) -Documentation
keywords: +patch
Added file:
http://bugs.python.org/file25803/unittest_method_name_difference.patch
___
Python tracker
<http://bugs.py
R. David Murray added the comment:
This is causing buildbot failures on some of the buildbots:
http://www.python.org/dev/buildbot/all/builders/x86%20Gentoo%203.x/builds/2529/steps/test/logs/stdio
http://www.python.org/dev/buildbot/all/builders/x86%20Windows7%203.x/builds/5082/steps/test/logs
R. David Murray added the comment:
I've applied this to 3.3. Because the preservation of spaces around the ascii
parts is a visible behavior change that could cause working programs to break,
I don't think I can backport it. I'm going to leave this open until I can
consul
R. David Murray added the comment:
Thanks for figuring that out. And no, it doesn't matter if it is
importlib.load_module or __import__, since both are provided by importlib now
and both use the cache.
It's an interesting question where the cache clear should go. I *think* it
sh
R. David Murray added the comment:
OK, I'm closing this, then, and will close the related issues as well.
Thanks again for the patch, Ralf.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
versions: -Python 2
R. David Murray added the comment:
This is fixed by the fix in issue 1079. Ralf found a *relatively* backward
compatible way to fix it, but since the point is preserving whitespace that
wasn't preserved before, there is an unavoidable behavior change, so it can't
be
R. David Murray added the comment:
This is fixed by the fix for issue 1079. I've added the test to the test suite.
--
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
superseder: -> decode_header does not follow RFC 2047
versions: -P
R. David Murray added the comment:
Instead of doing this we've opted to follow postel and be generous in what we
accept and go ahead and decode even if the leading and/or terminating space is
missing (see issue 1079).
--
resolution: -> rejected
status: open -
R. David Murray added the comment:
This is fixed by the fix to issue 1079, but we have decided that fix can't be
backported because it is a behavior change that might break existing working
programs.
--
resolution: -> duplicate
stage: -> committed/rejected
status: ope
R. David Murray added the comment:
OK, let's just do it in the individual test, then.
--
___
Python tracker
<http://bugs.python.org/issue7559>
___
___
Pytho
R. David Murray added the comment:
Presumably the PEP 0 generator needs a patch, but that's not something most of
us ever touch. I've added Nick to nosy, I think he made changes to it last.
--
nosy: +ncoghlan, r.david.murray
___
Pyth
R. David Murray added the comment:
That would probably be OK, but I don't see why clearing the cache in those same
methods (that create directories on the path) would be any harder. (It isn't
necessary to clear the cache *afterward*, only before, as far as I can see,
since the
R. David Murray added the comment:
Ah, yes, I wasn't clear. Sorry.
--
___
Python tracker
<http://bugs.python.org/issue7559>
___
___
Python-bugs-list m
Changes by R. David Murray :
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue14908>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by R. David Murray :
--
nosy: +rhettinger
stage: -> needs patch
type: -> behavior
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/i
Changes by R. David Murray :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue14989>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by R. David Murray :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue15000>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
The same problem exists in Python3.
--
nosy: +orsenthil, r.david.murray
stage: -> needs patch
versions: +Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/issu
New submission from R. David Murray :
Suppose you have a test package:
test_pkg
__init__.py
test_mytest.py
If __init__.py is empty and you run
python -m unittest test_pk
no tests are found.
You can get this to work by adding the following boiler plate to __init__.py:
def
R. David Murray added the comment:
Right, I'm not wanting to run discovery from the command line, I'm wanting to
run the tests in the package by package name. In my mind, this is exactly
parallel to specifying a module name and having unittest automatically discover
the TestCase
New submission from R. David Murray :
During the execution of the load tests protocol, the loader instance will set
its _top_level_dir attribute, and this will persist if the loader is passed on
to another load_tests method. If that method does not specify a top_level_dir
in a discovery call
R. David Murray added the comment:
Well, personally I just read the code, and didn't think anything of it. I
guess Python code is documentation to me :)
I don't see why there would be any objection to documenting them if you want
to, though. It's not like we're going to
Changes by R. David Murray :
--
components: +email
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue15013>
___
___
Python-bugs-list mailing list
Unsub
R. David Murray added the comment:
Yes, this is a need I also ran into, but hadn't gotten around to submitting a
bug for. If we are going to do this, though, I think we should do it right and
add the ability to support arbitrary login methods. An example of one way to
do this i
Changes by R. David Murray :
--
components: +email
nosy: +barry
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue15014>
___
___
Python-
Changes by R. David Murray :
--
nosy: +bquinlan
stage: -> patch review
type: -> behavior
versions: +Python 3.3 -Python 3.4
___
Python tracker
<http://bugs.python.org/i
R. David Murray added the comment:
Thanks for the patch. I may not get to this until after the beta (or I might,
you never know).
Could you submit a contributor agreement please?
http://www.python.org/psf/contrib
--
stage: -> patch review
title: [patch] add special case for la
R. David Murray added the comment:
There's already an issue for this (issue 14502), which is closed. If the docs
are still wrong you should probably reopen that one, since it has discussion of
the issues involved. (Note, however, that ThreadError is RuntimeError, so
technically the
R. David Murray added the comment:
Windows makes \x00 a space? How odd.
This is the result for me on linux:
Python 2.7.3+ (2.7:1f5d2642929a, May 25 2012, 12:47:34)
[GCC 4.5.3] on linux2
Type "help", "copyright", "credits" or "license" for more informa
R. David Murray added the comment:
An alternative is to do what the email package in 3.3 does, and treat naive
datetimes as exactly "UTC referenced but with no information as to what local
timezone they originated in". Either way, a program using the plistlib is
going to have to
Changes by R. David Murray :
--
resolution: -> invalid
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
Could you please clarify the inputs and outputs. I can't tell from your
description what exact byte string you are passing in from C++ or what exact
string you are seeing on the Python side. For example, if:
'--net-label-name=\'("DC1
New submission from R. David Murray :
And I wish I knew what those were.
--
assignee: docs@python
components: Documentation
messages: 162513
nosy: docs@python, r.david.murray
priority: normal
severity: normal
stage: needs patch
status: open
title: tutorial should use best practices in
R. David Murray added the comment:
The Python3 tutorial was already fixed, and the explanation of the parens is
not needed there since the "old syntax" is not supported.
I did not do any reordering since the use of 'as' immediately follows in the
text and seems to m
R. David Murray added the comment:
Thanks for working on this.
This is not my area of expertise, but what you describe sounds like an RLock,
and there is a C implementation of RLock in Python3. Could you just use that
for Python3?
Also, very minor comments on the patch format (I'm not
R. David Murray added the comment:
The obvious example is that the tutorial makes no mention of calling 'super' in
__init__. I'm also aware that there are issues of pickleability that arise if
you do things one way, but do not arise if you do things another way. But I
Changes by R. David Murray :
--
components: +email
nosy: +barry, r.david.murray
stage: -> needs patch
type: -> behavior
___
Python tracker
<http://bugs.python.org/i
R. David Murray added the comment:
That's why I phrased it as a question, I don't know enough about the C stuff.
Someone else nosy on this bug will probably have a more informed opinion.
I don't think the copyright marking policy is currently written down. It ought
to b
R. David Murray added the comment:
Thanks for the patch.
I think the extra check should be done unconditionally in the case where we've
looked up the default .netrc file. Adding a feature to 3.3 to provide an
optional check for other files (with default False) would then be an addit
R. David Murray added the comment:
I see some code changes, but no added tests for those code changes.
msg.fp doesn't exist in Python3. I'd like to understand those changes better,
but I don't know when I'll have the time or if it is worth the effort.
--
n
R. David Murray added the comment:
Oh, and the code changes should presumably be applied to Python3 as well (once
there are tests), so I've added those versions. It might be better to have two
patches, one for the close of _file, and the other for the msg.fp stuff (since
that doesn
R. David Murray added the comment:
I fail to see the problem here. If the module has 'from __future__ import
unicode_literals", then the docstring output clauses would need to be changed
to reflect the fact that the input literals are now unicode. What am I missing?
-
R. David Murray added the comment:
Since there's been no response, I'm closing this.
--
keywords: +buildbot
nosy: +r.david.murray
resolution: -> out of date
stage: -> committed/rejected
status: pending -> closed
___
Py
R. David Murray added the comment:
Closing because of lack of response.
--
nosy: +r.david.murray
status: pending -> closed
___
Python tracker
<http://bugs.python.org/iss
Changes by R. David Murray :
--
status: pending -> closed
___
Python tracker
<http://bugs.python.org/issue9722>
___
___
Python-bugs-list mailing list
Unsubscri
R. David Murray added the comment:
This was applied by Georg in SVN revision r77561 on 2010-01-17.
--
nosy: +r.david.murray
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python track
R. David Murray added the comment:
It doesn't look like anyone is working on it currently.
Yes, getting this right is a bit tricky for exactly the reason you say. You
have to make sure you don't break the other uses, and glancing at the patch (I
haven't looked at the code y
R. David Murray added the comment:
If you find any resources that we can link to, please post them here.
--
assignee: docs@python ->
nosy: +r.david.murray, terry.reedy
___
Python tracker
<http://bugs.python.org/issu
Changes by R. David Murray :
--
nosy: +asvetlov
___
Python tracker
<http://bugs.python.org/issue15041>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by R. David Murray :
--
assignee: jnoller ->
nosy: +sbt
versions: +Python 2.7, Python 3.2, Python 3.3 -Python 2.6, Python 3.0
___
Python tracker
<http://bugs.python.org/iss
R. David Murray added the comment:
"works" in the sense that it produces output. But it doesn't produce the
output it used to, which is the same text as the initial banner when you type
help(). I believe the existing behavior in this case is correct. With your
patch it pr
R. David Murray added the comment:
Oh, that wouldn't fix 'pydoc help', would it. So there are probably two places
where the special case has to be added, which means the code itself should go
in pydoc and be called from _Helper.__call__ somehow. (Note, I'm just throwin
R. David Murray added the comment:
Brian: ping. Since this is an enhancement, if you are going to accept it it
would be nice to get it into 3.3, which means committing it before June 23rd.
--
nosy: +r.david.murray
stage: -> patch review
versions: +Python
R. David Murray added the comment:
Ah, good. I thought we'd fixed the open/close issues, but I could easily
believe we had missed something (especially in Python2).
Since the fp stuff is gone in 3, I'd be OK with just applying this.
--
versions: -Python 3.2,
New submission from R. David Murray :
rdmurray@hey:~/python/p32>cat bad.py
This line is just ascii
A second line for good measure.
This comment contains undecodable stuff: "�" or "\\xe9" in "pass�"" cannot
be decoded.
The last line above
R. David Murray added the comment:
Actually it's a lot easier than that, although it is very much a hack: just
rename the .pyo files to .pyc, and python without -O will happily import them.
Since the optimization happens when the bytecode is written, this does what you
R. David Murray added the comment:
That makes sense. I'll add a mention of this to the 'open' docs that discuss
the buffering parameter.
--
assignee: -> r.david.murray
components: +Documentation
___
Python tracker
<h
R. David Murray added the comment:
Actually, it is documented:
http://docs.python.org/dev/reference/datamodel.html#basic-customization
"__new__() is intended mainly to allow subclasses of immutable types (like int,
str, or tuple) to customize instance creation."
It could certainly
Changes by R. David Murray :
--
nosy: +amaury.forgeotdarc, meador.inge
___
Python tracker
<http://bugs.python.org/issue15058>
___
___
Python-bugs-list mailin
Changes by R. David Murray :
--
nosy: +skrah
___
Python tracker
<http://bugs.python.org/issue15059>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
I doubt that unicode domain support in urllib would be of much use without full
IRI support. I would think that a domain that uses unicode is highly likely to
have URLs that use unicode.
However that doesn't mean a patch along the lines you suggest
R. David Murray added the comment:
email.utils.format_datetime implements RFC 5322 date format, which is very
different from RFC 3339. I don't remember enough about what I read in RFC 3339
to answer your question about isoformat.
--
___
P
R. David Murray added the comment:
It took me a while to make any sense out of your example, but having done so I
don't think it makes any sense in the argparse context. It is certainly not the
way argparse handles options or arguments. In argparse, if you have an option
'k
R. David Murray added the comment:
Well, if you can figure out how to add it, please do suggest a patch :)
It occurs to me that 'find' is a sort-of similar example, where options can be
repeated but the order in which they appear relative to other options matters.
So I can see
R. David Murray added the comment:
As I said, patches to improve the situation are welcome, and if they match with
current internet practices they will likely be accepted.
It is still the case that such URLs are likely to require extra work on the
part of the application to deal with the
R. David Murray added the comment:
You could get one of the pypy devs that have push rights on cpython to commit
it. If that doesn't happen, then at some point (probably not *too* long from
now) I or someone else will commit it. We have many more patches than we have
people with ti
4201 - 4300 of 10554 matches
Mail list logo