R. David Murray added the comment:
I reformatted the first hunk a bit, hopefully to make it even a little bit
clearer. We're still punting the actual definition to the later section, but I
think that's appropriate.
Thanks for the patch, Greg.
--
resolution: -> fixed
R. David Murray added the comment:
But it is create_socket you want to change. So if we add a map argument to
that and only pass it to socket if it is non-None, wouldn't that maintain
backward compatibility with current asyncore behavior? Neither asyncore nor
asynchat calls create_s
R. David Murray added the comment:
By the way, Glenn, what you posted as "the syntax error" (which it was) *is*
the traceback. A syntax error on the file directly being compiled will only
have one line in the traceback.
--
nosy: +r.da
R. David Murray added the comment:
Mostly likely it is correct. Looking at the definition of close, it is calling
"_real_close" when the _io_refs count drops to zero, and _decref_socketios is
decrementing that counter. So the logic is "if we have been closed, see if it
is ti
R. David Murray added the comment:
Thanks for the suggestion and the patch.
The 'true' isn't inherited from java. The actual value can be either an
integer or True/False. (If it were a function written in Python it would be
any value that evaluates as true, but because it
Changes by R. David Murray :
--
components: +email -Documentation
priority: normal -> low
versions: +Python 3.3 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue
Changes by R. David Murray :
--
components: +email
___
Python tracker
<http://bugs.python.org/issue1672568>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
All of this is going to be fixed a different (better :) way in an upcoming
patch that will add a new header parsing/folding policy to the email package.
For the record, the way to spell the "decode a header and return a string"
function using th
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email
___
Python tracker
<http://bugs.python.org/issue1525919>
___
___
Python-bugs-lis
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email
keywords: -easy
___
Python tracker
<http://bugs.python.org/issue1243730>
___
_
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email
___
Python tracker
<http://bugs.python.org/issue1043706>
___
___
Python-bugs-lis
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email
___
Python tracker
<http://bugs.python.org/issue740495>
___
___
Python-bugs-lis
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email
___
Python tracker
<http://bugs.python.org/issue795081>
___
___
Python-bugs-lis
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email
___
Python tracker
<http://bugs.python.org/issue2658>
___
___
Python-bugs-lis
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email
___
Python tracker
<http://bugs.python.org/issue1443875>
___
___
Python-bugs-lis
R. David Murray added the comment:
The email package no longer strips the leading whitespace. It doesn't unfold
the headers, but changing that at this stage has untenable consequences.
However, the email package in 3.3 will have a provisional API that will provide
the correct unfoldi
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email
versions: -Python 3.1
___
Python tracker
<http://bugs.python.org/issue1
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email
___
Python tracker
<http://bugs.python.org/issue9967>
___
___
Python-bugs-lis
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email
___
Python tracker
<http://bugs.python.org/issue1823>
___
___
Python-bugs-lis
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email
nosy: +barry
versions: -Python 3.1
___
Python tracker
<http://bugs.python.org/issu
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email
versions: -Python 3.1
___
Python tracker
<http://bugs.python.org/iss
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email
nosy: +barry
versions: -Python 3.1
___
Python tracker
<http://bugs.python.org/issu
Changes by R. David Murray :
--
components: +email
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
versions: -Python 3.1
___
Python tracker
<http://bugs.python.org/
Changes by R. David Murray :
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue13849>
___
___
Python-bugs-list mailing list
Unsubscri
R. David Murray added the comment:
I agree that testing for subclass is a rather specialized thing, and thus
should be defined by a project that needs it. Normal API-centric unit tests
shouldn't, IMO, care whether X is a subclass of Y. If you are using it to
write a failing unit te
Changes by R. David Murray :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue14819>
___
___
Python-bugs-list mailing list
Unsubscri
R. David Murray added the comment:
Thanks, fixed. Appears to have been a mistake made when we refactored from
expected/actual to first/second.
--
nosy: +r.david.murray
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
type: -&
R. David Murray added the comment:
Instead I decided to go ahead and document the argument as True/False. That
something else is accepted is a CPython implementation detail that shouldn't be
depended on.
By the way, I couldn't actually use your patch file, since it wasn'
R. David Murray added the comment:
I don't think that the suggested text contradicts that. (Especially the
wording "tends to".) So I think this might be a reasonable addition, but I can
see that "some people" might get upset :)
---
R. David Murray added the comment:
I think the behavior is correct. next(x) is outside the for expression in the
list comprehension, but 'list(x)' is an implicit 'for x in exp'. So I believe
it is the doc that needs amplification. The PEP discussion is referring
Changes by R. David Murray :
--
hgrepos: -44
___
Python tracker
<http://bugs.python.org/issue12586>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by R. David Murray :
Removed file: http://bugs.python.org/file22700/README.txt
___
Python tracker
<http://bugs.python.org/issue12586>
___
___
Python-bugs-list m
Changes by R. David Murray :
Removed file: http://bugs.python.org/file22699/b22698463737.diff
___
Python tracker
<http://bugs.python.org/issue12586>
___
___
Python-bug
Changes by R. David Murray :
--
components: +email
___
Python tracker
<http://bugs.python.org/issue14731>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
As mentioned on python-dev, I'm planning to introduce the new header
parsing/folding code as a provisional API in the spirit if not quite the letter
of PEP 411. Issue 14731 is a pre-requisite for this issue, since this patch
builds on to of that one.
R. David Murray added the comment:
I checked the indent fix into the wrong branch in my repo. It's in the other
patch. I could fix that if desired.
The reason for making the base class public is to allow subclassing. Perhaps
that is not needed for Compat32, though.
I don't thin
Changes by R. David Murray :
Removed file: http://bugs.python.org/file25646/email6.patch
___
Python tracker
<http://bugs.python.org/issue12586>
___
___
Python-bugs-list m
Changes by R. David Murray :
Added file: http://bugs.python.org/file25655/email6.patch
___
Python tracker
<http://bugs.python.org/issue12586>
___
___
Python-bugs-list m
R. David Murray added the comment:
I would also, however, not be a typical Python coding pattern. Functions
normally return None by default. The 'assertor True' pattern makes it
reasonably clear what the intent is, which just having logging return True
would not, particularl
R. David Murray added the comment:
Interesting. _checkquote doesn't even exist in the Python3 version of imaplib.
--
components: +email -Extension Modules
nosy: +barry, r.david.murray
___
Python tracker
<http://bugs.python.org/is
R. David Murray added the comment:
I was definitely wrong about the "obvious" part, then. The 'if __debug__:'
idiom is completely optimized away by -O, just like asserts are. That is, in
-O mode, there is no if test, the code block is just omitted entirely.
Having
Changes by R. David Murray :
--
nosy: +mark.dickinson
___
Python tracker
<http://bugs.python.org/issue14875>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
This is a test email reply with no MIME header.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue2
R. David Murray added the comment:
This is presumably going to turn out to be a problem with shlex's handling of
non-ascii characters. I believe there are open issues about that, but I'm not
sure of the status.
--
nosy: +r.david.murray
R. David Murray added the comment:
Thanks for the report and patch.
However, since there is no del_parser method, I'm inclined to think that this
is not a bug. That is, the ability to overwrite a previously defined subparser
could be considered a feature.
If Steven does consider it
R. David Murray added the comment:
I don't think that those additions make anything clearer, I'm afraid.
"child python process" would seem to imply raised in the new python running in
the child process, which is clearly not true.
Hmm. I seem to remember having this dis
R. David Murray added the comment:
Heh. Maybe what we ought to do is drop the shell argument and make everyone
build their own shell invocations :)
Actually, an API refactor where a shell call looks like this might be kind of
cool:
Popen(shell_cmd('echo magic'))
where shell wo
Changes by R. David Murray :
Removed file: http://bugs.python.org/file25655/email6.patch
___
Python tracker
<http://bugs.python.org/issue12586>
___
___
Python-bugs-list m
Changes by R. David Murray :
Added file: http://bugs.python.org/file25693/email6.patch
___
Python tracker
<http://bugs.python.org/issue12586>
___
___
Python-bugs-list m
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email -Library (Lib)
nosy: +barry
___
Python tracker
<http://bugs.python.org/issu
R. David Murray added the comment:
And now it's been long enough that I lost the email :(
--
assignee: r.david.murray ->
components: +email -Library (Lib)
nosy: +barry
versions: +Python 3.3 -Python 3.1
___
Python tracker
<http://bugs
R. David Murray added the comment:
I think I can actually fix this once the patch in issue 14731 is applied.
--
assignee: r.david.murray ->
components: +email -Library (Lib)
dependencies: +Enhance Policy framework in preparation for adding email6
policies as provisional
versi
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email -Library (Lib)
nosy: +barry
___
Python tracker
<http://bugs.python.org/iss
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email
nosy: +barry
type: -> behavior
versions: +Python 2.7 -Python 3.1
___
Python tracker
<http://bugs.python.org/i
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email -Library (Lib)
___
Python tracker
<http://bugs.python.org/issue6942>
___
___
Py
R. David Murray added the comment:
I think if we can fix issue 1590744, this will be completely fixed.
--
assignee: r.david.murray ->
dependencies: +mail message parsing glitch
___
Python tracker
<http://bugs.python.org/issue
Changes by R. David Murray :
--
components: +email -Library (Lib)
___
Python tracker
<http://bugs.python.org/issue968430>
___
___
Python-bugs-list mailin
Changes by R. David Murray :
--
versions: -Python 2.7, Python 3.2
___
Python tracker
<http://bugs.python.org/issue968430>
___
___
Python-bugs-list mailin
R. David Murray added the comment:
Thanks for the patch. I haven't forgotten about it, but it will probably still
be a while yet before I get to it. Hopefully before 3.3 is released, though.
--
assignee: r.david.murray ->
components: +email -Library (Lib)
nosy: +barry
titl
R. David Murray added the comment:
Forest, could you please submit a contributor agreement?
http://www.python.org/psf/contrib/
Life caught up with me and I haven't made enough progress to do anything with
this yet, but I still want to.
--
assignee: r.david.murray ->
co
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email -Library (Lib)
___
Python tracker
<http://bugs.python.org/issue1467619>
___
_
Changes by R. David Murray :
--
components: +email -Library (Lib)
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue12553>
___
___
Python-bugs-list m
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email -Library (Lib)
stage: test needed -> needs patch
___
Python tracker
<http://bugs.python.org/is
R. David Murray added the comment:
I've changed my approach. The policy option is now 'cte_type', but moreover
the default policy is now a backwards compatibility policy to which this issue
doesn't apply. The new provisional policy should get this support, but that&
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email -Library (Lib)
___
Python tracker
<http://bugs.python.org/issue7304>
___
___
Py
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue14645>
___
___
Py
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue14734>
___
___
Py
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email -Library (Lib)
nosy: +barry
___
Python tracker
<http://bugs.python.org/issu
R. David Murray added the comment:
Thanks.
--
___
Python tracker
<http://bugs.python.org/issue3244>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
Me too. I think the implication of that devguide entry is wrong.
--
nosy: +r.david.murray
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issu
R. David Murray added the comment:
I decided to keep the Compat32 class public both because it simplifies the
documentation and because there doesn't seem to be a good reason to hide it.
I'm leaving this issue open pending adding some discussion to
R. David Murray added the comment:
I think it is perfectly reasonable for a parser to leave the file pointer in
some undefined further location into the file when it detects "extra stuff" and
produces an error message. One can certainly argue that producing that error
message is
R. David Murray added the comment:
Well, if the stream isn't seekable then I don't see how it can be left in any
state other than the same one it leaves a file (read ahead as much as it read
to generate the error). So unfortunately by our backward compatibility rules I
still think
R. David Murray added the comment:
This works fine for me on Gentoo Linux with both 3.2.3+ (ie: what's in the
repo) and 3.2.2.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/is
R. David Murray added the comment:
Ah, I should clarify: Gentoo's 3.2.2. I'm sure they've added some patches,
just like Debian.
--
___
Python tracker
<http://bugs.pyt
Changes by R. David Murray :
--
assignee: -> r.david.murray
___
Python tracker
<http://bugs.python.org/issue14731>
___
___
Python-bugs-list mailing list
Un
R. David Murray added the comment:
Serhiy: did you add 3.3 because you can reproduce it on 3.3?
--
components: +Library (Lib) -None
___
Python tracker
<http://bugs.python.org/issue14
Changes by R. David Murray :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue14731>
___
___
Python-bugs-list
Changes by R. David Murray :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
We ended up deciding to keep backward compatibility and add datetime support as
a new API. All of these changes are now checked in to default. (See issue
665194, as well as issue 12586.)
--
resolution: -> duplicate
stage: needs patch -> com
R. David Murray added the comment:
Removing dependency on issue 11959. Instead I'm going to fix the logging test
by adding the necessary updates to its __init__ methods on the smtpd
subclasses. Then 11959 can be dealt with independently.
--
dependencies: -smtpd cannot be
R. David Murray added the comment:
Thanks very much to everyone who contributed to this patch. It was a real team
effort :)
--
assignee: r.david.murray ->
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open
New submission from R. David Murray :
The error recovery heuristic the parser uses is that if it sees a line with no
leading whitespace and no ':' in it, it assumes that the blank line between the
headers and the body was missing. It does not, however, register defect for
R. David Murray added the comment:
OK, here is patch based on the new policy support in 3.3. I have some concern
that the behavior change it introduces might cause some issues, but since it
seems like a reasonable change and is happening at a feature release boundary,
I think it should be
R. David Murray added the comment:
Oh, and to be clear on how this addresses the bug report: if you set
'raise_on_defect' to true when you call the parser, then you'll get an
exception when you call msg.get_payload(decode=True).
--
___
Changes by R. David Murray :
Removed file: http://bugs.python.org/file25737/base64_payload_defects.patch
___
Python tracker
<http://bugs.python.org/issue1672568>
___
___
R. David Murray added the comment:
Hmm. Thinking about it, though, that might not work if there are other errors
in the message, many of which are more benign. Probably the raise_on_defect
control is a little too coarse.
I've been thinking that we need a way to set the policy on an al
R. David Murray added the comment:
Fixed.
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
Most likely your problem is that you installed the module in question for 2.5,
but haven't (yet) installed it for 2.7. If you find that this isn't the
problem you can reopen the issue and provide more details. But I'm pretty sure
tha
Changes by R. David Murray :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
Fix committed.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.org/
R. David Murray added the comment:
I didn't wind up using your patch (for one thing I forgot that there were two
separate issues in this patch and independently rediscovered and fixed the
MissingHeaderBodySeparatorDefect one). However, this is now fixed in 3.3.
Unfortunately, sin
R. David Murray added the comment:
I almost applied this patch, but my gut is having second thoughts about it. I
don't think this is the correct solution. The correct solution would be to
delay the encoding of the body part until the message generation phase, and use
the requested li
Changes by R. David Murray :
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue14938>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
The pre 3.3 email package does not do any header unfolding. You can make this
work by doing the header unfolding before passing it to getaddresses:
>>> email.utils.getaddresses([''.join(m['to'].splitlines())])
[('A (B)
R. David Murray added the comment:
Ralf, thanks very much for this patch. I'm considering applying it. Given
that the current code breaks on parsing various legitimate constructs, it seems
like the behavior change (preserving whitespace in the non-EW parts...which IMO
is correct) shou
Changes by R. David Murray :
--
components: +email -Library (Lib)
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue13700>
___
___
Python-bugs-list m
Changes by R. David Murray :
--
components: +email -Library (Lib)
___
Python tracker
<http://bugs.python.org/issue14360>
___
___
Python-bugs-list mailin
Changes by R. David Murray :
--
components: +email -Library (Lib)
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue10839>
___
___
Python-bugs-list m
Changes by R. David Murray :
--
assignee: r.david.murray ->
components: +email
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue12037>
___
___
Py
4101 - 4200 of 10554 matches
Mail list logo
