[issue18937] add unittest assertion for logging

2013-09-06 Thread R. David Murray
R. David Murray added the comment: Exactly. It is the difference between black box testing and white box testing. IMO mock, while a great tool, should be used with caution, because it tends to lead to white box testing. -- ___ Python tracker

[issue5907] repr of time.struct_time type does not eval

2013-09-07 Thread R. David Murray
R. David Murray added the comment: It is very surprising that evaling the repr doesn't work, since struct_time is documented to have a named tuple interface, and evaling the repr for a namedtuple works. So hopefully fixing issue 1820 will also fix this. -- nosy: +r.david.m

[issue18963] test_selectors test_above_fd_setsize cases fail on OS X due to infinite hard limit

2013-09-07 Thread R. David Murray
R. David Murray added the comment: See also issue issue 17409. The code isn't setting it to RLIM_INFINITY explicitly, though, so this must mean that OSX is reporting an infinite hard limit when the hard limit is not in fact infinite. Seems like this is an OSX bug that we will have to

[issue18967] Find a less conflict prone approach to Misc/NEWS

2013-09-07 Thread R. David Murray
R. David Murray added the comment: For what it is worth, I haven't had a non-trivial merge conflict on Misc/NEWS for quite some time now. It seems to me that they are much rarer than they were with svn. (By 'trivial' I mean that the conflicts I see is that there's a n

[issue18967] Find a less conflict prone approach to Misc/NEWS

2013-09-07 Thread R. David Murray
R. David Murray added the comment: Then, again, I pretty much only do Library fixes. Maybe 'Core and builtins' fixes get messier because of the proximity of the date and version-specific header? That should be easy enough to fix --

[issue18967] Find a less conflict prone approach to Misc/NEWS

2013-09-08 Thread R. David Murray
R. David Murray added the comment: Were you changing something in core/builtins? I'm wondering if just making some same-between-versions space between the version header/date and the beginning of that section would be enough to solve 99% of the pro

[issue18829] csv produces confusing error message when passed a non-string delimiter

2013-09-08 Thread R. David Murray
R. David Murray added the comment: "delimiter must be a 1 character string" would cover it. -- ___ Python tracker <http://bugs.python.org/issue18829> ___ ___

[issue18829] csv produces confusing error message when passed a non-string delimiter

2013-09-08 Thread R. David Murray
R. David Murray added the comment: Parsing a csv file with no delimiter would seem to be meaningless, unless I'm misunderstanding what 'delimeter' controls. So the error messages for delimiter and quotechar are necessarily different. -- ___

[issue18973] Use argparse in the calendar module

2013-09-08 Thread R. David Murray
R. David Murray added the comment: I think it is highly inadvisable to make changes like this without also adding tests. We broke compileall by doing this even though we *did* add tests. -- nosy: +r.david.murray ___ Python tracker <h

[issue18975] timeit: Use thousands separators and print number of loops per second

2013-09-08 Thread R. David Murray
R. David Murray added the comment: I'm with Serhiy on this. So if separators are added, I would say they *must* be optional. Presumably if they are added they should be locale dependent :) All of which may well make it more complicated than it is worth. -- nosy: +r.david.m

[issue18975] timeit: Use thousands separators and print number of loops per second

2013-09-08 Thread R. David Murray
R. David Murray added the comment: I do not find a space to be an acceptable separator, sorry. -- ___ Python tracker <http://bugs.python.org/issue18975> ___ ___

[issue18986] Add a case-insensitive case-preserving dict

2013-09-09 Thread R. David Murray
R. David Murray added the comment: For the record, email is not a good argument for this, since email could not use this data structure (its data structure is *not* a dict, but a list with dict-like features grafted on). I do think this would be useful, and the generic version (analogous to

[issue18989] reuse of enum names in class creation inconsistent

2013-09-09 Thread R. David Murray
R. David Murray added the comment: As I recall this was discussed at length and we decided that this was the behavior we wanted. I could be wrong, of course; it was a long discussion. -- nosy: +r.david.murray ___ Python tracker <h

[issue18986] Add a case-insensitive case-preserving dict

2013-09-09 Thread R. David Murray
R. David Murray added the comment: coercekeydict -- ___ Python tracker <http://bugs.python.org/issue18986> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18986] Add a case-insensitive case-preserving dict

2013-09-09 Thread R. David Murray
R. David Murray added the comment: Indeed. Although there was apparently some call for it, it doesn't sound from a quick google like defaultdict was deemed to require a PEP. Presumably the informed audience should be wider than this issue, though. I also note that defaultdict is implem

[issue16564] email.generator.BytesGenerator fails with bytes payload

2013-09-10 Thread R. David Murray
R. David Murray added the comment: That's a different bug, and is probably due to the fact that \x0b is considered a line-ending character by the 'splitlines' method. Could you please open a new issue for this? It could be that this can't be fixed in Python3 until sup

[issue18967] Find a less conflict prone approach to Misc/NEWS

2013-09-11 Thread R. David Murray
R. David Murray added the comment: I agree with Antoine, but then as I said I don't run into huge merge conflicts very often. -- ___ Python tracker <http://bugs.python.org/is

[issue19002] ``dir`` function does not work correctly with classes.

2013-09-11 Thread R. David Murray
R. David Murray added the comment: As far as I know dir has always worked this way with classes (certainly back as far as 2.4, which is the oldest python I have on my dev system). So I doubt that this behavior can be open to change, whether or not we think the original decision was correct

[issue19004] datetime: Read in isoformat() output

2013-09-11 Thread R. David Murray
Changes by R. David Murray : -- resolution: -> duplicate stage: -> committed/rejected status: open -> closed superseder: -> datetime: add ability to parse RFC 3339 dates and times versions: +Python 3.4 -Python 3.3 ___ Python tr

[issue15873] datetime: add ability to parse RFC 3339 dates and times

2013-09-11 Thread R. David Murray
Changes by R. David Murray : -- nosy: +perey ___ Python tracker <http://bugs.python.org/issue15873> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19002] ``dir`` function does not work correctly with classes.

2013-09-11 Thread R. David Murray
R. David Murray added the comment: That's not how people use it at the interactive prompt, though. I call dir(str) to find what methods I can call on an str object, not what methods I can call on the str class object. Same goes for my own classes. Yes, I also call it on instances, b

[issue14611] inspect.getargs fails on some anonymous tuples

2012-04-18 Thread R. David Murray
R. David Murray added the comment: Formal parameter tuple unpacking was removed in Python3, so this is a Python2-only issue. Would you like to submit a patch for Python2? -- nosy: +r.david.murray priority: normal -> low stage: -> needs

[issue14612] Crash after modifying f_lineno

2012-04-18 Thread R. David Murray
R. David Murray added the comment: For reference, here is the crash: rdmurray@hey:~/python/p33>./python -m pdb script.py > /home/rdmurray/python/p33/script.py(1)() -> with open('test') as f: (Pdb) j 3 python: Objects/frameobject.c:207: frame_setlineno: Assertion `blocksta

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change

2012-04-18 Thread R. David Murray
R. David Murray added the comment: Someone needs to find time to review it. You could try recruiting reviewers on python-list. Anyone can do a review. Obviously the more knowledge they have in this area the better, but any good review is likely to move the issue along. -- nosy

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change

2012-04-18 Thread R. David Murray
R. David Murray added the comment: I see Alexander is going to take care of this. But to clarify what I suggested for your information: In an ideal world it would be a committer doing the patch review, followed by a checkin. But in the real world there aren't enough of us with enough

[issue14588] PEP 3115 compliant dynamic class creation

2012-04-19 Thread R. David Murray
Changes by R. David Murray : -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/issue14588> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue14627] Fatal Python Error when Python startup is interrupted by CTRL+c

2012-04-19 Thread R. David Murray
R. David Murray added the comment: I think Victor's point was that you get the "can't initialize standard streams" in addition to the KeyboardInterrupt (but I'm just guessing). (See issue 14228 for examples of what normally happens on a startup KeyboardInt

[issue14626] os module: use keyword-only arguments for dir_fd and nofollow to reduce function count

2012-04-19 Thread R. David Murray
R. David Murray added the comment: No, Guido's boolean keyword dislike is not about things being unclear at the call site. It's about boolean parameters instead of separate functions. That is (I believe) he prefers lstat/stat to having stat take a boolean keyword, keyword-only or

[issue14634] Mock cannot autospec functions with keyword-only arguments.

2012-04-20 Thread R. David Murray
New submission from R. David Murray : The following code: def foo(a, *, b=None): pass unittest.mock.create_autospec(foo) fails with this traceback: Traceback (most recent call last): File "temp.py", line 6, in unittest.mock.create_autospec(foo) F

[issue14636] Mock could check for exceptions in side effect list

2012-04-20 Thread R. David Murray
New submission from R. David Murray : I just spent an hour figuring out why my test was failing because I tried to do this: mymock.side_effect = (AuthenticationError, None) expecting the first call to raise an auth error and the second time it was called to get a normal return. Since

[issue7559] TestLoader.loadTestsFromName swallows import errors

2012-04-21 Thread R. David Murray
R. David Murray added the comment: Does fix for issue 1559549 (and the fact that importlib is in) allow for a cleaner fix for this? I've been putting off dealing with this issue in the expectation that it would. To answer the question: the fixed API can go in 3.3. If we fix this in ea

[issue1521950] shlex.split() does not tokenize like the shell

2012-04-21 Thread R. David Murray
R. David Murray added the comment: I'd like to take a look at this (I wasn't aware of it before). I'll try to do that some time in the next 24 hours, and if I don't you shouldn't wait for me :) Did you address Dan's concern about 'old' possibly n

[issue14645] Generator does not translate linesep characters in certain circumstances

2012-04-22 Thread R. David Murray
New submission from R. David Murray : I ran into this while translating a test, but it turns out it is a long standing problem. I presume it has not been an issue because in general in Python2 email messages are read as text with universal newline support, and thus the linesep characters get

[issue3177] Add shutil.open

2012-04-23 Thread R. David Murray
Changes by R. David Murray : -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/issue3177> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue3177] Add shutil.open

2012-04-23 Thread R. David Murray
R. David Murray added the comment: Is the error raising PEP 3151 compliant? -- ___ Python tracker <http://bugs.python.org/issue3177> ___ ___ Python-bugs-list m

[issue14596] struct.unpack memory leak

2012-04-23 Thread R. David Murray
R. David Murray added the comment: Other of our functions that do caching have been fixed so that the cache does not grow unbounded (usually by using lrucache, I think). IMO a cache that is unbounded by default is a bug. -- nosy: +r.david.murray

[issue14596] struct.unpack memory leak

2012-04-23 Thread R. David Murray
R. David Murray added the comment: If that is the case, then a doc footnote that a large repeat count will result in a large cache seems appropriate. Some way to control the max size of the cache would also be a reasonable enhancement request, at which point the cache size issue could be

[issue14648] Attempt to format ascii and non-ascii strings together fails with "... UCS2 ..."

2012-04-23 Thread R. David Murray
R. David Murray added the comment: I get this result on a debug build of default on linux: >>> "{0:s}{1:s}".format("ABC", "\u0410\u0411\u0412") python: Objects/unicodeobject.c:1223: _copy_characters: Assertion `ch <= to_maxchar' failed.

[issue1521950] shlex.split() does not tokenize like the shell

2012-04-23 Thread R. David Murray
R. David Murray added the comment: I am interested in shell stuff in general. The unicode bug is issue 1170. -- ___ Python tracker <http://bugs.python.org/issue1521

[issue3177] Add shutil.open

2012-04-23 Thread R. David Murray
R. David Murray added the comment: Launch is far better than open for this, I think. If someone can come up with an even better name, that would be good. But I would not like to use open for this function, because it does not behave like other open functions. The one exception I know of is

[issue14648] Attempt to format ascii and non-ascii strings together fails with "... UCS2 ..."

2012-04-23 Thread R. David Murray
R. David Murray added the comment: A test needs to be added for this. -- keywords: +easy priority: release blocker -> normal stage: committed/rejected -> test needed status: closed -> open ___ Python tracker <http://bugs.python.or

[issue14648] Attempt to format ascii and non-ascii strings together fails with "... UCS2 ..."

2012-04-23 Thread R. David Murray
R. David Murray added the comment: > What makes you think there isn't one? Poor eyesight? Sorry. -- ___ Python tracker <http://bugs.python.org

[issue3177] Add shutil.open

2012-04-23 Thread R. David Murray
R. David Murray added the comment: Initially this issue was about implementing a startfile-equivalent on posix. But if you have to add a gui option to startfile to not lanuch a GUI, and your real goal is a consistent way to launch non-gui programs on posix, then I don't see that th

[issue14635] telnetlib uses select instead of poll - limited to FD_SETSIZE fds

2012-04-23 Thread R. David Murray
R. David Murray added the comment: Éric: there are devices that still only allow telnet. Older cisco routers (*many* of which are still in the field) are just one example I'm familiar with. I don't currently have any tools that use telnetlib to talk to them, but I've got a

[issue14638] pydoc error on instance of a custom class

2012-04-23 Thread R. David Murray
Changes by R. David Murray : -- assignee: -> r.david.murray nosy: +r.david.murray stage: -> commit review ___ Python tracker <http://bugs.python.org/i

[issue14638] pydoc error on instance of a custom class

2012-04-23 Thread R. David Murray
R. David Murray added the comment: Thanks Peter. -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue14640] Typos in pyporting.rst

2012-04-23 Thread R. David Murray
R. David Murray added the comment: Thanks, Dionysios. -- nosy: +r.david.murray resolution: -> fixed stage: -> committed/rejected status: open -> closed type: -> behavior versions: +Python 3.2 ___ Python tracker <http://bugs.python

[issue3177] Add shutil.open

2012-04-23 Thread R. David Murray
R. David Murray added the comment: I'm not a lawyer (duh), but my understanding is that *looking* at GPL code (as opposed to proprietary code, where someone might sue you about it and not looking is a good defense) is OK, you just can'

[issue14655] traceback module docs should show how to print/fomat an exception object

2012-04-23 Thread R. David Murray
New submission from R. David Murray : Suppose you have an exception object acquired from somewhere. The exception is no longer active on the stack. Now you want to format the exception like format_exception would (to log it, perhaps). To do this you apparently need to call

[issue14655] traceback module docs should show how to print/fomat an exception object

2012-04-23 Thread R. David Murray
R. David Murray added the comment: Sounds OK to me, though I am worried others will think that kind of variable signature (where the type of the first argument depends on the number of arguments passed) is bad. -- ___ Python tracker <h

[issue1065986] Fix pydoc crashing on unicode strings

2012-04-24 Thread R. David Murray
R. David Murray added the comment: I don't think so. We aren't promising unicode support in pydoc in 2.x, and it is too late to add it. -- ___ Python tracker <http://bugs.python.org

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change

2012-04-24 Thread R. David Murray
R. David Murray added the comment: If you are satisfied with the time logic then yes, please apply it. I suspect that the number of people using the code and not aware of the problem (or not caring enough to do anything about it) exceeds the number aware of it who have coded a workaround

[issue1065986] Fix pydoc crashing on unicode strings

2012-04-24 Thread R. David Murray
R. David Murray added the comment: Hmm. Making it not raise an error while still producing useful output would be acceptable as a bug fix if that's all it takes, I think. -- status: closed -> open ___ Python tracker <http://bugs

[issue14653] Improve mktime_tz to use calendar.timegm instead of time.mktime

2012-04-24 Thread R. David Murray
R. David Murray added the comment: I think that what is going to happen is that both of these functions are going to be deprecated in favor of functions that use datetimes. That said, this might be a worthwhile as a bug fix. I'm adding Alexander as nosy to see what he thinks. (mktime_

[issue14663] Cannot comment out comments

2012-04-24 Thread R. David Murray
R. David Murray added the comment: A comment is a comment. *All* characters after the # are ignored, including other #s. Also, Python doesn't have multiline comments. (Well, you can use a triple quoted string as a multiline comment, but it is still a string, and follows the syntax

[issue14605] Make import machinery explicit

2012-04-24 Thread R. David Murray
R. David Murray added the comment: Hmm. Some at least of the buildbots have failed to build after that patch: ./python ./Python/freeze_importlib.py \ ./Lib/importlib/_bootstrap.py Python/importlib.h make: ./python: Command not found make: *** [Python/importlib.h] Error 127 program

[issue14670] subprocess.call with pipe character in argument

2012-04-25 Thread R. David Murray
R. David Murray added the comment: If shell is false, the pipe character is not special. -- nosy: +r.david.murray resolution: -> invalid stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue14670] subprocess.call with pipe character in argument

2012-04-25 Thread R. David Murray
R. David Murray added the comment: Oops, I typed too fact, and didn't notice that you were talking about windows. My point may still be valid, but I shouldn't be the one to close the issue since I don't know for sure for windows. -- nosy: +brian.curtin status:

[issue14670] subprocess.call with pipe character in argument

2012-04-25 Thread R. David Murray
Changes by R. David Murray : -- Removed message: http://bugs.python.org/msg159330 ___ Python tracker <http://bugs.python.org/issue14670> ___ ___ Python-bugs-list m

[issue14670] subprocess.call with pipe character in argument

2012-04-25 Thread R. David Murray
R. David Murray added the comment: Oops, I typed too fast, and didn't notice that you were talking about windows. My point may still be valid, but I shouldn't be the one to close the issue since I don't know for sure for windows. -- ___

[issue14670] subprocess.call with pipe character in argument

2012-04-25 Thread R. David Murray
R. David Murray added the comment: Ah, I thought I remembered seeing something about '|' in windows before, and I was right. It is only special to cmd.exe, which means it is only special when shell=True. See issue 1300 for a discussion. -- status: open

[issue8767] Configure: Cannot disable unicode

2012-04-26 Thread R. David Murray
R. David Murray added the comment: Reopening per this python-dev thread where MvL said that not being able to build 2.7 without unicode is a bug (but someone would need to care enough to contribute a patch to fix it). -- nosy: +r.david.murray priority: normal -> low stage: ->

[issue7185] csv reader utf-8 BOM error

2012-04-27 Thread R. David Murray
R. David Murray added the comment: Serhiy, the bug is about csv in particular. Can you confirm that using utf-8-sig allows one to process a file with a bom using the csv module? -- ___ Python tracker <http://bugs.python.org/issue7

[issue7185] csv reader utf-8 BOM error

2012-04-27 Thread R. David Murray
R. David Murray added the comment: I wasn't sure which script you were referring to, so I checked it myself and got the same results as you: after the seek(0) on the file object opened with utf-8-sig, csv read all the lines in the file, including reading the header line correctly. So,

[issue13698] Mailbox module should support other mbox formats in addition to mboxo

2012-04-29 Thread R. David Murray
R. David Murray added the comment: If that's really the only difference we might indeed be able to treat it as a bug fix. I'd have to look at a proposed patch to be sure. -- ___ Python tracker <http://bugs.python.o

[issue14700] Integer overflow in classic string formatting

2012-04-30 Thread R. David Murray
R. David Murray added the comment: Serhiy: FYI we use the versions field to indicate which versions the fix will be made in, not which versions the bug occurs in. Since only 2.7, 3.2, and 3.3 get bug fixes, I've changed the versions field to be just those three. (3.1 and 2.6 are sti

[issue14711] Remove os.stat_float_times

2012-05-03 Thread R. David Murray
R. David Murray added the comment: Victor proposed deprecating it as part of PEP 410 (see issue 13882), but the PEP was rejected for other reasons. -- nosy: +haypo, r.david.murray ___ Python tracker <http://bugs.python.org/issue14

[issue14726] Lib/email/*.py use an EMPTYSTRING global instead of ''

2012-05-04 Thread R. David Murray
R. David Murray added the comment: I've always wondered why the code did that. If Barry doesn't have a good reason for it, I'll refactor it at some point. -- assignee: -> r.david.murray nosy: +barry, r.david.murray typ

[issue14695] Tools/parser/unparse.py is out of date.

2012-05-04 Thread R. David Murray
R. David Murray added the comment: There is a test_tools file now. test_unparse could be called from it. -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/issue14

[issue14702] os.makedirs breaks under autofs directories

2012-05-04 Thread R. David Murray
R. David Murray added the comment: Hynek: it doesn't seem like that would work, since legitimate EPERM errors are much more likely. -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/is

[issue14726] Lib/email/*.py use an EMPTYSTRING global instead of ''

2012-05-05 Thread R. David Murray
R. David Murray added the comment: Good enough for me. I personally don't find it to be easier or harder to read with the names, so let's keep them. -- resolution: -> works for me stage: -> committed/rejected status: open -> closed ___

[issue14702] os.makedirs breaks under autofs directories

2012-05-05 Thread R. David Murray
R. David Murray added the comment: Hynek: you said "just like EEXIST", which doesn't check to see if the directory exists before continuing, thus my confusion. If mkdir -p does a stat first, then changing the makedirs algorithm to match is probably not a bad idea for OS compat

[issue14730] Implementation of the PEP 419: Protecting cleanup statements from interruptions

2012-05-05 Thread R. David Murray
Changes by R. David Murray : -- title: Implementation of the PEP 419 -> Implementation of the PEP 419: Protecting cleanup statements from interruptions ___ Python tracker <http://bugs.python.org/issu

[issue14731] Enhance Policy framework in preparation for adding "eamil6" policy as provisional

2012-05-05 Thread R. David Murray
New submission from R. David Murray : As discussed in my email to python-dev, I'm planning to add the new header parsing to Python 3.3 as a provisional extension, by adding a (set) of policies that are clearly marked provisional in the documentation. In order for this to work, I first

[issue14731] Enhance Policy framework in preparation for adding "eamil6" policy as provisional

2012-05-05 Thread R. David Murray
Changes by R. David Murray : -- keywords: +patch Added file: http://bugs.python.org/file25467/676f9c8c28c6.diff ___ Python tracker <http://bugs.python.org/issue14

[issue14731] Enhance Policy framework in preparation for adding email6 policies as provisional

2012-05-05 Thread R. David Murray
Changes by R. David Murray : -- title: Enhance Policy framework in preparation for adding "eamil6" policy as provisional -> Enhance Policy framework in preparation for adding email6 policies as provisional ___ Python t

[issue14734] Use binascii.b2a_qp/a2b_qp in email package header handling?

2012-05-05 Thread R. David Murray
New submission from R. David Murray : Currently the email package uses its own custom quoted printable encode/decode implementation for handling header quoted printable CTE encoding and decoding. It could be that using binascii would work, and be more performant. Or it might not be, but it

[issue14695] Tools/parser/unparse.py is out of date.

2012-05-06 Thread R. David Murray
R. David Murray added the comment: Since we are already doing path hackery in that test file to get things to run, I think your patch would be fine. If we grow more tests for the stuff in Tools (which would be good), we might want to consider reorganizing things, but for now I think that the

[issue14735] Version 3.2.3 IDLE CTRL-Z plus Carriage Return to end does not work

2012-05-06 Thread R. David Murray
R. David Murray added the comment: Making idle work with ctl-Z+enter might be reasonable. However, can you describe more fully the documentation that led you believe that would work? ctl-Z+enter is for the CMD window, not IDLE, to my understanding. -- nosy: +r.david.murray

[issue14740] get_payload(n, True) returns None

2012-05-07 Thread R. David Murray
R. David Murray added the comment: Thanks for the report and patch suggestion, but... This is actually the way it is designed to work. get_payload(i) returns the ith element of a multipart payload. Your workaround is in fact the correct way to do this operation. decode=True is documented

[issue14072] urlparse on tel: URI-s misses the scheme in some cases

2012-05-07 Thread R. David Murray
R. David Murray added the comment: See also issue 14036. -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/issue14072> ___ ___ Python-bug

[issue13815] tarfile.ExFileObject can't be wrapped using io.TextIOWrapper

2012-05-08 Thread R. David Murray
R. David Murray added the comment: Indeed, even though it is not a documented API, our backward compatibility policy pretty much requires that something named ExFileObject still exist, just in case. And in this case it probably should still be the thing returned. -- nosy

[issue14758] SMTPServer of smptd does not support binding to an IPv6 address

2012-05-08 Thread R. David Murray
R. David Murray added the comment: I don't think it is necessary to rewrite the existing tests, just add some that test the socket functionality. -- ___ Python tracker <http://bugs.python.org/is

[issue14759] Berkeley DB License conditions are onerous (and poorly documented)

2012-05-08 Thread R. David Murray
R. David Murray added the comment: Berkeley DB is no longer part of Python3, so I'm doubtful that this is going to be addressed. If it is addressed, it would have to be by the PSF rather than the developers, since the PSF is responsible for licensing issues. If you wish to pursue t

[issue14759] Is LICENSES.txt up to date?

2012-05-09 Thread R. David Murray
R. David Murray added the comment: The LICENSE.txt file is "just" the Python license, which has a rather convoluted history. Newer contributions are all under an Apache-style license from the individual contributors. My understanding (but I'm not a lawyer) is that ev

[issue13815] tarfile.ExFileObject can't be wrapped using io.TextIOWrapper

2012-05-09 Thread R. David Murray
R. David Murray added the comment: Yeah, I know it is technically private. We still tend to keep names around unless there's a good reason to delete them (like using them leads to broken code anyway). The code search is some evidence this deletion would be OK, but why *not* follow Ama

[issue14758] SMTPServer of smptd does not support binding to an IPv6 address

2012-05-09 Thread R. David Murray
R. David Murray added the comment: Well, that should be fixed anyway (a cleanup added that restores the original value). Then a new TestCase can test the socket stuff. -- ___ Python tracker <http://bugs.python.org/issue14

[issue13815] tarfile.ExFileObject can't be wrapped using io.TextIOWrapper

2012-05-09 Thread R. David Murray
R. David Murray added the comment: Code search is not proof, I'm afraid. It is evidence, though, and I thought I indicated I thought it was a good argument in favor of dropping the class. -- ___ Python tracker <http://bugs.python.org/is

[issue14766] Non-naive time comparison throws naive time error

2012-05-09 Thread R. David Murray
R. David Murray added the comment: An equivalent test using python 3.2's datetime.timezone works fine. Are you sure it isn't a bug in pytz? -- nosy: +belopolsky, r.david.murray ___ Python tracker <http://bugs.python.o

[issue14766] Non-naive time comparison throws naive time error

2012-05-09 Thread R. David Murray
R. David Murray added the comment: Ah. datetime.timezone wouldn't have that issue since it doesn't deal with DST. The 3.3 python version of datetime calls utcoffset in the same way as you describe, and it is supposed to have the same behavior as the C version, so probably 3.2/3

[issue14759] BSDDB license missing from liscense page in 2.7.

2012-05-09 Thread R. David Murray
R. David Murray added the comment: Ah, I see. No, the docs are correct, I'm the one who was mistaken. I thought the license page was on www.python.org, rather than docs.python.org. Developers *do* have full and easy access to docs.python.org, and we do track doc bugs here. As wit

[issue14759] BSDDB license missing from liscense page in 2.7.

2012-05-10 Thread R. David Murray
R. David Murray added the comment: Given the way Oracle is currently behaving, I personally think he is wise to delete it. It's optional at build-time anyway. -- ___ Python tracker <http://bugs.python.org/is

[issue13815] tarfile.ExFileObject can't be wrapped using io.TextIOWrapper

2012-05-10 Thread R. David Murray
R. David Murray added the comment: I don't think a doc change is needed. An isinstance check based on the docs will succeed, and the rest is an implementation detail, I think. -- ___ Python tracker <http://bugs.python.org/is

[issue14766] Non-naive time comparison throws naive time error

2012-05-10 Thread R. David Murray
R. David Murray added the comment: My, that's embarrassing. I somehow entirely missed the fact that we were dealing with times and not dates here. What you say makes sense to me, and the doc patch looks good. -- ___ Python tracker

[issue14796] Calendar module test coverage improved

2012-05-13 Thread R. David Murray
R. David Murray added the comment: Thanks for the patch. There are a couple of things I'd change, which I or someone could do while committing if you prefer, but if you'd like to tune up the patch yourself that would be great. The first is that I'd break up the tests that ru

[issue14781] Default to year 1 in strptime if year 0 has been specified

2012-05-14 Thread R. David Murray
R. David Murray added the comment: Datetime doesn't support BC. -- nosy: +r.david.murray resolution: -> invalid status: open -> closed ___ Python tracker <http://bugs.python.

[issue14782] Tab-completion of callables displays opening paren

2012-05-14 Thread R. David Murray
R. David Murray added the comment: It's issue 449227. -- nosy: +dieresys, facundobatista, georg.brandl, gpolo, pitrou, r.david.murray, rnd0110 ___ Python tracker <http://bugs.python.org/is

[issue14799] Tkinter ttk tests hang on linux

2012-05-14 Thread R. David Murray
R. David Murray added the comment: It does not hang for me on Gentoo. When I run the test suite before a checkin, I use -uall, and I've never had test_ttk hang for me. I did an 'hg pull; hg up' before running the command line you give below. -- nosy:

[issue14802] Python fails to compile with VC11 ARM configuration

2012-05-14 Thread R. David Murray
Changes by R. David Murray : -- title: Python 3.2 fail to compile with VC11 ARM configuration -> Python fails to compile with VC11 ARM configuration type: compile error -> enhancement versions: -Python 3.3 ___ Python tracker

[issue11959] smtpd cannot be used without affecting global state

2012-05-14 Thread R. David Murray
R. David Murray added the comment: I'm finally getting back around to this. If asyncore and asynchat are (mostly?) supporting an alternate socket map, why is it necessary to copy create_socket? Shouldn't we be fixing create_socket in asynco

<    36   37   38   39   40   41   42   43   44   45   >