[issue34157] NamedTemporaryFile can leave temporary files behind

2018-07-20 Thread R. David Murray
R. David Murray added the comment: Nick, what Jakub is saying is that 'with' hasn't even gotten involved yet: we're still executing the NamedTemporaryFile constructor, so the object hasn't been returned for 'with' to operate on yet. In other words, Nam

[issue34157] NamedTemporaryFile can leave temporary files behind

2018-07-20 Thread R. David Murray
Change by R. David Murray : -- resolution: duplicate -> stage: resolved -> needs patch status: closed -> open ___ Python tracker <https://bugs.python.or

[issue32663] SMTPUTF8SimTests are not actually being run

2018-07-25 Thread R. David Murray
R. David Murray added the comment: New changeset 48ed88a93bb0bbeaae9a4cfaa533e4edf13bcb51 by R. David Murray (chason) in branch 'master': bpo-32663 Make SMTPUTF8SimTests run (#5314) https://github.com/python/cpython/commit/48ed88a93bb0bbeaae9a4cfaa533e4edf13bcb51 -

[issue34220] Serialization of email message without header line length limit and a non-ASCII subject fails with TypeError

2018-07-25 Thread R. David Murray
R. David Murray added the comment: Thanks for the report. This is a duplicate of #33524. -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> non-ascii characters in headers causes TypeError on email.policy

[issue33524] non-ascii characters in headers causes TypeError on email.policy.Policy.fold

2018-07-25 Thread R. David Murray
Change by R. David Murray : -- nosy: +altvod versions: +Python 3.7, Python 3.8 -Python 3.6 ___ Python tracker <https://bugs.python.org/issue33524> ___ ___ Pytho

[issue32663] SMTPUTF8SimTests are not actually being run

2018-07-26 Thread R. David Murray
R. David Murray added the comment: New changeset 89352b08aad447d046551fa0cd374becd7941c91 by R. David Murray (Miss Islington (bot)) in branch '3.7': bpo-32663 Make SMTPUTF8SimTests run (GH-5314) (#8471) https://github.com/python/cpython/commit/89352b08aad447d046551fa0cd374b

[issue32663] SMTPUTF8SimTests are not actually being run

2018-07-26 Thread R. David Murray
R. David Murray added the comment: New changeset cecbe0ade87360cd37cc1389fe33dd92f2cf52ba by R. David Murray (Miss Islington (bot)) in branch '3.6': bpo-32663 Make SMTPUTF8SimTests run (GH-5314) (#8470) https://github.com/python/cpython/commit/cecbe0ade87360cd37cc1389fe33dd

[issue32663] SMTPUTF8SimTests are not actually being run

2018-07-26 Thread R. David Murray
R. David Murray added the comment: Thanks, Chason. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue32814] smtplib.send_message mishandles 8BITMIME RFC 6152

2018-07-26 Thread R. David Murray
R. David Murray added the comment: OK, the #32663 test fix I mentioned in the review is merged. -- versions: -Python 3.5 ___ Python tracker <https://bugs.python.org/issue32

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

2018-07-27 Thread R. David Murray
R. David Murray added the comment: Ah, sorry. we just modernized test_smtplib's __main__ section, and I think we lost the thread cleanup code that used to be run around the test suite. We need to add the thread cleanup decorators. -- nosy: +r.david.murray stage: -> nee

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

2018-07-27 Thread R. David Murray
R. David Murray added the comment: That's not the code I thought I merged. I'll have to take a look at what actually got merged. -- ___ Python tracker <https://bugs.python.o

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

2018-07-27 Thread R. David Murray
R. David Murray added the comment: That's due to another bug, which will get fixed by #32814, unless you'd like to generate a PR with the this fix in it (fixing the mutable default for smtp_options). -- ___ Python track

[issue34277] EmailPolicy not followed

2018-07-30 Thread R. David Murray
R. David Murray added the comment: I don't see you asserting utf8=True in your example, so I don't see what it has to do with the utf8 flag, since that is False by default. Maybe you are running up against the default value of refold_header, which

[issue34277] EmailPolicy not followed

2018-07-30 Thread R. David Murray
R. David Murray added the comment: You are indeed misunderstanding. The docs say: If False, follow RFC 5322, supporting non-ASCII characters in headers by encoding them as “encoded words”. If True, follow RFC 6532 and use utf-8 encoding for headers. Messages formatted in this way may be

[issue34277] EmailPolicy not followed

2018-07-30 Thread R. David Murray
R. David Murray added the comment: Well, it can't fold them and have them fit in the 78 character limit without adding whitespace that isn't in the original headers (unless there's a more subtle bug :) The email package has the possibility of having special behavior based

[issue24218] Also support SMTPUTF8 in smtplib's send_message method.

2018-07-31 Thread R. David Murray
R. David Murray added the comment: Well, posting on a closed issue is generally not the best way :) The current behavior with regards to the SMTPUTF8 flag is correct (it only matters for *addresses*, display names can already be transmitted if they contain non-ascii using non SMTPUTF8

[issue24255] Replace debuglevel-related logic with logging

2018-08-02 Thread R. David Murray
R. David Murray added the comment: Conrad: thanks for the effort, but using f-strings with logging is counterproductive. The idea behind logging is that the logged strings are not materialized unless something actually wants to output them. Using fstrings means you are doing all the work

[issue24255] Replace debuglevel-related logic with logging

2018-08-07 Thread R. David Murray
R. David Murray added the comment: We generally do not fix "linting errors" unless they reveal logic errors or we touch the lines of code for some other reason. We also follow the existing style of a module rather than any particular style guide (the stdlib modules are often olde

[issue34361] An error should be returned when there are spaces in between function name and parameters

2018-08-08 Thread R. David Murray
R. David Murray added the comment: Sorry, but ignoring that whitespace is part of the python language definition. At this point in time, whatever the merits of the "beginner" argument, it is not going to change, for backward compatibility reasons if nothing else. -

[issue34374] Shouldn't shutil.copyfile replace link in dst with follow_symlinks set?

2018-08-10 Thread R. David Murray
R. David Murray added the comment: It is following the model of the posix cp command, whose equivalent to 'follow_symlinks' only affects the source. -- nosy: +r.david.murray ___ Python tracker <https://bugs.python.o

[issue34375] Subtests (unittest)

2018-08-10 Thread R. David Murray
R. David Murray added the comment: https://docs.python.org/3/library/unittest.html#distinguishing-test-iterations-using-subtests -- nosy: +r.david.murray resolution: -> out of date stage: -> resolved status: open -> closed ___ Pytho

[issue24218] Also support SMTPUTF8 in smtplib's send_message method.

2018-08-15 Thread R. David Murray
R. David Murray added the comment: Sorry, I haven't had time to look at it yet :( Not sure when I will, things are more than a bit busy for me right now. Ping me again in two weeks if I haven't responded, please. The proposed solution sounds reasonable, though, so you could al

[issue24218] Also support SMTPUTF8 in smtplib's send_message method.

2018-08-17 Thread R. David Murray
R. David Murray added the comment: check out https://devguide.python.org. (Basically, banch and generate a PR on github). And please open a new issue for this. -- ___ Python tracker <https://bugs.python.org/issue24

[issue34464] There are inconsitencies in the treatment of True, False, None, and __debug__ keywords in the docs

2018-08-22 Thread R. David Murray
R. David Murray added the comment: I've removed 2.7 since those constants are not keywords in 2.7 (although None and __debug__ do raise syntax errors even in 2.7, they are not keywords there). Which is almost certainly why the docs treat them inconsistently (leftovers from before

[issue34659] Inconsistency between functools.reduce & itertools.accumulate

2018-09-13 Thread R. David Murray
R. David Murray added the comment: Presumably because conceptually an 'initial value' would be like adding an additional element on to the front of the iterable being passed as an argument, and itertools is all about operating on iterables. I'm not saying such an argume

[issue34694] Dismiss To Avoid Slave/Master wording cause it easier for non English spoken programmers

2018-09-19 Thread R. David Murray
Change by R. David Murray : -- nosy: -r.david.murray ___ Python tracker <https://bugs.python.org/issue34694> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34660] Replace ableist terms and pejoratives in source code.

2018-09-19 Thread R. David Murray
R. David Murray added the comment: > David and Brett: I consider part of the actions of the anonymous person using > the temporary aliases 25.45 and jonsees to be violations of our Code of > Conduct. I would therefore like you two to issue a warning, if not a ban. I am not inte

[issue34660] Replace ableist terms and pejoratives in source code.

2018-09-19 Thread R. David Murray
Change by R. David Murray : -- nosy: -r.david.murray ___ Python tracker <https://bugs.python.org/issue34660> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34800] email.contentmanager raises error when policy.max_line_length==None or 0

2018-09-25 Thread R. David Murray
R. David Murray added the comment: An unlimited line length would certainly satisfy the required minimum. As silane indicates, if max_line_length is 0 or None, the serializer is not supposed to wrap lines. (In fact one would like to have the option to control this separately for the

[issue21109] tarfile: Traversal attack vulnerability

2018-09-28 Thread R. David Murray
Change by R. David Murray : -- nosy: -r.david.murray ___ Python tracker <https://bugs.python.org/issue21109> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34881] unnecessary encoded-words usage breaks DKIM signatures

2018-10-03 Thread R. David Murray
R. David Murray added the comment: See also issue 34277 for a previous discussion. I thought I had included a header-level toggle for encoded words, but that doesn't actually make sense, since by default a header value is treated as unstructured (which means encoded words are allowed)

[issue34881] unnecessary encoded-words usage breaks DKIM signatures

2018-10-03 Thread R. David Murray
R. David Murray added the comment: You could also play with just making a parser that is a simplified version of get_unstructured, producing amaybe call it ASCIIOnlyUnstructuredTokenList...that would have as_ew_allowed set to False. That might not produce optimal results, but it would

[issue34954] Getting an email's subject is error-prone

2018-10-10 Thread R. David Murray
R. David Murray added the comment: Use the new email policies in python3. It handles all the decoding for you. I'm afraid you are on your own for python2. -- resolution: -> out of date stage: -> resolved status: open -> closed

[issue34954] Getting an email's subject is error-prone

2018-10-10 Thread R. David Murray
R. David Murray added the comment: The new policies *make* the email library that higher level library, that was pretty much the whole point :) I don't know how to make getting the fully decoded subject more intuitive than: msg['subject'] The fact that you have to spec

[issue34954] Getting an email's subject is error-prone

2018-10-11 Thread R. David Murray
R. David Murray added the comment: Can you demonstrate that policy.default and policy.SMTP produce a subject with newlines? If they do, that is a serious bug. Please don't reopen the issue. I'll reopen it if you convince me there is a bug :) The statement you suggest we

[issue34954] Getting an email's subject is error-prone

2018-10-11 Thread R. David Murray
R. David Murray added the comment: I'm guessing you got confused by the fact that the HTTP policy doesn't *add* new lines when *serializing*. If you can point to the part of the docs you read that produced that confusion, maybe we can

[issue35016] \r to match add into address header with not-ascii character

2018-10-18 Thread R. David Murray
R. David Murray added the comment: Thanks for the report and patch, but this is a duplicate of #34424. Your report prompted me to finally review the PR in that issue, though, so thanks twice :) -- resolution: -> duplicate stage: patch review -> resolved status: open -&g

[issue26441] email.charset: to_splittable and from_splittable are not there anymore!

2018-10-18 Thread R. David Murray
R. David Murray added the comment: New changeset 5be00247ae0de2e24dd14bbe4d9ca159434a1710 by R. David Murray (Braden Groom) in branch 'master': bpo-26441: Remove documentation for deleted to_splittable and from_splittable methods (#9865) https://github.com/python/cpyt

[issue26441] email.charset: to_splittable and from_splittable are not there anymore!

2018-10-18 Thread R. David Murray
R. David Murray added the comment: Thanks, Braden. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue31522] _mboxMMDF.get_string() fails to pass param to get_bytes()

2018-10-18 Thread R. David Murray
R. David Murray added the comment: New changeset d16f012f842e5719ff9fb90e217efc0f795853f2 by R. David Murray (Cheryl Sabella) in branch 'master': bpo-31522: mailbox.get_string: pass `from_` parameter to `get_bytes` (#9857) https://github.com/python/cpyt

[issue35057] Email header refolding adds additional \r in nested parse trees

2018-10-24 Thread R. David Murray
R. David Murray added the comment: Thank you for the report. This is a duplicate of #34424, which has a PR. -- resolution: -> duplicate stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue34424] Unicode names break email header

2018-10-24 Thread R. David Murray
R. David Murray added the comment: I've requested some small changes on the PR. If Jens doesn't respond in another week or so someone else could pick it up. -- ___ Python tracker <https://bugs.python.o

[issue34424] Unicode names break email header

2018-10-24 Thread R. David Murray
R. David Murray added the comment: Michael, if you could check if Jens patch fixes your problem I would appreciate it. -- nosy: +michael.thies ___ Python tracker <https://bugs.python.org/issue34

[issue35035] Documentation for email.utils is named email.util.rst

2018-10-26 Thread R. David Murray
R. David Murray added the comment: Sure, this is fine with me. -- ___ Python tracker <https://bugs.python.org/issue35035> ___ ___ Python-bugs-list mailin

[issue34155] email.utils.parseaddr mistakenly parse an email

2018-11-06 Thread R. David Murray
R. David Murray added the comment: >>> m = message_from_string("From: John Doe j...@example.com >>> \n\n", policy=default) >>> m['From'].addresses(Address(display_name='', username='John Doe jdoe', domain='example.

[issue34155] email.utils.parseaddr mistakenly parse an email

2018-11-06 Thread R. David Murray
R. David Murray added the comment: The formatting of that doctest paragraph got messed up. Let me try again: >>> m = message_from_string("From: John Doe j...@example.com \n\n", policy=default) >>> m['From'].addresses (Address(display_nam

[issue35222] email.utils.formataddr is not exactly the reverse of email.utils.parseaddr

2018-11-12 Thread R. David Murray
R. David Murray added the comment: Thanks for the report, but parseaddr and formataddr are defined *only* for ASCII. In the port to python3, parseaddr sort-of-maybe-sometimes does the naively expected thing with non-ascii, but that's just an accident. We could have added a check fo

[issue35222] email.utils.formataddr is not exactly the reverse of email.utils.parseaddr

2018-11-13 Thread R. David Murray
R. David Murray added the comment: Because the RFCs are defined only for ascii. Non-ascii in RFC 2822 addresses is an RFC violation. In python2 non-ascii would usually round-trip through these functions, but again that was an accident. If you'd like to propose a doc clarification

[issue35251] FTPHandler.ftp_open documentation error

2018-11-14 Thread R. David Murray
Change by R. David Murray : -- components: +Library (Lib) -email nosy: -barry, r.david.murray ___ Python tracker <https://bugs.python.org/issue35251> ___ ___

[issue27240] 'UnstructuredTokenList' object has no attribute '_fold_as_ew'

2018-11-17 Thread R. David Murray
R. David Murray added the comment: No. 3.5 is in security-fix-only mode. -- ___ Python tracker <https://bugs.python.org/issue27240> ___ ___ Python-bugs-list m

[issue8191] Make arg0 required argument in os.execl* functions

2013-05-26 Thread R. David Murray
R. David Murray added the comment: Mark, just asking that question doesn't really move the issue forward. Doing some research to see if there was any discussion on python-dev, and if not summarizing the issues and starting one, would be what could move the issue fo

[issue18067] In considering the current directory for importing modules, Python does not honour the output of os.getcwd()

2013-05-26 Thread R. David Murray
R. David Murray added the comment: This is a duplicate of issue 6386, which does contain an explanation of the behavior. -- nosy: +r.david.murray resolution: -> duplicate stage: -> committed/rejected status: open -> closed superseder: -> importing yields unexpected

[issue15392] Create a unittest framework for IDLE

2013-05-27 Thread R. David Murray
R. David Murray added the comment: Heh. Yeah, I use patch because I don't just work with mercurial/python, and I find the patch command simpler to use for applying patches in general, since I never want an autocommit. (The exception would be if I'm applying a patch that involve

[issue6386] importing yields unexpected results when initial script is a symbolic link

2013-05-27 Thread R. David Murray
R. David Murray added the comment: When a script is executed by python, it does *not* import from the CWD, it imports from the *location of the script*. From this, then, you can see that there are two possible interpretations of "the location of the script" when the script is a sy

[issue18074] argparse: Namespace can contain critical characters

2013-05-27 Thread R. David Murray
Changes by R. David Murray : -- superseder: -> argparse: positional arguments containing - in name not handled well ___ Python tracker <http://bugs.python.org/issu

[issue18081] test_logging failure in WarningsTest on buildbots

2013-05-28 Thread R. David Murray
New submission from R. David Murray: The following failure is showing up frequently in the buildbots. I haven't checked closely enough to be sure if it is a heisenberg, but I suspect it is, since it doesn't seem to be related to any of the recent changesets that would have been i

[issue18097] spam

2013-05-29 Thread R. David Murray
Changes by R. David Murray : Removed file: http://bugs.python.org/file30415/unnamed ___ Python tracker <http://bugs.python.org/issue18097> ___ ___ Python-bugs-list mailin

[issue18102] except-clause with own exception class inside generator can lead to confusing warning on termination

2013-05-30 Thread R. David Murray
R. David Murray added the comment: You are almost certainly correct. MyException can get set to None during interpreter shutdown. There are a couple of active issues and a PEP that address this type of problem, so this issue probably isn't needed, but I'll leave that up to Antoi

[issue18104] Idle: make human-mediated GUI tests usable

2013-05-30 Thread R. David Murray
R. David Murray added the comment: Since you *don't* want these to be autodiscovered by testing frameworks, perhaps h_test_.py would be a better naming scheme. -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/is

[issue18109] os.uname() crashes if hostname contains non-ascii characters

2013-05-31 Thread R. David Murray
R. David Murray added the comment: Issue 10097 may also have some relevant discussion, even though that issue originates from Windows. -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/issue18

[issue18111] Add a default argument to min & max

2013-05-31 Thread R. David Murray
R. David Murray added the comment: Issue 7153 and the discussions linked therefrom is presumably relevant here. Do you have a concrete use case? -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/issue18

[issue17973] FAQ entry for: '+=' on a list inside tuple both succeeds and raises an exception

2013-06-01 Thread R. David Murray
R. David Murray added the comment: I believe that summary is correct. -- ___ Python tracker <http://bugs.python.org/issue17973> ___ ___ Python-bugs-list mailin

[issue18111] Add a default argument to min & max

2013-06-01 Thread R. David Murray
R. David Murray added the comment: So you aren't really asking for a default, you are asking for a version of max/min that returns a sentinel instead of raising an error on an empty list. You could just write utility function that has a try/except in it. I'm not sure it is worth co

[issue18111] Add a default argument to min & max

2013-06-01 Thread R. David Murray
R. David Murray added the comment: I don't think there's any other way to get a ValueError out of min/max, but I haven't actually looked at the code to check. Of course, if we want people to rely on that, we'd need to document it. 'next's default is used to retu

[issue18111] Add a default argument to min & max

2013-06-02 Thread R. David Murray
R. David Murray added the comment: That's a good point about the __lt__. It occurred to me as well just before I read your post :). Raymond, do any other languages have an iterator protocol as a core language feature? It's the fact that it is in Python, and that it is not simp

[issue18111] Add a default argument to min & max

2013-06-02 Thread R. David Murray
R. David Murray added the comment: Oh, and I don't think Haskell counts, since you'd expect them to stick strictly to the mathematical definition, with no consideration of practicality :) Note that I'm not saying I'm +1 on adding this (I haven't decided), I'

[issue18118] curses utf8 output broken in Python2

2013-06-02 Thread R. David Murray
R. David Murray added the comment: I believe this is one of a class of bugs that are fixed in Python3, and that are unlikely to be fixed in Python2. I'll defer to Victor, though, who made a number of curses unicode fixes in Python3. -- nosy: +haypo, r.david.murray title: curses

[issue18121] antigravity leaks subprocess.Popen object

2013-06-02 Thread R. David Murray
R. David Murray added the comment: See also issue 5993. -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/issue18121> ___ ___ Python-bugs-list m

[issue18134] zipfile extractall accepts wrong password

2013-06-04 Thread R. David Murray
R. David Murray added the comment: This is a duplicate of issue 10876. According to that issue it is a bug in the zipfile format. -- nosy: +r.david.murray resolution: -> duplicate stage: -> committed/rejected status: open -> closed superseder: -> Zipfile sometimes consi

[issue18139] email module should have a way to prepend and insert headers

2013-06-05 Thread R. David Murray
R. David Murray added the comment: This is by design. I agree, however, that there should be a way to do this when an application needs it, so I'm changing this to a feature request. -- components: +email nosy: +barry, r.david.murray stage: -> needs patch title: email

[issue18141] tkinter.Image.__del__ can throw an exception if module globals are destroyed in the wrong order

2013-06-05 Thread R. David Murray
Changes by R. David Murray : -- nosy: +pitrou ___ Python tracker <http://bugs.python.org/issue18141> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18139] email module should have a way to prepend and insert headers

2013-06-05 Thread R. David Murray
R. David Murray added the comment: My preliminary thought (and I haven't checked the code yet to make sure this will actually work), is that under the new email policies we are dealing with full-blown header objects, meaning that they can know the header name they represent. This s

[issue18142] Tests fail on Mageia Linux Cauldron x86-64 with some configure flags

2013-06-05 Thread R. David Murray
R. David Murray added the comment: This is not the sort of bug report that is likely to get much action. Our tests pass normally (we have a buildbot fleet to ensure that they do before we cut a release), so it will be necessary to figure out why they are failing for your particular setup

[issue18146] Document miss, Stats objects has no method called "print_results"

2013-06-06 Thread R. David Murray
Changes by R. David Murray : -- resolution: -> duplicate stage: -> committed/rejected superseder: -> Example for Profile Module shows incorrect method ___ Python tracker <http://bugs.python.or

[issue11959] smtpd cannot be used without affecting global state

2013-06-06 Thread R. David Murray
R. David Murray added the comment: Looks good to me too. -- ___ Python tracker <http://bugs.python.org/issue11959> ___ ___ Python-bugs-list mailing list Unsub

[issue18153] python imaplib - error 'unexpected repsonse'

2013-06-06 Thread R. David Murray
R. David Murray added the comment: I think that technically the server is out of spec with the RFC. It isn't 100% clear, though since while the RFC says extra spaces are invalid, it also says that an untagged response is formed by "prefixing the token '*'", without o

[issue18116] getpass.unix_getpass() always fallback to sys.stdin

2013-06-07 Thread R. David Murray
R. David Murray added the comment: The test changes look correct to me, but it sure would be nice to come up with less fragile tests. For a function like this, though, it probably isn't possible. -- ___ Python tracker <http://bugs.py

[issue18155] csv.Sniffer.has_header doesn't escape characters used in regex

2013-06-07 Thread R. David Murray
R. David Murray added the comment: I doubt this is a regression, so I'm marking the others versions as well without actually testing it. Should be an easy fix. -- keywords: +easy nosy: +r.david.murray stage: -> needs patch versions: +Python 2.7, Py

[issue18159] ConfigParser getters not available on SectionProxy

2013-06-07 Thread R. David Murray
Changes by R. David Murray : -- nosy: +lukasz.langa ___ Python tracker <http://bugs.python.org/issue18159> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18163] Add a 'key' attribute to KeyError

2013-06-07 Thread R. David Murray
R. David Murray added the comment: I don't see how the fact that keys are immutable implies there are no GC issues. A tuple can be involved in a cycle, for example. -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/is

[issue18163] Add a 'key' attribute to KeyError

2013-06-07 Thread R. David Murray
R. David Murray added the comment: I'm arguing that the statement is false. I think that whether or not it should be a weakref in this and the other cases depends on whether you think an exception object should keep an object alive or not. It is fairly unlikely that a key would get i

[issue18053] Add checks for Misc/NEWS in make patchcheck

2013-06-08 Thread R. David Murray
R. David Murray added the comment: It's not about saving lines in the output, it's about saving space in the developer's brain/workflow efficiency. That said, it is only valuable if it is reasonably reliable. -- ___ Python

[issue18171] os.path.expanduser does not use the system encoding

2013-06-09 Thread R. David Murray
R. David Murray added the comment: I could not reproduce this error on Linux with python2.7. -- nosy: +haypo, r.david.murray ___ Python tracker <http://bugs.python.org/issue18

[issue18171] os.path.expanduser does not use the system encoding

2013-06-09 Thread R. David Murray
R. David Murray added the comment: Also, it would be helpful for you to show a full traceback, since there can be spurrious sources of unicode errors on Windows depending on how you execute your code. -- ___ Python tracker <http://bugs.python.

[issue18171] os.path.expanduser does not use the system encoding

2013-06-09 Thread R. David Murray
R. David Murray added the comment: On linux as well this fails: os.path.expanduser(u'~' + os.sep) But this works: os.path.expanduser('~' + os.sep) Counterintuitive, to say the least. The reason is that the value of the HOME environment variable is read as a byte s

[issue18171] os.path.expanduser does not use the system encoding

2013-06-09 Thread R. David Murray
Changes by R. David Murray : -- resolution: -> invalid status: open -> closed type: -> behavior ___ Python tracker <http://bugs.python.org/issue18171> ___ ___

[issue18022] Inconsistency between quopri.decodestring() and email.quoprimime.decode()

2013-06-09 Thread R. David Murray
R. David Murray added the comment: Most of the variations represent different invalid-input recovery choices. I believe binascii's decoding of b'= \n' is incorrect, as is its decoding of b'==41'. quopri's decoding of b'=\r' is arguably incorrect as wel

[issue18175] os.listdir(fd) leaks fd on error

2013-06-09 Thread R. David Murray
Changes by R. David Murray : -- nosy: +larry ___ Python tracker <http://bugs.python.org/issue18175> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18179] SMTP.local_hostname is undocumented

2013-06-10 Thread R. David Murray
R. David Murray added the comment: SMTP.local_hostname is probably a private attribute of the SMTP class, dating from before we started getting strict about having private attributes start with '_'. However, I see no reason to keep it private; we might as well just document it,

[issue18177] Typo in Documents

2013-06-10 Thread R. David Murray
R. David Murray added the comment: I presume that tex doesn't do quote-transformation on code blocks (it is not really smart quotes, since IIRC in tex you actually have to specify ` and ' in the correct places yourself). So perhaps the problem is that the function headers &

[issue18177] Incorect quote marks in code section-headers in PDF version of docs

2013-06-10 Thread R. David Murray
Changes by R. David Murray : -- title: Typo in Documents -> Incorect quote marks in code section-headers in PDF version of docs ___ Python tracker <http://bugs.python.org/issu

[issue18188] ERROR: test_no_optimize_flag on Mageia Linux Cauldron x86-64 with certain configure flags

2013-06-11 Thread R. David Murray
R. David Murray added the comment: This looks related to issue 14443, which was supposed to be fixed in 3.3.0. Can you do some of the same debugging that was done in that issue and see if it reveals any more about the problem? Also, I notice from that issue that Antoine was (is?) running

[issue18188] ERROR: test_no_optimize_flag on Mageia Linux Cauldron x86-64 with certain configure flags

2013-06-11 Thread R. David Murray
R. David Murray added the comment: Benjamin fixed the ftp error message, one commit after the 3.3.2 tag. Not sure if that is enough to make the test pass, though. So, it sounds like 18142 should be closed as "works for me"? That is, the remaining test failures are do to the p

[issue18188] ERROR: test_no_optimize_flag on Mageia Linux Cauldron x86-64 with certain configure flags

2013-06-11 Thread R. David Murray
R. David Murray added the comment: Given that we introduced the flag to support read-only file systems, I think one can argue that the test suite should support running on one. However, the right thing to do would be to set up a buildbot where that was true so that it doesn't get re-b

[issue18163] Add a 'key' attribute to KeyError

2013-06-11 Thread R. David Murray
R. David Murray added the comment: Making it unambiguous what piece of data is being retrieved, and allowing new code to have a more complex message than just 'Keyerror: ' and still be able to get at only the missing key. -- ___ Pyth

[issue18195] error when deep copying module is confusing

2013-06-11 Thread R. David Murray
R. David Murray added the comment: Well, we don't generally complicate the code to handle edge cases. That said, it might not be too complicated to add copy protocol methods to the module object which just raise a more useful error. -- nosy: +r.david.m

[issue18198] unittest discover should provide a way to define discovery at package level

2013-06-12 Thread R. David Murray
R. David Murray added the comment: The linked code does something different. I believe the title of this issue is incorrect for the implicitly suggested enhancement. I also suspect the suggested enhancement (to the extent that I understand it) is not ripe for stdlib inclusion, but I&#x

[issue18206] license url in site.py should always use X.Y.Z form of version number

2013-06-13 Thread R. David Murray
R. David Murray added the comment: For anyone who wants to work on this: the license URL is printed if only if the license file can't be found. -- keywords: +easy nosy: +r.david.murray stage: -> needs patch title: There is no license.html on www.python.org -> license url

[issue18217] Deprecate and remove gettext.install

2013-06-14 Thread R. David Murray
R. David Murray added the comment: How would you do dynamic switching of translation locale at runtime, then? -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/issue18

[issue18217] Deprecate and remove gettext.install

2013-06-14 Thread R. David Murray
R. David Murray added the comment: install says this: This installs the function _() in Python’s builtins namespace, based on domain, localedir, and codeset which are passed to the function translation() Unless I'm misunderstanding something, this means that the actual value of

<    32   33   34   35   36   37   38   39   40   41   >