[issue36893] email.headerregistry.Address blocks Unicode local part addr_spec accepted elsewhere

2019-05-12 Thread R. David Murray
R. David Murray added the comment: In order to legitimately have a non-ascii localpart, you *must* be using RFC6532 and RFC6531. In the email package you do this by using policy=SMTPUTF8, or setting utf8=True in your custom Policy. In smtplib you do this by specifying smtputf8 in the

[issue34424] Unicode names break email header

2019-05-13 Thread R. David Murray
R. David Murray added the comment: New changeset 45b2f8893c1b7ab3b3981a966f82e42beea82106 by R. David Murray (Jens Troeger) in branch 'master': bpo-34424: Handle different policy.linesep lengths correctly. (#8803) https://github.com/python/cpyt

[issue34424] Unicode names break email header

2019-05-13 Thread R. David Murray
R. David Murray added the comment: Approved and merged. Cheryl, can you shepherd this through the backport process, please? I'm contributing infrequently enough that I'm not even sure which version we are on :) -- ___ Python track

[issue36910] Certain Malformed email causes email.parser to throw AttributeError

2019-05-14 Thread R. David Murray
R. David Murray added the comment: Not a security issue, no. This isn't C where a stack overflow can give an attacker a vector for injecting arbitrary code. Per the Parser contract ("raise no exceptions, only register defects"), this should, as you say, re

[issue34424] Unicode names break email header

2019-05-14 Thread R. David Murray
R. David Murray added the comment: Thank you. I don't believe this is a security issue. -- ___ Python tracker <https://bugs.python.org/issue34424> ___ ___

[issue15115] Duplicated Content-Transfer-Encoding header when applying email.encoders

2018-01-15 Thread R. David Murray
R. David Murray added the comment: I believe so. For python3 I think it should only apply to the legacy API docs (you would use set_content (directly or indirectly) in python3, not set_payload). I've updated the versions. -- versions: +Python 3.6, Python 3.7 -Python 3.2, Pytho

[issue32573] sys.argv documentation should include caveat for embedded environments

2018-01-16 Thread R. David Murray
R. David Murray added the comment: A better question might be: is there something in the embedding framework that should initialize argv to the empty list? embedding framework here could have two meanings: either the third party code, or the code that we provide for supporting embedding

[issue32577] Pip creates entry point commands in the wrong place when invoked in a venv nested in a virtualenv

2018-01-17 Thread R. David Murray
R. David Murray added the comment: This is sounds like a variation on issue 30811. -- nosy: +r.david.murray ___ Python tracker <https://bugs.python.org/issue32

[issue30693] tarfile add uses random order

2018-01-17 Thread R. David Murray
R. David Murray added the comment: Given the reproducible builds angle, I'd say this was worth doing. -- nosy: +r.david.murray ___ Python tracker <https://bugs.python.org/is

[issue30693] tarfile add uses random order

2018-01-17 Thread R. David Murray
R. David Murray added the comment: Ah, I was just going to ask about that. I guess I'm -0 on the backport as well. The other reproducible build stuff is only going to land in 3.7. However, this is in a more general category than the pyc stuff, so I can see the argument for backporti

[issue32581] A bug of the write funtion of ConfigParser.py

2018-01-17 Thread R. David Murray
R. David Murray added the comment: Please provide a way to reproduce the problem you are observing. There is insufficient information here so far to understand the problem. -- nosy: +r.david.murray ___ Python tracker <https://bugs.python.

[issue32581] A bug of the write funtion of ConfigParser.py

2018-01-17 Thread R. David Murray
R. David Murray added the comment: I'll defer to Lukasz, but I don't believe this is a bug. An empty value and a value of "" are equivalent in config.ini syntax, as far as I know. -- nosy: +lukasz.langa ___ Python tracker <

[issue32590] Proposal: add an "ensure(arg)" builtin for parameter validation

2018-01-18 Thread R. David Murray
R. David Murray added the comment: I'm not clear why we want a bug tracker issue for something that is still only an idea. We generally *send* people to python-ideas when they propose half-baked ideas here :) (Not actually saying your idea is half-baked, but it clearly isn't f

[issue32594] File object 'name' attribute inconsistent type and not obviously documented

2018-01-18 Thread R. David Murray
R. David Murray added the comment: This has been discussed previously. The nature of the 'name' attribute for file objects is not really specified, so I'm not even sure what we would document. Maybe just that it is unspecified. -- nosy:

[issue32594] File object 'name' attribute inconsistent type and not obviously documented

2018-01-18 Thread R. David Murray
R. David Murray added the comment: I believe you are correct that it is too late to modify the existing behavior. Too many programs depend on it. As far as documenting, my point is that it is *not specified* what the name attribute contains. It can contain literally anything, depending on

[issue32601] PosixPathTest.test_expanduser fails in NixOS build sandbox

2018-01-19 Thread R. David Murray
Change by R. David Murray : -- nosy: +pitrou ___ Python tracker <https://bugs.python.org/issue32601> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25910] Fixing links in documentation

2018-01-20 Thread R. David Murray
R. David Murray added the comment: @guido: in roundup, by default anyone can change the issue title. I imagine he is a new user who just didn't understand that he was doing so. (And indeed, the account was created on 1/19). -- ___ Python tr

[issue32594] File object 'name' attribute inconsistent type and not obviously documented

2018-01-20 Thread R. David Murray
R. David Murray added the comment: Ah, yes. When I said "this has been discussed previously", that's the issue I was thinking of but couldn't find. -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> State clearly t

[issue32612] pathlib.(Pure)WindowsPaths can compare equal but refer to different files

2018-01-23 Thread R. David Murray
R. David Murray added the comment: Maybe we could at least mention the issue (and perhaps link to samefile) in the "General Properties" section? -- nosy: +r.david.murray ___ Python tracker <https://bugs.python.o

[issue32612] pathlib.(Pure)WindowsPaths can compare equal but refer to different files

2018-01-23 Thread R. David Murray
R. David Murray added the comment: Could WindowsPath (as opposed to PureWindowsPath) call samefile as part of the equality test? (I'm not familiar enough with pathlib to know if that is a nonsense question.) -- ___ Python tracker &

[issue27321] Email parser creates a message object that can't be flattened

2018-01-23 Thread R. David Murray
R. David Murray added the comment: Note: I reviewed this a while ago but the review comments haven't been addressed. -- ___ Python tracker <https://bugs.python.org/is

[issue32634] Message parsing fails where it has incompele headers

2018-01-23 Thread R. David Murray
R. David Murray added the comment: Yes, it is. -- stage: patch review -> resolved status: open -> closed type: crash -> behavior ___ Python tracker <https://bugs.python.or

[issue32655] File mode should be a constant

2018-01-24 Thread R. David Murray
R. David Murray added the comment: That isn't a bug. Python doesn't protect you from doing the wrong thing, in general. On the other hand, it might be a worthwhile improvement to make it read-only in this case. Especially since, as you point out, other seemingly similar attribut

[issue32657] Mutable Objects in SMTP send_message Signature

2018-01-25 Thread R. David Murray
R. David Murray added the comment: Chason: that does look like a bug. Mutable defaults are best to avoid, but if they are used read-only and not passed down further it isn't a problem. send_message was modeled on sendmail, and so copied it's use of defaults (which date from quite

[issue32669] cgitb file to print OSError exceptions

2018-01-25 Thread R. David Murray
R. David Murray added the comment: Yep, this one might get closed as "as designed", too ;) cgitb has to cope with something going wrong with trying to print out values, because there are a number of ways to break that in Python, not just the one you are pointing to. If you have

[issue32657] Mutable Objects in SMTP send_message Signature

2018-01-25 Thread R. David Murray
R. David Murray added the comment: On Thu, 25 Jan 2018 15:18:01 +, Steven D'Aprano wrote: > On Thu, Jan 25, 2018 at 02:28:17PM +0000, R. David Murray wrote: > The docstring for send_message does say > > If the sender or any of the recipient addresses contain non-AS

[issue32672] .then execution of actions following a future's completion

2018-01-25 Thread R. David Murray
R. David Murray added the comment: I think this requires a discussion on the python-ideas mailing list, since API changes to Future need consideration in the asyncio context as well. -- components: +Library (Lib) -Interpreter Core nosy: +r.david.murray type: -> enhancement versi

[issue32657] Mutable Objects in SMTP send_message Signature

2018-01-25 Thread R. David Murray
R. David Murray added the comment: It's probably enough to fix it. I fear that if we also change them in sendmail we'll break someone's code, but maybe we should do that anyway, for 3.7 only. -- versions: -Python 2.7, Python 3.4, Python

[issue32675] dict.__contains__(unhashable) raises TypeError where False was expected

2018-01-26 Thread R. David Murray
Change by R. David Murray : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue32683] isinstance is calling ob.__getattribute__ as a fallback instead of object.__class__.__get__

2018-01-26 Thread R. David Murray
R. David Murray added the comment: I don't think this is a bug. There are many ways to lie in Python. If your object lies, it is on your head when things break :) On the flip side, the ability to lie is very handy in many circumstances, and is often a case of duck typing rather than

[issue32684] asyncio.gather(..., return_exceptions=True) swallows cancellation

2018-01-26 Thread R. David Murray
R. David Murray added the comment: See also issue 26923, but I think this problem is different. -- nosy: +r.david.murray ___ Python tracker <https://bugs.python.org/issue32

[issue32606] Email Header Injection Protection Bypass

2018-01-27 Thread R. David Murray
R. David Murray added the comment: Yes. There's this thing called Postel's Law that says you should be generous in what you accept and careful in what you emit. So most MTAs and MUAs try very hard to guess what a non-RFC-compliant email is trying to say, which includes allow

[issue17305] IDNA2008 encoding missing

2018-01-28 Thread R. David Murray
R. David Murray added the comment: What we need for this issue is someone volunteering to writing the code. Given how long it has already been, I don't think anyone already on the core team is going to pick it up. -- ___ Python tracker &

[issue32700] spam?

2018-01-28 Thread R. David Murray
Change by R. David Murray : -- stage: -> resolved status: open -> closed title: The replys additional (Re.) is ok. -> spam? ___ Python tracker <https://bugs.python.or

[issue32712] Modifying a list/dict effects all variables sharing that address

2018-01-29 Thread R. David Murray
R. David Murray added the comment: Yep, that's the way Python works. You are modifying the same object through different names. Remember that in Python it is the objects that matter (which are identified in CPython via their memory address, but that's an implementation detail)

[issue27931] Email parse IndexError <""@wiarcom.com>

2018-01-29 Thread R. David Murray
R. David Murray added the comment: New changeset aa218d1649690d1c1ba86a9972f7fae646bf1a8f by R. David Murray (jayyyin) in branch 'master': bpo-27931: Fix email address header parsing error (#5329) https://github.com/python/cpython/commit/aa218d1649690d1c1ba86a9972f7fa

[issue27321] Email parser creates a message object that can't be flattened

2018-01-30 Thread R. David Murray
R. David Murray added the comment: Requested a small additional change to the new tests, and then this will be ready to go in. -- ___ Python tracker <https://bugs.python.org/issue27

[issue32727] smtplib's SMTP.send_message behaves differently with from_addr and to_addrs

2018-01-30 Thread R. David Murray
R. David Murray added the comment: Yes, that looks like a bug. Should be a one line bug fix, plus tests and news item if someone wants to make a PR... -- nosy: +r.david.murray ___ Python tracker <https://bugs.python.org/issue32

[issue32727] smtplib's SMTP.send_message behaves differently with from_addr and to_addrs

2018-01-30 Thread R. David Murray
R. David Murray added the comment: Yes, you'll have to write a test. Add a test after test_send_unicode_without_SMTPUTF8, but put the unicode in the name field of the 'from' address and test that it is accepted. You should be able to figure out how to check for success from

[issue19495] context manager for measuring duration of blocks of code

2018-01-30 Thread R. David Murray
R. David Murray added the comment: FWIW, we just ran in to the need for this on our project, and used 'Time' from the contexttimer package on pypi. In our use case we want the number so we can log it, and what we care about is the actual elapsed time, not a precise measurement o

[issue32727] smtplib's SMTP.send_message behaves differently with from_addr and to_addrs

2018-01-30 Thread R. David Murray
R. David Murray added the comment: The current test suite had better work fine without your new test, otherwise your fix broke something :) I will take a look. -- ___ Python tracker <https://bugs.python.org/issue32

[issue32727] smtplib's SMTP.send_message behaves differently with from_addr and to_addrs

2018-01-30 Thread R. David Murray
R. David Murray added the comment: We need a test that will fail without your fix. -- ___ Python tracker <https://bugs.python.org/issue32727> ___ ___ Python-bug

[issue32727] smtplib's SMTP.send_message behaves differently with from_addr and to_addrs

2018-01-30 Thread R. David Murray
R. David Murray added the comment: New changeset 8d83e4ba7823827bcbc119db887004d5c3a63dc6 by R. David Murray (Stéphane Wirtel) in branch 'master': bpo-32727: smtplib's SMTP.send_message behaves differently with from_addr and to_addrs (#5451) https://github.com/python

[issue32727] smtplib's SMTP.send_message behaves differently with from_addr and to_addrs

2018-01-31 Thread R. David Murray
R. David Murray added the comment: New changeset 85a92d00bd278022cc00fda6b124c06f614c5ebb by R. David Murray (Miss Islington (bot)) in branch '3.6': bpo-32727: smtplib's SMTP.send_message behaves differently with from_addr and to_addrs (GH-5451) (#5455) https://github.com

[issue32727] smtplib's SMTP.send_message behaves differently with from_addr and to_addrs

2018-01-31 Thread R. David Murray
R. David Murray added the comment: Thanks, Stéphane. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.4, Python 3.5 ___ Python tracker <https://bugs.python.or

[issue32572] Add the ftplib option, overrides the IP address.

2018-02-01 Thread R. David Murray
R. David Murray added the comment: I'd like confirmation from someone involved in maintaining the ftplib package that this is in fact the correct solution. -- nosy: +r.david.murray ___ Python tracker <https://bugs.python.org/is

[issue32572] Add the ftplib option, overrides the IP address.

2018-02-01 Thread R. David Murray
R. David Murray added the comment: I too wondered if pasv was the correct solution to the problem. -- ___ Python tracker <https://bugs.python.org/issue32

[issue20285] Improve object.__doc__ and help(object) output

2018-02-02 Thread R. David Murray
R. David Murray added the comment: If you want to be precise you could say "The last class in every __mro__ list." -- nosy: +r.david.murray ___ Python tracker <https://bugs.python.o

[issue32753] ssl.SSLError exceptions in test_poplib

2018-02-02 Thread R. David Murray
Change by R. David Murray : -- nosy: +christian.heimes ___ Python tracker <https://bugs.python.org/issue32753> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32753] ssl.SSLError exceptions in test_poplib

2018-02-02 Thread R. David Murray
Change by R. David Murray : -- nosy: +r.david.murray ___ Python tracker <https://bugs.python.org/issue32753> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32768] object.__new__ does not accept arguments if __bases__ is changed

2018-02-05 Thread R. David Murray
Change by R. David Murray : -- nosy: +r.david.murray ___ Python tracker <https://bugs.python.org/issue32768> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32774] distutils: cyclic reference in the documentation

2018-02-05 Thread R. David Murray
R. David Murray added the comment: This is a common pattern in our documentation. It is done because ":mod:`xxx`" means that xxx should be formatted as a module name, rather than anything else. While it is true that the formatting for most such references is currently the same, i

[issue31961] subprocess._execute_child doesn't accept a single PathLike argument for args

2018-02-06 Thread R. David Murray
R. David Murray added the comment: "I thought the case when args is a string and shell=False is deprecated." IMO it ought to be :) See issue 7839 for background. -- nosy: +r.david.murray ___ Python tracker <https://bugs.python.o

[issue32773] distutils should NOT preserve timestamps

2018-02-06 Thread R. David Murray
R. David Murray added the comment: That's the right thing in your opinion[*], but probably not in the opinion of others, thus the need for an option. There is also backward compatibility to be considered. -- nosy: +r.david.murray ___ P

[issue32773] distutils should NOT preserve timestamps

2018-02-06 Thread R. David Murray
R. David Murray added the comment: We have a strong backward compatibility policy, especially for distutils, so even though you can't imagine a use case I think we should keep the default the same. You could try lobbying the folks at pypa and see if they disagree with me, since the op

[issue32783] ln(2) isn't accurate in _math.c in cpython

2018-02-06 Thread R. David Murray
Change by R. David Murray : -- nosy: +mark.dickinson ___ Python tracker <https://bugs.python.org/issue32783> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32784] Wrong argument name for csv.DictReader in documentation

2018-02-06 Thread R. David Murray
R. David Murray added the comment: In the python3 docs it is given as 'f'. In the python2 docs, it is not. I suppose a doc backport was missed. -- nosy: +r.david.murray versions: -Python 3.5 ___ Python tracker <https://bu

[issue32784] Wrong argument name for csv.DictReader in documentation

2018-02-07 Thread R. David Murray
R. David Murray added the comment: Stéphane: I don't understand your question about changing the name of the parameter. As far as I can see the only thing to do here is backport the doc fix to 2.7. -- ___ Python tracker <https://bugs.py

[issue31937] Add the term "dunder" to the glossary

2018-02-07 Thread R. David Murray
R. David Murray added the comment: EAFP and BDFL are not python folk terminology (the former never was, the latter may have originated with us but it has widespread use). They are also acronyms. 'dunder' is the phonetic spelling of a way of pronouncing punctuation. Raymond

[issue32807] Add 'str' property to PathLib

2018-02-09 Thread R. David Murray
R. David Murray added the comment: This would not be a pythonic API. -- nosy: +r.david.murray resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue32807] Add 'str' property to PathLib

2018-02-09 Thread R. David Murray
R. David Murray added the comment: That was kind of an abrupt message, let me be more verbose: thank you for wanting to improve python, but as Serhiy pointed out we already solved the problem you are considering via PEP 519. In addition to that we consider str(x) to be the right way to get

[issue32158] Suppress (and other contextlib context managers) should work as decorators (where appropriate)

2018-02-09 Thread R. David Murray
R. David Murray added the comment: The designed use case of suppress is to cover a *single line* of python code. It should *not* be a decorator. -- nosy: +r.david.murray ___ Python tracker <https://bugs.python.org/issue32

[issue32769] Add 'annotations' to the glossary

2018-02-09 Thread R. David Murray
R. David Murray added the comment: PRs are for discussing proposed text/code. Discussion of whether or not to do this belongs here. (I have no opinion on this issue myself.) -- nosy: +r.david.murray ___ Python tracker <https://bugs.python.

[issue32755] Several cookies with the same name get intermixed

2018-02-10 Thread R. David Murray
R. David Murray added the comment: Well, "supersedes" sounds like all the old cookie values should be discarded, so I'd be inclined to call this a bug. On the other hand, programs could be (inadvertently, probably) depending on this behavior, so I'd also be inclined t

[issue32814] smtplib.send_message mishandles 8BITMIME RFC 6152

2018-02-10 Thread R. David Murray
R. David Murray added the comment: I agree. I'll be happy to review a patch proposal. Not sure how I overlooked this when I implemented send_message, but that was early enough in my reading of all the RFC that I may have just missed that d

[issue32817] MethodType ImportError, can't convert .py to .exe

2018-02-10 Thread R. David Murray
R. David Murray added the comment: PyInstaller is not part of the python standard library, you'll have to contact its community for help with this. -- nosy: +r.david.murray resolution: -> third party stage: -> resolved status: ope

[issue32828] compress "True if bool(x) else False" expressions

2018-02-12 Thread R. David Murray
R. David Murray added the comment: The one in generator.py should not be changed, it is clearer as written. I don't have a strong opinion on the others. -- nosy: +r.david.murray resolution: -> rejected stage: -> resolved status: ope

[issue32828] compress "True if bool(x) else False" expressions

2018-02-12 Thread R. David Murray
R. David Murray added the comment: Oops. I actually didn't intend to close this, but thinking about it I'm going to leave it closed. We generally don't do this kind of "tidy work" unless we are touching the code for other reasons. -- _

[issue32835] Add documention mentioning that Cygwin isn't fully compatible

2018-02-12 Thread R. David Murray
R. David Murray added the comment: We don't (can't) document everything we're *not* compatible with, we can only realisticly document what we support. I thought we did that, but all I can find at the moment is PEP 11, which you are correct, does not list cygwin as a no-l

[issue31562] snakebite.net is not available

2018-02-13 Thread R. David Murray
R. David Murray added the comment: There is a host dedicated to providing test infrastructure. I forget the name. Benjamin has done things with it in the past. -- nosy: +benjamin.peterson, r.david.murray ___ Python tracker <ht

[issue32848] Valgrind error with python

2018-02-15 Thread R. David Murray
R. David Murray added the comment: Did you notice that our configure has a --with-valgrind option? In any case, there isn't a bug in python here that you are reporting. If you want to continue to learn about our existing support for valgrind and find things that can be improved, yo

[issue32851] Complete your registration to Python tracker -- key uxOb1XizINE32OvAnH7tUiKMx4tFqGdK

2018-02-15 Thread R. David Murray
Change by R. David Murray : -- Removed message: https://bugs.python.org/msg312212 ___ Python tracker <https://bugs.python.org/issue32851> ___ ___ Python-bug

[issue32851] mistake

2018-02-15 Thread R. David Murray
Change by R. David Murray : -- resolution: -> not a bug stage: -> resolved status: open -> closed title: Complete your registration to Python tracker -- key uxOb1XizINE32OvAnH7tUiKMx4tFqGdK -> mistake ___ Python tracker <https://

[issue32884] Adding the ability for getpass to print asterisks when passowrd is typed

2018-02-24 Thread R. David Murray
R. David Murray added the comment: getpass is emulating the unix password prompt behavior. I'm not sure if the complication is worth it, especially since not echoing asterisks is, as you observe, fractionally more secure. So I guess I'm about -.5 on this feature. -

[issue32886] new Boolean ABC in numbers module

2018-02-24 Thread R. David Murray
Change by R. David Murray : -- nosy: +r.david.murray ___ Python tracker <https://bugs.python.org/issue32886> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32972] unittest.TestCase coroutine support

2018-02-28 Thread R. David Murray
R. David Murray added the comment: In order for this to be actually useful, I think we also need a mechanism to set up and run async cleanup methods. In my own project I accomplish this by putting the run_until_complete in a try/finally loop and have an asyncAddCleanup method that just

[issue32975] mailbox: It would be nice to move mailbox.Message from legacy email.message.Message API to new EmailMessage API

2018-03-01 Thread R. David Murray
R. David Murray added the comment: This is a reasonable request (a good way to use EmailMessage), but EmailMessage is not yet the default even for the email package. You have to specify policy=default to get it (or use it to construct a message). Mailbox probably needs some backward

[issue32919] csv.reader() to support QUOTE_ALL

2018-03-03 Thread R. David Murray
R. David Murray added the comment: QUOTE_ALL only makes sense as an output control parameter, IMO. It is an output discipline but doesn't say anything about semantics. In csv format, an empty field and a field containing the empty quoted string are completely equivalent. I would be

[issue32921] .pth files cannot contain folders with utf-8 names

2018-03-04 Thread R. David Murray
Change by R. David Murray : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker <https://bugs.python.org/issue32

[issue32972] unittest.TestCase coroutine support

2018-03-07 Thread R. David Murray
R. David Murray added the comment: I agree with what Zach said in msg313352. I don't see how having a separate class affects the problem of what to use to run an async def test case. If "an AsyncTestCase should be enough" but "other frameworks will require a differ

[issue32971] Docs on unittest.TestCase.assertRaises() should clarify context manager details

2018-03-11 Thread R. David Murray
R. David Murray added the comment: The implementation is literally that no non-keyword arguments other than the exception are given. If any keyword arguments other than msg are given, you get a warning. To say just "no callable" would be about as confusing as the 'and poss

[issue32982] Parse out invisible Unicode characters?

2018-03-11 Thread R. David Murray
R. David Murray added the comment: I think it sounds like a good idea to put the printed representation as a repered string, followed by the code point representation in parenthesis, in that message after "invalid character". -- nosy: +r.da

[issue32985] subprocess.Popen: Confusing documentation for restore_signals

2018-03-11 Thread R. David Murray
R. David Murray added the comment: Well, I imagine the original author thought of "python" as python itself, not the user's python program. That's certainly how I understood it when I read it in your message. It would not be a bad thing to clarify that, thou

[issue32829] Lib/ be more pythonic

2018-03-17 Thread R. David Murray
R. David Murray added the comment: The risk of introducing a bug is higher than the minimal benefit of making the changes. Thus we do not typically accept changes like this. We'll clean up such code when we touching it for other reasons. -- nosy: +r.david.murray resol

[issue32958] socket module calls with long host names can fail with idna codec error

2018-03-17 Thread R. David Murray
Change by R. David Murray : -- nosy: +r.david.murray ___ Python tracker <https://bugs.python.org/issue32958> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33014] Clarify str.isidentifier docstring; fix keyword.iskeyword docstring

2018-03-17 Thread R. David Murray
R. David Murray added the comment: For the original report that this issue was opened for: Use keyword.iskeyword() to test for reserved identifiers such as "def" and "class". The obvious replacement is: Use the iskeyword() function from the keyword module

[issue33017] Special set-cookie setting will bypass Cookielib

2018-03-18 Thread R. David Murray
R. David Murray added the comment: Can you explain what you think the problem is? I don't know what your "POC" snippets are trying to demonstrate. -- nosy: +r.david.murray ___ Python tracker <https://bugs.pyt

[issue23434] support encoded filename in Content-Disposition for HTTP in cgi.FieldStorage

2018-03-22 Thread R. David Murray
R. David Murray added the comment: I haven't read the http rfcs, but my understanding is that they follow the MIME standards, and the email library already has code to do proper parsing and decoding of encoded filenames in Content-Disposition headers. It should be possible to call that

[issue33014] Clarify str.isidentifier docstring; fix keyword.iskeyword docstring

2018-03-27 Thread R. David Murray
R. David Murray added the comment: I think my wording would be an improvement to the docs as well. You could link just the keyword function if you are worried about too many links, since that would keep the link count the same. -- ___ Python

[issue33156] Use super().method instead in email classes.

2018-03-27 Thread R. David Murray
R. David Murray added the comment: Thank you for wanting to improve Python, but unless this is actually causing a problem for someone, there is a greater chance of introducing a bug by making such changes than the benefit of the "cleanup". So we generally don't accept such

[issue33274] minidom removeAttributeNode returns None

2018-04-26 Thread R. David Murray
R. David Murray added the comment: The rule in Python is that when a function mutates its argument it does *not* return a pointer to the object it just mutated, and likewise a method does *not* return a pointer to the parent object. Usually this means a mutating function/method return None

[issue33395] TypeError: unhashable type: 'instancemethod'

2018-04-30 Thread R. David Murray
R. David Murray added the comment: The non-hashable case should be handled by a default function, I would think. It should be fairly straightforward to come up with a reproducer that does not involve cython, which I think would be the first step. -- nosy: +r.david.murray

[issue33395] TypeError: unhashable type: 'instancemethod'

2018-05-01 Thread R. David Murray
R. David Murray added the comment: Ah, in the absence of a traceback I think I misunderstood the problem (I failed to actually look at the code :) Given what you say about the slotwrapper, I'm not sure, but I'm guessing that that means cython isn't using the PyInstanceMethod_T

[issue33395] TypeError: unhashable type: 'instancemethod'

2018-05-01 Thread R. David Murray
R. David Murray added the comment: Functions/methods should be immutable, so yes, I think it is a safe assumption that they should be hashable, and a bug if they are not. I seem to vaguely recall that there is some other part of the cpython machinery that depend on being able to test

[issue33402] Change the fractions.Fraction class to convert to a unicode fraction string

2018-05-01 Thread R. David Murray
R. David Murray added the comment: I vote -1. It's cute, but I'd much rather have a consistently ascii representation of something that is easily represented in ascii. -- nosy: +r.david.murray ___ Python tracker <https://bu

[issue33436] Add an interactive shell for Sqlite3

2018-05-07 Thread R. David Murray
R. David Murray added the comment: It's not immediately obvious what benefits this provides over the existing sqlite-native repl and the python repl. Can you expand a bit on the use case? Also, I seem to remember that Catherine Devlin had at one point thought about expanding her sqlp

[issue33449] Documentation for email.charset confusing about the location of constants

2018-05-10 Thread R. David Murray
R. David Murray added the comment: Can you provide an example of where this occurs in the docs? -- nosy: +r.david.murray ___ Python tracker <https://bugs.python.org/issue33

[issue33449] Documentation for email.charset confusing about the location of constants

2018-05-10 Thread R. David Murray
R. David Murray added the comment: Ah, I see. Yes, those strings are actually hardcoded in the documentation source instead of being references. You are correct, they should be fixed. Note, however, that Charset is part of the legacy API and isn't actually used if you use the new A

[issue33459] Define "tuple display" in the docs

2018-05-10 Thread R. David Murray
R. David Murray added the comment: Nope, a tuple display is not equal to a parenthesized list. For example, in: x = 1, 2, 3 1, 2, 3 is a tuple display. The parenthesis are optional in that case (in the general case it is the comma that makes the tuple, not the parens). However, as far

[issue33459] Define "tuple display" in the docs

2018-05-11 Thread R. David Murray
R. David Murray added the comment: That's a generator expression, just like [x for x in ramge(3)] is a list comprehension, not a list display. And yes, in a number of circumstances parenthesis are required to delimit the tuple display and disambiguate the syntax. That is, it is the 1,

<    28   29   30   31   32   33   34   35   36   37   >