R. David Murray added the comment:
I think the module should be reviewed and made consistent, as Antoine did for
nntplib. I don't know enough about the IMAP protocol to do such a review, or
even weigh in meaningfully on the immediate question, nor am I likely to have
time to learn e
R. David Murray added the comment:
Well, we recently added support for parsing binary data streams to the email
module (or added back, if you are looking at it from a python2 perspective),
exactly because "in the wild" headers are not always RFC compliant ASCII, and
because bodies
R. David Murray added the comment:
> 4. The explicit-vs-implicit is about the contract defined in the spec (making
> explicit what, precisely, is required of both parties), not the type test.
Perhaps a clarification in the () spec that 'type str' means "type(s) is
s
R. David Murray added the comment:
How is this different from issue 2409?
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue10966>
___
___
R. David Murray added the comment:
On second reading I see one way it is different: you suggest to move the list
of expected skips out of regrtest. So, are you suggesting, essentially, that
support.import_module be replaced by an optional_import that takes arguments to
indicate on which
R. David Murray added the comment:
I think we have already been moving in this director for quite some time. Past
policy is to only change things when we are working on that area of code
anyway. If someone wants to make some specific proposals to simplify regrtest
by doing a wholesale move
R. David Murray added the comment:
I think we have already been moving in this direction for quite some time.
Past policy is to only change things when we are working on that area of code
anyway. If someone wants to make some specific proposals to simplify regrtest
by doing a wholesale
Changes by R. David Murray :
--
Removed message: http://bugs.python.org/msg126780
___
Python tracker
<http://bugs.python.org/issue10967>
___
___
Python-bugs-list m
R. David Murray added the comment:
Hmm. According to issue 4136, all bytes support was supposed to have been
removed.
--
nosy: +pitrou, r.david.murray
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
Ah, I see what you are getting at now. I was confused by the "raise SkipTest
directly" part, since the test suite currently does raise SkipTest instead of
ImportError. So the key change here is to make the test show as a *failure* on
those platf
Changes by R. David Murray :
--
nosy: +loewis
___
Python tracker
<http://bugs.python.org/issue10943>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by R. David Murray :
--
nosy: +vinay.sajip
___
Python tracker
<http://bugs.python.org/issue10949>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
I almost closed this as invalid, since the name is, after all 'os.stat' and the
docs clearly say that it calls the 'stat' system call. However, I see that our
docs do not contain the more explicit language used by the 'stat'
R. David Murray added the comment:
See also issue 5831. That should probably be closed as a dup of this since
this has an explanation.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
Newline='' is indeed needed. It preserves the newlines so that the csv module
can correctly parse them according to the weird csv quoting roles. And for
output, the fact that it isn't documented there is a an issue that was only
n
Changes by R. David Murray :
--
nosy: +michael.foord
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue10979>
___
___
Python-bugs-list mai
R. David Murray added the comment:
I also would put increasing test coverage at a higher priority, but this sort
of refactoring can be a good step in the development path of new contributors,
and doing it does decrease the future maintenance burden
R. David Murray added the comment:
Rather than doing a code deprecation you can just do 'from shlex import quote'
in pipes (with a comment about backward compatibility). I don't think there is
any real harm in leaving that kind of backward compatibility in plac
Changes by R. David Murray :
--
nosy: +bethard
___
Python tracker
<http://bugs.python.org/issue10984>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
I don't think Georg considers it a bug in Sphinx, it's just how the
disambiguation machinery works. You can write :func:`~os.stat` if you want the
link text to just be 'stat' but the link to be to 'os.stat'.
I don't th
R. David Murray added the comment:
The API change would be generating an error if newline='' wasn't specified.
Amplifying the bytes-case error message would be fine, though. On the other
hand, we are in RC phase, and I'm not at all sure this is important enough to
go
R. David Murray added the comment:
Issue 9124 addresses the underlying problem here, so I'm closing this as a
duplicate.
--
nosy: +r.david.murray
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
superseder: -> Mailbox module should us
R. David Murray added the comment:
Please keep new tests for existing features and new features in separate
issues. A proposed code refactoring should also be a separate issue.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.
R. David Murray added the comment:
Yes, I know you have to do it anyway, that's why I used the adverb 'just' (as
in 'just that, and nothing more') (I note that 'just' as an adverb tends to
get overused by English speakers, and
Changes by R. David Murray :
--
assignee: docs@python -> r.david.murray
___
Python tracker
<http://bugs.python.org/issue10960>
___
___
Python-bugs-list mai
R. David Murray added the comment:
Thanks.
Committed a modified version of the patch in r88164. I extended your breakout
of the attributes to the other paragraphs, and reorganized the order of the
paragraphs in the stat docs to put things into a more logical order (I hope).
I decided to
New submission from R. David Murray :
Title pretty much says it all. The constants are there in the stat module, but
they aren't documented. When they are documented the mentions in the
os.chflags entry can be turned into cross reference links.
--
assignee: docs@python
mes
R. David Murray added the comment:
What about putting the addition option details in the epilog?
--
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
That might be handy. I thought you were trying to roughly reproduce the
current help (which dumps it all out at once), which is why I suggested epilog.
--
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
The text in the docstrings appears to be accurate, and it seems to me they
clarify it even more than your suggested changes do. Also, I think
SimpleCookie's encode/decode roughly implements some RFC or another (though
there are some tweaks), and it
R. David Murray added the comment:
anthony: this is python3-only problem.
--
___
Python tracker
<http://bugs.python.org/issue10976>
___
___
Python-bugs-list m
R. David Murray added the comment:
I'm afraid so. The python3 uptake process was expected to take five years
overall, and we are only up to about the second year at this point. So while
you may have been away from Python for 6 years, you came back right in the
middle of an unpreced
R. David Murray added the comment:
That should have been "too late to make API changes for 3.2".
--
___
Python tracker
<http://bugs.python.org/issue9124>
___
__
R. David Murray added the comment:
Hmm. Am I misunderstanding something about epilog, then? I thought it was
placed at the end of the other help text?
--
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
I would say writing tests for regrtest is going to be a somewhat tricky task.
I think you will have to do some code tweaking to even be able to run certain
tests. I believe that regrtest currently has some built in assumptions about
the test directory (ie
R. David Murray added the comment:
Thanks, Victor, you beat me to it :) I'll see if I can review this tomorrow,
or if not I can probably do it Thursday.
I reverted r88197 because it was incorrect and caused an email test to fail.
Once I come up with a test for it I'll fix it cor
R. David Murray added the comment:
Haypo: yeah, in an ideal world Generator would use get_payload() and not
_payload, but I had to make some compromises with purity of model separation in
order to achieve the practical goal of handling bytes usefully. I'd like to
fix that as I work on
New submission from R. David Murray :
This was discovered by Haypo during work on #9124. I'll attach a patch with
test shortly.
--
assignee: r.david.murray
messages: 127139
nosy: r.david.murray
priority: high
severity: normal
stage: commit review
status: open
title: BytesGene
R. David Murray added the comment:
Here's the patch and test.
--
___
Python tracker
<http://bugs.python.org/issue11019>
___
___
Python-bugs-list m
R. David Murray added the comment:
OK, so let's try again, since roundup saw fit to clear the upload field on me...
--
Added file: http://bugs.python.org/file20537/bytes_generator_none_body.patch
___
Python tracker
<http://bugs.py
R. David Murray added the comment:
Committed in r88203.
--
resolution: -> fixed
stage: commit review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
I would open three new bugs to address the issues you raise. It ought to be
possible to rename things so that we can eliminate the pre-population of
NOTTESTS (if not I'd like to know why not!). STDTESTS appear to move certain
tests to the front, pos
R. David Murray added the comment:
As long as we are modifying that code, how about fixing the use of 'dict' as a
variable name? Alternative patch attached.
--
nosy: +r.david.murray
Added file: http://bugs.python.org/file20544/pyc
R. David Murray added the comment:
One fix or the other ought to go in, IMO.
--
___
Python tracker
<http://bugs.python.org/issue11020>
___
___
Python-bugs-list m
R. David Murray added the comment:
For the record, can you point to the relevant part of the relevant RFC?
--
assignee: -> r.david.murray
nosy: +r.david.murray
stage: -> needs patch
versions: +Python 3.1, Python 3.2 -Python 2.6
___
Python t
R. David Murray added the comment:
I haven't looked at the items Haypo has pointed to yet, but I have looked at
the API issues (get_string, add, etc). It seems to me that we have to make a
decision here: do we break API backward compatibility and convert to consuming
and emitting
R. David Murray added the comment:
I wasn't around when that decision was made, but looking at the posixmodule.c
source, system is a straightforward wrapper, but popen gets...byzantine on
anything but unix.
--
nosy: +r.david.murray
___
P
R. David Murray added the comment:
09 is still an invalid token in python3. Since int('09') works in python2 it
might be worth looking in to this further.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.o
R. David Murray added the comment:
Well, it is certainly intentional, then. Whether it is good is a different
story, but also a moot question since optparse has been replaced by argparse.
--
___
Python tracker
<http://bugs.python.org/issue11
Changes by R. David Murray :
--
nosy: +r.david.murray
stage: -> needs patch
versions: +Python 2.7, Python 3.1, Python 3.2 -3rd party
___
Python tracker
<http://bugs.python.org/issu
R. David Murray added the comment:
A feature request can only go in to 3.3 at this point. ConfigParser has had a
serious overhaul in 3.2, by the way.
--
assignee: -> lukasz.langa
nosy: +lukasz.langa, r.david.murray
versions: +Python 3.3 -Python
R. David Murray added the comment:
Well, there's still a backward compatibility issue: if this is changed,
currently working code may break. Maybe Lukasz or Fred will have a guess as to
how likely that is, because I don't.
--
nos
R. David Murray added the comment:
I would say so, otherwise how are you going to run the tests you write :)
As for the other issue...I hadn't counted one for --testdir, but making that a
new issue was a good idea. So the other two I had in mind was for STDTESTS and
NOTTESTS. I still
R. David Murray added the comment:
Attached is a patch that builds on Victor's patch, but takes the approach I
discussed of maintaining backward compatibility (for the most part; see below).
The test suite in this version is substantially unchanged. The major changes
are adding test
R. David Murray added the comment:
Steffen: thanks for testing. Do those error messages have tracebacks? Can you
post them? Can you post example messages and a short program that demonstrates
the problem? I'm going to be creating some non-ascii test cases, but any
additional info yo
R. David Murray added the comment:
The OSX build process is...hairy. Windows likewise (because you have to use MS
tools). Elsewhere, it is pretty straightforward :)
The 10.4 deployment target is the one we want. You can build for a 10.4
deployment target even if you are using a later SDK
R. David Murray added the comment:
I don't see those error messages in the mailbox source. I'm guess your
application isn trapping the errors in a try/except. In that case, just do a
bare 'raise' in the except clause, and you should get the full traceback.
I'm su
R. David Murray added the comment:
What is the data type returned by your get_msg? I bet it is string, and email
can't handle messages in string format that have non-ASCII characters (I'm
adding an explicit error message for this). You either need to use a Message
object, or, m
R. David Murray added the comment:
I'm updating the patch to contain a couple tests using non-ASCII. More are
needed.
Before this patch, one could process a file containing non-ASCII characters as
text, and if your default encoding happened to be able to decode it, things
would appe
Changes by R. David Murray :
Removed file: http://bugs.python.org/file20565/mailbox3.patch
___
Python tracker
<http://bugs.python.org/issue9124>
___
___
Python-bugs-list m
R. David Murray added the comment:
Code patch looks good to me. Unittest tests pass.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
Well, that's a bunch of code, and I'm afraid I don't know what your answer to
my question was. What error do you get now if you use the new version of
mailbox3.patch?
If you feed the new mailbox/email bytes, it will preserve the bytes as
R. David Murray added the comment:
Added two more tests of non-ASCII. I think the tests now cover the necessary
cases.
I still want to do a full code review tomorrow, but I think the patch is in
final form if anyone else is available to do a review as well.
Georg, are you OK with this
Changes by R. David Murray :
Added file: http://bugs.python.org/file20585/mailbox3.patch
___
Python tracker
<http://bugs.python.org/issue9124>
___
___
Python-bugs-list m
Changes by R. David Murray :
Removed file: http://bugs.python.org/file20579/mailbox3.patch
___
Python tracker
<http://bugs.python.org/issue9124>
___
___
Python-bugs-list m
R. David Murray added the comment:
If you are using the most recent mailbox3 patch (I should have renamed it,
sorry...I've no done so to make it clear) you should be getting an error
message that tells you to use binary or Message. So I don't understand how you
are getting this m
Changes by R. David Murray :
--
assignee: -> r.david.murray
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue11050>
___
___
Python-
R. David Murray added the comment:
Victor: yes, I was thinking that when I added that comment but forgot to come
back to it. Thanks for spotting that.
Another thing I forgot about yesterday is that I activated the commented out
statements that do linesep transformations on the binary file
New submission from R. David Murray :
One of the new tests introduced for #9124 fails for the Bably mailbox format.
The failing tests pass a file to the add method (test_add_binary_file,
test_add_nonascii_binary_file, test_add_text_file_warns). The failing part of
the tests have been
R. David Murray added the comment:
OK, I've added deprecation warnings for using StringIO or text mode files as
input. I found one bug thereby, but it is a bug that pre-existed the patch
(see issue 11062).
I've completed my code review.
To address Victor's question about t
R. David Murray added the comment:
(I hope you meant I was working on a patch :)
Patch is done, but there is one remaining test failure that I'm not sure how to
handle. The test is test_add_text_file_warns. The code checks to see if a
file is a subclass of io.TextIOWrapper, and if so
R. David Murray added the comment:
Benjamin suggested using hasattr(message, 'buffer'), and that works great. The
test revealed a bug in the patch, which is now fixed.
All tests pass on windows. As far as I'm concerned the patch is ready to go.
Other reviews would of co
R. David Murray added the comment:
Committed (with RM approval on IRC) in r88252.
Note that this does not necessarily solve the performance problem. A new issue
should be opened for that if it still exist.
--
resolution: -> fixed
stage: commit review -> committed/rejected
R. David Murray added the comment:
I have no idea what "a static context" means, so it wouldn't make it any
clearer to me. Can you explain further what your confusion is?
--
nosy: +r.david.murray
type: -> feature request
versions: +Python 2.7, Python 3.1, Pyth
R. David Murray added the comment:
I still don't understand. I haven't used threading much, but I don't believe
I've ever used a static method with it.
--
___
Python tracker
<http://bug
New submission from R. David Murray :
Inspired by what happened in issue 8973, I offer the attached patch for
test__all__ to have it check the __all__ list for duplicates. Interestingly,
the first failure is not in struct, but in os. Obviously the patch can't be
applied until the
R. David Murray added the comment:
Well, the test stops testing after the first failure. Perhaps another
enhancement request would be to make test__all__ a parameterized test so that
it tests all modules even if one or more fail.
On linux, the dups are putenv and unsetenv. And yes, deeper
R. David Murray added the comment:
Well, checking if the token is there before adding it would certainly be a fix,
but I think it would be worth understanding why it gets added if it is already
there, because instead perhaps it is possible to simply remove the adding code
from os.py
R. David Murray added the comment:
I'll leave priority setting to tarek, but it doesn't look to me like raising
the priority is going to make any difference, since it doesn't sound from
reading the ticket like anyone has found a solution yet (other than offering
6
R. David Murray added the comment:
FYI, a python traceback is not a segfault. Nor is it a 'crash' in the sense we
use in this tracker.
The warning has been added to the download page, though there is discussion
about whether or not it should be more prominent.
-
R. David Murray added the comment:
Eric, what you say is technically true, but we don't have any other place to
track PEP bugs.
--
assignee: -> docs@python
components: +Documentation
nosy: +docs@python, r.david.murray
resolution: invalid ->
stage: committed/rejected -&g
R. David Murray added the comment:
I see correct doc strings on both 2.7 head and 3.1.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue571
Changes by R. David Murray :
--
assignee: -> r.david.murray
nosy: +r.david.murray
stage: needs patch -> patch review
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/
R. David Murray added the comment:
Why not just put them in the 'abc' namespace? IMO, collections.abc.Callable
makes a lot less sense than abc.Mapping.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.o
R. David Murray added the comment:
Hmm. OK, so it is just Callable that is the odd man out.
But in that case, shouldn't the pattern be adopted by the other modules that
define abcs as well? And if the distinction isn't sharp enough in those other
modules to justify that, then
R. David Murray added the comment:
Well, the bug tracker isn't really the place to get help on using Python. I
would suggest posting to python-list, you are more likely to find people with
the time to help you there. You should also take a look at the Turtle demo
programs, I'm p
R. David Murray added the comment:
Steffan: I'm not sure what your post means, but I think there is a chance you
might be confused about something. Python should *never* change the locale
from the C locale. A Python *program* can do so, by calling setlocale, but
Python itself shoul
R. David Murray added the comment:
Ned: I read the bits in the turtle docs about -n as meaning *if* you use -n
*then* you should set this profile option (but if you don't, things should
work). I didn't go over the docs in detail, though, so maybe I'm misreading.
Since yo
R. David Murray added the comment:
Ah, in that case I think the docs could be improved on that point.
--
___
Python tracker
<http://bugs.python.org/issue11
R. David Murray added the comment:
This is fixed in py3k rc2, and thus will be fixed in 3.2. The trick will be
figuring out which update fixed it, to see if we can backport to 3.1 and 2.7.
Since issue 10841 touched stdio handling in Windows, I suspect that may be the
source, so I'm a
R. David Murray added the comment:
Duplicate of issue 6784. (If you disagree explain why here, please.)
--
nosy: +r.david.murray
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
superseder: -> byte/unicode pickle incompatibilities between
Changes by R. David Murray :
--
nosy: +jdharper
___
Python tracker
<http://bugs.python.org/issue6784>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
Looks like this was closed due to lack of appropriate people reviewing it,
rather than because such a review was done.
--
nosy: +brian.curtin, r.david.murray, tim.golden
resolution: out of date ->
status: closed -> open
versions: +Python 3.3 -
Changes by R. David Murray :
--
nosy: -BreamoreBoy
___
Python tracker
<http://bugs.python.org/issue1103350>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
My notes say that this bug is "similar to issue 5610", the fix for which made
it in to 2.6. I meant to come back and see if that fix fixed this bug, but I
forgot. The fix is different, so it is worth verifying that this test case
fails in 2.5
R. David Murray added the comment:
Looks good to me. I've added the #6510 as superseder, though I doubt we'll
ever make use of that info :)
--
superseder: -> email feedparser.py CRLFLF bug: $ vs \Z
___
Python tracker
<http:/
R. David Murray added the comment:
Great. Thanks for reporting it, and I'm glad we managed to already have it
fixed :)
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http:
R. David Murray added the comment:
There is no underlying file object. I presume you mean the reader/writer
object? Which have no close method, so there is no point in making them a
context manager. There is zero benefit and positive cost (an additional
nesting level). Just use with to
R. David Murray added the comment:
Steffen, I appreciate your testing this. Your error report doesn't have enough
information for me to reproduce the problem. Can you post a short test case,
including a sample email/mailbox file if needed, that reproduces the problem
you are seeing?
Changes by R. David Murray :
--
assignee: -> r.david.murray
___
Python tracker
<http://bugs.python.org/issue6>
___
___
Python-bugs-list mailing list
Un
1701 - 1800 of 10554 matches
Mail list logo
