Pablo Galindo Salgado added the comment:
New changeset 43cf7c864a2941b3f8f823e5928721dd286b7778 by Pablo Galindo in
branch 'main':
bpo-44263: Mention PyType_Ready in the gc protocol warning (GH-26445)
https://github.com/python/cpython/commit/43cf7c864a2941b3f8f823e5928721
Change by Pablo Galindo Salgado :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue44263>
___
___
Pablo Galindo Salgado added the comment:
New changeset d8ce746e7c5193757c8d316105870b0dc5d6fa53 by Miss Islington (bot)
in branch '3.10':
bpo-44263: Mention PyType_Ready in the gc protocol warning (GH-26445) (#26446)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
> This might be the same macOS bug.
It could be, but the same thing happens on Windows
--
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
> Pablo, can we add these warnings in 3.10?
Thanks for checking! Yeah, I think it makes sense to go ahead adding these
warnings to 3.10 . Please, add me as a reviewer to the backport PR to 3
Pablo Galindo Salgado added the comment:
New changeset f097d2302be46b031687726011b86fc241a042ef by Miss Islington (bot)
in branch '3.10':
bpo-42972: Fully implement GC protocol for xxlimited (GH-26451) (GH-26460)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 7fe9cad606a4ac7ac138528dcd19546394bc5a44 by Miss Islington (bot)
in branch '3.10':
bpo-44263: Fix _decimal and _testcapi GC protocol (GH-26464) (GH-26465)
https://github.com/python/cpython/commit/7fe9cad606a4ac7ac138528dcd1954
Pablo Galindo Salgado added the comment:
> Are you sure? All the reports are from macOS CI. Christian mentioned that it
> could be similar to another ssl test failure that also happen on Windows, but
> those tracebacks do not match the ones in this issue.
I am certainly not su
Pablo Galindo Salgado added the comment:
Hu, I sort of agree, but I need to weigh how complex is going to be to
special-case. I really don't want to start adding many different paths for the
different built-ins in different situa
Pablo Galindo Salgado added the comment:
Also, another problem is that "cannot assign to __debug__" is actually a
compiler error, while "cannot assign to Ellipsis here. Maybe you meant '=='
instead of '='?" is a parser error. This is because "__
Pablo Galindo Salgado added the comment:
What we can do is to replace:
SyntaxError: cannot assign to Ellipsis here. Maybe you meant '==' instead of
'='?
for
SyntaxError: cannot assign to '...' here. M
Pablo Galindo Salgado added the comment:
I suggest to just close it or otherwise changing the message to include "..."
instead of "Ellipsis". Anything else is actually much more complex than it
seems, unfortunately
--
___
Py
Change by Pablo Galindo Salgado :
Removed file: https://bugs.python.org/file50077/DTD-Matching-Gift-Dashboard -
Google Sheets.html
___
Python tracker
<https://bugs.python.org/issue42
Pablo Galindo Salgado added the comment:
New changeset 39dd141a4ba68bbb38fd00a65cdcff711acdafb5 by Serhiy Storchaka in
branch 'main':
bpo-44273: Improve syntax error message for assigning to "..." (GH-26477)
https://github.com/python/cpython/commit/39dd141a4ba68bbb38fd
Change by Pablo Galindo Salgado :
--
pull_requests: +25073
pull_request: https://github.com/python/cpython/pull/26478
___
Python tracker
<https://bugs.python.org/issue44
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset a384b6c04054a2c5050a99059836175cf73e2016 by Erlend Egeberg
Aasland in branch 'main':
bpo-44165: Optimise sqlite3 statement preparation by passing string size
(GH-26206)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
Erlend, check out
https://github.com/python/cpython/pull/26206#discussion_r643910263. After that
we can close this issue
--
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
New changeset fbf25b8c0dd1e62db59117d53bbd2d4131a06867 by Erlend Egeberg
Aasland in branch 'main':
bpo-44165: pysqlite_statement_create now returns a Py object, not an int
(GH-26484)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
I don't see anything relevant in the logs. These are the last messages
regarding this worker:
2021-06-02 18:38:26+ [-] Worker billenstein-macos detached from x86-64
macOS 3.7
2021-06-02 18:38:26+ [-] Worker billenstein-macos detached fro
Pablo Galindo Salgado added the comment:
New changeset cea0585b7939b487d7089f9d473f495264e8a491 by Mark Shannon in
branch '3.10':
[3.10] bpo-44298: Backport #26513 to 3.10 (#26516)
https://github.com/python/cpython/commit/cea0585b7939b487d7089f9d473f49
Pablo Galindo Salgado added the comment:
> Victor, this issue is reproducible on Linux. I reproduced it on my WSL.
How did you managed? I ran test_asyncio for almost 5 hours with -R in my linux
machine and could not reproduce?
--
___
Pyt
Pablo Galindo Salgado added the comment:
> And extending the buildbot timer may not help since it seems it's running
> infinitely
Extending the bot time was done so we can use faulthandler to identify the
test, because buildbot was cancelling the whole build
Pablo Galindo Salgado added the comment:
Ned, can you confirm that this works for you? I am closing the issue, but if
something is missing, please, reopen it and we will look into it :)
--
resolution: -> fixed
stage: patch review -> resolved
status: open -&g
Pablo Galindo Salgado added the comment:
New changeset f461a7fc3f8740b9e79e8874175115a3474e5930 by Erlend Egeberg
Aasland in branch 'main':
bpo-42862: Use functools.lru_cache iso. _sqlite.Cache in sqlite3 module
(GH-24203)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset f3491242e41933aa9529add7102edb68b80a25e9 by Batuhan Taskaya in
branch 'main':
bpo-11105: Do not crash when compiling recursive ASTs (GH-20594)
https://github.com/python/cpython/commit/f3491242e41933aa9529add7102edb
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
> And I've identified the issue is in test_close_kill_running. The patch for
> resolving the crash in bpo-38323 can be the cause of the newly introduced hang
Also, how did you reached this
Pablo Galindo Salgado added the comment:
New changeset 3283bf4519139cf62ba04a76930f84ca1e7da910 by Pablo Galindo in
branch '3.10':
[3.10] bpo-44273: Improve syntax error message for assigning to "..."
(GH-26477) (GH-26478)
https://github.com/p
Pablo Galindo Salgado added the comment:
New changeset de58b319af3a72440a74e807cf8a1194ed0c6d8c by Batuhan Taskaya in
branch '3.9':
[3.9] bpo-11105: Do not crash when compiling recursive ASTs (GH-20594)
(GH-26522)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
nosy: -pablogsal
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 3446516ffa92c98519146253153484291947b273 by Erlend Egeberg
Aasland in branch 'main':
bpo-44042: Optimize sqlite3 begin transaction (GH-25908)
https://github.com/python/cpython/commit/3446516ffa92c98519146253153484
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Pablo Galindo Salgado :
Given this script:
try:
x = 34
a = 1
instead of printing:
File "/home/pablogsal/github/python/master/lel.py", line 4
a = 1
^
SyntaxError: invalid syntax
we should print:
File "/home/pablogsal/github/python/master/
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +25117
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26523
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset b250f89bb7e05e72a4641d44b988866b919575db by Pablo Galindo in
branch 'main':
bpo-44305: Improve syntax error for try blocks without except or finally
(GH-26523)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
pull_requests: +25118
pull_request: https://github.com/python/cpython/pull/26524
___
Python tracker
<https://bugs.python.org/issue44
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset e53f72a1b42e17a331ed14bec674b1ee01d0720c by Pablo Galindo in
branch '3.10':
[3.10] bpo-44305: Improve syntax error for try blocks without except or finally
(GH-26523) (GH-26524)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 35002aa8f62dda1f79035e9904abdf476683e9be by Max Bélanger in
branch 'main':
bpo-32280: Store _PyRuntime in a named section (GH-4802)
https://github.com/python/cpython/commit/35002aa8f62dda1f79035e9904abdf476683e9be
-
Pablo Galindo Salgado added the comment:
Using a weak dictionary is not a correct solution as the cache must take string
ownership of the arguments and return value to do it's job properly. Moreover,
there are many types in Python that don't support weak references so this
Pablo Galindo Salgado added the comment:
> Yes, with the commands you provided in the
> https://bugs.python.org/issue38323#msg395090 I also reproduced the crash on
> my WSL. And any suggestions on the other test failures in the log I attached?
> I don't know if they are fix
New submission from Pablo Galindo Salgado :
All refleak buildbots are currently broken in master:
..
test_asyncio leaked [1533, 1531, 1533] references, sum=4597
test_asyncio leaked [367, 366, 367] memory blocks, sum=1100
11 tests failed again:
test_asyncgen test_asyncio test_code
Pablo Galindo Salgado added the comment:
Unfortunately, commit 2c1e2583fdc4db6b43d163239ea42b0e8394171f has broken all
the refleak buildbots. Example failure:
BISECTION:
c1e2583fdc4db6b43d163239ea42b0e8394171f is the first bad commit
commit 2c1e2583fdc4db6b43d163239ea42b0e8394171f
Author
Pablo Galindo Salgado added the comment:
Please, in the future, check with the buildbots before merging these kinds of
big PRs.
--
___
Python tracker
<https://bugs.python.org/issue43
Change by Pablo Galindo Salgado :
--
pull_requests: +25123
pull_request: https://github.com/python/cpython/pull/26530
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
This is caused by:
https://bugs.python.org/issue43693
--
nosy: +Mark.Shannon, eric.snow
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
> I was just asking if we could do anything about the multiple test failures
> (especially test_asyncio failure).
We don't see any failures as the ones in your logs in the buildbots or
otherwise, so seems something wrong in your sys
Pablo Galindo Salgado added the comment:
PR reverts commits 2c1e2583fdc4db6b43d163239ea42b0e8394171f and
b2bf2bc1ece673d387341e06c8d3c2bc6e259747. Please, commit them back once the
refleaks are resolved. I took a quick look and seems that there are several
issues but there are more I could
Pablo Galindo Salgado added the comment:
New changeset a46c220edc5cf716d0b71eb80ac29ecdb4ebb430 by stratakis in branch
'main':
bpo-44048: Fix two hashlib test cases under FIPS mode (GH-26470)
https://github.com/python/cpython/commit/a46c220edc5cf716d0b71eb80ac29ecdb4ebb430
-
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 17c4edc4e0692fe55e185755ea8a2f5238f3ef08 by Pablo Galindo in
branch 'main':
bpo-43693: Revert commits 2c1e2583fdc4db6b43d163239ea42b0e8394171f and
b2bf2bc1ece673d387341e06c8d3c2bc6e259747 (GH-26530)
https://github.com/pyth
Pablo Galindo Salgado added the comment:
New changeset 8363ac8607eca7398e568e1336154e1262a995a0 by Erlend Egeberg
Aasland in branch 'main':
bpo-44041: Add test for sqlite3 column count (GH-25907)
https://github.com/python/cpython/commit/8363ac8607eca7398e568e1336154e
Change by Pablo Galindo Salgado :
--
nosy: -pablogsal
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 006fd869e4798b68e266f5de89c83ddb531a756b by Erlend Egeberg
Aasland in branch 'main':
bpo-43853: Handle sqlite3_value_text() errors (GH-25422)
https://github.com/python/cpython/commit/006fd869e4798b68e266f5de89c83d
Pablo Galindo Salgado added the comment:
New changeset 3f4d801bf907a5fcab50f3b64475d1410b90a80f by Miss Islington (bot)
in branch '3.10':
bpo-44048: Fix two hashlib test cases under FIPS mode (GH-26470) (GH-26531)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 7459208de194db6222d7e3aa301c2b831dbe566d by Erlend Egeberg
Aasland in branch 'main':
bpo-44315: Remove unused connection argument from pysqlite_step() (GH-26535)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
nosy: -pablogsal
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
nosy_count: 8.0 -> 9.0
pull_requests: +25131
pull_request: https://github.com/python/cpython/pull/26541
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Yep
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
pull_requests: +25132
pull_request: https://github.com/python/cpython/pull/26542
___
Python tracker
<https://bugs.python.org/issue38
Pablo Galindo Salgado added the comment:
Raising this to a release blocker for 3.10.0 beta 3 as it breaks PyQt6 and
other projects.
--
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
priority: deferred blocker -> release blocker
___
Python tracker
<https://bugs.python.org/issue43908>
___
___
Python-
Change by Pablo Galindo Salgado :
--
priority: release blocker ->
___
Python tracker
<https://bugs.python.org/issue42972>
___
___
Python-bugs-list mai
Pablo Galindo Salgado added the comment:
I'm landing https://github.com/python/cpython/pull/26542 as a temporary
solution meanwhile we decide what to do with PR 26536.
--
___
Python tracker
<https://bugs.python.org/is
Pablo Galindo Salgado added the comment:
New changeset f171877ebe276749f31386baed5841ce37cbee2e by Pablo Galindo in
branch 'main':
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the test suite
(GH-26542)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 0d441d2e70e365b5dc517d8ff24a20b97bc4536a by Miss Islington (bot)
in branch '3.10':
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the test suite
(GH-26542) (GH-26544)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
I did the bisection:
ff359d735f1a60878975d1c5751bfd2361e84067 is the first bad commit
commit ff359d735f1a60878975d1c5751bfd2361e84067
Author: Miss Islington (bot) <31488909+miss-isling...@users.noreply.github.com>
Date: Mon May 31 02:12:27 2021
Change by Pablo Galindo Salgado :
--
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issue44304>
___
___
Python-bugs-list mai
Change by Pablo Galindo Salgado :
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/issue44304>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +25135
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26545
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
The problem is that this is wrong:
https://github.com/python/cpython/blob/f171877ebe276749f31386baed5841ce37cbee2e/Modules/_sqlite/statement.c#L411-L423
1) tp_clear should *not* do anything other than cleaning refs to python objects
2
Pablo Galindo Salgado added the comment:
Using the reproducer code by Mike, without this fix:
❯ ./python ../lel.py
[1]25344 segmentation fault ./python ../lel.py
With this fix:
❯ ./python ../problem.py
❯ echo $?
0
--
___
Python tracker
Pablo Galindo Salgado added the comment:
This is a simpler reproducer:
dest = sqlite.connect(':memory:')
def md5sum(t):
return
dest.create_function("md5", 1, md5sum)
x = dest("create table lang (name, first_appeared)&q
Pablo Galindo Salgado added the comment:
Agreed! I will let the PR to you :)
--
___
Python tracker
<https://bugs.python.org/issue44310>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
New changeset fa106a685c1f199aca5be5c2d0277a14cc9057bd by Pablo Galindo in
branch 'main':
bpo-44304: Fix crash in the sqlite3 module when the GC clears Statement objects
(GH-26545)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
Batuhan, can you take a look?
--
___
Python tracker
<https://bugs.python.org/issue11105>
___
___
Python-bugs-list mailin
Pablo Galindo Salgado added the comment:
> sqlit3.Cursor is prone to the same bug.
No, is not: it doesn't drop the GIL in tp_clear. There is technically no bug,
but is true that tp_clear should only clean Python references. Although in this
case there are some sematics with the clea
Pablo Galindo Salgado added the comment:
> Is this expected?
Yes, is an edge case of python identifiying two tokens together except that
there is no space:
>>> 3 4
File "", line 1
3 4
^^^
SyntaxError: invalid syntax. Perhaps you forgot a comma?
I hon
Change by Pablo Galindo Salgado :
--
title: Problems of int literal SyntaxErrors -> Suggestion for better syntax
errors in tokenizer errors
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
pull_requests: +25138
pull_request: https://github.com/python/cpython/pull/26551
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
New changeset 6e3b7cf3af3ed7758b2c2193c1d393feb8ab8f72 by Pablo Galindo in
branch 'main':
bpo-44304: Ensure the sqlite3 destructor callback is always called with the GIL
held (GH-26551)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 317e9ed4363a86b1364573c5a5e30011a080ce6d by Miss Islington (bot)
in branch '3.10':
bpo-44304: Ensure the sqlite3 destructor callback is always called with the GIL
held (GH-26551) (GH_26552)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +25142
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26555
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
PR 26555 does some improvements to your examples:
>>> 0777
File "", line 1
0777
^
SyntaxError: leading zeros in decimal integer literals are not permitted; use
an 0o prefix for octal integers
>>> 0
F
Pablo Galindo Salgado added the comment:
>b) always skip the test on windows => we can do that but it might be
> counterintuitive for the future
Well, is not that the test is flaky technically, this means that the feature
doesn't work on Windows (non release builds). So
Pablo Galindo Salgado added the comment:
New changeset 505624e917a2d3d845304f8d34fccd41f06d4720 by Erlend Egeberg
Aasland in branch 'main':
bpo-44327: Remove unused members from pysqlite_Connection (GH-26565)
https://github.com/python/cpython/commit/505624e917a2d3d845304f8d34fccd
Pablo Galindo Salgado added the comment:
New changeset 0d12f245523178eb62e22f5da5a276bfc7004ac4 by Erlend Egeberg
Aasland in branch 'main':
bpo-44326: Remove unused members from pysqlite_Statement (GH-26564)
https://github.com/python/cpython/commit/0d12f245523178eb62e22f5da5a276
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue44326>
___
___
Pablo Galindo Salgado added the comment:
This one will be very tricky to do correctly because the '=' is very
context-sensitive and the parser can be confused when backtracking, so this
*may* be quite delicate/complex.
I need to play a bit with this to know how feasible thi
Pablo Galindo Salgado added the comment:
I suspect this is going to be a pain for malformed expressions on the right.
For instance:
>>> a = {x: for x in {}}
File "", line 1
a = {x: for x in {}}
^^^
SyntaxError: exp
Pablo Galindo Salgado added the comment:
> will avoid unneeded allocations/GC tracking,
I am not sure what you mean, in the happy path you still need to GC track and
allocate.
--
nosy: +pablogsal
___
Python tracker
<https://bugs.pyth
Pablo Galindo Salgado added the comment:
> Yes, we need to allocate/track every time. I just propose to do so as late as
> possible, in order to avoid allocating a PyObject before we know if it is
> possible to actually create the statement.
That describes much better t
Pablo Galindo Salgado added the comment:
>> Well, I was thinking we could just do a simple check in
>> _PyPegen_check_tokenizer_errors or _PyPegen_run_parser functions. If the
>> last three tokens in the Parser object's tokens array are NAME,
>> EQUAL/MINEQUAL/
Pablo Galindo Salgado added the comment:
> I saw that unclosed parentheses' special error are checked in the same
> place.
Just to clarify: unclosed parentheses is a tokenizer error, not a parser error
and this is handled by checking the tokenize status when it has already f
Pablo Galindo Salgado added the comment:
I don't understand this example.
> importing re.match directly into __main__ replaces the keyword with the
> function.
It has not replaced anything, if you do a match statement it works and doesn't
call your function. For exampl
901 - 1000 of 4424 matches
Mail list logo
