Change by Pablo Galindo Salgado :
--
pull_requests: +15202
pull_request: https://github.com/python/cpython/pull/15515
___
Python tracker
<https://bugs.python.org/issue37
Pablo Galindo Salgado added the comment:
See also https://bugs.python.org/issue37947
--
___
Python tracker
<https://bugs.python.org/issue37954>
___
___
Pytho
Pablo Galindo Salgado added the comment:
New changeset 4901dc46da5ecb131f8d902a0fbd704934f209e1 by Pablo Galindo in
branch 'master':
bpo-37954: Fix reference leak in the symtable (GH-15514)
https://github.com/python/cpython/commit/4901dc46da5ecb131f8d902a0fbd70
Pablo Galindo Salgado added the comment:
Scheduled two custom builds of the 3.x refleak buildbots:
https://buildbot.python.org/all/#/builders/80/builds/684
https://buildbot.python.org/all/#/builders/1/builds/695
--
___
Python tracker
<ht
Pablo Galindo Salgado added the comment:
New changeset 3769425abd8da9a59b9645baf90ef49b9c69c140 by Pablo Galindo in
branch '3.8':
[3.8] bpo-37947: Adjust correctly the recursion level in symtable for named
expressions (GH-15499) (GH-15515)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
Scheduled another two custom builds on the 3.8 branch:
https://buildbot.python.org/all/#/builders/223/builds/85
https://buildbot.python.org/all/#/builders/224/builds/71
--
___
Python tracker
<ht
Pablo Galindo Salgado added the comment:
Can we close this issue or remove the release blocker?
--
___
Python tracker
<https://bugs.python.org/issue37
New submission from Pablo Galindo Salgado :
When building Python in some uncommon platforms (I am looking at you Solaris
and AIX) there are some known tests that will fail. Right now, regrtest has the
ability to ignore entire tests using the -x option and to receive a filter file
using the
Pablo Galindo Salgado added the comment:
> Tests that fail on some platforms can be marked to skip in code.
One of the use cases of this feature is for people to package Python at
distributions or companies and want to run the test suite without modifying the
code or applying patc
Pablo Galindo Salgado added the comment:
Oh, FreeBSD, what have you done now.
--
___
Python tracker
<https://bugs.python.org/issue37959>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
@koobs, did you changed recently the buildbot?
--
___
Python tracker
<https://bugs.python.org/issue37959>
___
___
Pytho
Change by Pablo Galindo Salgado :
--
nosy: +koobs
___
Python tracker
<https://bugs.python.org/issue37959>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
Could this be that the libc was outdated?
--
___
Python tracker
<https://bugs.python.org/issue37959>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
Thank you very much, Steve! This was indeed a bit tricky :)
The last refleak buildbot is green again, so closing this.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -&g
Pablo Galindo Salgado added the comment:
Thank you very much Nick for correcting this!
--
___
Python tracker
<https://bugs.python.org/issue37947>
___
___
Pytho
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal, pitrou
___
Python tracker
<https://bugs.python.org/issue38006>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
I think the real problem is in vectorcall. tp_clear will make sure all internal
pointers are either NULL or valid (by using Py_CLEAR, which also protects
against re-entrancy) and it the responsibility of the object or its users to
check that the
Pablo Galindo Salgado added the comment:
In particular, this was not happening before because the function type did not
implement tp_clear:
https://github.com/python/cpython/blob/3.7/Objects/funcobject.c#L615
The new implementation of tp_clear without checks is allowing this to happen
Change by Pablo Galindo Salgado :
--
resolution: fixed ->
status: closed -> open
___
Python tracker
<https://bugs.python.org/issue33418>
___
___
Pyth
Pablo Galindo Salgado added the comment:
This change introduced the possibility to have function objects in an
inconsistent state. For example, when calling tp_clear on the function some
code must be invoked that tries to ca the function but some fields are NULL
causing a crash.
I think we
Pablo Galindo Salgado added the comment:
See also https://bugs.python.org/issue33418 as the potential source of the
problem.
--
___
Python tracker
<https://bugs.python.org/issue38
Pablo Galindo Salgado added the comment:
See also https://bugs.python.org/issue38006
--
resolution: -> fixed
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
resolution: fixed ->
___
Python tracker
<https://bugs.python.org/issue33418>
___
___
Python-bugs-list mailing list
Un
Pablo Galindo Salgado added the comment:
In https://bugs.python.org/issue33418 I proposed reverting tp_clear on function
objects.
>What should be done when a function with func_code=NULL is called?
We can set the error indicator at least. Although I agree that it seems
suboptimal. At le
New submission from Pablo Galindo Salgado :
A weak reference may try to invoke a callback object that is being
cleaned (tp_clear) by the garbage collector and it may be in an
inconsistent state. As the garbage collector explicitly does not
invoke callbacks that are part of the same cycle
Pablo Galindo Salgado added the comment:
Antoine, could you check that I am not missing something in this logic?
--
___
Python tracker
<https://bugs.python.org/issue38
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +15310
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15645
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Check https://bugs.python.org/issue38006 for reference on this situation.
I have the suspicion that something in this argument is wrong and the problem
of arriving in this situation may be elsewhere, but I wanted to create this
issue and show the
Pablo Galindo Salgado added the comment:
The more I think about this the more I think there is something else at play.
If the GC is able to follow the dependency chain, all weakrefs should have been
already managed correctly and PyObject_ClearWeakRefs should have never be
invoked.
I think
Pablo Galindo Salgado added the comment:
I think I am going to close this until we understand
https://bugs.python.org/issue38006 better
--
___
Python tracker
<https://bugs.python.org/issue38
Change by Pablo Galindo Salgado :
--
resolution: -> not a bug
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
I think the problem is that whatever is weak-referenced by the weak ref
(CField_Type or similar) is not on the gc list. Because is not on the gc list,
handle_weakrefs
(https://github.com/python/cpython/blob/master/Modules/gcmodule.c#L1090) is not
Pablo Galindo Salgado added the comment:
I am going to re-close this until we understand exactly how this is interacting
with https://bugs.python.org/issue38006 as this seems more complicated than our
first hypothesis.
--
resolution: -> fixed
status: open ->
Pablo Galindo Salgado added the comment:
Unless we are missing something I think this may be caused by something in cffi
that is not implementing gc-related functions correctly, as
PyObject_ClearWeakRefs should not be called from a gc run. Given how
complicated this is and even if the
Pablo Galindo Salgado added the comment:
For the weakref to be handled correctly the ctypedescr needs to be identified
correctly as part of the isolated cycle. If is not in the isolated cycle
something may be missing tp_traverse or the GC flags.
Can you check if the ctypedescr is part of
Pablo Galindo Salgado added the comment:
Wait, I just checked and the call is done manually:
static void
ctypedescr_dealloc(CTypeDescrObject *ct)
{
PyObject_GC_UnTrack(ct);
if (ct->ct_weakreflist != NULL)
PyObject_ClearWeakRefs((PyObject *) ct);
I am not sure call
Change by Pablo Galindo Salgado :
--
Removed message: https://bugs.python.org/msg351022
___
Python tracker
<https://bugs.python.org/issue38006>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
PR15552 introduced a regression in FreeBSD buildbots:
https://buildbot.python.org/all/#/builders/168/builds/1417
Could you take a look?
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.
Pablo Galindo Salgado added the comment:
This is the failure for reference:
==
ERROR: test_shared_memory_basics
(test.test_multiprocessing_spawn.WithProcessesTestSharedMemory
Pablo Galindo Salgado added the comment:
Correction, is PR 15662 the one that introduced the recession (the one in this
issue) not the previous one I linked. Apologies for that.
--
___
Python tracker
<https://bugs.python.org/issue38
Pablo Galindo Salgado added the comment:
New changeset 2fc1160a80733f4c5c88796319154b3f59e98e4b by Pablo Galindo (Vinay
Sharma) in branch 'master':
bpo-38018: Fix test for multiprocessing.shared_memory in BSD systems (GH-15821)
https://github.com/python/cpyt
New submission from Pablo Galindo Salgado :
test_ctypes leaked [22, 22, 22] references, sum=66
3 tests failed again:
test_ctypes test_import test_importlib
https://buildbot.python.org/all/#/builders/1/builds/710
--
components: Tests
messages: 351640
nosy: pablogsal
priority
Pablo Galindo Salgado added the comment:
Bisecting points to commit 65366bc8bdc4716ebc361e622590b45a6e5aef07
--
___
Python tracker
<https://bugs.python.org/issue38
Pablo Galindo Salgado added the comment:
This PR introduced a reference leak tracked in:
https://bugs.python.org/issue38090
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue20
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +15497
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15848
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
nosy: +Anthony Sottile, steve.dower
___
Python tracker
<https://bugs.python.org/issue38090>
___
___
Python-bugs-list mailin
Pablo Galindo Salgado added the comment:
Should this be closed now?
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue38070>
___
___
Pytho
New submission from Pablo Galindo Salgado :
I get this when compiling CPython master
Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:89:19: error: implicit
declaration of function 'EVP_MD_CTX_new' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
r
New submission from Pablo Galindo Salgado :
❯ ./python.exe -m test test_importlib -R 3:3
Run tests sequentially
0:00:00 load avg: 1.45 [1/1] test_importlib
beginning 6 repetitions
123456
..
test_importlib leaked [20, 20, 20] references, sum=60
test_importlib failed
== Tests result: FAILURE
Pablo Galindo Salgado added the comment:
Bisecting points to
commit 5b172c27f760dc5437e37dd8f1540eb76440e9a7
Author: Dino Viehland
Date: Wed Sep 11 08:47:17 2019 -0700
bpo-38113: Update Python/ast.c to PEP-384 (GH-15975)
Removes statics for better subinterpreter support and
Change by Pablo Galindo Salgado :
--
title: test_importleak is leaking references -> test_importlib is leaking
references
___
Python tracker
<https://bugs.python.org/issu
New submission from Pablo Galindo Salgado :
Running the test suite to check refleaks over test.test_tools.test_c_analyzer
will always fail, make it impossible for the refleak buildbots to run
correctly.
Steps to reproduce:
./python -m test test_tools -v -R 3:3
Pablo Galindo Salgado added the comment:
Check this failure in the buildbots for reference:
https://buildbot.python.org/all/#/builders/80/builds/705/steps/4/logs/stdio
--
___
Python tracker
<https://bugs.python.org/issue38
Change by Pablo Galindo Salgado :
--
nosy: +nanjekyejoannah, vstinner
___
Python tracker
<https://bugs.python.org/issue38187>
___
___
Python-bugs-list mailin
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 5f5f11faf9de0d8dcbe1a8a4eb35d2a4232d6eaa by Pablo Galindo
(Abraham Toriz Cruz) in branch 'master':
bpo-37828: Fix default mock_name in unittest.mock.assert_called error (GH-16166)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +15830
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16233
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset 6fbc924696b4b5097c273c06ca2d82662940e184 by Pablo Galindo in
branch 'master':
bpo-38187: Fix reference leak in test_tools (GH-16233)
https://github.com/python/cpython/commit/6fbc924696b4b5097c273c06ca2d82
Pablo Galindo Salgado added the comment:
The original error is still present and
./python -m test test_tools -v -R 3:3
is still failing some times, but when it suceeds there are no leaks being
reported.
--
___
Python tracker
<ht
Change by Pablo Galindo Salgado :
--
Removed message: https://bugs.python.org/msg352645
___
Python tracker
<https://bugs.python.org/issue38187>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
PR 16233 fixes the reference leaks but the original error is still present and
./python -m test test_tools -v -R 3:3
is still failing (as in the test fails, instead of failing because there are
leaks
New submission from Pablo Galindo Salgado :
When calling Py_SetPath(), the value that is passed in is ignored.
--
components: Interpreter Core
keywords: 3.8regression
messages: 352856
nosy: pablogsal, vstinner
priority: normal
severity: normal
status: open
title: The value of
Pablo Galindo Salgado added the comment:
A very simple way to reproduce the bug:
Using pyInstaller, after applying these patches (to fix other Python3.8 issues)
https://github.com/pyinstaller/pyinstaller/pull/4441
https://github.com/pyinstaller/pyinstaller/pull/4440
you will get
Fatal
Change by Pablo Galindo Salgado :
--
priority: -> release blocker
___
Python tracker
<https://bugs.python.org/issue38234>
___
___
Python-bugs-list mai
Pablo Galindo Salgado added the comment:
There is this PR that avoids a hard crash in the interpreter:
https://github.com/python/cpython/pull/15645
--
___
Python tracker
<https://bugs.python.org/issue38
Pablo Galindo Salgado added the comment:
This is a regression introduced by:
commit 6876257eaabdb30f27ebcbd7d2557278ce2e5705
Author: Victor Stinner
Date: Mon Oct 7 18:42:01 2019 +0200
bpo-36389: _PyObject_CheckConsistency() available in release mode (GH-16612)
bpo-36389, bpo
New submission from Pablo Galindo Salgado :
configure --with-pydebug --with-trace-refs && make
Modules/gcmodule.c:378: visit_decref: Assertion "!_PyObject_IsFreed(op)" failed
Fatal Python error: _PyObject_AssertFailed
Python runtime state: preinitialized
Current thread
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +16216
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16630
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 36e33c360ed7716a2b5ab2b53210da81f8ce1295 by Pablo Galindo in
branch 'master':
bpo-38400 Don't check for NULL linked list pointers in _PyObject_IsFreed
(GH-16630)
https://github.com/python
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +16218
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16632
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
versions: +Python 3.7, Python 3.9
___
Python tracker
<https://bugs.python.org/issue38395>
___
___
Python-bugs-list mailin
Change by Pablo Galindo Salgado :
--
versions: +Python 2.7, Python 3.6
___
Python tracker
<https://bugs.python.org/issue38395>
___
___
Python-bugs-list mailin
Change by Pablo Galindo Salgado :
--
nosy: +benjamin.peterson, lukasz.langa, ned.deily
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
I'm marking this as release blocker for the 3.8 incoming release so we don't
forget about fixing this.
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.o
Pablo Galindo Salgado added the comment:
New changeset 10cd00a9e3c22af37c748ea5a417f6fb66601e21 by Pablo Galindo in
branch 'master':
bpo-38395: Fix ownership in weakref.proxy methods (GH-16632)
https://github.com/python/cpython/commit/10cd00a9e3c22af37c748ea5a417f6
Change by Pablo Galindo Salgado :
--
pull_requests: +16244
pull_request: https://github.com/python/cpython/pull/16661
___
Python tracker
<https://bugs.python.org/issue38
Change by Pablo Galindo Salgado :
--
pull_requests: +16245
pull_request: https://github.com/python/cpython/pull/16662
___
Python tracker
<https://bugs.python.org/issue38
Change by Pablo Galindo Salgado :
--
pull_requests: +16246
pull_request: https://github.com/python/cpython/pull/16663
___
Python tracker
<https://bugs.python.org/issue38
Pablo Galindo Salgado added the comment:
New changeset 526ef856dd598fd3cefdfadeb18ede7a8e57aa41 by Pablo Galindo in
branch '3.8':
[3.8] bpo-38395: Fix ownership in weakref.proxy methods (GH-16632) (GH-16662)
https://github.com/python/cpython/commit/526ef856dd598fd3cefdfadeb18ede
Change by Pablo Galindo Salgado :
--
priority: release blocker -> normal
___
Python tracker
<https://bugs.python.org/issue38395>
___
___
Python-bugs-list mai
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue38379>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Pablo Galindo Salgado :
--
pull_requests: +16269
stage: backport needed -> patch review
pull_request: https://github.com/python/cpython/pull/16683
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
pull_requests: +16271
pull_request: https://github.com/python/cpython/pull/16685
___
Python tracker
<https://bugs.python.org/issue38
Pablo Galindo Salgado added the comment:
Tim, I have created backports for 3.8 and 3.7 (PR 16683, PR 16685). In my case
cherry_picker ecbf35f9335b0420cb8adfda6f299d6747a16515 3.7 and cherry_picker
ecbf35f9335b0420cb8adfda6f299d6747a16515 3.8 works after fixing merge
conflicts. Maybe there
Change by Pablo Galindo Salgado :
--
pull_requests: +16273
pull_request: https://github.com/python/cpython/pull/16687
___
Python tracker
<https://bugs.python.org/issue38
New submission from Pablo Galindo Salgado :
While working on bpo-38379 I had to manually set the GC_DEBUG macro to 1 to
activate the extra checks that 'validate_list' does. These checks are super
useful to make sure all the gc lists used are consistent and in the expected
stat
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +16292
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16707
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
stage: patch review ->
versions: -Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.org/issue38437>
___
_
Pablo Galindo Salgado added the comment:
> Under which condition can such list be corrupted?
If someone is adding/modifiying the gc and calls any of the functions that set
the gc flags like (PREV_MASK_COLLECTING).
One example is that after calling move_unreachable(), the unreachable set
Pablo Galindo Salgado added the comment:
New changeset 320dd504ddf65efe946e6d1e89053ed2d7ebe1e9 by Pablo Galindo in
branch 'master':
bpo-38437: Activate GC_DEBUG when PY_DEBUG is set (GH-16707)
https://github.com/python/cpython/commit/320dd504ddf65efe946e6d1e89053e
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
Thanks Victor and Tim!
--
___
Python tracker
<https://bugs.python.org/issue38437>
___
___
Python-bugs-list mailin
Pablo Galindo Salgado added the comment:
>From the PR:
Where the benchmarks executed with CPU isolation? I am a bit suspicious of the
- pickle_list: 3.63 us +- 0.08 us -> 3.78 us +- 0.10 us: 1.04x slower (+4%)
If not, can you repeat them with CPU isolation and affinity? Check this for
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue36553>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
Hummmis this really a regression? The docs say:
> No other methods (except for the constructor) should be overridden in a
> subclass. In other words, only override the __init__() and run() methods of
> this class.
So if someone is o
Pablo Galindo Salgado added the comment:
I have repeated the benchmark in the speed.python.org server with CPU isolation
+ PGO + LTO:
Slower (21):
- xml_etree_iterparse: 127 ms +- 2 ms -> 131 ms +- 2 ms: 1.03x slower (+3%)
- xml_etree_parse: 195 ms +- 1 ms -> 200 ms +- 2 ms: 1.03x slow
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +16312
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16733
___
Python tracker
<https://bugs.python.org/issu
New submission from Pablo Galindo Salgado :
Compiling 3.8 in release mode emits this warning:
In function ‘getsockaddrarg’,
inlined from ‘sock_bind’ at
/home/pablogsal/github/python/3.8/Modules/socketmodule.c:3066:10:
/home/pablogsal/github/python/3.8/Modules/socketmodule.c:2288:9: warning
301 - 400 of 4424 matches
Mail list logo
