Change by Pablo Galindo Salgado :
--
versions: +Python 3.11
___
Python tracker
<https://bugs.python.org/issue44856>
___
___
Python-bugs-list mailing list
Unsub
New submission from Pablo Galindo Salgado :
Here:
https://github.com/python/cpython/blob/17c23167942498296f0bdfffe52e72d53d66d693/Python/bltinmodule.c#L60-L88
Seems that new_base is not properly cleaned on the error paths
--
messages: 399161
nosy: pablogsal
priority: normal
severity
Change by Pablo Galindo Salgado :
--
versions: +Python 3.10, Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue44856>
___
___
Python-bug
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +26141
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27647
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Oh, damn, turns out that there is a ton of reference leaks in the error path of
__build_class__ as well.
These leaks have been since forever!
Curiously I found about them when debugging https://bugs.python.org/issue44524
Change by Pablo Galindo Salgado :
--
title: Possible reference leak in error paths of update_bases() -> Possible
reference leak in error paths of update_bases() and __build_class__
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Wow, turns out the reference leak has been here since forever! I opened
https://bugs.python.org/issue44856? to tackle it
--
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
New changeset 762ef85f441cdec002cb4e812b9e77ae5033e571 by Mark Shannon in
branch '3.10':
bpo-44840: Compiler: Move duplication of exit blocks with no line numbers to
after CFG optimization. (GH-27656) (#27673)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
pull_requests: +26165
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27678
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
If we change the priority of the error messages, which is unclear if is easily
possible, the error will suggest that
print hello should be parenthesized as print (hello) Which if corrected will
leave the "world" part out as a call followed
Pablo Galindo Salgado added the comment:
We probably will need a new set of macros because these macros are public IIRC
correctly. Although as PyObject_GC_UnTrack has a check, we probably can just
absorb it and let backwards compat work by being idempotent if called twice
--
nosy
Pablo Galindo Salgado added the comment:
New changeset bfc2d5a5c4550ab3a2fadeb9459b4bd948ff61a2 by Pablo Galindo Salgado
in branch 'main':
bpo-33930: Fix segfault with deep recursion when cleaning method objects
(GH-27678)
https://github.com/python/cpyt
New submission from Pablo Galindo Salgado :
Given this code:
print(f"Here is that pesky {xxx/2:.3f} again")
The traceback prints:
Traceback (most recent call last):
File "/home/pablogsal/github/python/main/lel.py", line 1, in
print(f"Here is tha
Pablo Galindo Salgado added the comment:
The problem lies here:
https://github.com/python/cpython/blob/f66d00fdd7e9a333accc6bf0e37173051aaa55d0/Parser/string_parser.c#L374-L389
The problem is that the strstr call will fail because the string containing the
expression doesn't hav
Pablo Galindo Salgado added the comment:
Actually, this has even more problems. Because we are using strstr to find the
start of the expression in the parent string, if the expression is repeated the
offsets are incorrectly generated:
For example:
print(f"Here is that {xxx} pesky
Pablo Galindo Salgado added the comment:
Ha, we have test that knows is broken:
https://github.com/python/cpython/blob/f66d00fdd7e9a333accc6bf0e37173051aaa55d0/Lib/test/test_fstring.py#L217
--
___
Python tracker
<https://bugs.python.
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +26209
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27729
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset 8e832fb2a2cb54d7262148b6ec15563dffb48d63 by Pablo Galindo Salgado
in branch 'main':
bpo-44885: Correct the ast locations of f-strings with format specs and
repeated expressions (GH-27729)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
pull_requests: +26221
pull_request: https://github.com/python/cpython/pull/27743
___
Python tracker
<https://bugs.python.org/issue44
Change by Pablo Galindo Salgado :
--
pull_requests: +26222
pull_request: https://github.com/python/cpython/pull/27744
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
New changeset c28c2e1cb0dd5fc8b17514e2c4ee17415af733a4 by Pablo Galindo Salgado
in branch '3.10':
[3.10] bpo-44885: Correct the ast locations of f-strings with format specs and
repeated expressions (GH-27729) (GH-27743)
https://github.
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 4b86c9c5146c339c689830619be9d29b8f7bf417 by Pablo Galindo Salgado
in branch '3.9':
[3.9] bpo-44885: Correct the ast locations of f-strings with format specs and
repeated expressions (GH-27729) (GH-27744)
https://github.
Pablo Galindo Salgado added the comment:
Thanks Neil for the thorough explanation!
I think in any case we should benchmark this because this will affect *all* GC
types if I understand correctly and the TS mechanism had shown slowdowns before
Pablo Galindo Salgado added the comment:
> Is there a separate issue for how we are handling CodeType()?
No, that's why this is marked as release blocker, because this is the first
issue where CodeType was changed.
If you wish to close this one, please open a new issue explai
Pablo Galindo Salgado added the comment:
>> I want to get rid of PyCode_NewWithPosArgs() and just have PyCode_New().
That as added because of PEP 387 and unfortunately removing it is backwards
incompatible.
>> I propose we declare all APIs for code objects *unstable*, liab
Pablo Galindo Salgado added the comment:
I have tried to reproduce this on my Linux and Mac machines and I have been
unable to do it for the time being in either of them.
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
If someone can reproduce more or less reliably, it would be great to know where
are the leaked objects. For that, compile CPython with "-with-trace-refs",
surround the suspicious test in a loop (test_no_hang_on_context_chain_cycle2
for exa
Change by Pablo Galindo Salgado :
--
nosy: -pablogsal
___
Python tracker
<https://bugs.python.org/issue44918>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
> GH-27772 reverts the behaviour change but keeps the fix for the undefined
> behaviour. Can the backport of GH-27772 to the 3.10 branch go in before
> 3.10.0 final?
Thanks for checking with me!
Given that this is fixing a bug that we intr
Pablo Galindo Salgado added the comment:
I'm keeping track to the 3.10 backports to the second rc so could you add me as
a reviewer for the backport?
--
___
Python tracker
<https://bugs.python.org/is
New submission from Pablo Galindo Salgado :
When printing some instance of RegexFlag **in the REPL** it fails to print:
>>> import gc
# This prints a ton of objects, including the bad enum RegexFlag one
>>> gc.get_referrers(None)
Traceback (most recent call last):
F
Pablo Galindo Salgado added the comment:
Same happens when printing a enum.Flag with some values:
>>> enum.Flag(1)
Traceback (most recent call last):
File "", line 1, in
File "/home/pablogsal/github/cpython/Lib/enum.py", line 597, in __call__
Change by Pablo Galindo Salgado :
--
Removed message: https://bugs.python.org/msg399689
___
Python tracker
<https://bugs.python.org/issue44929>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
(Deleted last message because it was incorrect)
--
___
Python tracker
<https://bugs.python.org/issue44929>
___
___
Pytho
Pablo Galindo Salgado added the comment:
Simpler reproducer:
>>> import re
>>> re.RegexFlag(0)
Traceback (most recent call last):
File "", line 1, in
File "/home/pablogsal/github/cpython/Lib/enum.py", line 1399, in
global_flag_repr
return
Pablo Galindo Salgado added the comment:
This looks incorrect:
https://github.com/python/cpython/blob/1512bc21d60f098a9e9f37b44a2f6a9b49a3fd4f/Lib/enum.py#L1399
--
___
Python tracker
<https://bugs.python.org/issue44
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +26258
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27789
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
This is not a bug, check the thread that Serhiy attached. The grammar is, in
principle, correct. For instance, you can do:
def f(a,b,c):
pass
def wrapper(*args, **kw):
return f(c=1, *args, **kw)
wrapper(2,b=2)
And you don't want that
Change by Pablo Galindo Salgado :
--
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue34882>
___
___
Python-bugs-
Pablo Galindo Salgado added the comment:
Also, just to make it clear: changing this would be backwards incompatible, so
if someone is interested, a bigger discussion is needed (starting with
python-ideas/python-dev).
--
___
Python tracker
<ht
Pablo Galindo Salgado added the comment:
>> x = list(range(100))
Is creating a lot of objects, and the gc has a chance to run on every object
creation so maybe what's happening there is that you are inadvertently
triggering the gc
--
___
Pablo Galindo Salgado added the comment:
The opcode cache for load attribute in 3.10 uses the tp_version_tag so unless I
am missing something we can fall into the same problem, no?
--
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
> But it also does identity (pointer) comparison of type/class object
Good point! Even if I wrote that code I forgot about all the guards that were
needed for correctness. I now remember all the weird cases we discovered th
New submission from Pablo Galindo Salgado :
Currently, exception chaining in the C-API must be done by hand. This is a
painstaking process that involves several steps and is very easy to do
incorrectly.
We currently have a private function: _PyErr_ChainExceptions that does this
job. Given
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +26267
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27799
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
I am still amazed that I cannot reproduce the leaks on my machine. Maybe I am
missing some steps.
Could you outline how are you reproducing the leaks?
--
___
Python tracker
<https://bugs.python.
Pablo Galindo Salgado added the comment:
> But this makes it not leak again, so now we know it's the traceback:
The traceback is a very heavy gc object because it contains the frames, and in
the locals of the frame is the traceback itself via the exception. This is a
well known hea
Pablo Galindo Salgado added the comment:
There is some timing-related race condition at hand because I tried in a Linux
machine and a MacBook Pro (intel) laptop and I wasn't able to reproduce after
20 min of the script running :(
--
___
P
Pablo Galindo Salgado added the comment:
Serhiy, what do you suggest we should do then?
--
___
Python tracker
<https://bugs.python.org/issue44938>
___
___
Pytho
Pablo Galindo Salgado added the comment:
Hummm, interesting.
I wonder if this only happens with keywords or if this can be reproduced with
other constructs
--
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
The problem is not the keyword, is that we are parsing correctly until the
"and" and we find the comma there. It happens with anything that invalidates
more items:
>>> from math import sin, cos, $ tan
File "", line 1
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +26279
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27814
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 243b6c3b8fd3144450c477d99f01e31e7c3ebc0f by Erlend Egeberg
Aasland in branch 'main':
bpo-44079: Strip superfluous statement cache from sqlite3.Connection (GH-25998)
https://github.com/python/cpyt
New submission from Pablo Galindo Salgado :
I have noticed that the semantics of PyCode_Addr2Line() have changed from 3.9
to 3.10. Technically, the function was called with:
PyCode_Addr2Line(frame->f_code, frame->f_last_i * 2)
but now it needs to be called with
PyCode_Addr2Line
Pablo Galindo Salgado added the comment:
Sorry, bad copy paste. Correction:
Technically, the function was called with:
PyCode_Addr2Line(frame->f_code, frame->f_last_i)
but now it needs to be called with
PyCode_Addr2Line(frame->f_code, frame->
Pablo Galindo Salgado added the comment:
Are you ok if I add a small comment to the what's new of 3.10?
--
___
Python tracker
<https://bugs.python.org/is
Pablo Galindo Salgado added the comment:
I am marking this as a release blocker, given that this is probably going to
trip a lot of users.
--
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset 878e7267016ba25d05d8736349fb897c756f311d by Erlend Egeberg
Aasland in branch 'main':
bpo-44965: Early exit for non-DML statements in sqlite3.Cursor.executemany()
(GH-27865)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
nosy: -pablogsal
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
As long as the cycles don't actually end in a crash or an infinite cycle, I
think is fine to not include them in the contact.
Even if that were included I don't think is actually a problem. Many APIs in C
or C++ require the user to not f
Pablo Galindo Salgado added the comment:
New changeset 3df0fc89bc2714f5ef03e36a926bc795dcd5e05a by Erlend Egeberg
Aasland in branch 'main':
bpo-44976: Lazy creation of sqlite3 result rows (GH-27884)
https://github.com/python/cpython/commit/3df0fc89bc2714f5ef03e36a926bc7
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
components: -Parser
___
Python tracker
<https://bugs.python.org/issue44999>
___
___
Python-bugs-list mailing list
Unsub
Change by Pablo Galindo Salgado :
--
nosy: -pablogsal
___
Python tracker
<https://bugs.python.org/issue44999>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
New changeset 7ecd3425d45a37efbc745788dfe21df0286c785a by Erlend Egeberg
Aasland in branch 'main':
bpo-27334: roll back transaction if sqlite3 context manager fails to commit
(GH-26202)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 52702e8ba0d777ac92ec36038213976545c4759e by Erlend Egeberg
Aasland in branch '3.9':
[3.9] bpo-27334: roll back transaction if sqlite3 context manager fails to
commit (GH-26202) (GH-27944)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 7903a1096343d8018e889029f025d39bdd077170 by Erlend Egeberg
Aasland in branch 'main':
bpo-43853: Amend NEWS entry for latest changes in sqlite3 (GH-27922)
https://github.com/python/cpython/commit/7903a1096343d8018e889029f025d3
Pablo Galindo Salgado added the comment:
New changeset 0ec17a2494412ea7d76f7d0567b73c1fffa88c18 by Erlend Egeberg
Aasland in branch '3.9':
[3.9] bpo-43853: Amend NEWS entry for latest changes in sqlite3 (GH-27922)
(GH-27952)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset b34ca7e0515e6726cf5e938f7239de41df710cfd by Erlend Egeberg
Aasland in branch '3.10':
[3.10] bpo-43853: Amend NEWS entry for latest changes in sqlite3 (GH-27922).
(GH-27953)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
nosy: +lukasz.langa
___
Python tracker
<https://bugs.python.org/issue44963>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
I am reopening this issue since am_send never got documented here:
https://docs.python.org/3/c-api/typeobj.html#async-structs
--
nosy: +pablogsal
resolution: fixed ->
status: closed -> open
___
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +26401
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27955
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Oh, my bad. I can't find the enum values of the return type, though
(PySendResult).
--
___
Python tracker
<https://bugs.python.org/is
Pablo Galindo Salgado added the comment:
New changeset 6ea6cf22e9d084c27a4fffbbd298098a6ad5b776 by Dong-hee Na in branch
'3.10':
[3.10] bpo-45000: Update whatsnews about deleting __debug__ (GH-27956)
(GH-27958)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 32c1caa87f68a650f2d009a589a1db30484499cb by Dong-hee Na in branch
'3.10':
bpo-45000: Raise SyntaxError when try to delete __debug__ (GH-27947) (GH-27957)
https://github.com/python/cpython/commit/32c1caa87f68a650f2d009a589a1db
Pablo Galindo Salgado added the comment:
The error is correct:
>>> *(2,3,4)
File "", line 1
SyntaxError: can't use starred expression her
The problem is that you are trying to use as top level while:
*(),
is equivalent to:
(*(),)
which is using them in
Pablo Galindo Salgado added the comment:
I prefer to not backport this to 3.10 because technically we cannot introduce
new deprecations in an rc and I don't want someone compiling with -Werror to
crash between rcs.
--
___
Python tracker
&
Pablo Galindo Salgado added the comment:
New changeset 2a80893e5c023a73ccd32cc319f4f0404f548c00 by Erlend Egeberg
Aasland in branch '3.10':
[3.10] bpo-27334: roll back transaction if sqlite3 context manager fails to
commit (GH-26202) (GH-27943)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset f62763d26755260c31c717fb396550e00eb6b2a0 by Erlend Egeberg
Aasland in branch 'main':
bpo-43398: Add test for defect connection factories (GH-27966)
https://github.com/python/cpython/commit/f62763d26755260c31c717fb396550
Pablo Galindo Salgado added the comment:
Is something missing here?
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 86d8b465231473f850cc5e906013ba8581ddb503 by Erlend Egeberg
Aasland in branch 'main':
bpo-16379: expose SQLite error codes and error names in `sqlite3` (GH-27786)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset e34bb409197d72711ae2c6197f9d8305533034d4 by Erlend Egeberg
Aasland in branch 'main':
bpo-45041: Increase coverage for sqlite3.Cursor.executescript() (GH-28074)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
> In term of release process, can we change the traceback after Python 3.10.0
> final? Or can we only change it in Python 3.11?
I don't follow what you want to change in 3.10.0 final, PEP 657 is for Python
3.11. Can
Pablo Galindo Salgado added the comment:
Regarding the issue: I understand what you mean but I don't think we should get
into suppressing the indicators in special situations. Some people may say that
in a line that assigns to a call:
x = foo(x)
^^
highlighting foo() is als
Pablo Galindo Salgado added the comment:
>In my example, there are 6 frames. The indicators cover the whole line of 3
>frames: 50%. It's a common case, it's not special.
Special is not uncommon, is just some different behaviour rather than the
default one. I am not arguin
Pablo Galindo Salgado added the comment:
> Python 3.11 makes it worse: up to 1.5x longer
Sound like you likely want to use the environment variable to deactivate the
extra information ;)
--
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
> I want to backport it to 3.10 or 3.10.1 after Mark's review.
Ok, please, add me as a reviewer to the backport once is ready.
--
___
Python tracker
<https://bugs.python.org
Change by Pablo Galindo Salgado :
--
components: -Build, C API, Parser, Tests, email
nosy: -pablogsal
___
Python tracker
<https://bugs.python.org/issue39
Pablo Galindo Salgado added the comment:
Let's wait for 3.10.1 to backport this because I prefer to keep pyc files
stable for the release candidate. Turns out that people are already preparing
wheels to 3.10 and although this may be fine, I don't want to risk
incompatibiliti
Pablo Galindo Salgado added the comment:
I honestly want to backport it because I think it should not have any negative
impact, but on the other hand I don't feel very confident as the release
candidate phase is supposed to be as close as possible as the final release and
this is not f
Pablo Galindo Salgado added the comment:
> But we've never gotten past just talking about it
Stay tuned! :)
https://github.com/we-like-parsers/cpython/tree/fstring-grammar
--
___
Python tracker
<https://bugs.python.org
Pablo Galindo Salgado added the comment:
I think the best outcome here is to refine the syntax error. Making it behave a
bit better is going to be quite a pain because of how unary "-" and "not" work
on the priority level in the grammar.
I also don't th
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +26599
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28170
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
nosy: -pablogsal
___
Python tracker
<https://bugs.python.org/issue45116>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
IIUC we need to backport PR27655 to 3.10 no? Or do we need something else?
--
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
New changeset 4f88161f07538dfb24a43189fd59bf966cb40817 by Tzu-ping Chung in
branch 'main':
bpo-45035: Make sysconfig posix_home depend on platlibdir (GH-28011)
https://github.com/python/cpython/commit/4f88161f07538dfb24a43189fd59bf
1401 - 1500 of 4424 matches
Mail list logo
