Pablo Galindo Salgado added the comment:
As Steven mentions, match is a soft keyword:
>>> import keyword
>>> keyword.softkwlist
['_', 'case', 'match']
And they don't follow the same rules as key
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +25174
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26589
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Hi,
Unfortunately, the address sanitizer buildbot has been broken by
commit631f9938b1604d4f893417ec339b9e0fa9196fb1 :
https://buildbot.python.org/all/#/builders/585
--
___
Python tracker
<ht
Pablo Galindo Salgado added the comment:
Here is the top trace:
test_jump_in_nested_finally_3 (test.test_sys_settrace.JumpTestCase) ... ok
test_jump_into_finally_block (test.test_sys_settrace.JumpTestCase) ... ok
test_jump_into_finally_block_from_try_block
Pablo Galindo Salgado added the comment:
Eric, I saw thay you ran the buildbots on your PR (thanks a lot), but something
has gone wrong in some of them and they didn't run correctly. For example:
https://buildbot.python.org/all/#/builders/581/builds/58
I'm investigating why
Pablo Galindo Salgado added the comment:
There are many buildbot failures today and this is getting a bit out of hand so
I'm starting with a revert of f3fa63ec75fdbb4a08a10957a5c631bf0c4a5970 until we
have a better plan.
--
___
Python tr
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
nosy_count: 13.0 -> 14.0
pull_requests: +25180
pull_request: https://github.com/python/cpython/pull/26596
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +25179
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26596
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
pull_requests: +25181
pull_request: https://github.com/python/cpython/pull/26597
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
The problem seems to be that The problem is that PyFrame_LocalsToFast(frame,
1); calls into PyFrame_LocalsToFast where co->co_nlocals has a value of 3, and
this causes co->co_cell2arg[i - co->co_nlocals]; to access outside the bounds
of
Pablo Galindo Salgado added the comment:
New changeset 6d518bb3a11f9b16098f45b21a13ebe8f537f045 by Pablo Galindo in
branch 'main':
bpo-44348: Revert "bpo-39573: Py_TYPE becomes a static inline function
(GH-26493)" (GH-26596)
https://github.com/p
Pablo Galindo Salgado added the comment:
New changeset 6d518bb3a11f9b16098f45b21a13ebe8f537f045 by Pablo Galindo in
branch 'main':
bpo-44348: Revert "bpo-39573: Py_TYPE becomes a static inline function
(GH-26493)" (GH-26596)
https://github.com/p
Pablo Galindo Salgado added the comment:
New changeset d334c73b56756e90c33ce06e3a6ec23271aa099d by Pablo Galindo in
branch 'main':
bpo-44335: Fix a regression when identifying invalid characters in syntax
errors (GH-26589)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 3fe921cd49959181163671364c8b84faa88f7895 by Pablo Galindo in
branch 'main':
Revert "bpo-43693: Add the MAKE_CELL opcode and interleave fast locals offsets.
(gh-26396)" (GH-26597)
https://github.com/p
Pablo Galindo Salgado added the comment:
Yes, this one: https://bugs.python.org/issue44348
> s there a bpo issue for the buildbot failures on Windows?
The failures I've been seeing are C stack overflows.
But the ones affecting this issue are the ones in ASAN:
https://buildbot.python
Pablo Galindo Salgado added the comment:
> Long term, I expect to fix it by decoupling the C and Python stacks.
That won't fix half of the Windows failures because the stack overflow you are
seeing are for C to C calls if I am not mistaken. This happens on very deep
calls when co
Change by Pablo Galindo Salgado :
--
Removed message: https://bugs.python.org/msg395330
___
Python tracker
<https://bugs.python.org/issue43693>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
> Are there a bpo issue for the buildbot failures on Windows?
Yes, this one: https://bugs.python.org/issue44348
But just to clarify, the ones affecting this issue are the ones in ASAN, for
example:
https://buildbot.python.org/all/#/builders/
Pablo Galindo Salgado added the comment:
New changeset 1c02655fb08043b3027748ca1179c416c21a4277 by Erlend Egeberg
Aasland in branch 'main':
bpo-44329: Refactor sqlite3 statement creation (GH-26566)
https://github.com/python/cpython/commit/1c02655fb08043b3027748ca1179c4
Change by Pablo Galindo Salgado :
--
pull_requests: +25191
pull_request: https://github.com/python/cpython/pull/26608
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
Lysandros, could you take a look?
--
___
Python tracker
<https://bugs.python.org/issue44349>
___
___
Python-bugs-list m
Pablo Galindo Salgado added the comment:
This affects also older versions:
python3.8 lel.py
File "lel.py", line 3
^
SyntaxError: Generator expression must be parenthesized
--
title: Edge case in pegen's error displaying with non-utf8 lines ->
Pablo Galindo Salgado added the comment:
New changeset bafe0aade5741ab0d13143ee261711fdd65e8a1f by Pablo Galindo in
branch 'main':
bpo-44335: Ensure the tokenizer doesn't go into Python with the error set
(GH-26608)
https://github.com/python
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +25194
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26611
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
I think the simplest solution is PR 26611.
Ammar, can you check if that works for you?
--
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
New changeset 9fd21f649d66dcb10108ee395fd68ed32c8239cd by Pablo Galindo in
branch 'main':
bpo-44349: Fix edge case when displaying text from files with encoding in
syntax errors (GH-26611)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset c0496093e54edb78d2bd09b083b73e1e5b9e7242 by Miss Islington (bot)
in branch '3.10':
bpo-44349: Fix edge case when displaying text from files with encoding in
syntax errors (GH-26611) (GH-26616)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
Buildbots have the priority, please don't merge anything that breaks the
buildbots. We should figure out how to silence the false positive if indeed is
one, but I don't think it is. The address sanitizer is not speculative, it
literally
Pablo Galindo Salgado added the comment:
I don't think that's a segfault. That seems that the process was killed no?
Also, the buildbot is green so this is not happening in the latest builds
--
___
Python tracker
<https://bu
Pablo Galindo Salgado added the comment:
I can reproduce that failure of address sanitizer with GCC and clang
separately, so it doesn't seem like a false positive.
--
___
Python tracker
<https://bugs.python.org/is
Pablo Galindo Salgado added the comment:
Also, I can reproduce locally without any fork whatsoever:
./python -m test test_lib2to3
SUMMARY: AddressSanitizer: heap-buffer-overflow Python/ceval.c:3549 in
_PyEval_EvalFrameDefault
Shadow bytes around the buggy address:
0x0c1c8003ec40: fa fa fa
Pablo Galindo Salgado added the comment:
Even valgrind sees the problem:
❯ valgrind ./python -m test test_lib2to3
==27010== Memcheck, a memory error detector
==27010== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==27010== Using Valgrind-3.17.0 and LibVEX; rerun with -
Pablo Galindo Salgado added the comment:
I'm closing this as 3 different tools complain about the same thing, with a
very simple reproducer.
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python t
Pablo Galindo Salgado added the comment:
But SIGSEGV is signal 11, not -9
--
___
Python tracker
<https://bugs.python.org/issue44360>
___
___
Python-bugs-list m
Pablo Galindo Salgado added the comment:
As I mentioned in https://bugs.python.org/issue43693, the way to run it is the
following:
$ export ASAN_OPTIONS=detect_leaks=0:allocator_may_return_null=1:handle_segv=0
$ ./configure --with-address-sanitizer --without-pymalloc
$ make -j -s
$ ./python
Pablo Galindo Salgado added the comment:
> Do you think it would be it feasible to run the address sanitizer on all PRs,
> so that we can keep it passing?
That's a good idea,let me see how easy doing that would be
--
___
Python trac
Pablo Galindo Salgado added the comment:
> It seems like ceval.c:1600 upsets the sanitizer, at least for gcc.
Even if you don't trust the sanitizer, you can also use valgrind, it shows the
same error:
❯ valgrind ./python -m test test_lib2to3
==27010== Memcheck, a memory error
Pablo Galindo Salgado added the comment:
This is not a false positive. I break into gdb at the moment the sanitizer
makes the report and inspecting the values that apparently are wrong. I did
that by breaking into __sanitizer::ColorizeReports which is called for making
the report. THis is
Pablo Galindo Salgado added the comment:
commit e858ea15718709bc8ec3c13bd8451ff7d62cbe80 (HEAD -> specialize-load-attr)
Author: Mark Shannon
Date: Wed Jun 9 09:33:13 2021 +0100
Assert that address is in bounds (ASAN thinks it might not be).
diff --git a/Python/ceval.c b/Python/ceva
Pablo Galindo Salgado added the comment:
Closing as this would obviously need a PEP, please open a discusion first on
python-ideas
--
nosy: +pablogsal
resolution: -> rejected
stage: -> resolved
status: open -> closed
___
Python tracke
Pablo Galindo Salgado added the comment:
I am quite sure this is not a segmentation fault, Victor.
--
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
We'll wait for more builds, but for now the buildbot is green so I think this
should be closed and reopened if we see it again.
--
___
Python tracker
<https://bugs.python.org/is
Pablo Galindo Salgado added the comment:
Is anything left in this issue?
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue44187>
___
___
Pablo Galindo Salgado added the comment:
>From the gdb session looks to me that you are reading freed or invalid memory
>from the dictionary keys. Well, I'm quite sure you are doing that, but I don't
>know why they is happening.
--
___
Pablo Galindo Salgado added the comment:
Probably, otherwise is going to hurt because the syntax errors that you
describe trigger when two names are place together, which in general is a
missing comma.
The error message also doesn't say: "you are missing a comma" it says
Pablo Galindo Salgado added the comment:
The backtracking with the soft keyword may make this very annoying, by the way.
--
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
Oh, wait, I think I misunderstood the problem. The problem is that the parser
is backtracking and identifying match as a name.
Indeed, the soft keyword is a pain :(
--
___
Python tracker
<ht
Pablo Galindo Salgado added the comment:
I think it actually will be very useful to explain that these cases are invalid
in the Syntax error, which will also solve this problem.
This on the other hand shows a bigger problem: any generic syntax error that
happens inside "match" wil
Pablo Galindo Salgado added the comment:
Oh, turns out I already added machinery to solved this but I was missing a
piece!
--
___
Python tracker
<https://bugs.python.org/issue44
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +25216
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26630
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
> Is this covered by your fix?
No, that is not a backtracking error (is not going all the way to the "match"
expression).
--
___
Python tracker
<https://bugs.pytho
New submission from Pablo Galindo Salgado :
Let's asume this string:
"
x = "Cannot recover from "MemoryErrors" while something happnes while "
The line is incorrect because the quotes arround MemoryErrors are the same as
the string is used, resulting in STRING +
Pablo Galindo Salgado added the comment:
I will fix that one in another PR
--
___
Python tracker
<https://bugs.python.org/issue44368>
___
___
Python-bugs-list m
Pablo Galindo Salgado added the comment:
New changeset 457ce60fc70f1c9290023f46fb82b6a490dff32e by Pablo Galindo in
branch 'main':
bpo-44368: Ensure we don't raise incorrect custom syntax errors with soft
keywords (GH-26630)
https://github.com/python
Pablo Galindo Salgado added the comment:
Oh, this one is actually correct:
match ...:
case 42 as _:
pass
File "", line 2
case 42 as _:
^
SyntaxError: expected ':'
That is literally expecting a ":" and that's the error. It
Pablo Galindo Salgado added the comment:
> Could we just try parsing "as _" and raise if so? That wouldn't conflict with
> any existing rules, and that way we could actually have a helpful error
> message.
No, the same happens with other targets such as:
File
Change by Pablo Galindo Salgado :
--
pull_requests: +25218
pull_request: https://github.com/python/cpython/pull/26632
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
Checkout PR 26632, and see if this works for you
--
___
Python tracker
<https://bugs.python.org/issue44368>
___
___
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +25219
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26633
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 31aa0dbff4c1d39c9d77c6c8f4a61d0e46c1268b by Mark Shannon in
branch 'main':
bpo-44363: Get test_capi passing with address sanitizer (GH-26639)
https://github.com/python/cpython/commit/31aa0dbff4c1d39c9d77c6c8f4a61d
Pablo Galindo Salgado added the comment:
New changeset 05073036dcecefc00b0c3e7397601809da41e2f1 by Pablo Galindo in
branch 'main':
bpo-44368: Improve syntax errors with invalid as pattern targets (GH-26632)
https://github.com/python/cpython/commit/05073036dcecefc00b0c3e73976018
Change by Pablo Galindo Salgado :
--
pull_requests: +25247
pull_request: https://github.com/python/cpython/pull/26632
___
Python tracker
<https://bugs.python.org/issue38
Pablo Galindo Salgado added the comment:
Here is a smaller reproducer:
x = "ijosdfsd\
def blech():
pass
This seems to be an error with:
commit a698d52c3975c80b45b139b2f08402ec514dce75
Author: Batuhan Taskaya
Date: Thu Jan 21 00:38:47 2021 +0300
bpo-40176: Improve error mes
Pablo Galindo Salgado added the comment:
I think this should fix the issue, but someone should validate this:
diff --git a/Parser/tokenizer.c b/Parser/tokenizer.c
index 6002f3e05a..1c28737183 100644
--- a/Parser/tokenizer.c
+++ b/Parser/tokenizer.c
@@ -1084,17 +1084,16 @@ syntaxerror(struct
Pablo Galindo Salgado added the comment:
This affects 3.10 as well
--
versions: +Python 3.10
___
Python tracker
<https://bugs.python.org/issue44396>
___
___
Change by Pablo Galindo Salgado :
--
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issue44396>
___
___
Python-bugs-list mai
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +25262
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26676
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Ok, found the problem, we are not resetting the multi-line-start pointer when
we are reallocating the tokenizer buffers.
--
stage: patch review ->
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset af5fb6706219d7949c1db5c9f2b7da53198123f3 by Miss Islington (bot)
in branch '3.8':
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the test suite
(GH-26542) (GH-26670)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
alessandro mantovani, one question, how did you generate the crash scripts?
--
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
New changeset d03f342a8389f1ea9100efb0d1a205601e607254 by Miss Islington (bot)
in branch '3.10':
bpo-44396: Update multi-line-start location when reallocating tokenizer buffers
(GH-26676) (GH-26695)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
Well, in both cases this means that the line number is not available. I think
None is a bit cleaner in this regard.
--
___
Python tracker
<https://bugs.python.org/issue44
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +25300
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26712
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
keywords: +3.10regression, 3.9regression -patch
___
Python tracker
<https://bugs.python.org/issue44409>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
New changeset 507ed6fa1d6661e0f8e6d3282764aa9625a99594 by Pablo Galindo in
branch 'main':
bpo-44409: Fix error location in tokenizer errors that happen during
initialization (GH-26712)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
pull_requests: +25313
pull_request: https://github.com/python/cpython/pull/26723
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
New changeset 0d0a9eaa822658679cc2b65f125ab74bfd4aedfe by Pablo Galindo in
branch '3.9':
[3.9] bpo-44409: Fix error location in tokenizer errors that happen during
initialization (GH-26712). (GH-26723)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
One problem with that is that the lookahead will move the error indicator to
some incorrect place if the match fails. For example:
PYTHON3.9
>>> "dfssdfsdfsd" fdsf sdfsdfsd {}
File "", line 1
Pablo Galindo Salgado added the comment:
New changeset 00710e6346fd2394aa020b2dfae170093effac98 by Erlend Egeberg
Aasland in branch 'main':
bpo-43908: Make heap types converted during 3.10 alpha immutable (GH-26351)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 7297d74251de3b1c02dcdb9ca281461cc7fb4535 by Miss Islington (bot)
in branch '3.10':
bpo-43908: Make heap types converted during 3.10 alpha immutable (GH-26351)
(GH-26766)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
Unfortunately these are tokenizer errors and the tokenizer had no idea of
what's a function, so introducing syntactic structure in the error is going to
be quite error prone, as the tokenizer still sees whitespace and other stuff
that the p
Pablo Galindo Salgado added the comment:
But thanks a lot for the proposal!
--
___
Python tracker
<https://bugs.python.org/issue8>
___
___
Python-bugs-list m
Pablo Galindo Salgado added the comment:
Indeed, as Andre mentions your example is different because in you case the
call is interpreted as a generator comprehension, not as a function call.
--
resolution: -> not a bug
stage: -> resolved
status: open -&g
Change by Pablo Galindo Salgado :
--
pull_requests: +25376
pull_request: https://github.com/python/cpython/pull/26792
___
Python tracker
<https://bugs.python.org/issue44
New submission from Pablo Galindo Salgado :
This got me confused for a sec when doing some live demo:
>>> match x:
...case A(y=1, foo):
File "", line 2
case A(y=1, foo):
^
SyntaxError: invalid syntax
I propose to improve this to:
>>>
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +25377
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26793
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Btw, I noticed this is allowed:
>>> match x:
...case A(foo, t=3):
......
...
but this is not:
>>> match x:
...case A(foo=3, t):
Is that on pourpose?
--
___
Pyth
Pablo Galindo Salgado added the comment:
If this is supposed to mirror function calls, maybe the error should be::
>>> match a:
...case A(foo=3, t):
File "", line 2
case A(foo=3, t):
^
SyntaxError: positional patterns foll
Pablo Galindo Salgado added the comment:
New changeset a8c418d5ed1103106db547aa576b82c6031985a4 by Pablo Galindo in
branch '3.10':
[3.10] bpo-44368: Improve syntax errors with invalid as pattern targets
(GH-26632) (GH-26792)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
Mark, can you take a look at this?
--
nosy: +pablogsal
versions: +Python 3.11 -Python 3.10
___
Python tracker
<https://bugs.python.org/issue44
Change by Pablo Galindo Salgado :
--
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issue6>
___
___
Python-bugs-list mai
Change by Pablo Galindo Salgado :
--
keywords: +3.10regression
priority: normal -> deferred blocker
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset 185ecdc1463c527743eeb16a5deef75c1985de79 by Erlend Egeberg
Aasland in branch 'main':
bpo-40956: Convert sqlite3.connect and sqlite3.Connection.__init__ to AC
(GH-24421)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 7d0a47e1affd0a2f56600f3e9473f55f931595bd by Erlend Egeberg
Aasland in branch 'main':
bpo-44087: Disallow instantiation of sqlite3.Statement (GH-26567)
https://github.com/python/cpython/commit/7d0a47e1affd0a2f56600f3e9473f5
1001 - 1100 of 4424 matches
Mail list logo
