[issue46274] Tokenizer module does not handle backslash characters correctly

2022-01-06 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- title: backslash creating statement out of nothing -> Tokenizer module does not handle backslash characters correctly ___ Python tracker <https://bugs.python.org/issu

[issue46280] About vulnerabilities in Cpython native code

2022-01-06 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Based on the research of the result, I tried to design a tool to > automatically detect and repair vulnerabilities in CPython and make this tool > available. See: You mention here that your tool automatically "repairs" the code.

[issue46263] FreeBSD buildbots cannot compile Python

2022-01-06 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Is this under control, or do you still need help with some part? As Christian mentions, we still have the test_embed issue -- ___ Python tracker <https://bugs.python.org/issu

[issue46280] About vulnerabilities in Cpython native code

2022-01-06 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > I don't see how this could be an uninitialized read, although I'm willing to > be wrong. It can be uninitialized if the parenstack[nested_depth] value is itself initialized, which can happen if the memory block pointed by parensta

[issue46280] About vulnerabilities in Cpython native code

2022-01-06 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Anyway, (if I'm right,) this makes my points that a) there are false > positives, and b) we should have separate issues for each actual problem. Sorry Eric, I failed to clarify my comment: you are absolutely right in your analysis. I wa

[issue46289] AST: FomattedValue conversion's default value should be -1

2022-01-07 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +BTaskaya ___ Python tracker <https://bugs.python.org/issue46289> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46295] Subinterpreters hang in GIL adquisition if an extension module calls PyGILState_Ensure.

2022-01-07 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : Reproducer: Code for native_ext.cpp: #define PY_SSIZE_T_CLEAN #include #include #include #include #pragma GCC push_options #pragma GCC optimize ("O0") PyObject* run_simple(PyObject*, PyObject*) { PyGILState_ST

[issue46289] AST: FomattedValue conversion's default value should be -1

2022-01-07 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I think A is the best option -- ___ Python tracker <https://bugs.python.org/issue46289> ___ ___ Python-bugs-list mailin

[issue46295] Subinterpreters hang in GIL adquisition if an extension module calls PyGILState_Ensure.

2022-01-07 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> duplicate stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue46295] Subinterpreters hang in GIL adquisition if an extension module calls PyGILState_Ensure.

2022-01-07 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Yeah, this is indeed related/duplicate of bpo-15751 -- ___ Python tracker <https://bugs.python.org/issue46295> ___ ___

[issue46295] Subinterpreters hang in GIL adquisition if an extension module calls PyGILState_Ensure.

2022-01-07 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- superseder: -> [subinterpreters] Make the PyGILState API compatible with subinterpreters ___ Python tracker <https://bugs.python.org/issu

[issue46237] Incorrect line reported in syntax error

2022-01-07 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +eric.smith ___ Python tracker <https://bugs.python.org/issue46237> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46237] Incorrect line reported in syntax error

2022-01-07 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: This also affects 3.9 I imagine, no? -- ___ Python tracker <https://bugs.python.org/issue46237> ___ ___ Python-bug

[issue46237] Incorrect line reported in syntax error

2022-01-07 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +28666 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/30463 ___ Python tracker <https://bugs.python.org/issu

[issue46289] AST: FomattedValue conversion's default value should be -1

2022-01-07 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I would say yes, for consistency. It doesn't have any effects on user code that I am aware -- ___ Python tracker <https://bugs.python.org/is

[issue46237] Incorrect line reported in syntax error

2022-01-07 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Please Andre and Terry, test this fix as much as you want. I am quite sure is correct, but it is far-reaching so I want to make sure every situation that we can think of is correct (and remains correct

[issue46006] [subinterpreter] _PyUnicode_EqualToASCIIId() issue with subinterpreters

2022-01-07 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- priority: release blocker -> ___ Python tracker <https://bugs.python.org/issue46006> ___ ___ Python-bugs-list mai

[issue46237] Incorrect line reported in syntax error

2022-01-07 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I did some testing on my own using a code generator and a bunch of weird cases and I am confident this works. I am going to include this in the next alpha but will wait for your validation for some days before merging the backports

[issue46237] Incorrect line reported in syntax error

2022-01-07 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 6fa8b2ceee38187b0ae96aee12fe4f0a5c8a2ce7 by Pablo Galindo Salgado in branch 'main': bpo-46237: Fix the line number of tokenizer errors inside f-strings (GH-30463) https://github.com/python/cpyt

[issue46301] Enum tests: One branch is not covered in `Enum._convert_`

2022-01-09 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Seems that this PR has broken the refleak buildbots: https://buildbot.python.org/all/#/builders/320/builds/269/ https://buildbot.python.org/all/#/builders/384/builds/255 According to our buildbot policy, if this is not fixed in 24h we will need to

[issue46167] Parse assert (x == y, "Descriptive text") as statement params instead of a tuple

2022-01-09 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I created a PEP to formally propose the change: https://www.python.org/dev/peps/pep-0679/ -- ___ Python tracker <https://bugs.python.org/issue46

[issue46314] Stray RESUME opcode for unused lambda

2022-01-10 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Unfortunately the release of 3.11.0a4 is already underway and we are waiting for Steve's windows binaries, so this will need to wait for alpha 5 -- ___ Python tracker <https://bugs.python.org/is

[issue46339] PEG parser segfault from ast.literal_eval

2022-01-11 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Seems that the regression is caused by this commit: 6fa8b2ceee38187b0ae96aee12fe4f0a5c8a2ce7 is the first bad commit commit 6fa8b2ceee38187b0ae96aee12fe4f0a5c8a2ce7 Author: Pablo Galindo Salgado Date: Sat Jan 8 00:23:40 2022 + bpo-46237

[issue46339] PEG parser segfault from ast.literal_eval

2022-01-11 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: The reason is that the line numbers are now correctly identified, and that causes existing code to not work correctly :( -- ___ Python tracker <https://bugs.python.org/issue46

[issue46339] PEG parser segfault from ast.literal_eval

2022-01-11 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +28730 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/30529 ___ Python tracker <https://bugs.python.org/issu

[issue46237] Incorrect line reported in syntax error

2022-01-11 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +28741 pull_request: https://github.com/python/cpython/pull/30543 ___ Python tracker <https://bugs.python.org/issue46

[issue46237] Incorrect line reported in syntax error

2022-01-11 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue46237] Incorrect line reported in syntax error

2022-01-11 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Backporting this to 3.9 is a bit more challenging and more changes are required, so I am not backporting for 3.9 to avoid unintended side effects. -- ___ Python tracker <https://bugs.python.org/issue46

[issue46339] PEG parser segfault from ast.literal_eval

2022-01-11 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +28743 pull_request: https://github.com/python/cpython/pull/30545 ___ Python tracker <https://bugs.python.org/issue46

[issue46347] memory leak in PyEval_EvalCodeEx

2022-01-11 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Turns out this leak affects CYthon quite a lot: https://github.com/cython/cython/blob/29ad96444b8b1a4f05a6ac2328fde01de4782691/Cython/Utility/ObjectHandling.c#L2139-L2155 This seems to imply that every function call using __Pyx_PyCFunction_FastCall

[issue46347] memory leak in PyEval_EvalCodeEx

2022-01-11 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Apparently, this is causing adyncpg to leak megabytes in seconds -- ___ Python tracker <https://bugs.python.org/issue46

[issue46347] memory leak in PyEval_EvalCodeEx

2022-01-11 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Could it wait for 3.10.2 already scheduled for four weeks from now? I don't feel comfortable leaving a ton of Cython functions leaking memory constantly on many function calls. According to https://github.com/MagicStack/asyncpg/issues/874

[issue46339] PEG parser segfault from ast.literal_eval

2022-01-18 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 8c2fd09f365e082cfceb29afdf38953cdd670946 by Pablo Galindo Salgado in branch 'main': bpo-46339: Include clarification on assert in 'get_error_line_from_tokenizer_buffers' (#30545) https://github.com/p

[issue46231] grammar rule definition is missing: invalid_double_starred_kvpairs

2022-01-19 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 353674f289076eecf848d7a26871cce529b89a98 by Miss Islington (bot) in branch '3.9': bpo-46231: Remove invalid_* rules preceded by more tokens from the grammar docs (GH-30341) (GH-30392) https://github.com/python/cpyt

[issue46441] Caret points to wrong line on 'return yield 42' in REPL

2022-01-20 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +28909 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30718 ___ Python tracker <https://bugs.python.org/issu

[issue46339] PEG parser segfault from ast.literal_eval

2022-01-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 1fb1f5d8bd084c20f0a5fde547b563c08d103f09 by Miss Islington (bot) in branch '3.10': [3.10] bpo-46339: Fix crash in the parser when computing error text for multi-line f-strings (GH-30529) (GH-30542) https://github.com/pyth

[issue46339] PEG parser segfault from ast.literal_eval

2022-01-20 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue46441] Caret points to wrong line on 'return yield 42' in REPL

2022-01-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Thanks for the bug report, Guido! Everything should be ok now -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue46240] Incorrect hint about forgetting a comma

2022-01-22 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +29005 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/30819 ___ Python tracker <https://bugs.python.org/issu

[issue46240] Incorrect hint about forgetting a comma

2022-01-22 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 633db1c4eb863a1340e45c353e36f2f8dcf5945c by Pablo Galindo Salgado in branch '3.10': [3.10] bpo-46240: Correct the error for unclosed parentheses when the tokenizer is not finished (GH-30378). (GH-30819) https://github.com/pyth

[issue46485] ~ PEG operator in the grammar

2022-01-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: It means the same as if there is alternatives: if it fails to parse then it will immediately fail. We place them in rules like this in preparation for extension or in case there are invalid_* rules in the same set (which doesn't appear in the gr

[issue46485] ~ PEG operator in the grammar

2022-01-23 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> not a bug status: open -> closed ___ Python tracker <https://bugs.python.org/issue46485> ___ ___ Pyth

[issue46503] assertion failure in Parser/string_parser.c

2022-01-24 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +eric.smith ___ Python tracker <https://bugs.python.org/issue46503> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46503] assertion failure in Parser/string_parser.c

2022-01-24 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Adding Eric as this seems to be in the f-string parser. -- ___ Python tracker <https://bugs.python.org/issue46

[issue35095] Implement pathlib.Path.append_bytes and pathlib.Path.append_text

2022-01-24 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: -pablogsal ___ Python tracker <https://bugs.python.org/issue35095> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

2022-01-24 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: This issue is not related to the parser, so I am unmarking it. -- components: -Parser ___ Python tracker <https://bugs.python.org/issue46

[issue33125] Windows 10 ARM64 platform support

2022-01-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: No problem! What do I need to update? The script to add the binaries to the release page? -- ___ Python tracker <https://bugs.python.org/issue33

[issue46503] assertion failure in Parser/string_parser.c

2022-01-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Thanks for the quick fix, Eric! -- ___ Python tracker <https://bugs.python.org/issue46503> ___ ___ Python-bugs-list m

[issue46502] Py_CompileString no longer allows to tell "incomplete input" from "invalid input"

2022-01-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Indeed, these new errors are due to the new parser. Unfortunately, the new parser doesn't allow to check against incomplete input the way the old one did so that piece of documentation is unfortunately outdated. We should remove it to avoid fu

[issue46502] Py_CompileString no longer allows to tell "incomplete input" from "invalid input"

2022-01-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > However, I'm very keen to learn what is an alternative solution then to > distinguish hard invalid from incomplete input. IOW, what would be the new > way of achieving what's described in the old FAQ? Unfortunately, there is no

[issue46521] compile_command not raising syntax error when command ends with triple quotes

2022-01-25 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: -pablogsal ___ Python tracker <https://bugs.python.org/issue46521> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46521] compile_command not raising syntax error when command ends with triple quotes

2022-01-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: This is due to the fact that the new parser doesn't detect the syntax error of "abc def" after it has parsed the full text, but before that happens, the tokenizer has detected a problem (the ''' is not closed) and this is

[issue46521] compile_command not raising syntax error when command ends with triple quotes

2022-01-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > wontfix would really suck, because that would mean every REPL written with > the `code` module will be broken, even IPython: I understand, but I don't see a way to fix this without reverting the change to detect unclosed triple quites

[issue46521] compile_command not raising syntax error when command ends with triple quotes

2022-01-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Can you help me figure out why this bug doesn't show up in the normal Python > REPL? That's because the normal Python REPL works very differently when in interactive mode. This is because the tokenizer in interactive mode is coupl

[issue46521] compile_command not raising syntax error when command ends with triple quotes

2022-01-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > because my requirement is to detect if a code can be incomplete Python code, > without ever compiling it. AS I mentioned in other issues, unfortunately the new parser doesn't allow to do this as the old one does, because how it works.

[issue46524] test_peg_generator takes 8 minutes on Windows

2022-01-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: The test needs to build a lot of C extensions with different parsers, and that compilation is what takes most of the time. I don't think we should skip these tests by default on Windows, as it gives us valuable information (that the parser fea

[issue46091] IndendationError from multi-line indented statements

2022-01-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset a0efc0c1960e2c49e0092694d9839270914c by Pablo Galindo Salgado in branch 'main': bpo-46091: Correctly calculate indentation levels for whitespace lines with continuation characters (GH-30130) https://github.com/python/cpyt

[issue46091] IndendationError from multi-line indented statements

2022-01-25 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +29077 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30898 ___ Python tracker <https://bugs.python.org/issu

[issue46091] IndendationError from multi-line indented statements

2022-01-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 3fc8b74ace033a17346a992f661928ba619e61e8 by Pablo Galindo Salgado in branch '3.10': [3.10] bpo-46091: Correctly calculate indentation levels for whitespace lines with continuation characters (GH-30130). (GH-30898) https://

[issue46091] IndendationError from multi-line indented statements

2022-01-25 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +29078 pull_request: https://github.com/python/cpython/pull/30899 ___ Python tracker <https://bugs.python.org/issue46

[issue46091] IndendationError from multi-line indented statements

2022-01-25 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue46502] Py_CompileString no longer allows to tell "incomplete input" from "invalid input"

2022-01-26 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset f0a648152f2d8011f47cc49873438ebaf01d3f82 by Mateusz Łoskot in branch 'main': bpo-46502: Remove "How do I tell incomplete input" from FAQ (GH-30925) https://github.com/python/cpython/commit/f0a648152f2d8011f47c

[issue46502] Py_CompileString no longer allows to tell "incomplete input" from "invalid input"

2022-01-26 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +29112 pull_request: https://github.com/python/cpython/pull/30933 ___ Python tracker <https://bugs.python.org/issue46

[issue46502] Py_CompileString no longer allows to tell "incomplete input" from "invalid input"

2022-01-26 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +29113 pull_request: https://github.com/python/cpython/pull/30934 ___ Python tracker <https://bugs.python.org/issue46

[issue46502] Py_CompileString no longer allows to tell "incomplete input" from "invalid input"

2022-01-26 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset dafada393f9a790461430e2493ea1379e938b51a by Pablo Galindo Salgado in branch '3.9': [3.9] bpo-46502: Remove "How do I tell incomplete input" from FAQ (GH-30925) (GH-30934) https://github.com/p

[issue46502] Py_CompileString no longer allows to tell "incomplete input" from "invalid input"

2022-01-26 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue46502] Py_CompileString no longer allows to tell "incomplete input" from "invalid input"

2022-01-26 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset c7af838805ddf52320bce3d5978bfdd37eed1b3a by Pablo Galindo Salgado in branch '3.10': [3.10] bpo-46502: Remove "How do I tell incomplete input" from FAQ (GH-30925) (GH-30933) https://github.com/p

[issue46329] Split up the CALL_NO_KW and CALL_KW instructions.

2022-01-28 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Seems that this PR is causing some segfaults. See https://github.com/python/cpython/pull/30855#issuecomment-1024658459 -- nosy: +pablogsal ___ Python tracker <https://bugs.python.org/issue46

[issue46572] Unicode identifiers not necessarily unique

2022-01-29 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: This seems coherent with https://www.python.org/dev/peps/pep-3131/ to me. The parser ensures all identifiers are converted into the normal form NFKC while parsing; comparison of identifiers is based on NFKC

[issue46521] codeop._maybe_compile passes code with error + triple quotes

2022-01-29 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: >> Pablo, is there any possibility that the internal REPL parser could be >> wrapped, exposed to Python, and called with fake stdin/out/err objects? I would really advise against this. Unfortunately, the state of affairs is that the REP

[issue46521] codeop._maybe_compile passes code with error + triple quotes

2022-01-29 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +29189 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31010 ___ Python tracker <https://bugs.python.org/issu

[issue46329] Split up the CALL_NO_KW and CALL_KW instructions.

2022-01-29 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +29190 pull_request: https://github.com/python/cpython/pull/31011 ___ Python tracker <https://bugs.python.org/issue46

[issue46329] Split up the CALL_NO_KW and CALL_KW instructions.

2022-01-29 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I'm reverting #30855 for the time being given our buildbot policy. -- ___ Python tracker <https://bugs.python.org/is

[issue46329] Split up the CALL_NO_KW and CALL_KW instructions.

2022-01-29 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- Removed message: https://bugs.python.org/msg412088 ___ Python tracker <https://bugs.python.org/issue46329> ___ ___ Python-bug

[issue46329] Split up the CALL_NO_KW and CALL_KW instructions.

2022-01-29 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I'm reverting PR30855 for the time being given our buildbot policy. -- ___ Python tracker <https://bugs.python.org/is

[issue46521] codeop._maybe_compile passes code with error + triple quotes

2022-01-29 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Ugh, the approach to do that breaks super heavily test_idle :( -- ___ Python tracker <https://bugs.python.org/issue46

[issue46521] codeop._maybe_compile passes code with error + triple quotes

2022-01-29 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: If we want to go with this approach, I am going to need help to fix test_idle as I have no idea why is failing if test_codeop passes. -- ___ Python tracker <https://bugs.python.org/issue46

[issue46521] codeop._maybe_compile passes code with error + triple quotes

2022-01-30 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > The message is off That's because the tokenizer sees the error before the parser even has time to see the other one. Not sure if is technically anything to fix here other than the order of reporting two different errors, which may be a bi

[issue46600] Python built with clang -O0 allocates 10x more stack memory than clang -O3 on a Python function call

2022-02-01 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: PR 31052 seems to have broken a bunch of buildbots. If no fix is provided in 24 hours, we will need to revert :( -- nosy: +pablogsal ___ Python tracker <https://bugs.python.org/issue46

[issue46633] AddressSanitizer: Skip tests directly in Python, not with external config

2022-02-04 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I have recently added some decorators in test. support to deactivate tests if running under the sanitizers. -- ___ Python tracker <https://bugs.python.org/issue46

[issue46674] Two if in a row in generators

2022-02-07 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Please, stop reopening the issue. The syntax is valid python syntax and we will not be able to make it invalid -- resolution: -> not a bug status: open -> closed ___ Python tracker

[issue46521] codeop._maybe_compile passes code with error + triple quotes

2022-02-08 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 69e10976b2e7682c6d57f4272932ebc19f8e8859 by Pablo Galindo Salgado in branch 'main': bpo-46521: Fix codeop to use a new partial-input mode of the parser (GH-31010) https://github.com/python/cpyt

[issue46521] codeop._maybe_compile passes code with error + triple quotes

2022-02-08 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +29383 pull_request: https://github.com/python/cpython/pull/31213 ___ Python tracker <https://bugs.python.org/issue46

[issue46521] codeop._maybe_compile passes code with error + triple quotes

2022-02-08 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 5b58db75291cfbb9b6785c9845824b3e2da01c1c by Pablo Galindo Salgado in branch '3.10': [3.10] bpo-46521: Fix codeop to use a new partial-input mode of the parser (GH-31010). (GH-31213) https://github.com/python/cpyt

[issue46521] codeop._maybe_compile passes code with error + triple quotes

2022-02-08 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I am not backporting to 3.9 because the parser is different enough that introducing this would also introduce some unintended side effects. -- resolution: -> fixed stage: patch review -> resolved status: open -&g

[issue43366] Unclosed bracket bug in code.interact prevents identifying syntax errors

2022-02-08 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: This has been fixed by commit 69e10976b2e7682c6d57f4272932ebc19f8e8859: Python 3.11.0a5+ (heads/main:69e10976b2, Feb 8 2022, 12:30:20) [Clang 12.0.0 (clang-1200.0.32.29)] on darwin Type "help", "copyright", "credits" or

[issue43366] Unclosed bracket bug in code.interact prevents identifying syntax errors

2022-02-08 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.11 ___ Python tracker <https://bugs.python.or

[issue46703] boolean operation issue (True == False == False)

2022-02-09 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: This is not a bug. Please check the docs on the ternary operator: https://docs.python.org/3/reference/expressions.html#comparisons In particular: Comparisons can be chained arbitrarily, e.g., x < y <= z is equivalent to x < y and y <= z,

[issue46703] boolean operation issue (True == False == False)

2022-02-09 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- Removed message: https://bugs.python.org/msg412963 ___ Python tracker <https://bugs.python.org/issue46703> ___ ___ Python-bug

[issue46703] boolean operation issue (True == False == False)

2022-02-09 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: This is not a bug. Please check the docs on the ternary operator: https://docs.python.org/3/reference/expressions.html#comparisons In particular: Comparisons can be chained arbitrarily, e.g., x < y <= z is equivalent to x < y and y <= z,

[issue46704] Parser API not checking for null-terminator

2022-02-09 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Could you please provide an example input to reproduce this? -- ___ Python tracker <https://bugs.python.org/issue46

[issue46704] Parser API not checking for null-terminator

2022-02-09 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: The contract of that interface is to receive null-terminated strings, so I am a bit clueless on how this could receive a non-null terminated string. Notice that calling CompileCode with a non-null terminated string is out of contract

[issue46704] Parser API not checking for null-terminator

2022-02-09 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- Removed message: https://bugs.python.org/msg412970 ___ Python tracker <https://bugs.python.org/issue46704> ___ ___ Python-bug

[issue46704] Parser API not checking for null-terminator

2022-02-09 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: The contract of that interface is to receive null-terminated strings, so I am a bit clueless on how this could receive a non-null terminated string. Notice that calling PyRun_StringFlags with a non-null terminated string is out of contract

[issue46707] Parser hanging on stacked { tokens

2022-02-09 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +29411 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31241 ___ Python tracker <https://bugs.python.org/issu

[issue46707] Parser hanging on stacked { tokens

2022-02-09 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset b71dc71905ab674ccaa4a56230d17a28f61c325c by Pablo Galindo Salgado in branch 'main': bpo-46707: Avoid potential exponential backtracking in some syntax errors (GH-31241) https://github.com/python/cpyt

[issue46707] Parser hanging on stacked { tokens

2022-02-09 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +29412 pull_request: https://github.com/python/cpython/pull/31242 ___ Python tracker <https://bugs.python.org/issue46

[issue46707] Parser hanging on stacked { tokens

2022-02-09 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue46707] Parser hanging on stacked { tokens

2022-02-09 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 9b23f8f78fdb0d7eba016616ae7a97abbfc65aa6 by Pablo Galindo Salgado in branch '3.10': [3.10] bpo-46707: Avoid potential exponential backtracking in some syntax errors (GH-31241). (GH-31242) https://github.com/python/cpyt

[issue46707] Parser hanging on stacked { tokens

2022-02-09 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Thanks Anthony for the report! -- ___ Python tracker <https://bugs.python.org/issue46707> ___ ___ Python-bugs-list m

<    1   2   3   4   5   6   7   8   9   10   >