Pablo Galindo Salgado added the comment:
This patch makes it slow for small iterators:
Perf program:
import perf
runner = perf.Runner()
runner.timeit("list_comp",
stmt="[x for x in range(10)]",
setup="")
Current mast
Pablo Galindo Salgado added the comment:
More benchmarks for slow iterators:
import perf
runner = perf.Runner()
runner.timeit("list_comp",
stmt="[x**2 for x in k]",
setup="k=iter(list(range(10)))")
Current mast
Pablo Galindo Salgado added the comment:
> That is a one-off cost for the __length_hint__ of the range object
> specifically.
Objects with a known length (lists, sets, tuples) would not have that overhead.
That seems incorrect. This is not unique of range objects as it affects also
o
Change by Pablo Galindo Salgado :
--
Removed message: https://bugs.python.org/msg339634
___
Python tracker
<https://bugs.python.org/issue36551>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
> That is a one-off cost for the __length_hint__ of the range object
> specifically.
Objects with a known length (lists, sets, tuples) would not have that overhead.
That seems incorrect. This is not unique of range objects as it affects also
o
Pablo Galindo Salgado added the comment:
12718-5f06333a4e49.json.gz
==
Performance version: 0.7.0
Report on macOS-10.14.4-x86_64-i386-64bit
Number of logical CPUs: 8
Start date: 2019-04-08 19:40:57.104845
End date: 2019-04-08 20:02:37.392894
Change by Pablo Galindo Salgado :
--
Removed message: https://bugs.python.org/msg339665
___
Python tracker
<https://bugs.python.org/issue36551>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
Here are the updated results for the benchmark suite. The previous results
(unlinked from the issue to reduce noise)
were against an old version of the master branch.
2019-04-08_13-08-master-58721a903074.json.gz
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +12691
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
New submission from Pablo Galindo Salgado :
After the removal of pgen, there are multiple parser headers that are not used
anymore or ar lacking implementations.
--
components: Interpreter Core
messages: 340140
nosy: pablogsal
priority: normal
severity: normal
status: open
title
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +12742
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
I will separate the work in two Pull Request (maybe more). The implementation
of the PEP will be done in PR12701 and the documentation and other additions
will be done in future Pull Requests to keep things more manageable
Pablo Galindo Salgado added the comment:
New changeset f2cf1e3e2892a6326949c2570f1bb6d6c95715fb by Pablo Galindo in
branch 'master':
bpo-36623: Clean parser headers and include files (GH-12253)
https://github.com/python/cpython/commit/f2cf1e3e2892a6326949c2570f1bb6
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset fde9b33dfeedd4a4ed723b12d2330979dc684760 by Pablo Galindo in
branch 'master':
bpo-36427: Document that PyEval_RestoreThread and PyGILState_Ensure can
terminate the calling thread (GH-12541)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
pull_requests: +12745
___
Python tracker
<https://bugs.python.org/issue36427>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
New changeset 830b43d03cc47a27a22a50d777f23c8e60820867 by Pablo Galindo
(Xtreak) in branch 'master':
bpo-36593: Fix isinstance check for Mock objects with spec executed under
tracing (GH-12790)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
Thanks @xtreak for the analysis and the quick fix!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 7723d0545c3369e1b2601b207c250c70ce90b75e by Pablo Galindo in
branch '3.7':
[3.7] bpo-36427: Document that PyEval_RestoreThread and PyGILState_Ensure can
terminate the calling thread (GH-12541) (GH-12820)
https://github.
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
For the changes of PEP570, please wait until I merge the implementation to do
the grammar changes in lib2to3 for that.
--
___
Python tracker
<https://bugs.python.org/issue36
Pablo Galindo Salgado added the comment:
Łukasz, are you ok if we include this one in alpha4 as we were discussing in
the PRs? If you are happy with that I will merge it so there is early testing
and then we can keep working on the documentation and minor details for the
next stage. If not
Change by Pablo Galindo Salgado :
--
nosy: +lukasz.langa
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issue36540>
___
___
Py
New submission from Pablo Galindo Salgado :
This issue is to discuss how to handle the changes in the inspect module for
PEP 570. In particular, how to handle:
* getfullargspec
* formatargspec
for positional-only parameters.
--
components: Interpreter Core
messages: 341070
nosy
Pablo Galindo Salgado added the comment:
Opened https://bugs.python.org/issue36751 to track changes in the inspect
module.
--
___
Python tracker
<https://bugs.python.org/issue36
Pablo Galindo Salgado added the comment:
New changeset 8c77b8cb9188165a123f2512026e3629bf03dc9b by Pablo Galindo in
branch 'master':
bpo-36540: PEP 570 -- Implementation (GH-12701)
https://github.com/python/cpython/commit/8c77b8cb9188165a123f2512026e36
Change by Pablo Galindo Salgado :
--
priority: release blocker -> high
___
Python tracker
<https://bugs.python.org/issue36540>
___
___
Python-bugs-list mai
Pablo Galindo Salgado added the comment:
The implementation has been merged, so I will remove the "release blocker". We
are still missing the documentation and the final changes to the inspect module.
--
___
Python track
Pablo Galindo Salgado added the comment:
May be related to this failure:
https://buildbot.python.org/all/#/builders/58/builds/2292
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue36
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +12939
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
PR 13016 adds the positional-only arguments together with the regular arguments
as suggested by Steve and Łukasz and deprecates getfullargspec() in favour of
inspect.signature.
--
___
Python tracker
<ht
Pablo Galindo Salgado added the comment:
New changeset d5d2b4546939b98244708e5bb0cfccd55b99d244 by Pablo Galindo in
branch 'master':
bpo-36751: Deprecate getfullargspec and report positional-only args as regular
args (GH-13016)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
PR 13016 is fixed, and I will remove the release blocker, but I will leave it
open for now until we can check if there is consensus on the status and future
of the inspect module after PEP 570 :)
--
priority: release blocker -> nor
Pablo Galindo Salgado added the comment:
PR 13016 is merged, and I will remove the release blocker, but I will leave it
open for now until we can check if there is consensus on the status and future
of the inspect module after PEP 570
Change by Pablo Galindo Salgado :
--
Removed message: https://bugs.python.org/msg341129
___
Python tracker
<https://bugs.python.org/issue36751>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
I am +1 to this. Making it easier for the case of decorator factories that are
called with all the defaults is a very common pattern in the wild. There are
even known idioms for how to reduce the indentation of the naive approach
(returning partials
New submission from Pablo Galindo Salgado :
When evaluating a frame object, it is possible to exit the execution with some
variables in the stack. The frame deallocator (frame_dealloc) only cleans the
stack if f_stacktop is not NULL, but this only happens for generators and when
trace
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +13103
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
pull_requests: +13113
___
Python tracker
<https://bugs.python.org/issue36540>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
Are uintptr_t overflow/underflow semantics a defined behavior?
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue36
Pablo Galindo Salgado added the comment:
New changeset f00828a742d2e88c910bdfd00f08fcd998554ba5 by Pablo Galindo in
branch 'master':
bpo-36851: Clean the frame stack if the execution ends with a return and the
stack is not empty (GH-13191)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
pull_requests: +13147
___
Python tracker
<https://bugs.python.org/issue34408>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
I have backported the fix to 3.7 :)
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 34ed40f2e56703de04241cbacb306113b59a84f9 by Pablo Galindo in
branch '3.7':
[3.7] bpo-34408: Prevent a null pointer dereference and resource leakage in
`PyInterpreterState_New()` (GH-8767) (GH-13237)
https://github.com/pyth
Pablo Galindo Salgado added the comment:
round() delegates to class.__round__, so what's happening here is that numpy's
float implements __round__ in a way it returns a float.
There is no restriction on what the class can return:
>>> class A:
... def __round__(self):
Change by Pablo Galindo Salgado :
--
assignee: -> docs@python
components: +Documentation
nosy: +docs@python
resolution: -> not a bug
versions: +Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.org/i
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue36876>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Pablo Galindo Salgado :
--
pull_requests: +13157
___
Python tracker
<https://bugs.python.org/issue36751>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
Opened PR 13245 to un-deprecate getfullargspec.
--
___
Python tracker
<https://bugs.python.org/issue36751>
___
___
Pytho
Pablo Galindo Salgado added the comment:
Commit 9a4135e939bc223f592045a38e0f927ba170da32 introduced a reference leak:
https://buildbot.python.org/all/#/builders/80/builds/587/steps/3/logs/stdio
Bisect results for test_future:
0:00:00 load avg: 10.04 [1/1] test_future
beginning 9
Change by Pablo Galindo Salgado :
--
pull_requests: +13160
stage: resolved -> patch review
___
Python tracker
<https://bugs.python.org/issue36817>
___
___
Py
Pablo Galindo Salgado added the comment:
Opened PR13249 to fix the leak
--
stage: patch review -> resolved
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset 90fb04c1e23c0fddd438bd0f73e7c018cacef4bc by Pablo Galindo (Sanyam
Khurana) in branch 'master':
bpo-36822: Fix minor grammatical error in glossary.rst (GH-13145)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue36817>
___
___
Pyth
Pablo Galindo Salgado added the comment:
New changeset 5833e94d8615ea18b14e4830ecdb868aec81b378 by Pablo Galindo in
branch 'master':
bpo-36817: Fix reference leak for expr_text in f-string = parsing (GH-13249)
https://github.com/python/cpython/commit/5833e94d8615ea18b14e4830ecdb86
Pablo Galindo Salgado added the comment:
> If it is supposed to be stable can the `posonlyargcount` be moved to be the
> last argument ?
There are other projects that have already added a fix for the new parameter
positionally. If we add it to be the last (that still will break t
Change by Pablo Galindo Salgado :
--
status: closed -> open
___
Python tracker
<https://bugs.python.org/issue36886>
___
___
Python-bugs-list mailing list
Un
Pablo Galindo Salgado added the comment:
> and/or to CodeType docs to indicate the signature has changed in 3.8 ?
The documentation never documented the arguments for the code type (probably on
purpose), so not sure if adding a notice there will help much:
https://docs.python.org/
Pablo Galindo Salgado added the comment:
As a final note, notice that when keyword-only arguments were implemented, the
parameter was not added at the end of the constructor:
commit 4f72a78684bbfcdc43ceeabb240ceee54706c4b0
Author: Guido van Rossum
Date: Fri Oct 27 23:31:49 2006 +
Change by Pablo Galindo Salgado :
--
title: problem with Types on Python-3.8.0a4 -> Failed to construct CodeType on
Python-3.8.0a4
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +13167
stage: resolved -> patch review
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
>Understandable as well, just thinking that a CYA sentence in types.rst:
>"These types are not supposed to be instantiated outside of CPython internals
>and constructor signatures can vary between python versions.
>And maybe the doc
Pablo Galindo Salgado added the comment:
After PR 13255 is merged, let's open a new issue for the notice in types.rst to
keep the discussion isolated.
--
___
Python tracker
<https://bugs.python.org/is
Change by Pablo Galindo Salgado :
--
pull_requests: +13168
___
Python tracker
<https://bugs.python.org/issue36817>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
New changeset 26f55c29f2316648939ad12a9d3730a2118da2ea by Pablo Galindo in
branch 'master':
bpo-36817: Do not decrement reference for expr_text on fstring = parsing
failure (GH-13256)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
I concur with Raymond and Serhiy: this patch covers very exotic cases and
complicates the surrounding code. I'm closing this issue.
Thanks, @sir-sigurd for the proposal
--
resolution: -> rejected
stage: patch review -> resolved
s
Pablo Galindo Salgado added the comment:
New changeset 4f5febdf955240b6064bb5647dec084feaa98376 by Pablo Galindo (Sanyam
Khurana) in branch '3.7':
[3.7] bpo-36822: Fix minor grammatical error in glossary.rst (GH-13145).
(GH-13260)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 5d23e282af69d404a3430bb95aefe371112817b3 by Pablo Galindo in
branch 'master':
bpo-36886: Document changes in code object in What's new section (GH-13255)
https://github.com/python/cpython/commit/5d23e282af69d404a3430bb95
Change by Pablo Galindo Salgado :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue36886>
___
___
Pablo Galindo Salgado added the comment:
Indeed, this is failing as well in all buildbots but has not been reported
because fails in the setUp and therefore is counted as "RUN NO TESTS". Example:
https://buildbot.python.org/all/#/builders/58/builds/2368/steps/3/logs/stdio
-
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue36906>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
The issue is not fixed. The problem is that this still allows invalid syntax
because the code is optimized away:
def f():
if 0:
break
print("Hello")
f()
--
nosy: +pablogsal
Change by Pablo Galindo Salgado :
--
pull_requests: +13244
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue1875>
___
___
Py
Pablo Galindo Salgado added the comment:
>The drawback of compiling the dead code is adding cells for unneeded constants
>and local variables. Also it can create less optimal code for jumps.
Is unlikely that this situation arises often enough that this is a concern. We
would be sacri
Pablo Galindo Salgado added the comment:
For now, I am going to proceed to merge PR13245 and un-deprecate
getfullargspec().
Being said that I would want to remark that if test suites are broken when
deprecation warnings are emitted that is (1) their own choice, (2) precisely to
detect when
Pablo Galindo Salgado added the comment:
New changeset aee19f54f6fe45f6b3c906987941e5a8af4468e9 by Pablo Galindo in
branch 'master':
bpo-36751: Undeprecate getfullargspec (GH-13245)
https://github.com/python/cpython/commit/aee19f54f6fe45f6b3c906987941e5
Change by Pablo Galindo Salgado :
--
priority: release blocker -> normal
___
Python tracker
<https://bugs.python.org/issue36751>
___
___
Python-bugs-list mai
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +5084
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32586>
___
_
Pablo Galindo Salgado added the comment:
Thanks for reporting this issue. Indeed, this is an error in the documentation.
Notice that this is corrected in Python3 's version:
https://docs.python.org/3.6/howto/urllib2.html#handling-exceptions
I have prepared a Pull Request fixing this. T
Pablo Galindo Salgado added the comment:
There are some issues in the documentation for this function (slightly related)
to this described here: https://bugs.python.org/issue17799.
I can update the PR linked to that issue with this information as well.
--
nosy: +pablogsal
versions
Pablo Galindo Salgado added the comment:
Closed as is a duplicate of 31304. Thanks for reporting this!
--
nosy: +pablogsal
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> Update doc for starmap_async erro
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +5085
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
type: performance -> enhancement
___
Python tracker
<https://bugs.python.org/issue32599>
___
___
Python-bugs-list mai
Pablo Galindo Salgado added the comment:
+1 to this. I have seen a lot of regular expressions not using raw strings that
makes use of "\d" and friends. I will work on a patch to the docs if that's ok.
--
nosy: +pablogsal
___
Python
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +5102
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32603>
___
_
Change by Pablo Galindo Salgado :
--
pull_requests: +5103
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32232>
___
___
Python-
Pablo Galindo Salgado added the comment:
I have put together a PR with Matthias' patch and a test.
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/is
Pablo Galindo Salgado added the comment:
It seems that Microsoft compiler does not handle well the circular dependencies
between Include/pystate.h and Include/internal/pystate.h so I have included
guards for Windows in the new include for Include/pystate.h and deactivated the
test in that
Change by Pablo Galindo Salgado :
--
components: +Interpreter Core
type: -> performance
___
Python tracker
<https://bugs.python.org/issue32616>
___
___
Python-
Change by Pablo Galindo Salgado :
--
components: +Windows
nosy: +paul.moore, steve.dower, tim.golden, zach.ware
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
This behaviour is because "parent" descriptor ends calling:
@classmethod
def _from_parsed_parts(cls, drv, root, parts, init=True):
self = object.__new__(cls)
self._drv = drv
self._root = root
self._par
Pablo Galindo Salgado added the comment:
Sorry, the exception of object.__new__(cls) is AttributeError: _drv
--
___
Python tracker
<https://bugs.python.org/issue32
Pablo Galindo Salgado added the comment:
Antoine, is the reason of calling object.__new__(cls) in `_from_parsed_parts`
that the code does not raise on creation?
--
___
Python tracker
<https://bugs.python.org/issue32
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +5234
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32650>
___
_
Change by Pablo Galindo Salgado :
--
pull_requests: +5237
___
Python tracker
<https://bugs.python.org/issue32650>
___
___
Python-bugs-list mailing list
Unsub
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +5253
___
Python tracker
<https://bugs.python.org/issue20104>
___
___
Python-bugs-list mailin
Pablo Galindo Salgado added the comment:
I have opened a PR to address this issues:
https://github.com/python/cpython/pull/5415
--
___
Python tracker
<https://bugs.python.org/issue20
4001 - 4100 of 4563 matches
Mail list logo