[issue17005] Add a topological sort algorithm

2019-01-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: The one in PR 11583 is twice as faster: >timeit for -> >topsort([(2,11),(9,11),(9,8),(9,10),(10,11),(10,3),(11,7),(11,5),(8,7),(8,3)]) 12.4 µs ± 59.1 ns per loop (mean ± std. dev. of 7 runs, 10 loops each) >timeit for -> >t

[issue17005] Add a topological sort algorithm

2019-01-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: The one in PR 11583 is twice as fast: >timeit for -> >topsort([(2,11),(9,11),(9,8),(9,10),(10,11),(10,3),(11,7),(11,5),(8,7),(8,3)]) 12.4 µs ± 59.1 ns per loop (mean ± std. dev. of 7 runs, 10 loops each) >timeit for -> >tsort([

[issue23428] Use the monotonic clock for thread conditions on POSIX platforms

2019-01-17 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > One workaround is to use Python to use the mutex+cond implementation of > pthread locks, since this one is already able to use CLOCK_MONOTONIC: That this have any drawbacks? -- nosy: +pab

[issue23428] Use the monotonic clock for thread conditions on POSIX platforms

2019-01-17 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > One workaround is to use Python to use the mutex+cond implementation of > pthread locks, since this one is already able to use CLOCK_MONOTONIC: Does this have any drawbacks? -- ___ Python tracker

[issue17005] Add a topological sort algorithm

2019-01-18 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > 1. The name "topsort" is most naturally parsed as "top sort" which could be > misinterpreted (as a sort that puts items on top in some way). If the name > must be abbreviated then "toposort" would be better.

[issue32603] Deprecation warning on strings used in re module

2019-01-20 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue17005] Add a topological sort algorithm

2019-01-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I have updated the PR to receive a dictionary of sets as in Eric V. Smith's package. I have maintained the guts of the current algorithm as it scales much better: >>> test_data = {x:{x+n for n in range(100)} for x in range(1000)} &g

[issue17005] Add a topological sort algorithm

2019-01-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I have updated the PR to receive a dictionary of sets as in Eric V. Smith's package. I have maintained the guts of the current algorithm as it scales much better: >>> test_data = {x:{x+n for n in range(100)} for x in range(1000)} &g

[issue17005] Add a topological sort algorithm

2019-01-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Although I think the API with the dictionary may be cleaner, I still do not like it completely. 1) One of the reasons is that implementing C3 directly with the topological sort is not straightforward as the different nodes that are at the same level

[issue28607] C implementation of parts of copy.deepcopy

2019-01-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Hy Rasmus, would you like to make a PR with your patch and adding some tests? Thanks! -- nosy: +pablogsal ___ Python tracker <https://bugs.python.org/issue28

[issue35786] get_lock() method is not present for Values created using multiprocessing.Manager()

2019-01-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: You are not using multiprocessing.Value: >>> import multiprocessing >>> x = multiprocessing.Value("i", 0) >>> x.get_lock() -- nosy: +pablogsal ___ Python tracker

[issue17005] Add a topological sort algorithm

2019-01-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: (A, B, C, D, E, F) would not be correct as B is order 2 and "C" and "A" is order 1. The correct orders are the inner-group permutations of: [{'A', 'F'}, {'B', 'D', 'E&#x

[issue35378] multiprocessing.Pool.imaps iterators do not maintain alive the multiprocessing.Pool objects

2019-01-20 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +11392, 11393 ___ Python tracker <https://bugs.python.org/issue35378> ___ ___ Python-bugs-list mailin

[issue35378] multiprocessing.Pool.imaps iterators do not maintain alive the multiprocessing.Pool objects

2019-01-20 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +11392 ___ Python tracker <https://bugs.python.org/issue35378> ___ ___ Python-bugs-list mailing list Unsub

[issue35378] multiprocessing.Pool.imaps iterators do not maintain alive the multiprocessing.Pool objects

2019-01-20 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +11392, 11393, 11394 ___ Python tracker <https://bugs.python.org/issue35378> ___ ___ Python-bugs-list mailin

[issue35795] test_pkgutil test_zipapp fail in AMD64 Windows7 SP1 3.x and AMD64 Windows7 SP1 3.7 buildbots

2019-01-21 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : test_pkgutil test_zipapp fail in AMD64 Windows7 SP1 3.x and AMD64 Windows7 SP1 3.7 buildbots: https://buildbot.python.org/all/#/builders/40/builds/1525 https://buildbot.python.org/all/#/builders/130/builds/636

[issue35794] test_posix.py test failure

2019-01-21 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Hi, Thank you for opening the issue. Without providing more information we cannot help debugging the issue. Can you provide more information like what is your system, What OS, version of python, architecture...etc Is the only test that fails

[issue35794] test_posix.py test failure

2019-01-21 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- components: +Tests ___ Python tracker <https://bugs.python.org/issue35794> ___ ___ Python-bugs-list mailing list Unsub

[issue20239] Allow repeated deletion of unittest.mock.Mock attributes

2019-01-21 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue35794] test_posix.py test failure

2019-01-21 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I think that test should check for PermissionError as well. -- ___ Python tracker <https://bugs.python.org/issue35

[issue35794] test_posix.py test failure

2019-01-21 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +vstinner ___ Python tracker <https://bugs.python.org/issue35794> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35794] test_posix.py test failure

2019-01-21 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch, patch, patch pull_requests: +11404, 11405, 11406 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35794] test_posix.py test failure

2019-01-21 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +11404 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35794] test_posix.py test failure

2019-01-21 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch, patch pull_requests: +11404, 11405 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35794] test_posix.py test failure

2019-01-21 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset e9b185f2a493cc54f0d49eac44bf21e8d7de2990 by Pablo Galindo in branch 'master': bpo-35794: Catch PermissionError in test_no_such_executable (GH-11635) https://github.com/python/cpython/commit/e9b185f2a493cc54f0d49eac44bf21

[issue35794] test_posix.py test failure

2019-01-21 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

2019-01-21 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: @Steve, we are investigating and tracking this issue here: https://bugs.python.org/issue35795 According to the buildbot owner "directory tree removal needs to go through support.rmtree, not any of the stdlib methods for doing so. In a nutshell

[issue27035] Cannot set exit code in atexit callback

2019-01-22 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I think this is a documentation issue today. The docs say: >If an exception is raised during execution of the exit handlers, a traceback >is printed (unless SystemExit is raised) and the exception >information is saved. After all exit hand

[issue27035] Cannot set exit code in atexit callback

2019-01-22 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: The behaviour regarding printing SytemExit was changed by Serhiy in 3fd54d4a7e604067e2bc0f8cfd58bdbdc09fa7f4 and in bpo-28994. -- ___ Python tracker <https://bugs.python.org/issue27

[issue27035] Cannot set exit code in atexit callback

2019-01-22 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: @ Kumar Do you want to make a PR fixing the docs? -- ___ Python tracker <https://bugs.python.org/issue27035> ___ ___

[issue27035] Cannot set exit code in atexit callback

2019-01-24 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: You can always set the exit code calling sys.exit from outside the atexit handlers. I concur with R. David Murray in that calling sys.exit and expect anything sounds like a bad idea and an abuse if the atexit system. A normal application would call

[issue35876] test_start_new_session for posix_spawnp fails

2019-02-01 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : Example failure: https://buildbot.python.org/all/#/builders/141/builds/1142/steps/4/logs/stdio = ERROR: test_start_new_session (test.test_posix.TestPosixSpawn

[issue35881] test_type_comments leaks references and memory blocks

2019-02-01 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : The refleak buildbots have detected that test_type_comments is leaking references. Example failure: https://buildbot.python.org/all/#/builders/1/builds/490/steps/4/logs/stdio test_type_comments leaked [37, 37, 37] references, sum=111

[issue35881] test_type_comments leaks references and memory blocks

2019-02-01 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Yeah, as usual, Pablo is way too slow: he posted the same bug 1h30 after me. :( -- ___ Python tracker <https://bugs.python.org/issu

[issue35879] test_type_comments leaks references

2019-02-01 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: >From the duplicate (https://bugs.python.org/issue35881) : After some hours of debugging, I have identified the (possible) cause of the majority of the refleaks. The type_comments created in ast.c with new_type_comment() never reaches 0 refere

[issue35879] test_type_comments leaks references

2019-02-01 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: The extra referenced happen here in Python-ast.c : value = ast2obj_string(o->type_comment); if (!value) goto failed; if (_PyObject_SetAttrId(result, &PyId_type_comment, value) == -1) goto failed; Py_DECREF(value); ast2obj

[issue35879] test_type_comments leaks references

2019-02-01 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Hu I may be missing something but these is what I am seeing: BASELINE ❯ ./python.exe -m test test_type_comments -R 10:10 Run tests sequentially 0:00:00 load avg: 2.30 [1/1] test_type_comments beginning 20 repetitions

[issue35879] test_type_comments leaks references

2019-02-01 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Note: the extra DECREF will fail in other tests because it will deallocate None if ast2obj_object returns Py_None because the comment is NULL. -- ___ Python tracker <https://bugs.python.org/issue35

[issue35879] test_type_comments leaks references

2019-02-01 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I'm almost sure this is not the correct fix, but I think these findings point to that object as the one being leaked. I do not understand how this object should be deallocated and where, I am trying to follow how the other PyObject* (nam

[issue35912] _testembed.c fails to compile when using --with-cxx-main in the configure step

2019-02-06 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : Programs/_testembed.c is compiled with $(MAINCC) in Makefile.pre.in and that will use the C++ compiler if --with-cxx-main is used in the configuration step. The problem is that if the C++ compiler used is some of the more uncommon ones (like the

[issue35606] Add prod() function to the math module

2019-02-06 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: PR 11359 has the following properties in its current state: Performance vs naive implementation --- ./python -m perf timeit -s "import functools;import operator;iterable=list(range(1))" 'f

[issue35925] test_httplib test_nntplib test_ssl fail on ARMv7 Ubuntu 3.7 and ARMv7 Ubuntu 3.x buildbots

2019-02-06 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : Example failures https://buildbot.python.org/all/#/builders/117 https://buildbot.python.org/all/#/builders/106 == ERROR: test_networked_good_cert (test.test_httplib.HTTPSTest

[issue35940] multiprocessing manager tests fail in the Refleaks buildbots

2019-02-08 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : After PR11772, some buildbots with refleak checks fail because the tests modify the environment (leaking processes or threads or files ...). Some of the failures: https://buildbot.python.org/all/#builders/80/builds/506 ttps://buildbot.python.org

[issue35940] multiprocessing manager tests fail in the Refleaks buildbots

2019-02-09 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch, patch pull_requests: +11812, 11813 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35940] multiprocessing manager tests fail in the Refleaks buildbots

2019-02-09 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch, patch, patch pull_requests: +11812, 11813, 11814 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35940] multiprocessing manager tests fail in the Refleaks buildbots

2019-02-09 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +11812 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35808] Let's retire pgen

2019-02-09 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +pablogsal ___ Python tracker <https://bugs.python.org/issue35808> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35959] math.prod(range(10)) caues segfault

2019-02-10 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: The problem is that the intermediate result (i_result) can be 0 when doing the overflow check: x / i_result != b i am working on a fix. -- ___ Python tracker <https://bugs.python.org/issue35

[issue35959] math.prod(range(10)) caues segfault

2019-02-10 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +11822 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35959] math.prod(range(10)) caues segfault

2019-02-10 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch, patch pull_requests: +11822, 11823 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35959] math.prod(range(10)) caues segfault

2019-02-10 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch, patch, patch pull_requests: +11822, 11823, 11824 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35959] math.prod(range(10)) caues segfault

2019-02-10 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: PR11808 fixes the error and add some basic test. Please review the PR instead :) -- ___ Python tracker <https://bugs.python.org/issue35

[issue35940] multiprocessing manager tests fail in the Refleaks buildbots

2019-02-10 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue35959] math.prod(range(10)) caues segfault

2019-02-10 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue35959] math.prod(range(10)) caues segfault

2019-02-10 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +11825 ___ Python tracker <https://bugs.python.org/issue35959> ___ ___ Python-bugs-list mailing list Unsub

[issue35959] math.prod(range(10)) caues segfault

2019-02-10 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +11825, 11826 ___ Python tracker <https://bugs.python.org/issue35959> ___ ___ Python-bugs-list mailin

[issue35959] math.prod(range(10)) caues segfault

2019-02-10 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +11825, 11826, 11827 ___ Python tracker <https://bugs.python.org/issue35959> ___ ___ Python-bugs-list mailin

[issue35808] Let's retire pgen

2019-02-10 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch, patch pull_requests: +11828, 11829 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35808] Let's retire pgen

2019-02-10 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +11828 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35808] Let's retire pgen

2019-02-10 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch, patch, patch pull_requests: +11828, 11829, 11830 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35808] Let's retire pgen

2019-02-10 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: -11830 ___ Python tracker <https://bugs.python.org/issue35808> ___ ___ Python-bugs-list mailing list Unsub

[issue35808] Let's retire pgen

2019-02-10 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: -11829, 11830 ___ Python tracker <https://bugs.python.org/issue35808> ___ ___ Python-bugs-list mailin

[issue35961] gc_decref: Assertion "gc_get_refs(g) > 0" failed: refcount is too small

2019-02-10 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : I am seeing some failures in travis and some buildbots: 0:02:24 load avg: 3.30 [147/420/1] test_slice crashed (Exit code -6) -- running: test_multiprocessing_spawn (32 sec 523 ms), test_asyncio (45 sec 433 ms), test_multiprocessing_forkserver (47

[issue35959] math.prod(range(10)) caues segfault

2019-02-11 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: @Mark Dickinson Thanks for the links. I had opened yesterday PR11809 addressing the UB and adding more tests. Could you review the PR? -- ___ Python tracker <https://bugs.python.org/issue35

[issue35959] math.prod(range(10)) caues segfault

2019-02-11 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: @Mark long x = i_result * b; is still on the PR but the check for overflow does not use x. I will update the PR to move that line inside the overflow-safe block to prevent UB from happening and affecting the check itself (or the rest of the code

[issue35378] multiprocessing.Pool.imaps iterators do not maintain alive the multiprocessing.Pool objects

2019-02-11 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 3766f18c524c57784eea7c0001602017d2122156 by Pablo Galindo in branch 'master': bpo-35378: Fix multiprocessing.Pool references (GH-11627) https://github.com/python/cpython/commit/3766f18c524c57784eea7c00016020

[issue35378] multiprocessing.Pool.imaps iterators do not maintain alive the multiprocessing.Pool objects

2019-02-11 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue35978] test_venv fails in Travis with GCC

2019-02-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: That looks like a similar example of the problem that bpo35378 solves. But the PR is merged and the test keeps failing: test test_venv failed -- Traceback (most recent call last): File "/home/travis/build/python/cpython/Lib/test/test_venv.py&q

[issue35942] posixmodule.c:path_converter() returns an invalid exception message for broken PathLike objects

2019-02-12 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +11862 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35973] `growable_int_array type_ignores` in parsetok.c is not always freed.

2019-02-12 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +11863 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue26415] Excessive peak memory consumption by the Python parser

2019-02-12 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +pablogsal ___ Python tracker <https://bugs.python.org/issue26415> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35984] test__xxsubinterpreters leaked [3, 4, 3] memory blocks, sum=1

2019-02-13 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : The reafleak buildbots have detected memory block leaks in test__xxsubinterpreters: Ran 112 tests in 4.721s OK (skipped=5) . test__xxsubinterpreters leaked [3, 4, 3] memory blocks, sum=10 1 test failed again: test__xxsubinterpreters == Tests

[issue36013] test_signal fails in AMD64 Debian PGO 3.x

2019-02-16 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : test_signal fails in AMD64 Debian PGO 3.x: == Tests result: FAILURE then FAILURE == 406 tests OK. 10 slowest tests: - test_concurrent_futures: 2 min 37 sec - test_multiprocessing_spawn: 2 min 3 sec - test_multiprocessing_forkserver: 1 min 28 sec

[issue36012] Investigate slow writes to class variables

2019-02-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: It seems 50% of the overhead (50ns) is due to two reasons: - 30-40% is due to the call to update_slot(type, name) after the item is set in the class dictionary. - 70-60% is due to all the extra work from _PyObject_GenericSetAttrWithDict until it

[issue36013] test_signal fails in AMD64 Debian PGO 3.x

2019-02-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I scheduled a rebuild to check if the failure is consistent. -- ___ Python tracker <https://bugs.python.org/issue36

[issue36013] test_signal fails in AMD64 Debian PGO 3.x

2019-02-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I have tested in Ubuntu with the same version of bash 4.4.12(1)-release and the test succeeds: root@d7d8cf5d89bf:/src# echo $BASH_VERSION 4.4.12(1)-release root@d7d8cf5d89bf:/src# ./python -m test test_signal -m

[issue36013] test_signal fails in AMD64 Debian PGO 3.x

2019-02-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Could it be a race condition the signal delivery? Technically, the process sends itself a signal and never waits for it, it just exits. The signal can arrive after the process has exited normally. Or I am missing something obvious in this reasoning

[issue36016] Allow gc.getobjects to return the objects tracked by a specific generation

2019-02-17 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +11935 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue36016] Allow gc.getobjects to return the objects tracked by a specific generation

2019-02-17 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : gc.get_objects() return all the objects tracked by the garbage collector. This is useful, but right now there is no way of knowing in which generation each object is currently on. This information can be beneficial to understand better the state of

[issue36016] Allow gc.getobjects to return the objects tracked by a specific generation

2019-02-17 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +nascheme ___ Python tracker <https://bugs.python.org/issue36016> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36016] Allow gc.getobjects to return the objects tracked by a specific generation

2019-02-17 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +pitrou ___ Python tracker <https://bugs.python.org/issue36016> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36019] test_urllib fail in s390x buildbots

2019-02-17 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : test_urllib fail in s390x buildbots. It does not seem like a temporary failure as they keep failing consistently. Some failed builds: https://buildbot.python.org/all/#builders/126/builds/1010 https://buildbot.python.org/all/#builders/122/builds/1026

[issue36012] Investigate slow writes to class variables

2019-02-17 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: This are the timings that I am measuring with PR 11907: Variable and attribute read access: 5.7 ns read_local 5.9 ns read_nonlocal 16.2 ns read_global 24.5 ns read_builtin 20.9 ns read_classvar_from_class

[issue35942] posixmodule.c:path_converter() returns an invalid exception message for broken PathLike objects

2019-02-18 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 09fbcd6085e18b534fd4161844ff39f77eb4a082 by Pablo Galindo in branch 'master': bpo-35942: Improve the error message if __fspath__ returns invalid types in path_converter (GH-11831) https://github.com/python/cpyt

[issue35942] posixmodule.c:path_converter() returns an invalid exception message for broken PathLike objects

2019-02-18 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36044] PROFILE_TASK for PGO build is not a good workload

2019-02-19 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Also, the test suite exercises a lot of branches (like passing incorrect types to function to check errors) that will hurt the branch prediction that PGO generates. -- nosy: +pablogsal ___ Python tracker

[issue36040] Python\ast.c(3875): warning C4244: 'initializing': conversion from 'Py_ssize_t' to 'int'

2019-02-19 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +11973 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue36040] Python\ast.c(3875): warning C4244: 'initializing': conversion from 'Py_ssize_t' to 'int'

2019-02-19 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Fixed with commit https://github.com/python/cpython/commit/46a97920feaf4094436b2cdb32d2bd2fab3b59a5 -- nosy: +pablogsal resolution: -> fixed stage: patch review -> resolved status: open -&g

[issue36052] Assignment operator allows to assign to __debug__

2019-02-20 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +11984 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue36052] Assignment operator allows to assign to __debug__

2019-02-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: When I started working on this I did not notice the extra comments here. I will close my PR so Stéphane can do the PR. -- nosy: +pablogsal ___ Python tracker <https://bugs.python.org/issue36

[issue36052] Assignment operator allows to assign to __debug__

2019-02-21 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 3ad91673057d410bf9f8c53df6bb8aa18c4b68ca by Pablo Galindo (Stéphane Wirtel) in branch 'master': bpo-36052: Raise a SyntaxError when assigning a value to __debug__ with := (GH-11958) https://github.com/python/cpyt

[issue36052] Assignment operator allows to assign to __debug__

2019-02-21 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36019] test_urllib fail in s390x buildbots: http://www.example.com/

2019-02-21 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Related failure: https://buildbot.python.org/all/#/builders/141/builds/1233 -- Ran 56 tests in 25.105s OK (skipped=1) Re-running test 'test_normalization' in ve

[issue35867] NameError is not caught at Task execution

2019-02-21 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I do not think this is a bug. Any exception that is raised inside a task will be in the .exception() method when the task is finished. Here you are running the task without waiting for finalization. For example, if you change: async def cofunc1

[issue36109] test_descr fails on AMD64 Windows8 3.x buildbots

2019-02-25 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : https://buildbot.python.org/all/#/builders/32/builds/2198 == ERROR: test_vicious_descriptor_nonsense (test.test_descr.ClassPropertiesAndMethods

[issue36109] test_descr fails on AMD64 Windows8 3.x buildbots

2019-02-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I can reproduce this locally. How has this not being spotted by the CI: ❯ ./python.exe -m test test_descr Run tests sequentially 0:00:00 load avg: 3.82 [1/1] test_descr test test_descr failed -- Traceback (most recent call last): File "/

[issue36109] test_descr fails on AMD64 Windows8 3.x buildbots

2019-02-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: It seems that this is a race condition created as a consequence of: https://github.com/python/cpython/pull/2/files -- nosy: +serhiy.storchaka ___ Python tracker <https://bugs.python.org/issue36

[issue36110] test_descr: test_vicious_descriptor_nonsense() fails randomly

2019-02-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Duplicate of https://bugs.python.org/issue36109 -- nosy: +pablogsal ___ Python tracker <https://bugs.python.org/issue36

[issue36110] test_descr: test_vicious_descriptor_nonsense() fails randomly

2019-02-25 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> duplicate stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36110] test_descr: test_vicious_descriptor_nonsense() fails randomly

2019-02-25 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I was faster this time ;) -- ___ Python tracker <https://bugs.python.org/issue36110> ___ ___ Python-bugs-list mailin

<    34   35   36   37   38   39   40   41   42   43   >