Pablo Galindo Salgado added the comment:
I just merged PR 14433
--
___
Python tracker
<https://bugs.python.org/issue37603>
___
___
Python-bugs-list mailin
Pablo Galindo Salgado added the comment:
I will close this for now, we can revisit this if we find a better solution for
the issue.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracke
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +14780
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15017
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
> Any update on deprecating the parser module?
Wish granted: PR 15017
--
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
In the What's New section of 3.8
(https://docs.python.org/3.8/whatsnew/3.8.html#changes-in-the-c-api) it
indicates that:
> On Unix, C extensions are no longer linked to libpython except on Android and
> Cygwin. When Python is embedded
New submission from Pablo Galindo Salgado :
The test suite is failing when running with python -Werror due to some
uncatched DeprecationWarnings.
--
components: Tests
messages: 349261
nosy: pablogsal
priority: normal
severity: normal
status: open
title: Fix deprecation warnings
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +14916
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15184
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset aa542c2cf26c5af9298dda6064576b18906cdfbf by Pablo Galindo in
branch 'master':
bpo-37795: Capture DeprecationWarnings in the test suite (GH-15184)
https://github.com/python/cpython/commit/aa542c2cf26c5af9298dda6064576b
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
pull_requests: +14920
pull_request: https://github.com/python/cpython/pull/15188
___
Python tracker
<https://bugs.python.org/issue37
Pablo Galindo Salgado added the comment:
New changeset 162d45c531552d0699f945d2c22a763941dca3c1 by Pablo Galindo in
branch '3.8':
[3.8] bpo-37795: Capture DeprecationWarnings in the test suite (GH-15184)
(GH-15188)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue37830>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Pablo Galindo Salgado :
--
nosy: +benjamin.peterson, pitrou
___
Python tracker
<https://bugs.python.org/issue31171>
___
___
Python-bugs-list mailin
Pablo Galindo Salgado added the comment:
Some buildbots failing with this problem:
https://buildbot.python.org/all/#/builders/145/builds/849
--
___
Python tracker
<https://bugs.python.org/issue35
Pablo Galindo Salgado added the comment:
I will investigate with MacOS Mojave this week.
--
___
Python tracker
<https://bugs.python.org/issue35316>
___
___
Pytho
Change by Pablo Galindo Salgado :
--
assignee: -> pablogsal
___
Python tracker
<https://bugs.python.org/issue35316>
___
___
Python-bugs-list mailing list
Un
Pablo Galindo Salgado added the comment:
> Can someone please explain me why this change has any impact? Does it mean
> that _PyObject_GC_UNTRACK() macro has a bug?
Interestingly, this lonely and perplexing comment is left in
PyObject_GC_UnTrack (the function):
void
PyObject_GC_U
Pablo Galindo Salgado added the comment:
I did not backport this still because the code is very different and it
required more time to understand how it works on 2.7.
I do not have access currently to koobs buildbot (the IP has changed) so I
cannot check if that works
Pablo Galindo Salgado added the comment:
multiprocessing.Pool.imap hangs in MacOs after applying this commit:
import multiprocessing
def the_test():
print("Begin")
for x in multiprocessing.Pool().imap(int,
["4", "3"]):
print(x)
Pablo Galindo Salgado added the comment:
Bisecting between 3.7.0(good) and 3.7.1(bad) with the code in my previous
commit points to:
97f998a4dfd6db6d867f446daa62445d0782bf39 is the first bad commit
commit 97f998a4dfd6db6d867f446daa62445d0782bf39
Author: Miss Islington (bot) <31488909+m
Pablo Galindo Salgado added the comment:
This also happens on Linux, hanging in different moments:
❯ ./python test.py
Begin
4
[hangs]
❯ ./python test.py
Begin
4
3
[hangs]
❯ ./python test.py
[hangs]
--
___
Python tracker
<https://bugs.python.
New submission from Pablo Galindo Salgado :
After applying the PRs in issue34172, multiprocessing.Pool.imap hangs on MacOs
and Linux. This is a simple reproducer:
import multiprocessing
def the_test():
print("Begin")
for x in multiprocessing.Pool().imap(int,
Pablo Galindo Salgado added the comment:
As this issue was somehow still present previous to this commit, I am going to
track this problem in a new issue:
issue35378
--
status: open -> closed
___
Python tracker
<https://bugs.pyth
Pablo Galindo Salgado added the comment:
I was working already on a PR. Do you prefer to wait for yours instead?
--
___
Python tracker
<https://bugs.python.org/issue35
Pablo Galindo Salgado added the comment:
I think the code is almost ok (I also prefer to also use the cache as an excuse
to maintain the pool alive) but the test needs to be done a bit more carefully
to avoid hanging the test suite in case of failure and to avoid leaking threads
or
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +10087
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Víctor, I have a PR fixing this in:
issue35378
Even if is not correct to not call close or join on the Pool, this behaviour
was working before while now it hangs. The fix is really simple, si I think we
should fix it and not revert the change on this
Pablo Galindo Salgado added the comment:
> I'm not comfortable with the fix. I cannot explain why but I feel like adding
> a strong dependency from a child to its parent is going to lead to more bugs,
> not less. It sounds like a recipe for reference cycles. Maybe I'm
Change by Pablo Galindo Salgado :
--
Removed message: https://bugs.python.org/msg330994
___
Python tracker
<https://bugs.python.org/issue34172>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
> I'm not comfortable with the fix. I cannot explain why but I feel like adding
> a strong dependency from a child to its parent is going to lead to more bugs,
> not less. It sounds like a recipe for reference cycles. Maybe I'm
Pablo Galindo Salgado added the comment:
> I'm not comfortable with the fix. I cannot explain why but I feel like adding
> a strong dependency from a child to its parent is going to lead to more bugs,
> not less. It sounds like a recipe for reference cycles. Maybe I'm
Change by Pablo Galindo Salgado :
--
Removed message: https://bugs.python.org/msg330995
___
Python tracker
<https://bugs.python.org/issue34172>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
> I disagree that a child should keep its parent alive.
But this is normal across the standard library. For example, here is how a
deque iterator keeps the deque alive:
>>> x = deque([1,2,3])
>>> deque_iter = iter(x)
>>>
Pablo Galindo Salgado added the comment:
> that there is code in the stdlib that holdes reference between child and
> parent
Just to clarify: is not that is just code in the stdlib that keeps a reference
between child and parent. The examples I have given are the exact same
situatio
Pablo Galindo Salgado added the comment:
Although I think keeping the iterator is not a bad solution if done correctly,
I think more and more that is not the best solution.
@Antoine, would you be ok passing a weak reference to the iterator and raising
if the pool is dead?
I still think we
Pablo Galindo Salgado added the comment:
Ok, I will modify my PR to pass a weak reference and raise.
--
___
Python tracker
<https://bugs.python.org/issue35
New submission from Pablo Galindo Salgado :
Almost all Windows buildbots are failing to compile Python:
https://buildbot.python.org/all/#/builders/130/builds/525
https://buildbot.python.org/all/#/builders/113/builds/825
https://buildbot.python.org/all/#/builders/121/builds/782
https
Change by Pablo Galindo Salgado :
--
nosy: +ned.deily
versions: +Python 3.6, Python 3.7
___
Python tracker
<https://bugs.python.org/issue35437>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
https://github.com/python/cpython/commit/468a15aaf9206448a744fc5eab3fc21f51966aad
--
versions: -Python 3.6
___
Python tracker
<https://bugs.python.org/issue35
Pablo Galindo Salgado added the comment:
Reverting that commit seem to work:
https://buildbot.python.org/all/#/builders/91/builds/9
--
___
Python tracker
<https://bugs.python.org/issue35
Pablo Galindo Salgado added the comment:
More broken buildbots:
https://buildbot.python.org/all/#/builders/32/builds/1867
--
___
Python tracker
<https://bugs.python.org/issue35
Pablo Galindo Salgado added the comment:
@Steve Notice that 468a15aaf9206448a744fc5eab3fc21f51966aad is currently
reverted, so you need to push it again if you plan to add something on top of
it.
--
___
Python tracker
<https://bugs.python.
Pablo Galindo Salgado added the comment:
I am playing with passing weakreferences into the iterator objects, but this
may not be enough. For example, take the code of ApplyResult.get:
def get(self, timeout=None):
if self._pool() is None:
raise RuntimeError("The pool is
Change by Pablo Galindo Salgado :
--
Removed message: https://bugs.python.org/msg331441
___
Python tracker
<https://bugs.python.org/issue35378>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
I am playing with weakreferences inside the iterator objects, but this may not
be enough. For example, take the code of ApplyResult.get:
def get(self, timeout=None):
if self._pool() is None:
raise RuntimeError("The pool is dead!"
Pablo Galindo Salgado added the comment:
Also, making tests that do not leak threads for this case is very difficult as
if we go with weakrefs, the test *has* to leak a pool (the pool is dead but
never calls join/close) to check that when you use the iterator the exception
happens. Also
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +10291
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
This commit broke the following (at least) the buildbots:
https://buildbot.python.org/all/#/builders/38/builds/751
https://buildbot.python.org/all/#/builders/31/builds/719
can someone work on a fix? Otherwise we would have to revert the commit per our
Pablo Galindo Salgado added the comment:
Could it be that there is another test that is sending SIGALRM but does not
disarm the ITIMER_REAL timer before restoring the previous handler?
---
TypeError: 'int' object is not callable
Can it be that thread.file has some custom d
Pablo Galindo Salgado added the comment:
I logged in into the buildbot and try to reproduce that. After 230 iterations
of `test_eintr` I cannot reproduce the signal problem. Maybe this is an
interaction with some other test
--
___
Python
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +10318
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +10319
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset a932d0b496767b5aac14191cbc17093e502b6cb4 by Pablo Galindo in
branch 'master':
bpo-35412: Skip test_multiprocessing_fork and test_multiprocessing_forkserver
on Windows (GH-11086)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 2ab2afd387084ba38a37f5944fcb0675113b64dc by Pablo Galindo in
branch 'master':
bpo-35426: Eliminate race condition in test_interprocess_signal (GH-11087)
https://github.com/python/cpython/commit/2ab2afd387084ba38a37f5944fcb06
New submission from Pablo Galindo Salgado :
There is a race condition in FAIL: test_signal_handling_args
(test.test_asyncio.test_events.KqueueEventLoopTests) in macOS:
https://buildbot.python.org/all/#/builders/147/builds/546/steps/4/logs/stdio
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +10612
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
keywords: +patch, patch
pull_requests: +10612, 10613
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
keywords: +patch, patch, patch
pull_requests: +10612, 10613, 10614
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
New submission from Pablo Galindo Salgado :
According to this buildbot:
https://buildbot.python.org/all/#/builders/170/builds/218/steps/4/logs/stdio
there is some cleanup failure in test_sock_sendfile_os_error_first_call:
test_sock_sendfile_os_error_first_call
Change by Pablo Galindo Salgado :
--
keywords: +patch, patch
pull_requests: +10615, 10616
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +10615
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
keywords: +patch, patch, patch
pull_requests: +10615, 10616, 10617
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset 5471420faa84519530f29b08f2b042b2288e3e96 by Pablo Galindo in
branch 'master':
bpo-35601: Alleviate race condition when waiting for SIGALRM in test_asyncio
(GH-11337)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset d51324a2f5d172665f8824b25456c9822797fc84 by Pablo Galindo in
branch 'master':
bpo-35602: Make sure the transport is always closed in
SelectorEventLoopUnixSockSendfileTests (GH-11338)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
I am going to close this one as the only branch left is 3.6 and is on security
fixes only.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracke
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
Is there anything left in this issue or we can close it?
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue35
Pablo Galindo Salgado added the comment:
Should we close this issue or is anything left in this Derby?
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue20
Change by Pablo Galindo Salgado :
--
keywords: +patch, patch
pull_requests: +10676, 10677
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +10676
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
keywords: +patch, patch, patch
pull_requests: +10676, 10677, 10678
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
pull_requests: -10677, 10678
___
Python tracker
<https://bugs.python.org/issue35606>
___
___
Python-bugs-list mailin
Change by Pablo Galindo Salgado :
--
pull_requests: -10678
___
Python tracker
<https://bugs.python.org/issue35606>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
New changeset 0e5f771f38138714415f665651de7e674fcebc38 by Pablo Galindo (Sergey
Fedoseev) in branch 'master':
bpo-33234: Simplify list_preallocate_exact() (GH-11220)
https://github.com/python/cpython/commit/0e5f771f38138714415f665651de7e
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
I think is missing a manual backport to 3.6, but now that we are in security
fixes only I am not sure of what to do.
--
___
Python tracker
<https://bugs.python.org/issue35
Pablo Galindo Salgado added the comment:
I also think to expose posix_spawnp() as os.posix_spawnp() seems the more
consistent thing to do as the os/posix module tries to mirror glibc as much as
possible, which helps with discoverability and cross-reference with man pages
Pablo Galindo Salgado added the comment:
@Antoine Do you think we should start planning one of these long term solutions
or we should start trying to use Process.sentinel as a short term solution for
this particular issue?
--
___
Python tracker
Change by Pablo Galindo Salgado :
--
keywords: +patch, patch, patch
pull_requests: +11001, 11002, 11003
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +11001
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
keywords: +patch, patch
pull_requests: +11001, 11002
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
pull_requests: +11030, 11031
___
Python tracker
<https://bugs.python.org/issue24746>
___
___
Python-bugs-list mailin
Change by Pablo Galindo Salgado :
--
pull_requests: +11030
___
Python tracker
<https://bugs.python.org/issue24746>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
I made https://github.com/python/cpython/pull/11501 to fix this problem. After
my patch:
❯ ./python.exe -m test test_doctest test_doctest
Run tests sequentially
0:00:00 load avg: 1.82 [1/2] test_doctest
0:00:02 load avg: 1.82 [2/2] test_doctest
Change by Pablo Galindo Salgado :
--
pull_requests: +11030, 11031, 11032
___
Python tracker
<https://bugs.python.org/issue24746>
___
___
Python-bugs-list mailin
Pablo Galindo Salgado added the comment:
Hi Hernot,
I think I understand what you are indicating but I still find it a bit
confusing. Could you provide a reproducer and document a bit more the expected
and actual behaviour, maybe with some code snippets?
Thanks
--
nosy: +pablogsal
Pablo Galindo Salgado added the comment:
I have been playing with possible solutions for a while and the weak-reference
solution seems not robust enough as there are too potential race conditions
between the destruction of the weakreferences (the pool) and the handling code.
I would
Pablo Galindo Salgado added the comment:
That looks like an error indeed. Are you interested on making a PR for fixing
this?
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue35
Pablo Galindo Salgado added the comment:
Hi David,
Can you provide a full reproducer? In your example, mocked_print is undefined.
Please, provide a self-contained script that can be executed to test the
behaviour.
--
nosy: +pablogsal
___
Python
Pablo Galindo Salgado added the comment:
Indeed, closed as duplicate of https://bugs.python.org/issue25532
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
I think this is becase at the end, the threading code calls
sem_timedwait(thelock, &ts) where &ts is the timespect structure. The manpage
of sem_timedwait says:
...
The timeout shall expire when the absolute time specified by abs_timeout
pa
Pablo Galindo Salgado added the comment:
> One of the issue that I have with using posix_spawn() is that the *exact*
> behavior of subprocess is not properly defined by test_subprocess. Should we
> more more tests, or document that the exact behavior is "an implementation
>
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +11266
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
keywords: +patch, patch
pull_requests: +11266, 11267
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
keywords: +patch, patch, patch
pull_requests: +11266, 11267, 11268
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
pull_requests: -11268
___
Python tracker
<https://bugs.python.org/issue17005>
___
___
Python-bugs-list mailing list
Unsub
Change by Pablo Galindo Salgado :
--
pull_requests: -11267, 11268
___
Python tracker
<https://bugs.python.org/issue17005>
___
___
Python-bugs-list mailin
3701 - 3800 of 4563 matches
Mail list logo
