Pablo Galindo Salgado added the comment:
Thanks again, Serhiy :)
--
___
Python tracker
<https://bugs.python.org/issue37112>
___
___
Python-bugs-list mailin
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +13582
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/13697
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
title: Error in compilig the AST for functions with optional positional
arguments -> Error in compilig the AST for functions with optional
positional-only arguments
___
Python tracker
<https://bugs.pyth
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 2f58a84104ef64f71deb71d264305bcd73e59c97 by Pablo Galindo in
branch 'master':
bpo-37112: Allow compile to work on AST with positional only arguments with
defaults (GH-13697)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
components: Interpreter Core
nosy: pablogsal
priority: normal
severity: normal
status: open
title: Support annotations in positional-only arguments
versions: Python 3.8
___
Python tracker
<ht
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +13583
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/13698
___
Python tracker
<https://bugs.python.org/issu
New submission from Pablo Galindo Salgado :
New changeset a0c01bf1364f2996bb0186ddfc41d74350e01c39 by Pablo Galindo in
branch 'master':
bpo-37115: Support annotations in positional-only arguments (GH-13698)
https://github.com/python/cpython/commit/a0c01bf1364f2996bb0186ddfc41d7
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
Although I completely agree with the decision of figuring out an explicit
consensus regarding these APIs, I will explain a bit my +1:
My +1 is not about the usage of PyCode_New, is about the usage of
`types.CodeType`. The constructor for the later
Change by Pablo Galindo Salgado :
--
pull_requests: +13593
pull_request: https://github.com/python/cpython/pull/13706
___
Python tracker
<https://bugs.python.org/issue36
Change by Pablo Galindo Salgado :
--
pull_requests: +13594
pull_request: https://github.com/python/cpython/pull/13707
___
Python tracker
<https://bugs.python.org/issue36
Pablo Galindo Salgado added the comment:
Being said that, I am very happy with the current changes on the PR :)
Thank you @Terry and @Petr for helping with this!
--
___
Python tracker
<https://bugs.python.org/issue36
Pablo Galindo Salgado added the comment:
New changeset aac4d0342c3e692731c189d003dbd73a8c681a34 by Pablo Galindo in
branch 'master':
bpo-26826: Expose copy_file_range in the os module (GH-7255)
https://github.com/python/cpython/commit/aac4d0342c3e692731c189d003dbd7
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue37102>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Pablo Galindo Salgado :
Originally proposed in:
https://mail.python.org/pipermail/python-dev/2019-June/157812.html
--
components: Interpreter Core
messages: 344178
nosy: pablogsal, scoder, serhiy.storchaka
priority: normal
severity: normal
status: open
title: Make
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +13610
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/13726
___
Python tracker
<https://bugs.python.org/issu
New submission from Pablo Galindo Salgado :
https://buildbot.python.org/all/#/builders/58/builds/2539
https://buildbot.python.org/all/#/builders/58/builds/2539
Traceback (most recent call last):
File
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\test_venv.py",
New submission from Pablo Galindo Salgado :
BUILDBOT FAILURE REPORT
===
Builder name: AMD64 Windows8.1 Refleaks 2.7
Builder url: https://buildbot.python.org/all/#/builders/33/
Build url: https://buildbot.python.org/all/#/builders/33/builds/604
Failed tests
Change by Pablo Galindo Salgado :
--
nosy: +steve.dower
___
Python tracker
<https://bugs.python.org/issue37124>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
This is likely to be caused by:
https://github.com/python/cpython/pull/13688
--
___
Python tracker
<https://bugs.python.org/issue37
New submission from Pablo Galindo Salgado :
./python Lib/test/bisect_cmd.py test_math -R 2:2
...
WARNING: Running tests with --huntrleaks/-R and less than 3 warmup repetitions
can give false positives!
Run tests sequentially
0:00:00 load avg: 1.32 [1/1] test_math
beginning 4 repetitions
1234
Pablo Galindo Salgado added the comment:
math.comb is leaking, I opened https://bugs.python.org/issue37125 to track it.
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue35
Pablo Galindo Salgado added the comment:
It seems that https://github.com/python/cpython/pull/13725 fixes the leak:
❯ ./python -m test test_math -R :
Run tests sequentially
0:00:00 load avg: 1.55 [1/1] test_math
beginning 9 repetitions
123456789
.
== Tests result: SUCCESS ==
1 test
Pablo Galindo Salgado added the comment:
Sorry, I posted the same link twice. Here is the test_venv failure:
https://buildbot.python.org/all/#/builders/58/builds/2538
--
___
Python tracker
<https://bugs.python.org/issue37
New submission from Pablo Galindo Salgado :
https://buildbot.python.org/all/#/builders/1/builds/601
OK (skipped=1)
.
test_threading leaked [9770, 9772, 9768] references, sum=29310
test_threading leaked [3960, 3961, 3959] memory blocks, sum=11880
2 tests failed again:
test_asyncio
Pablo Galindo Salgado added the comment:
New changeset cd74e66a8c420be675fd2fbf3fe708ac02ee9f21 by Pablo Galindo in
branch 'master':
bpo-37122: Make co->co_argcount represent the total number of positonal
arguments in the code object (GH-13726)
https://github.com/python/c
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
Ping, should we include this in beta1 or as is a "bugfix" this can be
backported?
--
___
Python tracker
<https://bugs.python.o
Pablo Galindo Salgado added the comment:
❯ ./python -m test test_threading -m test_excepthook_thread_None -R :
Run tests sequentially
0:00:00 load avg: 1.38 [1/1] test_threading
beginning 9 repetitions
123456789
.
test_threading leaked [364, 364, 364, 364] references, sum=1456
Change by Pablo Galindo Salgado :
--
priority: normal -> high
___
Python tracker
<https://bugs.python.org/issue37126>
___
___
Python-bugs-list mailing list
Un
Pablo Galindo Salgado added the comment:
The problem here is that there is a reference cycle with
threading.ExceptHookArgs but structseq objects are not tracked by the GC.
--
___
Python tracker
<https://bugs.python.org/issue37
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +13613
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/13729
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Łukasz, this PR will fix the x86 Gentoo Refleaks 3.x and friends, so I would
recommend landing this before the release.
--
nosy: +lukasz.langa
___
Python tracker
<https://bugs.python.org/issue37
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
Fixed by https://github.com/python/cpython/pull/13725
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 3b57f50efc16c65df96914ec53bc8d3dc28e18b6 by Pablo Galindo in
branch 'master':
bpo-36842: Pass positional only parameters to code_new audit hook (GH-13707)
https://github.com/python/cpython/commit/3b57f50efc16c65df96914ec53bc8d
Pablo Galindo Salgado added the comment:
Just a heads up from issue37125: The leak is was fixed by PR13725.
--
___
Python tracker
<https://bugs.python.org/issue35
Pablo Galindo Salgado added the comment:
New changeset 7ffcf848df214135abeea7f6c6faa4135fd0928f by Pablo Galindo in
branch 'master':
bpo-37126: Allow structseq objects to be tracked by the GC (GH-13729)
https://github.com/python/cpython/commit/7ffcf848df214135abeea7f6c6faa4
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Pablo Galindo Salgado :
In the documentation, there are a lot of mismatches regarding function and
method signatures that use positional-only arguments with respect to the
docstrings (that properly use PEP570 syntax for documenting positional-only
parameters).
Not that
Change by Pablo Galindo Salgado :
--
keywords: +easy
stage: -> needs patch
title: Use PEP570 syntax in the documentation -> [EASY] Use PEP570 syntax in
the documentation
type: -> enhancement
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +13626
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/13743
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
nosy: +lukasz.langa
priority: normal -> high
___
Python tracker
<https://bugs.python.org/issue37124>
___
___
Python-
Pablo Galindo Salgado added the comment:
test_msilib is leaking references https://bugs.python.org/issue37124
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue12
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +13631
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/13750
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
The leak is because creating a 'msilib.Directory' adds an entry on a global
variable '_directories', therefore leaking.
My first PR will make sure the _directories is cleared out after the test to
stop the leak, but it seems to
Change by Pablo Galindo Salgado :
--
pull_requests: +13632
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/13751
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
> You forgot to call PyObject_GC_UnTrack() in structseq_dealloc(), no?
Yep, thanks for the catch!
--
stage: patch review -> resolved
___
Python tracker
<https://bugs.python.org/i
Pablo Galindo Salgado added the comment:
New changeset c0295dba259accc4b247beb22a0b2cc2f31d9850 by Pablo Galindo in
branch 'master':
bpo-37124: Fix reference leak in test_msilib (GH-13750)
https://github.com/python/cpython/commit/c0295dba259accc4b247beb22a0b2c
Pablo Galindo Salgado added the comment:
I cannot reproduce this issue locally :(
--
___
Python tracker
<https://bugs.python.org/issue35621>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
When I ran the tests, the watcher I get is a SafeChildWatcher
--
___
Python tracker
<https://bugs.python.org/issue35
Pablo Galindo Salgado added the comment:
> The failure depends on tests order execution (maybe you use -jN flag?).
Oh, I understand now!
> See https://github.com/python/cpython/pull/13754 for the fix
Thanks for the fix, Andrew! :)
--
___
New submission from Pablo Galindo Salgado :
test_import (test.test_multiprocessing_spawn._TestImportStar) ... ok
--
Ran 352 tests in 322.667s
OK (skipped=34)
Warning -- files was modified by test_multiprocessing_spawn
Before
Change by Pablo Galindo Salgado :
--
nosy: +koobs
___
Python tracker
<https://bugs.python.org/issue37135>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Pablo Galindo Salgado :
--
nosy: +pitrou
___
Python tracker
<https://bugs.python.org/issue37135>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Pablo Galindo Salgado :
--
pull_requests: +13645
pull_request: https://github.com/python/cpython/pull/13760
___
Python tracker
<https://bugs.python.org/issue35
Pablo Galindo Salgado added the comment:
New changeset 8565f6b6db0fa9f65449b532a5056a98bad3dc37 by Pablo Galindo in
branch 'master':
bpo-35814: Allow unpacking in r.h.s of annotated assignment expressions
(GH-13760)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
pull_requests: +13656
pull_request: https://github.com/python/cpython/pull/13760
___
Python tracker
<https://bugs.python.org/issue33
Pablo Galindo Salgado added the comment:
Thank you, Raymond, for sharing your concerns regarding this. I am sorry you
disagree with this change.
I would want to expose the reasons I think this is important and justified, but
please, don't read this
as a way of dismissing your concer
Pablo Galindo Salgado added the comment:
I am unable to reproduce this locally, will post here a backtrace if I manage
to do so.
--
___
Python tracker
<https://bugs.python.org/issue37
Pablo Galindo Salgado added the comment:
Adding the release manager to consider this
--
nosy: +lukasz.langa
___
Python tracker
<https://bugs.python.org/issue37
Pablo Galindo Salgado added the comment:
> FTR Victor reverted GH-13714 that triggers this.
Given the nature of the bugs, I would recommend to watch the buildbots
--
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
pull_requests: +13673
pull_request: https://github.com/python/cpython/pull/13789
___
Python tracker
<https://bugs.python.org/issue37
Change by Pablo Galindo Salgado :
--
nosy: -pablogsal
___
Python tracker
<https://bugs.python.org/issue33694>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
CURRENT-amd64% lldb ./python -c python.core
(lldb) target create "./python" --core "python.core"
Core file '/home/pablo/cpython/python.core' (x86_64) was loaded.
(lldb) bt
* thread #1, name = 'python',
Pablo Galindo Salgado added the comment:
Note that the core dump that we are talking about is something that we produced
afterwards when trying to reproduce the issue. The core that is produced as
part of the tests could be different. I am trying to get access to the test
files
New submission from Pablo Galindo Salgado :
https://buildbot.python.org/all/#/builders/1/builds/609/steps/5/logs/stdio
=
FAIL: test_stream_reader_create_warning
(test.test_asyncio.test_streams.StreamTests
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +13686
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/13800
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
> I'm curious if collections.__getattr__ suffers from the same problem?
Very likely, the problem is that there is no test in test_collections for the
deprecation warning, so this situation never
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 4cdbc452ce308bb55523e53963cabdc988e3f44b by Pablo Galindo in
branch 'master':
bpo-37148: Fix asyncio test that check for warning when running the test suite
with huntleaks (GH-13800)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
But copy_file_rane can leverage more filesystem features like deduplication and
copy offload stuff.
--
___
Python tracker
<https://bugs.python.org/issue26
Pablo Galindo Salgado added the comment:
Thank you, everyone, for expressing clearly your different opinions and
concerns. Without disregarding any of the
arguments so far I want to make some further clarifications on some points and
why I still think this is important.
> FWIW, I wo
Pablo Galindo Salgado added the comment:
Thank you Carol for your comment! Regarding your proposal, I find it it
attractive as a compromise in order to make more gentle the introduction of the
feature to users. I really appreciate the effort to balance all the different
aspects and concerns
Pablo Galindo Salgado added the comment:
> Pablo, Sure thing. I believe that a Sphinx extension (possibly existing
> sphinx-tabs as suggested by @bskinn in the Steering Council issue or one we
> develop/find) could give us both a "technically accurate" view and
> "
Pablo Galindo Salgado added the comment:
> If that premise turns out to be false, we should think seriously about
> whether this makes the docs less approachable for everyday users.
We have not done such a thing for any other feature of the language. I think
that since this is now
Pablo Galindo Salgado added the comment:
> FWIW, there is precedent. We have type annotations in the language but don't
> use them throughout the docs.
Although there is some distance between both cases, I think this is an
extremely good point to take into account that I have
Change by Pablo Galindo Salgado :
--
title: [EASY] Use PEP570 syntax in the documentation -> Use PEP570 syntax in
the documentation
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Thank you very much, everyone, for sharing your comments, views and concerns
and thanks to the steering council for helping to reach a conclusion.
I have updated PR13743 to only modify the functions that fall into the second
point of Brett's me
Change by Pablo Galindo Salgado :
--
pull_requests: +13728
pull_request: https://github.com/python/cpython/pull/13851
___
Python tracker
<https://bugs.python.org/issue37
Pablo Galindo Salgado added the comment:
New changeset c4c421d619baf2ff2f7e09f55b7ae22b8f863c7b by Pablo Galindo in
branch 'master':
bpo-37134: Use PEP570 syntax for sum() (GH-13851)
https://github.com/python/cpython/commit/c4c421d619baf2ff2f7e09f55b7ae2
Pablo Galindo Salgado added the comment:
Thanks Brian for the prototype!
I will close this now. We can reopen if something is missing in the future.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Pytho
Change by Pablo Galindo Salgado :
--
pull_requests: +13752
pull_request: https://github.com/python/cpython/pull/13874
___
Python tracker
<https://bugs.python.org/issue37
Pablo Galindo Salgado added the comment:
New changeset de76c07a8cd0216c3dce215e4d542e2f45aa022f by Pablo Galindo in
branch 'master':
bpo-37134: Add PEP570 notation to the signature of byte{array}.translate
(GH-13874)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
+1 to Serhiy's proposal
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue37163>
___
___
Pytho
New submission from Pablo Galindo Salgado :
./python.exe -m test test_os -R : -v
==
FAIL: test_utime (test.test_os.UtimeTests)
--
Traceback (most recent call
Pablo Galindo Salgado added the comment:
Python debug information
CC.version: Configured with: --prefix=/Library/Developer/CommandLineTools/usr
--with-gxx-include-dir=/usr/include/c++/4.2.1
Py_DEBUG: Yes (sys.gettotalrefcount() present)
_decimal.__libmpdec_version__
Pablo Galindo Salgado added the comment:
The failure tends to be very reliable when running with -R, running the test in
isolation or only one time normally succeeds. I will try to investigate more.
The hardware is a MacBook Pro with Mojave 10.14.5, 2.2 GHz Intel Core i7 and 16
GB 2400 MHz
Pablo Galindo Salgado added the comment:
The problem is that one of the filenames that the test creates has this inode
information for some mysterious reason:
❯ ll @test_25508_tmp/f1
-rw-r--r-- 1 pgalindo3 staff 7B 1 Jan 1970 @test_25508_tmp/f1
Change by Pablo Galindo Salgado :
--
Removed message: https://bugs.python.org/msg344983
___
Python tracker
<https://bugs.python.org/issue37195>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
For some reason, the files created for this test has a very weird inode
information:
❯ ll test_python_**/**/f*
-rw-r--r-- 1 pgalindo3 staff 7B 1 Jan 1970
test_python_26370/@test_26370_tmp/f1
Pablo Galindo Salgado added the comment:
> For some reason, the files created for this test has a very weird inode
> information.
Ok, disregard what I am saying, that's actually part of the test. But I think
this is related to the failure. I keep in
Pablo Galindo Salgado added the comment:
Ok, this is the failure once I investigated with pdb:
(Pdb) filename
'@test_28886_tmp/f1'
(Pdb) atime_ns
1002003000
(Pdb) mtime_ns
4005006000
(Pdb) set_time(filename, (atime_ns, mtime_ns))
(Pdb) st = os.stat(filename)
(Pdb) st.st_atime, s
Pablo Galindo Salgado added the comment:
I will test this on other laptops to try to "bisect" configuration-wise, but
for my investigation so far, it seems that the value in the (STRUCT_STAT)
st->st_atime is directly wrong (is 1559932701 when the test fails and 1 when
the
Pablo Galindo Salgado added the comment:
> WHat kind of file system is @test_28886_tmp/f1 created on?
Apple_APFS
--
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Thank you very much, Serhiy!
I am interested, I will try to look at the problem and try to get a PR soon.
What of the two possible solutions that you mention you think is better? I
assume if we make the peephole optimizer work with lnotab containing
Pablo Galindo Salgado added the comment:
Thanks, Nick for opening this issue. If everyone agrees this is the best path
forward I can make a PR. Take into account that doing such rename will break
again the projects that have adapted already (primarily only Cython). I would
like to give some
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +13825
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/13959
___
Python tracker
<https://bugs.python.org/issu
3501 - 3600 of 4563 matches
Mail list logo