Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +21966
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23048
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset 06f8c3328dcd81c84d1ee2b3a57b5381dcb38482 by Pablo Galindo in
branch 'master':
bpo-42214: Fix check for NOTEQUAL token in the PEG parser for the
barry_as_flufl rule (GH-23048)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
pull_requests: +21970
pull_request: https://github.com/python/cpython/pull/23051
___
Python tracker
<https://bugs.python.org/issue42
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset ddcd57e3ea75ab0ad370bbaaa6b76338edbca395 by Pablo Galindo in
branch '3.9':
[3.9] bpo-42214: Fix check for NOTEQUAL token in the PEG parser for the
barry_as_flufl rule (GH-23048) (GH-23051)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
> Maybe someone can bisect and find when this started happening?
As far as I understand, this has been the case since Python 2 at least:
$cat code.py
gdict = {}
ldict = {}
exec('''
x = 1
def f(): global x''', gdict, l
Pablo Galindo Salgado added the comment:
Commit c41559021213cfc9dc62a83fc63306b3bdc3e64b has introduced reference leaks:
--
Ran 202 tests in 21.654s
OK (skipped=1)
..
test_logging leaked [20, 20, 20] references, sum=60
Pablo Galindo Salgado added the comment:
New changeset aca67da4fe68d5420401ac1782203d302875eb27 by Jason R. Coombs in
branch 'master':
Revert "bpo-37193: remove thread objects which finished process its request
(GH-13893)" (GH-23107)
https://github.com/p
Pablo Galindo Salgado added the comment:
I'm happy that we are removing BEGIN_DO_NOT_EMIT_BYTECODE and
END_DO_NOT_EMIT_BYTECODE but could you elaborate how this is related? These
macros protect the compiler from emitting bytecode that corresponds to deaf
code and by definition, unreac
Pablo Galindo Salgado added the comment:
New changeset 9568622c9983b682b2a2a7bacfd3c341028ea099 by Jakub Kulík in branch
'master':
bpo-35455: Fix thread_time for Solaris OS (GH-8)
https://github.com/python/cpython/commit/9568622c9983b682b2a2a7bacfd3c341028ea099
-
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue35455>
___
___
Pyth
Pablo Galindo Salgado added the comment:
New changeset 6b7a90db362253d67201c2a438a3f38f1ec6180c by Miss Skeleton (bot)
in branch '3.9':
bpo-42180: fix plural in arguments and control (GH-23015) (GH-23114)
https://github.com/python/cpython/commit/6b7a90db362253d67201c2a438a3f3
New submission from Pablo Galindo Salgado :
https://buildbot.python.org/all/#/builders/205/builds/83
OK
..
test_ast leaked [23640, 23636, 23640] references, sum=70916
test_ast leaked [7932, 7930, 7932] memory blocks, sum=23794
1 test failed again:
test_ast
--
messages: 380269
Change by Pablo Galindo Salgado :
--
assignee: -> vstinner
___
Python tracker
<https://bugs.python.org/issue42250>
___
___
Python-bugs-list mailing list
Un
Change by Pablo Galindo Salgado :
--
components: +Tests
nosy: +BTaskaya, vstinner -pablogsal
versions: +Python 3.10
___
Python tracker
<https://bugs.python.org/issue42
Pablo Galindo Salgado added the comment:
> Dead code elimination will remove the `secret_debugging_code()`, but leave
> the test. The peephole optimiser can then reduce it to a NOP, but won't
> eliminate it as it is the only instruction for line 1.
Gotcha. I am pretty sure
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 0001a1b69ecda47b0406daa88c2943877580bcae by Mario Corchero in
branch 'master':
bpo-42251: Add gettrace and getprofile to threading (GH-23125)
https://github.com/python/cpython/commit/0001a1b69ecda47b0406daa88c2943
Pablo Galindo Salgado added the comment:
New changeset 72bb4c6c1fc5f5209819a2e62d55475ddc888192 by Miss Skeleton (bot)
in branch '3.9':
bpo-35455: Fix thread_time for Solaris OS (GH-8) (GH-23130)
https://github.com/python/cpython/commit/72bb4c6c1fc5f5209819a2e62d5547
Pablo Galindo Salgado added the comment:
New changeset a12f459ec2a31b96a21c735eb18f3d0fd19e99ff by Jakub Kulík in branch
'3.8':
[3.8] bpo-35455: Fix thread_time for Solaris OS (GH-8). (GH-23145)
https://github.com/python/cpython/commit/a12f459ec2a31b96a21c735eb18f3d
Pablo Galindo Salgado added the comment:
Good catch, Kevin! Would you like to submit a PR for fixing this?
--
___
Python tracker
<https://bugs.python.org/issue42
Pablo Galindo Salgado added the comment:
Given that having attributes that are classes is quite uncommon, I think we can
not optimize of the attribute itself is a class instead of checking for
descriptors on every hit, hurting the performance gains
Pablo Galindo Salgado added the comment:
Yury, any preference here?
--
nosy: +yselivanov
___
Python tracker
<https://bugs.python.org/issue42266>
___
___
Pytho
Pablo Galindo Salgado added the comment:
We could also store the tag of the type object if is a descriptor and compare
against that on the cache hit to check that our assumptions are valid. The
price here would be an extra pointer on the cache per opcode that may not even
be used most of
Pablo Galindo Salgado added the comment:
s/the attribute itself is a class/the attribute itself is in the class/
--
___
Python tracker
<https://bugs.python.org/issue42
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +22068
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23157
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset 80449f243b13311d660eab3a751648029bcdd833 by Pablo Galindo in
branch 'master':
bpo-42266: Handle monkey-patching descriptors in LOAD_ATTR cache (GH-23157)
https://github.com/python/cpython/commit/80449f243b13311d660eab3a751648
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 91e93794d5dd1aa91fbe142099c2955e0c4c1660 by Zackery Spytz in
branch 'master':
bpo-26389: Allow passing an exception object in the traceback module (GH-22610)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
> But... does any user really build Python manually after Python is installed?
> The Python build system couldn't handle that as part of the regular build?
> Maybe using a new configure --enable-static flag?
Embedding? But they should
Pablo Galindo Salgado added the comment:
Hummm, I think the gains of having the .o over the .a are very very small as
you can almost recreate anything you want with the .o using the .a and a small
initialization function unless I am missing something
Pablo Galindo Salgado added the comment:
> By the way, is there a replacement for this function? The unbound project
> uses it to display a SyntaxError when PyRun_SimpleFile() fails.
There is no replacement for the function because that function returned CST
nodes and those not
Pablo Galindo Salgado added the comment:
I will submit a PR today
--
___
Python tracker
<https://bugs.python.org/issue40939>
___
___
Python-bugs-list mailin
Pablo Galindo Salgado added the comment:
Mark, could you kindly create a proposed update to the PEP in the form of a PR
so I can evaluate it and we can iterate directly over the final specification?
--
___
Python tracker
<https://bugs.python.
Pablo Galindo Salgado added the comment:
> Pablo, have you already started on this? I didn't see your comment earlier
> and I've got a PR ready.
Yeah, but don't worry: submit your PR and I will review it :)
--
___
P
Pablo Galindo Salgado added the comment:
> The removals are documented, but the developers who are affected have no clue
> what to do. What do you think?
Here is difficult to recommend a canonical Path because as I mentioned, there
is no replacement for these functions becaus
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +0
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23332
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Apparently we currently don't allow walruses in set literals either:
>>> {y := 4, 4**2, 3**3}
File "", line 1
{y := 4, 4**2, 3**3}
^
SyntaxError: invalid syntax
But they should be allowed as well per PEP 572
Pablo Galindo Salgado added the comment:
The only question left is that if we should allow this on dict literals and
dict comprehensions as well (because these constructs have a ":" in the middle
that can be noisy if there are walrus, the answer isn't immediately
Pablo Galindo Salgado added the comment:
> Nagging question — is there sufficient difference between {x := y} and {x: y}
> ?
I think there is enough distinction, yes. It will also be a bit odd if is
allowed in list and list comps but not set and set
Pablo Galindo Salgado added the comment:
New changeset a57b3d30f66c90f42da751bf82256b9b22961ed0 by Pablo Galindo in
branch 'master':
bpo-41625: Expose the splice() system call in the os module (GH-21947)
https://github.com/python/cpython/commit/a57b3d30f66c90f42da751bf82256b
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset b0aba1fcdc3da952698d99aec2334faa79a8b68c by Pablo Galindo in
branch 'master':
bpo-42381: Allow walrus in set literals and set comprehensions (GH-23332)
https://github.com/python/cpython/commit/b0aba1fcdc3da952698d99aec2334f
Change by Pablo Galindo Salgado :
--
pull_requests: +1
pull_request: https://github.com/python/cpython/pull/2
___
Python tracker
<https://bugs.python.org/issue42
Pablo Galindo Salgado added the comment:
> This code is non-trivial :-( Should we provide a *new* C function doing that?
We could discuss adding a new C function, but IMHO that code is not especially
horrible or unreadable. I agree it could be simpler, tho
Pablo Galindo Salgado added the comment:
> Do you mean "Linux kernel >= 2.6.17 and glibc >= 2.5" ?
My understanding is that glibc provides emulation for glibc >= 2.5
The section from the manpage says:
The splice() system call first appeared in Linux 2.6.17; libr
Change by Pablo Galindo Salgado :
--
pull_requests: +22231
pull_request: https://github.com/python/cpython/pull/23340
___
Python tracker
<https://bugs.python.org/issue41
Pablo Galindo Salgado added the comment:
New changeset fa96608513b6eafe48777f1a5504134939dcbebc by Pablo Galindo in
branch 'master':
bpo-41625: Add versionadded to os.splice() constants (GH-23340)
https://github.com/python/cpython/commit/fa96608513b6eafe48777f1a550413
Change by Pablo Galindo Salgado :
--
pull_requests: +22244
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/23350
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
pull_requests: +22245
pull_request: https://github.com/python/cpython/pull/23351
___
Python tracker
<https://bugs.python.org/issue41
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
Thanks a lot Victor
--
___
Python tracker
<https://bugs.python.org/issue41625>
___
___
Python-bugs-list mailin
Pablo Galindo Salgado added the comment:
New changeset 87c87b5bd6f6a5924b485398f353308410f9d8c1 by Pablo Galindo in
branch '3.9':
[3.9] bpo-42381: Allow walrus in set literals and set comprehensions (GH-23332)
(GH-2)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
Unless we see something fundamentally broken with the hashability, I am +1 on
this. Even if it does not show in macro benchmarks over the 3% mark, the
microbenchmarks are positive and the code changes are very scoped, so there is
not a
Change by Pablo Galindo Salgado :
--
pull_requests: +22392
pull_request: https://github.com/python/cpython/pull/23503
___
Python tracker
<https://bugs.python.org/issue42
Pablo Galindo Salgado added the comment:
I may not know the what is the average airspeed velocity of a laden swallow,
but I know the average speed of adding a LOAD_METHOD opcode cache as in PR
23503 (measured with PGO + LTO + CPU isolation
Pablo Galindo Salgado added the comment:
New changeset af8646c8054d0f4180a2013383039b6a472f9698 by Pablo Galindo in
branch 'master':
bpo-1875: Raise SyntaxError in invalid blocks that will be optimised away
(GH-13332)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.o
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Pablo Galindo Salgado :
Any line in test_annotations() containing positional-only markers
in Lib/test/test_future.py will fail:
eq('lambda x, /: x')
Run tests sequentially
0:00:00 load avg: 0.71 [1/1] test_future
test test_future failed -- Traceback (m
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +13323
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Thanks for the patch Batuhan!
--
nosy: +pablogsal
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset da6129e821099c1372d511a11d18af83d6d5d128 by Pablo Galindo in
branch 'master':
bpo-36961: Handle positional-only arguments in uparse.c (GH-13412)
https://github.com/python/cpython/commit/da6129e821099c1372d511a11d18af
Pablo Galindo Salgado added the comment:
Notice that pdb also does not handle correctly PEP570:
def f1(x,/,arg=None, *, kwonly=None):
breakpoint()
f1(3)
-> breakpoint()
(Pdb) args
x = 3
--
nosy: +pablogsal
___
Python tracker
<
Pablo Galindo Salgado added the comment:
New changeset bf457c7d8224179a023957876e757f2a7ffc3d9d by Pablo Galindo (Rémi
Lapeyre) in branch 'master':
bpo-36969: Make PDB args command display keyword only arguments (GH-13452)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
Rémi, could you do a PR addressing co_posonlyargcount?
--
___
Python tracker
<https://bugs.python.org/issue36
Pablo Galindo Salgado added the comment:
> Of course, should I open a new PR or post a patch to be added to a current PR?
Make another PR against master.
--
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
I would suggest centralizing all PRs on the same issue as Petr is indicating to
reduce the noise, especially before the PEP is accepted.
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal, yselivanov
___
Python tracker
<https://bugs.python.org/issue37010>
___
___
Python-bugs-list mailin
Pablo Galindo Salgado added the comment:
The reason the main CI did not catch this is that test_tools is only executed
on a (random) subset of all the files if I remember correctly because when
executed on all files it massively increases the time of the CI
Pablo Galindo Salgado added the comment:
Anecdotally, this happened as well when in the implementation of PEP572
--
___
Python tracker
<https://bugs.python.org/issue36
Pablo Galindo Salgado added the comment:
Notice that test_tools will fail if f'{x=}' becomes f'x={x!r}' when unparsed
as it compares the text of the file and the text of the roundtrip of the ast of
the file
--
nosy: +pablogsal
__
Pablo Galindo Salgado added the comment:
Actually, it checks if the dump is the same:
class ASTTestCase(unittest.TestCase):
def assertASTEqual(self, ast1, ast2):
self.assertEqual(ast.dump(ast1), ast.dump(ast2))
def check_roundtrip(self, code1, filename="int
Pablo Galindo Salgado added the comment:
> Notice that test_tools will fail if f'{x=}' becomes f'x={x!r}'
I arrived at the wrong conclusion as Matthias points out.
>>> import ast
>>> ast.dump(compile("f'{x=}'","&quo
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +13447
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset 458560347f5c28e162bb288adfa0cfe5aad79557 by Pablo Galindo (Rémi
Lapeyre) in branch 'master':
bpo-36969: Make PDB args command display positional only arguments (GH-13459)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
Thanks Rémi for the PRs! :)
___
Python tracker
<https://bugs.python.org/issue36969>
___
___
Python-bugs-list mailing list
Unsub
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 561612d8456cfab5672c9b445521113b847bd6b3 by Pablo Galindo in
branch 'master':
bpo-37021: Port _randommodule to the argument clinic (GH-13532)
https://github.com/python/cpython/commit/561612d8456cfab5672c9b44552111
Pablo Galindo Salgado added the comment:
This seems a failure caused after merging either PEP589 or PEP586
--
nosy: +gvanrossum, levkivskyi
___
Python tracker
<https://bugs.python.org/issue37
New submission from Pablo Galindo Salgado :
BUILDBOT FAILURE REPORT
===
Builder name: AMD64 Debian root 3.x
Builder url: https://buildbot.python.org/all/#/builders/27/
Build url: https://buildbot.python.org/all/#/builders/27/builds/3006
Failed tests
Pablo Galindo Salgado added the comment:
Confirmed that this fixes the broken buildbots:
./python -m test test_tools - -uall -m test_files
== CPython 3.8.0a4+ (heads/master:91f4380ced, May 26 2019, 17:30:21) [GCC 8.3.0]
== Linux-5.0.15-1-MANJARO-x86_64-with-glibc2.29 little-endian
== cwd
Change by Pablo Galindo Salgado :
--
resolution: duplicate ->
status: closed -> open
___
Python tracker
<https://bugs.python.org/issue35753>
___
___
Pyth
Pablo Galindo Salgado added the comment:
> * allow input as ordered pairs like the Unix tsort command
> * allow more convenient input as dependency sequences (like graphviz):
This is how my first proposal started (and I still like it a bit more than the
dictionary input), but there ar
Pablo Galindo Salgado added the comment:
Is there anything more on this issue?
--
___
Python tracker
<https://bugs.python.org/issue37032>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
I think we can revisit this now that PEP570 is accepted
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue21
New submission from Pablo Galindo Salgado :
The last changes in the grammar regarding TYPE_COMMENTS should be added to this
section:
https://docs.python.org/3/reference/compound_stmts.html#function-definitions
--
assignee: docs@python
components: Documentation
messages: 343820
nosy
Pablo Galindo Salgado added the comment:
I will make a PR after https://github.com/python/cpython/pull/13202 is merged.
--
___
Python tracker
<https://bugs.python.org/issue37
Pablo Galindo Salgado added the comment:
Closing this. Will reopen if we realize we missed something.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue37082>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
BUILDBOT FAILURE REPORT
===
Builder name: AMD64 Ubuntu Shared 3.x
Builder url: https://buildbot.python.org/all/#/builders/141/
Build url: https://buildbot.python.org/all/#/builders/141/builds/1866
Failed tests
Pablo Galindo Salgado added the comment:
@Petr is https://bugs.python.org/issue37090 and
https://github.com/python/cpython/pull/13668 also addressing the buildbot
failures?
--
___
Python tracker
<https://bugs.python.org/issue36
Pablo Galindo Salgado added the comment:
Great! Thank you very much for the quick fix for the problem.
For AMD64 Ubuntu Shared 3.x, the last build was successful:
https://buildbot.python.org/all/#/builders/141/builds/1870/steps/5/logs/stdio
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +13581
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/13695
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset 3a46d5c293d39995dc5218bf46a7d92b16fb2a15 by Pablo Galindo in
branch 'master':
bpo-37108: Support super with methods that use positional-only arguments
(GH-13695)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
Thank you very much, Serhiy, for the catch!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
assignee: -> pablogsal
___
Python tracker
<https://bugs.python.org/issue37112>
___
___
Python-bugs-list mailing list
Un
3401 - 3500 of 4563 matches
Mail list logo
