Change by Pablo Galindo Salgado :
--
versions: -Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue41675>
___
___
Python-bugs-list mailin
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +21128
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22028
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
What do you refer when you say "sorting a file"?
What does "key" act upon? Strings representing the lines in the file?
For allow_disk_use=False, what's the difference between opening the file,
reading the lines, using sort()
Pablo Galindo Salgado added the comment:
New changeset 9b648a95ccb4c3b14f1e87158f5c9f5dbb2f62c0 by Pablo Galindo in
branch 'master':
bpo-41654: Fix deallocator of MemoryError to account for subclasses (GH-22020)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
pull_requests: +21143
pull_request: https://github.com/python/cpython/pull/22046
___
Python tracker
<https://bugs.python.org/issue41
Change by Pablo Galindo Salgado :
--
pull_requests: +21142
pull_request: https://github.com/python/cpython/pull/22045
___
Python tracker
<https://bugs.python.org/issue41
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +21144
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22047
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset d14775ddbb067bcfa6eca516d3cbe968a8c1334e by Pablo Galindo in
branch '3.9':
[3.9] bpo-41654: Fix deallocator of MemoryError to account for subclasses
(GH-22020) (GH-22045)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 77f4000ae0d43a2685face80e7f14d4aba053973 by Pablo Galindo in
branch '3.8':
[3.8] [3.9] bpo-41654: Fix deallocator of MemoryError to account for subclasses
(GH-22020) (GH-22046)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +21153
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22053
___
Python tracker
<https://bugs.python.org/issu
New submission from Pablo Galindo Salgado :
This program can segfault the parser by stackoverflow:
import ast
code = "f(" + ",".join(['a' for _ in range(10)]) + ")"
print("Ready!")
ast.parse(code)
the reason is that the rule for argu
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset f9c5e3f5f61cd380f8a17c814766fc3730b7fbdf by Pablo Galindo in
branch 'master':
bpo-41675: Modernize siginterrupt calls (GH-22028)
https://github.com/python/cpython/commit/f9c5e3f5f61cd380f8a17c814766fc
Pablo Galindo Salgado added the comment:
New changeset 4a97b1517a6b5ff22e2984b677a680b07ff0ce11 by Pablo Galindo in
branch 'master':
bpo-41690: Use a loop to collect args in the parser instead of recursion
(GH-22053)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
pull_requests: +21157
pull_request: https://github.com/python/cpython/pull/22067
___
Python tracker
<https://bugs.python.org/issue41
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
All the pablogsal-* buildbots have been updated
--
___
Python tracker
<https://bugs.python.org/issue41642>
___
___
Pytho
Pablo Galindo Salgado added the comment:
New changeset 8de34cdb952a2e3b8d7a9a213845cad01a8cece3 by Pablo Galindo in
branch '3.9':
[3.9] bpo-41690: Use a loop to collect args in the parser instead of recursion
(GH-22053) (GH-22067)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
I think I have the problem. The problem is that the asdl_seq that is b is
filled with KeywordOrStarred* not with expr_ty.
We need to do:
KeywordOrStarred* last = asdl_seq_GET(b, asdl_seq_LEN(b)-1);
return _Py_Call(_PyPegen_dummy_name(p), args
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +21164
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22077
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
The reason this does not manifest itself without the address sanitizer is
because that information is thrown away later, and the line and col numbers for
the Call node end being correct.
--
___
Python
Pablo Galindo Salgado added the comment:
I have added a new builbot builder to detect these problems in the future more
immediately:
https://buildbot.python.org/all/#/builders/582
For example, building the current master:
https://buildbot.python.org/all/#/builders/582/builds/1
And with PR
Pablo Galindo Salgado added the comment:
> return _Py_Call(_PyPegen_dummy_name(p), args, keywords, EXTRA_EXPR(first,
> last->element));
Actually, this is not enough because last->element may be a keyword_ty.
I have updated PR 22077 to receive the EXTRA macro in the call
Pablo Galindo Salgado added the comment:
New changeset 315a61f7a9418d904e0eea14b1f054fac3a90e9f by Pablo Galindo in
branch 'master':
bpo-41697: Correctly handle KeywordOrStarred when parsing arguments in the
parser (GH-22077)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
pull_requests: +21166
pull_request: https://github.com/python/cpython/pull/22079
___
Python tracker
<https://bugs.python.org/issue41
Pablo Galindo Salgado added the comment:
New changeset be17295280c89771c80f317da072f6c0d016cc60 by Pablo Galindo in
branch '3.9':
[3.9] bpo-41697: Correctly handle KeywordOrStarred when parsing arguments in
the parser (GH-22077) (GH-22079)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
Given that using asdl_seq currently means casting from void*, we could maybe
have a set of macros like asdl_seq_GET that are type specialized (there aren't
many of them) and in debug mode they can check that the ->kind attribute is
consist
Pablo Galindo Salgado added the comment:
That's true. Is a bit sad because a considerable amount of problems we
experienced with the new parser were due to invalid casts from these structures
:(
--
___
Python tracker
<https://bugs.py
Pablo Galindo Salgado added the comment:
I am of the same opinion as Raymond
--
___
Python tracker
<https://bugs.python.org/issue41678>
___
___
Python-bug
Change by Pablo Galindo Salgado :
--
pull_requests: +21188
pull_request: https://github.com/python/cpython/pull/22102
___
Python tracker
<https://bugs.python.org/issue41
Pablo Galindo Salgado added the comment:
New changeset d64d78be20ced6ac9de58e91e69eaba184e36e9b by Miss Islington (bot)
in branch '3.9':
bpo-41531: Fix compilation of dict literals with more than 0x elements
(GH-21850) (GH-22107)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset a708ae7470cf0abc58a62853c25d9bbc977f8cd1 by Miss Islington (bot)
in branch '3.9':
bpo-41218: Improve the test cases for test_compile_top_level_await_no_coro
(GH-21363) (GH-22109)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 6ae61959ec51a6b3dddc8e665ce6a7b8aeb26c04 by Pablo Galindo in
branch '3.8':
bpo-41654: Explicitly cast PyExc_MemoryError to PyTypeObject to avoid warning
(GH-22102)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
versions: +Python 3.10 -Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue40318>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
New changeset 7f331c898a36d937c66ba93f86d2a445c96d382e by Erlend Egeberg
Aasland in branch 'master':
bpo-40318: Migrate to SQLite3 trace v2 API (GH-19581)
https://github.com/python/cpython/commit/7f331c898a36d937c66ba93f86d2a4
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
See also https://bugs.python.org/issue41571
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue23
Pablo Galindo Salgado added the comment:
New changeset 207c321f13cea3fee7f378057864e8c6453f5adf by Erlend Egeberg
Aasland in branch 'master':
bpo-40744: Drop support for SQLite pre 3.7.3 (GH-20909)
https://github.com/python/cpython/commit/207c321f13cea3fee7f378057864e8
Pablo Galindo Salgado added the comment:
Given the status of the 3.9 branch and given that this does not add anything
new or fixes any specific bug, I would recommend to not backport this
--
___
Python tracker
<https://bugs.python.org/issue40
Pablo Galindo Salgado added the comment:
Feel free to re-open if i missed something :)
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
versions: -Python 3.9
___
Python tracker
<https://bugs.python.org/issue40744>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
These tests are expensive because they have to compile one C extension per test
but I don't see any way to make them faster than does not complicate the whole
setup considerably.
I have tried to compile a shared object containing the common part
New submission from Pablo Galindo Salgado :
Casting incorrect elements pulled from asdl_seq objects has been a pain when
developing the new PEG parser and is a source of spooky-bug-at-a-distance
problems in which the consequences of an incorrect casting from void* are felt
much later.
I
Pablo Galindo Salgado added the comment:
> Let me know if I'm misunderstanding the proposal. Are you proposing a
> non-standard ASDL extension to that won't work with existing ASDL parsers?
No, I am not proposing any modification to the ASDL parsers nor the ASDL
definition
Pablo Galindo Salgado added the comment:
> Why not just include these in the Python-ast.h and auto-generate them in the
> asdl_c.py
That's a possibility, but that would incur in a lot of new extra code, and some
asdl_seq items in the parser contain non-standard types that only P
Pablo Galindo Salgado added the comment:
> Well, since the extra code will be autogenerated, guess it wouldn't be much
> problematic.
It will because it means that generic functions that receive asdl_seq an need
to cast aliased pointers because they will still receive asdl_seq
Pablo Galindo Salgado added the comment:
> Well, since the extra code will be autogenerated, guess it wouldn't be much
> problematic. But I see about the PEG thing.
On the other hand, having explicit types for the sequences will allow us to get
compile errors instead of runtime
Pablo Galindo Salgado added the comment:
> I know it's moot now, but still -- what benefit do we get from using a
> "standard" like ASDL? All our tooling for it is custom for Python only.
I think there are other tools or implementations of Python that use standard
pars
Pablo Galindo Salgado added the comment:
New changeset 58de1dd6a8677bd213802c19204b827cb7134695 by Serhiy Storchaka in
branch 'master':
bpo-41525: Make the Python program help ASCII-only (GH-21836)
https://github.com/python/cpython/commit/58de1dd6a8677bd213802c19204b82
Pablo Galindo Salgado added the comment:
New changeset 1b4552c5e8e925f24c15f707050f22c977171125 by Maggie Moss in branch
'master':
bpo-41428: Implementation for PEP 604 (GH-21515)
https://github.com/python/cpython/commit/1b4552c5e8e925f24c15f707050f22c977171125
--
nosy:
Pablo Galindo Salgado added the comment:
Now that PR 21515 is landed, we should consider what sections of the docs/spec
needs to be updated.
--
___
Python tracker
<https://bugs.python.org/issue41
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +21278
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/3
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue41757>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
Hi Giordon and thanks for your issue.
Could you please check if you can reproduce this behaviour with Python3.8 and
with the current master? We have some new
code that may be preventing this to happen:
https://github.com/python/cpython/blob/master
Pablo Galindo Salgado added the comment:
Indeed, I cannot reproduce this with Pyhon3.8:
(vev) ❯ python -m pytest tests/test_validation.py - -k
"test_optimizer_stitching" -v
=
Pablo Galindo Salgado added the comment:
I think this can be very error prone because a particular operation could be
interrupted by GIL switching in the middle of the context manager and be
reported as taking much more than the execution of the code itself is taking.
This will be very
Change by Pablo Galindo Salgado :
--
resolution: -> rejected
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
Thanks for the proposal Matthew, unfortunately, this addition is not reliable
enough for the standard library and OTOH can be easily implemented in-situ for
the users that know what the limitations are
Change by Pablo Galindo Salgado :
--
pull_requests: +21313
pull_request: https://github.com/python/cpython/pull/22258
___
Python tracker
<https://bugs.python.org/issue41
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
nosy_count: 5.0 -> 6.0
pull_requests: +21314
pull_request: https://github.com/python/cpython/pull/22258
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset a5634c406767ef694df49b624adf9cfa6c0d9064 by Pablo Galindo in
branch 'master':
bpo-41746: Add type information to asdl_seq objects (GH-3)
https://github.com/python/cpython/commit/a5634c406767ef694df49b624adf9c
Change by Pablo Galindo Salgado :
--
pull_requests: +21375
pull_request: https://github.com/python/cpython/pull/22331
___
Python tracker
<https://bugs.python.org/issue41
Pablo Galindo Salgado added the comment:
This is because the types of the grammars in
Lib/test/test_peg_generator/test_c_parser.py needs to be updated to use the new
sequences
--
___
Python tracker
<https://bugs.python.org/issue41
Pablo Galindo Salgado added the comment:
Hi Irit,
Could you kindly check if PR 12607 solves this issue in any way?
--
___
Python tracker
<https://bugs.python.org/issue40
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +21432
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22391
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Hi Cendio Ossman and thanks for the report.
Indeed, there are a bunch of problems here taking into account the language
reference "The variables of the module code block are local and global". PR
22391 fixes those and also the repr-gene
Pablo Galindo Salgado added the comment:
> I'm sorry, that doesn't mean much to me. Is it simply a matter of applying
suitable casts to the various parameters in the C code fragments in those?
Yep, and in the capture variables and in the rule types. Check
https://github.com/p
Pablo Galindo Salgado added the comment:
I think that we should try to land PR 12607 first.
--
___
Python tracker
<https://bugs.python.org/issue40608>
___
___
Pablo Galindo Salgado added the comment:
I concur with Guido: it makes the grammar slightly more complex for no gain.
Also, the originally allowed rule does not allow *any* lambda but only the ones
that are simple, which is a special case that makes it even more complex. In
any case you can
Change by Pablo Galindo Salgado :
--
nosy: +barry, brett.cannon, p-ganssle
___
Python tracker
<https://bugs.python.org/issue41519>
___
___
Python-bugs-list mailin
Change by Pablo Galindo Salgado :
--
pull_requests: +21484
pull_request: https://github.com/python/cpython/pull/22455
___
Python tracker
<https://bugs.python.org/issue41
Pablo Galindo Salgado added the comment:
Closing as not a bug, feel free to reopen if we are missing something here :)
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
> FWIW, I believe that you have to call `PyErr_NormalizeException` on the
> values returned from `PyErr_Fetch`. It looks like this is working as expected.
Indeed that is the case, from the docs:
Under certain circumstances, the values retur
Pablo Galindo Salgado added the comment:
> You can put ok<0 test in the if (nargs) branch, to avoid the test when
> nargs=0.
+1
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
I would need to carefully look at the PRs to estimate the maintenance cost, but
it seems to me initially that all these operations happen very rarely in
regular code and probably will have no impact on macro benchmarks. In general,
I dislike branches
Pablo Galindo Salgado added the comment:
I think that the backport to 3.8 may have some unintended consequences in the
last patch release as venv created with 3.8 now exhibit the pip regression
(https://github.com/pypa/pip/issues/8695.).
Steve, would you be ok if we bump all branches
Pablo Galindo Salgado added the comment:
> I dunno, but it's been doing this since 1992, so I think it would be fragile
> to change. The best thing therefore is to make ast.literal_eval() match it
> exactly.
+1 We had considerable finicky behaviour in the parser related to
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
pull_requests: +21532
pull_request: https://github.com/python/cpython/pull/22527
___
Python tracker
<https://bugs.python.org/issue41
Pablo Galindo Salgado added the comment:
New changeset fb0a4651f1be4ad936f8277478f73f262d8eeb72 by Pablo Galindo in
branch 'master':
bpo-41840: Report module-level globals as both local and global in the symtable
module (GH-22391)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
pull_requests: +21533
pull_request: https://github.com/python/cpython/pull/22528
___
Python tracker
<https://bugs.python.org/issue41
Change by Pablo Galindo Salgado :
--
pull_requests: +21534
pull_request: https://github.com/python/cpython/pull/22529
___
Python tracker
<https://bugs.python.org/issue41
Pablo Galindo Salgado added the comment:
New changeset 7b7aa94e51a396365df41f86b7b64a3b74481a6c by Pablo Galindo in
branch '3.9':
[3.9] bpo-41840: Report module-level globals as both local and global in the
symtable module (GH-22391). (GH-22528)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset fd22823991380de2a309221748fc41cf0ba6ed40 by Pablo Galindo in
branch '3.8':
[3.8] bpo-41840: Report module-level globals as both local and global in the
symtable module (GH-22391). (GH-22529)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
pull_requests: +21545
pull_request: https://github.com/python/cpython/pull/22544
___
Python tracker
<https://bugs.python.org/issue41
Change by Pablo Galindo Salgado :
--
pull_requests: +21546
pull_request: https://github.com/python/cpython/pull/22545
___
Python tracker
<https://bugs.python.org/issue41
Pablo Galindo Salgado added the comment:
You can already do:
my_counter = 0
for i in rage(1000):
my_counter += (1 if (i % 2) == 0 else 0)
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue41
Pablo Galindo Salgado added the comment:
In any case, for modifications about the Python syntax, please, open first some
debate in the python-ideas mailing list.
--
resolution: -> postponed
stage: -> resolved
status: open -> closed
_
Pablo Galindo Salgado added the comment:
Without evaluating the validity of the regex vulnerability, is important to
note that the files in Tools/scripts are not part of the standard library and
therefore they aren't a valid stack vector.
--
nosy: +pabl
Pablo Galindo Salgado added the comment:
Yeah, there is some code in PR 21748 that should be merged (the new test).
--
___
Python tracker
<https://bugs.python.org/issue41
New submission from Pablo Galindo Salgado :
For Python 3.10 now that annotations are always returned as strings, we can
drop all the unparse logic by obtaining the string in the parser directly
(after checking that the annotation is a valid expression).
--
messages: 378158
nosy
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +21579
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22587
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
nosy: +BTaskaya
___
Python tracker
<https://bugs.python.org/issue41967>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
I have attached a draft PR for this:
https://github.com/python/cpython/pull/22587
I think this may be a considerable win as the diff is +66 −1,013
--
nosy: +gvanrossum, lukasz.langa, lys.nikolaou
stage: patch review
3201 - 3300 of 4563 matches
Mail list logo