Pablo Galindo Salgado added the comment:
In any case, the underlying problem here is the fact that codeop is deciding to
continue asking for input of not depending on the repr() of the syntax error
exception itself, which is the major hack here.
Previously, it worked because for unclosed
Pablo Galindo Salgado added the comment:
> "If mode is 'repl', compile returns None to indicate that the code is
> incomplete as is but might become valid if more lines (or maybe just more
> code) were added"
That would be ideal, but my guess is that is not tri
Change by Pablo Galindo Salgado :
--
nosy: +lys.nikolaou
___
Python tracker
<https://bugs.python.org/issue43366>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
We just need to suppress the warning unless I am missing somey. Distutils will
still be used internally by CPython.
--
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
> Rather than attempting to fix this specific vulnerability, I suggest to add
> new audit events on the following gc functions:
Makes sense, I will prepare a PR today
--
___
Python tracker
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +23562
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/24794
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset b4f9089d4aa787c5b74134c98e5f0f11d9e63095 by Pablo Galindo in
branch 'master':
bpo-43439: Add audit hooks for gc functions (GH-24794)
https://github.com/python/cpython/commit/b4f9089d4aa787c5b74134c98e5f0f
Change by Pablo Galindo Salgado :
--
pull_requests: +23577
pull_request: https://github.com/python/cpython/pull/24810
___
Python tracker
<https://bugs.python.org/issue43
Change by Pablo Galindo Salgado :
--
pull_requests: +23578
pull_request: https://github.com/python/cpython/pull/24811
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
I have a suggestion (I am ok with also doing both). We should add also a flag
that allows to statically compile openssl into the extension modules (if the .a
are available) so there will be no shared object dependency. This allows us to
have
Pablo Galindo Salgado added the comment:
> OpenSSL uses dynamic linking by default.
As long as OpenSSL provide a .a file (they do) you can always static link. That
is a decision of how you integrate the library.
> Static linking is problematic for dynamic engine support.
Not sure I
Pablo Galindo Salgado added the comment:
Note that I am not proposing to statically link the extensions into the core, I
am proposing to statically link openssl into the extensions, so the symbols are
in the text segment of the extension
Pablo Galindo Salgado added the comment:
> The problem is that some features are not baked into the .a files.
Oh, I see. So when using modern versions of openssl what shared objects do we
expect to be in the NEEDED section? Right now, I see this in python3.8 in
Ubuntu with OpenSSL 1.
Pablo Galindo Salgado added the comment:
> AFAIK this won't play will with static linking.
It should not be any problem as long as we expose the SSL symbols in the
dynamic table of the extension (this happens by default). The only nuisance
would be that users will still need thos
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
nosy_count: 2.0 -> 3.0
pull_requests: +19509
pull_request: https://github.com/python/cpython/pull/20214
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset 2a561b5f6830aee39cf05dc70c24e26c3558dda0 by Pablo Galindo in
branch 'master':
bpo-37616: Handle version information more gracefully in getpath.c (GH-20214)
https://github.com/python/cpython/commit/2a561b5f6830aee39cf05dc70c24e2
Change by Pablo Galindo Salgado :
--
nosy: +aeros
___
Python tracker
<https://bugs.python.org/issue40696>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
Re-opening the issue
--
resolution: fixed ->
status: closed -> open
___
Python tracker
<https://bugs.python.org/i
Pablo Galindo Salgado added the comment:
Maybe we should revert
--
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
Removed message: https://bugs.python.org/msg369463
___
Python tracker
<https://bugs.python.org/issue40217>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
Maybe we should revert this change and modify the "how to port to ..." section
as we did in bpo-35810 to tell users that they need to manually visit the
parent in classes created with PyTyp
Change by Pablo Galindo Salgado :
--
pull_requests: +19550
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/20264
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
nosy: +gvanrossum, lys.nikolaou, pablogsal
___
Python tracker
<https://bugs.python.org/issue40715>
___
___
Python-bugs-list m
Pablo Galindo Salgado added the comment:
Actually, I have been thinking about this more and I cannot really trace how
the bug could happen. We control the type allocation, but Py_tp_alloc controls
the instance allocation and that can be anything, the current patch should not
interfere with
Pablo Galindo Salgado added the comment:
New changeset f50516e6a978ee694232512399dd1ab47aaebab1 by Batuhan Taskaya in
branch 'master':
bpo-40334: Correctly generate C parser when assigned var is None (GH-20296)
https://github.com/python/cpython/commit/f50516e6a978ee694232512399dd1a
Pablo Galindo Salgado added the comment:
New changeset 72e0aa2fd2b9c6da2caa5a9ef54f6495fc2890b0 by Batuhan Taskaya in
branch 'master':
bpo-40176: Improve error messages for trailing comma on from import (GH-20294)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
pull_requests: +19573
pull_request: https://github.com/python/cpython/pull/20302
___
Python tracker
<https://bugs.python.org/issue40
Change by Pablo Galindo Salgado :
--
pull_requests: +19575
pull_request: https://github.com/python/cpython/pull/20302
___
Python tracker
<https://bugs.python.org/issue40
Change by Pablo Galindo Salgado :
--
pull_requests: -19573
___
Python tracker
<https://bugs.python.org/issue40176>
___
___
Python-bugs-list mailing list
Unsub
Change by Pablo Galindo Salgado :
--
pull_requests: +19576
pull_request: https://github.com/python/cpython/pull/20302
___
Python tracker
<https://bugs.python.org/issue40
Pablo Galindo Salgado added the comment:
New changeset 275d7e1080d0007a82965d1ac510abb0ae8d7821 by Pablo Galindo in
branch '3.9':
[3.9] bpo-40176: Improve error messages for trailing comma on from import
(GH-20294) (GH-20302)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
pull_requests: -19576
___
Python tracker
<https://bugs.python.org/issue40176>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
New changeset b8a65ec1d3d4660d0ee38a9765d98f5cdcabdef5 by Batuhan Taskaya in
branch 'master':
bpo-40715: Reject dict unpacking on dict comprehensions (GH-20292)
https://github.com/python/cpython/commit/b8a65ec1d3d4660d0ee38a9765d98f
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset ae145833025b0156ee2a28219e3370f3b27b2a36 by Lysandros Nikolaou in
branch 'master':
bpo-40334: Produce better error messages for non-parenthesized genexps
(GH-20153)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
This is expected behaviour and happens because we need to clean the exception
variable outside the `except` block to avoid reference cycles. If you need the
variable later, you need to do an assignment:
try:
1/0
except Exception as exc
Pablo Galindo Salgado added the comment:
This is the equivalent construct that we compile it to:
https://github.com/python/cpython/blob/master/Python/compile.c#L3102-L3110
--
___
Python tracker
<https://bugs.python.org/issue40
Change by Pablo Galindo Salgado :
--
nosy: +Mark.Shannon
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
>But then why I still can access this variable? Shouldn't it then be
resulting in NameError as it's undefined variable at this point of time?
I don't think so, this is the same as if you do:
def f(exc):
del exc
return exc
Pablo Galindo Salgado added the comment:
> as it's either the
variable should exist and have a value or it should be unknown and result
in NameError at this point.
One thing is the symbol and another thing is its value. The function is always
aware of the existence of the sym
Pablo Galindo Salgado added the comment:
> but if exc variable is only available in except block why then it shadows
the function variable name?
Because the except block does not create a new scope and therefore when you do
'except as x' it does an assignment to x in the same
Change by Pablo Galindo Salgado :
--
nosy: +christian.heimes
___
Python tracker
<https://bugs.python.org/issue40728>
___
___
Python-bugs-list mailing list
Unsub
Change by Pablo Galindo Salgado :
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue40726>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
> What would be the downsides of reverting and documenting that tp_traverse
> must visit Py_TYPE(self)?
Not much IMHO, I actually would prefer this solution over any automatic
"hacks". The reason is that any hack will be technical
Pablo Galindo Salgado added the comment:
I don't think the examples you mention is proof of inconsistent behaviour:
> * list expressions do have their scope and do not overwrite local variables
comprehensions have their own scope in Python 3 and this is documented. General
bloc
Pablo Galindo Salgado added the comment:
New changeset 43300148c5f30317ebf767aa8853a957ee5c87fb by Batuhan Taskaya in
branch '3.7':
[3.7] bpo-40663: Correctly handle annotations with subscripts in ast_unparse.c
(GH-20156). (GH-20192)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset a4d219b35e35f9efc406cd70f2812275bcd989fe by Batuhan Taskaya in
branch '3.8':
[3.8] bpo-40663: Correctly handle annotations with subscripts in ast_unparse.c
(GH-20156). (GH-20191)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
I have been playing with the reproducer and I am a bit confused: The reproducer
crashes in the same way even after reverting PR 19414 so it does not seem
related to it. This is what I get:
>>> import reproducer
>>> reproducer.Modu
Pablo Galindo Salgado added the comment:
Ok, I found the problem. The problem is that the reproduced does not correctly
work the reference count of base_class because when construction get tuple of
bases:
PyObject *bases = PyTuple_New(1);
result = PyTuple_SetItem(bases, 0, base_class);
if
Pablo Galindo Salgado added the comment:
Closing as we have a new parser in 3.9 and the current one will be removed in
Python 3.10.
--
resolution: -> rejected
stage: patch review -> resolved
status: open -> closed
___
Python tracke
Pablo Galindo Salgado added the comment:
> If you add a Py_INCREF before, the crash disappears.
To be clear: the other crash is still in the reproduced: the one that Petr
describes in his comment. In PR 20264 I have prepared the changes that I
proposed previously (including the revert
New submission from Pablo Galindo Salgado :
Python has a (mostly unknown) -d flag that can only be used in debug builds
that emit some debug output for the old parser. The new parser does not support
such flag. This is very useful when playing with the grammar as it helps
enormously to
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +19608
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/20340
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
A piece of the output for the string "1 + 1" with PR 20340:
> star_expressions[0-0]: star_expression ','
✗ star_expressions[0-0]: star_expression ',' failed!
> star_expressions[0-0]: star_expr
Change by Pablo Galindo Salgado :
--
nosy: +gvanrossum, lys.nikolaou
___
Python tracker
<https://bugs.python.org/issue40750>
___
___
Python-bugs-list mailin
Pablo Galindo Salgado added the comment:
New changeset c73914a562580ae72048876cb42ed8e76e2c83f9 by Rémi Lapeyre in
branch 'master':
bpo-36290: Fix keytword collision handling in AST node constructors (GH-12382)
https://github.com/python/cpython/commit/c73914a562580ae72048876cb42ed8
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset cba503151056b448b7a3730dc36ef660ade5 by Batuhan Taskaya in
branch 'master':
bpo-40334: Support suppressing of multiple optional variables in Pegen
(GH-20367)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 800a35c623bbcdb5793c7d7a4974524286311479 by Pablo Galindo in
branch 'master':
bpo-40750: Support -d flag in the new parser (GH-20340)
https://github.com/python/cpython/commit/800a35c623bbcdb5793c7d7a497452
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
pull_requests: +19656
pull_request: https://github.com/python/cpython/pull/20393
___
Python tracker
<https://bugs.python.org/issue40
Pablo Galindo Salgado added the comment:
New changeset deb4355a37e41edf1199920789fe9572c1fb43c2 by Pablo Galindo in
branch 'master':
bpo-40750: Do not expand the new parser debug flags if Py_BUILD_CORE is not
defined (GH-20393)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 9645930b5bc1833ef495891d22052d1ba65ab7ea by Lysandros Nikolaou in
branch 'master':
bpo-40688: Use the correct parser in the peg_generator scripts (GH-20235)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 6cb0ad20396116b5076a58b05b55286d6d5e0c94 by Lysandros Nikolaou in
branch '3.9':
bpo-40246: Fix test_fstring when run with the old parser (GH-20402)
https://github.com/python/cpython/commit/6cb0ad20396116b5076a58b05b5528
Pablo Galindo Salgado added the comment:
New changeset f7b1e461567e5e3fa3ba46f589d9edc1b45b2dd0 by Lysandros Nikolaou in
branch 'master':
bpo-38964: Print correct filename on a SyntaxError in an fstring (GH-20399)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 791a46ed58f74d673cf2c0d81deec57155bf7583 by Lysandros Nikolaou in
branch '3.9':
[3.9] bpo-38964: Print correct filename on a SyntaxError in an fstring
(GH-20399) (GH-20404)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
Please, don't remove these as I use them often to track down memory usage in a
similar way as Inada-san.
--
___
Python tracker
<https://bugs.python.org/is
New submission from Pablo Galindo Salgado :
https://buildbot.python.org/all/#/builders/394/builds/94
..
test_interpreters leaked [216, 216, 216] references, sum=648
test_interpreters leaked [84, 84, 84] memory blocks, sum=252
1 test failed again:
test_interpreters
Change by Pablo Galindo Salgado :
--
assignee: -> nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue40783>
___
___
Python-bugs-list mai
Pablo Galindo Salgado added the comment:
Ok, closing as duplicate although I prefer to track the leaks in different
issues for organizational pourposes.
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
___
Pytho
Change by Pablo Galindo Salgado :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset c116c94ff119485761460f1033cdee425bed0310 by Shantanu in branch
'master':
bpo-40614: Respect feature version for f-string debug expressions (GH-20196)
https://github.com/python/cpython/commit/c116c94ff119485761460f1033cdee
Change by Pablo Galindo Salgado :
--
pull_requests: +19716
pull_request: https://github.com/python/cpython/pull/20464
___
Python tracker
<https://bugs.python.org/issue40
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
nosy_count: 13.0 -> 14.0
pull_requests: +19717
pull_request: https://github.com/python/cpython/pull/20465
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Commit 9d17cbf33df7cfb67ca0f37f6463ba5c18676641 is causing all refleak
buildbots to fail and is masking other issues and causing some confusion
already in other PRs (like https://github.com/python/cpython/pull/20433) so I
opened a revert in PR 20465
Pablo Galindo Salgado added the comment:
New changeset 9b83829e7d476acecc86d48978acc5813ec51e65 by Pablo Galindo in
branch '3.9':
[3.9] bpo-40614: Respect feature version for f-string debug expressions
(GH-20196) (GH-20464)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
We have a bunch of buildbots that test the installed Python. For instance, if
you search for "installed" in
https://buildbot.python.org/all/#/builders?tags=%2B3.x we have:
aarch64 Fedora Rawhide Clang Installed 3.x
aarch64 Fedora St
Pablo Galindo Salgado added the comment:
Any suggestions for the new module? I assume we can move this to a new
topsort/topological_sort or similar...
What do people think?
--
___
Python tracker
<https://bugs.python.org/issue17
Pablo Galindo Salgado added the comment:
> Can you update the current status?
Sorry, what do you mean by "current status"? Do you meant this issue or the
status of that PR?
--
___
Python tracker
<https://bugs.pytho
Pablo Galindo Salgado added the comment:
If we move it, I would prefer a new module that somehow makes clear the scope,
something like graphutils or graphtheory or graph (although this las one will
probably collide with many existing things
Pablo Galindo Salgado added the comment:
> The downside I see with any graph prefixed names is the fact that it implies
> a larger collection of graph operations.
I don't see that an issue. In the general term is better to have a general name
and discuss further improvements tha
Pablo Galindo Salgado added the comment:
I would like to hear Raymond and Tim advise on what the best name for the new
module should be :)
--
___
Python tracker
<https://bugs.python.org/issue17
Pablo Galindo Salgado added the comment:
I checked and from the list of proposed names with "graph" prefixes, only
"graphutils" is not colliding with something on Pypi.
For the record "cslib" and "misclib" are also available but the scope of those
fe
Change by Pablo Galindo Salgado :
--
pull_requests: +19801
pull_request: https://github.com/python/cpython/pull/20558
___
Python tracker
<https://bugs.python.org/issue17
Pablo Galindo Salgado added the comment:
Opened https://github.com/python/cpython/pull/20558. I have *initially*
proposed "graphlib" as it feels more in-line with other stdlib module names and
as Jim pointed it does not collide with anything major. Also, I have proposed
this initi
Pablo Galindo Salgado added the comment:
New changeset 2f172d8f1525defe9bba4d49e967fdfc69151731 by Pablo Galindo in
branch 'master':
bpo-17005: Move topological sort functionality to its own module (GH-20558)
https://github.com/python/cpython/commit/2f172d8f1525defe9bba4d49e967fd
Pablo Galindo Salgado added the comment:
> 1. GH-20342 solved this issue?
As far as I understand, yes. Although I did not check if all the warnings here
are solved in that PR, as the PR eliminates all the ones that we found, it
should be resolved.
I think we can close this issue
>
Pablo Galindo Salgado added the comment:
Yeah, this is not a bug as Serhiy points out. Regarding the error message, we
are currently working on trying to unify the error messages in the the parser
as much as we can but there is also no promise that they will match 100%.
Many grammar checks
Change by Pablo Galindo Salgado :
--
nosy: +gvanrossum, lys.nikolaou
___
Python tracker
<https://bugs.python.org/issue40847>
___
___
Python-bugs-list mailin
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +19883
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/20666
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +19884
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/20667
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset 2e6593db0086004a1ca7f7049218ff9573d473c2 by Pablo Galindo in
branch 'master':
bpo-40880: Fix invalid read in newline_in_string in pegen.c (#20666)
https://github.com/python/cpython/commit/2e6593db0086004a1ca7f7049218ff
Pablo Galindo Salgado added the comment:
New changeset a54096e30523534e8eebb8dc1011b4536ed237a8 by Pablo Galindo in
branch 'master':
bpo-40883: Fix memory leak in fstring_compile_expr in parse_string.c (GH-20667)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset f7ed4d4e83f5d9e85e244a1cbc460f26436ab24d by Shantanu in branch
'3.8':
bpo-40614: Respect feature version for f-string debug expressions (GH-20196)
(GH-20466)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
2901 - 3000 of 4563 matches
Mail list logo