Pablo Galindo Salgado added the comment:
> (Huh, where did it get __new_parser__?)
>From here:
https://github.com/python/cpython/blob/master/Parser/pegen/parse.c#L67
--
___
Python tracker
<https://bugs.python.org/i
Change by Pablo Galindo Salgado :
--
resolution: -> rejected
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset a15c9b3a0524e5ca0434d2ad11076677824af941 by Lysandros Nikolaou in
branch 'master':
bpo-40334: Always show the caret on SyntaxErrors (GH-20050)
https://github.com/python/cpython/commit/a15c9b3a0524e5ca0434d2ad110766
Change by Pablo Galindo Salgado :
--
pull_requests: +19382
pull_request: https://github.com/python/cpython/pull/20076
___
Python tracker
<https://bugs.python.org/issue40
Pablo Galindo Salgado added the comment:
Thanks for the issue and the PR @hauntsaninja. Unfortunately, I think this is
already covered by #20083 and https://bugs.python.org/issue40618
--
nosy: +pablogsal
___
Python tracker
<ht
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +19395
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/20090
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset bcc30360951a303aa72b0502b77aad2c5f09f30d by Pablo Galindo in
branch 'master':
bpo-40619: Correctly handle error lines in programs without file mode (GH-20090)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
resolution: -> duplicate
stage: patch review -> resolved
status: open -> closed
superseder: -> PEG Parser: Invalid targets for augassign and except succeed
___
Python tracker
<https://
Pablo Galindo Salgado added the comment:
New changeset ce21cfca7bb2d18921bc4ac27cb064726996c519 by Lysandros Nikolaou in
branch 'master':
bpo-40618: Disallow invalid targets in augassign and except clauses (GH-20083)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 16ab07063cb564c1937714bd39d6915172f005b5 by Pablo Galindo in
branch 'master':
bpo-40334: Correctly identify invalid target in assignment errors (GH-20076)
https://github.com/python/cpython/commit/16ab07063cb564c1937714bd39d691
Pablo Galindo Salgado added the comment:
New changeset ce4a753dcb3eef3d68e892a6515490b1aa219651 by Batuhan Taskaya in
branch 'master':
bpo-38870: Do not separate factor prefixes in ast.unparse (GH-20133)
https://github.com/python/cpython/commit/ce4a753dcb3eef3d68e892a6515490
Pablo Galindo Salgado added the comment:
New changeset 25160cdc4775a1ddb4e37c8bf5a6e31ad9c146ed by Batuhan Taskaya in
branch 'master':
bpo-38870: Don't put unnecessary parentheses on class declarations in ast.parse
(GH-20134)
https://github.com/python
Pablo Galindo Salgado added the comment:
New changeset 31245d19f2de03e57fd93c5169f00a36d7410fcf by Batuhan Taskaya in
branch 'master':
bpo-39740: Early declare devpoll_methods to support old compilers (GH-19281)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset cae2275949157490b469d79ef250387eca324b9e by Batuhan Taskaya in
branch 'master':
bpo-40211: Clarify os.preadv and os.pwritev are supported on AIX 7.1+ (GH-19401)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset d5a980a60790571ec88aba4e011c91e099e31e98 by Batuhan Taskaya in
branch 'master':
bpo-40165: Suppress stderr when checking if test_stty_match should be skipped
(GH-19325)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset e966af7cff78e14e1d289db587433504b4b53533 by Batuhan Taskaya in
branch 'master':
bpo-38870: Correctly handle empty docstrings in ast.unparse (GH-18768)
https://github.com/python/cpython/commit/e966af7cff78e14e1d289db5874335
Pablo Galindo Salgado added the comment:
New changeset dff92bb31f7db1a80ac431811f8108bd0ef9be43 by Batuhan Taskaya in
branch 'master':
bpo-38870: Implement round tripping support for typed AST in ast.unparse
(GH-17797)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
pull_requests: +19446
pull_request: https://github.com/python/cpython/pull/20141
___
Python tracker
<https://bugs.python.org/issue38
Pablo Galindo Salgado added the comment:
New changeset 6341fc7257d89d798675ad6e425f7eb0b6f2b4bb by Pablo Galindo in
branch 'master':
bpo-38870: Use subTest in test_unparse for better error reporting (GH-20141)
https://github.com/python/cpython/commit/6341fc7257d89d798675ad6e425f7e
Pablo Galindo Salgado added the comment:
New changeset 2c8cd06afe8e0abb52367f85978f19b88e2df53e by Lysandros Nikolaou in
branch 'master':
bpo-40334: Improvements to error-handling code in the PEG parser (GH-20003)
https://github.com/python/cpyt
New submission from Pablo Galindo Salgado :
The new peg parser segfaults when parsing the attached reproducer.
this is due to the fact that the exception set by `tokenizer_error` is not
properly propagated.
--
components: Interpreter Core
files: reproducer.py
messages: 369132
nosy
Pablo Galindo Salgado added the comment:
I think we may need to test for the error indicator (and maybe PyErr_Ocurred
for safety) before every alternative. Something like:
diff --git a/Tools/peg_generator/pegen/c_generator.py
b/Tools/peg_generator/pegen/c_generator.py
index 8f9972bb41
Pablo Galindo Salgado added the comment:
Indeed, that diff solves the problem
--
___
Python tracker
<https://bugs.python.org/issue40661>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
A quick benchmark using xxl.py:
Base time (master):
Time: 9.386 seconds on an average of 20 runs
With the patch in this issue:
Time: 9.498 seconds on an average of 20 runs
Sadly I could not test with PGO/LTO and without CPU isolation, so it would be
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 7b7a21bc4fd063b26a2d1882fddc458861497812 by Lysandros Nikolaou in
branch 'master':
bpo-40661: Fix segfault when parsing invalid input (GH-20165)
https://github.com/python/cpython/commit/7b7a21bc4fd063b26a2d1882fddc45
Pablo Galindo Salgado added the comment:
New changeset 63b8e0cba3d43e53a8dd8878ee1443c8427f462d by Batuhan Taskaya in
branch 'master':
bpo-40528: Improve AST generation script to do builds simultaneously (GH-19968)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
keywords: +3.9regression -patch
___
Python tracker
<https://bugs.python.org/issue40662>
___
___
Python-bugs-list mailin
Pablo Galindo Salgado added the comment:
New changeset e6578a226d8a8a13d1062d154fad0fef28ee2416 by Irit Katriel in
branch 'master':
bpo-40662: Fixed ast.get_source_segment for ast nodes that have incomplete
location information (GH-20157)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 2135e10dc717c00d10d899d232bebfc59bb25032 by Batuhan Taskaya in
branch 'master':
bpo-40663: Correctly handle annotations with subscripts in ast_unparse.c
(GH-20156)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset d71a6492dbd5434dfa6a0ad95e3ad98aa690887a by CyberSaxosTiGER in
branch 'master':
bpo-38870: correctly escape unprintable characters on ast.unparse (GH-20166)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 75b863aa97016c6813709eb620c43295f84dd51f by Lysandros Nikolaou in
branch 'master':
bpo-40334: Reproduce error message for type comments on bare '*' in the new
parser (GH-20151)
https://github.com/p
Pablo Galindo Salgado added the comment:
New changeset c102a148256b00b7d48c51a1a97df19042e603de by Batuhan Taskaya in
branch 'master':
bpo-38870: Don't omit parenthesis when unparsing a slice in ast.unparse
https://github.com/python/cpython/commit/c102a148256b00b7d48c51a1a
Change by Pablo Galindo Salgado :
--
pull_requests: +19495
pull_request: https://github.com/python/cpython/pull/20194
___
Python tracker
<https://bugs.python.org/issue40
Pablo Galindo Salgado added the comment:
New changeset 3764069f3ba2a7e932837ae19265059339dc86e3 by Pablo Galindo in
branch 'master':
bpo-40669: Use requirements.pip when installing PEG dependencies (GH-20194)
https://github.com/python/cpython/commit/3764069f3ba2a7e932837ae1926505
Pablo Galindo Salgado added the comment:
> I thought about using code.__hash__ in the first place, but the compiler's
> underlying store system (both compiler_unit->u_consts and
> compiler->c_const_cache) uses dictionary's where the keys are constant
> objects
Pablo Galindo Salgado added the comment:
New changeset bcc9579227578de5dd7f8825d24ba51b618ad3c2 by James Gerity in
branch 'master':
bpo-42485: [Doc] Link to PEP 617 from full grammar specification (GH-23532)
https://github.com/python/cpython/commit/bcc9579227578de5dd7f8825d24ba5
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
I cannot reproduce it either in 3.9. Building 3.9 in debug mode and using -d
works as expected
--
___
Python tracker
<https://bugs.python.org/issue42
Pablo Galindo Salgado added the comment:
Also, note the -d flag activates the debug mode **in the parser**, not in the
tokenizer.
--
___
Python tracker
<https://bugs.python.org/issue42
Change by Pablo Galindo Salgado :
--
pull_requests: +22474
pull_request: https://github.com/python/cpython/pull/23606
___
Python tracker
<https://bugs.python.org/issue40
Pablo Galindo Salgado added the comment:
Seems that commit 1ed83adb0e95305af858bd41af531e487f54fee7 was deleting some
functions that were not correctly covered by redirection macros. I have opened
PR 23606 to restore those as they were
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +22475
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23607
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
pull_requests: +22476
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/23608
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
https://buildbot.python.org/all/#/builders/526/builds/3
--
___
Python tracker
<https://bugs.python.org/issue41
Pablo Galindo Salgado added the comment:
Started custom build of PR 23608 in
https://buildbot.python.org/all/#/buildrequests/84365
--
___
Python tracker
<https://bugs.python.org/issue41
Pablo Galindo Salgado added the comment:
Seems that adding #include does not work so I am going to skip
adding this function on AIX. If someone is interested in fixing it, they can
remove the #ifdef and figure out what's going on with that bui
Pablo Galindo Salgado added the comment:
New changeset 46bd5ed94cf3d5e03f45eecf9afea1659980c8bf by Pablo Galindo in
branch 'master':
bpo-40939: Restore some stable API functions incorrectly deleted (GH-23606)
https://github.com/python/cpython/commit/46bd5ed94cf3d5e03f45eecf9afea1
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
I am currently working on test that checks that the stable API symbols are
correctly exported. Unfortunately there is no official maintained list if those
symbols, so is taking a while
--
___
Python
Pablo Galindo Salgado added the comment:
> On Windows there is PC/python3dll.c.
Even that is severely out of date, unfortunately. There are many functions that
were removed in 3.8 and 3.7 that are still listed there.
--
___
Python tracker
<
Pablo Galindo Salgado added the comment:
New changeset 99b594404d364b363c184f48338d6ee81bee26dd by Pablo Galindo in
branch 'master':
bpo-42521: Add note about 'Python -d' only working on debug builds (GH-23607)
https://github.com/python/cpython/commit/99b594404d364b363c18
Pablo Galindo Salgado added the comment:
New changeset dedc2cd5f02a2e2fc2c995a36a3dccf9d93856bb by Pablo Galindo in
branch 'master':
bpo-41625: Do not add os.splice on AIX due to compatibility issues (GH-23608)
https://github.com/python/cpython/commit/dedc2cd5f02a2e2fc2c995a36a3dcc
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Pablo Galindo Salgado :
>From the discussion at the end of https://bugs.python.org/issue40939 is
>important to add a check to the CI that can tell us if we mistakenly remove a
>symbol of the limited ABI.
--
components: Tests
messages: 382336
nosy:
Pablo Galindo Salgado added the comment:
Opened https://bugs.python.org/issue42545 for that
--
___
Python tracker
<https://bugs.python.org/issue40939>
___
___
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +22484
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23616
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/issue42545>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
I added some comments in the PR regarding the possibility of forcing the
tracking on the visiting function to redirect the cost to gc passes instead of
when calling next() but there is another option: not untracking tuples that
have refcount == 1
Pablo Galindo Salgado added the comment:
> not untracking tuples that have refcount == 1.
Actually, this may not be a good idea as well: running test_list shows that
there are 14786 tuples with refcount == 1 that would have been untracked. This
is a non-trivial workload to the gc pas
Pablo Galindo Salgado added the comment:
> The GC visit may happen when the refcount of the result tuple is > 1, but it
> may drop back to 1 before __next__ called again
Good point. Also, is it possible that a more complex cycle ends having more
than one reference to that result,
Pablo Galindo Salgado added the comment:
> Or, if z's refcount drops to zero and it's cleaned up, its traverse function
> may *never* be called, which leaves the untracked r -> o -> r cycle.
This is a real problem, indeed. We would need to add the tracking to the
Pablo Galindo Salgado added the comment:
I forgot to mention the conclusion: my conclusion is that although the GC is
resilient to these shenanigans (it was also extensive validation along with the
algorithm), I still prefer to track it on the next() call because is
technically the right
Pablo Galindo Salgado added the comment:
> I'll merge it and move on to similar PRs for the other affected stuff:
Not sure if is more ergonomic, but I would prefer to fix this in one PR so the
buildbots don't test the partial fixes. Also is easier to revert if something
goes w
Pablo Galindo Salgado added the comment:
New changeset 85f1dedb8d05774e0d3739be0a11cd970b98097f by Pablo Galindo in
branch 'master':
bpo-42545: Check that all symbols in the limited ABI are exported (GH-23616)
https://github.com/python/cpython/commit/85f1dedb8d05774e0d3739be0a11cd
Pablo Galindo Salgado added the comment:
I want to make some tweaks to the script, so I will leave this open
--
___
Python tracker
<https://bugs.python.org/issue42
Change by Pablo Galindo Salgado :
--
pull_requests: +22516
pull_request: https://github.com/python/cpython/pull/23648
___
Python tracker
<https://bugs.python.org/issue42
Pablo Galindo Salgado added the comment:
New changeset 79c1849b9e5b635bd36b13e1be9dc7cbc2bd6312 by Pablo Galindo in
branch 'master':
bpo-42545: Improve the error message in the stable API script (GH-23648)
https://github.com/python/cpython/commit/79c1849b9e5b635bd36b13e1be9dc7
Pablo Galindo Salgado added the comment:
I am a bit confusedwhy is this failing now?
--
___
Python tracker
<https://bugs.python.org/issue42574>
___
___
Pytho
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset b63a620014b67a6e63d10783149c41baaf59def8 by Matěj Cepl in branch
'master':
bpo-42579: Make workaround for various versions of Sphinx more robust (GH-23662)
https://github.com/python/cpython/commit/b63a620014b67a6e63d10783149c41
Pablo Galindo Salgado added the comment:
New changeset 60463e8e4f79e5b5e96dc43fb83ded373b489e33 by Brandt Bucher in
branch '3.9':
bpo-42536: GC track recycled tuples (GH-23623) (GH-23651)
https://github.com/python/cpython/commit/60463e8e4f79e5b5e96dc43fb83ded
Pablo Galindo Salgado added the comment:
New changeset 7c797982383ebfd9cca39c480dcf6132979dd06f by Brandt Bucher in
branch '3.8':
bpo-42536: GC track recycled tuples (GH-23623) (GH-23652)
https://github.com/python/cpython/commit/7c797982383ebfd9cca39c480dcf61
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
I would suggest to use some other string formatting for that one line. The
reason is that technically (although very unlikely) downstream consumers could
be relying on some old PYTHON_FOR_REGEN in the Makefile for 3.8 and I would not
like to change
Change by Pablo Galindo Salgado :
--
pull_requests: +22548
pull_request: https://github.com/python/cpython/pull/23685
___
Python tracker
<https://bugs.python.org/issue42
Pablo Galindo Salgado added the comment:
New changeset b6d6f5367da1f2e3f749c358ae8563c56a0cc395 by Pablo Galindo in
branch '3.8':
bpo-42574: Use format() instead of f-string in Tools/clinic/clinic.py to allow
using older Python versions (GH-23685)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
+1 for the `=` sign
--
___
Python tracker
<https://bugs.python.org/issue30858>
___
___
Python-bugs-list mailin
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +22610
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23753
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset 43c4fb6c90c013a00cb820cb61e4990cd8ec7f5e by Pablo Galindo in
branch 'master':
bpo-30858: Improve error location for expressions with assignments (GH-23753)
https://github.com/python/cpython/commit/43c4fb6c90c013a00cb820cb61e499
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
I concur, handling also multi-line constructs is tricky and I would prefer not
to implement some hack for specific situations because my experience is that
balancing that with other things Is tricky. As Lysandros mentioned, the parser
reports
Pablo Galindo Salgado added the comment:
> pidigits and regex_v8 are LOAD_ATTR heavy benchmarks?
The PR is for LOAD_METHOD infrastructure, not for LOAD_ATTR (There was an
incorrect title in the PR that I corrected but the contents are correct).
> I will run benchmarks in my mach
Pablo Galindo Salgado added the comment:
Oh, I am quite confused about what's going on with pidigits and regex_v8. I
will try to run the benchmarks again. Did you compare the current master
against the PR? If that's the case we should rebase the PR it first to make
sure we are co
Pablo Galindo Salgado added the comment:
OK, I have repeated the benchmarks after rebasing and this is what I get:
venv ❯ python -m pyperf compare_to
json/2020-12-16_11-20-master-8203c73f3bb1.json.gz
json/2020-12-16_11-22-load_method-21b1566125b3.json.gz -G --min-speed=1
Slower (13
Pablo Galindo Salgado added the comment:
I think I am closing the PR as it seems that the gains are not good enough (and
there is quite a lot of noise by comparing the benchmarks together).
--
___
Python tracker
<https://bugs.python.
Pablo Galindo Salgado added the comment:
> IMO you need to implement LOAD_METHOD support for all kinds of calls,
> including the ones that use kwargs, to see any improvement.
I will try to do some prototyping around that to see how much can we gain in
that route. In any case,
Pablo Galindo Salgado added the comment:
New changeset 84ebcf271a2cc8bfd1762acb279502b8b6ef236e by Matt Wozniski in
branch 'master':
bpo-17140: Document multiprocessing's ThreadPool (GH-23812)
https://github.com/python/cpython/commit/84ebcf271a2cc8bfd1762acb279502b8b6ef236e
Pablo Galindo Salgado added the comment:
https://github.com/python/python-docs-theme/pull/57 is landed. We just need a
new release of the package to pypi
--
___
Python tracker
<https://bugs.python.org/issue42
Pablo Galindo Salgado added the comment:
New changeset a44ce6c9f725d336aea51a946b42769f29fed613 by Matti Picus in branch
'master':
bpo-42604: always set EXT_SUFFIX=${SOABI}${SHLIB_SUFFIX} when using configure
(GH-23708)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 4b155967b3e743cbdc31600f13f1bfcf07f7b6ce by Miss Islington (bot)
in branch '3.9':
bpo-42604: always set EXT_SUFFIX=${SOABI}${SHLIB_SUFFIX} when using configure
(GH-23708) (GH-23866)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
Thanks for the PR, mattip!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
Raising this to a release blocker
--
priority: normal -> release blocker
versions: +Python 3.10, Python 3.9
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
The symptom is that we are now trying to free something in the small integer
cache that we shouldn't. Running this under the address sanitizer shows a bit
more of the problem:
==190303==ERROR: AddressSanitizer: attempting free on address whic
Pablo Galindo Salgado added the comment:
Indeed. The module in the std lib is actually different:
https://github.com/python/cpython/blob/master/Modules/_zoneinfo.c#L570-L589
and uses _PyLong_GetOne() instead of _PyLong_One
--
___
Python tracker
Pablo Galindo Salgado added the comment:
The version in 3.9 is also different but also uses _PyLong_One:
https://github.com/python/cpython/blob/3.9/Modules/_zoneinfo.c#L571-L590
Although that is passed directly to PyDict_SetItemString so the refcount should
be correct
2601 - 2700 of 4563 matches
Mail list logo
