[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > GCC warning on aarch64 Fedora Rawhide LTO + PGO 3.x buildbot: Is this related to this issue? We didn't change that line -- ___ Python tracker <https://bugs.python.org

[issue40370] AIX: ld_so_aix not found during test of test_peg_generator

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Tested on an AIX system: [pablo@ibm_machine cpython (master)]$ uname -a AIX ibm_machine 1 7 *** powerpc AIX [pablo@ibm1 cpython (master)]$ ./python -m test test_peg_generator 0:00:00 Run tests sequentially 0:00:00 [1/1] test_peg_generator

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > I don't know. It's just that I spotted this compiler warnining while > reviewing recent buildbot failures. Given that is a compiler warning and we didn't change those lines, I would say is n

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset ebebb6429c224c713e1c63a0b05d4840f52c7415 by Lysandros Nikolaou in branch 'master': bpo-40334: Improve various PEG-Parser related stuff (GH-19669) https://github.com/python/cpython/commit/ebebb6429c224c713e1c63a0b05d48

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > ImportError: cannot import name 'Final' Currently, you need Python3.8+ to do 'make regen-pegen'. We can try to modify the module to not use newer features like "Final&q

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > oduleNotFoundError: No module named 'distutils.tests' Oh, are you using a python distribution that strips distutils? Is this Debian or Ubuntu? I suppose we need to account for that. I will create a PR for trying to address bot

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: "That's for pointing that out" -> "Thanks for pointing that out" -- ___ Python tracker <htt

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +19004 pull_request: https://github.com/python/cpython/pull/19684 ___ Python tracker <https://bugs.python.org/issue40

[issue40334] PEP 617: new PEG-based parser

2020-04-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 50f28dea32c45e1a49b3bd07c874b4fa837a5e88 by Pablo Galindo in branch 'master': bpo-40334: Allow to run make regen-pegen without distutils (GH-19684) https://github.com/python/cpython/commit/50f28dea32c45e1a49b3bd07c874b4

[issue40334] PEP 617: new PEG-based parser

2020-04-24 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 24ffe705c30e36c82940d75fd1454256634d0b3c by Lysandros Nikolaou in branch 'master': bpo-40334: Rewrite test_c_parser to avoid memory leaks (GH-19694) https://github.com/python/cpython/commit/24ffe705c30e36c82940d75fd14542

[issue40335] Regression in multiline SyntaxError offsets

2020-04-24 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: This is likely due to the new parser (see PEP 617). Do you get the same problem running with -X oldparser ? -- ___ Python tracker <https://bugs.python.org/issue40

[issue40335] Regression in multiline SyntaxError offsets

2020-04-24 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Hu.actually, no. This is something else... -- ___ Python tracker <https://bugs.python.org/issue40335> ___ ___

[issue40335] Regression in multiline SyntaxError offsets

2020-04-24 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- Removed message: https://bugs.python.org/msg367225 ___ Python tracker <https://bugs.python.org/issue40335> ___ ___ Python-bug

[issue40335] Regression in multiline SyntaxError offsets

2020-04-24 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Yeah, I can confirm after bisecting that the commit that introduced the regression is the new parser: c5fc15685202cda73f7c3f5c6f299b0945f58508 is the first bad commit commit c5fc15685202cda73f7c3f5c6f299b0945f58508 Author: Pablo Galindo Date: Wed

[issue40335] Regression in multiline SyntaxError offsets

2020-04-24 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: With the old parser it works: ~/github/python/master master* ❯ ./python -X oldparser t.py 3.9.0a5+ (heads/master:503de7149d, Apr 24 2020, 22:02:28) [GCC 9.3.0] SyntaxError: - line: 8 - offset: 8 - text: "'''\n\ndef bar():\n

[issue40335] Regression in multiline SyntaxError offsets

2020-04-24 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: And the regression happens because we are ignoring that test currently due to the new parser not currently reporting the same offsets: https://github.com/python/cpython/blob/master/Lib/test/test_exceptions.py#L181

[issue40335] Regression in multiline SyntaxError offsets

2020-04-24 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > pyflakes's testsuite has many failures under the new parser Can you report this also on the PEP 617 issue? -- ___ Python tracker <https://bugs.python.org

[issue40334] PEP 617: new PEG-based parser

2020-04-26 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +19043 pull_request: https://github.com/python/cpython/pull/19721 ___ Python tracker <https://bugs.python.org/issue40

[issue40334] PEP 617: new PEG-based parser

2020-04-26 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +19045 pull_request: https://github.com/python/cpython/pull/19723 ___ Python tracker <https://bugs.python.org/issue40

[issue40217] The garbage collector doesn't take in account that objects of heap allocated types hold a strong reference to their type

2020-04-27 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +19054 pull_request: https://github.com/python/cpython/pull/19733 ___ Python tracker <https://bugs.python.org/issue40

[issue40217] The garbage collector doesn't take in account that objects of heap allocated types hold a strong reference to their type

2020-04-27 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 91a5ae18351027867e99c96db5ea235d9c42e47a by Pablo Galindo in branch 'master': bpo-40217: Clean code in PyType_FromSpec_Alloc and add NEWS entry (GH-19733) https://github.com/python/cpython/commit/91a5ae18351027867e99c96db5ea23

[issue40334] PEP 617: new PEG-based parser

2020-04-27 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 2b74c835a7280840a853e3a9aaeb83758b13a458 by Pablo Galindo in branch 'master': bpo-40334: Support CO_FUTURE_BARRY_AS_BDFL in the new parser (GH-19721) https://github.com/python/cpython/commit/2b74c835a7280840a853e3a9aaeb83

[issue40334] PEP 617: new PEG-based parser

2020-04-27 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +19058 pull_request: https://github.com/python/cpython/pull/19736 ___ Python tracker <https://bugs.python.org/issue40

[issue40334] PEP 617: new PEG-based parser

2020-04-27 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset b94dbd7ac34dc0c79512656eb17f6f07e09fca7a by Pablo Galindo in branch 'master': bpo-40334: Support PyPARSE_DONT_IMPLY_DEDENT in the new parser (GH-19736) https://github.com/python/cpython/commit/b94dbd7ac34dc0c79512656eb17f6f

[issue40334] PEP 617: new PEG-based parser

2020-04-27 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > The parser generator imports modules token and tokenize. It is not correct, > because they are relevant to the Python version used to run the parser > generator, and not to the Python version for which the parser is generated. > It wor

[issue40334] PEP 617: new PEG-based parser

2020-04-27 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +19067 pull_request: https://github.com/python/cpython/pull/19745 ___ Python tracker <https://bugs.python.org/issue40

[issue40334] PEP 617: new PEG-based parser

2020-04-27 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset d55133f49fe678fbf047a647aa8bb8b520410e8d by Lysandros Nikolaou in branch 'master': bpo-40334: Catch E_EOF error, when the tokenizer returns ERRORTOKEN (GH-19743) https://github.com/python/cpyt

[issue40334] PEP 617: new PEG-based parser

2020-04-27 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 3d53d8756f0403eec6a4e12f183103d651bed6c5 by Lysandros Nikolaou in branch 'master': bpo-40334: Don't skip test_parser:test_trigget_memory_error (GH-19744) https://github.com/python/cpython/commit/3d53d8756f0403eec6a4e12f1

[issue40334] PEP 617: new PEG-based parser

2020-04-28 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 5b9f4988c94f47fa35e84f154a7b5aa17bc04722 by Pablo Galindo in branch 'master': bpo-40334: Refactor peg_generator to receive a Tokens file when building c code (GH-19745) https://github.com/python/cpyt

[issue40334] PEP 617: new PEG-based parser

2020-04-28 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +19095 pull_request: https://github.com/python/cpython/pull/19775 ___ Python tracker <https://bugs.python.org/issue40

[issue40334] PEP 617: new PEG-based parser

2020-04-28 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Pablo: Would you mind to increase ware-gentoo-x86 timeout? Ex: 30 min instead > of 15 min. Done: https://github.com/python/buildmaster-config/pull/190 -- ___ Python tracker <https://bugs.p

[issue40334] PEP 617: new PEG-based parser

2020-04-28 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +19099 pull_request: https://github.com/python/cpython/pull/19779 ___ Python tracker <https://bugs.python.org/issue40

[issue40334] PEP 617: new PEG-based parser

2020-04-28 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > The following code works on Python 3.8, but fails with SyntaxError on Python > 3.9.0a6 with the old and the new parser (see bpo-40431): This is not due to the new parser but due to https://bugs.python.org/issue40246. Please, report it th

[issue40246] Different error messages for same error - invalid string prefixes

2020-04-28 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I personally think the new behaviour is more consistent and more likely to catch errors. -- ___ Python tracker <https://bugs.python.org/issue40

[issue40334] PEP 617: new PEG-based parser

2020-04-28 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 37af21b667a9f41437b5b8e451497d7725016df5 by Lysandros Nikolaou in branch 'master': bpo-40334: Fix shifting of nested f-strings in the new parser (GH-19771) https://github.com/python/cpython/commit/37af21b667a9f41437b5b8e451497d

[issue40334] PEP 617: new PEG-based parser

2020-04-28 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 2208134918ee673451e4fc525bbeab71142d794a by Pablo Galindo in branch 'master': bpo-40334: Explicitly cast to int in pegen.c to fix a compiler warning (GH-19779) https://github.com/python/cpyt

[issue40334] PEP 617: new PEG-based parser

2020-04-28 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 6d6508765514c7c10719478a0430f5e47c9a96ac by Lysandros Nikolaou in branch 'master': bpo-40334: Disallow invalid single statements in the new parser (GH-19774) https://github.com/python/cpyt

[issue40432] Pegen regenerate project for Windows not working

2020-04-29 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 9b64ef3ac7b434065dbff0048b9103999e4b491a by Anthony Shaw in branch 'master': bpo-40432 Fix MSBuild project for Pegen grammars (#GH-9785) https://github.com/python/cpython/commit/9b64ef3ac7b434065dbff0048b9103

[issue40432] Pegen regenerate project for Windows not working

2020-04-29 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue40334] PEP 617: new PEG-based parser

2020-04-29 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 4db245ee9ddbe6c53d375de59a35ff59dea2a8e0 by Pablo Galindo in branch 'master': bpo-40334: refactor and cleanup for the PEG generators (GH-19775) https://github.com/python/cpython/commit/4db245ee9ddbe6c53d375de59a35ff

[issue40246] Different error messages for same error - invalid string prefixes

2020-04-29 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > What's also possible is to handle keywords at tokenizer level Sadly, the tokenizer is unaware of keywords (maybe except async and await because their history as soft keywords) as that distinction usually is up to the parser as the parser is

[issue40246] Different error messages for same error - invalid string prefixes

2020-04-29 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > If it's all handled by the tokenizer, how come it's different in the > newparser? Is not different in the new parser: both parsers have analogous behaviour now: ~/github/python/master master ❯ ./python Python 3.9.0a6+ (heads/master

[issue40246] Different error messages for same error - invalid string prefixes

2020-04-29 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Indeed, reverting commit 41d5b94af44e34ac05d4cd57460ed104ccf96628 makes it work with both parsers: ~/github/python/master master* ❯ ./python -X oldparser Python 3.9.0a6+ (heads/master-dirty:84724dd239, Apr 29 2020, 20:29:53) [GCC 9.3.0] on linux Type

[issue40334] PEP 617: new PEG-based parser

2020-04-29 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 69e802ed812e38cb68a4ab74af64b4f719b6cc78 by Lysandros Nikolaou in branch 'master': bpo-40334: Fix test_peg_parser to actually use the old parser (GH-19778) https://github.com/python/cpython/commit/69e802ed812e38cb68a4ab74af64b4

[issue39562] Asynchronous comprehensions don't work in asyncio REPL

2020-04-29 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I think we should backport the fix 4454057269b995341b04d13f0bf97f96080f27d0 (change constants) to 3.8 given that the likelihood of users using the actual hardcoded value of the constants instead of the constants themselves is very low. Also, given

[issue40334] PEP 617: new PEG-based parser

2020-04-30 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +19138 pull_request: https://github.com/python/cpython/pull/19818 ___ Python tracker <https://bugs.python.org/issue40

[issue40334] PEP 617: new PEG-based parser

2020-05-01 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Warnings found by pyflakes: Hu, "Lib/test/test_tools/test_c_analyzer/test_parser" has nothing to do with this PR. This looks like Eric Snow's c analyzer for avoiding globals and other stuff fo

[issue40334] PEP 617: new PEG-based parser

2020-05-01 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +19152 pull_request: https://github.com/python/cpython/pull/19833 ___ Python tracker <https://bugs.python.org/issue40

[issue40334] PEP 617: new PEG-based parser

2020-05-01 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset b796b3fb48283412d3caf52323c69690e5818d3d by Pablo Galindo in branch 'master': bpo-40334: Simplify type handling in the PEG c_generator (GH-19818) https://github.com/python/cpython/commit/b796b3fb48283412d3caf52323c696

[issue39562] Asynchronous comprehensions don't work in asyncio REPL

2020-05-01 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +19153 pull_request: https://github.com/python/cpython/pull/19835 ___ Python tracker <https://bugs.python.org/issue39

[issue40334] PEP 617: new PEG-based parser

2020-05-01 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 76c1b4d5c5a610c09943e1ee7ae18f1957804730 by Batuhan Taskaya in branch 'master': bpo-40334: Improve column offsets for thrown syntax errors by Pegen (GH-19782) https://github.com/python/cpyt

[issue40334] PEP 617: new PEG-based parser

2020-05-01 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Seems there are more dependencies on wrong tokenizer. Please don't forget to > fix this. Thanks, Serhiy, will submit a PR soon! -- ___ Python tracker <https://bugs.python.

[issue39562] Asynchronous comprehensions don't work in asyncio REPL

2020-05-01 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue40334] PEP 617: new PEG-based parser

2020-05-01 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +19155 pull_request: https://github.com/python/cpython/pull/19837 ___ Python tracker <https://bugs.python.org/issue40

[issue39562] Asynchronous comprehensions don't work in asyncio REPL

2020-05-01 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +19156 pull_request: https://github.com/python/cpython/pull/19838 ___ Python tracker <https://bugs.python.org/issue39

[issue39562] Asynchronous comprehensions don't work in asyncio REPL

2020-05-01 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 71e6122b4428ae43e868e34db4f072635f58a555 by Pablo Galindo in branch '3.8': bpo-39562: Correctly updated the version section in the what's new document (GH-19838) https://github.com/python

[issue40334] PEP 617: new PEG-based parser

2020-05-01 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 3941d9700b2a272689cb8a8435b5c60a1466ef79 by Guido van Rossum in branch 'master': bpo-40334: Refactor lambda_parameters similar to parameters (GH-19830) https://github.com/python/cpython/commit/3941d9700b2a272689cb8a8435b5c6

[issue40334] PEP 617: new PEG-based parser

2020-05-01 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 03b7642265e65f198682f22648dbe6cf4fff9835 by Lysandros Nikolaou in branch 'master': bpo-40334: Make the PyPegen* and PyParser* APIs more consistent (GH-19839) https://github.com/python/cpyt

[issue40334] PEP 617: new PEG-based parser

2020-05-01 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +19166 pull_request: https://github.com/python/cpython/pull/19849 ___ Python tracker <https://bugs.python.org/issue40

[issue40334] PEP 617: new PEG-based parser

2020-05-01 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 7ba08ff7b41911f972d0750e068a2270e0dbd68f by Pablo Galindo in branch 'master': bpo-40334: use the TOKENS file when checking dangling rules (GH-19849) https://github.com/python/cpython/commit/7ba08ff7b41911f972d0750e068a22

[issue39562] Asynchronous comprehensions don't work in asyncio REPL

2020-05-01 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: The merge is in 3.8 master, so we need to make sure that Łukasz includes this on the 3.8.3 release. Victor sent an email to python-dev already about this issue. If you want to make absolutely sure this happens, maybe send an email directly to Łukasz

[issue40334] PEP 617: new PEG-based parser

2020-05-01 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +19170 pull_request: https://github.com/python/cpython/pull/19854 ___ Python tracker <https://bugs.python.org/issue40

[issue40334] PEP 617: new PEG-based parser

2020-05-01 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset d2baff4301387e232495491f7291903cc1217d21 by Pablo Galindo in branch 'master': bpo-40334: regenerate metaparser as part of regen-all (GH-19854) https://github.com/python/cpython/commit/d2baff4301387e232495491f729190

[issue38870] Expose ast.unparse in the ast module

2020-05-03 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 493bf1cc316b0b5bd90779ecd1132878c881669e by Batuhan Taskaya in branch 'master': bpo-38870: Don't start generated output with newlines in ast.unparse (GH-19636) https://github.com/python

[issue40426] Unable to use lowercase hexadecimal digits for percent encoding

2020-05-03 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I think that may be happening because you are still refering to this issue in the title of https://github.com/python/cpython/pull/19888? Not sure how the linkage is made, but if this keeps happening you may open an issue in the core-workflow repo in

[issue40426] Unable to use lowercase hexadecimal digits for percent encoding

2020-05-03 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: In the title -> in the description -- ___ Python tracker <https://bugs.python.org/issue40426> ___ ___ Python-bugs-lis

[issue40334] PEP 617: new PEG-based parser

2020-05-03 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 7f06af684a1882fdb19d20650825948b1d7996e5 by Lysandros Nikolaou in branch 'master': bpo-40334: Set error_indicator in _PyPegen_raise_error (GH-19887) https://github.com/python/cpython/commit/7f06af684a1882fdb19d2065082594

[issue40490] peg_generator module has unused imports

2020-05-03 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue40334] PEP 617: new PEG-based parser

2020-05-04 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset e10e7c771bf06112c4a311e0ef6b8af6423b0cca by Lysandros Nikolaou in branch 'master': bpo-40334: Spacialized error message for invalid args after bare '*' (GH-19865) https://github.com/p

[issue40246] Different error messages for same error - invalid string prefixes

2020-05-04 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 846d8b28ab9bb6197ee81372820311c0abe509c0 by Lysandros Nikolaou in branch 'master': bpo-40246: Revert reporting of invalid string prefixes (GH-19888) https://github.com/python/cpython/commit/846d8b28ab9bb6197ee81372820311

[issue40523] Weakref proxy missing pass throughs for hash() and reversed()

2020-05-05 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch nosy: +pablogsal nosy_count: 1.0 -> 2.0 pull_requests: +19261 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19946 ___ Python tracker <https://bugs.p

[issue40355] The ast module fails to reject certain malformed nodes

2020-05-05 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset c21c51235aa8061da6b0593d6f857f42fd92fd8b by Curtis Bucher in branch 'master': bpo-40355: Improve error messages in ast.literal_eval with malformed Dict nodes (GH-19868) https://github.com/python/cpyt

[issue40523] Weakref proxy missing pass throughs for hash() and reversed()

2020-05-05 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 96074de573f82fc66a2bd73c36905141a3f1d5c1 by Pablo Galindo in branch 'master': bpo-40523: Add pass-throughs for hash() and reversed() to weakref.proxy objects (GH-19946) https://github.com/python/cpyt

[issue40523] Weakref proxy missing pass throughs for hash() and reversed()

2020-05-05 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue40528] Improve / Clear ASDL generator

2020-05-06 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I was also thinking about getting rid of "string" nodes and just use Constant for those. Having the strings raw make the AST inconsistent because nodes that are 'strings' do not have line numbers and other metadata, making tools t

[issue40528] Improve / Clear ASDL generator

2020-05-06 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > For which of them a line number is meaningful and useful? Apologies, I was thinking of 'identifier', which is basically a PyObject representing a string. For instance, when parsing function calls like x = ast.parse("f(x=435)"

[issue40528] Improve / Clear ASDL generator

2020-05-06 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 091951a67c832db83c60f4eb22f1fb474b70e635 by Batuhan Taskaya in branch 'master': bpo-40528: Improve and clear several aspects of the ASDL definition code for the AST (GH-19952) https://github.com/python/cpyt

[issue40334] PEP 617: new PEG-based parser

2020-05-06 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +19280 pull_request: https://github.com/python/cpython/pull/19964 ___ Python tracker <https://bugs.python.org/issue40

[issue40334] PEP 617: new PEG-based parser

2020-05-06 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 999ec9ab6af536cc2666a0847ec02331aaf00416 by Lysandros Nikolaou in branch 'master': bpo-40334: Add type to the assignment rule in the grammar file (GH-19963) https://github.com/python/cpyt

[issue40334] PEP 617: new PEG-based parser

2020-05-06 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +19281 pull_request: https://github.com/python/cpython/pull/19966 ___ Python tracker <https://bugs.python.org/issue40

[issue40334] PEP 617: new PEG-based parser

2020-05-06 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +19285 pull_request: https://github.com/python/cpython/pull/19969 ___ Python tracker <https://bugs.python.org/issue40

[issue40334] PEP 617: new PEG-based parser

2020-05-06 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 99db2a1db7a9b468a0ce8377d579f78fa03a2a34 by Pablo Galindo in branch 'master': bpo-40334: Allow trailing comma in parenthesised context managers (GH-19964) https://github.com/python/cpython/commit/99db2a1db7a9b468a0ce8377d579f7

[issue40334] PEP 617: new PEG-based parser

2020-05-06 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 470aac4d8e76556bd8f820f3f3928dca2b4d2849 by Pablo Galindo in branch 'master': bpo-40334: Generate comments in the parser code to improve debugging (GH-19966) https://github.com/python/cpyt

[issue40334] PEP 617: new PEG-based parser

2020-05-07 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 2f37c355ab0e9ec9c1753985d27c41fa0bd719b9 by Lysandros Nikolaou in branch 'master': bpo-40334: Fix error location upon parsing an invalid string literal (GH-19962) https://github.com/python/cpyt

[issue40334] PEP 617: new PEG-based parser

2020-05-07 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 4638c6429575bd6de26b12b2af5df74d6568b553 by Lysandros Nikolaou in branch 'master': bpo-40334: Error message for invalid default args in function call (GH-19973) https://github.com/python/cpyt

[issue40555] pegen (PEP 617): bug in error handling

2020-05-07 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +19302 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19986 ___ Python tracker <https://bugs.python.org/issu

[issue40555] pegen (PEP 617): bug in error handling

2020-05-07 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue40555] pegen (PEP 617): bug in error handling

2020-05-07 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset db9163ceef31ba00ccb23226917f9c8e9142a0b8 by Pablo Galindo in branch 'master': bpo-40555: Check for p->error_indicator in loop rules after the main loop is done (GH-19986) https://github.com/python/c

[issue40334] PEP 617: new PEG-based parser

2020-05-07 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +19303 pull_request: https://github.com/python/cpython/pull/19987 ___ Python tracker <https://bugs.python.org/issue40

[issue40556] test__xxsubinterpreters leaked [1486, 1484, 1484, 1484] references

2020-05-07 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : Minimal reproducer: ./python -m test test__xxsubinterpreters -m test_custom___reduce__ -R : 0:00:00 load avg: 3.20 Run tests sequentially 0:00:00 load avg: 3.20 [1/1] test__xxsubinterpreters beginning 9 repetitions 123456789

[issue40334] PEP 617: new PEG-based parser

2020-05-09 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +19331 pull_request: https://github.com/python/cpython/pull/20020 ___ Python tracker <https://bugs.python.org/issue40

[issue40334] PEP 617: new PEG-based parser

2020-05-10 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: There is some discrepancy with the codeop module when running with the new parser: ./python -c "import codeop; codeop.CommandCompiler()('raise = 2\n\n', symbol='exec')" (No error) ./python -Xoldparser -c "im

[issue40585] compile_command exec not raising syntax error with new PGEN Parser

2020-05-10 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch nosy: +pablogsal nosy_count: 1.0 -> 2.0 pull_requests: +19340 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20030 ___ Python tracker <https://bugs.p

[issue40585] compile_command exec not raising syntax error with new PGEN Parser

2020-05-10 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 5b956ca42de37c761562e9c9aeb96a0e67606e33 by Pablo Galindo in branch 'master': bpo-40585: Normalize errors messages in codeop when comparing them (GH-20030) https://github.com/python/cpython/commit/5b956ca42de37c761562e9c9aeb96a

[issue40585] compile_command exec not raising syntax error with new PGEN Parser

2020-05-10 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue40334] PEP 617: new PEG-based parser

2020-05-11 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +19349 pull_request: https://github.com/python/cpython/pull/20039 ___ Python tracker <https://bugs.python.org/issue40

[issue40599] Improve error messages with expected keywords

2020-05-11 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +19350 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20039 ___ Python tracker <https://bugs.python.org/issu

[issue40599] Improve error messages with expected keywords

2020-05-11 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : Using the new parser, we could improve the plain "syntax error" messages with the tokens/keywords that would have made the parser advance. There is a proof of concept in https://github.com/python/cpython/pull/20039 you can play with. I

[issue40334] PEP 617: new PEG-based parser

2020-05-11 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: -19349 ___ Python tracker <https://bugs.python.org/issue40334> ___ ___ Python-bugs-list mailing list Unsub

[issue40599] Improve error messages with expected keywords

2020-05-11 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > SyntaxError: Invalid syntax. Expected one of: for, pass, lambda, False, > global, True, __new_parser__, if, raise, continue, not, break, while, None, > del, nonlocal, import, assert, return, class, with, def, try, from, yield Haha, that

<    21   22   23   24   25   26   27   28   29   30   >