[issue39276] type() cause segmentation fault in callback function called from C extension

2020-01-09 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- Removed message: https://bugs.python.org/msg359687 ___ Python tracker <https://bugs.python.org/issue39276> ___ ___ Python-bug

[issue4347] Circular dependency causes SystemError when adding new syntax

2020-01-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I think there is nothing missing now that the C version of pgen is gone. And parsetok is already rebuilt when gramminit.h changes: Python/compile.o Python/symtable.o Python/ast_unparse.o Python/ast.o Python/future.o Parser/parsetok.o: $(srcdir

[issue1531415] parsetok.c emits warnings by writing to stderr

2020-01-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: The C version of pgen is gone so the circular dependency should not be a problem as as far as I can tell, Parser/parsetok.c does not emit warnings anymore (the functions are unused). Maybe we should just clean that code instead

[issue1531415] parsetok.c emits warnings by writing to stderr

2020-01-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: https://github.com/python/cpython/pull/17971 -- ___ Python tracker <https://bugs.python.org/issue1531415> ___ ___ Pytho

[issue3530] ast.NodeTransformer doc bug

2020-01-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 6680f4a9f5d15ab82b2ab6266c6f917cb78c919a by Pablo Galindo (Batuhan Taşkaya) in branch 'master': bpo-3530: Add advice on when to correctly use fix_missing_locations in the AST docs (GH-17172) https://github.com/python/cpyt

[issue3530] ast.NodeTransformer doc bug

2020-01-12 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.o

[issue39313] lib2to3 provide a way to use exec as a function in RefactoringTool

2020-01-12 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue39307] Memory leak in parsetok

2020-01-13 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 7ba6f18de2582755ae31888ba6a4237d96dddc48 by Pablo Galindo (Alex Henrie) in branch 'master': bpo-39307: Fix memory leak on error path in parsetok (GH-17953) https://github.com/python/cpython/commit/7ba6f18de2582755ae31888ba6a423

[issue39307] Memory leak in parsetok

2020-01-13 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38903] #if 0 block on parsetok.c

2020-01-13 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue1531415] parsetok.c emits warnings by writing to stderr

2020-01-13 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Closed by https://github.com/python/cpython/pull/17365 -- resolution: -> fixed stage: test needed -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/

[issue39320] Handle unpacking of */** arguments and rvalues in the compiler

2020-01-13 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +pablogsal ___ Python tracker <https://bugs.python.org/issue39320> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39322] Add gc.is_finalized to check if an object has been finalised by the gc

2020-01-13 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : Right now is not possible to check from the Python layer if an object with gc support has been already finalized by the GC (but has been resurrected). When implementing some callbacks for the gc in order to add advanced statistics, I have greatly

[issue39322] Add gc.is_finalized to check if an object has been finalised by the gc

2020-01-13 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +17392 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17989 ___ Python tracker <https://bugs.python.org/issu

[issue39322] Add gc.is_finalized to check if an object has been finalised by the gc

2020-01-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset a2ec3f07f7f028ff6229d6be2a7cfbda1f4efaeb by Pablo Galindo in branch 'master': bpo-39322: Add gc.is_finalized to check if an object has been finalised by the gc (GH-17989) https://github.com/python/cpyt

[issue39322] Add gc.is_finalized to check if an object has been finalised by the gc

2020-01-14 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue39322] Add gc.is_finalized to check if an object has been finalised by the gc

2020-01-14 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +17404 pull_request: https://github.com/python/cpython/pull/18000 ___ Python tracker <https://bugs.python.org/issue39

[issue39322] Add gc.is_finalized to check if an object has been finalised by the gc

2020-01-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset b6791375b2ff86ea07f068fb53d9575c337eaa5b by Pablo Galindo in branch 'master': bpo-39322: Add gc.is_finalized to the gc module docstring (GH-18000) https://github.com/python/cpython/commit/b6791375b2ff86ea07f068fb53d957

[issue17005] Add a topological sort algorithm

2020-01-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Am I seriously suggesting this for Python? Sure. It's fun to advance the > practical state of the art :-) I think this API looks very interesting! I have some questions before start implementing it to play a bit with it: - I

[issue17005] Add a topological sort algorithm

2020-01-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Fair enough, I will read this carefully again and try to sketch a prototype soon :) -- ___ Python tracker <https://bugs.python.org/issue17

[issue17005] Add a topological sort algorithm

2020-01-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Disregarding the API, what do you think about the approach of https://github.com/python/cpython/pull/11583 for the implementation? Under my benchmarks (check previous comments) it seems to perform very good with regards to memory and time

[issue38076] Make struct module PEP-384 compatible

2020-01-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Executing this simple code after this commit segfaults: from multiprocessing.pool import Pool class A(object): def __init__(self): self.pool = Pool() def __del__(self): self.pool.close() self.pool.join() a = A() [1

[issue39360] python3.8 regression - ThreadPool join via __del__ hangs forever

2020-01-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: This is not a regression: the code only worked on 3.7 because there is a sleep in the pool maintainance loop that makes the pool more likely being more consistent, but is the same problem as there is a race condition. For example, reducing the sleep

[issue39362] add option to make chunksize adaptive for multiprocessing.pool methods

2020-01-16 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +pablogsal ___ Python tracker <https://bugs.python.org/issue39362> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32615] Inconsistent behavior if globals is a dict subclass

2020-01-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > IMHO we should reject dict subclasses to make Python (especially ceval.c) > more efficient. The global type must be checked at every place where it's > possible to specify or override globals. Like the exec() function. I agree with

[issue17005] Add a topological sort algorithm

2020-01-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I have been playing with the API for a while and I have to say that I have fallen in love with it: I tried to reimplement many snippets of parallel and non-parallel topological-order processing of a graph with this and it always fits very nicely. I

[issue39372] The header files in Include/ have many declarations with no definition

2020-01-17 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : There are many declarations that lack definitions in our header files that should be cleaned (linking against those symbols will fail so removing them should be safe if I am not missing something). -- components: Build messages: 360204 nosy

[issue39372] The header files in Include/ have many declarations with no definition

2020-01-17 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +17436 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18037 ___ Python tracker <https://bugs.python.org/issu

[issue39372] The header files in Include/ have many declarations with no definition

2020-01-17 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset cd7db76a636c218b2d81d3526eb435cfae61f212 by Pablo Galindo in branch 'master': bpo-39372: Clean header files of declared interfaces with no implementations (GH-18037) https://github.com/python/cpyt

[issue39372] The header files in Include/ have many declarations with no definition

2020-01-17 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue39372] The header files in Include/ have many declarations with no definition

2020-01-18 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Maybe backport this change (except PyNoArgsFunction)? I didn't think of backporting to reduce the possibilities of something going wrong, but is true that a backport without PyNoArgsFunction should be harmless. Reopening the issue meanwhile

[issue38400] Python segfaults when configured with --with-pydebug --with-trace-refs

2020-01-19 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Since https://bugs.python.org/issue38070 was backported to 3.8, shouldn't > this as well? 3.8 is currently broken otherwise. Thanks for the catch, Elvis! -- ___ Python tracker <https://b

[issue38076] Make struct module PEP-384 compatible

2020-01-21 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Is it enough to reduce the issue priority from release blocker to normal? The error can still happened in other modules and under similar conditions, no? -- ___ Python tracker <https://bugs.pyth

[issue39421] Use-after-free in heappushpop() of heapq module

2020-01-22 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: To be honest, given how many ways this bug happens I think its time to consider msg359023. -- ___ Python tracker <https://bugs.python.org/issue39

[issue39421] Use-after-free in heappushpop() of heapq module

2020-01-22 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: AS this discussion will take a while and likely will have deeper consequences, in the meantime I created PR18118 to specifically fix this. -- stage: patch review -> needs patch ___ Python tracker <

[issue39421] Use-after-free in heappushpop() of heapq module

2020-01-22 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +17505 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/18118 ___ Python tracker <https://bugs.python.org/issu

[issue39425] list.count performance regression

2020-01-22 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset fdb21609d944941f0732df72dc3d07a7a9a7efea by Pablo Galindo (Miss Islington (bot)) in branch '3.8': bpo-39425: Fix list.count performance regression (GH-18119) (GH-18120) https://github.com/python/cpyt

[issue39425] list.count performance regression

2020-01-22 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Thanks for the PR, Dong-hee Na :) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue39425] list.count performance regression

2020-01-22 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 9e06d61af30bac4fcacb7973f826147ccc010392 by Pablo Galindo (Miss Islington (bot)) in branch '3.7': bpo-39425: Fix list.count performance regression (GH-18119) (GH-18121) https://github.com/python/cpyt

[issue39425] list.count performance regression

2020-01-22 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > The following result is a little bit surprising: haha, I went to exactly the same journey when reviewing this PR :) -- ___ Python tracker <https://bugs.python.org/issu

[issue39427] python -X options are not documented in the CLI --help

2020-01-22 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : When running python --help there is no documentation on the -X opt options available. It just says: -X opt : set implementation-specific option without what 'opt' can be. -- assignee: pablogsal components: Interpreter Core messag

[issue39427] python -X options are not documented in the CLI --help

2020-01-22 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +17517 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18131 ___ Python tracker <https://bugs.python.org/issu

[issue39427] python -X options are not documented in the CLI --help

2020-01-22 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +17519 pull_request: https://github.com/python/cpython/pull/18133 ___ Python tracker <https://bugs.python.org/issue39

[issue39427] python -X options are not documented in the CLI --help

2020-01-22 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +17520 pull_request: https://github.com/python/cpython/pull/18134 ___ Python tracker <https://bugs.python.org/issue39

[issue39421] Use-after-free in heappushpop() of heapq module

2020-01-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 79f89e6e5a659846d1068e8b1bd8e491ccdef861 by Pablo Galindo in branch 'master': bpo-39421: Fix posible crash in heapq with custom comparison operators (GH-18118) https://github.com/python/cpyt

[issue39421] Use-after-free in heappushpop() of heapq module

2020-01-23 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue17005] Add a topological sort algorithm

2020-01-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 99e6c260d60655f3d2885af545cbc220b808d492 by Pablo Galindo in branch 'master': bpo-17005: Add a class to perform topological sorting to the standard library (GH-11583) https://github.com/python/cpyt

[issue17005] Add a topological sort algorithm

2020-01-23 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +17541 pull_request: https://github.com/python/cpython/pull/18155 ___ Python tracker <https://bugs.python.org/issue17

[issue17005] Add a topological sort algorithm

2020-01-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 65ecc390c1fa5acdd6348ae3f9843bbdcd8870d1 by Pablo Galindo in branch 'master': bpo-17005: Minor improvements to the documentation of TopologicalSorter (GH-18155) https://github.com/python/cpyt

[issue39463] ast.Constant, bytes, and ast.unparse

2020-01-27 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > First, it breaks backward compatibility for older code that creates ast.Num > without specifying kind The ast changes during versions, and in the current master there are no "Num" nodes, so not much we could do there safely. >

[issue39463] ast.Constant, bytes, and ast.unparse

2020-01-27 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > First, it breaks backward compatibility for older code that creates ast.Num > without specifying kind The ast changes during versions, and in the current master there are no "Num" nodes, so not much we could do there sadly. >

[issue39463] ast.Constant, bytes, and ast.unparse

2020-01-27 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- Removed message: https://bugs.python.org/msg360757 ___ Python tracker <https://bugs.python.org/issue39463> ___ ___ Python-bug

[issue39463] ast.Constant, bytes, and ast.unparse

2020-01-27 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Maybe we need to clarify to the docs of 'unparse' that the AST object needs to be valid. -- ___ Python tracker <https://bugs.python.o

[issue39463] ast.Constant, bytes, and ast.unparse

2020-01-27 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Maybe we should only offically allow things that can be generated by > ast.parse? Yes, I think this is the way to go. In the future, we can expand the function to support more things, but for the first release, it should be as much restrict

[issue39453] Use-after-free in list contain

2020-01-27 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 4dbf2d8c6789a9b7299b142033073213604b8fdc by Pablo Galindo (Dong-hee Na) in branch 'master': bpo-39453: Make list.__contains__ hold strong references to avoid crashes (GH-18181) https://github.com/python/cpyt

[issue39675] forked process in multiprocessing does not honour atexit

2020-02-18 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- assignee: -> pablogsal ___ Python tracker <https://bugs.python.org/issue39675> ___ ___ Python-bugs-list mailing list Un

[issue39675] forked process in multiprocessing does not honour atexit

2020-02-18 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- components: +Library (Lib) type: -> behavior versions: +Python 3.9 ___ Python tracker <https://bugs.python.org/issu

[issue39686] add dump_json to ast module

2020-02-19 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Thanks, Richard for your proposal. I concur with Batuhan: I am -1 as well on this addition. Echoing some of the same ideas, I think this is specialized enough that does not make sense to have it in the standard library, especially if a Pypi package

[issue39686] add dump_json to ast module

2020-02-19 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > There seems to be movement towards a general usage. For instance, take a look > at clang, in particular the flag '-ast-dump=json'. I don't think the clang argument holds because clang is a command-line tool after all and it ma

[issue39686] add dump_json to ast module

2020-02-19 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Just to clarify: ast.dump *will* fail with a more deph object as well, I am not claiming that ast.dump will parse everything because of course suffers the same problem. -- ___ Python tracker <ht

[issue39427] python -X options are not documented in the CLI --help

2020-02-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 333b9899fc7807575d1742b77b4633ac53bd528f by Pablo Galindo in branch '3.7': [3.7] bpo-39427: Document -X opt options in the CLI --help and the man page (GH-18131) (#18134) https://github.com/python/cpyt

[issue39427] python -X options are not documented in the CLI --help

2020-02-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 13951c7f25c628ea2dc0a869ebe18e7bf593fa6d by Pablo Galindo in branch '3.8': [3.8] bpo-39427: Document -X opt options in the CLI --help and the man page (GH-18131) (GH-18133) https://github.com/python/cpyt

[issue39427] python -X options are not documented in the CLI --help

2020-02-23 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38641] lib2to3 does not support py38 return/yield syntax with starred expressions

2020-03-01 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38641] lib2to3 does not support py38 return/yield syntax with starred expressions

2020-03-01 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 768d739c1cd8c1d41902229581811a9b86bcc76e by Vlad Emelianov in branch 'master': bpo-38641: Add lib2to3 support for starred expressions in return/yield statements (GH-16994) https://github.com/python/cpyt

[issue39520] AST Unparser can't unparse ext slices correctly

2020-03-01 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 185903de12de8837bf0dc0008a16e5e56c66a019 by Batuhan Taşkaya in branch 'master': bpo-39520: Fix un-parsing of ext slices with no dimensions (GH-18304) https://github.com/python/cpython/commit/185903de12de8837bf0dc0008a16e5

[issue38870] Expose ast.unparse in the ast module

2020-03-01 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 397b96f6d7a89f778ebc0591e32216a8183fe667 by Batuhan Taşkaya in branch 'master': bpo-38870: Implement a precedence algorithm in ast.unparse (GH-17377) https://github.com/python/cpython/commit/397b96f6d7a89f778ebc0591e32216

[issue39815] functools.cached_property() not included in __all__

2020-03-01 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +pablogsal nosy_count: 3.0 -> 4.0 pull_requests: +18085 pull_request: https://github.com/python/cpython/pull/18728 ___ Python tracker <https://bugs.python.org/issu

[issue39815] functools.cached_property() not included in __all__

2020-03-01 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 12b714391e485d0150b343b114999bae4a0d34dd by Pablo Galindo in branch '3.8': [3.8] bpo-39815: add cached_property to all (GH-18726) (GH-18728) https://github.com/python/cpython/commit/12b714391e485d0150b343b114999b

[issue39815] functools.cached_property() not included in __all__

2020-03-01 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue39199] Improve the AST documentation

2020-03-01 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 114081f8adafa16283df30c456716a1bef4758d0 by Pablo Galindo in branch 'master': bpo-39199: Add descriptions of non-deprecated nodes to the AST module documentation (GH-17812) https://github.com/python/cpyt

[issue39829] __len__ called twice in the list() constructor

2020-03-02 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Why should that be backwards incompatible? The number of times we can `__len__` on the constructor is an implementation detail. The reason is called now twice is because there is an extra check for the preallocation logic, which is detached from the

[issue39778] collections.OrderedDict and weakref.ref raises "refcount is too small" assertion

2020-03-02 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- assignee: -> pablogsal ___ Python tracker <https://bugs.python.org/issue39778> ___ ___ Python-bugs-list mailing list Un

[issue39778] collections.OrderedDict and weakref.ref raises "refcount is too small" assertion

2020-03-02 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I concur with Antoine and Tim. The GC already has the machinery to deal with weak references in the correct way (even more after recent bugfixes regarding callbacks). Traversing the weak reference list in incorrect because the object does not &quo

[issue38870] Expose ast.unparse in the ast module

2020-03-02 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 89aa4694fc8c6d190325ef8ed6ce6a6b8efb3e50 by Batuhan Taşkaya in branch 'master': bpo-38870: Add docstring support to ast.unparse (GH-17760) https://github.com/python/cpython/commit/89aa4694fc8c6d190325ef8ed6ce6a

[issue39778] collections.OrderedDict and weakref.ref raises "refcount is too small" assertion

2020-03-02 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > I agree the tp_traverse docs should point out that weakref lists are special > this way, but I think the problem is unique to them - can't think of another > case where a container points to an object it doesn't own a reference

[issue39778] collections.OrderedDict and weakref.ref raises "refcount is too small" assertion

2020-03-02 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +18104 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/18749 ___ Python tracker <https://bugs.python.org/issu

[issue39778] collections.OrderedDict and weakref.ref raises "refcount is too small" assertion

2020-03-02 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 0c2b509f9d1d3a9065bc62c2407e1dc2ed70e9c2 by Pablo Galindo in branch 'master': bpo-39778: Don't traverse weak-reference lists OrderedDict's tp_traverse and tp_clear (GH-18749) https://github.com/p

[issue39778] collections.OrderedDict and weakref.ref raises "refcount is too small" assertion

2020-03-02 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +18109 pull_request: https://github.com/python/cpython/pull/18754 ___ Python tracker <https://bugs.python.org/issue39

[issue39778] collections.OrderedDict and weakref.ref raises "refcount is too small" assertion

2020-03-02 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +18111 pull_request: https://github.com/python/cpython/pull/18756 ___ Python tracker <https://bugs.python.org/issue39

[issue39778] collections.OrderedDict and weakref.ref raises "refcount is too small" assertion

2020-03-02 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 9ddcb914f9c2debe7c1359b2450cd1573e86b91c by Pablo Galindo in branch '3.8': [3.8] bpo-39778: Don't traverse weak-reference lists OrderedDict's tp_traverse and tp_clear (GH-18749) (GH-18756) https://github.com/p

[issue39697] Failed to build with --with-cxx-main=g++-9.2.0

2020-03-02 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: This seems like a duplicate of https://bugs.python.org/issue35912 -- nosy: +pablogsal ___ Python tracker <https://bugs.python.org/issue39

[issue39831] Reference leak in PyErr_WarnEx()

2020-03-02 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +pablogsal nosy_count: 1.0 -> 2.0 pull_requests: +18115 pull_request: https://github.com/python/cpython/pull/18760 ___ Python tracker <https://bugs.python.org/issu

[issue39831] Reference leak in PyErr_WarnEx()

2020-03-02 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +18116 pull_request: https://github.com/python/cpython/pull/18761 ___ Python tracker <https://bugs.python.org/issue39

[issue39831] Reference leak in PyErr_WarnEx()

2020-03-02 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I made the backports to 3.7 and 3.8 manually to calm down the refleak buildbots as the automatic backports failed :) -- ___ Python tracker <https://bugs.python.org/issue39

[issue39831] Reference leak in PyErr_WarnEx()

2020-03-02 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 499c926fbeafa7e4c15d925fea27fe8a65cc3b25 by Pablo Galindo in branch '3.7': [3.7] bpo-39831: Fix a reference leak in PyErr_WarnEx(). (GH-18750). (GH-18760) https://github.com/python/cpython/commit/499c926fbeafa7e4c15d925fea27fe

[issue39831] Reference leak in PyErr_WarnEx()

2020-03-02 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 394dc0db878c08d003772de163a57ac12046d865 by Pablo Galindo in branch '3.8': [3.8] bpo-39831: Fix a reference leak in PyErr_WarnEx(). (GH-18750) (GH-18761) https://github.com/python/cpython/commit/394dc0db878c08d003772de163a57a

[issue39831] Reference leak in PyErr_WarnEx()

2020-03-02 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Closing this as the backports are merged. Thanks, Serhiy, for finding the leak and for the fix :) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracke

[issue39802] Ensure {get, set}_escdelay and {get, set}_tabsize only implemented when the extensions are activated

2020-03-02 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 4991cf47c487500fdedc34f0a2eb4b7468a67c3c by Batuhan Taşkaya in branch 'master': bpo-39802: Only expose set_escdelay and set_tabsize when curses extensions are activated (GH-18705) https://github.com/python/cpyt

[issue39802] Ensure {get, set}_escdelay and {get, set}_tabsize only implemented when the extensions are activated

2020-03-03 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue39831] Reference leak in PyErr_WarnEx()

2020-03-03 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > It is not so easy for 3.7. Apologies Serhiy, I thought it was more straightforward and just wanted to stop the mail storm that the refleak buildbots were causing :( -- ___ Python tracker <

[issue39639] Remove Suite node from AST

2020-03-04 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset d82e469048e0e034d8c0020cd33b733be1adf68b by Batuhan Taşkaya in branch 'master': bpo-39639: Remove the AST "Suite" node and associated code (GH-18513) https://github.com/python/cpython/commit/d82e469048e0e034d8c0

[issue39639] Remove Suite node from AST

2020-03-04 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38894] Path.glob() sometimes misses files that match

2020-03-06 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- assignee: -> pablogsal nosy: +pablogsal ___ Python tracker <https://bugs.python.org/issue38894> ___ ___ Python-bugs-lis

[issue38894] Path.glob() sometimes misses files that match

2020-03-06 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I fail to reproduce this last example: ~/github/python/master master* ❯ mkdir tmp ~/github/python/master master* ❯ cd tmp ~/github/python/master/tmp master* ❯ touch 1.txt ~/github/python/master/tmp master* ❯ ln -s

[issue38894] Path.glob() sometimes misses files that match

2020-03-06 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- Removed message: https://bugs.python.org/msg363548 ___ Python tracker <https://bugs.python.org/issue38894> ___ ___ Python-bug

[issue38894] Path.glob() sometimes misses files that match

2020-03-06 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Ok, I managed to reproduce. This seems a regression introduced by https://github.com/python/cpython/pull/11988 in issue https://bugs.python.org/issue36035. -- ___ Python tracker <https://bugs.python.

[issue38894] Path.glob() sometimes misses files that match

2020-03-06 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +18173 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18815 ___ Python tracker <https://bugs.python.org/issu

[issue14126] Speed up list comprehensions by preallocating the list where possible

2020-03-07 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Isn't this the same as https://bugs.python.org/issue36551 ? -- nosy: +pablogsal ___ Python tracker <https://bugs.python.org/is

[issue39199] Improve the AST documentation

2020-03-07 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Would not be better to use mode='eval' for expression nodes? Agreed! I will prepare a PR soon to simplify the expression examples. -- ___ Python tracker <https://bugs.pytho

<    18   19   20   21   22   23   24   25   26   27   >