Martin Panter added the comment:
The warning for urllib2.urlopen() was removed in revision 1882157b298a.
However, a couple other warnings were converted to “Changed in version 2.7.9”
in revision fb83916c3ea1, which seems safer to me.
Removing documentation almost seems like a step backwards
Martin Panter added the comment:
Will keep this in mind, but my time is rather limited, so I may not get to it
(and I wouldn’t want to discourage other people from working on it)
--
___
Python tracker
<http://bugs.python.org/issue20
Martin Panter added the comment:
Patch looks good, apart from one little thing (see review)
--
___
Python tracker
<http://bugs.python.org/issue29311>
___
___
Pytho
Changes by Martin Panter :
--
dependencies: +Document socket.SOL_SOCKET
___
Python tracker
<http://bugs.python.org/issue1732367>
___
___
Python-bugs-list mailin
Martin Panter added the comment:
Patch looks good to me.
BTW in Issue 27409 I proposed a patch listing more of these.
--
nosy: +martin.panter
___
Python tracker
<http://bugs.python.org/issue26
Changes by Martin Panter :
--
title: Clarify the behavior of NotImplemented -> Clarify the behavior of
__eq__() returning NotImplemented
___
Python tracker
<http://bugs.python.org/issu
Changes by Martin Panter :
--
dependencies: +Clarify the behavior of __eq__() returning NotImplemented
___
Python tracker
<http://bugs.python.org/issue15
Martin Panter added the comment:
I added this behaviour in 3.6 on purpose via Issue 26685.
The change also impacted Yury (see the original bug thread), but if I
understood correctly, he eventually decided that it highlighted a problem in
asyncio or his code (though the resulting asyncio pull
Martin Panter added the comment:
If the assignment is completely removed, won’t this break the test when run
from the source or build tree (as opposed to when installed)? Or at least make
the situation worse: the AIX buildbot is already failing test_distutils, but at
least it is looking for
Martin Panter added the comment:
It is not obvious what the effect of not calling addFailure() is, but perhaps
this is related to Issue 25894? Failure and error statuses are not immediately
reported from subtests.
--
nosy: +martin.panter
___
Python
Martin Panter added the comment:
There is an inconsistency when parsing with headersonly=True. According to the
documentation, get_payload() with message/rfc822 should should return a list of
Message objects, not a string. But using headersonly=True produces a
non-multipart Message object
Changes by Martin Panter :
--
versions: +Python 3.6 -Python 3.5
___
Python tracker
<http://bugs.python.org/issue21272>
___
___
Python-bugs-list mailing list
Unsub
Martin Panter added the comment:
Updated patch for 2.7, which I plan to commit soon. Corresponding Py 3 patch
coming soon.
--
Added file: http://bugs.python.org/file46398/expressions-py2.7_v17.diff
___
Python tracker
<http://bugs.python.
Changes by Martin Panter :
Added file: http://bugs.python.org/file46399/expressions-py3.7_v17.diff
___
Python tracker
<http://bugs.python.org/issue12067>
___
___
Pytho
Martin Panter added the comment:
Is it okay to only fix this in 3.5+? 3.4 only gets security fixes now.
Either way, the “with” statement changes is not a bug fix and should only go
into 3.7.
--
nosy: +martin.panter
stage: -> commit rev
Martin Panter added the comment:
ERROR: test_annotation_usage_with_methods (test.test_typing.NamedTupleTests)
--
Traceback (most recent call last):
File "/home/proj/python/cpython/Lib/test/test_typing.py", lin
Martin Panter added the comment:
Just a minor update with an extra get_payload() test I missed before
--
versions: +Python 3.7
Added file: http://bugs.python.org/file46400/policy-flag.v2.patch
___
Python tracker
<http://bugs.python.org/issue24
Changes by Martin Panter :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Martin Panter added the comment:
I don’t run AIX, but my understanding is there are three distinct branches
(2.7, 3.5, and 3.6+). Some of the following is guessed, so please correct me if
I am wrong:
Python 2.7:
_sysconfigdata.py incorrectly created with LDSHARED = Modules/ld_so_aix.
Result
Martin Panter added the comment:
Sorry I meant Issue 10656. I recently committed a fix regarding out-of-tree
builds and ld_so_aix, and it sounds like you were thinking of reverting that.
--
___
Python tracker
<http://bugs.python.org/issue18
Changes by Martin Panter :
--
components: +Library (Lib)
stage: -> needs patch
versions: +Python 3.6, Python 3.7
___
Python tracker
<http://bugs.python.org/issu
Martin Panter added the comment:
This works for me on Linux:
>>> signal.pthread_sigmask(signal.SIG_BLOCK, {signal.SIGUSR1})
set()
>>> import threading
>>> t = threading.Thread(target=sigwait)
>>> t.start()
Send me a signal, my PID is 24197
>>> os.kil
Martin Panter added the comment:
More closely related: Issue 23448, about the same thing with urllib, which adds
the Host value itself. Any solution should be shared between both modules.
--
nosy: +martin.panter
___
Python tracker
<h
Martin Panter added the comment:
Nothing has been fixed; I don’t see any evidence that this is “out of date”.
Here is a more complete test:
import urllib.request
opener = urllib.request.build_opener(urllib.request.HTTPCookieProcessor())
urllib.request.install_opener(opener)
request = '
Martin Panter added the comment:
I presume this is the same as in Issue 18543 (and a few other duplicates). Let
me know if I got it wrong.
IMO there is no easy fix. The best solution may be to just document the
behaviour as a limitation of the API, and design a new/improved API for the
Martin Panter added the comment:
Do you have an opinion of the proposal Shawn?
Judging by John’s “[the constant] is what the system provides, though
users may customize as needed”, it sounds like the patch is more than a bug
fix. Will it also mean find_library() will no longer search
Martin Panter added the comment:
There is an Open Indiana buildbot
<http://buildbot.python.org/all/buildslaves/cea-indiana-x86>, that was passing
test_ctypes (until the buildbot went offline a few weeks ago). Would it be
possible to include a regression test case?
Also, in
Martin Panter added the comment:
I’m not really an expert on non-ASCII URLs / IRIs. Maybe it is obvious to other
people that this is a good general implementation, but for me to thoroughly
review it I would need time to research the relevant RFCs, other
implementations, suitability for the
New submission from Martin Panter:
Modules/ld_so_beos and Modules/ar_beos are no longer used since Be OS support
was dropped from the configure script for Python 3:
https://hg.python.org/cpython/diff/a5e984eda45a/configure.in
I propose to also remove the scripts.
--
components: Build
Martin Panter added the comment:
The O! and O& units are in a similar situation. They just use a different font
and descriptive name, rather than a specific type:
``O!`` (object) [*typeobject*, PyObject \*]
``O&`` (object) [*converter*, *anything*]
Following this lead, you could writ
Martin Panter added the comment:
FWIW, here is an attempt to add Argument Clinic to the Objects/floatobject.c
and Objects/longobject.c implementations:
https://bugs.python.org/file33943/issue20185_conglomerate_v4.diff
https://bugs.python.org/file33989/clinic_longobject_v3.patch
If the methods
Martin Panter added the comment:
For str.format_map(mapping), yes the parsing happens in
Objects/stringlib/unicode_format.h, but I don’t see that as a big problem.
Moving this back to “needs patch”, assuming it is okay to convert format_map().
Other than from that, there are just tricky
Martin Panter added the comment:
longobject_v5 looks good to me
--
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bugs-list mailin
Martin Panter added the comment:
I think the general rule is to clean up code if you are doing something else in
nearby code, but don’t go out of your way with unnecessary cleanups to
arbitrary code. Otherwise it adds too much noise to the repository history,
review process, risks adding bugs
Martin Panter added the comment:
Of course, somehow I missed that
--
___
Python tracker
<http://bugs.python.org/issue18842>
___
___
Python-bugs-list mailin
Martin Panter added the comment:
Thanks Senthil
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Martin Panter added the comment:
Thanks Ned. Do you know what version of Python Sphinx uses (which runs
patchlevel.py)?
According to Issue 28039, David set up Python 2.7 so that “make touch” would
work. But the log also uses a python2.5 command, and apparently Python 2.3 also
installed on
Martin Panter added the comment:
According to <https://bugs.python.org/issue17861#msg217417>, Ned says 2.6+ is
already needed to build the Python 3.5 documentation, so maybe Sphinx uses that.
--
___
Python tracker
<http://bugs.python.org/i
New submission from Martin Panter:
The Windows FAQ
<https://docs.python.org/release/3.5.2/faq/windows.html#how-do-i-keep-editors-from-inserting-tabs-into-my-python-source>
mentions the “python -t” command-line option, but in Python 3 this option is
undocumented (and I understand has no
Martin Panter added the comment:
I pushed the simpler 2.6-compatible option. Keeping this open to check the
buildbot is happy overnight.
--
stage: needs patch -> resolved
___
Python tracker
<http://bugs.python.org/issu
Martin Panter added the comment:
While I don’t have much opinion either way, here is a patch to remove the
existing dead code should that be the eventual outcome.
If the default implementations in the base class deferred to math.isfinite()
etc, that may help with compatibility
Martin Panter added the comment:
Can you explain your broken pipe situation? Are you talking about a real-world
EPIPE operating on a pseudoterminal, or just a result of using a Unix socket to
emulate a PTY in the tests? Usually a broken pipe is an asynchronous condition.
You cannot predict
Martin Panter added the comment:
Misc/NEWS (and the commit message) say 1.2.10. Perhaps you meant 1.2.11?
--
nosy: +martin.panter
___
Python tracker
<http://bugs.python.org/issue29
Martin Panter added the comment:
Shouldn’t the top-level unpack() parameter be called “buffer” like the other
functions and methods, not “inputstr”?
--
nosy: +martin.panter
___
Python tracker
<http://bugs.python.org/issue29
Martin Panter added the comment:
FYI Victor, you can make non-C-contiguous buffers by slicing memoryview:
>>> struct.unpack(">L", memoryview(b"1234")[::-1])
Traceback (most recent call last):
File "", line 1, in
BufferError: memoryview: underlying bu
Martin Panter added the comment:
Not a big deal, but the change produces compiler warnings with GCC 6.1.1:
/home/proj/python/cpython/Objects/bytesobject.c: In function ‘bytes_subscript’:
/home/proj/python/cpython/Objects/bytesobject.c:1701:13: warning: ‘slicelength’
may be used uninitialized
Changes by Martin Panter :
--
title: Subprocess picks the wrong executable on Windows -> Subprocess searches
special directories before PATH on Windows
___
Python tracker
<http://bugs.python.org/issu
Martin Panter added the comment:
It is hard to make sense of this without decoding your URLs, downloading the
repository and finding the relevant commit. Anyway, what you have posted sounds
like a duplicate of Issue 8557.
--
nosy: +martin.panter
resolution: -> duplicate
st
Changes by Martin Panter :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> subprocess.Popen(cwd) documentation
___
Python tracker
<http://bugs.python
Martin Panter added the comment:
Marco: I agree “Python reports an error” would have been simpler. That is what
I meant to say. Anyway, perhaps we should put
Python raises :exc:`IndentationError` if mixed tabs and spaces are causing
problems in leading whitespace.
In general, the exception
Martin Panter added the comment:
Perhaps this is a duplicate of Issue 8557
--
nosy: +martin.panter
___
Python tracker
<http://bugs.python.org/issue15451>
___
___
Changes by Martin Panter :
--
components: +Windows
stage: test needed -> needs patch
title: subprocess.Popen(cwd) documentation -> subprocess.Popen(cwd)
documentation: Posix vs Windows
___
Python tracker
<http://bugs.python.org/i
Martin Panter added the comment:
Have you tried enabling the locale with locale.setlocale()? I believe Python
only enables LC_CTYPE by default, so other locale aspects like LC_TIME won’t
work until they are enabled.
--
nosy: +martin.panter
Martin Panter added the comment:
>>> datetime.now().strftime("%x")
'02/06/17'
>>> from locale import setlocale, LC_TIME
>>> setlocale(LC_TIME)
'C'
>>> setlocale(LC_TIME, "
New submission from Martin Panter:
By default, the email package turns single-line header fields into multi-line
ones to try and limit the length of each line. The documentation
<https://docs.python.org/release/3.5.2/library/email.policy.html#email.policy.Policy.max_line_length>
say
Martin Panter added the comment:
Please explain what the wrong behaviour that you see is, and what you expect
the right behaviour should be.
That code is intended to either keep any user-supplied Accept-Encoding header
field, or send “Accept-Encoding: identity” if the field is not supplied
Martin Panter added the comment:
Jim, regarding Doc/faq/windows.rst, this warning lead me to open Issue 29387.
We already have discussed a patch for that, and I think it is ready to commit
(when it gets to the top of my list, if nobody else beats me to it).
Regarding Misc/NEWS, I think I was
Changes by Martin Panter :
--
dependencies: +Tabs vs spaces FAQ out of date
___
Python tracker
<http://bugs.python.org/issue29521>
___
___
Python-bugs-list mailin
Martin Panter added the comment:
Diff showing what changed relative to the main 3.5 branch when merging in the
3.5.2 release: <https://hg.python.org/cpython/rev/31a2a278dc85:1f8938164809>.
There are four news entries deleted from the 3.5.2rc1 section. Ideally they
should have been mo
Martin Panter added the comment:
This is similar to the problem of building a list by repeating one item:
<https://docs.python.org/2.7/faq/programming.html#how-do-i-create-a-multidimensional-list>.
With dict.fromkeys(), the resulting dictionary maps each specified key object
to the o
Martin Panter added the comment:
I suggest to close this as not a bug.
--
resolution: -> not a bug
___
Python tracker
<http://bugs.python.org/issue29552>
___
_
Martin Panter added the comment:
Sounds related to Issue 22239
--
nosy: +martin.panter
___
Python tracker
<http://bugs.python.org/issue29558>
___
___
Python-bug
Martin Panter added the comment:
Without more information about what the relevant code is and why you think the
line number is wrong, my best guess is you may not realize how the
ResourceWarning is emitted. It happens when the garbage collector runs and
destroys the socket object, which
Martin Panter added the comment:
Looks like the tests should run if the data is already downloaded. First run
needs -u urlfetch. My guess is your data is somehow corrupted. Check out your
copy of the files in Lib/test/data/, compare them to e.g.
<http://www.pythontest.net/hashlib/blake2b.
Martin Panter added the comment:
You say that the line number is incorrect. What would you consider a correct
line number to be?
Let me try again to explain my theory about garbage collection and reference
cycles. Perhaps you have two objects a and b, linked such that a.x = b and b.y
= a
Martin Panter added the comment:
The file position is often useful when the cleanup is deterministic. Example:
def f1():
file1 = open("/dev/null")
def f2():
file2 = open("/dev/null")
del file2 # ResourceWarning
f1() # ResourceWarning at function exit
f2()
Martin Panter added the comment:
The second example seems like the original complaint in Issue 25612. That
spawned a separate bug related to the first situation, which was later closed:
Issue 25683.
--
nosy: +martin.panter
type: -> behav
Martin Panter added the comment:
Matthias’s proposal sounds reasonable to me. There is a minor disadvantage that
it will exceed the width of an 80-character terminal:
UnboundLocalError: local variable 'x' referenced before assignment, or got delet
ed
But I don’t think the wrappin
Changes by Martin Panter :
--
stage: -> needs patch
versions: +Python 2.7, Python 3.5, Python 3.7
___
Python tracker
<http://bugs.python.org/issue29394>
___
_
Martin Panter added the comment:
It looks like you are trying to tunnel one SSL or TLS connection through
another SSL/TLS connection (instead of through a plain OS socket). There is
already a bug recently opened about this: Issue 29394.
Basically, the SSL module doesn’t support this, and the
Martin Panter added the comment:
Matthias’s proposal adds support for a new keyword-only “exc” argument:
print_exception(exc=exception_instance)
I still think it is worth supporting a single positional argument as well:
print_exception(exception_instance)
Another point is that it may
Martin Panter added the comment:
It's not clear what you expected the behaviour to be. A function cannot both
raise an exception and return a value.
In any case, you are correct in saying "the next option, '-d', is taken as the
argument." I do not think
Martin Panter added the comment:
Be careful, some OSes have limited support for “poll”, “kqueue”, etc with
terminals, and I ended up using “select” in the test suite:
https://bugs.python.org/issue26870#msg265604
https://github.com/python/cpython/commit/79f561d126d09d6d7ea1457a2a6ef267d93e6448
Martin Panter added the comment:
Apparently zlib only supports windowBits (wbits) = 0 since v1.2.3.5. I added a
version check in the Python 3 tests, which seems to have solved the buildbot
problems (OpenIndiana and OS X buildbots). In Python 2 I removed the test,
because Python 2 has no
Martin Panter added the comment:
> v = tuple(map(int, zlib.ZLIB_RUNTIME_VERSION.split(".")))
> supports_wbits_0 = v >= (1, 2, 3, 5)
That was basically my first thought. But I didn’t want to presume that every
element of the version is an integer. For instance, the cu
Martin Panter added the comment:
Porting this to Python 2 uncovered a few flaws that I am unsure how to best
handle. In this patch I have added workarounds, but perhaps we can find better
fixes.
1. The io.BytesIO.write() C implementation does not accept array.array()
objects. I suspect it
Martin Panter added the comment:
Strictly speaking, Python 2.7 never had special support for RTLD_MEMBER or
find_library(). That is why I am unsure about many of these changes being done
in 2.7. They seem more like new features than bug fixes. Especially once you
start talking about a smart
Martin Panter added the comment:
Thankyou Nathan, and also Anish & Aatish.
For the record, it is normally enough to do a patch against the latest (3.6),
and any minor conflicts can be sorted out when applying it to 3.5. In this case
the 3.5 and 3.6 patches were basically the same. But
Martin Panter added the comment:
Changing the names to tokenize. does solve the problem of the tokenize
module versus the tokenize() fuction, so I can accept this way since you prefer
it.
So I think that just leaves what to do with the actual test case. I don’t think
it matters too much, but
Martin Panter added the comment:
I think this patch is okay
--
nosy: +martin.panter
___
Python tracker
<http://bugs.python.org/issue27109>
___
___
Python-bug
Martin Panter added the comment:
For this particular case, there is only one existing test class called
CgiTests, without any special setup or handling. It seems too arbitrary to have
a second class called MiscTestCase, so I would prefer the new test be added to
CgiTests
Changes by Martin Panter :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Martin Panter added the comment:
I don’t see any violation or anything needing fixing in the documentation or
code. Can you elaborate?
The fcntl() documentation says “The values used for ‘cmd’ [F_DUPFD, etc] are
operating system dependent, and are available as constants in the ‘fcntl’
module
Martin Panter added the comment:
It looks like your commit to the “default” branch already included the relevant
changes, so I did the merge while keeping the files the same. If I missed
something, it may need an extra update. But the tests seem to be working (is
there a turtledemo test
Martin Panter added the comment:
Thanks for the report Phoenix
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Martin Panter added the comment:
It seems like this code does get used, so I agree to add it.
I think the table in the RST documentation should also be updated, possibly
with a versionadded/versionchanged notice.
--
nosy: +martin.panter
___
Python
Martin Panter added the comment:
Indeed it is duplicated! I must have read this in my head many times before
pushing it, and never picked it up.
--
___
Python tracker
<http://bugs.python.org/issue27
Martin Panter added the comment:
This recently hung AMD64 FreeBSD 9.x 3.5. The stack trace was different, and
there is only one thread:
http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.x%203.5/builds/828/steps/test/logs/stdio
[398/398] test_io
Timeout (0:15:00)!
Thread
Martin Panter added the comment:
I found a relatively recent case of this failing on a buildbot:
http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.x%203.x/builds/4339/steps/test/logs/stdio
== CPython 3.6.0a1+ (default:eaee5aed6fbc, May 27 2016, 05:52:21) [GCC 4.2.1
20070831 patched
Martin Panter added the comment:
Thanks, that is a very good point about threads. I remember that testing
tkinter leaves an internal TK or TCL thread running in the background. And I
understand Free BSD delivers process signals to arbitrary threads (not
necessarily the main thread).
But the
Martin Panter added the comment:
Found the same hang on the 3.6 branch, which was definitely running separate
processes:
http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.x%203.x/builds/4210/steps/test/logs/stdio
== CPython 3.6.0a0 (default:ed6345cb08ab, Apr 29 2016, 18:35:36) [GCC
Martin Panter added the comment:
Here is a patch for just the wsgiref module, which I plan to commit in time for
3.5.2. I also updated the test case to avoid hanging due to a (theoretical)
race with how signal handling works.
--
Added file: http://bugs.python.org/file43066/wsgiref
Martin Panter added the comment:
Attached patch adds a possible test, and fixes the truncation problem I
mentioned above.
I tried testing set_completer_delims() with a UTF-8 locale, but I suspect Gnu
Readline does not support it. I called set_completer_delims("\xF6"), which
encode
Changes by Martin Panter :
Added file: http://bugs.python.org/file43068/readline_locale.v2.patch
___
Python tracker
<http://bugs.python.org/issue16182>
___
___
Python-bug
Changes by Martin Panter :
Removed file: http://bugs.python.org/file43067/readline_locale.v2.patch
___
Python tracker
<http://bugs.python.org/issue16182>
___
___
Pytho
Martin Panter added the comment:
For Python 3, the bytes.splitlines() and bytearray.splitlines() documentation
has been moved to a separate section out (Issue 21777). I don’t think it is
good to add much detail of bytes.splitlines() in the str.splitlines()
documentation.
For Python 2
New submission from Martin Panter:
This fixes various spelling mistakes in documentation, code comments, and test
function names.
There is also a correction to an exception message in
Modules/_ctypes/callproc.c, which I propose to fix only in 3.6.
--
files: typos.py3.patch
keywords
Changes by Martin Panter :
Added file: http://bugs.python.org/file43077/typos.py2.patch
___
Python tracker
<http://bugs.python.org/issue27171>
___
___
Python-bugs-list m
Martin Panter added the comment:
Thanks. The py2 version is partly a back port, but I have searched for the same
kind of spelling mistakes and fixed them in different places, e.g. “overriden”
in Lib/bsddb/test/test_all.py, which does not exist in Py 3
Martin Panter added the comment:
Reopening to change the Python 2 documentation. A starting point may be
Matthew’s patch and/or Alexander’s patch in Issue 22232.
--
status: closed -> open
___
Python tracker
<http://bugs.python.org/issu
901 - 1000 of 4320 matches
Mail list logo
