Martin Panter added the comment:
Windows fails the test:
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/7989/steps/test/logs/stdio
==
ERROR: test_path_objects (test.test_logging.HandlerTest
Martin Panter added the comment:
This upset the buildbots:
http://buildbot.python.org/all/builders/PPC64%20Fedora%203.x/builds/1259/steps/test/logs/stdio
==
FAIL: test_all (test.datetimetester.ZoneInfoCompleteTest
Martin Panter added the comment:
Apart from the empty “if” statement style (see review), tuple_and_list.patch
looks good to me.
I understand the patches from 2011 and earlier have all been committed (correct
me if I missed something).
Here is another patch fixing a 64-bit overflow in _thread
Martin Panter added the comment:
Perhaps we should add a test for the __length_hint__() overflow to
tuple_and_list.patch:
>>> a = [1,2,3,4]
>>> import sys
>>> class B:
... def __iter__(s): return s
... def __next__(s): raise StopIteration()
... def __length_hi
Changes by Martin Panter :
Added file: http://bugs.python.org/file43839/array-size.patch
___
Python tracker
<http://bugs.python.org/issue1621>
___
___
Python-bugs-list m
Martin Panter added the comment:
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.5/builds/1072/steps/test/logs/stdio
==
FAIL: test_null_bytes (test.test_genericpath.TestGenericTest) (attr='ge
Martin Panter added the comment:
Hmm maybe this patch is okay. We are assuming size_t will fit more than
PY_SSIZE_T_MAX.
The alternatives I can think of would be equally ugly:
/* Risks loss of precision, e.g. 64 bit integer from floating point */
if (n < (Py_ssize_t)(PY_SSIZE_T_MAX / 1
Martin Panter added the comment:
FYI, other failures that may be different problems:
http://buildbot.python.org/all/builders/AMD64%20Snow%20Leop%203.x/builds/4930/steps/test/logs/stdio
Timeout (0:15:00)!
Thread 0x7fff71296cc0 (most recent call first):
File
"/Users/buildbot/builda
Martin Panter added the comment:
Thanks Xiang for your work on this, and Klamann for the report.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Martin Panter added the comment:
The bug should no longer be a problem in 3.6, as long as my change for Issue
26721 survives.
Here is an updated patch against 3.5.
--
versions: -Python 3.6
Added file: http://bugs.python.org/file43840/wfile-partial.v5.patch
Martin Panter added the comment:
This patch is what I had in mind for setting the documented default as
delete=b'', but using NULL internally.
I also changed it to allow the table argument to be omitted. We can change the
documentation accordingly. These are just suggestions; use
Martin Panter added the comment:
Buildbots seem happier now
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue13849>
___
___
Python-
Martin Panter added the comment:
The error message comes from Undefined Behaviour Sanitizer, which was added to
newer versions of GCC and Clang. Currently I am compiling with
./configure --with-pydebug CC="gcc -fsanitize=undefined -fno-sanitize=alignment
-fno-sanitize=shift&qu
Martin Panter added the comment:
I don’t accept that the bltinmodule.c code is similar to your patch. It gets a
size_t from calling strlen() on a string that potentially comes from outside
Python, so it is definitely valid to check for PY_SSIZE_T_MAX.
However I did find PyByteArray_Resize
Martin Panter added the comment:
The patch looks good to me (assuming it still applies). Should also remove the
“b” macro.
--
components: +Extension Modules -Library (Lib), Tests
nosy: +martin.panter
stage: patch review -> commit review
___
Pyt
Martin Panter added the comment:
V2 patch adds another fix, uncovered by recent datetime tests:
>>> a = array("B")
>>> a[:] = a
/media/disk/home/proj/python/cpython/Modules/arraymodule.c:748:5: runtime
error: null pointer passed as argument 1, which is declared
Martin Panter added the comment:
Xiang: I don’t think we need to make the tests do anything special. Just make
sure they exercise the code that handles overflows. I have been running the
test suite without any -j0 option, and I can look over the output and see the
error messages. Or if we get
Martin Panter added the comment:
unicode.patch avoids an overflow in PyUnicode_Join():
>>> size = int(sys.maxsize**0.5) + 1
>>> "".join(("A" * size,) * size)
Objects/unicodeobject.c:9927:12: runtime error: signed integer overflow: 46341
+ 2147441
Martin Panter added the comment:
FWIW I can produce two of these failures locally: the time_t OverflowError, and
the test_all() system_transitions one. Let me know if you want any more info.
In my case the message for the test_all() failure is “posix/Africa/Casablanca
system_transitions”. I
Martin Panter added the comment:
-Wall is already added (unconditionally) to $OPT above. What’s the point of
also adding it to $CFLAGS_NODIST as well? Does it have to be added to both?
--
nosy: +martin.panter
___
Python tracker
<h
Martin Panter added the comment:
I think the time for backporting to 3.2 has passed. Is there anything else to
do for this report?
--
nosy: +martin.panter
versions: -Python 3.2
___
Python tracker
<http://bugs.python.org/issue8
Martin Panter added the comment:
The three unused results in Modules/_posixsubprocess.c are probably fixed by
revision dd18cccb55b0.
The Modules/socketmodule.c pointer aliasing was addressed in 3.3 by Issue 8623,
and the Modules/_multiprocessing/multiprocessing.c type-punning has been
Martin Panter added the comment:
The Modules/_multiprocessing/multiprocessing.c code was removed in 3.3 (Issue
12981). Therefore I am calling this fixed.
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
_
Martin Panter added the comment:
I left some suggestions and questions on the code review.
--
___
Python tracker
<http://bugs.python.org/issue26851>
___
___
Pytho
Martin Panter added the comment:
I would expect isintance() to fail like this for any class, not just Enum. I
haven’t looked in your zip file, but a workaround may be to import the Enum
class from a third module into both main.py and the other file. The third
module should only get executed
Martin Panter added the comment:
Even if your patch isn’t quite ready, it may (have been) better than nothing :)
I had the idea to share stuff between Idle completion and Readline completion,
but after looking at the Idle code, it did not seem very practical in general.
But maybe you can at
New submission from Martin Panter:
$ ./python -m unittest -v test.test_{idle,tix}
. . .
test_tix (unittest.loader._FailedTest) ... ERROR
==
ERROR: test_tix (unittest.loader._FailedTest
Martin Panter added the comment:
It seems this change causes test_tix to fail for me; see Issue 27611
--
nosy: +martin.panter
___
Python tracker
<http://bugs.python.org/issue24
Changes by Martin Panter :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.o
Changes by Martin Panter :
Added file: http://bugs.python.org/file43872/issue26462.v3_regen.diff
___
Python tracker
<http://bugs.python.org/issue26462>
___
___
Python-bug
Martin Panter added the comment:
Without blocking the C implementation _datetime, I get both extremes causing
OverflowError:
>>> import datetime, time, os
>>> os.environ["TZ"] = "EST+05EDT,M3.2.0,M11.1.0"
>>> time.tzset()
>>>
Martin Panter added the comment:
With Julien’s patch applied, these are the remaining warnings:
/media/disk/home/proj/python/cpython/Doc/library/configparser.rst:240: WARNING:
Could not lex literal_block as "ini". Highlighting skipped.
/media/disk/home/proj/python/cpython/D
Martin Panter added the comment:
I _think_ the system_transitions failure only happens for 32 bit (have to test
more to be sure). (My 32-bit environment is lacking many libraries compared to
main 64-bit environment, but still uses the same filesystem etc.) First
system_transitions failure
Martin Panter added the comment:
FTR: The Mercurial bug has wandered to
<https://bz.mercurial-scm.org/show_bug.cgi?id=3761>. It suggests using “hg
--config diff.git=0 diff”.
Also, this 2011 post has some details of how the Git patch format is accepted
or not (not sure if anything has c
Martin Panter added the comment:
The documentation for recent releases looks nice and functional now, thanks. So
at least that aspect is fixed.
--
___
Python tracker
<http://bugs.python.org/issue25
Martin Panter added the comment:
I think generating it with Mercurial (and not using Mercurial’s Git patch
format) is the best way. I just left some more notes at
<https://bugs.python.org/issue13963#msg271260>.
--
___
Python tracker
Martin Panter added the comment:
I don’t understand why we have so many tests that assign the server port in the
server thread, and then use some sort of synchronization to get it to the
client thread. IMO it would be simpler in this case to do something like:
def setUp(self):
serv
Martin Panter added the comment:
The whole point of my suggestion was to bind and set the server socket to
listing mode before starting the other thread. The socketserver constructor
should do this before returning:
>>> s = DocXMLRPCServer(("localhost", 0)) # Call
Changes by Martin Panter :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Martin Panter added the comment:
Just confirming that my Casablanca failure is restricted to the 32-bit build,
though I think you already figured this out.
--
___
Python tracker
<http://bugs.python.org/issue24
Changes by Martin Panter :
Added file: http://bugs.python.org/file43885/issue26462.v4_regen.diff
___
Python tracker
<http://bugs.python.org/issue26462>
___
___
Python-bug
Martin Panter added the comment:
I’ve finished going over the latest patch. There are a couple of problems; see
the review link.
Also, why did you add the changes in Doc/library/decimal.rst? In your second
patch, you removed one of these changes, but now you have added more. They seem
to
Changes by Martin Panter :
Added file: http://bugs.python.org/file43889/doc-warnings.v3.patch
___
Python tracker
<http://bugs.python.org/issue26638>
___
___
Python-bug
Martin Panter added the comment:
The Modules/main.c cases are not errors. They are just long strings defined as
static constants, rather than literals passed in directly.
I think we can close this now. Unless people think this warning is worth using,
in which case we should find a way to work
Martin Panter added the comment:
The readline completion code does not strictly depend on on Readline, although
currently it is modelled after its quirky API. But we can change that by adding
a more general API.
In <https://bugs.python.org/issue25419#msg266320>, I suggested
Martin Panter added the comment:
GCC’s -Wformat options are documented at
<https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wformat-321>. We
already enable -Wall by default, which implicitly enables -Wformat, but not
-Wformat=2. Apparently, -Wformat=2 enables -Wformat-se
New submission from Martin Panter:
In the Generator.flatten() (Lib/email/generator.py), the code sets, among
others, the instance attributes _EMPTY (correct spelling) and _encoded_EMTPY
(misspelling). Further down in that class, _encoded_EMPTY (correct spelling) is
set as a class attribute
Martin Panter added the comment:
A few other buildbots shared this failure. It would be nice to see what the
article is that is causing the failure, but I’m fairly confident we should just
remove this part of the test.
--
stage: -> needs pa
Martin Panter added the comment:
I played with the server and group that is apparently used in the test:
>>> server = NNTP_SSL("nntp.aioe.org")
>>> [_, _, first, last, _] = server.group("fr.comp.lang.python")
>>> first
2900
>>> last
291
Martin Panter added the comment:
This version actually works :P
--
Added file: http://bugs.python.org/file43904/ending-dot.v2.patch
___
Python tracker
<http://bugs.python.org/issue19
Changes by Martin Panter :
Removed file: http://bugs.python.org/file43904/ending-dot.v2.patch
___
Python tracker
<http://bugs.python.org/issue19613>
___
___
Python-bug
Changes by Martin Panter :
Added file: http://bugs.python.org/file43905/ending-dot.v2.patch
___
Python tracker
<http://bugs.python.org/issue19613>
___
___
Python-bug
Martin Panter added the comment:
Here is a patch that fixes some more related misspellings. This includes some
test method names, and one internal C function variable.
FWIW nonexistant vs nonexistent may be a bit controversial (and neither look
particularly wrong to me), so I didn’t change
Martin Panter added the comment:
Here is a patch implementing my suggestion to unconditionally define
everything, prefixed with Py_ instead. Not tested on a normal Windows build.
--
versions: +Python 3.6 -Python 3.4
Added file: http://bugs.python.org/file43907/Py_REPARSE.patch
Martin Panter added the comment:
Interesting approach. Why two separate files, for cross-compiling and native
compiling? Why not merge them together?
Some of the other Min GW patches add stuff like the following to the
configure.ac checks. Would it make more sense to add e.g
Changes by Martin Panter :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue17594>
___
___
Python-bugs-list mailing list
Unsubscrib
Martin Panter added the comment:
The patch extends Misc/config_mingw, which is added by another patch in Issue
17594.
--
dependencies: +mingw: preset configure defaults
nosy: +martin.panter
___
Python tracker
<http://bugs.python.org/issue18
Martin Panter added the comment:
My guess is it was to avoid a conflict between the “Python/” source directory,
and the “./python” executable that may be built in the same directory. Wouldn’t
that be a problem in your case too?
--
nosy: +martin.panter
Martin Panter added the comment:
I wonder if the PYTHONPATH preprocessor definition can just be moved from
PC/pyconfig.h. It is a shame to duplicate it, and it only seems to be used in
PC/getpathp.c (if you ignore Modules/getpath.c which is unused on Windows).
--
components: +Windows
Martin Panter added the comment:
Perhaps it would make more sense to use rpartition() or rstrip(). It seems
possible to have a closing curly bracket in a namespace, but not in a element
tag or attribute name.
My guess is the __all__ failure is just a sign to add the new function to the
Martin Panter added the comment:
FWIW I suspect this technique could be expanded to prevent
Programs/_freeze_importlib from being cross-compiled, if anyone was interested.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -&g
Changes by Martin Panter :
--
title: ElementTree -- provide a way to ignore namespace in tags and seaches ->
ElementTree -- provide a way to ignore namespace in tags and searches
___
Python tracker
<http://bugs.python.org/issu
Martin Panter added the comment:
I wouldn’t mind the “host” byte order, assuming it just means use
sys.byteorder. I think I have done this a few times, both when I really wanted
the native byte order, and when I didn’t care, but assumed the native order
might be slightly more efficient (e.g
Martin Panter added the comment:
I don’t like special values. A length of minus one makes no sense, so should
trigger an exception, not some unexpected behaviour. A different data type like
None would be a bit better.
But I’m not sure this would be widely used. If you really need it you could
Martin Panter added the comment:
I agree that the signed conversion cases should be an error.
However the unsigned case would break working code that I have written for
bijective numeration. See _bytes_to_int() and _int_to_bytes() in Issue 20132,
inc-codecs.diff, for example. Since non-zero
Martin Panter added the comment:
Thanks for the patch
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
versions: +Python 2.7
___
Python tracker
<http://bugs.python.or
Changes by Martin Panter :
--
dependencies: +mingw: use main() to start execution
___
Python tracker
<http://bugs.python.org/issue17605>
___
___
Python-bugs-list m
Changes by Martin Panter :
Added file: http://bugs.python.org/file43915/issue26462.v5_regen.diff
___
Python tracker
<http://bugs.python.org/issue26462>
___
___
Python-bug
Martin Panter added the comment:
Regarding the warning in Modules/_posixsubprocess.c, I don’t see any problem.
I’m not sure exactly what it is warning about. Maybe if the cur pointer ever
gets _before_ the start of hex_errno, that could be a problem, but the loop
should stop when it reaches
Martin Panter added the comment:
V5 looks pretty good to me. With your blessing of restoring the python -q
example from v4 (see review), I think it is ready to commit.
--
stage: patch review -> commit review
___
Python tracker
&l
Martin Panter added the comment:
All the bits that I understand look okay now. :)
I am still curious what configures the preprocessor to set __ARM_ARCH to 7 (I
guess the clang -target argument?), and why we can’t set LDFLAGS at the same
time or place. Is it just more convenient this way
Martin Panter added the comment:
One last change I think needs making to the same demo, the “code-block” needs
indenting under the bullet point:
* The interpreter can now be started with a quiet option, ``-q``, to prevent
the copyright and version information from being displayed in the
Martin Panter added the comment:
Where is the code that sets the clang -target argument, or gcc -march? Is it
hidden away somewhere in the autoconf code? Do you manually set it with
‘./configure CFLAGS="-target . . ." ’?
--
___
Pyth
Martin Panter added the comment:
Usually my technique is to apply the 3.6 patch to 3.5, fix up any conflicts,
and leave the 3.6-only bits out (which get rejected by the patch process
anyway). But dedicated patch(es) may be useful. Especially for 2.7, where there
are probably independent
Martin Panter added the comment:
The test seems to be comparing ctypes and native C bit-field structures, c_int
and c_short versus native int and short. In general in C, if a bit-field has
type “int” without a signed or unsigned qualifier, it is up to the
implementation which mode is chosen
Changes by Martin Panter :
--
versions: +Python 2.7
___
Python tracker
<http://bugs.python.org/issue26462>
___
___
Python-bugs-list mailing list
Unsubscribe:
Martin Panter added the comment:
Okay, leaving this open for a 2.7 patch. BTW thanks for your work; I tried to
tackle these warnings a while ago, but I didn’t know enough about
Sphix/RST/etc. The 2.7 change should be fairly easy; I can give it a crack if
you’re not that interested in 2.7
Martin Panter added the comment:
I think this one should be fairly safe; any breakage should be pretty obvious
by watching the buildbots.
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issu
Martin Panter added the comment:
For the record, the first error without this patch is
../Python/random.c:26:1: error: unknown type name 'HCRYPTPROV'
According to
<https://msdn.microsoft.com/en-us/library/windows/desktop/aa382471%28v=vs.85%29.aspx>,
the header to use
Martin Panter added the comment:
Leading underscore is a good idea.
I have no idea if VC14 includes the structure, but I suspect if it was added
with this name, we would know because it would cause the same conflict that Min
GW caused.
--
Added file: http://bugs.python.org/file43931
Martin Panter added the comment:
Here is a quick merge with the current code.
First concern: The patch adds special support if KEY_WOW64_64KEY is not
defined, claiming to be for _WIN32_WINNT < 0x502, however these days I think
Python dropped support for Windows XP etc, so we can probably d
Martin Panter added the comment:
Here is another possible option. It is still a bit of a hack, because the
configure script inserts comments into the makefile, but this is already done
e.g. with @EXPORT_MACOSX_DEPLOYMENT_TARGET@. The advantage is we get to keep
the filenames of the
Martin Panter added the comment:
Looks like your Python 3 build is messed up. Maybe it doesn’t like running from
a different directory. I would try from the main build directory, and note the
test_bitfields has an S:
./python -m unittest -v ctypes.test.test_bitfields
What I am suggesting as
Martin Panter added the comment:
I’m not familiar with the implementation, but it does seem like this should be
fixed within _PyLong_AsByteArray().
Also, what about int.from_bytes(b"", ..., signed=True)? There are existing
tests for this case, but it seems like it should be an err
Martin Panter added the comment:
Issue 27657 has been opened about the quirk with numeric URLs
--
dependencies: +urlparse fails if the path is numeric
___
Python tracker
<http://bugs.python.org/issue22
Martin Panter added the comment:
If the problem was just Julian not being aware of urlsplit(), there is not much
to be done for this bug.
--
resolution: -> not a bug
status: open -> pending
___
Python tracker
<http://bugs.python.org/i
Martin Panter added the comment:
The main backward compatibility consideration would be Issue 754016, but don’t
agree with the changes made, and would support reverting them. The original bug
reporter wanted urlparse("1.2.3.4:80", "http") to be treated as the URL
http://1.
Martin Panter added the comment:
My view is that because the schemes are not in the documented list of supported
schemes, this is a new feature, and any documentation update should include a
“versionadded” or similar notice.
--
components: +Library (Lib)
stage: -> patch rev
Changes by Martin Panter :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> [urllib.request.HTTPRedirectHandler.http_error_302] Relative
Redirect issue
___
Python tracker
<http://bugs.python
Martin Panter added the comment:
overflow_fix_in_listextend.patch: I doubt Python supports the kinds of platform
where this overflow would be possible. It may require pointers smaller than 32
bits, or char objects larger than 8 bits. Perhaps we could just add a comment
explaining we assume
Martin Panter added the comment:
Thanks for the feedback. I did wonder about the name. Perhaps I will go with
GENERATED_COMMENT:
GENERATED_COMMENT='#'
Python/importlib_external.h: @GENERATED_COMMENT@
$(srcdir)/Lib/importlib/_bootstrap_external.py Programs/_freeze
Martin Panter added the comment:
The check in ins1() was originally added in revision b9002da46f69. I presume it
references the Python-dev thread “can this overflow (list insertion)?”
<2812145155.a7...@activestate.com>,
<https://marc.info/?l=python-dev&m=107666472818169&g
Martin Panter added the comment:
It looks like PyMem_RESIZE() would be a truer equivalent than PyMem_Calloc(),
since PyMem_MALLOC() does not initialize the memory. I would be happy with
changing to that if you want.
PyMem_Malloc() has been limited to PY_SSIZE_T_MAX since Issue 2620, although
Martin Panter added the comment:
The patch looks okay to me.
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue27660>
___
___
Python-
Martin Panter added the comment:
Looking over r60793, the overflow check at
Modules/cjkcodecs/multibytecodec.c:836 looks vulnerable to being optimized
away, because it can only detect the overflow if the line above has already
overflowed. Perhaps change PY_SSIZE_T_MAX to MAXDECPENDING. I
Martin Panter added the comment:
For the record, I presume you are referring to Issue 27435.
--
___
Python tracker
<http://bugs.python.org/issue26439>
___
___
Martin Panter added the comment:
For 2.7, adding the automatic RTLD_MEMBER mode does not seem like a bug fix to
me. Currently, I understand this code could load two separate libraries:
file = CDLL("libcrypto.a(libcrypto.so.1.0.0)")
member = CDLL("libcrypto.a(libcrypto.so.1.0.0)
Martin Panter added the comment:
If you are still figuring out Mercurial, maybe see
<https://docs.python.org/devguide/setup.html#getting-the-source-code> and
<https://docs.python.org/devguide/patch.html#tool-usage> if you hav
Martin Panter added the comment:
Depends on how you define “looks like an IP address”. Does the www.cwi.nl:80
case look like an IP address? What about “path:80” or “localhost:80”? If there
is any code relying on the bug, it may just as easily involve host name as a
numeric IP address
Martin Panter added the comment:
I also have reservations about using getaddrinfo() like this. Some potential
problems:
1. IPv4-only compatibility: On my Linux computer, getaddrinfo("localhost", 0)
returns AF_INET6 before AF_INET. Some programs, like Firefox and BSD netcat,
will t
1301 - 1400 of 4320 matches
Mail list logo
