Changes by Mark Dickinson :
--
assignee: -> rhettinger
___
Python tracker
<http://bugs.python.org/issue13121>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Mark Dickinson :
--
type: behavior -> feature request
___
Python tracker
<http://bugs.python.org/issue13121>
___
___
Python-bugs-list mailing list
Un
Mark Hammond added the comment:
My apologies Eric - I had completely overlooked those tests. Attaching a new
patch with a test. Note the existing test doesn't actually perform a build so
the new test also doesn't, but it does check the core logic (ie, that a
manifest with only
Mark Dickinson added the comment:
I'm warming to this idea.
We already have several round-to-integer functions (but not
round-to-an-arbitrary-number-of-decimal-places) available in the math module
(under the names floor, ceil and trunc). This *does* seem to be a common need,
and it&#
Mark Hammond added the comment:
Thanks for the review. One note:
| +def manifest_setup_ldargs
| I’d make all new methods private ones (i.e. leading underscore).
They aren't strictly private and are designed to be overridden by subclasses
(although in practice, subclassing the com
Mark Dickinson added the comment:
Fixed. Thanks for the report!
--
nosy: +mark.dickinson
resolution: -> fixed
status: open -> closed
versions: +Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/i
Changes by Mark Dickinson :
--
assignee: docs@python -> mark.dickinson
___
Python tracker
<http://bugs.python.org/issue13145>
___
___
Python-bugs-list mai
Mark Hammond added the comment:
New version of the patch with the small tweaks requested plus a NEWS entry.
--
Added file: http://bugs.python.org/file23400/bug-7833-tweaks-plus-news.patch
___
Python tracker
<http://bugs.python.org/issue7
Mark Hammond added the comment:
My experience is that for VS2008 at least, the /MANIFESTFILE: option seems to
be ignored if there is nothing to put in the manifest, and this tends to be
true if you use a static CRT instead of the DLL based one (ie, if you use /MT)
Issue 7833 has a patch
Mark Bucciarelli added the comment:
Something strange is going on.
I just built pysql 2.6.3 from source, and now my unit test gives the expected
"IntegrityError: foreign key constraint failed" message.
poq, what do you get when you run this script:
import sqlite3
print "sqlit
Mark Bucciarelli added the comment:
BAD : sqlite3.sqlite_version_info = (3, 6, 12)
GOOD: sqlite3.sqlite_version_info = (3, 7, 4)
GOOD: sqlite3.sqlite_version_info = (3, 7, 8)
I guess this is the cause of the different behavior.
sqlite_version_info is the version of the underlying sqlite3
Mark Hammond added the comment:
I pushed the changes to 2.7, 3.2 and 3.3. I'm happy to help with
distutils2/packaging but I'll need to do that later once I work out where to
start :) Therefore I'm not yet closing this issue.
--
___
Changes by Mark Dickinson :
--
nosy: +mark.dickinson
___
Python tracker
<http://bugs.python.org/issue13200>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Mark Dickinson :
--
components: +Interpreter Core
nosy: +mark.dickinson
stage: -> patch review
type: -> feature request
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/i
Mark Dickinson added the comment:
Nice patch! I put some comments on Rietveld.
--
___
Python tracker
<http://bugs.python.org/issue13201>
___
___
Python-bug
Changes by Mark Dickinson :
--
assignee: -> mark.dickinson
___
Python tracker
<http://bugs.python.org/issue13201>
___
___
Python-bugs-list mailing list
Un
Mark Dickinson added the comment:
The new patch looks fine; I'd still like to have the more explicit reference
counting in range_hash (see replies on Rietveld).
A few more things:
- The patch needs a Misc/NEWS entry before committing; it probably deserves a
line in Doc/whatsnew/3.
Changes by Mark Bucciarelli :
--
resolution: -> invalid
___
Python tracker
<http://bugs.python.org/issue12997>
___
___
Python-bugs-list mailing list
Unsubscri
Mark Dickinson added the comment:
Your 'i = i + 1' is at the wrong indentation level.
--
nosy: +mark.dickinson
resolution: -> invalid
status: open -> closed
___
Python tracker
<http://bugs.py
Mark Hammond added the comment:
I don't think a buildbot will be necessary - like the earlier compilers, they
may have basic support but they don't all get buildbot support. The "problem"
isn't the lack of ability/will to get things working with VS2010 - it is more
Mark Hammond added the comment:
The first chunk of that patch is for when pythonhome==NULL. There is also a
similar block just under it when MS_WINDOWS is not defined. While I don't know
in which cases this will be built without that define, it looks as though the
*buf++ = DELIM; s
Mark Dickinson added the comment:
I get a test failure in test_hash (which is checking exactly that the
hash(range) uses the default object hash, so that test is clearly out of date
now). Apart from that, the latest patch looks good to me.
I'm going to give this a couple of days in
Changes by Mark Dickinson :
--
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue9574>
___
___
Python-bugs-list mailing list
Un
Mark Dickinson added the comment:
What about
def total_minutes(td):
return td / datetime.timedelta(minutes=1)
?
--
___
Python tracker
<http://bugs.python.org/issue5
Mark Dickinson added the comment:
I've taken the liberty of updating the patch, with a few minor changes:
range_equality -> range_equals (like range_contains)
move identity check into range_equals
move comments before the code they describe (PEP7)
add whatsnew entry
remove check th
Mark Dickinson added the comment:
Hmm. Why does my patch not get a 'review' button?
--
___
Python tracker
<http://bugs.python.org/issue13201>
___
___
Mark Dickinson added the comment:
Ah, there it is. Never mind. :-)
--
___
Python tracker
<http://bugs.python.org/issue13201>
___
___
Python-bugs-list mailin
Mark Dickinson added the comment:
Thanks for the comments. Here's an updated patch, that actually makes use of
the pure Python version to test the built-in int-to-float conversion.
--
versions: -Python 2.7, Python 3.2
Added file: http://bugs.python.org/file
Mark Dickinson added the comment:
> In most cases, global variables Py_Zero and Py_One would be enough to
> simplify this kind of code.
Agreed.
--
___
Python tracker
<http://bugs.python.org/i
Changes by Mark Dickinson :
--
resolution: -> fixed
stage: commit review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Mark Dickinson :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Mark Dickinson added the comment:
Closing as "won't fix", for reasons given above.
--
resolution: -> wont fix
status: open -> closed
___
Python tracker
<http://b
Mark Dickinson added the comment:
I've fixed some of the inaccurate comments in Objects/longobject.c, for the
default branch; I'm still looking at the Doc update.
This really is a bit of a mess, especially for cases like PyLong_AsVoidPtr,
which can either end up calling PyLong_As
Mark Dickinson added the comment:
> It could be fun to remove these conversions and see how much of the
> test-suite fails. :-)
... On my machine, just test_ctypes and test_getargs2, as it turns out.
--
___
Python tracker
<http://bugs.p
Mark Dickinson added the comment:
New changeset 221638ba5d2a by Mark Dickinson in branch 'default':
Issue #13248, issue #8540: Remove deprecated Context._clamp attribute from
Decimal module.
http://hg.python.org/cpython/rev/22
Mark Hammond added the comment:
I can't explain why this might be happening given the Python dll is still build
against vc9 - I'm guessing this can't be reproduced without vs10 in the mix?
Re making the feature optional - distutils doesn't really lend itself to
customizi
Changes by Mark Dickinson :
--
priority: normal -> critical
stage: -> needs patch
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/i
Mark Dickinson added the comment:
Patch looks good to me.
--
nosy: +mark.dickinson
___
Python tracker
<http://bugs.python.org/issue13343>
___
___
Python-bug
Mark Dickinson added the comment:
I can't reproduce this:
Python 2.7.2 |EPD 7.1-2 (32-bit)| (default, Jul 3 2011, 15:40:35)
[GCC 4.0.1 (Apple Inc. build 5493)] on darwin
Type "packages", "demo" or "enthought" for more information.
>>> from random
Mark Dickinson added the comment:
> What do you suggest? Doing it in _PyEval_SliceIndex() in 2.7 is
> problematic, as we don't want x[None:2], right? :)
Eh? Don't we already have this?
Python 2.7.2 (default, Aug 22 2011, 13:53:27)
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)
Mark Dickinson added the comment:
> it would be convenient if low=high=mode returned low (or mode or high)
Yes, I agree that random.triangular should degrade gracefully, in the same way
that random.uniform does.
--
___
Python tracker
&l
Mark Dickinson added the comment:
How would you suggest refactoring this?
For that example, I'd prefer not to remove the repetition; as it is, the code
is clean and clear. Eliminating the repetition would involve adding an extra
layer of indirection, making the code in one of
Mark Dickinson added the comment:
Sorry, I'm closing this as rejected. It might possibly have been better to
write the code this way to begin with, but the code is already there, it's
working, and there's little to be gained by 'fixing' it at this po
Changes by Mark Dickinson :
--
nosy: +mark.dickinson
___
Python tracker
<http://bugs.python.org/issue11937>
___
___
Python-bugs-list mailing list
Unsubscribe:
Mark Dickinson added the comment:
Yep, there's an oddity here that's directly inherited from C's sprintf family
of functions, namely that in %e-style formatting you give the number of digits
after the point (= one less than the total number of significant digits), and
in %g-s
Mark Dickinson added the comment:
> Maybe a note describing that %g is different from the others in this regard?
-1 from me; I don't really see that that would improve the documentation.
Maybe that's just me, but I expect reference documentation to be clean, and
uncluttered
Changes by Mark Dickinson :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue12245>
___
___
Python-bugs-list
Changes by Mark Dickinson :
--
assignee: mark.dickinson ->
___
Python tracker
<http://bugs.python.org/issue7433>
___
___
Python-bugs-list mailing list
Un
Mark Dickinson added the comment:
Closing as won't fix. Even deprecation doesn't seem worth the effort here.
--
resolution: -> wont fix
status: open -> closed
___
Python tracker
<http://bugs.p
Changes by Mark Dickinson :
--
versions: +Python 3.3 -Python 2.7, Python 3.2
___
Python tracker
<http://bugs.python.org/issue2813>
___
___
Python-bugs-list mailin
Mark Dickinson added the comment:
Status update: all the reported errors from the Objects/ directory have been
fixed in the default branch (many of these were fixed recently as part of
making sure that the test-suite runs under Clang's -ftrapv option), or are out
of date. I haven'
Mark Dickinson added the comment:
See also issue #1621.
--
___
Python tracker
<http://bugs.python.org/issue9530>
___
___
Python-bugs-list mailing list
Unsub
Mark Dickinson added the comment:
The issues reported for the datetime, array, itertools and math modules are
also already fixed. That just leaves the following two of the reported issues
outstanding:
: Op: <<=, Reason :
Signed Left Shift Error: Right operand is negative or is g
Mark Dickinson added the comment:
See also issue #9530.
--
___
Python tracker
<http://bugs.python.org/issue1621>
___
___
Python-bugs-list mailing list
Unsub
Changes by Mark Dickinson :
--
versions: +Python 3.2, Python 3.3 -Python 2.6
___
Python tracker
<http://bugs.python.org/issue13433>
___
___
Python-bugs-list mailin
Mark Dickinson added the comment:
> I'd be happy to re-run the tests sometime.
Yes, please! Alternatively, if there are easy instructions for us to re-run
these tests, that would be valuable, too. Do I understand correctly that you
have a publicly available extension to LLVM
Mark Dickinson added the comment:
+1 to kwargs support in sched. I've also ended up modifying sched.py to
support this in the past.
--
nosy: +mark.dickinson
___
Python tracker
<http://bugs.python.org/is
New submission from Mark Dickinson :
Docs nit: at http://docs.python.org/dev/library/stdtypes.html#boolean-values
we have
"""
The built-in function bool() can be used to cast any value to a Boolean ...
"""
It's a little unusual to talk about casting in Py
Mark Hammond added the comment:
A manifest seems to be currently created fine - can you provide steps to
reproduce the problem you see?
--
___
Python tracker
<http://bugs.python.org/issue13
Mark Dickinson added the comment:
Given that we typically need at least 4 bytes just for the PyObject * pointer
for each item in a list, I guess real lists are safe.
But how about list-like objects, implementing __len__ and __getitem__? The
following appears to run forever on my machine
Mark Dickinson added the comment:
> Does Python really need yet another multiprecision library?
It's not really another library: it's a reimplementation of the existing
decimal library in C. The decimal library is *hugely* valuable to the
financial world, but its slowne
Mark Dickinson added the comment:
See also issue #13496.
--
___
Python tracker
<http://bugs.python.org/issue9530>
___
___
Python-bugs-list mailing list
Unsub
Mark Dickinson added the comment:
Well, it's sort of documented implicitly: from
http://docs.python.org/c-api/intro.html#exceptions
"In general, when a function encounters an error, it sets an exception,
discards any object references that it owns, and returns an error indicator
Changes by Mark Dickinson :
--
nosy: +mark.dickinson
___
Python tracker
<http://bugs.python.org/issue13535>
___
___
Python-bugs-list mailing list
Unsubscribe:
Mark Dickinson added the comment:
The 'self.bit_length() >= bits' condition for to_unsigned doesn't look right to
me.
E.g., if bits == 32, I'd expect the acceptable range of values to be
range(-2**31, 2**31)---i.e., including -2**31, but excluding 2**31.
Mark Dickinson added the comment:
On the feature request itself, I have to say that I'm unconvinced. Doing x %
(2**32) seems good enough to me, in situations where you don't need the bounds
checking. (And it's not clear to me that needing the bounds checks is the more
c
Changes by Mark Dickinson :
--
nosy: +mark.dickinson
___
Python tracker
<http://bugs.python.org/issue13534>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Mark Dickinson :
--
versions: -Python 3.4
___
Python tracker
<http://bugs.python.org/issue13534>
___
___
Python-bugs-list mailing list
Unsubscribe:
Mark Dickinson added the comment:
Thanks for the report, and all the sleuthing. It's always good to see Python's
test suite expose C library (or C compiler) bugs. :-)
I propose closing this as 'won't fix': I certainly wouldn't want to add
workarounds in the
Changes by Mark Dickinson :
--
assignee: -> mark.dickinson
___
Python tracker
<http://bugs.python.org/issue13534>
___
___
Python-bugs-list mailing list
Un
Mark Dickinson added the comment:
Style nit: how about
'except ValueError as e'
instead of
'except ValueError, e'
(Actually, why do we need e?)
--
nosy: +mark.dickinson
___
Python tracker
<http://bug
Mark Dickinson added the comment:
Isn't the documentation that you refer to about *nested* list comprehensions,
rather than list comprehensions with multiple 'for' clauses?
E.g.,:
[number for row in matrix for number in row]
is not a nested list comprehension: it&
Mark Dickinson added the comment:
Mind you, I'm not at all sure about that use of 'apprehension'...
--
___
Python tracker
<http://bugs.pyt
Mark Dickinson added the comment:
+1 for fixing this.
--
nosy: +mark.dickinson
___
Python tracker
<http://bugs.python.org/issue13573>
___
___
Python-bugs-list m
Mark Shannon added the comment:
Please reopen this bug as the fix is wrong.
This fix merely hides the symptoms of _PyType_Lookup returning a dead object,
by calling PyType_Modified() frequently, thus ensuring the type method cache is
almost always invalidated.
This results in a significant
Mark Dickinson added the comment:
Agree with the -1s.
--
___
Python tracker
<http://bugs.python.org/issue13603>
___
___
Python-bugs-list mailing list
Unsubscribe:
Mark Shannon added the comment:
Absolutely. subtype_dealloc deals with deallocation of subtype
*instances*, not the types themselves.
> Maybe we can try and explore the reference graph again?
This sort of thing is one of the reasons that the cycle GC does not call
any finalisers. Attempt
Mark Shannon added the comment:
What's happening is that the cycle GC calls type_clear to clear the type, but
the method-cache is not invalidated.
I have added a call to PyType_Modified in type_clear (as well as type_set_name
and type_set_qualname, which also modify the type).
Pat
Mark Shannon added the comment:
Beat me to it, Antoine!
Don't forget type_set_name and type_set_qualname.
--
___
Python tracker
<http://bugs.python.org/is
Mark Shannon added the comment:
Antoine Pitrou wrote:
> Antoine Pitrou added the comment:
>
>> I have added a call to PyType_Modified in type_clear (as well as
>> type_set_name and type_set_qualname, which also modify the type).
>
> Can __name__ and __qualname__
New submission from Mark Shannon :
test_clear_dict_in_ref_cycle in test_module only works by coincidence,
if the name of the variable on line 77 is changed from 'a' to 'x', then the
test fails.
This is a result of the arbitrary ordering of removals of values from a modules
Mark Dickinson added the comment:
> Can this be fixed?
Not without breaking backwards compatibility, I would think.
--
nosy: +mark.dickinson
___
Python tracker
<http://bugs.python.org/issu
Mark Dickinson added the comment:
Did you have specific changes in mind?
While we're still maintaining 2.x and 3.x code in parallel, there's a benefit
to not having the versions of decimal.py diverge too much. Given that the
2.3-compatible code isn't actually broken, I&
Changes by Mark Shannon :
--
nosy: +Mark.Shannon
___
Python tracker
<http://bugs.python.org/issue13703>
___
___
Python-bugs-list mailing list
Unsubscribe:
Mark Shannon added the comment:
What is the mechanism by which the attacker can determine the seeds?
The actual hash value is not directly observable externally.
The attacker can only determine the timing effects of multiple
insertions into a dict, or have I missed something?
> - h
Mark Shannon added the comment:
But that's not the issue we are supposed to be dealing with.
A single (genuinely random) seed will deal with the attack described in
the talk and it is (almost) as fast as using 0 as a seed.
Why make things complicated dealing with a hypothetical pr
Mark Shannon added the comment:
I agree.
+1 for strings. -0 for numbers.
This might cause problems with dict subclasses and the like,
so I'm -1 on this.
--
___
Python tracker
<http://bugs.python.org/is
Mark Shannon added the comment:
Without the context, that last message didn't make much sense.
I agree with Terry that we should copy Perl and Ruby (for strings).
I'm -1 on hash() returning a different value than dict uses internally.
--
Mark Dickinson added the comment:
No, but they take tuples:
>>> 'abcd'.endswith(('a', 'b'))
False
>>> 'abcd'.endswith(('c', 'd'))
True
Suggest closing as out of date.
--
nosy: +
Mark Shannon added the comment:
>>> * the method would need to be implemented for all hashable Python types
>> It was already discussed, and it was said that only hash(str) need to
>> be modified.
>
> Really ? What about the much simpler attack on integer hash val
Mark Dickinson added the comment:
[Antoine]
> Also, how about false positives? Having legitimate programs break
> because of legitimate data would be a disaster.
This worries me, too.
[MAL]
> Yes, which is why the patch should be disabled by default (using
> an env var) in dot-re
Mark Dickinson added the comment:
Here's a patch. Stefan, could you please review?
--
keywords: +patch
Added file: http://bugs.python.org/file22068/issue12080.patch
___
Python tracker
<http://bugs.python.org/is
Changes by Mark Dickinson :
--
stage: -> commit review
___
Python tracker
<http://bugs.python.org/issue12080>
___
___
Python-bugs-list mailing list
Unsubscri
Mark Dickinson added the comment:
Here's a slightly improved version that adds guards against computing 10**ye
for large ye in the case y < 0, ye > 0.
--
Added file: http://bugs.python.org/file22069/issue12080_v2.patch
___
Python tra
Changes by Mark Nottingham :
--
nosy: +mnot
___
Python tracker
<http://bugs.python.org/issue7827>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Mark Dickinson :
In Python 2.6 and 2.7, str.translate accepts None as a first argument. That's
documented in the docs, but not in the str.translate docstring.
--
assignee: docs@python
components: Documentation
messages: 136720
nosy: docs@python, mark.dick
New submission from Mark Hammond :
Probably in all versions, but certainly in 2.7.
If you create an installer with bdist_wininst and specify an install_script,
that script is not run on uninstallation.
See attached test case: setup.py specifies an install_script which just appends
argv to
Changes by Mark Hammond :
Added file: http://bugs.python.org/file22161/hello.py
___
Python tracker
<http://bugs.python.org/issue12200>
___
___
Python-bugs-list mailin
Changes by Mark Hammond :
Added file: http://bugs.python.org/file22162/hello-install.py
___
Python tracker
<http://bugs.python.org/issue12200>
___
___
Python-bugs-list m
Changes by Mark Hammond :
--
assignee: tarek -> mhammond
keywords: +patch
stage: -> patch review
versions: +Python 2.7, Python 3.2, Python 3.3, Python 3.4
Added file: http://bugs.python.org/file22205/issue12200.patch
___
Python tracker
401 - 500 of 12223 matches
Mail list logo
