[issue1798] Add ctypes calling convention that allows safe access of errno

2008-05-21 Thread Maciek Fijalkowski
Maciek Fijalkowski <[EMAIL PROTECTED]> added the comment: thread local storage sounds also a bit weird to me. Errcheck sounds way better, I would also like to have errcheck as a possible default on library, when calling CDLL constructor. This would be a convinient way of specifying

[issue1798] Add ctypes calling convention that allows safe access of errno

2008-05-23 Thread Maciek Fijalkowski
Maciek Fijalkowski <[EMAIL PROTECTED]> added the comment: On the one hand, no it does not hurt when we're resetting errno before any call. On the other hand if we try hard "to be like C", it's a bit strange that we always reset errno (which is on the other hand very g

[issue2953] _zip_directory_cache untested and undocumented

2008-05-23 Thread Maciek Fijalkowski
New submission from Maciek Fijalkowski <[EMAIL PROTECTED]>: _zip_directory_cache has no single test nor piece of documentation. The only place where it's mentioned is a call to method .clear() on it in tests. Besides, it can be whatever. Despite _ prefix, which I would consider to

[issue2982] more tests for pyexpat

2008-08-18 Thread Maciek Fijalkowski
Maciek Fijalkowski <[EMAIL PROTECTED]> added the comment: Next wave of tests - error handling. More specifically all errors that might happen during parsing XML and reported by parser itself. ___ Python tracker <[EMAIL PROTECTED]> <http://

[issue3931] codecs.charmap_build is untested and undocumented

2008-09-22 Thread Maciek Fijalkowski
New submission from Maciek Fijalkowski <[EMAIL PROTECTED]>: Although it doesn't start with _ and is definitely necessary as codecs call it. -- components: Library (Lib) messages: 73569 nosy: fijal severity: normal status: open title: codecs.charmap_build is untested and u

[issue8276] useless PyEval_CallObject function

2010-03-31 Thread Maciek Fijalkowski
New submission from Maciek Fijalkowski : In ceval.c there is such code: PyObject * PyEval_CallObject(PyObject *func, PyObject *arg) { return PyEval_CallObjectWithKeywords(func, arg, (PyObject *)NULL); } #define PyEval_CallObject(func,arg) \ PyEval_CallObjectWithKeywords(func

[issue8276] useless PyEval_CallObject function

2010-03-31 Thread Maciek Fijalkowski
Maciek Fijalkowski added the comment: Yeah, I meant the function. Sorry for not being specific enough. I suppose the function is there to preserve ABI, but definitely code needed recompilation since 2007. -- ___ Python tracker <h

[issue1838] Ctypes C-level infinite recursion

2008-01-16 Thread Maciek Fijalkowski
New submission from Maciek Fijalkowski: Code in example abuses the fact that _as_parameter_ is passed recursively. Not sure if this is for fixing or not. -- components: Extension Modules files: crash.py messages: 59993 nosy: arigo, fijal severity: normal status: open title: Ctypes C

[issue1875] "if 0: return" not raising SyntaxError

2008-01-19 Thread Maciek Fijalkowski
Changes by Maciek Fijalkowski: -- nosy: +cfbolz, fijal __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1875> __ ___ Python-bugs-list mailing list Unsubs

[issue1881] increase parser stack limit

2008-01-22 Thread Maciek Fijalkowski
Maciek Fijalkowski added the comment: Attached file that handles stack overflow slightly better (from pypy). It really measures stack size, not some arbitrary limit of python calls. Yes, this have slightly bigger overhead than just passing around number, but as a side effect solves Lib/test

[issue1881] increase parser stack limit

2008-01-22 Thread Maciek Fijalkowski
Maciek Fijalkowski added the comment: Wuaaa, sorry Added file: http://bugs.python.org/file9259/stack.h __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1881> __ __

[issue1881] increase parser stack limit

2008-01-22 Thread Maciek Fijalkowski
Maciek Fijalkowski added the comment: PyPy is all MIT, no problem at license. This should not be plugged into the parser, this is not a patch (especially not a patch for the parser). This file is rather to illustrate possible solution to solve the problem of sys.setrecursionlimit not being a

[issue1326] "internal" zipimport.zipimporter feature untested

2008-01-24 Thread Maciek Fijalkowski
Maciek Fijalkowski added the comment: There is another untested and undocumented attribute called prefix on zipimporter objects. __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/

[issue2532] file that breaks 2to3 (despite being correct python)

2008-04-01 Thread Maciek Fijalkowski
New submission from Maciek Fijalkowski <[EMAIL PROTECTED]>: Infinite recursion problem. I know this file is obscure, but it's still pretty valid python. -- assignee: collinwinter components: 2to3 (2.x to 3.0 conversion tool) files: ssl.py messages: 64829 nosy: collinwi

[issue4946] Lib/test/test__locale uses is to compare strings

2009-01-14 Thread Maciek Fijalkowski
New submission from Maciek Fijalkowski : this is at least a bad practice. It also might break silently at any point. -- components: Library (Lib), Tests files: out.diff keywords: patch messages: 79846 nosy: fijal severity: normal status: open title: Lib/test/test__locale uses is to

[issue4990] test_codeccallbacks.CodecCallbackTest.test_badhandlerresult is not testing anything

2009-01-18 Thread Maciek Fijalkowski
New submission from Maciek Fijalkowski : the reason is that it of course raises TypeError, since number of args is wrong. -- files: out.diff keywords: patch messages: 80121 nosy: fijal severity: normal status: open title: test_codeccallbacks.CodecCallbackTest.test_badhandlerresult is

[issue5068] tarfile loops forever on broken input

2009-01-26 Thread Maciek Fijalkowski
New submission from Maciek Fijalkowski : I have troubles actually finding such a file, but I encountered it at least once (file is gone by now though). The lines in question are for bz2 compression: in _BZ2Proxy.read: try: raw = self.fileobj.read(self.blocksize

[issue5578] unqualified exec in class body

2009-03-27 Thread Maciek Fijalkowski
New submission from Maciek Fijalkowski : A patch and a test. The problem is a bit broader - what about import * etc? Patch fixes that, but without a test. -- components: Interpreter Core files: out.diff keywords: patch messages: 84259 nosy: fijal severity: normal status: open title

[issue2953] _zip_directory_cache untested and undocumented

2009-03-29 Thread Maciek Fijalkowski
Maciek Fijalkowski added the comment: Seems I meant setuptools indeed. Note that brett's importlib contains some tests for _zip_directory_cache. -- ___ Python tracker <http://bugs.python.org/i

[issue2953] _zip_directory_cache untested and undocumented

2009-04-05 Thread Maciek Fijalkowski
Maciek Fijalkowski added the comment: The bug with this is that setuptools uses it (and even relies on what is there and in what order), while it has no single tests and no documentation. -- ___ Python tracker <http://bugs.python.org/issue2

[issue2953] _zip_directory_cache untested and undocumented

2009-04-05 Thread Maciek Fijalkowski
Maciek Fijalkowski added the comment: it == _zip_directory_cache -- ___ Python tracker <http://bugs.python.org/issue2953> ___ ___ Python-bugs-list mailin

[issue2953] _zip_directory_cache untested and undocumented

2009-04-05 Thread Maciek Fijalkowski
Maciek Fijalkowski added the comment: setuptools at least deletes stuff from _zip_directory_cache (via _uncache function in easy_install.py). it also iterates over it and checks for existance of elements. What about documenting details about _zip_directory_cache: * does it need to be a normal

[issue3051] heapq change breaking compatibility

2010-05-17 Thread Maciek Fijalkowski
Maciek Fijalkowski added the comment: Hello. I would like to complain. It was decided at some point some time ago that both pure-python and C version should run against the same test suite and should not have any differencies. The reasoning behind it is that other python implementations

[issue3051] heapq change breaking compatibility

2010-05-18 Thread Maciek Fijalkowski
Maciek Fijalkowski added the comment: I cannot honestly make much sense from what you said. My concern is whether python and C version behaves the same or not. It seems that in current version they intentionally behave differently, for simplicity and it's against policy of having the