New submission from Lysandros Nikolaou :
Inspired by bpo-41064, I sat down to try and find problems with f-string
locations in the new parser. I was able to come up with a way to compute the
locations of the f-string expressions that I think is more consistent and
allows us to delete all the
Change by Lysandros Nikolaou :
--
keywords: +patch
pull_requests: +20225
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21054
___
Python tracker
<https://bugs.python.org/issu
Change by Lysandros Nikolaou :
--
title: Pre-feed the parser with the f-string location -> Pre-feed the parser
with the f-string expression location
___
Python tracker
<https://bugs.python.org/issu
New submission from Lysandros Nikolaou :
It's relatively easy to identify if a SyntaxError occurs when parsing an
fstring expression or not. The idea is to slightly change the error message to
start with "f-string: " when it does (in the same way in which SyntaxError
messages
Lysandros Nikolaou added the comment:
> My only reservation would be: if the parsing of f-strings is moved into the
> parser, would it be possible to maintain the error new messages?
Probably without a single change.
--
___
Python tracker
Change by Lysandros Nikolaou :
--
keywords: +patch
pull_requests: +20250
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21084
___
Python tracker
<https://bugs.python.org/issu
New submission from Lysandros Nikolaou :
Brandt found this out while testing his implementation of the `match`
statement. When a list or tuple are followed by a colon without an annotation,
the old parser used to say "invalid syntax", while the new parser considers
this an anno
Change by Lysandros Nikolaou :
--
keywords: +patch
pull_requests: +20320
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21160
___
Python tracker
<https://bugs.python.org/issu
Change by Lysandros Nikolaou :
--
pull_requests: +20330
pull_request: https://github.com/python/cpython/pull/21172
___
Python tracker
<https://bugs.python.org/issue41
Change by Lysandros Nikolaou :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Lysandros Nikolaou :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Lysandros Nikolaou :
The f-string parser uses the raw allocator in various places. We had a very
very brief discussion about this with Pablo and he suggested to change the new
parser and the hand-written f-string parser to use the pymalloc allocator.
Eric, is there a
Change by Lysandros Nikolaou :
--
keywords: +patch
pull_requests: +20331
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21173
___
Python tracker
<https://bugs.python.org/issu
Lysandros Nikolaou added the comment:
Ok, I've opened a PR. Should be backport this to previous versions as well?
--
___
Python tracker
<https://bugs.python.org/is
Lysandros Nikolaou added the comment:
Should we maybe backport this to 3.9 as well?
--
___
Python tracker
<https://bugs.python.org/issue41084>
___
___
Python-bug
Change by Lysandros Nikolaou :
--
pull_requests: +20339
pull_request: https://github.com/python/cpython/pull/21183
___
Python tracker
<https://bugs.python.org/issue41
Change by Lysandros Nikolaou :
--
pull_requests: +20340
pull_request: https://github.com/python/cpython/pull/21184
___
Python tracker
<https://bugs.python.org/issue41
Change by Lysandros Nikolaou :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Lysandros Nikolaou :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Lysandros Nikolaou :
--
pull_requests: +20366
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/21212
___
Python tracker
<https://bugs.python.org/issu
Lysandros Nikolaou added the comment:
> What do either of you think? Can the new parser handle it better?
Pablo, correct me if I'm wrong, but I think that the parser has nothing to do
with this. It's not the parser that produces this SyntaxError, it's some later
compilat
Lysandros Nikolaou added the comment:
> If I understand correctly, Nick is talking about modifying the different
> iterations for different errors in codeop no?
I was talking about msg200936, where Nick proposed to just hardcode a check for
nonlocal SyntaxErrors in codeop._maybe_c
Change by Lysandros Nikolaou :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Lysandros Nikolaou added the comment:
Thanks, Victor!
The fix is merged, so I'm closing this again.
--
___
Python tracker
<https://bugs.python.org/is
Lysandros Nikolaou added the comment:
> From what I understand, "checking for two or more hanging INDENTS" and,
> "hardcoding a check for nonlocal SyntaxErrors in codeop._maybe_compile" are
> two different solutions, right? If yes, do we have an answer to
Lysandros Nikolaou added the comment:
I feel that I wasn't clear at all in my previous responses, so let me try to
have another go at explaining how I see this:
We have two distinct problems, that are totally unrelated to one another:
1) nonlocal should raise when it's not i
Lysandros Nikolaou added the comment:
That's right, but the SyntaxError message is somewhat confusing. At least the
fact that the SyntaxError message is some for both of
def a():
def b():
nonlocal x
and
def a():
nonlocal x
seems a bit misleadin
Lysandros Nikolaou added the comment:
some -> same
--
___
Python tracker
<https://bugs.python.org/issue19335>
___
___
Python-bugs-list mailing list
Unsubscrib
Lysandros Nikolaou added the comment:
> I still see this problem with 3.10, which I thought might have fixed this.
Nope, that's still true in 3.10.
>I'm working on overhauling how these are calculated. But it's complex, and is
>taking a while.
In short, the Formatted
Lysandros Nikolaou added the comment:
Pablo, I can do that as well, if you don't have the time.
--
___
Python tracker
<https://bugs.python.org/is
Lysandros Nikolaou added the comment:
Pablo, on second thought, should we maybe change the assertion to
`assert(name_len > 0)`?
--
___
Python tracker
<https://bugs.python.org/issu
Change by Lysandros Nikolaou :
--
pull_requests: +20509
pull_request: https://github.com/python/cpython/pull/21364
___
Python tracker
<https://bugs.python.org/issue41
Lysandros Nikolaou added the comment:
> Can you prepare a PR?
Done.
--
___
Python tracker
<https://bugs.python.org/issue41215>
___
___
Python-bugs-list mai
Lysandros Nikolaou added the comment:
New changeset 782f44b8fb07ec33cee148b2b6b4cf53024fe0cd by Lysandros Nikolaou in
branch 'master':
bpo-41215: Make assertion in the new parser more strict (GH-21364)
https://github.com/python/cpython/commit/782f44b8fb07ec33cee148b2b6b4cf
Change by Lysandros Nikolaou :
--
pull_requests: +20783
pull_request: https://github.com/python/cpython/pull/21642
___
Python tracker
<https://bugs.python.org/issue40
Lysandros Nikolaou added the comment:
I propose that we take no further action and close this.
--
___
Python tracker
<https://bugs.python.org/issue41
Change by Lysandros Nikolaou :
--
nosy: +lys.nikolaou
___
Python tracker
<https://bugs.python.org/issue7>
___
___
Python-bugs-list mailing list
Unsubscribe:
Lysandros Nikolaou added the comment:
I had a look at this. I have been testing with the input a{x}, which faces the
same problem.
It's actually because of an invalid_* rule. The call stack looks like this:
...
invalid_comprehension_rule(Parser * p)
(/home/lysnikolaou/repos/cpython/P
Change by Lysandros Nikolaou :
--
keywords: +patch
pull_requests: +21195
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/22111
___
Python tracker
<https://bugs.python.org/issu
Lysandros Nikolaou added the comment:
New changeset c111355480ff51b50a671679c5099f534cb01cae by Pablo Galindo in
branch 'master':
bpo-41826: Fix compiler warnings in test_peg_generator (GH-22455)
https://github.com/python/cpython/commit/c111355480ff51b50a671679c5099f
Change by Lysandros Nikolaou :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Lysandros Nikolaou added the comment:
Pablo, can this be closed now that PR3 is merged?
--
___
Python tracker
<https://bugs.python.org/issue41746>
___
___
Lysandros Nikolaou added the comment:
This c
--
nosy: +lys.nikolaou
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Lysandros Nikolaou :
--
Removed message: https://bugs.python.org/msg378963
___
Python tracker
<https://bugs.python.org/issue41667>
___
___
Python-bug
Change by Lysandros Nikolaou :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue40335>
___
___
Python-bugs-
Lysandros Nikolaou added the comment:
I'm closing this since this specific issue seems to be fixed both in master and
in 3.9. Anthony, feel free to re-open it, in case I've missed something.
--
___
Python tracker
<https://bu
Lysandros Nikolaou added the comment:
Let me look into that.
--
assignee: -> lys.nikolaou
nosy: +lys.nikolaou
___
Python tracker
<https://bugs.python.org/issu
Change by Lysandros Nikolaou :
--
pull_requests: +21743
pull_request: https://github.com/python/cpython/pull/22786
___
Python tracker
<https://bugs.python.org/issue41
Change by Lysandros Nikolaou :
--
nosy: +lys.nikolaou
___
Python tracker
<https://bugs.python.org/issue33754>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Lysandros Nikolaou :
--
pull_requests: +21806
pull_request: https://github.com/python/cpython/pull/22864
___
Python tracker
<https://bugs.python.org/issue41
Lysandros Nikolaou added the comment:
New changeset 2e5ca9e3f68b33abb7d2c66d22ffc18dec40641a by Lysandros Nikolaou in
branch 'master':
bpo-41746: Cast to typed seqs in CHECK macros to avoid type erasure (GH-22864)
https://github.com/python/cpyt
Lysandros Nikolaou added the comment:
Last bit of work is now done.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Lysandros Nikolaou :
We can avoid having to go through all the invalid rules (which might be a
significant performance boost, since these may call expensive rules like
primary or others), if we run the parser two times.
On the first run, all the invalid rules are disabled
Change by Lysandros Nikolaou :
--
keywords: +patch
pull_requests: +21835
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22111
___
Python tracker
<https://bugs.python.org/issu
Lysandros Nikolaou added the comment:
We do not have a big corpus of SyntaxErrors to test against, but some manual
testing of running a file with a SyntaxError after a long complex line 1000
times shows no slowdown.
We keep the token stream for the second run, so we don't need to ru
Lysandros Nikolaou added the comment:
New changeset bca701403253379409dece03053dbd739c0bd059 by Lysandros Nikolaou in
branch 'master':
bpo-42123: Run the parser two times and only enable invalid rules on the second
run (GH-22111)
https://github.com/python/cpyt
Change by Lysandros Nikolaou :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Lysandros Nikolaou :
--
pull_requests: -21195
___
Python tracker
<https://bugs.python.org/issue41659>
___
___
Python-bugs-list mailing list
Unsub
Change by Lysandros Nikolaou :
--
pull_requests: +21910
pull_request: https://github.com/python/cpython/pull/22996
___
Python tracker
<https://bugs.python.org/issue41
Lysandros Nikolaou added the comment:
New changeset 15acc4eaba8519d7d5f2acaffde65446b44dcf79 by Lysandros Nikolaou in
branch 'master':
bpo-41659: Disallow curly brace directly after primary (GH-22996)
https://github.com/python/cpython/commit/15acc4eaba8519d7d5f2acaffde654
Change by Lysandros Nikolaou :
--
pull_requests: +21921
pull_request: https://github.com/python/cpython/pull/23006
___
Python tracker
<https://bugs.python.org/issue41
Lysandros Nikolaou added the comment:
New changeset c4b58cea4771afc0ddfdb857b0fb5115b9f4bc9f by Lysandros Nikolaou in
branch '3.9':
[3.9] bpo-41659: Disallow curly brace directly after primary (GH-22996) (#23006)
https://github.com/python/cpyt
Change by Lysandros Nikolaou :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Lysandros Nikolaou :
--
pull_requests: +21927
pull_request: https://github.com/python/cpython/pull/23011
___
Python tracker
<https://bugs.python.org/issue42
Lysandros Nikolaou added the comment:
New changeset 24a7c298d47658295673dc04d1b6d59f2b200a7c by Lysandros Nikolaou in
branch '3.9':
[3.9] bpo-42123: Run the parser two times and only enable invalid rules on the
second run (GH-22111) (GH-23011)
https://github.com/python/cpyt
Change by Lysandros Nikolaou :
--
nosy: +lys.nikolaou
nosy_count: 3.0 -> 4.0
pull_requests: +21984
pull_request: https://github.com/python/cpython/pull/23065
___
Python tracker
<https://bugs.python.org/issu
Lysandros Nikolaou added the comment:
New changeset 02cdfc93f82fecdb7eae97a868d4ee222b9875d9 by Lysandros Nikolaou in
branch 'master':
bpo-42218: Correctly handle errors in left-recursive rules (GH-23065)
https://github.com/python/cpython/commit/02cdfc93f82fecdb7eae97a868d4ee
Change by Lysandros Nikolaou :
--
pull_requests: +21985
pull_request: https://github.com/python/cpython/pull/23066
___
Python tracker
<https://bugs.python.org/issue42
Change by Lysandros Nikolaou :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Lysandros Nikolaou :
test_format:test_locale tests for the existence of the thousands separator in a
formatted number.
However, my locale does not expect/enforce (not sure what the correct term is)
grouping the number in thousands, which leads to the test (and consequently
Change by Lysandros Nikolaou :
--
keywords: +patch
pull_requests: +21986
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23067
___
Python tracker
<https://bugs.python.org/issu
Lysandros Nikolaou added the comment:
New changeset 301822859b3fc34801a06f1090d62f9f2ee5b092 by Lysandros Nikolaou in
branch 'master':
bpo-42224: Fix test_format when locale does not expect number grouping
(GH-23067)
https://github.com/python/cpyt
Change by Lysandros Nikolaou :
--
pull_requests: +22028
pull_request: https://github.com/python/cpython/pull/23111
___
Python tracker
<https://bugs.python.org/issue42
Lysandros Nikolaou added the comment:
New changeset 723e21a8e79815ae77474d1f21b9847b9c9bdbeb by Lysandros Nikolaou in
branch '3.9':
bpo-42224: Fix test_format when locale does not expect number grouping
(GH-23067)
https://github.com/python/cpyt
Change by Lysandros Nikolaou :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Lysandros Nikolaou :
--
nosy: +lys.nikolaou
nosy_count: 3.0 -> 4.0
pull_requests: +22208
pull_request: https://github.com/python/cpython/pull/23317
___
Python tracker
<https://bugs.python.org/issu
New submission from Lysandros Nikolaou :
While a walrus is valid withing generator expressions in 3.8, it's not in 3.9
and onward.
➜ cpython git:(master) ✗ python3.8
Python 3.8.6 (default, Oct 3 2020, 16:26:47)
[GCC 9.3.0] on linux
Type "help", "copyright&quo
Change by Lysandros Nikolaou :
--
keywords: +patch
pull_requests: +22210
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23319
___
Python tracker
<https://bugs.python.org/issu
Lysandros Nikolaou added the comment:
Pablo, have you already started on this? I didn't see your comment earlier and
I've got a PR ready.
--
___
Python tracker
<https://bugs.python.o
Change by Lysandros Nikolaou :
--
pull_requests: +22212
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/23321
___
Python tracker
<https://bugs.python.org/issu
Lysandros Nikolaou added the comment:
Victor, Miro, both removal of the parser module and of all the C API functions
are now documented in the 3.10 whatsnew document. Do you feel that this is
enough for us to close this issue again?
--
___
Python
New submission from Lysandros Nikolaou :
Since unparenthesized walruses are allowed in list comprehensions and in
generator expressions, should we maybe allow them in set comprehensions as well?
--
components: Interpreter Core
messages: 381173
nosy: gvanrossum, lys.nikolaou, pablogsal
Lysandros Nikolaou added the comment:
New changeset cae60187cf7a7b26281d012e1952fafe4e2e97e9 by Lysandros Nikolaou in
branch 'master':
bpo-42316: Allow unparenthesized walrus operator in indexes (GH-23317)
https://github.com/python/cpython/commit/cae60187cf7a7b26281d012e1952fa
Change by Lysandros Nikolaou :
--
pull_requests: +22217
pull_request: https://github.com/python/cpython/pull/23329
___
Python tracker
<https://bugs.python.org/issue42
Change by Lysandros Nikolaou :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Lysandros Nikolaou added the comment:
New changeset 2b800ef809eefbc96a536e4b43a8285f2353f64d by Lysandros Nikolaou in
branch '3.9':
bpo-42374: Allow unparenthesized walrus in genexps (GH-23319) (GH-23329)
https://github.com/python/cpython/commit/2b800ef809eefbc96a536e4b43a828
Lysandros Nikolaou added the comment:
> dict comprehension
FWIW, unparenthesized walruses are still disallowed in dictcomps and to be
honest, I'm not sure if we should allow them or not. I feel that allowing too
many colons there would be too noisy.
{a:='a': b:=1} doesn
Lysandros Nikolaou added the comment:
While {(a:='a'): (b:=1)} looks somewhat cleaner to me.
--
___
Python tracker
<https://bugs.python.org/issue42381>
___
__
Change by Lysandros Nikolaou :
--
pull_requests: +22274
pull_request: https://github.com/python/cpython/pull/23382
___
Python tracker
<https://bugs.python.org/issue42
Change by Lysandros Nikolaou :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Lysandros Nikolaou :
For those, who use custom tools for their terminals, prepending __VENV_PROMPT__
to PS1 doesn't really help all that much, because it gets overwritten by those
tools. Would it make sense to export __VENV_PROMPT__ as an environment variable
Lysandros Nikolaou added the comment:
It is. Somehow search failed me big time. I'm closing the issue.
--
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.
Change by Lysandros Nikolaou :
--
resolution: -> duplicate
___
Python tracker
<https://bugs.python.org/issue36966>
___
___
Python-bugs-list mailing list
Un
Change by Lysandros Nikolaou :
--
nosy: +lys.nikolaou
___
Python tracker
<https://bugs.python.org/issue35328>
___
___
Python-bugs-list mailing list
Unsubscribe:
Lysandros Nikolaou added the comment:
Is anybody still working on this?
--
___
Python tracker
<https://bugs.python.org/issue35328>
___
___
Python-bugs-list m
Change by Lysandros Nikolaou :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Lysandros Nikolaou :
Since recently, Homebrew refuses to link sqlite. Upon researching the whole
thing, I found out that this is now considered a feature of Homebrew and not a
bug. Thus homebrew users on macOS do not get the SQLite module installed by
default, because it
Lysandros Nikolaou added the comment:
@brettcannon, yeah I saw that, but there hasn't been any progress since
November. I'm still interested in this though. What would the correct workflow
be? Pushing commits to the same PR or opening a new one with a
Lysandros Nikolaou added the comment:
This can be most likely be closed. In the last days I had some unrelated
problems with my mac and had to do a full format. After reinstalling macOS the
problem went away, so it must have been something specific to my previous state
of things that
Lysandros Nikolaou added the comment:
Mariatta noted at
https://mail.python.org/archives/list/core-mentors...@python.org/message/KFIGNAGJKWQXCXG72VGIGGA3OCKUHOFC/
that these issues are not reserved and are now available for first-time
contributors.
--
nosy: +lys.nikolaou
201 - 300 of 352 matches
Mail list logo
