[issue36674] "unittest.TestCase.debug" should honour "skip" (and other test controls)

2019-05-07 Thread Lisa Roach
Change by Lisa Roach : -- pull_requests: +13096 ___ Python tracker <https://bugs.python.org/issue36674> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36674] "unittest.TestCase.debug" should honour "skip" (and other test controls)

2019-05-07 Thread Lisa Roach
Change by Lisa Roach : -- pull_requests: -13094 ___ Python tracker <https://bugs.python.org/issue36674> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31356] Add context manager to temporarily disable GC

2018-01-30 Thread Lisa Roach
Change by Lisa Roach : -- pull_requests: +5284 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue31356> ___ ___ Python-bugs-list mai

[issue31356] Add context manager to temporarily disable GC

2018-01-30 Thread Lisa Roach
Lisa Roach added the comment: I gave it a shot- looks like we need to ensure that we catch any errors that could be thrown by the warning itself. I wasn't entirely sure how to create a test for this, if anyone knows how I'll definit

[issue30940] Documentation for round() is incorrect.

2018-04-01 Thread Lisa Roach
Change by Lisa Roach : -- keywords: +patch pull_requests: +6053 ___ Python tracker <https://bugs.python.org/issue30940> ___ ___ Python-bugs-list mailing list Unsub

[issue33184] Update OpenSSL to 1.1.0h / 1.0.2o

2018-04-04 Thread Lisa Roach
Lisa Roach added the comment: I'd like to help out with this, I see Christian is already providing a lot of compatibility for the latest versions of OpenSSL. What needs to be done for the update? -- nosy: +lisroach ___ Python tracker &

[issue31145] PriorityQueue.put() fails with TypeError if priority_number in tuples of (priority_number, data) are the same.

2017-09-26 Thread Lisa Roach
Lisa Roach added the comment: I think it is a good idea to have a simple way to add a value to sort on in general, it could have some interesting use-cases. Also I am with Nick a name change would make the broader scope clearer. What I am not sure about is making the comparison have to be

[issue31822] Document that urllib.parse.{Defrag, Split, Parse}Result are namedtuples

2017-11-16 Thread Lisa Roach
Change by Lisa Roach : -- keywords: +patch pull_requests: +4378 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issue31822> ___ _

[issue32173] linecache.py add lazycache to __all__ and use dict.clear to clear the cache

2017-12-01 Thread Lisa Roach
Lisa Roach added the comment: I think these changes look good, ganziqim has real code improvements (in the form of adding lazycache to __all__ and using clear() in clearchache), as well as improving the code formatting for readability

[issue33073] Add as_integer_ratio() to int() objects

2018-08-12 Thread Lisa Roach
Change by Lisa Roach : -- keywords: +patch pull_requests: +8230 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue33073> ___ ___ Python-

[issue24412] setUpClass equivalent for addCleanup

2018-09-11 Thread Lisa Roach
Change by Lisa Roach : -- pull_requests: +8628 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issue24412> ___ ___ Python-

[issue34659] Inconsistency between functools.reduce & itertools.accumulate

2018-09-13 Thread Lisa Roach
Lisa Roach added the comment: Happy to! I'll try to make a patch. -- ___ Python tracker <https://bugs.python.org/issue34659> ___ ___ Python-bugs-list m

[issue26467] Add async magic method support to unittest.mock.Mock

2018-09-14 Thread Lisa Roach
Change by Lisa Roach : -- keywords: +patch pull_requests: +8725 stage: test needed -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue34659] Inconsistency between functools.reduce & itertools.accumulate

2018-09-16 Thread Lisa Roach
Change by Lisa Roach : -- keywords: +patch pull_requests: +8769 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue34659> ___ ___ Python-

[issue34659] Inconsistency between functools.reduce & itertools.accumulate

2018-09-23 Thread Lisa Roach
Lisa Roach added the comment: New changeset 9718b59ee5f2416cdb8116ea5837b062faf0d9f8 by Lisa Roach in branch 'master': bpo-34659: Adds initial kwarg to itertools.accumulate() (GH-9345) https://github.com/python/cpython/commit/9718b59ee5f2416cdb8116ea5837b0

[issue34659] Inconsistency between functools.reduce & itertools.accumulate

2018-09-24 Thread Lisa Roach
Change by Lisa Roach : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue34788] ipaddress module fails on rfc4007 scoped IPv6 addresses

2018-10-30 Thread Lisa Roach
Lisa Roach added the comment: I think this is something that would be good to have. Jeremy would you care to make a PR for this? -- nosy: +lisroach ___ Python tracker <https://bugs.python.org/issue34

[issue24412] setUpClass equivalent for addCleanup

2018-11-08 Thread Lisa Roach
Lisa Roach added the comment: New changeset 0f221d09cad46bee38d1b7a7822772df66c53028 by Lisa Roach in branch 'master': bpo-24412: Adds cleanUps for setUpClass and setUpModule. (GH-9190) https://github.com/python/cpython/commit/0f221d09cad46bee38d1b7a7822772df66c53028 -

[issue35221] Enhance venv activate commands readability

2018-11-12 Thread Lisa Roach
Lisa Roach added the comment: Using plain angle brackets is common placeholder notation, and I think changing it to something different might be confusing to those who are familiar with the pattern. I have also seen plenty of people copying and pasting the wrong things because of this

[issue24209] Allow IPv6 bind in http.server

2018-11-18 Thread Lisa Roach
Change by Lisa Roach : -- pull_requests: +9840 stage: test needed -> patch review ___ Python tracker <https://bugs.python.org/issue24209> ___ ___ Python-

[issue24209] Allow IPv6 bind in http.server

2018-11-18 Thread Lisa Roach
Lisa Roach added the comment: Looks like the original author isn't around anymore (feel free to chime in if you are, Link!), so I went ahead and made a PR. I added a quick unit test, it's not much but more than nothing, plus updated the documentation. -- nosy:

[issue27779] Sync-up docstrings in C version of the the decimal module

2016-12-01 Thread Lisa Roach
Lisa Roach added the comment: This (should) be the patch with the python docstrings copied over to the C version. -- Added file: http://bugs.python.org/file45728/docstrings.patch ___ Python tracker <http://bugs.python.org/issue27

[issue28911] Clarify the behaviour of assert_called_once_with

2017-01-13 Thread Lisa Roach
Lisa Roach added the comment: It took me a little while to wrap my brain around this, but you are definitely right that the documentation is not sufficient, your changes are an improvement. My wonder is, should we change the documentation or be looking at the code itself? I have always

[issue29549] Improve docstring for str.index

2017-02-20 Thread Lisa Roach
Lisa Roach added the comment: I tried to have a go at making the str.index Argument Clinic compatible, Serhiy can you take a look at my commits and let me know if this is the correct way of doing it: https://github.com/python/cpython/compare/master...lisroach:master If it looks good I will

[issue29549] Improve docstring for str.index

2017-02-23 Thread Lisa Roach
Changes by Lisa Roach : -- pull_requests: +225 ___ Python tracker <http://bugs.python.org/issue29549> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29549] Improve docstring for str.index

2017-02-23 Thread Lisa Roach
Lisa Roach added the comment: I'll just go ahead and make my PR, let me know what else needs to be done. Serhiy, if you could point me in the direction of how to write the docstring so that it is in the Argument Clinic style I would be happy to take a

[issue23951] Update devguide style to use a similar theme as Docs

2016-06-29 Thread Lisa Roach
Lisa Roach added the comment: I have updated the conf.py and added a "tools" folder that contains the themes, templates, etc. to make the devguide match more closely with the pydoctheme. I altered the theme a little bit to keep the colors more consistent with the original devguide,

[issue23951] Update devguide style to use a similar theme as Docs

2016-07-19 Thread Lisa Roach
Lisa Roach added the comment: Thanks for the feedback! I've cleaned up the patch, hopefully I've been able to catch all the little things that needed to be removed. I was able to wire in rstlint to the make.bat and makefile, so 'make check' should now work. I believe

[issue23951] Update devguide style to use a similar theme as Docs

2016-07-19 Thread Lisa Roach
Lisa Roach added the comment: Whoops, forgot to remove some errant code. -- Added file: http://bugs.python.org/file43804/devguide_theme_revised.patch ___ Python tracker <http://bugs.python.org/issue23

[issue27566] Tools/freeze/winmakemakefile.py clean target should use 'del' instead of 'rm'

2016-08-03 Thread Lisa Roach
Lisa Roach added the comment: I think this patch makes the proper fix, changed the lines: print("\t-rm -f *.obj") print("\t-rm -f $(target).exe") to print("\t-del /f *.obj") print("\t-del /f $(target).exe") -- keywords:

[issue12345] Add math.tau

2016-08-11 Thread Lisa Roach
Lisa Roach added the comment: I've updated the test to assert tau is equal to 2*math.pi, as well as updated the docs and cmath. Let me know if I have made any errors! -- nosy: +lisroach Added file: http://bugs.python.org/file44080/tau3

[issue12345] Add math.tau

2016-08-14 Thread Lisa Roach
Lisa Roach added the comment: I have added some more detail to the Tau documentation, including that Tau is 2 * pi, as well as some links to Tau Day and Vi Hart's video. That should give Python users enough to get started forming their own opinions on tau vs pi :) -- Added

[issue27779] Sync-up docstrings in C version of the the decimal module

2016-09-01 Thread Lisa Roach
Lisa Roach added the comment: I will start working on the patch for this! Thanks for pointing me this way, Raymond. -- nosy: +lisroach ___ Python tracker <http://bugs.python.org/issue27

[issue27779] Sync-up docstrings in C version of the the decimal module

2016-09-09 Thread Lisa Roach
Lisa Roach added the comment: Hi Stefan and Raymond, Here's my start on the patch, I wanted to get your opinions on the direction before I go too far. I've been comparing the two sets of docstrings, and trying to synchronize them in the clearest way that most closely matches t

[issue27779] Sync-up docstrings in C version of the the decimal module

2016-09-09 Thread Lisa Roach
Lisa Roach added the comment: I just noticed some trailing whitespace in the patch, ignore them for now and they'll be removed in the next patch. -- ___ Python tracker <http://bugs.python.org/is

[issue27779] Sync-up docstrings in C version of the the decimal module

2016-10-17 Thread Lisa Roach
Lisa Roach added the comment: Anyone get the chance to look over this yet? -- ___ Python tracker <http://bugs.python.org/issue27779> ___ ___ Python-bugs-list m

[issue28130] Document that time.tzset updates time module globals

2016-10-18 Thread Lisa Roach
Lisa Roach added the comment: Will this simple update be enough? Or should more documentation be added for clarification? -- keywords: +patch nosy: +lisroach Added file: http://bugs.python.org/file45135/tzset_doc.patch ___ Python tracker <h

[issue27779] Sync-up docstrings in C version of the the decimal module

2016-11-01 Thread Lisa Roach
Lisa Roach added the comment: Thanks for taking a look Stefan! I agree, it is definitely not as easy as it sounds. Your review and comments are helpful, I will make adjustments to the docstrings. If you want, I can continue to try to sync-up the docstrings and submit them for you and

<    1   2