Larry Hastings added the comment:
I don't think "k" is the right answer.
POSIX defines the user and group parameters as uid_t and gid_t respectively; in
turn, uid_t and gid_t are defined as "integers", pointedly omitting the either
of the words "signed"
Larry Hastings added the comment:
Thinking about it some more, maybe we need to be smart about whether
uid_t/gid_t are signed or unsigned.
I'm no good with configure hackery--could anyone here enhance the configure
script so it could tell us whether or not uid_t and gid_t were sign
Larry Hastings added the comment:
That patch from Victor looks pretty good. I'll try to get it in for beta 2,
however I'm on the road right now. I'm back Sunday night and will try to do it
then.
If someone else wants to jump in that's fine with me.
--
Larry Hastings added the comment:
I don't think this needs clarifying. If you think the reference to "touch"
currently only muddles the issue, let's remove it entirely.
--
___
Python tracker
<http://bug
Larry Hastings added the comment:
It looks like #1747858 is another duplicate. Though arguably all these "dups"
aren't really dups because I rewrote chown's argument parsing for 3.3.
--
___
Python tracker
<http://bug
Changes by Larry Hastings :
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Larry Hastings added the comment:
Here's a first cut at a patch. It's really just an update of Victor's patch to
#4591 (done with his blessing). I tweaked it slightly; the parsing functions
are now O& converter functions.
I also added a reasonable unit test. Note ho
Larry Hastings added the comment:
Okay, I'll remove the ".. note". Checking in shortly.
--
___
Python tracker
<http://bugs.python.org/issue15233>
___
__
Larry Hastings added the comment:
So, it's checked in to trunk. Shall I also backport to 2.7 and 3.2 as the
issue suggests?
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
The .4 patches both LGTM, please commit!
--
___
Python tracker
<http://bugs.python.org/issue15202>
___
___
Python-bugs-list m
Larry Hastings added the comment:
Sorry; the patch didn't apply cleanly, and it looks like I bungled doing it
manually. Fixing now.
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
Is anyone working on this? I could possibly take a stab at it tonight, if I
get the evening to myself.
--
___
Python tracker
<http://bugs.python.org/issue15
Larry Hastings added the comment:
I have been meditating on this, and I'm not sure we should change 2.7. 3.2
might be okay.
The thing is, I fear we're not just talking about CPython implementation
details, we're talking about the Python Standard Library. The existing
docume
Larry Hastings added the comment:
Hynek, it's clear you understand this far better than I do. Could I get you to
fix the Fedora buildbot problem, etc, etc?
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
Sorry, I've been on the road a lot. Thanks, Antoine!
--
___
Python tracker
<http://bugs.python.org/issue15413>
___
___
Larry Hastings added the comment:
Because both functions were available in 3.2, and we can't remove old functions
without a full deprecation cycle.
--
resolution: -> wont fix
stage: -> committed/rejected
status: open -> closed
___
Larry Hastings added the comment:
I just tried it, and os.readlink('/tmp/broken-symlink') worked fine. What OS
are you using?
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
ftruncate isn't new.
--
___
Python tracker
<http://bugs.python.org/issue15548>
___
___
Python-bugs-list mailing list
Unsubsc
Larry Hastings added the comment:
What does the following script print out?
import os
os.chdir('/tmp')
os.symlink('--success--', 'foo')
print("this should print --success-- :")
print(os.readlink('foo'))
os.unlink('foo')
--
_
Larry Hastings added the comment:
Since everything is working fine, and the documentation arguably needs no
update, I'm closing this.
--
resolution: -> works for me
stage: -> committed/rejected
status: open -> closed
___
Python
Larry Hastings added the comment:
This platform is 8-byte aligned?
--
___
Python tracker
<http://bugs.python.org/issue15589>
___
___
Python-bugs-list mailin
Larry Hastings added the comment:
nm, I get it, doubles are 8-bytes and should be 8-byte aligned. Let me stare
at it some more.
--
___
Python tracker
<http://bugs.python.org/issue15
Larry Hastings added the comment:
Attached is a patch attempting to force double alignment. Stefan: please apply
and try it. Does this help?
--
keywords: +patch
Added file:
http://bugs.python.org/file26727/larry.force.alignment.in.capi.test.1.diff
Larry Hastings added the comment:
I'll ask the obvious: was that an optimized build? Not that that explains the
bug--but that might explain why "length" appeared to contain 24.
It's hard to believe this is really an OS bug...
--
__
Larry Hastings added the comment:
Can you tell me which code path it took? Either by walking through the code as
it runs, or by telling me about the preprocessor defines used by utime
(HAVE_FUTIMES, HAVE_FUTIMENS, HAVE_FUTIMESAT, HAVE_UTIMENSAT, HAVE_UTIMES,
HAVE_UTIME_H). The easy way to
Larry Hastings added the comment:
mtime is never converted into a "decimal". Do you perhaps mean "double"?
--
___
Python tracker
<http://bug
Larry Hastings added the comment:
haypo: If a series of shell commands duplicated the problem, then okay, but I
suspect the problem has to do with persistent state in the process and will
only be reproducible with a C program.
--
___
Python tracker
Larry Hastings added the comment:
Yes, but the code should still work. The test that's failing reads the
atime/mtime from a file, then writes those values out to the file, then reads
again to confirm that they're the same. That should a
Larry Hastings added the comment:
Could we work around it? Ignore the length we get back from readlink() and
just measure the buffer ourselves? Or, if we wanted to be *really* paranoid,
write a \0 at the length they give us back and *then* strlen it
Larry Hastings added the comment:
Lgtm.
Trent Nelson wrote:
>
>Trent Nelson added the comment:
>
>Easy fix, cast AT_FDCWD to (int):
>
>
>% hg diff
>diff -r 3a880d640981 Modules/posixmodule.c
>--- a/Modules/posixmodule.c Tue Sep 18 07:21:18 2012 +0300
>+++ b
Larry Hastings added the comment:
Patch looks like it'll work fine. But please add regression tests checking
that the error message is what we want.
Are the new error messages okay with the OP? It looks like now it'll throw
TypeError("argument must be string, bytes or in
Larry Hastings added the comment:
Ah! It seems Python is anti-Oxford Comma. Carry on! ;-)
Wouldn't test_os be the natural place? I don't understand why you're having
difficulty finding a suitable place.
--
___
Python
Larry Hastings added the comment:
Patch looks fine in principle, though I'd want someone to go over the
individual cases to make sure they make sense.
Also, I have something up my sleeve regarding argument parsing for 3.4, and if
it gets accepted we might be touching all this code anywa
Larry Hastings added the comment:
Patch looks fine, except please fix 80 columns.
--
___
Python tracker
<http://bugs.python.org/issue15972>
___
___
Python-bug
Larry Hastings added the comment:
LGTM. Serhiy, you have the commit bit?
--
___
Python tracker
<http://bugs.python.org/issue15972>
___
___
Python-bugs-list mailin
Larry Hastings added the comment:
Georg: this okay to check in? It passes the regression test.
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue15
Larry Hastings added the comment:
I must be missing something--because I thought Python *already* depended on
this apparently-undefined behavior. The small-block object allocator in
Objects/obmalloc.c determines whether a pointer belongs to a particular arena
using exactly this trick. I
New submission from Larry Hastings:
You know how you start pulling on a thread and before you notice you've
unraveled the whole sweater? I meant to do a simple *one line* fix on the docs
and wound up with a nearly-300-line diff. I claim it's all an improvement,
though I'm wi
New submission from Larry Hastings:
I wrote the following script called "bonkers.py":
--
import sys
print(sys.argv[0])
--
then ran
% python3 -m unittest bonkers
It printed
--
['python -m unittest', 'bonkers']
--
Shouldn't it say "pyth
Larry Hastings added the comment:
Certainly. But what is the right thing to do?
I talked to Michael about it in person this morning, and our consensus was: use
basename of sys.executable.
Patch attached.
--
keywords: +patch
stage: needs patch -> patch review
Added file: h
Larry Hastings added the comment:
Agreed. Not a bug. Closing the issue.
--
resolution: -> invalid
stage: -> committed/rejected
status: open -> closed
type: -> behavior
___
Python tracker
<http://bugs.python
Larry Hastings added the comment:
Michael, you're the one who came up with the feature. If you write the comment
I'll fold it into the patch.
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
Eric, iirc you're the de facto csv guy? Does this seem reasonable to you?
--
nosy: +eric.araujo, larry
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
As Serhiy says, which filename to display is wholly context-sensitive to which
errno it is. And there's no cheap way to display both. The cheap fix is to
call path_error with a nulled-out "path" object; this will display the error
without a f
Larry Hastings added the comment:
New patch, just calling posix_error directly.
--
Added file: http://bugs.python.org/file27344/larry.rename_error.2.diff
___
Python tracker
<http://bugs.python.org/issue16
Larry Hastings added the comment:
Is there a different utime family function on these platforms that *can* write
atime/mtime with ns resolution?
--
___
Python tracker
<http://bugs.python.org/issue15
Larry Hastings added the comment:
You're a sneaky, naughty bunny. "posix._have_functions" indeed! I guess your
back was to the wall.
1)
If I follow your code correctly, when one has utimensat, the assertLess calls
using _t consider st0.st_mtime_ns < st1.st_mtime_ns even i
Larry Hastings added the comment:
I don't know POSIX / UNIX all that well. Does it require that a stat call
updates atime? Because that's one of those "how does it ever work"
head-scratchers. (Maybe everybody always disables atime these days?
Larry Hastings added the comment:
Does Python still officially support m68k?
--
nosy: +larry
___
Python tracker
<http://bugs.python.org/issue20904>
___
___
Pytho
Larry Hastings added the comment:
Yeah, I admit I don't understand what problem that code was solving. But it
looked Very Deliberate so I preserved the behavior.
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
I'm happy to accept the change for 3.4.1, but I'm not going to cherry-pick a
fix for an unsupported platform after rc3.
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
RDM's checkin ( 21ecc3d52806 ) renamed the subheading of "Summary -- Release
Highlights" from "New Expected Features for Python Implementations" to "New
features". But there's still a major heading with that title.
Larry Hastings added the comment:
I propose to check this in.
--
keywords: +patch
Added file:
http://bugs.python.org/file34438/larry.remove.other.instance.of.clumsy.wording.1.diff
___
Python tracker
<http://bugs.python.org/issue20
Larry Hastings added the comment:
ok. actually pulling all the docs from default into 3.4.
--
resolution: -> fixed
stage: commit review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Larry Hastings added the comment:
Can I mark this closed? I'm tagging 3.4.0 final soon.
--
___
Python tracker
<http://bugs.python.org/issue18257>
___
___
Larry Hastings added the comment:
Was this done? I'm tagging 3.4.0 final soon.
--
___
Python tracker
<http://bugs.python.org/issue16245>
___
___
Pytho
Larry Hastings added the comment:
Fixed in b2ee3fe195e2.
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Larry Hastings added the comment:
If the 3.4 changes are done, can we either close this or remove 3.4 from the
versions?
--
nosy: +larry
___
Python tracker
<http://bugs.python.org/issue16
Larry Hastings added the comment:
So is this fixed? Can we close the issue? I'm tagging 3.4.0 final soon.
--
nosy: +larry
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
Yeah, I'm not accepting this for 3.4 at this point, and I bet the other RMs
feel the same way.
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
Since 3.4 and 3.5 are different code bases, I assume you'd be willing to check
this in for both. Assuming that's the case, please tick the 3.5 version too.
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
Martin: I hadn't realized there was such a rule from Guido. Can you cite where
he said that?
Obviously I didn't mind accepting this patch, as it looks like it would have
roughly zero maintenance cost for anyone who doesn't care about 68k. Bu
Larry Hastings added the comment:
It sounds like this definitely won't happen for 3.4. And if Guido has indeed
declared "no code for unsupported platforms", it won't happen for 3.5 either.
--
versions: -Python 3.4
___
P
Larry Hastings added the comment:
I agree that it's a short and straightforward patch, and as stated I wouldn't
mind accepting it. However, I don't make a habit of going against Guido's
rulings.
--
___
Python tracker
<
Larry Hastings added the comment:
That's why I haven't said firmly yes or no yet. I expect to see Guido in just
over two weeks, and if nothing turns up by then I'll ask him in person. Is
anybody here in a hurry?
--
___
Python
Larry Hastings added the comment:
(And hooray for that, given the meteoric rise of AtheOS. :| )
I'm going to go way out on a limb and say that Guido hasn't made a
pronouncement here. Also, the discussions cited by Martin are about entire new
platforms (AtheOS, Haiku), whereas
Larry Hastings added the comment:
That's my fault. That conversion was done at a time when there were a lot
fewer eyes looking at AC.
It should obviously be fixed, and a test added to the regression test suite.
It'd also be nice if running the curses test didn't make rea
Larry Hastings added the comment:
> I retract my veto.
You don't have a "veto". Only Guido has that.
Anyhow you have yet to reply to Mr. Schwab's assertion:
> The emulator has always correctly implemented the insn.
If that's true, then I don't understa
Larry Hastings added the comment:
I was told to keep Argument Clinic compatible with 3.3. I think it's a good
idea for the tools to not require absolutely current Python. Would it be a big
deal to support 3.3?
--
___
Python tracker
Larry Hastings added the comment:
Thank you Lars for your thorough reply.
While I agree that this isn't a release blocker, as it was clearly designed to
behave this way... it seems to me that it wouldn't take much to make the
tarfile module a lot safer. Specifically:
* D
Larry Hastings added the comment:
I have no objections to someone backporting this.
--
___
Python tracker
<http://bugs.python.org/issue16395>
___
___
Python-bug
Larry Hastings added the comment:
How about examining the inspect.Signature?
--
___
Python tracker
<http://bugs.python.org/issue21088>
___
___
Python-bugs-list m
Larry Hastings added the comment:
Benjamin: given the brave new world of 2.7 living even longer, Guido said this
sort of bug fix was fair game. Will you accept a patch for this in 2.7?
--
assignee: -> larry
nosy: +benjamin.peterson
___
Pyt
Larry Hastings added the comment:
I don't think we can fix this. file_read returns a str, and str can have at
most SSIZE_T_MAX entries. So, file_read could read size_t characters, but it
couldn't return them.
--
___
Python trac
Larry Hastings added the comment:
D'oh, yeah, you guys are right. SSIZE_T_MAX > LONG_MAX, so that's an
improvement. We just can't do the full size_t range.
--
___
Python tracker
<http://bugs.
Larry Hastings added the comment:
Here's my version of the patch. It does the same thing Victor's patch does,
but removes a now-completely-irrelevant stanza of code, and adds a test.
I'm on 64-bit Linux, so the test was always going to work anyway. So I tested
the test by cha
Larry Hastings added the comment:
+1 to doc deprecation and adding a DeprecationWarning for 3.5.
--
___
Python tracker
<http://bugs.python.org/issue20438>
___
___
Larry Hastings added the comment:
Okay, I say let's check this in. If mirabilos can cite problems it causes we
can revert it.
Andreas, is there someone who would normally check this in for you, or should I
do it?
--
___
Python tracker
Larry Hastings added the comment:
Here's my version of the patch, which is like Victor's patch but adds a test.
For what it's worth, I'll make sure this issue is fixed before I release 3.4.1.
--
Added file:
http://bugs.python.org/file34939/larry.curses.win
New submission from Larry Hastings:
I noticed this code in Objects/object.c today:
/* Hack to force loading of pycapsule.o */
PyTypeObject *_PyCapsule_hack = &PyCapsule_Type;
What is this doing? Note that PyCapsule_Type is referred to inside
_Py_ReadyTypes(), so there's
Larry Hastings added the comment:
It's really that easy, it was a stupid bug that is probably my fault, the fix
will be in 3.4.1.
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
By default AC emits "$type" for class methods, see dict_fromkeys in
Objects/dictobject.c.
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
If you guys want this in 3.4.1, please get it checked in in the next, oh, eight
hours.
--
___
Python tracker
<http://bugs.python.org/issue21
Changes by Larry Hastings :
--
assignee: -> larry
resolution: -> fixed
stage: needs patch -> resolved
___
Python tracker
<http://bugs.python.or
Larry Hastings added the comment:
Sorry, I should have said "3.4.1rc1". You can still get it in for 3.4.1.
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
3.4.1rc1 is the first release I've cut where the makefile didn't auto-download
Sphinx. And then the makefile used "python" and "sphinx-build" straight off
the path, rather than finding the local ones. To generate pydoc-topi
Larry Hastings added the comment:
Well, surely working with the current python is sufficient? I'd be happy if it
was only guaranteed to run with the python tree it's a part of.
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
I'm totally on board with you guys checking this in for 3.4.1.
--
___
Python tracker
<http://bugs.python.org/issue21435>
___
___
Larry Hastings added the comment:
dstufft, what do you think?
--
nosy: +dstufft
___
Python tracker
<http://bugs.python.org/issue7776>
___
___
Python-bugs-list m
Changes by Larry Hastings :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue21088>
___
___
Python-bugs-list mailing list
Unsubscrib
Larry Hastings added the comment:
Antoine's plan sounds good to me. And, is it true that NFS only supports
four-byte timestamps?
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
Berker: do you consider your diff ready to go in, or is it an "early" diff
(like a work-in-progress)?
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
I tag 3.4.1 final in less than 24 hours. I really would prefer that the
embedded pip not contain such, uh, fresh software. But let's try it and hope
for the best.
--
___
Python tracker
<http://bugs.py
Larry Hastings added the comment:
Yeah, I'd like to see the diff.
--
___
Python tracker
<http://bugs.python.org/issue7776>
___
___
Python-bugs-list m
Larry Hastings added the comment:
Okay, this has my blessing to be merged for 3.4.1.
--
___
Python tracker
<http://bugs.python.org/issue7776>
___
___
Python-bug
Changes by Larry Hastings :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue7776>
___
___
Python-bugs-list mailing list
Unsubscrib
Larry Hastings added the comment:
(If the past few weeks have taught us *anything*, it's that we can't look to
OpenSSL to learn best practices.)
--
nosy: +larry
stage: -> resolved
___
Python tracker
<http://bugs.pytho
Larry Hastings added the comment:
Considering that I'm tagging 3.4.1 within an hour or two, and we don't have a
patch yet, I'd say that this is too late to go into 3.4.1. But I'm happy to
consider it for a future 3.4.x revision.
--
__
New submission from Larry Hastings:
If you extract current Python (3.4 or trunk) into a directory, and anywhere in
the name of the directory is the string "bad", such as
/tmp/badtest
/home/baddison/src/python
then test_write_filtered_python_package() in Lib/test/test_zipfile.py
Larry Hastings added the comment:
Here's an eye-wateringly-thorough description of the bug for the sake of
posterity.
The test code in question is test_write_filtered_python_package() in
Lib/test/test_zipfile.py. This function uses PyZipFile to build a zipfile
from the contents of the
801 - 900 of 2389 matches
Mail list logo
