[issue23967] Make inspect.signature expression evaluation more powerful

Larry Hastings added the comment: Thanks to #24002 I now know how to write evalify_node properly. This patch is now much better. Note that I deliberately made the new function _eval_ast_expr() as a "private" module-level routine. I need that same functionality in Argument Clinic t

[issue23967] Make inspect.signature expression evaluation more powerful

Larry Hastings added the comment: Whoops. Here's the revised patch. -- Added file: http://bugs.python.org/file39123/larry.improved.signature.expressions.2.txt ___ Python tracker <http://bugs.python.org/is

[issue24000] More fixes for the Clinic mapping of converters to format units

Larry Hastings added the comment: > "u#" and "Z#" allow null characters. Not according to the documentation. 'u' explicitly says it does not allow NUL characters. 'Z', 'u#', and 'Z#' all say they are "vari

[issue24000] More fixes for the Clinic mapping of converters to format units

Larry Hastings added the comment: New diff based on Serhiy's latest round of comments. Thanks, Serhiy! You are inexhaustable! -- Added file: http://bugs.python.org/file39125/larry.one.more.clinic.format.unit.map.cleanup.3.txt ___ Python tr

[issue24001] Clinic: use raw types in types= set

Changes by Larry Hastings : Removed file: http://bugs.python.org/file39122/larry.one.more.clinic.format.unit.map.cleanup.2.txt ___ Python tracker <http://bugs.python.org/issue24

[issue24001] Clinic: use raw types in types= set

Larry Hastings added the comment: Whoops. I'll fix that. -- ___ Python tracker <http://bugs.python.org/issue24001> ___ ___ Python-bugs-list mailing list

[issue24001] Clinic: use raw types in types= set

Larry Hastings added the comment: Here's the right patch. -- Added file: http://bugs.python.org/file39128/larry.clinic.use.raw.types.2.txt ___ Python tracker <http://bugs.python.org/is

[issue24007] Write PyArg_Parse* format in a line with a function

Larry Hastings added the comment: I don't care about this, but the patch looks fine. If this really helps then LGTM. Please hold off checking this in until after 3.5.0 alpha 4 is released. -- ___ Python tracker <http://bugs.python.org/is

[issue24001] Clinic: use raw types in types= set

Larry Hastings added the comment: Attached is a patch implementing all my proposed changes here: * "types" is now renamed "accept" * it accepts a set of real Python types * there are placeholder types for buffer, robuffer, rwbuffer * "nullable=True" is gone, re

[issue23920] Should Clinic have "nullable" or types=NoneType?

Larry Hastings added the comment: I've implemented this change in the latest patch (#3) for #24001. -- ___ Python tracker <http://bugs.python.org/is

[issue21483] Skip os.utime() test on NFS?

Larry Hastings added the comment: Issac doesn't have commit bit... ... but you do. -- ___ Python tracker <http://bugs.python.org/issue21483> ___ ___ Pytho

[issue20323] Argument Clinic: docstring_prototype output causes build failure on Windows

Larry Hastings added the comment: Is this problem gone, now that Serhiy changed everything over to the "file" preset? -- ___ Python tracker <http://bugs.python.o

[issue20323] Argument Clinic: docstring_prototype output causes build failure on Windows

Larry Hastings added the comment: I thought the bug only happened with the "two-pass" preset. The "two-pass" preset is gone, because I broke it, and nobody was using it anyway, so I removed it. (I don't even remember what "two-pass" was trying to do. It&#

[issue20851] Update devguide to cover testing from a tarball

Larry Hastings added the comment: I don't plan on doing tarball-only drops during the 3.5 beta/rc period like I did during 3.4. However, when I do a release (e.g. 3.5.0a4), I release Windows binaries (built by Steve Dower), OS X binaries (built by Ned Deily), and source in tarballs

[issue23967] Make inspect.signature expression evaluation more powerful

Larry Hastings added the comment: Cleaned up the patch some more--the code was stupid in a couple places. I think it's ready to go in. -- Added file: http://bugs.python.org/file39181/larry.improved.signature.expressions.3.txt ___ Python tr

[issue23967] Make inspect.signature expression evaluation more powerful

Larry Hastings added the comment: It's only used for signatures in builtins. Any possible security hole here is uninteresting because the evil hacker already got to run arbitrary C code in the module init. Because it's only used for signatures in builtins, we shouldn't encoun

[issue24042] Convert os._getfullpathname() and os._isdir() to Argument Clinic

Larry Hastings added the comment: Why isn't the patch tested? -- ___ Python tracker <http://bugs.python.org/issue24042> ___ ___ Python-bugs-list mailing list

[issue24037] Argument Clinic: add the boolint converter

Larry Hastings added the comment: I think this is silly. Python has a well-understood concept of "truth": https://docs.python.org/3/library/stdtypes.html#truth-value-testing I assert that the reason people used the "i" format unit for what are really boolean values

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Larry Hastings added the comment: How often are patches backported to 2.7? While I understand the sentiment, I'd like to understand the scale of the objection being raised. I suspect it's infrequent, making the objection a

[issue24051] Argument Clinic no longer works with single optional argument

Larry Hastings added the comment: Optional groups were designed to support two specific legacy use cases: * functions that have groups of parameters that are * functions with optional parameters to the left of required parameters They are not intended to be used in cases like this. I

[issue24051] Argument Clinic no longer works with single optional argument

Larry Hastings added the comment: Sorry, I forgot to finish the first bullet point. It should have read: * functions that have groups of parameters that are optional only as a group (e.g. curses.window.getch) -- ___ Python tracker <h

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Larry Hastings added the comment: Removing "static" breaks GCC on Linux (gcc 4.9.2 on Ubuntu 15.04 x86-64): ./Modules/_sre.c:2780:20: error: static declaration of ‘pattern_methods’ follows non-static declaration static PyMethodDef pattern_methods[] = { ^ ./Modu

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Larry Hastings added the comment: Steve, does this patch fix the build for Windows? By all rights it oughta. -- Added file: http://bugs.python.org/file39281/larry.fix.sre.build.on.windows.diff.1.txt ___ Python tracker <http://bugs.python.

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Larry Hastings added the comment: As mentioned on #20148, removing the "static" from the forward declarations breaks it on GCC. (And, of the two, I think GCC is the one being reasonable here.) Attached is a patch that should fix the build for tkinter. -- Added f

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Larry Hastings added the comment: Sorry--you can simply remove that line, it's no longer needed. -- ___ Python tracker <http://bugs.python.org/issue20148> ___ ___

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Larry Hastings added the comment: Yes, it moves the type declaration to the bottom of the file, and adds forward static declarations for the types to the top of the file. -- ___ Python tracker <http://bugs.python.org/issue20

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Larry Hastings added the comment: Oh, this is only happening on the *beta* compiler? In that case, I genuinely suggest you file a bug. We can still check in the workaround, but I really do think MSVS's behavior is wrong here. (Why is it only for forward static declarations of arra

[issue24051] Argument Clinic no longer works with single optional argument

Larry Hastings added the comment: If the argument currently uses a default value of -1, then I see no problem with converting it to Argument Clinic using a default value of -1. If you claim it's a "hack" then you should discuss that with the author o

[issue24051] Argument Clinic no longer works with single optional argument

Larry Hastings added the comment: Closing as wontfix. This is not a supported use of optional groups. -- resolution: -> wont fix status: languishing -> closed ___ Python tracker <http://bugs.python.org/i

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Larry Hastings added the comment: I agree. I looked it up in the C99 standard. 6.9.2.2 says: "If the declaration of an identifier for an object is a tentative definition and has internal linkage, the declared type shall not be an incomplete type." And if you'd hurry up and

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Larry Hastings added the comment: (sorry, 6.9.2.3) -- ___ Python tracker <http://bugs.python.org/issue20148> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Larry Hastings added the comment: We discussed it in IRC a bit (and I got a little education). I can propose three remedies: A) back out the Clinic conversion in _ssl.c B) support Clinic in 2.7 just for _ssl.c C) do a one-time backport of the Clinic generated code for _ssl.c IMO these are in

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Larry Hastings added the comment: Attached. Glad you asked right away, it would have been a lot harder to get later! -- Added file: http://bugs.python.org/file39283/irc.transcript.of._ssl.clinic.discussion.txt ___ Python tracker <h

[issue20148] Derby: Convert the _sre module to use Argument Clinic

Larry Hastings added the comment: Steve, please close this issue when you've confirmed it's now building correctly on Windows. -- ___ Python tracker <http://bugs.python.o

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Larry Hastings added the comment: Steve, please close this issue when you've confirmed it's now building correctly on Windows. -- ___ Python tracker <http://bugs.python.o

[issue20159] Derby #7: Convert 51 sites to Argument Clinic across 3 files -> Derby: Convert the ElementTree module to use Argument Clinic

Larry Hastings added the comment: LGTM -- ___ Python tracker <http://bugs.python.org/issue20159> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

Larry Hastings added the comment: Clinic's syntax is diverging from what shipped with 3.4. So if you copied _ssl.c over, it wouldn't work with the Clinic that shipped with 3.4. Maybe the best thing is if Clinic in trunk supports "legacy mode", where the code it generate

[issue23911] Move path-based bootstrap code to a separate frozen file.

Larry Hastings added the comment: This checkin broke the buildbots. If you build trunk then run ./python -bb -m test test_site the test fails. "-bb" is used by the normal test runner ("make test"). The problem is in the lines self.assertTrue(os.p

[issue24001] Clinic: use raw types in types= set

Changes by Larry Hastings : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue24000] More fixes for the Clinic mapping of converters to format units

Larry Hastings added the comment: Here's a freshened version of the patch. I updated the Clinic HOWTO. Serhiy: You're right, length and zeroes always have the same value. Would you ever want length without allowing zeroes? Like, in the future, would we ever want str(lengt

[issue24000] More fixes for the Clinic mapping of converters to format units

Larry Hastings added the comment: I have no interest in naming "str" to "pchar". Yes, *most* of the other converters are named after the C type they translate to. But so far converter names doesn't mention whether or not they represent pointers to types--it's

[issue24000] More fixes for the Clinic mapping of converters to format units

Larry Hastings added the comment: Here's an updated patch where I've removed the "length" parameter to converters, instead relying solely on the "zeroes" parameter. -- Added file: http://bugs.python.org/file39289/larry.one.more.clinic

[issue24000] More fixes for the Clinic mapping of converters to format units

Larry Hastings added the comment: As for "str doesn't even accept str for y and y#", the name "str" is not for the Python type, it's for the C type. -- ___ Python tracker <

[issue24000] More fixes for the Clinic mapping of converters to format units

Larry Hastings added the comment: I don't think those are better names. -- ___ Python tracker <http://bugs.python.org/issue24000> ___ ___ Python-bugs-list m

[issue24000] More fixes for the Clinic mapping of converters to format units

Larry Hastings added the comment: As for "why not length instead of zeroes": Because the primary reason for the parameter is specifying that the string can contain embedded zeroes. Returning the length is a side-effect of this, not the main point. If the string didn't have

[issue24000] More fixes for the Clinic mapping of converters to format units

Larry Hastings added the comment: The length attribute is an internal implementation detail, so its name is not relevant. It's used in the generation of the accompanying "length" parameter for the impl function for this converter. "length" is a good name for it. &q

[issue24000] More fixes for the Clinic mapping of converters to format units

Larry Hastings added the comment: I don't know why you're bringing up previous versions of Python. The clinic.py under review here is for 3.5. -- ___ Python tracker <http://bugs.python.o

[issue20303] Argument Clinic: optional groups

Larry Hastings added the comment: Yes, when I implemented optional groups, I didn't realize that sometimes people mixed them with optional arguments (with default values). Clinic doesn't cope well when you mix the two. Does this work? /*[clinic input] _curses.window.getstr [

[issue24138] Speed up range() by caching and modifying long objects

New submission from Larry Hastings: This probably shouldn't be checked in. But it was an interesting experiment, and I did get it to work. My brother forwarded me this question from Stack Overflow: http://stackoverflow.com/questions/23453133/is-there-a-reason-python-3-enumerates-s

[issue24138] Speed up range() by caching and modifying long objects

Larry Hastings added the comment: 10**3 doesn't show off this hack as much as other numbers would; the hack only operates from 257 to the max in that will fit in a single long "digit" (32767 on 32-bit, 2**30 on 64-bit). Anyway, freelist for one-digit longs seems nearly as good,

[issue24000] More fixes for the Clinic mapping of converters to format units

Larry Hastings added the comment: I think this is a definite improvement, so I've checked it in so I can move on. If you guys still want to talk about it, we can still change it before we hit beta. -- resolution: -> fixed stage: patch review -> resolved status: ope

[issue24145] Support |= for parameters in converters

New submission from Larry Hastings: Some "format units" provided by PyArg_ParseTuple() are exactly the same as others, except that they also accept the value None. For example, "s" and "z" are exactly the same, except "z" accepts None and "s"

[issue23920] Should Clinic have "nullable" or types=NoneType?

Larry Hastings added the comment: The final version of this has been implemented as part of 41fb7fd04b5d for issue #24001. However, I'll mention here for posterity's sakes: there's an additional discussion on #24145. (Everyone on the nosy list has already been invite

[issue24146] ast.literal_eval doesn't support the Python ternary operator

New submission from Larry Hastings: ast.literal_eval() supports all Python operators, yes? No. It doesn't support "if/else", Python's ternary operator. Is there a reason it does not? I think it probably should. -- messages: 242760 nosy: benjamin.peterson,

[issue21520] Erroneous zipfile test failure if the string 'bad' appears in pwd

Larry Hastings added the comment: Checked in, with the filter function on a separate line, to 3.4. Also merged into 3.5. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker <http://bug

[issue20274] sqlite module has bad argument parsing code, including undefined behavior in C

Larry Hastings added the comment: I'm gonna fix this now. (I'm cleaning up some old issues I filed on the bug tracker this morning.) For 3.4, I'm just removing the PyObject *kwargs for those three functions that don't actually accept keyword arguments (METH_VARARGS) an

[issue20274] sqlite module has bad argument parsing code, including undefined behavior in C

Changes by Larry Hastings : -- assignee: ghaering -> larry resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bugs.python

[issue20274] sqlite module has bad argument parsing code, including undefined behavior in C

Changes by Larry Hastings : -- versions: +Python 3.5 ___ Python tracker <http://bugs.python.org/issue20274> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20274] sqlite module has bad argument parsing code, including undefined behavior in C

Larry Hastings added the comment: Yes, all those bugs exist in 2.7. However, Benjamin hasn't responded to this bug, so I assume he doesn't care and I should leave 2.7 alone. -- ___ Python tracker <http://bugs.python.o

[issue20274] sqlite module has bad argument parsing code, including undefined behavior in C

Larry Hastings added the comment: Benjamin: I assume you want the extraneous (and undefined behavior) kwargs parameters removed. Do you also want pysqlite_connection_call() to start calling _PyArg_NoKeywords()? -- ___ Python tracker <h

[issue20274] sqlite module has bad argument parsing code, including undefined behavior in C

Changes by Larry Hastings : -- versions: +Python 2.7 ___ Python tracker <http://bugs.python.org/issue20274> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24138] Speed up range() by caching and modifying long objects

Larry Hastings added the comment: I'd rather have the general-purpose freelist for ints too. How about we close this issue now, and assuming the freelist for ints goes in we can abandon this approach entirely. -- resolution: -> rejected stage: patch review -> resolved s

[issue15027] Faster UTF-32 encoding

Larry Hastings added the comment: We're still in alpha, so it's fine for 3.5 right now. The cutoff for new features for 3.5 will be May 23. -- ___ Python tracker <http://bugs.python.o

[issue17394] Add slicing support to collections.deque

Changes by Larry Hastings : -- nosy: +larry ___ Python tracker <http://bugs.python.org/issue17394> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17394] Add slicing support to collections.deque

Larry Hastings added the comment: For the record, Raymond asked for permission to check this in (a new feature) for 3.5 beta 2, as he won't have time to finish it before beta 1. As 3.5 release manager I've given him permission.

[issue24268] PEP 489 -- Multi-phase extension module initialization

Larry Hastings added the comment: If it makes sense, can you guys check it in soon, like in real-time here? I tag 3.5 beta 1 in about an hour, and since this is a "bug-fix" it's legitimate to go in. -- ___ Python tracker <http

[issue24281] String formatting: incorrect number of decimal places

Changes by Larry Hastings : -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue24281> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27355] Strip out the last lingering vestiges of Windows CE support

Larry Hastings added the comment: Refreshed the patch. With a Misc/NEWS entry I think it's ready for checkin. WFM on Linux 64-bit with gcc; can I get people to try other platforms? * os x (clang) * win32 * win64 -- Added file: http://bugs.python.org/file44378/larry.dont.wi

[issue27355] Strip out the last lingering vestiges of Windows CE support

Larry Hastings added the comment: Committed. Bye bye Windows CE! -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue27960] Distutils tests are broken in 3.4

New submission from Larry Hastings: 3.4.5 shipped with a working test suite. Since the release of 3.4.5 somebody broke test_distutils in the 3.4 branch. It needs to be fixed. jason.coombs: AFAICT you were the last person to touch it. Are you the one who broke it? % ./python -m test

[issue27850] Remove 3DES from cipher list (sweet32 CVE-2016-2183)

Larry Hastings added the comment: I don't think "remove de-recommended cypher" qualifies as a security fix for 3.3 or 3.4. Certainly you're not permitted to add ChaCha20 to 3.3 or 3.4. IMO these changes should only be in 2.7 and 3.5+. -- versions: -Py

[issue27850] Remove 3DES from cipher list (sweet32 CVE-2016-2183)

Larry Hastings added the comment: > The difference between a security feature and a security fix > is incredibly hard to differentiate. I'm not buying this argument. > For instance, with 3DES being de-recommended (and removed in future > OpenSSLs) that leaves basically onl

[issue27850] Remove 3DES from cipher list (sweet32 CVE-2016-2183)

Larry Hastings added the comment: Here at the core dev sprint we had a discussion about whether adding ChaCha20 into 3.5 was the right call. Strictly speaking, of course, it's neither a bug fix or a security fix, so that suggests it shouldn't be permitted. However ultimately we co

[issue27850] Remove 3DES from cipher list (sweet32 CVE-2016-2183)

Larry Hastings added the comment: > FWIW the cipher list (at least the restricted ones for > ssl.create_default_context()) is explicitly documented > as being able to be changed at any time without prior deprecation Yes. To be specific: "The protocol, options, cipher and othe

[issue27995] Upgrade Python 3.4 to OpenSSL 1.0.2h on Windows

Changes by Larry Hastings : -- nosy: +larry title: Upgrade Python 3.4 to OpenSSL 1.0.2h -> Upgrade Python 3.4 to OpenSSL 1.0.2h on Windows ___ Python tracker <http://bugs.python.org/issu

[issue27850] Remove 3DES from cipher list (sweet32 CVE-2016-2183)

Larry Hastings added the comment: Okay. We (Ned Deily + Steve Dower + me) talked it over here at the core dev sprints, and they convinced me that it's basically okay to add the CHACHA20 string to 3.4 and 3.5--it has some history, and OpenSSL is a little different, etc etc. So go for i

[issue27995] Upgrade Python 3.4 to OpenSSL 1.0.2h on Windows

Larry Hastings added the comment: I talked this over with Steve Dower, the current "platform expert" for Windows. As he points out: the 3.4 Windows build is effectively unsupported. The Windows platform expert for Python 3.4 resigned from core Python development. Also, of c

[issue27850] Remove 3DES from cipher list (sweet32 CVE-2016-2183)

Larry Hastings added the comment: > My reading of this is that for OpenSSL Python defines a range of > compatible sonames at the time of the first release in a series (e.g. > 3.4.0), and then will never extend that in either direction for that > release series. Put another way: patch

[issue27850] Remove 3DES from cipher list (sweet32 CVE-2016-2183)

Larry Hastings added the comment: I agree completely Jim. The problem is that OpenSSL regularly discovers face-meltingly bad security bugs, so it frequently pulls the "security exception" lever. As with so many things in this life, we play the hand we're dealt. I have my

[issue28257] Regression for star argument parameter error messages

Larry Hastings added the comment: It's too late to change this for 3.5. -- versions: -Python 3.5 ___ Python tracker <http://bugs.python.org/issue28257> ___ ___

[issue21109] tarfile: Traversal attack vulnerability

Changes by Larry Hastings : -- nosy: -larry ___ Python tracker <http://bugs.python.org/issue21109> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28406] Possible PyUnicode_InternInPlace() edge-case bug

New submission from Larry Hastings: A visual inspection of PyUnicode_InternInPlace() suggests there might be a rare edge-case bug lurking there. Specifically, the bug has to do with "interned mortal" strings. Interned mortal strings are stored in the static "interned" di

[issue28406] Possible PyUnicode_InternInPlace() edge-case bug

Larry Hastings added the comment: Ah, indeed. My mistake--I'm working in the Gilectomy branch, which is hilariously out of date. (It's stuck in February 2016.) The new version using PyDict_SetDefault() won't have *this* specific problem. Perhaps later I'll read the n

[issue28754] Argument Clinic for bisect.bisect_left

Larry Hastings added the comment: There's special syntax to handle aliases. From comments in clinic.py: # alternatively: # modulename.fnname [as c_basename] = modulename.existing_fn_name # clones the parameters and return converter from that # function.

[issue28754] Argument Clinic for bisect.bisect_left

Larry Hastings added the comment: Oh, and, if the code literally asserts they're the same function, that's just a sanity check based on the implementation. You could preserve that if you care to, or you could just write a new function and remove the assertion. Do what you thi

[issue28753] Clinic: Converting Your First Function is not up to date

Larry Hastings added the comment: The bit about the "clinic/_" include is a good point. Care to write a doc patch? The bit about FASTCALL I don't know anything about because I haven't worked with FASTCALL. I've added Victor Stinner, the author of the FASTCALL pat

[issue28753] Clinic: Converting Your First Function is not up to date

Larry Hastings added the comment: I understand your concern as a non-English speaker, but your patch was really pretty good. I did edit it a little; how's this? -- Added file: http://bugs.python.org/file45566/larry.issue28753.diff ___ P

[issue28753] Clinic: Converting Your First Function is not up to date

Changes by Larry Hastings : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue28753> ___ ___

[issue28753] Clinic: Converting Your First Function is not up to date

Larry Hastings added the comment: Let's see what Victor has to say. -- ___ Python tracker <http://bugs.python.org/issue28753> ___ ___ Python-bugs-list m

<    19   20   21   22   23   24