Larry Hastings added the comment:
Marking as closed for now. If we decide it's a problem we can reopen later.
--
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.
Larry Hastings added the comment:
I don't think it'd be appropriate to backport to 3.4--that ship has sailed.
3.4 requires a stacklevel=8 and that's that.
If we backported it and it shipped in 3.4.4, "correct" code would have to use a
stacklevel=8 for 3.4.0 throug
Changes by Larry Hastings :
--
priority: release blocker -> deferred blocker
___
Python tracker
<http://bugs.python.org/issue25005>
___
___
Python-bugs-list mai
Larry Hastings added the comment:
Marking this as deferred, as I'm not convinced I should ship either of those
patches in 3.5.0rc3.
--
nosy: +larry
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
What happened with this?
--
___
Python tracker
<http://bugs.python.org/issue24585>
___
___
Python-bugs-list mailing list
Unsub
Larry Hastings added the comment:
Yes, I saw that. That doesn't mean we should change the interface they are
using (incorrectly) eighteen months after it shipped. We take
backwards-compatibility pretty seriously here in the Python world, bugs an
Larry Hastings added the comment:
Unless I'm overruled, yes.
--
___
Python tracker
<http://bugs.python.org/issue24305>
___
___
Python-bugs-list mailing list
Larry Hastings added the comment:
Having slept on it, I agree with Steve. We should make the minimal change
necessary in order to not crash.
However, it still needs a regression test. The test can use JohnLeitch's
proposed test as a good starting point, but it must accept either succe
Larry Hastings added the comment:
I want to ship something, but I don't think it'll be either of those patches in
their current form.
Maybe I'm dense, but I don't feel like I understand these patches. They have
very different approaches.
The first one attempts to rehab
Larry Hastings added the comment:
Steve, did you confirm that the test triggers the array bounds bug when the
patch *isn't* applied? I want to confirm both that a) the test exercises the
bug, and b) the fix fixes the bug. I assume you ran the test suite with the
patch applied, so
Larry Hastings added the comment:
Okay, I think *I* reproduced it.
1) I pulled your cpython350 fork down locally.
2) I updated to your checkin that fixed the bug. (c31dad22c80d)
3) I reverted the change to Modules/timemodule.c to put the bug back:
% hg cat -r 97393 Modules/timemodule.c
Larry Hastings added the comment:
So is this considered broken enough that I need to accept a fix for 3.5.0? And
has a consensus been reached about exactly what that fix would be?
--
___
Python tracker
<http://bugs.python.org/issue23
Larry Hastings added the comment:
Reassigning to 3.6.
--
priority: deferred blocker -> release blocker
versions: +Python 3.6 -Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.org/issu
Larry Hastings added the comment:
I'm leaving this open just because we're apparently waiting on some "What's
New" docs.
--
___
Python tracker
<http:
Larry Hastings added the comment:
Well, I'm already holding up rc3 on one other issue, might as well fix this
too. Can somebody make me a pull request?
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
I suspect we're not fixing this in 3.4, so I'm removing 3.4 from the version
list.
--
versions: -Python 3.4
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
So, whatever the security hole is that subprocess.call(shell=True) leaves open,
os.startfile() doesn't have? os.startfile() doesn't use a shell? (How does it
find the full path to the executable?)
--
Larry Hastings added the comment:
Well, so, what do you recommend I do here?
--
___
Python tracker
<http://bugs.python.org/issue25005>
___
___
Python-bugs-list m
Larry Hastings added the comment:
Backout pull request merged, please forward-merge, thanks!
--
___
Python tracker
<http://bugs.python.org/issue24917>
___
___
Larry Hastings added the comment:
Backout pull request merged, please forward-merge, thanks!
--
___
Python tracker
<http://bugs.python.org/issue25005>
___
___
Larry Hastings added the comment:
(I meant, just normal pull request. I did your two pull requests right in a
row and got my wires crossed.)
--
___
Python tracker
<http://bugs.python.org/issue24
Larry Hastings added the comment:
Okay, this is literally the only thing rc3 is waiting on now.
--
___
Python tracker
<http://bugs.python.org/issue23517>
___
___
Changes by Larry Hastings :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Larry Hastings :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue25005>
___
___
Larry Hastings added the comment:
This was backed out of 3.5, as we discovered it introduced a security hole just
before 3.5.0 shipped. (See issue 25005 for more.)
Since it's been backed out, I've reopened the issue. However I've moved it
forward to 3.6, as it's no lon
Changes by Larry Hastings :
--
nosy: -larry
___
Python tracker
<http://bugs.python.org/issue8232>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
Is it appropriate to make this change as a "bug fix", in already-released
versions of Python? Would you be happy or sad if you updated your Python from
3.x.y to 3.x.y+1 and the rounding method used when converting floats to
datetime stam
Larry Hastings added the comment:
Well, for now I assume it really truly genuinely isn't going in 3.5.0. I
suppose we can debate about 3.4.x and 3.5.1 later, once we have a fix everybody
is happy with.
--
___
Python tracker
Larry Hastings added the comment:
If the guy doing the work says "don't merge it in 3.5.0", and we're at the
final release candidate before 3.5.0 final ships, and we don't even have a
patch that everyone likes yet... it does seem like it's not going to happen fo
Larry Hastings added the comment:
Doc fixes are always welcome. Barring mishaps I should tag 3.5.0 final on
Saturday; it'd be sweet if you could get me your diff no later than Friday
night.
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
I fixed it. My original attempted hack had bad regular expressions. Once my
regular expressions worked properly it was all fine.
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -&g
Larry Hastings added the comment:
This is your wheelhouse, Steve.
--
assignee: -> steve.dower
___
Python tracker
<http://bugs.python.org/issue25027>
___
___
Py
Larry Hastings added the comment:
Any clue here? Is this unaligned access?
--
___
Python tracker
<http://bugs.python.org/issue25029>
___
___
Python-bugs-list m
Larry Hastings added the comment:
I'm the author of capsulethunk.h, and I am happy to relicense it under MIT.
How would you feel about leaving capsulethunk.h there, for posterity's sakes,
but adding "for updates please see py3c"? We could even update the
capsulethunk.h th
Larry Hastings added the comment:
I wish people wouldn't remove old patches. There's no harm in leaving them,
and it may be a useful historical record.
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
Does this need a Misc/NEWS entry?
--
___
Python tracker
<http://bugs.python.org/issue25029>
___
___
Python-bugs-list mailin
Changes by Larry Hastings :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue25027>
___
___
Python-bugs-list mailing list
Unsubscrib
Larry Hastings added the comment:
Given Victor's reluctance to get this in to 3.5.0, this can't even be marked as
a "deferred blocker" anymore. Demoting to normal priority.
--
priority: deferred blocker -> normal
__
Larry Hastings added the comment:
Here's an attempt at a What's New section for this change. I expect it's
wrong! Maybe someone can fix it. Maybe it's actually better than not having
one at all.
Can we maybe get a round or two of edits on this and get somethi
Larry Hastings added the comment:
Given Victor's reluctance to get this in to 3.5.0, this can't even be marked as
a "deferred blocker" anymore. Demoting to normal priority.
--
priority: deferred blocker -> normal
__
Larry Hastings added the comment:
The Misc/NEWS entry for this was added under Python 3.5.0rc3. But, since no
pull request has been made for this change, this change hasn't been merged into
3.5.0. It will ship as part of Python 3.5.1. I've moved the Misc/NEWS entry
a
Larry Hastings added the comment:
Pull request accepted! Please forward-merge, thanks!
--
___
Python tracker
<http://bugs.python.org/issue24272>
___
___
Pytho
Larry Hastings added the comment:
Pull request approved. Hopefully the last one for 3.5.0! Please forward-merge.
--
___
Python tracker
<http://bugs.python.org/issue25
Larry Hastings added the comment:
Pull request accepted. Please forward-merge, thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Larry Hastings added the comment:
It's fixed! So it's finally closed.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs
Larry Hastings added the comment:
You wait until the day of release for 3.5.0 final, then create a "release
blocker" because some items in the What's New documentation aren't
lexographically sorted?
We tagged the release yesterday. The installers are already built. I am
Larry Hastings added the comment:
First, the What's New on the website is generated from the 3.5 branch in
hg.python.org. So it's already up-to-date. That's the one most people will
refer to.
Second, if the What's New was really that horribly out of date, and we wanted
Larry Hastings added the comment:
I'm hoping to release 3.5.0 final in the next hour or two. I don't want to
hold up the release for your changes. However, when you're done making changes
to the document, and they're all checked in, let me know and I'll manually
bu
Larry Hastings added the comment:
The "Detailed Release Information" link is correct. You probably just have an
old cached copy of something.
I could add a "What's New" link somewhere.
Though both of these things are interesting, neither of them is relevant to
thi
Larry Hastings added the comment:
I don't know how to do it. I asked the Documentation Expert member of the
Python 3.5 release team, but it seems he's afk at the moment. I'm trying to
find someone else who knows how to do it.
--
___
Larry Hastings added the comment:
Tracebacks aren't my forte, but this does smell like a regression and something
that should be fixed.
My worry about things like this is that it isn't as much a "bug" as a "badly
implemented interface". As in, that's th
Larry Hastings added the comment:
Old version stuck in the CDN cache. I cleared the cache, it's fine now.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.pyth
Larry Hastings added the comment:
When I built the documentation, I used
% release.py --export 3.5.0
(release.py coming from hg.python.org/release, a collection of release manager
tools.) I then installed this build as the 3.5.0 documentation, specifically
the build from "python-
Larry Hastings added the comment:
Python 3.5 is not supported on Windows XP.
The Python core dev team's policy is, a major Python version (e.g. 3.4, 3.5)
only supports the Windows versions that are currently supported by Microsoft at
the time of the initial release (e.g. 3.4.0 final,
Larry Hastings added the comment:
Is this a change (I hesitate to use the word "regression") as of Python 3.5.0?
--
nosy: +larry
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
That's an interesting thought, eryksun. I'll pass it along to the python.org
web developers.
Djoudi, it is mentioned on the Python web site, in the What's New In Python 3.5
document:
https://docs.python.org/3.5/whatsnew/3.5.html#unsupp
Larry Hastings added the comment:
Well, even if the Windows build was on fire and children were dying, we
couldn't do anything about it until next week--Steve's on vacation. I expect
he'll weigh in on this when he gets back.
--
___
Larry Hastings added the comment:
They don't go there, they go in https://docs.python.org/3.5/archives/
Where is the documentation that this
"https://www.python.org/ftp/python/doc/3.5.0/"; directory is an officially
supp
Larry Hastings added the comment:
The official way to download the documentation is from this page:
https://docs.python.org/3.5/download.html
which links to the "archives" directory.
When python.org changed to the new site, some things moved around. I guess
this was one of th
Changes by Larry Hastings :
--
nosy: +larry
___
Python tracker
<http://bugs.python.org/issue18967>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
Okay. I got tired of the constant Misc/NEWS merge conflicts, so I wrote a tool
to fix the problem. It's checked in to Bitbucket here:
https://bitbucket.org/larry/mergenews/
There's a readme, which you'll see rendered on that page.
I don&
Larry Hastings added the comment:
In case you're too lazy to go visit the link to my "mergenews" repository and
read the readme...
mergenews has three tools:
* splitnews, which splits the existing Misc/NEWS file into hundreds of
individual files,
* mergenews, which merges
Larry Hastings added the comment:
> [...] commit messages are for other developers, which news entries are
> ultimately for users. Some developers want (insist on) the freedom to
> make the two different, with different details.
That's easy enough to accommodate. I updated &q
Larry Hastings added the comment:
I don't agree that in all cases the Misc/NEWS entry and the checkin comment
must be wholly different. While I concur that that's called for now and again,
I believe this to be rare. Most checkins are small changes, and a single-line
summary for
Larry Hastings added the comment:
Why is this marked as a release blocker? It doesn't strike me as all that
major.
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
Describing this as a "security sensitive issue" is being facile. It's more
appropriate to describe this as a "new feature", aka, something that does not
go in after x.y.0 final.
Please only check this
Larry Hastings added the comment:
I should clarify, I don't speak for 2.7. The rules there are a little
different and it's up to Benjamin to decide. But please don't add new features
to 3.4 and 3.5.
--
___
Python tracker
<http
Larry Hastings added the comment:
I think it's about time to think about releasing 3.5.1. But since this bug is
marked as a "release blocker", 3.5.1 cannot be released until this is fixed.
Arguably I can't even really make a schedule for 3.5.1 until it's fixed, or
Larry Hastings added the comment:
Okay, I'm scheduling 3.5.1rc1 on the assumption that you'll check in by next
weekend. If you're going to slip please let me know and I'll slip accordingly.
--
___
Python tracker
<http://bug
Larry Hastings added the comment:
I don't plan to hold up 3.5.1 for this.
--
priority: release blocker -> normal
___
Python tracker
<http://bugs.python.org
Changes by Larry Hastings :
--
priority: release blocker -> normal
___
Python tracker
<http://bugs.python.org/issue25660>
___
___
Python-bugs-list mai
Larry Hastings added the comment:
The "release blocker" priority level is inappropriate for nice-to-have
features. Quoting PEP 101, the how-to-make-a-Python-release guide:
release blocker - Stops the release dead in its tracks. You may
not make any releas
Larry Hastings added the comment:
This change didn't make it into 3.5.1. It will be released with 3.5.2. I've
already updated the Misc/NEWS entry.
--
nosy: +larry
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
This change didn't make it into 3.5.1. It will be released with 3.5.2. I've
already updated the Misc/NEWS entry.
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
I read some comments here and on the patches. Serhiy's patch adds some code
and Victor says you can't call that macro on this object and wow this is badly
broken. Can someone explain in simpler terms what's so
Larry Hastings added the comment:
Is this going in soon? I want to cherry-pick this for 3.5.1, which I tag in
about 80 hours.
--
___
Python tracker
<http://bugs.python.org/issue25
Larry Hastings added the comment:
You can have it in 3.5.1, and we can negotiate about how to get it in.
--
___
Python tracker
<http://bugs.python.org/issue25
Larry Hastings added the comment:
> Please look at http://bugs.python.org/issue25779.
You closed that one and marked it "not a bug"...?
--
___
Python tracker
<http://bugs.pytho
Larry Hastings added the comment:
Fixed in 3.5.1 final.
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Larry Hastings added the comment:
I don't agree that a reference cycle counts as a release blocker.
--
nosy: +larry
priority: release blocker -> normal
___
Python tracker
<http://bugs.python.org
Larry Hastings added the comment:
I'm not going to hold up 3.5.1 for this.
--
priority: release blocker -> high
___
Python tracker
<http://bugs.python.org
Larry Hastings added the comment:
I cherry-picked this for 3.5.1.
--
___
Python tracker
<http://bugs.python.org/issue25709>
___
___
Python-bugs-list mailin
Larry Hastings added the comment:
You're a little late; 3.5.1 was released two days ago.
--
___
Python tracker
<http://bugs.python.org/issue24931>
___
___
Larry Hastings added the comment:
Like I said--no.
--
___
Python tracker
<http://bugs.python.org/issue25624>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
I'm assuming this is a configuration issue on the buildbots.
--
priority: release blocker -> low
___
Python tracker
<http://bugs.python.org
Larry Hastings added the comment:
I hear your plea. But isn't it almost as easy to just leave it alone? 3.4
won't get many checkins from now on, so it won't actually kick off many tasks.
But it would mean the "check the buildbots" step of making a release would be
Larry Hastings added the comment:
Unless you can explain what bugs this is causing, I don't see any need to
change the behavior.
--
resolution: -> not a bug
status: open -> closed
___
Python tracker
<http://bugs.python.
Larry Hastings added the comment:
How does it break? Maybe you could explain more.
--
___
Python tracker
<http://bugs.python.org/issue25930>
___
___
Python-bug
Larry Hastings added the comment:
Even if this was a good idea, it's too late to change the behavior of the
builtin function.
--
resolution: -> rejected
stage: -> resolved
status: open -> closed
___
Python tracker
<http:
Larry Hastings added the comment:
Nope. Argument Clinic was merged in 3.4, and in 3.3 pwd.getpwuid wouldn't
accept strings. So this isn't a bug introduced in the Clinic conversion in
3.4, this is historical behavior, and we can't change it now.
If anything, I'd pre
Larry Hastings added the comment:
Yeah, change "curl" to "curly". If you commit the fix without a test case I'd
forgive you. Or I can do it if that makes you nervous.
--
___
Python tracker
<http:
Larry Hastings added the comment:
>Modules/_opcode.c: Issue 19674 (3.4). Only one function I can see there
> (Larry’s original post says two sites).
I produced the post with a big grep through the codebase. Which was quite a
while ago now. Code changes and moves around; if you ca
Larry Hastings added the comment:
Christian: Is that CVE the same crash as reported by mail by Gustavo Grieco?
--
___
Python tracker
<http://bugs.python.org/issue26
Larry Hastings added the comment:
I approve in principle, but this patch isn't ready.
If we compile on Win32, and allow_fd is on, and they pass in an invalid fd,
your patched code will reach line 914 "length = PyBytes_GET_SIZE(bytes);" but
bytes will b
Larry Hastings added the comment:
Can you post the updated patch please?
--
___
Python tracker
<http://bugs.python.org/issue26671>
___
___
Python-bugs-list mailin
Larry Hastings added the comment:
LGTM.
--
___
Python tracker
<http://bugs.python.org/issue26671>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
You should find a different reviewer. I don't really care about "const". I'll
live with it if it's there but I'm not going to go around adding it.
--
___
Python tracker
<
New submission from Larry Hastings:
Obmalloc now has theoretical support for locking. I say theoretical because
I'm not convinced it's ever been used.
The interface is defined through five macros:
SIMPLELOCK_DECL
SIMPLELOCK_INIT
SIMPLELOCK_FINI
SIMPL
Larry Hastings added the comment:
There's already a comment saying that the macros are empty because the GIL
protects obmalloc from parallelization.
I'd be happy to improve the code and add calls for LOCK_INIT and LOCK_FINI in
the proper places. You don't have to do it. S
Larry Hastings added the comment:
FWIW, the patch still cleanly applies, but now a couple tests in posix fail
because the assertion text has changed.
--
___
Python tracker
<http://bugs.python.org/issue24
2101 - 2200 of 2389 matches
Mail list logo
