[issue24824] Pydoc fails with codecs

2015-08-08 Thread Larry Hastings
Larry Hastings added the comment: Can we do better? How about a new field on the Parameter object, "symbolic_default_value", which shows you the expression used to compute the value? We could then set default_value to the result of the expression, pydoc could print the symbolic

[issue24824] Pydoc fails with codecs

2015-08-08 Thread Larry Hastings
Larry Hastings added the comment: I just tried every module, simulating pydoc on it. codecs is the only one that failed. So, I can live with just changing codecs for now. But let's do it properly in 3.6. Go ahead and check in for 3.5--or, if you don't get it done before I want

[issue24824] Pydoc fails with codecs

2015-08-08 Thread Larry Hastings
Larry Hastings added the comment: That's a fine change for 3.5. For 3.6 I want to solve the general problem, at which point we can switch back to calling sys.getdefaultencoding() if we like. Serhiy, can you make a patch a post it here? I want to tag 3.5.0rc1 in one or two

[issue24824] Pydoc fails with codecs

2015-08-08 Thread Larry Hastings
Larry Hastings added the comment: Please change "Default encoding is" to "The default encoding is". Apart from that, LGTM, please check in! -- ___ Python tracker <http://bug

[issue23973] PEP 484 implementation

2015-08-08 Thread Larry Hastings
Larry Hastings added the comment: Can we mark this closed now? -- nosy: +larry ___ Python tracker <http://bugs.python.org/issue23973> ___ ___ Python-bugs-list m

[issue24585] Windows installer does not detect existing installs

2015-08-08 Thread Larry Hastings
Larry Hastings added the comment: Did this work as hoped in beta 4? Can we mark it as fixed now? -- ___ Python tracker <http://bugs.python.org/issue24

[issue24732] 3.5.0b3 Windows accept() on unready non-blocking socket raises PermissionError

2015-08-08 Thread Larry Hastings
Larry Hastings added the comment: If this is now fixed but still needs a unit test, can I change it from "release blocker" to "high" priority? -- nosy: +larry ___ Python tracker <http://bug

[issue24272] PEP 484 docs

2015-08-08 Thread Larry Hastings
Larry Hastings added the comment: I assume what we've got is good enough for rc1? Can we mark this closed / reduce the priority from "release blocker"? Note that there are few (if any) restrictions on fixing docs during the release candidates. (Though after today we'll

[issue24824] Pydoc fails with codecs

2015-08-09 Thread Larry Hastings
Larry Hastings added the comment: Fixed. Thanks, Serhiy! -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue24667] OrderedDict.popitem()/__str__() raises KeyError

2015-08-09 Thread Larry Hastings
Larry Hastings added the comment: Yeah, I stopped it at 300k iterations. No problems. Glad this fix got in for rc1. -- ___ Python tracker <http://bugs.python.org/issue24

[issue24732] 3.5.0b3 Windows accept() on unready non-blocking socket raises PermissionError

2015-08-09 Thread Larry Hastings
Changes by Larry Hastings : -- priority: release blocker -> high ___ Python tracker <http://bugs.python.org/issue24732> ___ ___ Python-bugs-list mailing list Un

[issue24834] pydoc should display the expression for a builtin argument default, not its result

2015-08-09 Thread Larry Hastings
New submission from Larry Hastings: As discussed in #24824, inspect.Parameter currently only has a place to store the value of a default argument. Which means, if a complicated bit of code was used to produce that default argument, all we have left is the value, not the code that arrived at

[issue24272] PEP 484 docs

2015-08-09 Thread Larry Hastings
Changes by Larry Hastings : -- priority: release blocker -> high ___ Python tracker <http://bugs.python.org/issue24272> ___ ___ Python-bugs-list mailing list Un

[issue24585] Windows installer does not detect existing installs

2015-08-09 Thread Larry Hastings
Larry Hastings added the comment: Quoting from PEP 101: release blocker - Stops the release dead in its tracks. You may not make any release with any open release blocker bugs. So, yeah, I want to. -- priority: release blocker -> criti

[issue23973] PEP 484 implementation

2015-08-09 Thread Larry Hastings
Changes by Larry Hastings : -- priority: release blocker -> high ___ Python tracker <http://bugs.python.org/issue23973> ___ ___ Python-bugs-list mailing list Un

[issue24835] Consistent failure in test_asyncio on Windows 7 buildbot

2015-08-09 Thread Larry Hastings
New submission from Larry Hastings: The Python 3.5 buildbot for Windows 7 consistently fails during test_asyncio. The buildbots are here: http://buildbot.python.org/all/waterfall?category=3.5.stable An example log file: http://buildbot.python.org/all/builders/x86%20Windows7%203.5/builds/173

[issue24836] Consistent failure in test_email on OS X Snow Leopard buildbot for Python 3.5

2015-08-09 Thread Larry Hastings
New submission from Larry Hastings: The Snow Leopard buildbot for Python 3.5 consistently fails in the regression test for the email module. The 3.5 buildbots are here: http://buildbot.python.org/all/waterfall?category=3.5.stable Example log file: http://buildbot.python.org/all/builders

[issue24836] Consistent failure in test_email on OS X Snow Leopard buildbot for Python 3.5

2015-08-09 Thread Larry Hastings
Larry Hastings added the comment: Thanks for diagnosing the problem, David! -- keywords: +buildbot priority: critical -> normal ___ Python tracker <http://bugs.python.org/issu

[issue24745] Better default font for editor

2015-08-09 Thread Larry Hastings
Larry Hastings added the comment: We're retagging 3.5.0rc1 to fix this and one other regression. Can someone step up and get this fix checked in in the next six or eight hours? You can just check in to the 3.5 branch on hg.python.org/cpython like normal (you won't have to use Bit

[issue24835] Consistent failure in test_asyncio on Windows 7 buildbot

2015-08-09 Thread Larry Hastings
Larry Hastings added the comment: We're retagging 3.5.0rc1 to fix this and one other regression. Can someone step up and get this fix checked in in the next six or eight hours? You can just check in to the 3.5 branch on hg.python.org/cpython like normal (you won't have to use Bit

[issue24835] Consistent failure in test_asyncio on Windows 7 buildbot

2015-08-09 Thread Larry Hastings
Larry Hastings added the comment: I don't have one either. But that's why we've got buildbots. The Windows 7 buildbot, where I first noticed the regression, is here: http://buildbot.python.org/all/builders/x86%20Windows7%203.5 It should be done testing your patch 1 hour and

[issue24835] Consistent failure in test_asyncio on Windows 7 buildbot

2015-08-09 Thread Larry Hastings
Larry Hastings added the comment: The buildbot passes the test! Hooray! -- ___ Python tracker <http://bugs.python.org/issue24835> ___ ___ Python-bugs-list mailin

[issue24839] platform._syscmd_ver raises DeprecationWarning

2015-08-10 Thread Larry Hastings
Larry Hastings added the comment: Yes, I'll accept that for 3.5.0. Paste a link to a pull request here at your earliest convenience (and opportunity). -- ___ Python tracker <http://bugs.python.org/is

[issue24492] using custom objects as modules: AttributeErrors new in 3.5

2015-08-10 Thread Larry Hastings
Larry Hastings added the comment: I would like the fix in 3.5. However, I'm not qualified to review the code. Can you get a qualified reviewer in to look over the code? Once someone suitable has reviewed it, I'll accept a pull request (pasted in here

[issue24492] using custom objects as modules: AttributeErrors new in 3.5

2015-08-10 Thread Larry Hastings
Changes by Larry Hastings : -- assignee: larry -> brett.cannon ___ Python tracker <http://bugs.python.org/issue24492> ___ ___ Python-bugs-list mailing list Un

[issue24839] platform._syscmd_ver raises DeprecationWarning

2015-08-10 Thread Larry Hastings
Larry Hastings added the comment: Not yet. I'll open it after I release 3.5.0rc1. I'll send email to clp-d and clp-c when I do. I can email you privately too if you like. -- ___ Python tracker <http://bugs.python.o

[issue24492] using custom objects as modules: AttributeErrors new in 3.5

2015-08-10 Thread Larry Hastings
Larry Hastings added the comment: Yes, Eric and Armin are both qualified reviewers in my book. You have my blessing to send a pull request. Thanks, everybody! -- ___ Python tracker <http://bugs.python.org/issue24

[issue24839] platform._syscmd_ver raises DeprecationWarning

2015-08-10 Thread Larry Hastings
Larry Hastings added the comment: My Bitbucket repo is now public. https://bitbucket.org/larry/cpython350 -- ___ Python tracker <http://bugs.python.org/issue24

[issue24492] using custom objects as modules: AttributeErrors new in 3.5

2015-08-10 Thread Larry Hastings
Larry Hastings added the comment: My Bitbucket repo is now public. https://bitbucket.org/larry/cpython350 -- ___ Python tracker <http://bugs.python.org/issue24

[issue24839] platform._syscmd_ver raises DeprecationWarning

2015-08-11 Thread Larry Hastings
Larry Hastings added the comment: They are currently in sync, yes. The 3.5 branch has been a ghost town the last day or two, which tbh has been pleasant for me.helpfu -- ___ Python tracker <http://bugs.python.org/issue24

[issue24839] platform._syscmd_ver raises DeprecationWarning

2015-08-11 Thread Larry Hastings
Larry Hastings added the comment: Merged. Please forward-port to 3.5.1 and 3.6. Thanks! (See? Already I can tell this rc-cycle is going to be way easier on me than 3.4 was.) -- ___ Python tracker <http://bugs.python.org/issue24

[issue24769] Interpreter doesn't start when dynamic loading is disabled

2015-08-11 Thread Larry Hastings
Larry Hastings added the comment: Uh, Nick? You didn't add me to this bug. -- nosy: +larry ___ Python tracker <http://bugs.python.org/issue24769> ___ ___

[issue9232] Allow trailing comma in any function argument list.

2015-08-11 Thread Larry Hastings
Larry Hastings added the comment: With PEP 448, we can now have fronkulate(**kwargs, **kwargs2) -- ___ Python tracker <http://bugs.python.org/issue9

[issue24844] Python 3.5rc1 compilation error with Apple clang 4.2 included with Xcode 4

2015-08-11 Thread Larry Hastings
Larry Hastings added the comment: I'd need to see the patch to be certain, but yes my assumption is I'd accept a pull request for this. -- ___ Python tracker <http://bugs.python.o

[issue24847] Can't import tkinter in Python 3.5.0rc1

2015-08-11 Thread Larry Hastings
Larry Hastings added the comment: I trust you, Steve, but I still want to see it get a review before I pull it. Can you find someone qualified to review the change? -- ___ Python tracker <http://bugs.python.org/issue24

[issue17703] Trashcan mechanism segfault during interpreter finalization in Python 2.7.4

2015-08-12 Thread Larry Hastings
Larry Hastings added the comment: Can anyone else confirm this bug in 3.4? -- ___ Python tracker <http://bugs.python.org/issue17703> ___ ___ Python-bugs-list m

[issue21167] float('nan') returns 0.0 on Python compiled with icc

2015-08-13 Thread Larry Hastings
Larry Hastings added the comment: Assuming that "ICC_NAN_STRICT" is only on for Intel icc: yes, please. -- ___ Python tracker <http://bugs.python.o

[issue24492] using custom objects as modules: AttributeErrors new in 3.5

2015-08-13 Thread Larry Hastings
Larry Hastings added the comment: Yep. This time I have foisted nearly all the work, including the forward-merging, onto y'all. *sits back, sips iced coffee* -- ___ Python tracker <http://bugs.python.org/is

[issue20851] Update devguide to cover testing from a tarball

2015-08-23 Thread Larry Hastings
Larry Hastings added the comment: To make the tarballs, I use the "release.py" script from here: https://hg.python.org/release and run "release.py --export ". I haven't peeked inside the black box to see how the sausage is made. -- _

[issue21167] float('nan') returns 0.0 on Python compiled with icc

2015-08-24 Thread Larry Hastings
Larry Hastings added the comment: Pull request accepted and merged. -- ___ Python tracker <http://bugs.python.org/issue21167> ___ ___ Python-bugs-list mailin

[issue24847] Can't import tkinter in Python 3.5.0rc1

2015-08-24 Thread Larry Hastings
Larry Hastings added the comment: Pull request accepted and merged. -- ___ Python tracker <http://bugs.python.org/issue24847> ___ ___ Python-bugs-list mailin

[issue24867] Asyncio Task.get_stack fails with native coroutines

2015-08-24 Thread Larry Hastings
Larry Hastings added the comment: Pull request accepted and merged. -- ___ Python tracker <http://bugs.python.org/issue24867> ___ ___ Python-bugs-list mailin

[issue24769] Interpreter doesn't start when dynamic loading is disabled

2015-08-24 Thread Larry Hastings
Larry Hastings added the comment: Yes, I'll accept this into 3.5.0, please send a pull request. -- ___ Python tracker <http://bugs.python.org/issue24769> ___ ___

[issue24844] Python 3.5rc1 compilation error with Apple clang 4.2 included with Xcode 4

2015-08-24 Thread Larry Hastings
Larry Hastings added the comment: Please either mark as wontfix or send me a pull request. -- ___ Python tracker <http://bugs.python.org/issue24844> ___ ___ Pytho

[issue24305] The new import system makes it impossible to correctly issue a deprecation warning for a module

2015-08-24 Thread Larry Hastings
Larry Hastings added the comment: The C implementation is making me nervous. My gut feeling is the Python implementation would be easier to get right. I still don't quite understand: what is the user-perceived result of this change? Module authors issuing a DeprecationWarning can no

[issue24305] The new import system makes it impossible to correctly issue a deprecation warning for a module

2015-08-24 Thread Larry Hastings
Larry Hastings added the comment: Is it really *impossible* to "correctly issue a deprecation warning for a module", as the title asserts? Or does the new import system simply make it *tiresome*? if sys.version_info.major == 3 and sys.version_info.minor == 4: stackleve

[issue24305] The new import system makes it impossible to correctly issue a deprecation warning for a module

2015-08-24 Thread Larry Hastings
Larry Hastings added the comment: If this has been broken since 3.3, I don't think it's a release blocker for 3.5. I'm willing to consider it a "bug" and accept a fix, but I'd prefer it to be as low-risk as possible (aka the Python version). Can someone fix th

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

2015-08-24 Thread Larry Hastings
Changes by Larry Hastings : -- title: The new import system makes it impossible to correctly issue a deprecation warning for a module -> The new import system makes it inconvenient to correctly issue a deprecation warning for a module ___ Pyt

[issue24847] Can't import tkinter in Python 3.5.0rc1

2015-08-24 Thread Larry Hastings
Changes by Larry Hastings : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue24769] Interpreter doesn't start when dynamic loading is disabled

2015-08-24 Thread Larry Hastings
Larry Hastings added the comment: I wanted to get this in to Python 3.5.0rc2, so I checked it in myself. Petr, I gave you credit in the checkin comment and Misc/NEWS. Hope that's okay! -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ver

[issue24769] Interpreter doesn't start when dynamic loading is disabled

2015-08-25 Thread Larry Hastings
Larry Hastings added the comment: That's correct, it's just in 3.5.0 at the moment. -- ___ Python tracker <http://bugs.python.org/issue24769> ___ ___

[issue24937] Multiple problems in getters & setters in capsulethunk.h

2015-08-25 Thread Larry Hastings
Larry Hastings added the comment: Given that capsulethunk is only needed for 2.6 (and previous), and those versions are no longer maintained by the Python core community, yes I'd be happy for you to take over maintainership and host it externally. I'm sure we could change the doc

[issue24769] Interpreter doesn't start when dynamic loading is disabled

2015-08-25 Thread Larry Hastings
Larry Hastings added the comment: I have merged it forward into 3.5.1 and 3.6. -- ___ Python tracker <http://bugs.python.org/issue24769> ___ ___ Python-bugs-list m

[issue24912] The type of cached objects is mutable

2015-08-25 Thread Larry Hastings
Larry Hastings added the comment: As Python 3.5 Release Manager, my official statement is: Eek! -- priority: high -> release blocker ___ Python tracker <http://bugs.python.org/issu

[issue24913] deque.index() overruns deque boundary

2015-08-26 Thread Larry Hastings
Larry Hastings added the comment: Please create a pull request at your earliest convenience. -- priority: high -> release blocker ___ Python tracker <http://bugs.python.org/issu

[issue24912] The type of cached objects is mutable

2015-08-26 Thread Larry Hastings
Larry Hastings added the comment: This exciting new feature was added in checkin c0d25de5919e addressing issue #22986. Perhaps the core devs who added it would like to chime in. -- nosy: +benjamin.peterson, njs ___ Python tracker <h

[issue24913] deque.index() overruns deque boundary

2015-08-26 Thread Larry Hastings
Larry Hastings added the comment: https://docs.python.org/devguide/devcycle.html#release-candidate-rc https://mail.python.org/pipermail/python-dev/2015-August/141167.html -- ___ Python tracker <http://bugs.python.org/issue24

[issue24975] Python 3.5 can't compile AST involving PEP 448 unpacking

2015-08-31 Thread Larry Hastings
Larry Hastings added the comment: Good catch! Please file a pull request via bitbucket. -- ___ Python tracker <http://bugs.python.org/issue24975> ___ ___ Pytho

[issue23517] datetime.utcfromtimestamp rounds results incorrectly

2015-09-01 Thread Larry Hastings
Larry Hastings added the comment: > too late for 3.5.0 How's that? -- ___ Python tracker <http://bugs.python.org/issue23517> ___ ___ Python-bugs-lis

[issue24975] Python 3.5 can't compile AST involving PEP 448 unpacking

2015-09-02 Thread Larry Hastings
Larry Hastings added the comment: Merged. Please forward-merge to 3.5.1 and 3.6, thanks! -- ___ Python tracker <http://bugs.python.org/issue24975> ___ ___ Pytho

[issue24913] deque.index() overruns deque boundary

2015-09-02 Thread Larry Hastings
Larry Hastings added the comment: Assigning to Brett, who has agreed to do the merge to 3.5.0 that Raymond has declined to do. -- assignee: larry -> brett.cannon nosy: +brett.cannon ___ Python tracker <http://bugs.python.org/issu

[issue24989] scan_eol() Buffer Over-read

2015-09-03 Thread Larry Hastings
Larry Hastings added the comment: Yes, please create a pull request for this patch. Thanks! And just to confirm: I just applied patch 2 to CPython, then undid the change to bytesio.c. The new test fails, and sometimes Python will segmentation fault. If I then apply the patch to bytesio.c

[issue24989] scan_eol() Buffer Over-read

2015-09-03 Thread Larry Hastings
Changes by Larry Hastings : -- priority: high -> release blocker ___ Python tracker <http://bugs.python.org/issue24989> ___ ___ Python-bugs-list mailing list Un

[issue24912] The type of cached objects is mutable

2015-09-03 Thread Larry Hastings
Larry Hastings added the comment: Mark, Victor, Benjamin: how do you feel about v2 patch vs rolling back the change entirely? -- ___ Python tracker <http://bugs.python.org/issue24

[issue21192] Idle: Print filename when running a file from editor

2015-09-03 Thread Larry Hastings
Larry Hastings added the comment: Terry, if you want this pulled in to Python 3.5.0, you'll need to create a pull request on Bitbucket. Instructions are here: https://mail.python.org/pipermail/python-dev/2015-August/141167.html and here: https://mail.python.org/pipermail/python-dev

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

2015-09-03 Thread Larry Hastings
Larry Hastings added the comment: Well, this is making me nervous to apply during the RCs. But... I'm willing to risk it. My price: I want to see this run on a bunch of otherwise-healthy buildbots to make sure it doesn't break any platforms. In case you've never done such

[issue24913] deque.index() overruns deque boundary

2015-09-03 Thread Larry Hastings
Larry Hastings added the comment: Merged. Please do a (null) merge forward into 3.5.1 and 3.6. Thanks! -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue21192] Idle: Print filename when running a file from editor

2015-09-03 Thread Larry Hastings
Larry Hastings added the comment: On the other hand, I do not hold with marking a minor cosmetic change like this as "release blocker". I'm willing to accept the change, given PEP 434, but I'm not going to delay any releases for it. -- priority: relea

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

2015-09-03 Thread Larry Hastings
Larry Hastings added the comment: That *is* easier, thanks. Though the UI for that is baffling. Protip: search for the section where all the "custom" builders are listed all in one section, three-quarters of the way down the page. --

[issue21192] Idle: Print filename when running a file from editor

2015-09-03 Thread Larry Hastings
Larry Hastings added the comment: Pull request accepted, please forward-merge. Thanks! > There is something odd about the size of your clone. My cpython > clone is 928 MB on disk with 30300 files, while the clone of my fork > of your repository is 1.59 GB for 14500 files. I have no

[issue24989] scan_eol() Buffer Over-read

2015-09-03 Thread Larry Hastings
Larry Hastings added the comment: Pull request accepted. Please forward-merge. Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue21998] asyncio: support fork

2015-09-04 Thread Larry Hastings
Larry Hastings added the comment: Surely this is too late for 3.5? -- nosy: +larry ___ Python tracker <http://bugs.python.org/issue21998> ___ ___ Python-bug

[issue22970] asyncio: Cancelling wait() after notification leaves Condition in an inconsistent state

2015-09-04 Thread Larry Hastings
Larry Hastings added the comment: Is anyone going to try and fix this for 3.5.0? Or should we "kick the can down the road" and reassign it to 3.6? -- nosy: +larry ___ Python tracker <http://bugs.python.o

[issue22980] C extension naming doesn't take bitness into account

2015-09-04 Thread Larry Hastings
Larry Hastings added the comment: I sure hope not. -- nosy: +larry ___ Python tracker <http://bugs.python.org/issue22980> ___ ___ Python-bugs-list mailin

[issue23623] Python 3.5 docs need to clarify how to set PATH, etc

2015-09-04 Thread Larry Hastings
Larry Hastings added the comment: Can we close this out? -- nosy: +larry ___ Python tracker <http://bugs.python.org/issue23623> ___ ___ Python-bugs-list mailin

[issue24745] Better default font for editor

2015-09-04 Thread Larry Hastings
Larry Hastings added the comment: Anything happening with this? We tag 3.5.0rc3 in about 36 hours. -- ___ Python tracker <http://bugs.python.org/issue24

[issue23517] datetime.utcfromtimestamp rounds results incorrectly

2015-09-04 Thread Larry Hastings
Larry Hastings added the comment: I will happy delegate to Tim Peters whether or not this should be fixed in 3.5.0, or whether it should wait until 3.5.1 or even 3.6. Tim, ball's in your court! -- ___ Python tracker <http://bugs.py

[issue24635] test_typing is flaky

2015-09-04 Thread Larry Hastings
Larry Hastings added the comment: Anything happening with this? We tag 3.5.0rc3 in about 36 hours. -- ___ Python tracker <http://bugs.python.org/issue24

[issue24748] Change of behavior for importlib between 3.4 and 3.5 with DLL loading

2015-09-04 Thread Larry Hastings
Larry Hastings added the comment: Anything happening with this? We tag 3.5.0rc3 in about 36 hours. -- ___ Python tracker <http://bugs.python.org/issue24

[issue21998] asyncio: support fork

2015-09-04 Thread Larry Hastings
Larry Hastings added the comment: I've remarked it as "normal" priority and moved it to 3.6. Not my problem anymore! :D -- priority: deferred blocker -> normal versions: +Python 3.6 -Python 3.4, Python 3.5 ___ Pyt

[issue21998] asyncio: support fork

2015-09-04 Thread Larry Hastings
Changes by Larry Hastings : -- nosy: -larry ___ Python tracker <http://bugs.python.org/issue21998> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24635] test_typing is flaky

2015-09-04 Thread Larry Hastings
Changes by Larry Hastings : -- priority: deferred blocker -> high ___ Python tracker <http://bugs.python.org/issue24635> ___ ___ Python-bugs-list mai

[issue21192] Idle: Print filename when running a file from editor

2015-09-04 Thread Larry Hastings
Larry Hastings added the comment: The pull requests are numbered by creation order, not by merge order. Normally I'd expect that yes, Serhiy's merge would include yours. But it didn't work out that way. If you look at the changeset graph: https://bitbucket.org/larry/cpython

[issue21192] Idle: Print filename when running a file from editor

2015-09-04 Thread Larry Hastings
Larry Hastings added the comment: There won't be conflicts with Serhiy's merge--just the opposite. His pull request was merged first, so it's perfect that he did his forward merge first. He's already resolved any conflicts with his merge, and so when you merge you&#

[issue24635] test_typing is flaky

2015-09-04 Thread Larry Hastings
Larry Hastings added the comment: Pull request accepted. Please forward merge, thanks! And, yes, this will be a null merge because you already separately committed it to 3.5. -- assignee: larry -> gvanrossum stage: needs patch -> resolved status: open -&g

[issue24917] time_strftime() Buffer Over-read

2015-09-04 Thread Larry Hastings
Larry Hastings added the comment: Yes, I'd like this fix in 3.5.0. One bit of feedback on the patch: outbuf is a char * (or wchar_t *), therefore outbuf[1] is a char (or wchar_t). You shouldn't compare it to NULL. I'm not sure we still support any compilers that define NU

[issue24917] time_strftime() Buffer Over-read

2015-09-05 Thread Larry Hastings
Larry Hastings added the comment: Rather than debating about how various platforms handle malformed format strings for strftime(), and whether or not they crash, we should simply prevent the native strftime() function from seeing them in the first place. I'd like the "v3" pa

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

2015-09-05 Thread Larry Hastings
Larry Hastings added the comment: Okay. Right now creating server-side clones is broken. So I have repurposed one of my existing (old, dead) server-side clones for testing this. It's called "ssh://h...@hg.python.org/larry/path_error2". I just fired off this change on

[issue24912] The type of cached objects is mutable

2015-09-05 Thread Larry Hastings
Larry Hastings added the comment: Because the BDFL asked that it be so. -- ___ Python tracker <http://bugs.python.org/issue24912> ___ ___ Python-bugs-list mailin

[issue24917] time_strftime() Buffer Over-read

2015-09-05 Thread Larry Hastings
Larry Hastings added the comment: Pull request accepted. Please forward-merge. Thanks! -- ___ Python tracker <http://bugs.python.org/issue24917> ___ ___ Pytho

[issue24748] Change of behavior for importlib between 3.4 and 3.5 with DLL loading

2015-09-05 Thread Larry Hastings
Larry Hastings added the comment: Pull request accepted. I had to do it manually, as I got a Misc/NEWS merge conflict. But from where I'm sitting it looks like Bitbucket understands the pull request was accepted and merged. Please forward-merge. T

[issue24748] Change of behavior for importlib between 3.4 and 3.5 with DLL loading

2015-09-05 Thread Larry Hastings
Changes by Larry Hastings : -- assignee: -> ncoghlan resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker <http://bugs.python

[issue24917] time_strftime() Buffer Over-read

2015-09-05 Thread Larry Hastings
Larry Hastings added the comment: The tests from this patch fail on Linux. - First: There is no trailing % test on Linux, and glibc's strftime() happily ignores a trailing %, so no ValueError is raised. Python should do either one or the other of the following: 1) Python should en

[issue24917] time_strftime() Buffer Over-read

2015-09-05 Thread Larry Hastings
Larry Hastings added the comment: The starting curly brace goes on the same line as the statement starting the block. Keywords followed by a left parenthesis get a space between the keyword and the parenthesis. It's a small matter, I'm really much more interested in reconciling th

[issue24917] time_strftime() Buffer Over-read

2015-09-05 Thread Larry Hastings
Larry Hastings added the comment: Sorry, maybe you inherited those violations. I was in a hurry and not in a charitable frame of mind. -- ___ Python tracker <http://bugs.python.org/issue24

[issue24917] time_strftime() Buffer Over-read

2015-09-05 Thread Larry Hastings
Larry Hastings added the comment: I have convinced myself that disallowing trailing % marks on all platforms is the right thing to do. Whether or not the underlying platform tolerates it, it is never *valid* input to strftime. I have a patch incubating at home. I'll put it up for r

[issue24917] time_strftime() Buffer Over-read

2015-09-05 Thread Larry Hastings
Larry Hastings added the comment: Oh, maybe it was all like that before. Sorry, I was in a hurry and not in a charitable frame of mind. -- ___ Python tracker <http://bugs.python.org/issue24

[issue24917] time_strftime() Buffer Over-read

2015-09-05 Thread Larry Hastings
Larry Hastings added the comment: I'm going to back this out of 3.5.0rc3. I'm still willing to discuss accepting it into 3.5.0 final in some form, but for now I don't want to hold up the release. Steve: it should never be possible to crash the Python interpreter with well-for

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

2015-09-06 Thread Larry Hastings
Larry Hastings added the comment: It was basically okay on the buildbots--no worse than cpython would have been before the checkin. (A lot of the buildbots are... wonky.) I checked it in to cpython350 directly. I'll do the forward merge after 3.5.0rc3 goes out the

[issue24917] time_strftime() Buffer Over-read

2015-09-06 Thread Larry Hastings
Changes by Larry Hastings : -- priority: release blocker -> deferred blocker ___ Python tracker <http://bugs.python.org/issue24917> ___ ___ Python-bugs-list mai

<    16   17   18   19   20   21   22   23   24   >