Larry Hastings added the comment:
Since you have abandoned your patch, please stop changing the issue title on me.
--
title: Derby: Convert the ElementTree module to use Argument Clinic -> Derby
#7: Convert 51 sites to Argument Clinic across 3 files -> Derby: Convert the
Eleme
New submission from Larry Hastings:
This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.
This issue asks you to change the following bundle of
New submission from Larry Hastings:
This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.
This issue asks you to change the following bundle of
New submission from Larry Hastings:
This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.
This issue asks you to change the following bundle of
New submission from Larry Hastings:
This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.
This issue asks you to change the following bundle of
New submission from Larry Hastings:
This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.
This issue asks you to change the following bundle of
New submission from Larry Hastings:
This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.
This issue asks you to change the following bundle of
New submission from Larry Hastings:
This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.
This issue asks you to change the following bundle of
New submission from Larry Hastings:
This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.
This issue asks you to change the following bundle of
Larry Hastings added the comment:
(Brett: in order to avoid creating 129 differet issues on the tracker, I'm
bundling files together into groups of 50 sites. You don't have to tackle the
whole list if you don't want to.)
This issue is part of the Great Argument Clinic Conversi
New submission from Larry Hastings:
This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.
This issue asks you to change the following bundle of
Larry Hastings added the comment:
Serhiy: Assigning to you because you wrote a patch; if you don't want the
issue, sorry, please undo it.
--
assignee: -> serhiy.storchaka
___
Python tracker
<http://bugs.python.org
Larry Hastings added the comment:
Serhiy: Assigning to you because you wrote a patch; if you don't want the
issue, sorry, please undo it.
--
assignee: -> serhiy.storchaka
___
Python tracker
<http://bugs.python.org
Larry Hastings added the comment:
Serhiy: Assigning to you because you wrote a patch; if you don't want the
issue, sorry, please undo it.
--
assignee: -> serhiy.storchaka
___
Python tracker
<http://bugs.python.org
New submission from Larry Hastings:
This is a meta-issue tracking all the Argument Clinic Derby sub-issues.
--
assignee: larry
components: email
messages: 207649
nosy: barry, larry, r.david.murray
priority: normal
severity: normal
stage: needs patch
status: open
title: The Great
Changes by Larry Hastings :
--
dependencies: +Derby: Convert the audioop module to use Argument Clinic
___
Python tracker
<http://bugs.python.org/issue20
Changes by Larry Hastings :
--
dependencies: +Derby: Convert the _sre module to use Argument Clinic -Derby:
Convert the audioop module to use Argument Clinic
___
Python tracker
<http://bugs.python.org/issue20
Larry Hastings added the comment:
The issue tracker isn't letting me add all the dependencies to the dependency
list. For the record, here are the numbers:
#20133
#20148
#20151
#20152
#20159
#20168
#20170
#20171
#20172
#20173
#20174
#20175
#20177
#20178
#20179
#20180
#20181
#20182
#
Larry Hastings added the comment:
Sure. Whoever takes ownership of this issue: please ignore _testbuffer.c.
--
title: Derby #14: Convert 50 sites to Argument Clinic across 6 files -> Derby
#14: Convert 41 sites to Argument Clinic across 5 fi
Larry Hastings added the comment:
Absolutely. decimal is a very special case.
Whoever takes over this issue: please ignore the part about _decimal.c.
--
title: Derby #8: Convert 52 sites to Argument Clinic across 3 files -> Derby
#8: Convert 28 sites to Argument Clinic across 2 fi
Larry Hastings added the comment:
Just one comment on your patch. The documentation already tells you how to
handle keyword arguments (section 8 tells you how to handle default values,
section 9 tells you how to handle | in the format string). If you have any
suggestions on how I could
New submission from Larry Hastings:
Stefan added some docstring text signatures by hand, only to discover that
inspect.Signature still didn't recognize them. Specifically,
decimal.Decimal.compare was unrecognized. This is a method_descriptor object,
which is a type that isn't ev
Larry Hastings added the comment:
Okay, learned some things.
1) inspect already has an ismethoddescriptor(). So I'll try to do this
properly by
2) The real problem is that method_descriptor doesn't have __text_signature__.
I only added that to PyCFunctionObject. I'l
Larry Hastings added the comment:
To be precise: a "keyword argument" is something that happens on the caller
side. What you're talking about is a "positional-or-keyword parameter". And
parameters are positio
Larry Hastings added the comment:
Here's a patch that adds __text_signature__ support for three more builtin
types:
method_descriptor
classmethod_descriptor
wrapper_descriptor
method-wrapper
The patch also modifies inspect.Signature so it recognizes these types.
--
Added
Larry Hastings added the comment:
Here's how the files were parceled out into the various bundles:
#20170
Derby #1: Convert 137 sites to Argument Clinic in Modules/posixmodule.c
Modules/posixmodule.c: 137 sites
#20171
Derby #2: Convert 115 sites to Argument Clinic in Mo
Larry Hastings added the comment:
I'd prefer it if you use the existing Derby issues. It's hard enough for me to
keep track of what's going on as it is, and it's unhelpful of you to create a
redundant issue. If you'd like some help figuring out how to work with th
Larry Hastings added the comment:
So do you think there are any entry points worth converting in _tkinter, or
should we close this issue?
--
___
Python tracker
<http://bugs.python.org/issue20
Larry Hastings added the comment:
Good catch! It should be an easy fix, but I won't be able to get to it until
tomorrow.
--
assignee: -> larry
stage: -> needs patch
type: -> behavior
___
Python tracker
<http://bugs.pyth
Larry Hastings added the comment:
I did correct that "where is file X" problem; issue #20187 is a meta-issue for
the whole Derby, and it has a list of all the issues and what files they map
to. I'm sorry that this is not an optimal solution for organization, but it
should be w
Larry Hastings added the comment:
Oh, okay. That sounds fine, and I'm not in a hurry. Please post the patch
whenever you're ready, thanks!
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
> * I have experimented in zlib_decompressobj, and I got good compact
> code, but wrong docstring ("decompressobj(wbits=None, zdict=None)").
> Needed a way to specify optional parameters without default Python
> values. Correct signatu
Larry Hastings added the comment:
The piecemeal approach sounds fine, but I'm only going to review patches once
you post them here. (I'm not sure I can get to reviewing your patch today, but
definitely tomorrow.)
--
___
Python trac
Larry Hastings added the comment:
> Previous approach is not applicable to compressobj because
> Py_buffer can't have default value. Seems as compressobj is
> not compatible with Argument Clinic.
Then perhaps we can fix Argument Clinic to be compatible. Py_buffer doesn't
Larry Hastings added the comment:
I lied, I just looked at it. You said it was only one function, so it went
quickly.
It looks totally fine. In fact, Argument Clinic is generating better code than
the original!
--
___
Python tracker
<h
Larry Hastings added the comment:
Oh, and, p.s. I was a Win32 developer for about fifteen years. I don't touch
it anymore, but I consider myself still competent to read patches for simple
stuff like the registry library.
--
___
Python tr
Changes by Larry Hastings :
--
nosy: +tim.peters
___
Python tracker
<http://bugs.python.org/issue20189>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
I just realized, you're misunderstanding what the first line of the docstring
is.
When you run help(function_written_in_Python), the first line of the help is
the function's signature rendered in text. That's generated by "pydoc&quo
Larry Hastings added the comment:
Yes, it's just Python syntax, so you'd use "->". However, you are not
permitted to according to PEP 8:
"The Python standard library will not use function annotations as that would
result in a premature commitment to a
Larry Hastings added the comment:
Would the patch be about as simple as the patch for 2.7 in #20207?
Also, #20207 is also marked for 3.4. Either unmark 3.4/3.5 in #20207, or close
this bug as a duplicate.
--
___
Python tracker
<h
Larry Hastings added the comment:
Okay, then, can you educate me on what you're proposing here?
--
___
Python tracker
<http://bugs.python.org/issue20209>
___
___
Larry Hastings added the comment:
Is there any way to use SSLv2 in 3.4?
--
___
Python tracker
<http://bugs.python.org/issue20209>
___
___
Python-bugs-list mailin
Larry Hastings added the comment:
I don't have a lot of context for this. It sounds like #20207 proposes to
remove the ability to use SSLv2 at all. And in the comments Alex Gaynor seems
to say that SSLv2 is already disabled in Python 3.
If #20207 happens for 3.4, would it still be pos
Larry Hastings added the comment:
If we removed it completely (which I'm *not* proposing, just gathering data)
how many people would it affect?
Is there any legitimate reason why some people would want SSLv2? Like "we
aren't allowed to upgrade this serve
Larry Hastings added the comment:
Okay, you have my permission to mark it pending deprecated.
> What I'm proposing is to remove it after we deprecate it.
I understand the deprecation process. Like I said, I was just trying to get a
sense of how many people would be
New submission from Larry Hastings:
Miscellaneous Argument Clinic fixes:
* Added default value type verification for almost all return converters.
* Added return converters for float, dobule, unsigned long,
unsigned int, short, and unsigned short.
* Py_buffer converter improvements
Larry Hastings added the comment:
LGTM. Check it in please!
--
___
Python tracker
<http://bugs.python.org/issue20200>
___
___
Python-bugs-list mailing list
Unsub
Larry Hastings added the comment:
LGTM. To be honest I don't understand what the hell 'w*' is for.
--
___
Python tracker
<http://bugs.pyt
Larry Hastings added the comment:
I've got a bunch of doc improvements in the rollup patch in #20214. I invite
you to give it a review. If that looks suitable please close this issue.
As for a verb, I've been using "convert". "zlibmodule has already been
conver
Larry Hastings added the comment:
Oh .
socket.sendto can't currently be converted to Argument Clinic. There's legacy,
and then there's the cruelty that only 1993-style argument parsing can inflict.
(socket.sendto's argument parsing was checked in in revision ac3c80abbf43
Changes by Larry Hastings :
--
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue20196>
___
___
Python-bugs-list mai
Larry Hastings added the comment:
Here's a fix. Works for me, let me know if it works for you.
--
Added file:
http://bugs.python.org/file33397/larry.zero.positional.parameters.patch.1.txt
___
Python tracker
<http://bugs.python.org/is
Changes by Larry Hastings :
--
assignee: -> larry
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Larry Hastings added the comment:
While it's dandy to add docstrings, your patch doesn't have any Argument Clinic
stuff in it. I don't mind if you add docstrings as part of the process of
converting to Argument Clinic, but I'm not interested in this
Larry Hastings added the comment:
That METH_O is working perfectly. You seem to be confused by it.
The original code was kind of dumb. The function only takes two parameters:
self, and a second "obj" parameter which can be any kind of object. CPython
has special support for ex
Larry Hastings added the comment:
Oops, sorry kbk.
--
assignee: kbk ->
nosy: -kbk
___
Python tracker
<http://bugs.python.org/issue20175>
___
___
Python-
Larry Hastings added the comment:
Go for it!
That's weird. Why can't I assign it to you? Have you not signed and submitted
a Python contributor agreement?
--
assignee: -> kbk
nosy: +kbk
___
Python tracker
<http://bugs.pytho
Larry Hastings added the comment:
Right, it doesn't work because you left the PyArg_ParseTuple call in your impl
function. Remove that and it should work.
Rule 1: Argument Clinic handles all argument parsing for you. Your "impl"
function should never call PyAr
Larry Hastings added the comment:
1)
When I wrote that I hadn't considered that people would want custom subclasses
of ints. I assumed they'd be using custom converter *functions*, which of
course means they'd use 'O&'. I can think of how to reword the te
Larry Hastings added the comment:
Yury: Thanks! I don't need any help right now though--just a review on this
patch ;-)
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
1)
Wow. I never knew about PyArg_UnpackTuple. You're right, those should be
converted too. Hooray, more entry points to convert.
I'll write something up for the howto about UnpackTuple.
I just did a quick check, and there are 96 entry points (b
Larry Hastings added the comment:
You can accomplish that workflow by using the Clinic buffer prototype and
moving all your output to the "side". Or by using the "buffer" approach, and
stopping when you hit the generated code. One of these might actually happen
in Clinic
Larry Hastings added the comment:
(Actually a self converter would be fine too. Those are only allowed to cast.)
I'm not doing this; here's why. I want the call signature to the impl function
to be the *idealized* signature of that function. And METH_NOARGS passes in a
dumb stu
Larry Hastings added the comment:
Yes, this is supported, just undocumented (for now). The magic you want is,
for example in Modules/_sre.c:
endpos: Py_ssize_t(c_default="PY_SSIZE_T_MAX") = sys.maxsize
--
___
Python trac
Larry Hastings added the comment:
Freshened patch,
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue20214>
___
___
Python-bugs-list mailin
Larry Hastings added the comment:
Do you have commit rights? I can commit this patch for you if you don't. Just
wondering what (if anything) is holding this up.
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
Georg, you mind reviewing this too? Six line patch. Just trying to clean my
plate a little before I fix a bug for you :D
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue20
Larry Hastings added the comment:
Looks like you don't, so I'll commit this on your behalf.
--
___
Python tracker
<http://bugs.python.org/issue20201>
___
___
Larry Hastings added the comment:
Also adding the one-byte fix from #20201 to the rollup patch here. (Not
bothering to upload a fresh patch because it is literally one byte, fixing a
misspelled variable name.)
--
___
Python tracker
<h
Larry Hastings added the comment:
I goofed, I do have some additional fixes. Here's everything.
Changes since patch #1:
* Added 'converter' argument to 'object' converter.
* Fixed misspelled variable name (see #20201).
* Several documentation updates.
---
Larry Hastings added the comment:
Easy fix. Thanks for the report!
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<http://bugs.python.or
Larry Hastings added the comment:
Third patch, with these new features:
* Relaxed rules regarding c_default and py_default; they can now be
used even when no default value is supplied.
* Added bool return converter.
* Made one fail() call easier to read, through the power of str.format
Larry Hastings added the comment:
Fixed as part of the rollup patch in #20214.
--
assignee: -> larry
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
New submission from Larry Hastings:
As per Georg's request (and hacks in other places), Argument Clinic should have
support for special methods. To wit:
__init__ should be required to be an instance method. Clinic should suppress
its methoddef #define.
__new__ should be required to
Larry Hastings added the comment:
Updated patch incorporating changes from Georg Brandl. Thanks Georg!
--
Added file:
http://bugs.python.org/file33434/larry.special.methods.support.patch.2.txt
___
Python tracker
<http://bugs.python.org/issue20
Larry Hastings added the comment:
Fixed in revision 43e109ca9018. Well, changed anyway, maybe it's still not
wonderful text.
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
I don't know what you mean by a "multipart patch", but the bug tracker has
handled every patch I've thrown at it so far. (Assuming that the patch is
based on a reasonably fresh checkout of trunk.)
--
__
Changes by Larry Hastings :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Larry Hastings :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Larry Hastings added the comment:
Okay, life has gotten even more complicated.
In another issue (#20172) Zachary Ware pointed out that Argument Clinic needs
to generate "self" parameters in the text string. But this complicates life
for inspect.Signature, which needs to not publish
Larry Hastings added the comment:
> Clinic should be adding 'self' to the signature,
> which should then be picked up by the __text_signature__
> parser, and used by inspect and pydoc.
This innocent little comment has derailed my whole day. You're right, 'self
Larry Hastings added the comment:
Not for builtins.
--
___
Python tracker
<http://bugs.python.org/issue20189>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
Here's an updated patch. I tried to "do it right" which wound up being a huge
amount of work in Clinic. The actual change to inspect.Signature was really
easy, once I understood everything.
The churn in the .c files is because Clinic no
Larry Hastings added the comment:
> Another issue is that with the patch applied help() is broken for
> certain forms of docstrings:
Yeah. We discussed this briefly in #19674. I wanted to use a marker that
wasn't The Convention That People Have Used For Decades but I felt overrule
Larry Hastings added the comment:
Filed comments on everything.
--
___
Python tracker
<http://bugs.python.org/issue20172>
___
___
Python-bugs-list mailin
Larry Hastings added the comment:
Same bug for 'y' too. Will fix in a patch probably Tuesday. Thanks for
pointing it out!
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
Very nice! I had an idea to do this in the back of my head too. But my plate
is already full.
I haven't reviewed the patch yet--and I have a huge backlog of reviews already.
But I can give this higher priority if you need it for other patches. Wh
Larry Hastings added the comment:
Dang it, I forgot to add the second patch. Here it is.
--
Added file:
http://bugs.python.org/file33467/larry.support.text_signature.on.more.types.diff.2.txt
___
Python tracker
<http://bugs.python.org/issue20
Larry Hastings added the comment:
Meador Inge: In the future, please create new issues for these sorts of fixes.
--
___
Python tracker
<http://bugs.python.org/issue16
Larry Hastings added the comment:
If it's not worth a new issue, then you can check it in without citing an issue
at all.
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
Updated the patch. (Diff #2 apparently didn't apply cleanly, so we didn't get
a review link.)
Old-guard core devs: I'm *really* desperate for a review of this patch. You
don't have to review everything thing, just these files:
Larry Hastings added the comment:
Antoine Pitrou took care of cryptmodule.c.
--
title: Derby #17: Convert 50 sites to Argument Clinic across 14 files -> Derby
#17: Convert 49 sites to Argument Clinic across 13 files
___
Python tracker
&l
Larry Hastings added the comment:
The attached patch extends Argument Clinic and the inspect module: now you may
use simple (!) expressions as default values. So for example "sys.maxsize - 1"
should now work fine.
* Names may be in the current module; as a backup they will also be
New submission from Larry Hastings:
It was a quick hack: Clinic now has a syntax for cloning an existing
function! The first line of the function block should be
module.class.new_function [as c_basename] = module.class.existing_fn
Hurry up and give me a LGTM so you can use it everywhere
Larry Hastings added the comment:
Shall I just check it in and fix it if it breaks?
--
___
Python tracker
<http://bugs.python.org/issue20268>
___
___
Python-bug
Larry Hastings added the comment:
Begun, the clone war has.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Larry Hastings added the comment:
Zachary: If you refresh your copy of trunk, you can now "clone" functions. See
the howto for the syntax.
The failure you were seeing was in some code that I just rewrote (see #20226).
I'd be interested if you could apply that patch and try
Larry Hastings added the comment:
Can you give me an example of performance degradation due to Argument Clinic?
What percentage slowdown is common?
--
___
Python tracker
<http://bugs.python.org/issue20
Larry Hastings added the comment:
Until you have some numbers, your assertion has no weight and should be ignored.
(As Carl Sagan once wrote: "That which can be asserted without evidence can be
dismissed without evidence." And as Donald Knuth wrote: "Premature
optimization is
Larry Hastings added the comment:
We can use this now. So I bumped it to the top of my queue and reviewed it. I
had only minor feedback--thanks!
--
___
Python tracker
<http://bugs.python.org/issue20
1201 - 1300 of 2389 matches
Mail list logo
