Larry Hastings added the comment:
We tried a pure python implementation of io once. Didn't go so well. :p
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
Stefan is right. I'll fix Clinic.
--
___
Python tracker
<http://bugs.python.org/issue19976>
___
___
Python-bugs-list m
Larry Hastings added the comment:
Yes, but it's a small utility. If it costs nothing to maintain _pyio then
okay. But if we're spending measurable time on it but it's only a nice-to-have
then we should drop it.
(Full disclosure: I have no idea how much work goes into ma
Larry Hastings added the comment:
A quick google suggests:
http://sourcefrog.net/weblog/software/languages/C/unused.html
--
___
Python tracker
<http://bugs.python.org/issue19
Larry Hastings added the comment:
To do it properly with Clang requires a pragma:
http://stackoverflow.com/questions/3417837/what-is-the-best-way-to-supress-unused-variable-x-warning/18724213#18724213
What a mess.
--
___
Python tracker
<h
Larry Hastings added the comment:
Here's a first attempt at a patch.
The Visual Studio pragma disables for the rest of the file, which is
undesirable. Maybe we could turn it on and off inline, but it's not clear to
me that that would have the desired effect of turning off the w
Larry Hastings added the comment:
So all the PyRun_*Object functions are new in 3.4, and none of them are
documented yet?
Option 4 is silly--I don't think we should ship them as public APIs in 3.4 if
we're planning to rename them. I prefer the previous options.
p.s. fwiw I ha
Larry Hastings added the comment:
So far I agree that this should be postponed to 3.5.
--
___
Python tracker
<http://bugs.python.org/issue19702>
___
___
Python-bug
Larry Hastings added the comment:
Are all the functions that use "Object" to indicate "Unicode object instead of
string" new in 3.4? Of those, how many are undocumented?
--
___
Python tracker
<http://bug
Larry Hastings added the comment:
Are we proposing renaming any functions that are either
a) not new in 3.4, or
b) were documented as of 3.4 beta 1?
--
___
Python tracker
<http://bugs.python.org/issue19
Larry Hastings added the comment:
Are those five functions new in 3.4 and undocumented?
--
___
Python tracker
<http://bugs.python.org/issue19518>
___
___
Pytho
Larry Hastings added the comment:
That's not how this works, Eric. I have to give you permission to add a new
feature, which I remind you I have yet to do.
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
So can you tell me how this will make users' lives easier? I don't really
understand the issues involved. But the only concrete thing I've seen
mentioned is making testing easier, and that's not worth breaking
Larry Hastings added the comment:
1. Is this patch going to change best practice for working with ModuleSpec?
2. If we delayed it to 3.5, will users have to ignore it to work around the
deficiencies of the ModuleSpec implementation in 3.4?
I'm guessing the answer to both of these is &quo
Larry Hastings added the comment:
The best fix would be to convert the docstrings to something inspect can parse.
Preferably by converting the functions to use Argument Clinic, though you
could manually mark up the docstring by hand if necessary
Larry Hastings added the comment:
One of the relevant PEPs (PEP 8? PEP 7? the annotations PEP?) states that the
Python standard library is not permitted to use annotations. And considering
that Argument Clinic is an internal-only tool, we could probably justify the
decision to not allow
Larry Hastings added the comment:
I wouldn't call this a new feature--it's definitely a bug fix. So the "feature
freeze" rule does not automatically apply. I definitely wouldn't permit this
once we reach release candidates, but we aren't there yet.
I get the
Larry Hastings added the comment:
I agree--though it would be better if you simply got it in before Saturday.
--
___
Python tracker
<http://bugs.python.org/issue20
Larry Hastings added the comment:
Yeah, unless there was a *huge* amount of support for changing this, it's way
too late for 3.4.
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
So, not to yank your chain, but... I'm okay with checking this in. Yes, we're
already in beta, but ModuleSpec is brand new, and the sense I get is that this
use case is obscure even for ModuleSpec. The only installed base is beta 1
users, and
Larry Hastings added the comment:
Isn't this a new feature?
--
nosy: +larry
___
Python tracker
<http://bugs.python.org/issue15027>
___
___
Python-bugs-list m
Larry Hastings added the comment:
I'm willing to risk it in 3.4. Can you check it in in the next twelve hours?
(Sorry for the short notice, it slipped my mind until just now.)
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
Would you describe it as a "bug fix" or a "security fix"? If it's neither of
those things, then you need special permission to add it during beta. And
given that this patch has the possibility of causing bugs, I'd prefer to n
Larry Hastings added the comment:
I hid it in the howto directory. Nobody'll look in there! :D
--
assignee: -> larry
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.p
Larry Hastings added the comment:
Well please get a second opinion. I don't know why you added me, I'm not
qualified.
--
nosy: +brett.cannon, ncoghlan
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
Doesn't help on Windows, junior!
--
___
Python tracker
<http://bugs.python.org/issue19659>
___
___
Python-bugs-list m
Larry Hastings added the comment:
You broke buildbots. Please fix.
http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.0%203.x/builds/1389
--
assignee: -> eric.snow
priority: normal -> high
resolution: fixed ->
stage: committed/rejected -> needs patch
status: cl
Larry Hastings added the comment:
Hmm, hard to see how you caused that with the path loader change. Still please
take a quick look.
I fired off another build to see if it was a transient error, but that'll take
a while.
--
___
Python tr
Larry Hastings added the comment:
Thanks for seeing this through, Eric.
--
___
Python tracker
<http://bugs.python.org/issue20123>
___
___
Python-bugs-list mailin
Larry Hastings added the comment:
I can accept the fourth patch in its current state.
Is that a rollup patch, including all the previous patches, or is it
independent?
Is there a patch I can look at for this new API?
--
___
Python tracker
<h
Larry Hastings added the comment:
Antoine: I made the call to bite the bullet and fix it. If that's a terrible
idea we can change it before RC1. But from my (admittedly dim) understanding
of the issue, we're going to have to fix this sooner or later, and sooner is
probably bett
Larry Hastings added the comment:
And, yes, Ethan's checkin missed the cutoff for beta 2.
--
___
Python tracker
<http://bugs.python.org/issue19995>
___
___
Larry Hastings added the comment:
So a documentation error and having to manually specify "&" at the front of
your string means it's "broken"?
Nevertheless, I'll take a look at it.
--
___
Python tracker
Larry Hastings added the comment:
Here's the problem. Let's say I gave you a way of specifying a symbolic
constant for the default value for C. What value should we use for the default
value in Python? Keep in mind, it has to be expressed as a static value that
can be stored as a
Larry Hastings added the comment:
Since this isn't a bugfix, it was inappropriate to check this in after
feature-freeze for 3.4. However it looks harmless enough, so I'm not asking
you to revert it at this time.
I guess it's easier to get forgiveness than permission, huh.
Larry Hastings added the comment:
As an example, consider pattern_match() in _sre.c. This implements the match
method on a pattern object; in other words, re.compile().match(). The third
parameter, endpos, defaults to PY_SSIZE_T_MAX in C. What should
inspect.Signature() report as the
Larry Hastings added the comment:
"sys.maxsize" won't work. inspect.Signature parses the __text_signature__
using ast.parse, and it only recognizes constant values and named constants
(True/False/None) for the default value for parameters. Playing with ast, it
looks li
Larry Hastings added the comment:
Actually, the documentation (the "howto") states:
Note that object() must explicitly support each Python type you specify for the
type argument. Currently it only supports str. It should be easy to add more,
just edit Tools/clinic/clinic.py, search
Larry Hastings added the comment:
Obviously we can't live with manually editing the output from Argument Clinic,
so I'll get you a fix for O! today.
Maybe we could use a better literal value? Like 2**31 - 1?
I don't understand the pydoc thing. Ca
Larry Hastings added the comment:
Here's a patch, please review. You can see how Py_buffer variables are
initialized in zlibmodule.c in the patch.
--
Added file:
http://bugs.python.org/file0/larry.clinic.py_buffer.initialization.patch.
Larry Hastings added the comment:
Attached is an example of how we could support simple named constants in
__text_signature__. The change to posixmodule.c is just a hack to exercise the
code in inspect.Signature; I didn't have a good example handy.
When I apply the patch and run &quo
Changes by Larry Hastings :
--
assignee: -> larry
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Larry Hastings added the comment:
Whoops, forgot to attach the file. here it is.
--
Added file:
http://bugs.python.org/file1/larry.simple.named.constants.in.text.signature.example
___
Python tracker
<http://bugs.python.org/issue20
Larry Hastings added the comment:
I've seen the problem before, but was too busy to fix it. Give me a
reproducable test case and I'll fix it.
--
assignee: -> larry
___
Python tracker
<http://bugs.pytho
Larry Hastings added the comment:
Oh, golly, this was one of those "what was I thinking?" sorts of bugs. The
problem (and the fix) was obvious once I stared at it long enough.
--
resolution: -> fixed
stage: -> committed/rejected
status
Larry Hastings added the comment:
It is unfortunate, but on the other hand that's what happens in Python too:
>>> import sys
>>> import inspect
>>> def foo(blah=sys.maxsize): pass
...
>>> str(inspect.signature(foo))
'(blah=
Larry Hastings added the comment:
Attached is a patch supporting simple symbolic constants. It works from
beginning to end--you specify it in the Argument Clinic input and it shows up
in the inspect.Signature and uses the constant in the generated C code.
One complication: when using one of
Larry Hastings added the comment:
And for Python blocks would you suggest
/*[python input]
...
[python start generated code]*/
...
/*[python end generated code; checksum:
da39a3ee5e6b4b0d3255bfef95601890afd80709]*/
To answer your question: no, it wouldn't be
Larry Hastings added the comment:
storchaka: You propose a result, not an approach. How do you propose we do
that?
In any case, I think making *that* work would be way too big a change for 3.4.
Whatever you proposed would only be appropriate for 3.5
Larry Hastings added the comment:
If it's source code, programmers will need to examine it from time to time. A
more important distinction imo: stringlib is type-parameterized like some sort
of prehistoric C++ template specialization. Thankfully the gunk generated by
Argument Clinic is
Larry Hastings added the comment:
When would you want this?
--
___
Python tracker
<http://bugs.python.org/issue20158>
___
___
Python-bugs-list mailing list
Unsub
Larry Hastings added the comment:
I'll fix this but it's low priority for today.
It's not a release blocker; we could release Python 3.4 with this bug.
--
assignee: -> larry
priority: release blocker -> normal
___
Larry Hastings added the comment:
I already noticed this; it'll be fixed in the patch for #20144. But thanks for
the report!
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
For the record, I'd be very happy to accept a patch for this into 3.4 at any
time.
--
nosy: +larry
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
I meant, under what circumstances would you want to use this?
I don't know why you would ever want --clean. Removing the output from the
Argument Clinic blocks would break any file using it. And Argument Clinic is
sufficiently fast, if you were wo
Larry Hastings added the comment:
Here's a second patch; I think this is ready to go in
I cleaned up the node parsing a lot. It now knows how to parse the following
types of default values:
* Number (this applies to both ints and floats)
* String ('hello')
* Attribu
Larry Hastings added the comment:
Oops! I forgot to actually attach the new patch. I'm dumb.
--
Added file:
http://bugs.python.org/file33340/larry.simple.symbolic.constant.default.values.diff.2.txt
___
Python tracker
<http://bugs.py
Larry Hastings added the comment:
Antoine just suggested that, if we used this "accumulator" thing, we'd want a
convention for where the generated text should go. I actually have an answer
for that: near the end, below the implementations of the module / class
methods
Larry Hastings added the comment:
I don't think Argument Clinic should do this. It would leave the file in a
broken state. But if it's an option on clinic.py it might tempt somebody into
using it, then they'd be confused.
If you want this functionality, please hack it up y
Larry Hastings added the comment:
Attached is a new, simpler approach for supporting O!. The object() converter
now takes two arguments:
* type, which is the type you want the parameter declared as
(e.g. "PyUnicodeObject *")
* subclass_of, which is the PyTypeObject you want
Larry Hastings added the comment:
Patch attached. I tweaked the punctuation in the last line, from this:
/*[clinic end generated code; checksum: {checksum}]*/
^ ^
to this: | |
v v
Larry Hastings added the comment:
Consider: if you ran "clinic.py --clean" on a C file, then tried to use "make
clinic", the makefile would first try to build the C file. But since the C
file is now broken, the make would fail. And you can't use "make clinic&quo
Larry Hastings added the comment:
There are lots of ways you can crash Python by giving erroneous input to
Argument Clinic. Clinic has no visibility into the C type system, so it has no
way of verifying whether or not the type objects you pass in are correct.
That's unfixable and not r
Larry Hastings added the comment:
At Antoine's suggestion, I added a custom function to testcapi that exercises
all the different possible types for default values in a text signature. Also
the docs have been updated. LGTU?
--
Added file:
http://bugs.python.org/file
Larry Hastings added the comment:
The problem was an easy fix. However, while fixing it I discovered another
problem (if "[clinic]*/" was the last line, and it didn't have an eol, Clinic
would append another "[clinic]*/"). I fixed that too and added
Larry Hastings added the comment:
If you edit the Clinic input and don't run clinic.py on it, it's out-of-date
but not broken.
If you edit the Clinic output and make a mistake, it's *your* fault.
If you ran clinic.py --clean, now you've broken your file *and* the normal
Larry Hastings added the comment:
Incorporated suggestions from Serhiy. Thanks, Serhiy!
--
Added file:
http://bugs.python.org/file33348/larry.simple.symbolic.constant.default.values.diff.4.txt
___
Python tracker
<http://bugs.python.org/issue20
Larry Hastings added the comment:
I must admit I am losing patience with this conversation. Argument Clinic is
not going to provide an attractively-named option that breaks your build and
requires fixing by hand. The bug is closed, the feature is not happening, it's
my hope that we ca
Larry Hastings added the comment:
Argument Clinic now supports simple constants like "sys.maxsize" as default
values for arguments for builtins. I'm assuming this gets you basically what
you wanted; if this isn't sufficient please open a new issue.
--
assignee:
Larry Hastings added the comment:
Argument Clinic's support for "O!" is now simpler and more flexible. It's not
as convenient as the previous API, but that API wasn't really sustainable. I'm
assuming this fixes your problem; if not please open a new issue.
--
Changes by Larry Hastings :
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Larry Hastings added the comment:
I'm assuming this is sufficient. If further bikeshedding is needed please
reopen the issue.
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python
Larry Hastings added the comment:
Fixed as a side effect of fixing #20144. And by the way this was never a
release blocker.
--
assignee: -> larry
priority: release blocker -> normal
resolution: -> fixed
stage: -> committed/rejected
status: op
Larry Hastings added the comment:
Can you refresh the patch? I think all the problems you cited are fixed, and
also the comments Argument Clinic uses were all changed. I'll review when you
have a fresh patch.
--
title: Convert the _sre module to use Argument Clinic -> Derby:
Larry Hastings added the comment:
Can you refresh the patch? I think all the problems you cited are fixed, and
also the comments Argument Clinic uses were all changed. I'll review when you
have a fresh patch.
--
title: Convert the audioop module to use Argument Clinic -&g
Larry Hastings added the comment:
Can you refresh the patch? The comments Argument Clinic uses were all changed.
I'll review when you have a fresh patch.
--
title: Convert the binascii module to use Argument Clinic -> Derby: Convert the
binascii module to use Argumen
Larry Hastings added the comment:
Can you refresh the patch? The comments Argument Clinic uses were all changed.
I'll review when you have a fresh patch. And I'll look at __init__ and
subelement then.
--
title: Convert the ElementTree module to use Argument Clinic -> D
Larry Hastings added the comment:
I'm normalizing the names of these issues so they're easier to read and to
search for.
--
title: Use Argument Clinic with _imp -> Derby: Convert the _imp module to use
Argument Clinic
___
Python t
Larry Hastings added the comment:
What functions, and what makes them unsuitable?
--
___
Python tracker
<http://bugs.python.org/issue20168>
___
___
Python-bug
Larry Hastings added the comment:
(It would have made it easier on me if you'd used the C function names, instead
of the names in the module.)
I agree. In retrospect, it's not surprising that things in _tkinter aren't
suitable, as it appears to be a shunt for calling things in
New submission from Larry Hastings:
This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.
This issue asks you to change the following bundle of
New submission from Larry Hastings:
This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.
This issue asks you to change the following bundle of
New submission from Larry Hastings:
This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.
This issue asks you to change the following bundle of
Changes by Larry Hastings :
--
components: +Extension Modules -Library (Lib)
___
Python tracker
<http://bugs.python.org/issue20170>
___
___
Python-bugs-list mailin
New submission from Larry Hastings:
This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.
This issue asks you to change the following bundle of
Changes by Larry Hastings :
--
components: +Extension Modules -Library (Lib)
___
Python tracker
<http://bugs.python.org/issue20171>
___
___
Python-bugs-list mailin
New submission from Larry Hastings:
This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.
This issue asks you to change the following bundle of
New submission from Larry Hastings:
This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.
This issue asks you to change the following bundle of
New submission from Larry Hastings:
This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.
This issue asks you to change the following bundle of
Larry Hastings added the comment:
Sorry, meant to convert a different issue into this issue.
--
resolution: -> duplicate
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
New submission from Larry Hastings:
This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.
This issue asks you to change the following bundle of
Larry Hastings added the comment:
(Converting this issue into Derby entry #7. Serhiy has stated that
he is abandoning his ElementTree patch; it may make a good starting point for
you if you take over this issue.)
This issue is part of the Great Argument Clinic Conversion Derby,
where we&#x
Changes by Larry Hastings :
--
type: behavior -> enhancement
___
Python tracker
<http://bugs.python.org/issue20171>
___
___
Python-bugs-list mailing list
Un
Changes by Larry Hastings :
--
type: behavior -> enhancement
___
Python tracker
<http://bugs.python.org/issue20173>
___
___
Python-bugs-list mailing list
Un
Changes by Larry Hastings :
--
type: behavior -> enhancement
___
Python tracker
<http://bugs.python.org/issue20175>
___
___
Python-bugs-list mailing list
Un
Changes by Larry Hastings :
--
type: behavior -> enhancement
___
Python tracker
<http://bugs.python.org/issue20170>
___
___
Python-bugs-list mailing list
Un
Changes by Larry Hastings :
--
type: behavior -> enhancement
___
Python tracker
<http://bugs.python.org/issue20174>
___
___
Python-bugs-list mailing list
Un
Changes by Larry Hastings :
--
type: behavior -> enhancement
___
Python tracker
<http://bugs.python.org/issue20177>
___
___
Python-bugs-list mailing list
Un
Changes by Larry Hastings :
--
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issue20175>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
As I discussed with you on IRC, the problem is, we have 129 files with sites
that need examining. I was advised that creating 129 issues on the tracker was
a bad idea. So I had to combine them together somehow. I wrote a Python
script to group them into
1101 - 1200 of 2389 matches
Mail list logo
