Change by Karthikeyan Singaravelan :
--
nosy: +xtreak, yselivanov
___
Python tracker
<https://bugs.python.org/issue35101>
___
___
Python-bugs-list mailin
Karthikeyan Singaravelan added the comment:
Seems there is a related open issue with a similar regex based solution
proposed for another class definition related issue :
https://bugs.python.org/issue22355#msg226538 . I think it's worth converting
the example code reported in issue223
Karthikeyan Singaravelan added the comment:
This seems to be a duplicate of issue12920. issue24491 was also a related issue
closed as a duplicate of issue12920. So I propose closing this to continue the
discussion in issue12920. Feel free to add in if I am missing something.
--
nosy
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35105>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
Sorry about that I thought to redirect the discussion to the linked issue since
it had a lot of people who might provide a better discussion about it. Feel
free to reopen this if needed.
--
___
Python
New submission from Karthikeyan Singaravelan :
Currently we run doctest in CI and we use the environment variable PYTHON to
get the path of python binary to be used for virtualenv creation. We set
PYTHON=../python in .travis.yml at [0] before running tests thus this causes
the CI to use
Karthikeyan Singaravelan added the comment:
Sorry to bump this but to add some more context doctest related issues were
fixed in issue34962 and is now enforced in CI.
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue27
Karthikeyan Singaravelan added the comment:
Thanks for the report. A simple reproducible in Python without splinter code. I
think it happens for instances of the class where the attribute is a property
raising exception and executing inspect.getmembers(Foo) works fine.
# bpo35108.py
import
Karthikeyan Singaravelan added the comment:
Sorry I misread your title stating it's about object getattr for a property has
to execute the underlying code it seems as explained in
https://stackoverflow.com/a/30143990/2610955 . I don't know if there is a way
through which an attrib
Karthikeyan Singaravelan added the comment:
Thanks for the report. Search gives me a related issue with PR to implement
IOBase for SpooledTemporaryFile : issue26175
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35
New submission from Karthikeyan Singaravelan :
inspect.getsource uses inspect.findsource that uses a regex to check for class
declaration and starts matching against the regex from the start of the
program. When there is a match it checks for the first character to be 'c' to
retur
Karthikeyan Singaravelan added the comment:
The related issue already implements seekable and other methods for IOBase. As
I can see from the open PR there are PR comments with respect to tests and docs
that need to be acted upon as per reviewer's comments. With respect to this
is
Karthikeyan Singaravelan added the comment:
@nubirstein You're welcome :) As noted in
https://bugs.python.org/issue26175#msg328911 the PR has the implementation of
seekable at
https://github.com/python/cpython/pull/3249/files#diff-34b2145d7fe189e893ec7934afe9829cR761
. You can help
Karthikeyan Singaravelan added the comment:
I have an open PR for babel https://github.com/python-babel/babel/pull/608 .
The problem is merging them and cutting a new release depends on the
maintainers availability. Once it's fixed we have to make sure dependencies of
babel like sphin
Karthikeyan Singaravelan added the comment:
> If we do so, we won't be able to write doctest about new features (existing
> in 3.8, not existing in 3.7), which is worse than having warnings.
I agree with the same. Maybe I am running doctest wrong locally? I use make
venv and m
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue33376>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
> Anyway, if it works today, the first developper writing doctest about a 3.8
> feature will cause a doctest failure so no we can't use 3.7 to test 3.8.
Agreed that we need to run on the master branch binary for 3.8 only features
l
Karthikeyan Singaravelan added the comment:
The current set of tests are at
https://github.com/python/cpython/blob/0353b4eaaf451ad463ce7eb3074f6b62d332f401/Lib/test/test_http_cookiejar.py#L406
. A simple set of tuple that can be added based on the report as below :
("http://barfo
Change by Karthikeyan Singaravelan :
--
keywords: +patch
pull_requests: +9569
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Karthikeyan Singaravelan added the comment:
Thanks for the confirmation. I have created a PR
(https://github.com/python/cpython/pull/10258) with test and added 3.8 as
affected version. Please add in if I have missed anything in the PR.
--
versions: +Python 3.8
Change by Karthikeyan Singaravelan :
--
nosy: +martin.panter, orsenthil
___
Python tracker
<https://bugs.python.org/issue35121>
___
___
Python-bugs-list mailin
Karthikeyan Singaravelan added the comment:
Thanks for the report Denis. Would you like to propose a PR for this? The file
is at https://github.com/python/cpython/blob/master/Doc/reference/datamodel.rst
. This was added as part of 5364b5cd757. I am adding Ivan who added the example
for
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35126>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35114>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
@Tester Thanks for the report. I looked at the crash report and I couldn't see
CPython crashing with a segfault. I think it's a crash from another application
which might be running the interpreter and can't handle the error raised
Karthikeyan Singaravelan added the comment:
Thanks for the report. The issue tracker deals with reports for CPython and
issues related to pip are not maintained here. Please file a doc issue at
https://github.com/pypa/pip/ . `--download` was deprecated with
https://github.com/pypa/pip/pull
Karthikeyan Singaravelan added the comment:
FYI created an issue at https://github.com/pypa/pip/issues/5976
Thanks!
--
assignee: -> docs@python
resolution: third party ->
stage: resolved ->
status: closed -> open
type: -> behavior
___
Karthikeyan Singaravelan added the comment:
Sorry, my comment reopened the bug :(
--
resolution: -> third party
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Karthikeyan Singaravelan added the comment:
There is an open PR that adds a similar example. Is it the same as the one you
are proposing and I think you can add a review comment to add it with the same
PR if it's different?
PR : https://github.com/python/cpython/pull/9787
T
Karthikeyan Singaravelan added the comment:
@anmikf Please use one issue for all the details. I am closing this as a
duplicate of issue35140 since it has the same reproducer script and details.
Feel free to reopen this if it's a different one adding little more context on
the diffe
Change by Karthikeyan Singaravelan :
--
nosy: +ezio.melotti, xtreak
___
Python tracker
<https://bugs.python.org/issue35142>
___
___
Python-bugs-list mailin
Karthikeyan Singaravelan added the comment:
I think parsing with regex especially on multiline cases like here is little
tricky handling all cases. I find AST module to be a good fit. I tried using a
callback where every class definition is taken up and then from that line to
rest of the
Change by Karthikeyan Singaravelan :
--
title: Annotations future requires unparse, but not accessible from Pythpn ->
Annotations future requires unparse, but not accessible from Python
___
Python tracker
<https://bugs.python.org/issu
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35144>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
Seems like a related issue : issue26660 . Maybe TemporaryDirectory can allow an
onerror argument that is passed internally to rmtree during cleanup and state
the same in the documentation that TemporaryDirectory can't cleanup read-only
Karthikeyan Singaravelan added the comment:
Good catch Windson! I overlooked the tests. There is also a comment that it's
liberal in the test function. Since the code was added in 2006 I don't if it's
ok broken to fix this or not. I will let the reviewers take a call then.
Karthikeyan Singaravelan added the comment:
I tried ast module and it passes my test cases but I found another case since
object.__name__ returns unqualified name thus matching against nested class
names might conflict with the ones on the top level. Example is below where
there is Spam at
Karthikeyan Singaravelan added the comment:
Thanks Serhiy, object.__qualname__ can be used to get qualified name of the
object but ast nodes don't have qualified name for the node where I can match
against it. node.name returns unqualified name and hence using ast module I
Karthikeyan Singaravelan added the comment:
Thanks Serhiy, I am going with the same approach too using a Stack. I am
working on it and I have fixed the set initial cases I reported with tests. I
just stumbled upon the nested definitions and inner classes. I will raise a PR
by end of today
Karthikeyan Singaravelan added the comment:
Thanks for the report and PR. I think these are related issues : issue17560,
issue28506 with issue17560 being open one. Correct me if I am wrong here.
--
nosy: +xtreak
___
Python tracker
<ht
Change by Karthikeyan Singaravelan :
--
keywords: +patch
pull_requests: +9614
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Karthikeyan Singaravelan added the comment:
Thanks Serhiy for the details. I think there are also less tests for
inspect.findsource with respect to classes though it's more robust than the
regex approach. Thus there might be different effects which are correct now or
selects an alte
Change by Karthikeyan Singaravelan :
--
components: +Windows
nosy: +paul.moore, steve.dower, tim.golden, zach.ware
___
Python tracker
<https://bugs.python.org/issue35
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue33757>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
There are some relevant docs in the inspect module about properties triggering
code execution and thus using getattr_static to fetch attributes. Ref :
https://docs.python.org/3/library/inspect.html#fetching-attributes-statically .
I tried the
Karthikeyan Singaravelan added the comment:
+1 from me too. issue35108 could help from this implementation where properties
execute code that might cause runtime exception. Initially I tried using
getattr_static inside getmembers at msg329254 but I think a separate function
or an option to
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue34305>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
Thanks for the report. The code was added with
c1f974c944a3e73cbc9102356d8700a190dcafb3 and self._pushback_chars is declared
only when punctuation_chars is passed to shlex.shlex in the constructor as you
have mentioned in
https://github.com
Change by Karthikeyan Singaravelan :
--
pull_requests: -9633
___
Python tracker
<https://bugs.python.org/issue9731>
___
___
Python-bugs-list mailing list
Unsub
Karthikeyan Singaravelan added the comment:
Adding the related StackOverflow question here for some context :
https://stackoverflow.com/questions/53156623/calling-for-super-str-seem-to-call-self-repr-in-list-subclass
Thanks
--
nosy: +xtreak
Karthikeyan Singaravelan added the comment:
Is this being worked on or can I try fixing this?
My analysis so far is as below :
1. For functions : inspect.signature looks for attribute __signature__ for
functions and while creating the mock for a function since we already have the
Karthikeyan Singaravelan added the comment:
I did some analysis with the given example script. Related issue where Aaron
has some analysis : issue12154 . The patch doesn't break anything since there
are no tests for this that also could be added.
1. When we do inspect.getdoc(c.sum) it
Karthikeyan Singaravelan added the comment:
Adding my analysis here which is also at related issue : issue30129. On the
attached program written by @skip.montanaro both c.sum and Child.sum return
None for inspect.getdocs thus docstrings in pydoc are empty which can be fixed
in both
Karthikeyan Singaravelan added the comment:
Dictionary iterates over keys and this is expected behavior. If you need to
iterate by values you should use dict().values()
$ python3 -c 'for i in dict(a=1): print(i)'
a
$ python3 -c 'print(all(dict(a=False)))' # Iterate by
Karthikeyan Singaravelan added the comment:
Is this a case of realname having @ inside an unquoted string? As I can see
from the RFC the acceptable characters of an atom other than alphabets and
digits that comprises a phrase are
Karthikeyan Singaravelan added the comment:
Ah sorry, I was typing so long and had an idle session that I didn't realize
@r.david.murray added a comment with the explanation. Just to add I tried using
Perl module (https://metacpan.org/release/Email-Address) that uses regex for
parsing
Karthikeyan Singaravelan added the comment:
I think this issue is covered with issue35101. It has an open PR as per the
proposed fix with tests : https://github.com/python/cpython/pull/10209/files
--
nosy: +xtreak
___
Python tracker
<ht
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue17972>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Karthikeyan Singaravelan :
--
pull_requests: +9682
___
Python tracker
<https://bugs.python.org/issue32513>
___
___
Python-bugs-list mailing list
Unsub
Change by Karthikeyan Singaravelan :
--
keywords: +patch
pull_requests: +9683
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Karthikeyan Singaravelan :
--
pull_requests: -9682
___
Python tracker
<https://bugs.python.org/issue32513>
___
___
Python-bugs-list mailing list
Unsub
Karthikeyan Singaravelan added the comment:
@berker.peksag I have created a unit test PR and verified that the test fails
in 3.6 and passes on master.
# 3.6 branch
cpython git:(25bd107399) ./python.exe
Python 3.6.7+ (remotes/upstream/3.6:25bd107399, Nov 8 2018, 00:50:43)
[GCC 4.2.1
Change by Karthikeyan Singaravelan :
--
pull_requests: +9702
___
Python tracker
<https://bugs.python.org/issue32513>
___
___
Python-bugs-list mailing list
Unsub
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35195>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
Thanks for the report. There was a related issue : issue29694 . This was fixed
in 3.7 and was backported with
https://github.com/python/cpython/commit/d7abeb7024b9755c291c29bdc8c4494246e975ad
(3.5.4 and above) . Can you please specify the full
Change by Karthikeyan Singaravelan :
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue35196>
___
___
Python-bugs-list mailing list
Unsub
Karthikeyan Singaravelan added the comment:
>From the PEP 540
This mode is off by default, but is automatically activated when using the
"POSIX" locale.
Add the -X utf8 command line option and PYTHONUTF8 environment variable to
control UTF-8 Mode.
https://docs.python.
Karthikeyan Singaravelan added the comment:
> Thank your for your response. I'm running python 3.5.2. The linked issue is
> indeed a duplicate of this one.
Thanks for the confirmation and script.
> I'm running Ubuntu 16.04.5 LTS. I don't know if you know anything a
Karthikeyan Singaravelan added the comment:
realpath aliases to abspath in Windows as I can see from the code and I think
this is a regression fixed with https://github.com/python/cpython/pull/10082
--
nosy: +xtreak
___
Python tracker
<ht
Karthikeyan Singaravelan added the comment:
Thanks for the report. I think this was a regression reported in
https://bugs.python.org/issue31047#msg328322 and was fixed with
https://github.com/python/cpython/pull/10082 . I think the regression was in
3.7.1 but the fix was made a little
Karthikeyan Singaravelan added the comment:
Just adding the open issues given Raymond's message for reference. A lot of the
IDLE issues have patches and since we moved to GitHub they were not updated.
Thanks to Tal for converting some patches togit PRs. I would like to help with
Karthikeyan Singaravelan added the comment:
I have limited understanding of Windows and I don't have access to a Windows
machine to check this out. I am adding Victor who implemented the PEP and might
help here. There also seems to be PYTHONLEGACYWINDOWSFSENCODING for windows
specifi
Change by Karthikeyan Singaravelan :
--
nosy: +ned.deily
___
Python tracker
<https://bugs.python.org/issue35209>
___
___
Python-bugs-list mailing list
Unsub
Karthikeyan Singaravelan added the comment:
Thanks for the report. I added Ned since it seemed similar to issue32481 but
from Python 3.7 the Mac installers from python.org ship with in-built Tcl/Tk
8.6.8 as in which was the reported version
https://www.python.org/download/mac/tcltk/#built
Karthikeyan Singaravelan added the comment:
Thanks, can you please try the mac installer from python.org to see if the
crash is till present : https://www.python.org/downloads/release/python-371/
Please remove the original email content while replying from email unless the
relevant parts
Karthikeyan Singaravelan added the comment:
Thanks a lot remi_bertholet. I think this is related to issue32481 . I will
wait for Ned's confirmation on how Homebrew packages Python 3.7 with Tcl/Tk and
if it's different from python.org Mac
Change by Karthikeyan Singaravelan :
--
stage: resolved ->
status: closed -> open
___
Python tracker
<https://bugs.python.org/issue33826>
___
___
Pyth
Karthikeyan Singaravelan added the comment:
I think this can be useful for keyword arguments as in the original suggestion.
I tried an initial implementation as below to use difflib to get the difference
like unittest if there are keyword args to be checked against the caller list
since the
Karthikeyan Singaravelan added the comment:
Please quote only the relevant parts of the original email while replying from
email since it duplicates the content and makes your reply hard to read. Also I
think the bug tracker doesn't support attachments from email so please attach
them
Karthikeyan Singaravelan added the comment:
Thanks for the report. The tracker is for issues related to CPython. I think
this is an issue with pip and please file an issue at
https://github.com/pypa/pip/issues. I can see some related issues as per your
original report on googling
Karthikeyan Singaravelan added the comment:
Sorry I overlooked the part where it says this works with command line but
throws an error on batch script.
--
___
Python tracker
<https://bugs.python.org/issue35
Change by Karthikeyan Singaravelan :
--
nosy: +eric.smith
___
Python tracker
<https://bugs.python.org/issue35212>
___
___
Python-bugs-list mailing list
Unsub
Karthikeyan Singaravelan added the comment:
dictionary's insertion order is preserved in 3.6 and above. Hence sorting by
lexical order was removed in issue34160 and there is a discussion in the same
issue to add an option to provide sorted output.
As part of triaging I propose closing
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35151>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
mock can only verify if the function is called with the correct number of
arguments as you have passed spec. It doesn't verify whether the function
implementation is correct like calling Something.foobar() because it's not
designed to
Karthikeyan Singaravelan added the comment:
Agreed this is confusing. Is this a Linux specific error? Trying this on Mac
gives me a different error code and exception.
# Mac
$ ./python.exe
Python 3.8.0a0 (heads/master:cd449806fa, Nov 12 2018, 09:51:24)
[Clang 7.0.2 (clang-700.1.81)] on
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35224>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
Related discussion with same segfault in Travis CI : issue33701
--
___
Python tracker
<https://bugs.python.org/issue33
Karthikeyan Singaravelan added the comment:
I think this is due to the fact that when an attribute of a call object is
accessed a new call object is returned with the parent as self.parent [0] but
the original information regarding the parent is lost during representation and
no check for
Karthikeyan Singaravelan added the comment:
Yes, for call objects it's always there but some of the tests use a tuple
during self.assertEquals and hence during equality check other fails with the
attribute error for parent like below. Also getattr(self, 'parent', None) !=
Change by Karthikeyan Singaravelan :
--
nosy: +eric.smith
___
Python tracker
<https://bugs.python.org/issue35232>
___
___
Python-bugs-list mailing list
Unsub
Karthikeyan Singaravelan added the comment:
Found a relevant issue but 3 years old :
https://github.com/travis-ci/travis-ci/issues/4387#issuecomment-125635027
Doc PR : https://github.com/travis-ci/docs-travis-ci-com/pull/311 . The docs
recommend usage of -a to select a free port
3001 - 3092 of 3092 matches
Mail list logo
