Change by Karthikeyan Singaravelan :
--
nosy: +barry, eli.bendersky, ethan.furman
___
Python tracker
<https://bugs.python.org/issue35899>
___
___
Python-bug
Karthikeyan Singaravelan added the comment:
I guess json module expects a return value from default function that is str,
int, float, etc. that can be handled by built in encoders and returning a bytes
object with repr causes it to keep calling default until a value of one of
expected type
Karthikeyan Singaravelan added the comment:
This is fixed upstream and will be available as Sphinx is upgraded. Closing it
now. Thanks @roelschroeven for the report.
Upstream PR : https://github.com/sphinx-doc/sphinx/pull/6018
--
resolution: -> third party
stage: -> re
Change by Karthikeyan Singaravelan :
--
nosy: +martin.panter
___
Python tracker
<https://bugs.python.org/issue35906>
___
___
Python-bugs-list mailing list
Unsub
Karthikeyan Singaravelan added the comment:
pprint only sorts dicts currently so sort_dicts is better than sort that sounds
more general. sort_dicts=True is the current behavior so I guess this is
backwards compatible way to do this change
Karthikeyan Singaravelan added the comment:
traits is not a part of stdlib and the tracker deals with issues in CPython. I
think this is a third party issue or something related to your environment that
can be reported to the respective project.
--
nosy: +xtreak
Karthikeyan Singaravelan added the comment:
args and kwargs property can be introduced on the call object to return the
args and kwargs stored in the tuple. Currently wrapping call object with tuple
can get a tuple of args and kwargs but a property would be helpful. A first
attempt patch on
Karthikeyan Singaravelan added the comment:
I think "Actual" is more consistent with other error messages like
assert_has_calls. I haven't seen usage of observed or received in error
messages and hence my opinion on using expected and actual though they are not
visually a
Karthikeyan Singaravelan added the comment:
@kakshay, I am not working on it so feel free to pick it up. I stumbled upon
this while looking into mock issues and I just posted a patch to gather API
feedback. I guess it would be helpful if someone confirms it would be a good
addition so that
Change by Karthikeyan Singaravelan :
--
nosy: +lukasz.langa
___
Python tracker
<https://bugs.python.org/issue35954>
___
___
Python-bugs-list mailing list
Unsub
Change by Karthikeyan Singaravelan :
--
nosy: +xdegaye
___
Python tracker
<https://bugs.python.org/issue35953>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
Sorry to comment on a closed issue. I see the following behavior with
difflib.ndiff which is used under the hood by unittest. The strings that differ
by '-' and 'w' generate different output compared to 'a' and
Karthikeyan Singaravelan added the comment:
This feels safer to me with respect to backwards compatibility and also that it
might be easier to backport this to mock on GitHub which works with Python 2.7.
I have less knowledge on difference between tuple and namedtuple internals so I
might
New submission from Karthikeyan Singaravelan :
math.prod introduced with issue35606 seems to segfault when zero is present on
some cases like start or middle of the iterable. I couldn't find the exact
cause of this. This also occurs in optimized builds.
# Python information built
Karthikeyan Singaravelan added the comment:
I too saw this a week back but couldn't reproduce it. There is one another test
that fails like this and passes on verbose mode issue35809 . Travis doesn't
report tests that fail in the complete run and pass during verbose run like
bu
Change by Karthikeyan Singaravelan :
--
nosy: +eric.smith
___
Python tracker
<https://bugs.python.org/issue35960>
___
___
Python-bugs-list mailing list
Unsub
Karthikeyan Singaravelan added the comment:
> If contributions are accepted as GitHub pull requests
these days, I can do it myself too.
GitHub pull requests are accepted. Please see https://devguide.python.org/ .
Thanks
--
nosy: +xtr
Karthikeyan Singaravelan added the comment:
@pablogsal I am reopening this since this has an open PR though original issue
was fixed. Feel free to close this if this can be discussed in a separate issue.
--
resolution: fixed ->
stage: resolved -> patch review
status: closed -
Karthikeyan Singaravelan added the comment:
Is this something related to running under coverage? With the failure commit on
Travis I built the binary and there are no failures with unittest but the tests
fail with coverage. Running 'set.add(0)' under coverage and as normal file
Karthikeyan Singaravelan added the comment:
I have tried with different places where only '-' and 'w' differ. They seemed
to produce correct diff except for this once case where the diff was confusing.
--
nosy: +tim.peters
type: -> behavior
versions: +Python
Karthikeyan Singaravelan added the comment:
Seems related : issue33266
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35968>
___
___
Pytho
Karthikeyan Singaravelan added the comment:
The reported example works fine on master and 3.7 . The related issue's fix was
not backported to 3.6 . 3.6 is in security fixes only mode. So upgrading to 3.7
will help and I propose closing this as a duplicate of issue33266 .
➜ cpytho
Karthikeyan Singaravelan added the comment:
No problem, after some debugging the statement finally executed is
'exec(compile("set.add(0)", "foo.py", "exec"))' . In Python interpreter this
will give the expected error. It also gives the same error
Karthikeyan Singaravelan added the comment:
I am not sure this is a duplicate since the other issue was about newline at
the end of strings. This is about the diff being little irrelevant even with
newline in the end for strings. Sample program where change in 5th character
gives the
Karthikeyan Singaravelan added the comment:
I hope there are certain modules that CPython interpreter expects to load
properly. There were some cases in the past where encodings module caused the
interpreter to crash. A similar scenario.
➜ cpython git:(master) echo "raise Excepti
Karthikeyan Singaravelan added the comment:
Thanks for the explanation. This seems to give the desired diff with
charjunk=None passed to multiline string comparison helper. I am not sure how
useful it would be to pass it to sequence and dict comparison that also use
ndiff. I can open a PR if
Karthikeyan Singaravelan added the comment:
Sorry by previous reports I was talking about some of the issues where the
installers were not correct though I couldn't find the issue at the moment. I
just presented it as a data point where some necessary modules that cannot be
imported
Karthikeyan Singaravelan added the comment:
The change in behavior of Perl was discussed in
https://mail.python.org/pipermail/python-ideas/2017-June/045842.html
--
nosy: +vstinner, xtreak
___
Python tracker
<https://bugs.python.org/issue35
Change by Karthikeyan Singaravelan :
--
nosy: +gvanrossum
___
Python tracker
<https://bugs.python.org/issue35973>
___
___
Python-bugs-list mailing list
Unsub
Karthikeyan Singaravelan added the comment:
Duplicate of issue35961 ? It occurs in Travis too
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35
Karthikeyan Singaravelan added the comment:
Sorry, it occurs in Travis too randomly not consistently.
--
___
Python tracker
<https://bugs.python.org/issue35
Karthikeyan Singaravelan added the comment:
> Do you have an url to an example of crash on Travis?
Travis crash that occurred few days back :
https://travis-ci.org/python/cpython/jobs/491701299 . I first noticed it on an
IDLE lib PR where this failure was unrelated but I can remem
Karthikeyan Singaravelan added the comment:
It has been crashing for almost all the last 5 PRs merged to master :
https://travis-ci.org/python/cpython/jobs/492241988 - Feb 12, 21:51
https://travis-ci.org/python/cpython/jobs/492123432 - Feb 12, 17:33
https://travis-ci.org/python/cpython/jobs
New submission from Karthikeyan Singaravelan :
I noticed this while checking issue35961. test_venv is always failing on GCC
which is marked as optional in Travis.
Log : https://travis-ci.org/python/cpython/jobs/492123436#L1909
0:39:35 load avg: 1.00 [390/416] test_venv
test test_venv failed
Karthikeyan Singaravelan added the comment:
This issue affects 2.7 as well along with 3.4 and 3.5. The initial report was
notified to secur...@python.org . 2.7.16 release candidate dates were announced
at https://mail.python.org/pipermail/python-dev/2019-February/156266.html. I
have
Karthikeyan Singaravelan added the comment:
Is this Windows specific? I am unable to reproduce this on Mac and Ubuntu with
master and Python 3.7 .
➜ cpython git:(master) ./python.exe -c 'import os, shutil;
shutil.make_archive("foo...bar..", "zip", os.path.abspath(&q
Karthikeyan Singaravelan added the comment:
Could be the case that it's windows specific. For "foo...bar..." abspath
returns "foo...bar..." in Python on Mac. I don't have access to Windows but
checking this on dotnet fiddle with C# which I hope uses Windows ful
Karthikeyan Singaravelan added the comment:
This seems to be same as issue33524 ?
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35
Karthikeyan Singaravelan added the comment:
Thanks for the confirmation. I would propose closing this as a duplicate. The
PR on the other issue might fix your issue and is just waiting on a NEWS entry.
--
___
Python tracker
<ht
Change by Karthikeyan Singaravelan :
--
superseder: -> non-ascii characters in headers causes TypeError on
email.policy.Policy.fold
___
Python tracker
<https://bugs.python.org/issu
Karthikeyan Singaravelan added the comment:
Thanks for the report. mypy is not part of stdlib and it seems that typeshed
doesn't have BaseEventLoop defined in asyncio.__init__.pyi [0] . Adding it to
the import removes the error . I guess this needs to be filed in typeshed.
There is an
Karthikeyan Singaravelan added the comment:
On windows os.path.abspath("foo...bar..") returns "foo...bar" which is used in
shutil.make_archive [0] returning foo...bar.zip. @matrixise , I am reopening
this and adding Windows so that this can be confirmed as known behavior
New submission from Karthikeyan Singaravelan :
Though random module doesn't receive frequent changes can you please add the
relevant lines in the description or the relevant commit with the corresponding
line number in the report with a description.
On master with commit [0] line 295
Change by Karthikeyan Singaravelan :
--
nosy: +levkivskyi
___
Python tracker
<https://bugs.python.org/issue35992>
___
___
Python-bugs-list mailing list
Unsub
Change by Karthikeyan Singaravelan :
--
nosy: +vinay.sajip
___
Python tracker
<https://bugs.python.org/issue35995>
___
___
Python-bugs-list mailing list
Unsub
Karthikeyan Singaravelan added the comment:
Thanks for the report. I think this is design by choice that self is not passed
to the side_effect directly set on the mock [0]. Changing this would break
existing tests like [1] . You can use the approach by @remi.lapeyre which
directly replaces
Karthikeyan Singaravelan added the comment:
Not sure if it's related but there was a similar report on failure in freebsd
bots with tls1.3 : issue35031 . Can you please add SSL info with ./python -m
test.pythoninfo | grep ssl ?
Test runs fine on my ubuntu 16.04 machine with below
Karthikeyan Singaravelan added the comment:
I can confirm that this fails on a fresh fedora 29 VM as of commit 355f16f. The
changes in PR 10011 make this test pass.
SSL version and OS details
$ cat /etc/fedora-release
Fedora release 29 (Twenty Nine)
$ uname -a
Linux fedora-s-1vcpu-1gb-blr1
Change by Karthikeyan Singaravelan :
--
nosy: +gvanrossum, levkivskyi
___
Python tracker
<https://bugs.python.org/issue36009>
___
___
Python-bugs-list mailin
Karthikeyan Singaravelan added the comment:
See also issue34464
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue36000>
___
___
Python-bug
Karthikeyan Singaravelan added the comment:
Tests were added with 842985f6c70484ed7b8fc30d0bc05aec73236a98 and passes on
master and 3.7.1 . Can you please add the full traceback and the command you
used to run the test? Also the output of python version as below to try
reproducing it
Karthikeyan Singaravelan added the comment:
Thanks for the details. I couldn't reproduce this on a clean v3.7.2 build on
Mac. There were also no changes to argparse.py between 3.7.0 and 3.7.2 so I
don't know why it's failing on your environment.
➜ cpython git:(9a3ffc0492)
Change by Karthikeyan Singaravelan :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Karthikeyan Singaravelan added the comment:
This is a good first issue. Python 3 docs uses `{:.3f}".format(1.0/3.0)` that
was changed as part of 04d8a245f162b33e6c861ba0869918d9262be63e. Python 2 docs
could be changed too to use floats that makes the example correct.
--
Karthikeyan Singaravelan added the comment:
Some discussion in issue15452 about using ast.literal_eval instead of eval
which I think is the similar to this report.
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue36
Change by Karthikeyan Singaravelan :
--
nosy: +lukasz.langa
___
Python tracker
<https://bugs.python.org/issue36023>
___
___
Python-bugs-list mailing list
Unsub
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue36026>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Karthikeyan Singaravelan :
--
nosy: +serhiy.storchaka, vstinner
___
Python tracker
<https://bugs.python.org/issue36026>
___
___
Python-bugs-list mailin
Karthikeyan Singaravelan added the comment:
Agreed with @p-ganssle . Similar issue33152 in the past for the refactoring in
timeit module to use list comprehension. Large refactorings like this could
also make git blame little more difficult in places where this has less benefit
like smaller
Change by Karthikeyan Singaravelan :
--
nosy: +levkivskyi
___
Python tracker
<https://bugs.python.org/issue36042>
___
___
Python-bugs-list mailing list
Unsub
Karthikeyan Singaravelan added the comment:
Sorry, I don't get the report. Can you please add a short reproducer script
with a description of the current behavior and the expected behavior?
--
nosy: +xtreak
___
Python tracker
&
Karthikeyan Singaravelan added the comment:
This seems like a good change to me. GitHub PRs are accepted please see
https://devguide.python.org/ . Since this is an enhancement it can only go as
part of Python 3.8 if accepted.
--
nosy: +xtreak
versions: -Python 3.6, Python 3.7
Change by Karthikeyan Singaravelan :
--
nosy: +rhettinger
___
Python tracker
<https://bugs.python.org/issue36049>
___
___
Python-bugs-list mailing list
Unsub
Change by Karthikeyan Singaravelan :
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue36000>
___
___
Python-bugs-list mailin
Change by Karthikeyan Singaravelan :
--
nosy: +mark.dickinson, rhettinger
___
Python tracker
<https://bugs.python.org/issue36055>
___
___
Python-bugs-list mailin
Karthikeyan Singaravelan added the comment:
I guess key should be bytes instead of a dict with string key. Maybe the docs
could be improved about the case where key in case of dict should be bytes.
>>> from urllib.request import urlopen, Request
>>> r = Request("
Karthikeyan Singaravelan added the comment:
Stéphane, I don't know much about urllib to review this. The reason I said it's
better document this is that there was an extended discussion on issue25439
along with a PR about type checking breaking some behavior and ambiguity in
what
Karthikeyan Singaravelan added the comment:
I would recommend posting this on python-ideas to get some feedback. This
introduces new control flow and breaks some old assumptions as in third case
empty block is executed and there might be code that depends upon current
for-else behavior
Karthikeyan Singaravelan added the comment:
Slightly similar proposal in the past :
https://mail.python.org/pipermail/python-ideas/2016-March/038897.html
--
___
Python tracker
<https://bugs.python.org/issue36
Change by Karthikeyan Singaravelan :
--
nosy: +rhettinger
___
Python tracker
<https://bugs.python.org/issue36068>
___
___
Python-bugs-list mailing list
Unsub
Karthikeyan Singaravelan added the comment:
If I understand the issue correctly it's as below is a simple reproducer where
target is resolved with {'a': 1} during the construction of the decorator [0]
though it's redefined later in the program as target = dict(a=2). Al
Karthikeyan Singaravelan added the comment:
Can you please add a simple reproducer to understand the issue in little more
detail? I could see some tests along with different cases producing the error
message at
https://github.com/python/cpython/blob/a40681dd5db8deaf05a635eecb91498dac882aa4
Change by Karthikeyan Singaravelan :
--
nosy: +paul.j3
___
Python tracker
<https://bugs.python.org/issue36078>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
Is this similar to issue35872? Can you please specify the full version of
Python as in 3.7.0 or later?
--
components: +Windows
nosy: +paul.moore, steve.dower, tim.golden, xtreak, zach.ware
___
Python
Karthikeyan Singaravelan added the comment:
https://docs.python.org/3/whatsnew/3.0.html
> The round() function rounding strategy and return type have changed. Exact
> halfway cases are now rounded to the nearest even result instead of away from
> zero. (For example, round(2.5) now
Karthikeyan Singaravelan added the comment:
@steven.daprano Bit off topic but you can also append .patch in the PR URL to
generate patch file with all the commits made in the PR up to latest commit and
.diff provides the current diff against master. They are plain text and can be
downloaded
Karthikeyan Singaravelan added the comment:
Thanks for the report. 3.4 is in security fixes only mode and will reach end of
life soon. This seems to be a backport of the change in 3.5 that won't be
accepted. Since the feature is available in 3.5+ I would recommend upgrading to
3.5 and
Karthikeyan Singaravelan added the comment:
Looking further this can be solved for a string target in patch.dict which can
be resolved again while calling the decorated function. There could be a case
where the actual target is specified and in that case mock could only updates
the
Karthikeyan Singaravelan added the comment:
I am not sure if the tracker can be used for updating a PEP since the PEPs are
available in separate GitHub repo that accepts issues and PRs at
https://github.com/python/peps .
--
nosy: +xtreak
Change by Karthikeyan Singaravelan :
--
nosy: +pitrou
___
Python tracker
<https://bugs.python.org/issue36084>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Karthikeyan Singaravelan :
While looking into the unittest.mock tests I came across test_patch_descriptor
[0] which makes an early return since patch.object and patch.dict are not
supported on staticmethod, classmethod and property as noted in the comment.
The tests still
Change by Karthikeyan Singaravelan :
--
nosy: +terry.reedy
___
Python tracker
<https://bugs.python.org/issue36086>
___
___
Python-bugs-list mailing list
Unsub
Karthikeyan Singaravelan added the comment:
Thanks Mario for the details. I had almost the same patch while writing
msg336300 :) There were no test case failures except that I had resolved it in
the constructor storing the string representation as a separate variable and
also while calling
Change by Karthikeyan Singaravelan :
--
keywords: +patch
pull_requests: +12030
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Karthikeyan Singaravelan :
--
nosy: +rhettinger, tim.peters
___
Python tracker
<https://bugs.python.org/issue36095>
___
___
Python-bugs-list mailin
Karthikeyan Singaravelan added the comment:
Not a unicode expert but searching along the lines there was a note added on
issue10610 that int() is supported for characters of 'Nd' category. So to check
if a string can be converted to integer with help of int() I should be using
str
Karthikeyan Singaravelan added the comment:
> `int` and `float` required general category Nd, which corresponds to
> `str.isdigit`.
Sorry, did you mean str.isdecimal? since there could be a subset where isdigit
is True and isdecimal returns False.
>>> '\u00B2'.isde
Karthikeyan Singaravelan added the comment:
Agreed, though str.isnumeric behavior might seem to be correct in terms of user
who knows unicode internals the naming makes it easy to be used for a general
user on trying to determine if the string can be used for int() without knowing
unicode
Karthikeyan Singaravelan added the comment:
This seems like an easy issue that the warnings in docs for ast need to be
manually backported to 2.7 since miss Islington cannot cherry pick two PRs for
2.7 in https://bugs.python.org/issue32758#msg313511 .
--
nosy: +Mariatta
Karthikeyan Singaravelan added the comment:
Related to issue35925 ?
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue36104>
___
___
Python-bug
Change by Karthikeyan Singaravelan :
--
nosy: +pablogsal, vstinner
___
Python tracker
<https://bugs.python.org/issue36104>
___
___
Python-bugs-list mailin
Karthikeyan Singaravelan added the comment:
@tashrifbillah I will be happy to add a test on a follow up PR attributing to
the original PR as per
https://github.com/python/cpython/pull/10343#issuecomment-467026474
Thanks
--
nosy: +xtreak
Change by Karthikeyan Singaravelan :
--
keywords: +patch
pull_requests: +12063
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Karthikeyan Singaravelan added the comment:
Closing this as resolved. @jaraco this just made it to 3.8.0 alpha 2, feel free
to reopen this if needed. Thanks Mario and Chris for review and merge :)
--
___
Python tracker
<https://bugs.python.
Change by Karthikeyan Singaravelan :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Karthikeyan Singaravelan added the comment:
https://docs.python.org/3/library/multiprocessing.html#proxy-objects
> If standard (non-proxy) list or dict objects are contained in a referent,
> modifications to those mutable values will not be propagated through the
> manager because
Karthikeyan Singaravelan added the comment:
This seems to be same as issue35417 and some resolution on detecting these type
of cases at issue10375.
--
nosy: +benjamin.peterson, xtreak
___
Python tracker
<https://bugs.python.org/issue36
Karthikeyan Singaravelan added the comment:
That's a lot faster and will be great if they make it to next alpha :) Adding
Ammar Askar since they did review for positional arguments.
--
nosy: +ammar2, xtreak
___
Python tracker
&
Change by Karthikeyan Singaravelan :
--
nosy: +xdegaye, xtreak
___
Python tracker
<https://bugs.python.org/issue36130>
___
___
Python-bugs-list mailing list
Unsub
New submission from Karthikeyan Singaravelan :
I am seeing this error on Windows and Mac CI builds where FTP related tests in
test.test_urllib2net.TimeoutTest are failing. It's reproducible locally too
where the tests are skipped on Mac and Ubuntu. Not sure if it's random since
s
1901 - 2000 of 3092 matches
Mail list logo