[issue37709] CSVReader ignores dialect.lineterminator

2019-07-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Seems related : https://bugs.python.org/issue1072404 . There is a note on docs that it's ignored and may be changed in future. https://docs.python.org/3/library/csv.html -- nosy: +skip.montanaro, x

[issue37714] 2to3 tab Problems

2019-07-29 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +benjamin.peterson ___ Python tracker <https://bugs.python.org/issue37714> ___ ___ Python-bugs-list mailin

[issue37712] Exception frames from unittest.TestCase.fail dependent on nesting

2019-07-30 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +ezio.melotti, michael.foord, rbcollins ___ Python tracker <https://bugs.python.org/issue37712> ___ ___ Python-bug

[issue37717] argparse subcommand docs has non-existent parameter "action"

2019-07-30 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +paul.j3 ___ Python tracker <https://bugs.python.org/issue37717> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37717] argparse subcommand docs has non-existent parameter "action"

2019-07-30 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Seems related : issue23487 . kwargs is manipulated before passing to parsers_class causing the error message and also the discussion in issue23487 notes this to be a documentation issue over usage of action argument. -- nosy: +xtreak

[issue37719] addSubtest not calling addFailure and addError

2019-07-30 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: See also issue29152 which seems to raise same concerns over this behvavior. -- nosy: +ezio.melotti, michael.foord, rbcollins, xtreak ___ Python tracker <https://bugs.python.org/issue37

[issue25312] Cryptic error message if incorrect spec is set on a callable mock

2019-07-31 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Using spec only checks for the attribute to be present and not the signature of the actual attribute being called. You might need autospec for this behavior. The below example to use create_autospec does the correct validation for mock_foo.func

[issue26752] Mock(2.0.0).assert_has_calls() raise AssertionError in two same calls

2019-07-31 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I proposed a PR for issue36871 which has the same issue with constructor signature being used for method calls when specced. I also checked the patch with the examples reported here regarding signature mismatch and they seem to be fixed. So

[issue37461] email.parser.Parser hang

2019-08-01 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: 3.5 also seems to be affected. git cherry pick works and the patch fixes the problem so I assume the backport would be straightforward. Since 3.5 is open for security fixes with 3.5.8 as next release I am adding Larry. $ git cherry-pick a4a994b

[issue37743] How should contextmanager/ContextDecorator work with generators?

2019-08-01 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +ncoghlan ___ Python tracker <https://bugs.python.org/issue37743> ___ ___ Python-bugs-list mailing list Unsub

[issue37742] logging.getLogger accepts name='root' leading to confusion

2019-08-01 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +vinay.sajip ___ Python tracker <https://bugs.python.org/issue37742> ___ ___ Python-bugs-list mailing list Unsub

[issue37756] Error 0x80070643 when installing

2019-08-04 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker <https://bugs.python.org/issue37

[issue37761] Inaccurate explanation of ArgumentParser.add_argument()'s name-or-flags in JA

2019-08-05 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Japanese translation is tracked as part of GitHub issues at https://github.com/python/python-docs-ja . -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue37

[issue37764] email.Message.as_string infinite loop

2019-08-05 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +maxking ___ Python tracker <https://bugs.python.org/issue37764> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37765] Include keywords in autocomplete list for IDLE

2019-08-05 Thread Karthikeyan Singaravelan
New submission from Karthikeyan Singaravelan : Currently, the basic repl for python provides keywords as part of autocompletion but IDLE doesn't provide them. I was trying to build an async repl on top of IDLE to support top level await statements as part of IDLE since "python

[issue37765] Include keywords in autocomplete list for IDLE

2019-08-05 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +taleinat ___ Python tracker <https://bugs.python.org/issue37765> ___ ___ Python-bugs-list mailing list Unsub

[issue37741] importlib.metadata docs not showing up in the module index

2019-08-05 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Including a module directive with synopsis as below in importlib.metadata.rst seems to fix this. It would also be good to include a link to source code from the importlib.metadata docs page since it's written in Python. .. m

[issue37765] IDLE: Include keywords in __main__ autocomplete list

2019-08-05 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks Terry, I used a similar patch. My main use case was around typing where normal shell autocompletes it and was curious if it was intentional. I didn't know that windows didn't give keywords. The keywords are short and added very

[issue37773] ValueError: I/O operation on closed file. in ZipFile destructor

2019-08-06 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: This looks like a regression in 3.8 so I have added 3.8 regression tag. -- keywords: +3.8regression nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue37

[issue37791] Propose to deprecate `ignore_errors` and `onerror` parameters of `shutil.rmtree()`

2019-08-08 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +giampaolo.rodola, serhiy.storchaka, tarek ___ Python tracker <https://bugs.python.org/issue37791> ___ ___ Pytho

[issue37792] xml.etree.ElementTree.Element.__eq__ does compare only objects identity

2019-08-08 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +eli.bendersky, scoder ___ Python tracker <https://bugs.python.org/issue37792> ___ ___ Python-bugs-list mailin

[issue37806] Infinite recursion with typing.get_type_hints

2019-08-10 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +gvanrossum, levkivskyi ___ Python tracker <https://bugs.python.org/issue37806> ___ ___ Python-bugs-list mailin

[issue37816] f-string documentation not fully accurate

2019-08-10 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +eric.smith ___ Python tracker <https://bugs.python.org/issue37816> ___ ___ Python-bugs-list mailing list Unsub

[issue37814] typing module: empty tuple syntax is undocumented

2019-08-10 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +gvanrossum, levkivskyi ___ Python tracker <https://bugs.python.org/issue37814> ___ ___ Python-bugs-list mailin

[issue37828] Fix default mock_name in unittest.mock.assert_called error message

2019-08-12 Thread Karthikeyan Singaravelan
New submission from Karthikeyan Singaravelan : In the format string for assert_called the evaluation order is incorrect and hence for mock's without name 'None' is printed whereas it should be 'mock' like for other messages. The error message is ("Expected 

[issue37785] argparse uses %s in gettext calls causing xgettext warnings

2019-08-12 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +paul.j3 ___ Python tracker <https://bugs.python.org/issue37785> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37829] Documentation of stdlib: add example of mixed arguments to dict()

2019-08-12 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +inada.naoki, rhettinger versions: -Python 3.5, Python 3.6 ___ Python tracker <https://bugs.python.org/issue37

[issue37830] continue in finally with return in try results with segfault

2019-08-12 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Adding Serhiy since this change was introduced with issue32489. -- nosy: +serhiy.storchaka, xtreak ___ Python tracker <https://bugs.python.org/issue37

[issue35293] make doctest (Sphinx) emits a lot of warnings

2018-11-21 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: They are warnings related to third party packages used for doctest and some of them might become incompatible with https://github.com/python/cpython/pull/10596. Related discussion : issue35109 -- nosy: +xtreak

[issue35307] Command line help example is missing "--prompt" option

2018-11-25 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the report. Would you like to propose a PR for this? I think this is an easy issue where the new help string for --help needs to be updated at https://github.com/python/cpython/blob/master/Doc/using/venv-create.inc -- nosy

[issue35313] test_embed fails in travis CI when tests are executed from a virtual environment

2018-11-25 Thread Karthikeyan Singaravelan
New submission from Karthikeyan Singaravelan : I noticed GCC related test always failing in Travis but it's optional and builds were always green. It's consistent and related to test_embed. It seems that the tests are ran from a virtual environment for GCC that causes some differe

[issue35314] fnmatch failed with leading caret (^)

2018-11-26 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue35314> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35317] test_email: test_localtime_daylight_false_dst_true() fails depending on the timezone

2018-11-26 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I remember some related issues raised in the past about the same test failing on freebsd machines : issue31628 and issue15750 (some more detail on msg168747) -- nosy: +xtreak ___ Python tracker <ht

[issue35320] Writable __spec__.has_location attribute

2018-11-26 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue35320> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35320] Writable __spec__.has_location attribute

2018-11-26 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I think a setter was added for has_location (msg205384) and docs were updated as part of the patch but the PEP was not updated? . A setter for has_location : https://hg.python.org/cpython/rev/e961a166dc70

[issue35334] urllib3 fails with type error exception, when cannot reach PyPI - urllib3.util.retry

2018-11-27 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I think this is an issue with pip specifically with Ubuntu/Debian packaging causing the error. Please see https://github.com/pypa/pip/issues/3943, https://github.com/pypa/pip/issues/4779 and https://answers.launchpad.net/ubuntu/+question/659285

[issue35330] When using mock to wrap an existing object, side_effect requires return_value

2018-11-28 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue35330> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35330] When using mock to wrap an existing object, side_effect requires return_value

2018-11-28 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I did some debugging with docstring for wraps. > `wraps`: Item for the mock object to wrap. If `wraps` is not None then > calling the Mock will pass the call through to the wrapped object > (returning the real result). Attribute acce

[issue35330] When using mock to wrap an existing object, side_effect requires return_value

2018-11-28 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: A little more discussion over side_effect and return_value precedence : issue22541 -- ___ Python tracker <https://bugs.python.org/issue35

[issue35330] When using mock to wrap an existing object, side_effect requires return_value

2018-11-28 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks @mariocj89 for the explanation. I just got to the docs part about side_effect and return_value precedence. I am curious to know about the behavior as well and at least this can be added as a test as I see only around 3 tests for side_effect

[issue35338] set union/intersection/difference could accept zero arguments

2018-11-28 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I agree with @SilentGhost to use set().union(*sequence) which is compatible with Python 2 too. -- nosy: +rhettinger, xtreak ___ Python tracker <https://bugs.python.org/issue35

[issue35341] Add generic version of OrderedDict to typing module

2018-11-28 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +gvanrossum, levkivskyi ___ Python tracker <https://bugs.python.org/issue35341> ___ ___ Python-bugs-list mailin

[issue27903] Avoid ResourceWarnings from platform._dist_try_harder

2018-11-28 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I guess this can be closed as out of date since the function was removed with https://github.com/python/cpython/pull/10787/. cc: Victor -- nosy: +vstinner resolution: -> out of date stage: -> resolved status: open -&g

[issue28608] Support creating hardlink using `pathlib`

2018-11-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Just to add to this os.link supports path-like objects. Adding @pitrou to take a call on this. -- nosy: +pitrou, xtreak versions: +Python 3.8 -Python 3.7 ___ Python tracker <https://bugs.python.

[issue27903] Avoid ResourceWarnings from platform._dist_try_harder

2018-11-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Ah sorry I forgot the previous versions that had this code. Thanks for the catch and PR victor :) -- ___ Python tracker <https://bugs.python.org/issue27

[issue24412] setUpClass equivalent for addCleanup

2018-11-29 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- pull_requests: +10041 ___ Python tracker <https://bugs.python.org/issue24412> ___ ___ Python-bugs-list mailing list Unsub

[issue35354] Generator functions stack overflow

2018-11-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I think I have seen this bug reported elsewhere but can't find it now. A simple reproducer : def foo(): try: raise Exception() except: foo() foo() Running under gdb on Ubuntu : Program received signal SIGABRT, Ab

[issue35354] Generator functions stack overflow

2018-11-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I was referring to issue6028 and issue32570. -- ___ Python tracker <https://bugs.python.org/issue35354> ___ ___ Pytho

[issue35354] Generator functions stack overflow

2018-11-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I was referring to issue6028 and issue32570. -- ___ Python tracker <https://bugs.python.org/issue35354> ___ ___ Pytho

[issue35354] Generator functions stack overflow

2018-11-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I was referring to issue6028 and issue32570. -- ___ Python tracker <https://bugs.python.org/issue35354> ___ ___ Pytho

[issue35354] Generator functions stack overflow

2018-11-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I was referring to issue6028 and issue32570. -- ___ Python tracker <https://bugs.python.org/issue35354> ___ ___ Pytho

[issue35354] Generator functions stack overflow

2018-11-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > I think I have seen this bug reported elsewhere but can't find it now. Sorry, I was referring to issue6028 and issue32570 that I thought were similar to the original report. -- ___ Python

[issue35354] Generator functions stack overflow

2018-11-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > I think I have seen this bug reported elsewhere but can't find it now. Sorry, I was referring to issue6028 and issue32570 that I thought were similar to the original report. -- ___ Python

[issue31177] unittest mock's reset_mock throws an error when an attribute has been deleted

2018-11-29 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +cjw296, mariocj89 ___ Python tracker <https://bugs.python.org/issue31177> ___ ___ Python-bugs-list mailin

[issue35354] Generator functions stack overflow

2018-11-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > I think I have seen this bug reported elsewhere but can't find it now. Sorry, I was referring to issue6028 and issue32570 that I thought were similar to the original report. -- ___ Python

[issue35354] Generator functions stack overflow

2018-11-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > I think I have seen this bug reported elsewhere but can't find it now. Sorry, I was referring to issue6028 and issue32570 that I thought were similar to the original report. -- ___ Python

[issue35354] Generator functions stack overflow

2018-11-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > I think I have seen this bug reported elsewhere but can't find it now. Sorry, I was referring to issue6028 and issue32570 that I thought were similar to the original report -- ___ Python

[issue35354] Generator functions stack overflow

2018-11-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > I think I have seen this bug reported elsewhere but can't find it now. Sorry, I was referring to issue6028 and issue32570 that I thought were similar to the original report. -- ___ Python

[issue2771] Test issue

2018-11-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: test comment -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue2771> ___ ___ Python-bugs-list mailin

[issue35354] Generator functions stack overflow

2018-11-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > I think I have seen this bug reported elsewhere but can't find it now. Sorry, I was referring to issue6028 and issue32570 that I thought were similar to the original report. -- ___ Python

[issue35354] Generator functions stack overflow

2018-11-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > I think I have seen this bug reported elsewhere but can't find it now. Sorry, I was referring to issue6028 and issue32570 that I thought were similar to the original report. -- ___ Python

[issue35354] Generator functions stack overflow

2018-11-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > I think I have seen this bug reported elsewhere but can't find it now. Sorry, I was referring to issue6028 and issue32570 that I thought were similar to the original report. -- ___ Python

[issue35354] Generator functions stack overflow

2018-11-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > I think I have seen this bug reported elsewhere but can't find it now. Sorry, I was referring to issue6028 and issue32570 that I thought were similar to the original report. -- ___ Python

[issue2771] Test issue

2018-11-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > I think I have seen this bug reported elsewhere but can't find it now. Sorry, I was referring to issue6028 and issue32570 that I thought were similar to the original report. -- ___ Python

[issue35354] Generator functions stack overflow

2018-11-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > I think I have seen this bug reported elsewhere but can't find it now. Sorry, I was referring to issue6028 and issue32570 that I thought were similar to the original report. -- ___ Python

[issue35353] Add frame command to pdb

2018-11-30 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- title: Add frame command to pub -> Add frame command to pdb ___ Python tracker <https://bugs.python.org/issu

[issue35354] Generator functions stack overflow

2018-11-30 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Brett, the user had an invalid email address in their profile thus adding comments to the issue caused a server error while sending notification to them. So they have been removed from the issue. Please see : https://python.zulipchat.com/#narrow

[issue31177] unittest mock's reset_mock throws an error when an attribute has been deleted

2018-12-01 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I am closing this as fixed since all the PRs were merged. Feel free to reopen this if needed. Thanks @mariocj89 and @vstinner for the review. -- resolution: -> fixed stage: patch review -> resolved status: open -&g

[issue27715] call-matcher breaks if a method is mocked with spec=True

2018-12-01 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak versions: +Python 3.7, Python 3.8 -Python 3.4, Python 3.5 ___ Python tracker <https://bugs.python.org/issue27

[issue35341] Add generic version of OrderedDict to typing module

2018-12-02 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > Shall I open a new issue for this? @itoijala Please see https://bugs.python.org/issue33462. It's on master. -- nosy: +xtreak ___ Python tracker <https://bugs.python.org

[issue35374] Windows doc build does not find autodetected hhc.exe

2018-12-02 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker <https://bugs.python.org/issue35

[issue35375] name shadowing while a module tries to import another

2018-12-02 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > A python user can't be expected to know the name of every possible file in > the Python standard library. Maybe the current working directory should be > removed from sys.path when importing from within another module not in the &g

[issue34238] When BROWSER is set on Mac webbrowser.register_standard_browsers doesn't work

2018-12-02 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > However, I think there might be a bug with the implementation that doesn't > correctly respect the BROWSER preference. Notice how the webbrowser._tryorder > has two 'lynx' items and both of them are last. If you look at

[issue35382] Something wrong with pymysql

2018-12-03 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: It's a third party issue as others noted but just to add to this I found the below PR and question to be related to your problem in the tracker while googling byte2int pymysql that might be of help. * https://stackoverflow.com/questions/515

[issue35382] Something wrong with pymysql

2018-12-03 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Sorry, I messed up while adding the reply at the same time. Closing it again. -- nosy: +mark.dickinson, steven.daprano resolution: -> third party stage: -> resolved status: open -> closed _

[issue35405] Wrong traceback for AssertionError while running under pdb

2018-12-04 Thread Karthikeyan Singaravelan
New submission from Karthikeyan Singaravelan : While running under pdb when I have an assertion error after the command continue then the assertion error is mentioned with the statement under which I have executed continue command in pdb. Below script has an assertion error on assert 1 == 2

[issue35405] Wrong traceback for AssertionError while running under pdb

2018-12-04 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks Serhiy, is this a known behavior or issue since it's from 2.7 ? This is highly confusing and misleading as in your example and also while debugging tests that fail at a different line of assertion statement from the current line i

[issue35405] Wrong traceback for AssertionError while running under pdb

2018-12-04 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Seems this is a known issue and has an open PR https://github.com/python/cpython/pull/6233 . I checked out the PR locally and it works fine on the examples presented though has merge conflicts with master. I am closing it as duplicate of

[issue16482] pdb.set_trace() clobbering traceback on error

2018-12-04 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I too just hit this issue with pdb and checked out the PR locally. It works fine though it has merge conflicts with latest master. I am adding 3.8, 3.7 and 3.6 removing the older versions that don't support bug fixes. Since the PR has un

[issue35398] SQLite incorrect row count for UPDATE

2018-12-04 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +ghaering, xtreak ___ Python tracker <https://bugs.python.org/issue35398> ___ ___ Python-bugs-list mailin

[issue35398] SQLite incorrect row count for UPDATE

2018-12-04 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Did some debugging here. If I am understanding this correctly the rowcount is set at https://github.com/python/cpython/blob/b8e689a6e8134e88f857a55e50b6a4977967e385/Modules/_sqlite/cursor.c#L574 . It checks for is_dml flag that is set here https

[issue35417] Double parenthesis in print function running 2to3 in already correct call

2018-12-05 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the report. Is this similar to issue10375 ? One option would be to use -p to stop transforming print related code if you don't want to transform any print statement. $ cat /tmp/foo.py print (1) $ 2to3 /tmp/foo.py [snip] ---

[issue35416] Fix potential resource warnings in distutils

2018-12-05 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: There is a similar open issue issue22831 with patches for distutils and Tools. -- nosy: +serhiy.storchaka, xtreak ___ Python tracker <https://bugs.python.org/issue35

[issue17185] unittest mock create_autospec doesn't correctly replace mocksignature

2018-12-05 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: While working on partials test case failure I found two more cases along the way. 1. When we call create_autospec it calls _get_signature_object that gets the signature for the given parameter. With functools.partial it returns a partial object

[issue35427] logging UnicodeDecodeError from undecodable strftime output

2018-12-07 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +vinay.sajip ___ Python tracker <https://bugs.python.org/issue35427> ___ ___ Python-bugs-list mailing list Unsub

[issue35443] Add Tail Call Optimization

2018-12-09 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Guido had some thoughts on Tail Recursion Optimization (TRE). http://neopythonic.blogspot.com/2009/04/tail-recursion-elimination.html -- nosy: +xtreak ___ Python tracker <https://bugs.python.

[issue17185] unittest mock create_autospec doesn't correctly replace mocksignature

2018-12-09 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- keywords: +patch pull_requests: +10284 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue26704] unittest.mock.patch: Double patching instance method: AttributeError: Mock object has no attribute '__name__'

2018-12-09 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks @asottile for the patch. I think the original AttributeError is resolved with issue28919 where they were silenced. It seems similar to issue32153 though the exception occurs from mock instead of partial object as in issue32153. The fix was

[issue28054] Diff for visually comparing actual with expected in mock.assert_called_with.

2018-12-09 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: It seems that TestCase in unittest.case accepts failureException attribute that is raised on assertion failure. My initial approach is to subclass TestCase and add a custom failure exception like MockException that is caught to add the diff to the

[issue20239] Allow repeated deletion of unittest.mock.Mock attributes

2018-12-09 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I find this to be a reasonable behavior as with normal objects that support setting the attribute after deletion. It also seems to be an easy issue since @michael.foord has already attached the patch for this from the original report. The patch

[issue35449] documenting objects

2018-12-09 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue35449> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35448] ConfigParser .read() - handling of nonexistent files

2018-12-09 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +lukasz.langa ___ Python tracker <https://bugs.python.org/issue35448> ___ ___ Python-bugs-list mailing list Unsub

[issue35449] documenting objects

2018-12-09 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: There was a related proposal in https://www.python.org/dev/peps/pep-0258/#attribute-docstrings -- ___ Python tracker <https://bugs.python.org/issue35

[issue24928] mock.patch.dict spoils order of items in collections.OrderedDict

2018-12-09 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks @nekobon for the patch. I am triaging old mock related issues. I think dict insertion order is maintained from 3.6 and guaranteed with 3.7 and above. But it would be good to add the unit test in the patch as a PR. I ran the test on master

[issue35463] mock uses incorrect signature for partial and partialmethod with autospec

2018-12-11 Thread Karthikeyan Singaravelan
New submission from Karthikeyan Singaravelan : This is a bug report for https://bugs.python.org/issue17185#msg331149 that I was asked to raise as a separate issue. 1. When we call create_autospec it calls _get_signature_object that gets the signature for the given parameter. With

[issue32153] mock.create_autospec fails if an attribute is a partial function

2018-12-12 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: @cjw296 since the unit tests were added and the original report is fixed with 3.7 and above can this be closed? -- ___ Python tracker <https://bugs.python.org/issue32

[issue35488] pathlib Path.match does not behave as described

2018-12-14 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue35488> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35488] pathlib Path.match does not behave as described

2018-12-14 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Is this similar to issue29249 (See also msg285311) and issue34731 ? As I can see in Lib/test/test_pathlib.py there are also no tests for "**" and I think it's good to add one along with

[issue27715] call-matcher breaks if a method is mocked with spec=True

2018-12-14 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I think the original issue with patch.object reported by Carl is different from the one reported by David for autospec. Analyzed the report by David and When we call autospec on a class with instance=True then the spec is modeled on the signature

[issue35500] Align expected and actual calls on mock.assert_called_with error message

2018-12-14 Thread Karthikeyan Singaravelan
New submission from Karthikeyan Singaravelan : Currently, assert_called_with has expected calls list in the same line with AssertionError that causes the visualizing the difference to be hard. It will be great if Expected call occurs on the next line so that the diff is improved. The change

<    12   13   14   15   16   17   18   19   20   21   >