[issue43758] dict.config TimedRotatingFileHandler filename .suffix does not function

New submission from Justin Lee : Hi, I would like to change the .suffix for the TimedRotatingFileHandler for the "future-created" file in dictConfig written in json. Is there any suggestion on how to do that? -- messages: 390400 nosy: tea940314 priority: normal severi

[issue45520] Frozen dataclass deep copy doesn't work with __slots__

Justin Furuness added the comment: I didn't realize it was possible to add slots in that way (slots=True). I think for normal classes manually defining __slots__ is the common way of adding __slots__ (at least for me), so it feels weird to me that manually defining __slots__ instead of a

[issue45520] Frozen dataclass deep copy doesn't work with __slots__

Justin Furuness added the comment: Thank you for the in-depth explanation. That all makes sense to me, I have run into the __slots__ with defaults issues before, I'll be sure to try out these fixes. I appreciate you taking the time. Thanks, Justin On Tue, Oct 19, 2021 at 5:28 PM

[issue38860] GenericPyCData_new does not invoke new or init

New submission from Justin Capella : When subclassing the ctypes.Structure class, __new__ and __init__ are not invoked when using the inherited classmethod from_buffer_copy to create the object. I think this is because tp_alloc is ultimately used by GenericPyCData_new when creating the

[issue38576] CVE-2019-18348: CRLF injection via the host part of the url passed to urlopen()

Justin Capella added the comment: Can't see the specifics of that "restricted" redhat bug, but this was interesting bug and I wanted to ask if perhaps the domain in such cases should be IDN / punycoded ://xn--n28h.ws/ for example is ://💩.la --

[issue38860] GenericPyCData_new does not invoke new or init

Justin Capella added the comment: It might make sense that CSimpleData types do not call init, which makes sense for _fields_ but it doesn't make sense to offer subclassing (of Structure) and not use the subclass, instead creating a type of the same name. That test case is bugged, mi

[issue39175] Funkness with issubset

New submission from Justin Hodder : line 59,"print(x2,"avalMana",set(avalMana.keys()))" prints:"{('A', 'B')} avalMana {'A', ('A', 'B'), ('A', 'C')}" line 60,"if x2.issubset(set(ava

[issue39175] Funkness with issubset

Justin Hodder added the comment: This works: $ diff PythonDoesntWorks.py HowCanYouPayMana.v3.py 60c60 < if x2.issubset(set(avalMana.keys())): --- > if x2.issubset(set(list(avalMana.keys(: 62a63 > this doesn't work: $ diff PythonDoesntWorks.py HowCanYouPayMa

[issue39175] Funkness with issubset

Justin Hodder added the comment: oh I'm using Python 3.8.1 (32-bit) 3.8.1150.0 on win10 -- ___ Python tracker <https://bugs.python.org/issue39175> ___ ___

[issue39175] Funkness with issubset

Justin Hodder added the comment: AttributeError: 'tuple' object has no attribute 'issubset' And it doesn't explain why it works as expected in Brython. -- ___ Python tracker <https:

[issue38860] GenericPyCData_new does not invoke new or init

Justin Capella added the comment: Becca were you still interested in this issue? Anyone agree the unit test seems to have a bug if that is intended behavior? Is there a better forum for discussion about design/behavior, maybe the more generic issue of GenericPyCData_new using tp_alloc

[issue40078] asyncio subprocesses allow pids to be reaped, different behavior than regular subprocesses

New submission from Justin Lebar : >From https://bugs.python.org/issue1187312 about regular subprocesses: > So as long as the application keeps a reference to the > subprocess object, it can wait for it; auto-reaping only > starts when the last reference was dropped [in P

[issue1187312] subprocess: optional auto-reaping fixing os.wait() lossage

Justin Lebar added the comment: 15 years later, it seems asyncio subprocesses may have the same issue. :) https://bugs.python.org/issue40078 -- nosy: +Justin.Lebar ___ Python tracker <https://bugs.python.org/issue1187

[issue40078] asyncio subprocesses allow pids to be reaped, different behavior than regular subprocesses

Change by Justin Lebar : -- versions: +Python 3.7, Python 3.8 ___ Python tracker <https://bugs.python.org/issue40078> ___ ___ Python-bugs-list mailing list Unsub

[issue40078] asyncio subprocesses allow pids to be reaped, different behavior than regular subprocesses

Change by Justin Lebar : -- type: -> behavior versions: +Python 3.9 ___ Python tracker <https://bugs.python.org/issue40078> ___ ___ Python-bugs-list mai

[issue13337] IGNORE_CASE doctest option flag

Change by Justin Baum : -- keywords: +patch nosy: +justinba1010 nosy_count: 3.0 -> 4.0 pull_requests: +22426 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23547 ___ Python tracker <https://bugs.python.org/i

[issue41337] strangnedd with the parser

New submission from Justin Hodder : Here a colab that demostrates the bug https://colab.research.google.com/drive/1OWSEoV7Wx-EBA_2IprNZoASNvXIky3iC?usp=sharing the following code gives"received an invalid combination of arguments - got (Tensor, Tensor), but expected one of:" im

[issue33533] Provide an async-generator version of as_completed

Change by Justin Arthur : -- nosy: +JustinTArthur nosy_count: 5.0 -> 6.0 pull_requests: +21508 pull_request: https://github.com/python/cpython/pull/22491 ___ Python tracker <https://bugs.python.org/issu

[issue33533] Provide an async-generator version of as_completed

Justin Arthur added the comment: I've added a new PR, PR 22491. This one has as_completed returning an iterator and includes tests for both the old and new style. I see a trivial amount of latency added in extra call stack over Guido's original implementation. Should we decide to

[issue38032] lib2to3 doesn't parse Python 3 identifiers containing non-spacing marks

Justin Arthur added the comment: Not sure if there is consensus on how to fix, but fixing #12731 will fix this for most of the cases I've seen complaints about as a side effect. -- ___ Python tracker <https://bugs.python.org/is

[issue33533] Provide an async-generator version of as_completed

Justin Arthur added the comment: Thanks, Hrvoje. I've updated the patch to match this bug's suggested format and have updated the documentation and What's New. The one quirk that comes with the benefit of getting the same futures back is that we still allow both coroutines an

[issue33533] Provide an async iterator version of as_completed

Change by Justin Arthur : -- title: Provide an async-generator version of as_completed -> Provide an async iterator version of as_completed ___ Python tracker <https://bugs.python.org/issu

[issue33533] Provide an async iterator version of as_completed

Change by Justin Arthur : -- versions: +Python 3.10 -Python 3.8 ___ Python tracker <https://bugs.python.org/issue33533> ___ ___ Python-bugs-list mailin

[issue38912] test_asyncio altered the execution environment

Change by Justin Arthur : -- nosy: +JustinTArthur nosy_count: 5.0 -> 6.0 pull_requests: +21662 pull_request: https://github.com/python/cpython/pull/22691 ___ Python tracker <https://bugs.python.org/issu

[issue38912] test_asyncio altered the execution environment

Justin Arthur added the comment: The "'NoneType' object has no attribute 'close'" error is likely caused by a race against the loop calling the test protocol object's connection_made callback. I was able to reproduce this case occasionally on macOS and it

[issue42140] asyncio.wait function creates futures set two times

Justin Arthur added the comment: Your change makes perfect sense to me. It would be a backport-only change as the 2nd set creation is actually getting removed for the development version (3.10) to finalize the deprecation of wait's coroutine scheduling. -- nosy: +JustinTA

[issue42140] asyncio.wait function creates futures set two times

Justin Arthur added the comment: I believe the documentation may be referring to the English set and not a Python set, but I could be wrong. Yury changed the wording from sequence to set in 3.7, but we didn't document a breaking change as far as I know. The purpose of thos

[issue42140] asyncio.wait function creates futures set two times

Justin Arthur added the comment: > So the behaviour you describe will happen anyway. Unless we make your change against the 3.9 branch, in which case the fix will make it into the 3.9.x series of patch releases. -- ___ Python tracker <

[issue13801] The Python 3 Docs doesn't highlight nonlocal

Justin Wehnes added the comment: Nonlocal is highlighted under Language Reference under simple statements section 6.13 (http://docs.python.org/dev/reference/index.html). help("nonlocal") will also bring up the documentation (works for me in 3.3). -- nosy

[issue13801] The Python 3 Docs don't highlight nonlocal

Justin Wehnes added the comment: Ahh yes I see it. Sorry about that. -- ___ Python tracker <http://bugs.python.org/issue13801> ___ ___ Python-bugs-list mailin

[issue13816] Two typos in the docs

Justin Wehnes added the comment: Removed the hyphen in function keys. Didn't really see a problem with using an apostrophe in 'ith' instead of a hyphen because I have seen it done both ways but changed it anyways. This is my first contribution so i needed the practice. Hope I

[issue13816] Two typos in the docs

Changes by Justin Wehnes : Added file: http://bugs.python.org/file24274/i_th_hyphen.diff ___ Python tracker <http://bugs.python.org/issue13816> ___ ___ Python-bugs-list m

[issue13816] Two typos in the docs

Justin Wehnes added the comment: Fixed. -- Added file: http://bugs.python.org/file24302/issue13816.diff ___ Python tracker <http://bugs.python.org/issue13

[issue13857] Add textwrap.indent() as counterpart to textwrap.dedent()

Justin Wehnes added the comment: Just wondering if someone is already working on this or am I free to supply a patch? -- nosy: +jwehnes ___ Python tracker <http://bugs.python.org/issue13

[issue37086] time.sleep error message misleading

New submission from Justin Fay : Using python3.6 and calling `time.sleep` with an invalid argument the `TypeError` raised has the error message "TypeError: an integer is required". This is not the case as a float or integer is acceptable. Using python 2.7 the error message given

[issue37086] time.sleep error message misleading

Justin Fay added the comment: >From looking at the code for this (note I am not a C programmer so may have >gotten this wrong) _PyTime_FromObject first checks if the object is a float >using PyFloat_Check(obj) this is evident as passing nan to time.sleep raises a >ValueEr

[issue37372] datetime.time unpickling fails in case of python2 pickle with seconds>=24

New submission from Justin Blanchard : Under bpo-22005, Python 3 gained support for unpickling datetime data from Python 2. (Thanks!) It turns out the input validation isn't quite right: it bombs on datetime.time when the encoded seconds (not hours) field is >=24: python2>>>

[issue27755] Retire DynOptionMenu with a ttk Combobox

Justin Foo added the comment: Thanks for analysing further, Terry. My original goal was a drop-in replacement for an aspect of IDLE I found quite annoying (on Windows). Unfortunately, my limited playing with tkinter didn't inspire me to go beyond

[issue36931] json lib doesnt want to load from file

New submission from Justin Rose : when I run the included file i get an error that looks like: Traceback (most recent call last): File "/home/justin/Desktop/pkmn/main.py", line 10, in expansion = json.load(expan_list) File "/usr/lib/python3.6/json/__init__.py"

[issue33643] Mock functions with autospec STILL don't support assert_called_once, assert_called, assert_not_called

Justin Dray added the comment: I can still reproduce this with python 3.6.5: https://gist.github.com/justin8/c6a565d3b64222a9ba3a2568d1d830ee no .assert_called() on autospec'd functions, but it works with normal mock.MagicMock() ipython autocomplete shows assert_any

[issue15103] Solaris compiler chokes on importlib.h

Justin Venus added the comment: What is the purpose of the comment at the end of "Python/importlib.h"? If I remove the comment that states "binary marker for mercurial" (something to that effect anyhow) the code compiles and only the tests fail. --

[issue12927] test_ctypes: segfault with suncc

Justin Venus added the comment: I can confirm (see attachement) that `--with-system-ffi` prevents the segfault on test_ctypes with the solaris compiler on Solaris11 x86. I did not have to update the system at all for this switch to work. -- Added file: http://bugs.python.org

[issue3786] _curses, _curses_panel & _multiprocessing can't be build in 2.6b3 w/ SunStudio 12

Justin Venus added the comment: The attached patch allows _curses and _curses_panel to build with the sunpro compiler on Solaris11. The only changes were compiler/linker options in the main setup.py. The interactive curses_test works on my system. I can easily make patches for python2.7

[issue13405] Add DTrace probes

Justin Venus added the comment: @jcea I am the owner of the Solaris 11 buildslave[1]. I have configured the build user to have dtrace privileges if you need to run additional tests against it. Let me know if you encounter any additional issues with this system. 1)http://buildbot.python.org

[issue15268] curses configure checks fail if only /usr/include/ncursesw/curses.h is installed

Justin Venus added the comment: I have a similar issue on Solaris and a patch[1] to fix it attached to issue 3786. 1) http://bugs.python.org/file26171/bug3786.patch -- nosy: +Justin.Venus ___ Python tracker <http://bugs.python.org/issue15

[issue12927] test_ctypes: segfault with suncc

Justin Venus added the comment: I can confirm this issue is resolved on Solaris 11 x86 and has been since '--with-system-ffi' was added to the build rules. -- ___ Python tracker <http://bugs.python.o

[issue13552] Compilation issues of the curses module on OpenIndiana

Justin Venus added the comment: Does OpenIndiana ship with the gnu version of ncurses like Solaris 11? Headers: /usr/include/ncurses Libraries: /usr/gnu/lib If it matches Solaris, then you can use my patch[1] in issue 3786 to see if that works around the issue, like it does for Solaris. 1

[issue3786] _curses, _curses_panel & _multiprocessing can't be build in 2.6b3 w/ SunStudio 12

Justin Venus added the comment: I am sure that macro object is there for good reason, it just doesn't apply for Solaris 11. On Jul 7, 2012 10:34 AM, "Éric Araujo" wrote: > > Éric Araujo added the comment: > > +# work around for assumpti

[issue16057] Subclasses of JSONEncoder should not be insturcted to call JSONEncoder.decode

New submission from Justin Lebar: The JSONEncoder documentation says we can implement our own encoder as: >>> class ComplexEncoder(json.JSONEncoder): ... def default(self, obj): ... if isinstance(obj, complex): ... return [obj.real, obj.imag] ...

[issue16057] Subclasses of JSONEncoder should not be insturcted to call JSONEncoder.decode

Justin Lebar added the comment: Ah, I see. The examples do what you think they should do, but not for the reason you think they should do it -- the JSON encoding logic calls the encoder's encode() method before calling its default() method. I still think the examples could be imp

[issue13936] RFE: change bool(datetime.time(0, 0, 0)) to evaluate as True

Justin Brown added the comment: This behavior conflicts with the other major classes, datetime.date and datetime.datetime. The ostensible reason for this falsy behavior is that midnight represents a fundamental zero point. We should expect to see similar zero points that evaluate to False for

[issue20849] add exist_ok to shutil.copytree

Changes by Justin Myers : -- nosy: +justin.myers ___ Python tracker <http://bugs.python.org/issue20849> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21699] Windows Python 3.4.1 pyvenv doesn't work in directories with spaces.

New submission from Justin Engel: Venv virtual environments don't work with spaces in the path. (env) C:\My Directory\path > pip -V Fatal error in launcher: Unable to create process using '""C:\My Directory\path\env\Scripts\python.exe"" "C:\My

[issue16924] try: except: ordering error

New submission from Justin Eittreim: When running multiple nested loops (to emulate the circumstances of a program running multiple different modules at once,) each with their own try: except: block (in this case for KeyboardInterrupt,) the order of operations seems to fall out of place. As

[issue22395] test_pathlib error for complex symlinks on Windows

New submission from Justin Foo: The _check_complex_symlinks function compares paths for string equality instead of using the assertSame helper function. Patch attached. -- components: Tests messages: 226828 nosy: jfoo priority: normal severity: normal status: open title: test_pathlib

[issue22395] test_pathlib error for complex symlinks on Windows

Justin Foo added the comment: The _check_complex_symlinks function compares stringified paths for string equality instead of using the assertSame helper method. Patch attached. -- keywords: +patch Added file: http://bugs.python.org/file36609/issue22395.patch

[issue22395] test_pathlib error for complex symlinks on Windows

Justin Foo added the comment: The failing tests were: * test_complex_symlinks_absolute * test_complex_symlinks_relative * test_complex_symlinks_relative_dot_dot for both PathTest and WindowsPathTest, via inheritance from the _BasePathTest class

[issue7511] msvc9compiler.py: ValueError when trying to compile with VC Express

Justin Foo added the comment: The speedups extension for MarkupSafe (which has a pure Python fallback) on Python 3.3.3 64-bit was happily compiled with `pip install markupsafe` after applying Steve's patch and Li Wah's definition for KEY_BASE. -- n

[issue20301] Correct docs for default access argument for DeleteKeyEx

New submission from Justin Foo: The default access for winreg.DeleteKeyEx is winreg.KEY_WOW64_64KEY (as per the function signature). This the documentation for Python 2.7 has this correct. Reference: http://hg.python.org/cpython/file/2e32462e4832/PC/winreg.c#l1089 -- assignee: docs

[issue20690] IDLE Indents convert to spaces and then throws error

New submission from Justin Barker: When I add some lines to my module code, some of the tabs that I enter convert to spaces. This throws an inconsistency error and I can't get it to stop! -- components: IDLE files: test.py messages: 211664 nosy: Justin.Barker priority: normal sev

[issue7511] msvc9compiler.py: ValueError when trying to compile with VC Express

Justin Foo added the comment: I think getting this bug fixed would be really nice from a user experience point of view. I've further into this for my own setup, which is Python 3.3 64-bit, Visual C++ Express 2010 and the Windows SDK v7.1 (plus service packs), which is probably a ty

[issue5738] multiprocessing example wrong

Justin MacCallum added the comment: I think this should either be fixed or removed from the documentation. It is very confusing as is. I have next to no idea what I'm doing, but I've attached a patch that allows this code to function, at least sort of. You can now create cluste

[issue8833] tarfile: broken hardlink handling and testcase.

New submission from Justin Bronder : When adding hardlinks to an archive, tarfile does not set the size of each additional link to zero as specified by the tar format [1]. In addition, the current test case hardlinks is also broken. Instead of testing that the size of a hardlink to a non-empty

[issue9003] urllib about https behavior

Changes by Justin Samuel : -- nosy: +jsamuel ___ Python tracker <http://bugs.python.org/issue9003> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8998] add crypto routines to stdlib

Changes by Justin Samuel : -- nosy: +jsamuel ___ Python tracker <http://bugs.python.org/issue8998> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1589] New SSL module doesn't seem to verify hostname against commonName in certificate

Changes by Justin Samuel : -- nosy: +jsamuel ___ Python tracker <http://bugs.python.org/issue1589> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9065] tarfile: default root:root ownership is incorrect.

New submission from Justin Bronder : According to the tar spec [1], uname/gname should only be filled when they have successfully been resolved from the uid/gid. The tarfile module incorrectly defaults to root:root in this case. A patch against svn trunk r82183 is included. All tarfile unit

[issue9065] tarfile: default root:root ownership is incorrect.

Changes by Justin Bronder : -- components: +Library (Lib) versions: +Python 2.6 ___ Python tracker <http://bugs.python.org/issue9065> ___ ___ Python-bugs-list m

[issue29518] 'for' loop not automatically breaking (index error on line of loop header)

New submission from Justin McNiel: All for loops are refusing to break (Python 2.7.13) on win32 - only on execution of '.py' file an example would be:" for x in range(5): #Line 1 of main.py print x#Line 2 of main.py " and the resulting error would be:&q

[issue29518] 'for' loop not automatically breaking (index error on line of loop header)

Justin McNiel added the comment: While restarting didn't fix it, waiting for the next morning did, so I am afraid that that isn't possible, also, I have made tremendous changes to my code since then, but I would by happy to send you any bit of my code that you would like, it cold

[issue27755] Retire DynOptionMenu with a ttk Combobox

New submission from Justin Foo: One aspect of the IDLE interface that looks extremely old is the the dropdown menu. In the patch, I think I've preserved whatever essential functionality DynOptionMenu used to have, but I'm relatively unfamiliar with Tk so I'm not sure.

[issue27755] Retire DynOptionMenu with a ttk Combobox

Changes by Justin Foo : -- keywords: +patch Added file: http://bugs.python.org/file44097/issue27755.patch ___ Python tracker <http://bugs.python.org/issue27

[issue21417] Compression level for zipfile

Justin Foo added the comment: Would compresslevel be a suitable argument? All the backend compressors accept values from 1 to 9 if I'm not mistaken. -- nosy: +jfoo ___ Python tracker <http://bugs.python.org/is

[issue21417] Compression level for zipfile

Justin Foo added the comment: I thought about that, but: 1. compresslevel=None might make look like no compression was being done at all 2. The current default is not 9 for all backends -- ___ Python tracker <http://bugs.python.org/issue21

[issue22395] test_pathlib error for complex symlinks on Windows

Justin Foo added the comment: This is no longer a problem for me and I can't reproduce why it was even a problem in the first place. -- status: open -> closed ___ Python tracker <http://bugs.python.org

[issue27755] Retire DynOptionMenu with a ttk Combobox

Justin Foo added the comment: Ah, I've noticed the folly of my ways. This sort of stuff is already being managed with patches filed under various other issues. It just wasn't obvious to me as I wasn't seeing many new improvements in the default branch or much communicat

[issue27755] Retire DynOptionMenu with a ttk Combobox

Justin Foo added the comment: I wasn't sure if the ongoing work in #24781 essentially rendered my patch obsolete, so I keenly await Mark's response. Upon reflection, I think my patch is a cheap win even if it's later overhauled by other improvements. -- status:

[issue23317] Incorrect description of descriptor invocation in Python Language Reference

New submission from Justin Eldridge: The section titled "Invoking Descriptors" in the Python Language Reference [1] says: Class Binding If binding to a new-style class, A.x is transformed into the call: A.__dict__['x'].__get__(None, A). This suggests th

[issue23317] Incorrect description of descriptor invocation in Python Language Reference

Justin Eldridge added the comment: Ah, I see how writing a description of this which is both concise and precise would be difficult, especially for Python 2. > But the Class Binding description is correct, since if the __get__ method is > *not* defined on the type (of the descriptor

[issue24645] logging.handlers.QueueHandler should not lock when handling a record

New submission from Justin Bronder: The Queue backing the QueueHandler is already sufficiently locking for thread-safety. This isn't a huge issue, but the QueueHandler is a very nice built-in which could be used to work around a deadlock I've encountered several times. In brief,

[issue24645] logging.handlers.QueueHandler should not lock when handling a record

Justin Bronder added the comment: On 16/07/15 20:03 +, R. David Murray wrote: > > R. David Murray added the comment: > > Can you expand on the deadlock? Are you saying that the "extra" locking is > causing the deadlock? > > -- > nosy: +r.da

[issue24645] logging.handlers.QueueHandler should not lock when handling a record

Justin Bronder added the comment: On 16/07/15 23:21 +, Vinay Sajip wrote: > > Vinay Sajip added the comment: > > I'm not sure I want to make a special case just to support what seems like a > somewhat pathological use case (no offence intended). > > If you ne

[issue24652] C-API Pure Embedding enhancement

New submission from Justin Huang: >From the example in here: https://docs.python.org/2/extending/embedding.html#pure-embedding when directly using the example (compiling and trying with external file etc.) it doesn't work right away. Instead an extra line: PySys_SetArgv(ar

[issue25593] _sock_connect_cb can be called twice resulting in InvalidStateError

Justin Mayfield added the comment: I believe I'm seeing this bug in a non-threaded and non-forked env. System: OSX 10.11.1 (15B42) Python 3.5.0 (from brew install) I'm using aiohttp to create several dozens of HTTP connections to the same server (an async tornado web server)

[issue25593] _sock_connect_cb can be called twice resulting in InvalidStateError

Justin Mayfield added the comment: Attaching simplified test setup. It does take some doing to repro so the local async server is required to make it happen (for me). When I tried just pointing to python.org it would not repro in 100 iterations, but using a local dummy server repros 100

[issue25593] _sock_connect_cb can be called twice resulting in InvalidStateError

Justin Mayfield added the comment: Attached server side of repro. -- Added file: http://bugs.python.org/file41017/Issue25593_repro_server.py ___ Python tracker <http://bugs.python.org/issue25

[issue25593] _sock_connect_cb can be called twice resulting in InvalidStateError

Justin Mayfield added the comment: This code repros without aiohttp when pitted against the previously attached web server (again on OSX 10.11, mid-2012 MBPr). Admittedly this may seem very arbitrary but I have better reasons in my production code for stopping an IOLoop and starting it again

[issue25593] _sock_connect_cb can be called twice resulting in InvalidStateError

Justin Mayfield added the comment: Just reproduced on Linux, Fedora Core 23. -- ___ Python tracker <http://bugs.python.org/issue25593> ___ ___ Python-bugs-list m

[issue25593] _sock_connect_cb can be called twice resulting in InvalidStateError

Justin Mayfield added the comment: Guido, Shouldn't this not be the case for level triggered polling? From looking at selectors it looks like these are always level triggered which means they should only event once. -- ___ Python tracker

[issue25593] _sock_connect_cb can be called twice resulting in InvalidStateError

Justin Mayfield added the comment: Nevermind, in the case of writeablity it won't matter either way. -- So in looking at tornado's ioloop they run the ready callbacks before calling poll(). So the callbacks can modify the poll set. --

[issue25593] _sock_connect_cb can be called twice resulting in InvalidStateError

Justin Mayfield added the comment: I'm attaching a patch that runs `_ready` callbacks at the start of `_run_once`. The style and implications are ranging so I leave it to you at this point. -- keywords: +patch Added file: http://bugs.python.org/file

[issue25593] _sock_connect_cb can be called twice resulting in InvalidStateError

Justin Mayfield added the comment: I don't believe this is a case of nonidempotent callbacks, unless you are referring to Future.set_result(), which by design can't be called twice. The callbacks are given an inconsistent opportunity to modify the poll set because of indetermin

[issue25593] _sock_connect_cb can be called twice resulting in InvalidStateError

Justin Mayfield added the comment: Interesting. I was going to do an analysis what using _ready.appendleft() for adding selector events would do for that scenario. The idea being to consistently juxtapose exiting callbacks, selector events and new callbacks. However I think this just moves

[issue25593] _sock_connect_cb can be called twice resulting in InvalidStateError

Justin Mayfield added the comment: Yes, that's what I was suggesting. Looking at tornado they do the stop between callbacks/matured-scheduled and events. That approach seems somewhat arbitrary to me at first glance but tornado is very mature and they usually have good reasons for what

[issue25593] _sock_connect_cb can be called twice resulting in InvalidStateError

Justin Mayfield added the comment: +1 Let me know what I can do to help. -- ___ Python tracker <http://bugs.python.org/issue25593> ___ ___ Python-bugs-list mailin

[issue25593] _sock_connect_cb can be called twice resulting in InvalidStateError

Justin Mayfield added the comment: You bet. -- ___ Python tracker <http://bugs.python.org/issue25593> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25593] _sock_connect_cb can be called twice resulting in InvalidStateError

Justin Mayfield added the comment: Attached patch submission for stop flag proposal. I assume you didn't mean a github PR since the dev docs seem to indicate that is for readonly usage. This passes all the tests on my osx box but it should obviously be run by a lot more

[issue25593] _sock_connect_cb can be called twice resulting in InvalidStateError

Justin Mayfield added the comment: I should have commented more on the run_once removal. The depiction given in its docstring seemed inconsistent with the new way stop works and I found no callers, so it seemed like it was best left out to avoid confusion. No worries though, I didn't g

[issue25593] _sock_connect_cb can be called twice resulting in InvalidStateError

Justin Mayfield added the comment: Ha, email race. Regarding rev 2, the updated docstring and scheduled stop looks good along with alleviating the confusion I mentioned. I'm not sure about your warning comment; Perhaps that's a patch I didn't lay e

[issue25593] _sock_connect_cb can be called twice resulting in InvalidStateError

Justin Mayfield added the comment: I see. Seems like good discussion over there. I joined up. -- ___ Python tracker <http://bugs.python.org/issue25593> ___ ___

<    1   2   3   >