Julien Palard added the comment:
> I also discovered several holes in the test suite coverage while refactoring
> it.
Are they all tested in the current diff?
--
nosy: +mdk
___
Python tracker
<http://bugs.python.org/i
Julien Palard added the comment:
Look like issue1745108 has only be closed for being "outdated" (msg240919 ), it
does not clearly mean that the bug does no longer exists.
Have you been able to test the example in it?
--
___
Python trac
Julien Palard added the comment:
“digits which do not form decimal radix forms”
> “forming a form” seems a long way of saying very little. The difference seems
> a bit vague
> I gather that digits not in the Unicode “decimal digit” category are often
> (always?) still decim
Julien Palard added the comment:
So, is there still an inconsistency in the documentation?
--
___
Python tracker
<http://bugs.python.org/issue26363>
___
___
Pytho
Julien Palard added the comment:
Hi, thanks for reporting,
Variables are defined in python docs¹ by:
> If a name is bound in a block, it is a local variable of that block, unless
> declared as nonlocal or global. If a name is bound at the module level, it is
> a global varia
Julien Palard added the comment:
Should this issue be closed so?
--
___
Python tracker
<http://bugs.python.org/issue28853>
___
___
Python-bugs-list mailin
Julien Palard added the comment:
> But gettext formulas are not purposed to support non-integer values and can
> return incorrect result
Looks like the cast to integer is done *before* giving the value to the C
gettext expression.
> For example (in Ukrainian)
As long as gettext e
Julien Palard added the comment:
> It seems to me that a fractional number should be formatted with the same
> form independently from it's value
Ok, so 1.000 seconds, ok, LGTM.
Should we mention something explicit about it? Not sure how to write it down,
but I still fear that
Julien Palard added the comment:
@Victor you're right, I forgot that partial can also apply keyword arguments.
Here is a new patch.
--
Added file: http://bugs.python.org/file45753/issue28707.diff
___
Python tracker
<http://bugs.py
Julien Palard added the comment:
Unless somebody don't think so, I think this should go as a pypi module before
going to the socket module, so this issue should probably be closed.
--
___
Python tracker
<http://bugs.python.org/is
Julien Palard added the comment:
Hi Martin,
Historically (lo=0, hi=None) was the implementation (in Python), until the C
implementation, which used (lo=0, hi=-1). As my implementation allows for -1
and None, I don't think I'm breaking
Julien Palard added the comment:
LGTM, for me it's time to release it as a package on pypi to check the adoption
rate and see it it's worth adding it in Python and maybe close this issue.
--
___
Python tracker
<http://bugs.python.o
Julien Palard added the comment:
FWIW, in _PyType_Lookup I see the "300" PyLong being cached, and later, just
before the segfault, I see its address getting out of the cache (a cache hit)
but it's no longer a PyLong, it's scrambled, so we're getting a real pointer
wit
Julien Palard added the comment:
I'm able to reproduce the segmentation fault outside the interactive mode, see
attached file.
--
Added file: http://bugs.python.org/file45756/weird_without_interactive.py
___
Python tracker
<http://bugs.py
Julien Palard added the comment:
Problem looks mainly due to the __setattr__ done on a different type than the
getattr, and the cache of PyType_Lookup:
- type_setattro will be called with Foo, "x", and the value to set
- type_getattro will be called with FooProxy, "x"
T
Changes by Julien Palard :
Added file: http://bugs.python.org/file45764/issue28707.diff
___
Python tracker
<http://bugs.python.org/issue28707>
___
___
Python-bugs-list m
Julien Palard added the comment:
I found a way to fix it, but as I'm just discovering cpython internals, I'm not
sure it's the right way, review are very welcome.
I fixed it this way because:
The bytecode generated for "proxy.x = 0" (a STORE_ATTR) will call a
PyObj
Julien Palard added the comment:
Carefully reviewed, and tests are passing, issue is fixed: LGTM.
--
nosy: +mdk
___
Python tracker
<http://bugs.python.org/issue28
Julien Palard added the comment:
> issue28866.diff always invalidates the cache, so it works. But it is
> suboptimal, IMO it defeats the whole purpose of a cache.
Not sure about defeating the purpose of the cache as I only invalidate in
setattr, getattr are still cache hitting. I
Changes by Julien Palard :
Added file: http://bugs.python.org/file45793/issue26483.diff
___
Python tracker
<http://bugs.python.org/issue26483>
___
___
Python-bugs-list m
Julien Palard added the comment:
Just rebasing my patch on tip as it does no longer cleanly apply.
--
Added file: http://bugs.python.org/file45795/issue28755-3.diff
___
Python tracker
<http://bugs.python.org/issue28
Julien Palard added the comment:
Tried to run the test_nanfunctions.py on tip and Python 3.6.0b4+, on numpy 1.11
and 1.12.0b1, can't make it fail.
Installed numpy 1.12.0b1 using: ./python -m pip install --user numpy==1.12.0b1
I suspect Charles tested using Python 3.6.0b3 (can you co
Julien Palard added the comment:
I was able to simplify my patch a bit, I think I should also add a test to
ensure we keep the hi=-1 and hi=None compatibility in the future.
--
Added file: http://bugs.python.org/file45832/issue28754-8.diff
Julien Palard added the comment:
Added a test to ensure compatibility of both hi=None (introduced in original
Python version) and hi=-1 (Introduced by the C version).
Modified Python version to be compatible with the C-introduced hi=-1, so that
the new test pass
Changes by Julien Palard :
Added file: http://bugs.python.org/file45836/issue28754-9.diff
___
Python tracker
<http://bugs.python.org/issue28754>
___
___
Python-bugs-list m
New submission from Julien Palard:
Today, writing an AC declaration like:
something: Py_ssize_t(c_default="-1") = None
Leads to the almost obvious "Py_ssize_t_converter: default value None for field
something is not of type int".
But it actually make sense:
- Acce
Changes by Julien Palard :
--
title: AC: Accept None as a default value for any type -> AC: Accept None as a
Py_ssize_t default value
___
Python tracker
<http://bugs.python.org/issu
Julien Palard added the comment:
Proposed a patch, but I'm not a huge fan of modifying getargs.c. If it's
accepted, I'll obviously need to write tests before this is merged.
--
keywords: +patch
Added file: http://bugs.python.org/file45838/
Julien Palard added the comment:
Maybe wait for issue28933.
--
___
Python tracker
<http://bugs.python.org/issue28754>
___
___
Python-bugs-list mailing list
Unsub
Julien Palard added the comment:
Hi Larry,
In any cases it looks like supporting hi=-1 and hi=None is mandatory:
hi=None is the current implementation in the bisect (Python) module.
hi=-1 is the current implementation in the _bisect (C) module.
Both are currently living together, the C
Julien Palard added the comment:
Hi Raymond,
I don't like having the converters in the C implementation too, that's why I'm
working on issue28933 to clean this.
> letting the C function handle both -1 and None in the implementation rather
> than in AC?
It works, yes. Bu
Julien Palard added the comment:
> It looks like you did it with a converter for 28754. That's okay. But not
> in the default implementation.
It's not by default, we have to declare "… = None" in the AC declaration, which
was an error before my patch (inc
Julien Palard added the comment:
> You propose an automatic conversion of "None" into "-1"? That's awful.
> Please don't commit that patch to CPython.
Not really, I propose a way to do it with AC when needed. And the AC semantics
introduced are not "
Changes by Julien Palard :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue28753>
___
___
Python-bugs-list mailing list
Unsubscrib
Julien Palard added the comment:
I renamed your function groupby2 to compare it with itertools.groupby and
tested but:
>>> print(list(groupby2(['A', 'B'])))
does not returns, looks like your implementation have a bug, so I tried:
>>> for k in groupby2(
Julien Palard added the comment:
Hi Larry,
Did you take more time to review this patch and my last comments? I don't think
it that awful as it does _not_ apply until explicitly asked for, but I'm open
to discuss it.
--
___
Python trac
Julien Palard added the comment:
LGTM but no AIX to test it.
--
___
Python tracker
<http://bugs.python.org/issue28845>
___
___
Python-bugs-list mailing list
Unsub
Julien Palard added the comment:
> for just one use case
I don't think that using None in a default argument is "one use case", nor a
"special case" it's more like a "widly used pattern" that I'd like to make
simple to implement (also see http:/
Julien Palard added the comment:
Hi Larry,
Do you mean a new converter in clinic.py like Nullable_Py_ssizze_t, or a
converter that I copy/paste every time I need it like
http://bugs.python.org/review/28754/patch/19417/76440 ?
--
___
Python tracker
Changes by Julien Palard :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue28933>
___
___
Python-bugs-list mailing list
Unsubscrib
Julien Palard added the comment:
As the pattern of this converter is not widely used, I'll let it in the code of
_bisect for the moment, see: http://bugs.python.org/issue28933.
--
___
Python tracker
<http://bugs.python.org/is
Julien Palard added the comment:
For the record, I opened a WIP pull request here:
https://github.com/python/docsbuild-scripts/pull/8
Feedback is welcome.
--
___
Python tracker
<http://bugs.python.org/issue26
Julien Palard added the comment:
Hi,
Tried again, this time getting some stats with MCACHE_STATS 1, to check if my
patch is defeating the cache:
Without my patch:
$ time ./python performance/benchmarks/bm_chaos.py --worker -l1 -w0 -n1
--filename chaos.ppm --width=512 --height=512
Julien Palard added the comment:
John: You should probably package this as a pip module alongisde with a git
repository, at least to measure qty of interested persones, and get some
feedback / contributions.
--
___
Python tracker
<h
Changes by Julien Palard :
--
pull_requests: +143
___
Python tracker
<http://bugs.python.org/issue28754>
___
___
Python-bugs-list mailing list
Unsubscribe:
Julien Palard added the comment:
Your implementation looks right, but I don't see the point of defining
combinations AB, AC, ABD in the Foo enum. Foo may only define A, B, C, D and
outside of Foo anyone can build any needed combinations.
This way it looks clear in the Foo declaration (4
New submission from Julien Palard:
I have a script that close its socket to /dev/log immediatly before using it,
causing it to fail, here is the code :
{{{
#!/usr/bin/env python
# -*- coding: utf-8 -*-
import logging
import logging.handlers
import daemon
from daemon.pidlockfile import
Julien Palard added the comment:
I understand the files_preserve parameter, the bug I'm filling is the
innability of SysLogHandler to reopen the socket, although it tries :
// DaemonContext closing all FDs:
close(3)= 0
close(2)
Julien Palard added the comment:
Works for me in 2.7.8:
$ python --version
Python 2.7.8
# cat /tmp/test.py
#!/usr/bin/env python
from __future__ import print_function
def toto():
"""
>>> print (42, 43)
42 43
"""
return 42
$ py
New submission from Julien Palard:
Requesting HTTP using `requests`, which uses `http.client` which use `socket`,
sometimes, my program get stuck like this:
```
File "/usr/lib/python3.2/socket.py", line 287 in readinto
File "/usr/lib/python3.2/http/client.py", line 308
Julien Palard added the comment:
I only have a `socket.setdefaulttimeout(10)` just after my imports...
--
___
Python tracker
<http://bugs.python.org/issue24
Changes by Julien Palard :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue24486>
___
___
Python-bugs-list mailing list
Unsubscrib
Julien Palard added the comment:
OK, so, requests have a `timeout` and take it into account, and it solves my
problem.
Yet I don't understand one little thing:
With both requests `timeout` parameter set or unset, the exact same
http.client.py:_read_status call the same socket.readinto.
Julien Palard added the comment:
@Serhiy @haypo: Popular enough or not, it may start as a lib on pypi, we'll see
its usage from here.
--
___
Python tracker
<http://bugs.python.org/is
Julien Palard added the comment:
Hi Elliot, nice spot!
Why are you redefining Py_ABS, which looks already defined in `pymacro.h`
included itself by `Python.h`? I'm not fan of undefining it later, it may
surprise someone later expecting it to be there.
I tried to compile without
Julien Palard added the comment:
Hi, did you forget to attach the patch?
--
nosy: +mdk
___
Python tracker
<http://bugs.python.org/issue28692>
___
___
Python-bug
Julien Palard added the comment:
Hi Stéphane,
Your patch is simple and elegant, but I'm asking myself a question about the
idea to pass a class instead of an instance to the TCPServer ctor (I know
that's not your choice).
If we were able to pass an instance of SimpleHTTPRequ
Julien Palard added the comment:
Hi, thanks for your contribution!
Documentation give examples implementation of your methods:
- https://docs.python.org/3/library/socket.html#socket.socket.sendmsg
- https://docs.python.org/3/library/socket.html#socket.socket.recvmsg
and from here, some
Julien Palard added the comment:
Problems looks from `Modules/_sqlite/statement.c`:
```
if (!_need_adapt(current_param)) {
adapted = current_param;
} else {
adapted = pysqlite_microprotocols_adapt(current_param,
(PyObject*)&pysqlite_PrepareProtocolType, NULL);
if (ada
Julien Palard added the comment:
I missed an occurrence of this "if/else" block, and by changing it, a lot of
tests are failing, typically:
```==
ERROR: CheckBlob (sqlite3.test.types.Sqlit
Julien Palard added the comment:
By moving:
```
/* else set the right exception and return NULL */
PyErr_SetString(pysqlite_ProgrammingError, "can't adapt");
```
from `pysqlite_microprotocols_adapt` to `pysqlite_adapt` (to avoid changing the
semantics from the ou
Julien Palard added the comment:
The inconcistencies were introduced in hg changeset 41703:7993f23ad46c, git
commit:
commit 40ec96630b96f077c8b5746ab0ec038f95aede8b
Author: Walter Dörwald
Date: Sat May 12 11:08:06 2007 +
Change PyUnicode_EncodeUnicodeEscape() to return a bytes
Julien Palard added the comment:
So, lgtm.
--
___
Python tracker
<http://bugs.python.org/issue28750>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Julien Palard:
It looks like the "Converting Your First Function" has been written with
clinic-generated C code interspersed with user C code. But it looks like
nowadays a `clinic/{}.c.h` file is generated, so the "Converting Your First
Function" shoul
Changes by Julien Palard :
--
components: +Argument Clinic
nosy: +larry
versions: +Python 3.6
___
Python tracker
<http://bugs.python.org/issue28753>
___
___
Pytho
Changes by Julien Palard :
--
versions: +Python 3.7
___
Python tracker
<http://bugs.python.org/issue28753>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Julien Palard :
--
assignee: -> docs@python
components: +Documentation
nosy: +docs@python
type: -> enhancement
___
Python tracker
<http://bugs.python.org/i
Changes by Julien Palard :
--
keywords: +patch
Added file: http://bugs.python.org/file45562/issue28754.diff
___
Python tracker
<http://bugs.python.org/issue28
New submission from Julien Palard:
Today I read https://docs.python.org/3.6/howto/clinic.html so I tried one:
bisect.bisect_left.
I was unable to do `bisect_right`, as it's an "alias" for `bisect`, and there's
a unit-test checking `self.assertEqua
Changes by Julien Palard :
Added file: http://bugs.python.org/file45563/issue28754-2.diff
___
Python tracker
<http://bugs.python.org/issue28754>
___
___
Python-bugs-list m
Julien Palard added the comment:
@Larry: As a french-speaking guy, I typically don't write non-internal doc in
english, fearing it sound weird for natives. I prefer translating it back in
french (I'm the current leader of https://github.com/afpy/python_doc_fr)
Here, here
Julien Palard added the comment:
Thanks for proof-reading my english, your editions are really nice: LGTM.
--
___
Python tracker
<http://bugs.python.org/issue28
Julien Palard added the comment:
Should we keep this open for the FASTCALL bit?
--
___
Python tracker
<http://bugs.python.org/issue28753>
___
___
Python-bug
Julien Palard added the comment:
I searched an occurrence of what I'm describing which is already using clinic
and there is, at least, one in Modules/binascii.c line 1090:
TL;DR: The idea is to use the `modulename.fnname [as c_basename] =
modulename.existing_fn_name` clinic syntax, d
Julien Palard added the comment:
Here it is for the whole bisect module.
I separated my work in commits, but I'm not sure how rietveld will eat that as
they'll have unknown references, so I'll probably also upload a single patch
with a
Changes by Julien Palard :
Added file: http://bugs.python.org/file45569/bisect.diff
___
Python tracker
<http://bugs.python.org/issue28754>
___
___
Python-bugs-list mailin
Changes by Julien Palard :
Added file: http://bugs.python.org/file45568/bisect_left.diff
___
Python tracker
<http://bugs.python.org/issue28754>
___
___
Python-bugs-list m
Changes by Julien Palard :
Added file: http://bugs.python.org/file45570/insort.diff
___
Python tracker
<http://bugs.python.org/issue28754>
___
___
Python-bugs-list mailin
Changes by Julien Palard :
Added file: http://bugs.python.org/file45571/insort-left.diff
___
Python tracker
<http://bugs.python.org/issue28754>
___
___
Python-bugs-list m
Changes by Julien Palard :
Added file: http://bugs.python.org/file45572/issue28754-3.diff
___
Python tracker
<http://bugs.python.org/issue28754>
___
___
Python-bugs-list m
Julien Palard added the comment:
The whole diff is reviewable in `issue28754-3.diff`.
--
___
Python tracker
<http://bugs.python.org/issue28754>
___
___
Python-bug
Changes by Julien Palard :
--
keywords: +patch
Added file: http://bugs.python.org/file45573/issue28755.diff
___
Python tracker
<http://bugs.python.org/issue28
New submission from Julien Palard:
I was reading `howto/clinic.html` and though I'll fix syntax highlighting.
--
assignee: docs@python
components: Argument Clinic, Documentation
messages: 281304
nosy: docs@python, larry, mdk
priority: normal
severity: normal
status: open
title: R
Changes by Julien Palard :
Added file: http://bugs.python.org/file45575/issue28755-2.diff
___
Python tracker
<http://bugs.python.org/issue28755>
___
___
Python-bugs-list m
Julien Palard added the comment:
I can't reproduce the issue:
$ ./python
Python 3.6.0b4+ (default, Nov 23 2016, 00:23:59)
[GCC 5.4.1 20160904] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>&
601 - 685 of 685 matches
Mail list logo
