[issue16801] Preserve original representation for integers / floats in docstrings

2012-12-28 Thread Terry J. Reedy
Terry J. Reedy added the comment: If you wish to pursue this, I suggest starting with 'the simplest thing that works' for the text cases at hand. They all involve 'mode' and you have not presented and I cannot think of other cases. So somewhere in the signature generation

[issue16801] Preserve original representation for integers / floats in docstrings

2012-12-29 Thread Terry J. Reedy
Terry J. Reedy added the comment: It seems to me that the real issue is not to preserve the original representation. What if the original author specified mode as 438 or calculated it as 0o600|0o60|0o6 ? He might and we should still like to see it as 0o666. So the real issue is to specify the

[issue994421] logging module prints unexpected message when no handler set

2012-12-29 Thread Terry J. Reedy
Terry J. Reedy added the comment: Update: It appears that in at least 3.2+ (but not 2.7), loggers have a default handler, making the no-handler behavior moot. In any case, the example code prints 'one' and 'two' instead of the message. -

[issue16801] Preserve original representation for integers / floats in docstrings

2013-01-02 Thread Terry J. Reedy
Terry J. Reedy added the comment: A subclass with a custom representation, as I suggested above, is even simpler and involves no change to inspect or docstring conventions. I otherwise agree with closing this. -- ___ Python tracker <h

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

2013-01-04 Thread Terry J. Reedy
Terry J. Reedy added the comment: If this is really an 'enhancement', it will only go in 3.4. If it is a bug/behavior issue, then it should be marked as such and 2.7,3.2,3.3 selected. I have not read the doc and messages well enough to know, so I leave that to you and Benjamin.

[issue16808] inspect.stack() should return list of named tuples

2013-01-04 Thread Terry J. Reedy
Terry J. Reedy added the comment: Should a test be added to or changed in test_inspect? Line 163 has a test_stack method that calls inspect.stack. -- nosy: +terry.reedy ___ Python tracker <http://bugs.python.org/issue16

[issue16823] Python crashes on running tkinter code with threads

2013-01-04 Thread Terry J. Reedy
Terry J. Reedy added the comment: What you are doing appears to be unsupported (invalid). From http://www.astro.washington.edu/users/rowen/TkinterSummary.html "all Tkinter access must be from the main thread (or more precisely, from the thread that calls the mainloop). Violating this is l

[issue16829] IDLE on POSIX can't print filenames with spaces

2013-01-04 Thread Terry J. Reedy
Terry J. Reedy added the comment: Since there is no 'print filename' command on the menu, I am guessing that this is about 'File/Print Window' where the window is an edit window for a file with spaces in the name. In any case, on Win7 3.3 this worked fine for 'tem wi

[issue16855] traceback module leaves off module name in last line of formatted tracebacks

2013-01-04 Thread Terry J. Reedy
Terry J. Reedy added the comment: On Win7, 2.7.3 gives me the same output. (Running in IDLE, I don't get the 'socket.' prefix even on the second traceback.) With 3.3, I get socket.timeout both times (console or IDLE). So the problem seems to be 2.x only. print_exc calls print_e

[issue16862] FAQ has outdated information about Stackless

2013-01-04 Thread Terry J. Reedy
Terry J. Reedy added the comment: I think answer 2 should just say "An alternative is Stackless Python." and let interested people click the link. The entire second sentence should go, and I am not sure how much of the rest of the first is still correct, as Stackless has changed fr

[issue16863] Python 2 error in Argparse tutorial

2013-01-04 Thread Terry J. Reedy
Terry J. Reedy added the comment: A quick patch would be 'This tutorial was written for argparse in Python 3. A few details are different in 2.x.' But feel free to do better. -- nosy: +terry.reedy ___ Python tracker <http://bu

[issue16823] Python crashes on running tkinter code with threads

2013-01-04 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- resolution: invalid -> status: closed -> open ___ Python tracker <http://bugs.python.org/issue16823> ___ ___ Python-bugs-

[issue16855] traceback module leaves off module name in last line of formatted tracebacks

2013-01-05 Thread Terry J. Reedy
Terry J. Reedy added the comment: console = cmd window. I did run it there and that is where I duplicated your 2.7.3 result. I don't understand the different result with 2.7.3 IDLE, since it runs in a separate pythonw process that *should* give the same result as the python cmd window

[issue16748] Make CPython test package discoverable

2013-01-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: test_main makes it trivial to import a test file and run the test. >>> import test/test_xxx as t; t.test_main() I do not know the implications of unittest.main(), but I would dislike losing the abov

[issue16880] Importing "imp" will fail if dynamic loading not supported

2013-01-11 Thread Terry J. Reedy
Terry J. Reedy added the comment: Given the current (3.3) imp.py docstring """This module provides the components needed to build your own __import__ function. Undocumented functions are obsolete. In most cases it is preferred you consider using the importlib module's fun

[issue16886] Doctests in test_dictcomp depend on dict order

2013-01-11 Thread Terry J. Reedy
Terry J. Reedy added the comment: Yes, export patch from 3.2 or 3.3 (which you need to do anyway to upload here), import patch into 2.7. Feel free to ask questions on the Core-mentorship list. The devguide is still a work-in-progress, but has had several recent patches. Great to hear that

[issue16887] IDLE - tabify/untabify applied when clicking Cancel

2013-01-11 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- nosy: +terry.reedy ___ Python tracker <http://bugs.python.org/issue16887> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16899] Add support for C99 complex type (_Complex) as ctypes.c_complex

2013-01-11 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- stage: -> test needed versions: +Python 3.4 ___ Python tracker <http://bugs.python.org/issue16899> ___ ___ Python-bugs-list mai

[issue16901] In http.cookiejar.FileCookieJar() the .load() and .revert() methods don't work

2013-01-11 Thread Terry J. Reedy
Terry J. Reedy added the comment: First, a minor issue about class signatures: doc: FileCookieJar(filename, delayload=None, policy=None) code: def __init__(self, filename=None, delayload=False, policy=None) Pretty clearly, doc should be changed to match code, as later code allow for possibility

[issue16930] mention limitations and/or alternatives to hg graft

2013-01-11 Thread Terry J. Reedy
Terry J. Reedy added the comment: Windows preserves case when writing a filename but ignores it when searching and opening filenames. IE, if I have tem.py and try to save TEM.py (from IDLE), it says 'tem.py exists, overwrite?'. So will or will not that be a problem for graft wi

[issue16933] argparse: remove magic from examples

2013-01-11 Thread Terry J. Reedy
Terry J. Reedy added the comment: The new examples are much better and to me the patch looks ready to apply. -- nosy: +terry.reedy stage: patch review -> commit review ___ Python tracker <http://bugs.python.org/issu

[issue16927] Separate built-in types from functions and group similar functions in functions.rst

2013-01-11 Thread Terry J. Reedy
Terry J. Reedy added the comment: I like this idea, including the function subdivisions. I once suggested moving the classes into the later builtins chapter, but it was pointed out to me that a) they once *were* functions (no longer relevant); b) they are callables (very relevant); and hence

[issue16886] Doctests in test_dictcomp depend on dict order

2013-01-11 Thread Terry J. Reedy
Terry J. Reedy added the comment: The hg workbench gui of tortoisehg, which I use, has make/apply patch selections that get translated to hg commands. So same thing ;-). -- ___ Python tracker <http://bugs.python.org/issue16

[issue16880] Importing "imp" will fail if dynamic loading not supported

2013-01-12 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- Removed message: http://bugs.python.org/msg179807 ___ Python tracker <http://bugs.python.org/issue16880> ___ ___ Python-bugs-list m

[issue16880] Importing "imp" will fail if dynamic loading not supported

2013-01-12 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- Removed message: http://bugs.python.org/msg179806 ___ Python tracker <http://bugs.python.org/issue16880> ___ ___ Python-bugs-list m

[issue16880] Importing "imp" will fail if dynamic loading not supported

2013-01-12 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- nosy: -Nurhusien2 ___ Python tracker <http://bugs.python.org/issue16880> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16880] Importing "imp" will fail if dynamic loading not supported

2013-01-12 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- Removed message: http://bugs.python.org/msg179810 ___ Python tracker <http://bugs.python.org/issue16880> ___ ___ Python-bugs-list m

[issue16880] Importing "imp" will fail if dynamic loading not supported

2013-01-12 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- Removed message: http://bugs.python.org/msg179814 ___ Python tracker <http://bugs.python.org/issue16880> ___ ___ Python-bugs-list m

[issue16880] Importing "imp" will fail if dynamic loading not supported

2013-01-12 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- Removed message: http://bugs.python.org/msg179816 ___ Python tracker <http://bugs.python.org/issue16880> ___ ___ Python-bugs-list m

[issue16829] IDLE on POSIX can't print filenames with spaces

2013-01-12 Thread Terry J. Reedy
Terry J. Reedy added the comment: Given the system-dependent nature of the problem, starting with the simplest thing that really ought to work seems reasonable to me. I verified that the 3.3 patch has no effect on Windows. IE, files with and without spaces printed without .py in the printed

[issue1683368] object.__init__ shouldn't allow args/kwds

2013-01-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: First, What's New " explains the new features in Python". This issue is a bugfix. AFAIK, object() has always been documented as having no parameters. The fact that passing extra args should raise a TypeError is no secret. Second, this *is*

[issue16823] Python quits on running tkinter code with threads

2013-01-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: We use 'crash' to mean a segfault (and core dump, on *nix) or the Windows equivalent. We avoid those if at all possible. A Python traceback is not a crash but a semi-graceful shutdown that has be planned for, given the circumstances. What is annoyi

[issue16468] argparse only supports iterable choices

2013-01-15 Thread Terry J. Reedy
Terry J. Reedy added the comment: The exception question is messy, but I think it is the wrong question. The doc is correct in that it says what the code should be doing. To test whether an argument is in a collection of choices, the code should just say that: 'arg in choices' (a

[issue16468] argparse only supports iterable choices

2013-01-15 Thread Terry J. Reedy
Terry J. Reedy added the comment: I took a good look at the 3.3 code. With respect to the main purpose of choices -- checking user input -- argparse does not require that choices be iterable, as it *does* use 'in', as it should. Line 2274: if action.choices is not None and

[issue16468] argparse only supports iterable choices

2013-01-15 Thread Terry J. Reedy
Terry J. Reedy added the comment: _Actions_container(object) [1198 in 3.3.0 code] .add_argument() [1281] does not directly check for choices.__iter__ ('__iter__' is not in the file). Nor does it use the 3.x-only alternative isinstance(choices, collections) ('Iterable' is

[issue14576] IDLE: closes when writing warnings on Windows

2013-01-17 Thread Terry J. Reedy
Terry J. Reedy added the comment: >I think the next interesting question is to find out why an invalid home >directory causes idle to not start up. There's no obvious reason why that >should be the case in principle, As Roger showed, IDLE will start up with an invalid home dire

[issue16468] argparse only supports iterable choices

2013-01-18 Thread Terry J. Reedy
Terry J. Reedy added the comment: If you can somewhat solve the problem by better using the existing api, good. I am not 'stuck' on reusing str/repr*. If metavar is non-optional for non-iterable choices, the doc should say so in the entry for choices. (Does the test suite alre

[issue3982] support .format for bytes

2013-01-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: >it would probably be reasonable to make these protocols use str objects at the >heart, and only convert to bytes after the formatting is done. I presume this would mean adding 'if py3: out = out.encode()' after the formatting. As I said be

[issue3982] support .format for bytes

2013-01-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: After re-reading everything, I have somewhat changed my mind on this proposal. Perhaps 3.0 threw out too much, making it overly difficult to do some things that were to easy in 2.x and to write cross-version code. String formatting converts all arguments to

[issue13896] Make shelf instances work with 'with' as context managers

2013-01-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: The patch did not update the doc. See #17040, with proposed patch. -- ___ Python tracker <http://bugs.python.org/issue13

[issue16468] argparse only supports iterable choices

2013-01-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: I think we have converged on the right solution. The patch looks good as far as it goes, assuming that it passes the current + unwritten new tests. It will also be a good basis for reconsidering what to do with long/infinite iterables in #16418. I think the

[issue17005] Add a topological sort algorithm

2013-01-26 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- nosy: +terry.reedy ___ Python tracker <http://bugs.python.org/issue17005> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2013-01-27 Thread Terry J. Reedy
Terry J. Reedy added the comment: > As Richard explained, this will not break working code, this will break only > broken code If code is both working and broken, for some reasonable meaning of 'working' and 'broken', breaking such broken code *will* break working c

[issue13997] Clearly explain the bare minimum Python 3 users should know about Unicode

2013-01-27 Thread Terry J. Reedy
Terry J. Reedy added the comment: I basically agree with Ezio. The doc currently starts with Introduction to Unicode History of Character Codes ... It ends with Tips for Writing Unicode-aware Programs. ... The most important tip is: Software should only work with Unicode strings

[issue16743] mmap on Windows can mishandle files larger than sys.maxsize

2013-01-27 Thread Terry J. Reedy
Terry J. Reedy added the comment: I missed the Ngb+1 case in your previous answer and agree that this is a bug issue. -- ___ Python tracker <http://bugs.python.org/issue16

[issue17047] Fix double double words words

2013-02-02 Thread Terry J. Reedy
Terry J. Reedy added the comment: These are correct as they are: Lib/tkinter/tix.py:149:"""Locates a bitmap file of the name name.xpm or name in one of the Lib/tkinter/tix.py:160:"""Locates an image file of the name name.xpm, name.xbm or nam

[issue12568] Add functions to get the width in columns of a character

2013-02-02 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- stage: -> patch review type: -> enhancement ___ Python tracker <http://bugs.python.org/issue12568> ___ ___ Python-bugs-list

[issue12568] Add functions to get the width in columns of a character

2013-02-02 Thread Terry J. Reedy
Terry J. Reedy added the comment: In this part of width.py, w = unicodedata.east_asian_width(c) if c == 'A': # ambiguous raise ValueError("ambiguous character %x" % (ord(c))) I presume that 'c' should be '

[issue17048] calendar should understand full- vs. half-width characters

2013-02-02 Thread Terry J. Reedy
Terry J. Reedy added the comment: For this particular East Asian local, the problem is the double spacing between the double-width characters (the Chinese numbers 1 to 7). This is potentially easily fixed for this locale. But do all locales have abbreviated weekday names that fit in 2 columns

[issue17060] IDLE -- jump to home should not go past the PS1 and PS2 prompts

2013-02-02 Thread Terry J. Reedy
Terry J. Reedy added the comment: On my Win 7 system, with 3.3.0, the first Home sends the cursor to the beginning of the user entry, after '>>> '. The second sends it to the beginning of the display line. And so forth, as intended. See #3851. (It worked the same with Win

[issue17061] tokenize unconditionally emits NL after comment lines & blank lines

2013-02-02 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- nosy: +meador.inge ___ Python tracker <http://bugs.python.org/issue17061> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17068] peephole optimization for constant strings

2013-02-02 Thread Terry J. Reedy
Terry J. Reedy added the comment: It would also be nice to optimize '{}{}{}'.format('https://', host, uri). Either seems a bit much to ask from a fairly naive compiler :-). -- nosy: +terry.reedy stage: -> needs patch versions: +Python 3.4 ___

[issue16686] audioop overflow issues

2013-02-02 Thread Terry J. Reedy
Terry J. Reedy added the comment: I do not have the knowledge needed to review the code, but I took a brief look. The three doc patches need a verb to be proper English. "Samples truncated in case of overflow." should be "Samples are truncated in case of overflow." in

[issue7083] locals() behaviour differs when tracing is in effect

2013-02-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: Anatoly, please stop playing with the headers. It is meaningless and irritating, especially when you set them wrong. The 3.5 choice is for issues that will *not* apply before then. An example is actually making a change warned about in a deprecation warning

[issue10365] IDLE Crashes on File Open Dialog when code window closed before other file opened

2013-02-04 Thread Terry J. Reedy
Terry J. Reedy added the comment: It seems like a logic error to try to remove something that is not there. But it is not obvious from the traceback that your problem has anything to do with *opening* a file. Unbinding should only happen when *closing* a file. So I suspect this is a different

[issue17047] Fix double double words words

2013-02-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: Lib/tkinter/tix.py:1920 Val may be: "auto" -- the width of the column is set the the widest cell in the column; a valid Tk screen distance I believe 'the the' should be 'to the width of the' Lib/tkinter/tix.py:1944 Val may b

[issue17047] Fix double double words words

2013-02-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: I am working on patch(es) now, against 3.2. But to make 2.7.4/3.2.4, I'd like you to apply, as I am not currently set up to do so properly. I may do separate patches for doc, lib, module, and others, so none is overwhe

[issue17047] Fix double double words words

2013-02-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: First batch for Lib/*. Separate 3.2 and 2.7 files as the later required deletion of concurrent patch and adjustment of tix and turtle paths. -- keywords: +patch Added file: http://bugs.python.org/file28994/Lib14707-27.diff

[issue17047] Fix double double words words

2013-02-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: These of course do not contain patches for new dups introduced in 3.3. I kept a record and will later make a separate patch for those. (I hope before 3.3.1). -- Added file: http://bugs.python.org/file28995/Lib14707-32.diff

[issue17047] Fix double double words words

2013-02-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: C module files. I cannot find python-gdb.py. -- Added file: http://bugs.python.org/file28996/Mod14707-27.diff ___ Python tracker <http://bugs.python.org/issue17

[issue17047] Fix double double words words

2013-02-07 Thread Terry J. Reedy
Changes by Terry J. Reedy : Added file: http://bugs.python.org/file28997/Mod14707-32.diff ___ Python tracker <http://bugs.python.org/issue17047> ___ ___ Python-bugs-list m

[issue17047] Fix double double words words

2013-02-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: A majority of doc glitches listed here are new in 3.3. I believe someone make a similar de-double patch some time ago. I put the other 2.7/3.2 fixes here so this is it for those two versions. -- Added file: http://bugs.python.org/file28998/Doc17047-27

[issue17047] Fix double double words words

2013-02-07 Thread Terry J. Reedy
Changes by Terry J. Reedy : Added file: http://bugs.python.org/file28999/Doc17047-32.diff ___ Python tracker <http://bugs.python.org/issue17047> ___ ___ Python-bugs-list m

[issue17047] Fix double double words words

2013-02-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: This is for 3.3 and 3.4. It is against tip, but should apply to 3.3 since the lines changed were as reported here for 3.3. -- Added file: http://bugs.python.org/file29000/Issue17047-34.diff ___ Python tracker <h

[issue17159] Remove explicit type check from inspect.Signature.from_function()

2013-02-08 Thread Terry J. Reedy
Terry J. Reedy added the comment: My first concern is whether this is a behavior issue that can be fixed in the next 3.3 release or an enhancement request that should wait for 3.4. If Signature.from_function were documented in the manual with the current limitation, this issue would

[issue17108] import silently prefers package over module when both available

2013-02-08 Thread Terry J. Reedy
Terry J. Reedy added the comment: I looked through both the old 2.7 import statement doc and the new 3.3 import statement doc and import system chapter (5. The import system) and could not find anything about what a Path Based Finder path entry finder does when a particular path entry has

[issue17152] Array module should support "boolean" natively

2013-02-08 Thread Terry J. Reedy
Terry J. Reedy added the comment: You are proposing a bit array. Whether the bits are interpreted or displayed as 0/1 or f/t or False/True is secondary. The problem is that bit arrays do not fit the array model, with its minimum byte size per element of 1. There are other aspects of arrays

[issue17157] issubclass() should accept iterables in 2nd arg

2013-02-08 Thread Terry J. Reedy
Terry J. Reedy added the comment: Given isxxx(src, target_s), the proposal would seem to be to change the internal test "type(target_s) is tuple" to "hasattr(type(target_s), '__iter__'). This depends on metaclasses not having .__iter__ methods, just as type does no

[issue17158] help() module searcher text is misleading

2013-02-08 Thread Terry J. Reedy
Terry J. Reedy added the comment: You are asking that help("modules spam") act more like help("modules"), which sensibly prints "Enter ..." after the list. A minor but reasonable request, but since the current behavior is not a bug and some code might possible dep

[issue17159] Remove explicit type check from inspect.Signature.from_function()

2013-02-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: I am puzzled by this part of the patch: - with self.assertRaisesRegex(TypeError, 'is not a callable object'): + with self.assertRaisesRegex(TypeError, '42.*is not a callable object'): With 3.3, I get "TypeError: 42 is not a callable

[issue17158] help() module searcher text improvement

2013-02-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: Looking further at the pydoc code, I see that "Here is a list. Enter any listed item to get more help", with both sentences printed before the list, is normal. Having a post-list prompt for the list of all modules is the exception. So I would no l

[issue17158] help() module searcher text improvement

2013-02-10 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- assignee: -> terry.reedy ___ Python tracker <http://bugs.python.org/issue17158> ___ ___ Python-bugs-list mailing list Unsubscri

[issue17170] string method lookup is too slow

2013-02-11 Thread Terry J. Reedy
Terry J. Reedy added the comment: A related issue: the speed of finding and hence replacing chars in strings is known to have regressed in 3.3 relative to 3.2, especially on Windows. For long strings, that will negate in 3.3 the speedup for the initial method call. See #16061, with patches

[issue17188] Document 'from None' in raise statement doc.

2013-02-11 Thread Terry J. Reedy
New submission from Terry J. Reedy: Language manual, section 7.8. The raise statement has no mention of the 'from None' option. Indeed it says "if given, the second expression must be another exception class or instance", which would exclude None. Library manual, Ch 5.

[issue17159] Remove explicit type check from inspect.Signature.from_function()

2013-02-11 Thread Terry J. Reedy
Terry J. Reedy added the comment: I opened separate issue #17188: Document 'from None' in raise statement doc. -- ___ Python tracker <http://bugs.python.o

[issue18960] First line can be executed twice

2013-09-13 Thread Terry J. Reedy
Terry J. Reedy added the comment: I thought that that was the specification*: the encoding comment should be the first line unless it has to be the second line to allow for an executable comment. Executing a non-comment first line twice is definitely contrary to the intent of the PEP. * I

[issue18951] In unittest.TestCase.assertRegex change "re" and "regex" to "r"

2013-09-13 Thread Terry J. Reedy
Terry J. Reedy added the comment: [The information in titles, especially long titles that do not fit in the title box (on my system, at least) should be repeated in the opening message.] The point of the patch is to use the same name for the same object in the two columns* and to use a single

[issue18961] Non-UTF8 encoding line

2013-09-13 Thread Terry J. Reedy
Terry J. Reedy added the comment: Which behavior do you propose to change? Does PEP263 specify the response to a self-contradictory encoding comment? What do you think it should say? I raising is the better behavior. Idle notices that it cannot save the file with iso8859-15 encoding, so it

[issue18965] 2to3 can produce illegal bytes literals

2013-09-13 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- nosy: +benjamin.peterson ___ Python tracker <http://bugs.python.org/issue18965> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18968] Find a way to detect incorrectly skipped tests

2013-09-13 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- nosy: +terry.reedy ___ Python tracker <http://bugs.python.org/issue18968> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18968] Find a way to detect incorrectly skipped tests

2013-09-13 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- components: +Tests ___ Python tracker <http://bugs.python.org/issue18968> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18974] Use argparse in the diff script

2013-09-13 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- nosy: +terry.reedy ___ Python tracker <http://bugs.python.org/issue18974> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19006] UnitTest docs should have a single list of assertions

2013-09-13 Thread Terry J. Reedy
Terry J. Reedy added the comment: I like the current division, but agree that The TestCase class provides a number of methods to check for and report failures, such as: is slightly misleading. I would change it to The TestCase class provides a number of methods to check for and report

[issue19020] Regression: Windows-tkinter-idle, unicode, and 0xxx filename

2013-09-14 Thread Terry J. Reedy
New submission from Terry J. Reedy: Current 3.3.2+ repository build (32 bit) and 3.4.0a2 repository build (32 bit) and installation (64 bit) have a problem that did not exist in my Win6 3.3.2 installation (64 bit). (Bruce Sherwood discovered the symption with some installed version of 3.4.0a

[issue6699] IDLE: Warn user about overwriting a file that has a newer version on filesystem

2013-09-14 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- nosy: +bsherwood ___ Python tracker <http://bugs.python.org/issue6699> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16650] Popen._internal_poll() references errno.ECHILD outside of the local scope

2013-09-14 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- versions: -Python 3.2 ___ Python tracker <http://bugs.python.org/issue16650> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16650] Popen._internal_poll() references errno.ECHILD outside of the local scope

2013-09-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: sorry for noise -- nosy: +terry.reedy versions: +Python 3.2 ___ Python tracker <http://bugs.python.org/issue16650> ___ ___ Pytho

[issue12085] subprocess.Popen.__del__ raises AttributeError if __init__ was called with an invalid argument list

2013-09-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: I think this patch is a false solution and should be reverted. Oleg should have been told to use sys.version to make the correct call. Given how Python is, that is the correct solution to his problem. The result of this patch is #19021: an AttributeError on

[issue12085] subprocess.Popen.__del__ raises AttributeError if __init__ was called with an invalid argument list

2013-09-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: The same issue arises when an exception is raised during the __init__ execution, rather than in the call argument match phase, and the exception is caught. class C(): def __init__(self): self.a = self.b def __del__(self): self.a try: C() except

[issue19021] AttributeError in Popen.__del__

2013-09-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: The condition was changed from self._child_created to the getattr call in #12085. As explained in msg197748, I think that change should be reverted (and this issue closed). I think elaborating a bad patch only makes it worse

[issue1602] windows console doesn't print or input Unicode

2013-09-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: >From reading the module, import stream; stream.enable() replaces sys.stdin/out/err with new classes. -- ___ Python tracker <http://bugs.python.org/iss

[issue12558] Locale-dependent exception for float width argument to Tkinter widget constructor

2013-09-15 Thread Terry J. Reedy
Terry J. Reedy added the comment: Perhaps we can fix it on the Python side. When self.tk is called with a configuration cnf, cnf is often (always?) first passed to Misc._options, as in BaseWidget.__init__: self.tk.call( (widgetName, self._w) + extra + self._options(cnf

[issue19029] tix.py uses StringType

2013-09-15 Thread Terry J. Reedy
Terry J. Reedy added the comment: I am slightly surprised no one has complained about a NameError. I guess tix is untested and not used too much, or at least not the two methods, tixCommand.tix_configure and TixWidget.config_all. Anyway, do it

[issue18873] "Encoding" detected in non-comment lines

2013-09-16 Thread Terry J. Reedy
Terry J. Reedy added the comment: One of the problem with encoding recognition is that the same logic is more-or-less reproduced multiple places, so any fix needs to be applied multiple places. From the detect_encoding_in_comments_only.patch: Lib/idlelib/IOBinding.py Lib/lib2to3/pgen2

[issue19042] Idle: add option to autosave 'Untitled' edit window

2013-09-17 Thread Terry J. Reedy
New submission from Terry J. Reedy: The General tab of the IDLE Preferences dialog has this section with two radiobuttons: Autosave Preferences At Start of Run (F5) () Prompt to Save () No Prompt The latter option actually means "No prompt unless the window is a new window (

[issue14983] email.generator should always add newlines after closing boundaries

2013-09-21 Thread Stephen J. Turnbull
Stephen J. Turnbull added the comment: Seems this hasn't been resolved. I have to disagree with David's interpretation of RFC 2046. The definition of a boundary says that it is "terminated" with a CRLF. It also clarifies that the introducing CRLF is "conceptua

[issue14983] email.generator should always add newlines after closing boundaries

2013-09-21 Thread Stephen J. Turnbull
Stephen J. Turnbull added the comment: Following OpenPGP convention is clearly optional (or maybe a SHOULD, but the word "elect" makes it a pretty weak SHOULD). RFC 2046 is a MUST, it's not a matter of "convention". The problem is that a parser that works forward in

[issue12085] subprocess.Popen.__del__ raises AttributeError if __init__ was called with an invalid argument list

2013-09-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: A class attribute is still a special case fix to a generic problem, if indeed the message is a problem. If class attribute backup is to become a requirement of all delete methods, it needs to first be documented, after pydev discussion. To apply the class

[issue12085] subprocess.Popen.__del__ raises AttributeError if __init__ was called with an invalid argument list

2013-09-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: The message problem can arise during exit if __del__ depends an any attribute of any object. It is hard to imagine a __del__ method that does not. Any __del__ method, including that of Popen, could handle AttributeErrors by wrapping the whole body in try

[issue12085] subprocess.Popen.__del__ raises AttributeError if __init__ was called with an invalid argument list

2013-09-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: Reading Antoine's message more carefully, and the cited doc line, the generic fix to prevent the warning would be try: <__del__ body> except Exception: pass The question is, do we only want to block the warning when someone calls Popen wit

<    87   88   89   90   91   92   93   94   95   96   >