Terry J. Reedy added the comment:
Summary of this post: compile currently checks user input with assert; this is
a bug that should be changed.
I re-read astlinenotest.py and realized that FunctionDef is included in '*' and
not some omitted import. (The latter is common for code
Terry J. Reedy added the comment:
The reverenced post did not give a runnable minimal example with the claimed
bug, but only described more complex code at a now dead link. The following
from http://effbot.org/tkinterbook/entry.htm works on my Win7 machine.
import tkinter as tk
master = tk.Tk
Terry J. Reedy added the comment:
Sounds like a good idea to me. The code looks pretty straightforward as far as
I understood it.
--
___
Python tracker
<http://bugs.python.org/issue21
Terry J. Reedy added the comment:
Reading the Tk Wiki page, it appears that Shift undoes ShiftLock except on Mac,
where it does nothing. So there is effectively only ^a and ^A, etc.
Looking as the Get New Keys dialog, the Basic Key Binding Entry pane says "New
keys .." plural, but a
Terry J. Reedy added the comment:
> Now the binding will be assigned to two actions.
I do not see this. I only see duplicated, which is bad enough
to be patched. What did you leave out ;-).
Also see #12387, which we need to finish, and Ned's link to
http://wiki.tcl.tk/28331
A p
Terry J. Reedy added the comment:
#17853 was in the context of metaclasses. Even so, I am puzzled by the opening
statement there that
from enum import Enum # I added this as necessary
class Season(Enum):
SPRING = Season()
"works beautifully" at top level as it indeed raises
Changes by Terry J. Reedy :
--
versions: +Python 3.5 -Python 3.4
___
Python tracker
<http://bugs.python.org/issue14776>
___
___
Python-bugs-list mailing list
Unsub
Terry J. Reedy added the comment:
Trip, see msg140290, which was ignored.
--
___
Python tracker
<http://bugs.python.org/issue2506>
___
___
Python-bugs-list mailin
New submission from Terry J. Reedy:
The Tutorial section More on Lists
https://docs.python.org/3.4/tutorial/datastructures.html#more-on-lists includes
list.pop but ignores it in the example and final comment. I think the examples
should be augmented and the comment modified.
1. (simplest) End
Terry J. Reedy added the comment:
Thanks David. If this is not to be your last contribution, and we hope not,
please fill out the contributor agreement, if you have hot already, at
https://www.python.org/psf/contrib/contrib-form/
--
resolution: -> fixed
stage: needs patch -> re
Terry J. Reedy added the comment:
Deleting the function and calls to it would be easy. But my memory, which could
be off, is that I left fixwordbreaks(root) in the test function now called
_editor_window (at the end of the file) because the test did not work right
without it. I willhave to
Changes by Terry J. Reedy :
--
nosy: +jesstess
___
Python tracker
<http://bugs.python.org/issue21477>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
I wonder if we should consider extracting the body of
if isinstance(source, types.UnicodeType):
as a function, call it ufix_latin1; add one or more alterntives, ufix_utf8,
ufix_locale, ufix_irdb(?); keep ufix_latin1 as default; but switch to an
Changes by Terry J. Reedy :
--
assignee: docs@python -> terry.reedy
nosy: +terry.reedy
stage: -> commit review
versions: +Python 2.7, Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.org/i
Changes by Terry J. Reedy :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> `int()`, `float()`, etc think python strings are null-terminated
type: -> behavior
___
Python tracker
<http
Terry J. Reedy added the comment:
Replacing 2061 with the following should work for all versions.
desc = module.__doc__.splitlines()[0] if module.__doc__ else ''
--
nosy: +terry.reedy
type: -> behavior
versions: +Python 2.7, Python 3.5
_
Changes by Terry J. Reedy :
--
nosy: +terry.reedy
___
Python tracker
<http://bugs.python.org/issue21558>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
In 2.7, it was only *long integers* that could not overflow. In both python 2
and 3, the comment only applys to operations on integers and not to integers
converted to floats. Perhaps that could be clarified. If have any example from
running Python where
Terry J. Reedy added the comment:
My thoughts on this. Overall, +.something (and increasing as I look at it more
;-).
I am opposed to adding this to the relatively long file menu. It has nothing to
do with manipulating or editing files. If it is to go in, please put it on the
help menu, at
Terry J. Reedy added the comment:
run-runall.diff import cleanly to 3.4. Running all the tests works well enough
that I am applying this, with minor changes, to be a base for further patches.
Good job.
The few problems I fixed:
1. AutoCompleteWindow.py had \n added at the beginning. I just
Terry J. Reedy added the comment:
Since I wanted to get this large patch applied as a basis for further work, I
went ahead with the 2.7 backport. I am listing the issues in converting
run-runall-34.diff to run-runall-27.diff to help Saimadhav do this in the
future.
1. /tkinter/Tkinter/ 7
Terry J. Reedy added the comment:
I just discovered today that Rietveld can do diffs between diffs, so to speak.
For example,
http://bugs.python.org/review/21477/diff2/11941:11942/Lib/idlelib/idle_test/htest.py
showed the changes between patched htest in 3.4 and 2.7
Terry J. Reedy added the comment:
Thanks for the followup. This should be useful info for anyone who finds this
issue.
--
___
Python tracker
<http://bugs.python.org/issue12
Terry J. Reedy added the comment:
0. I pushed a slight revision of the patch. See 2) for the main change. In
htest, I also did 3), corrected some line spacing issues, and changed
'focussing' to the US spelling 'focusing'. A tested 2.7 version of the
attached, htest-25
Terry J. Reedy added the comment:
Yes, remove unscrollable (test2) tree widget (review response).
--
___
Python tracker
<http://bugs.python.org/issue21
Terry J. Reedy added the comment:
I plan to add more.
--
___
Python tracker
<http://bugs.python.org/issue21054>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
This is documentation for the 2.7 '-3' command line option, which I presume has
not changed at least since 2.7.0, rather than for 2to3, which has changed in
different 3.x releases. If I am correct, the list of things -3 warns about has
not changed
New submission from Terry J. Reedy:
#17390 changes the title bars for (so far), shell and editor windows. While the
editor window change helps me (for reasons given on the issue) and got no
objection, before being pushed, from people nosy on the issue, others have
found it objectionable in
Terry J. Reedy added the comment:
Another possibility is to separate the calculation of the title from setting
it. This would make it much easier to unittest the calculation of the title.
--
___
Python tracker
<http://bugs.python.org/issue21
Terry J. Reedy added the comment:
Since no title format can satisfy everyone, I propose to make it user
configurable. The default can be the old style. I opened #21588 for that and
marked it high priority.
--
priority: high -> normal
versions: +Python 3.5 -Python
Terry J. Reedy added the comment:
My understanding is that when a builtin is converted, a) the docstring
signature disappears, and b) getfullargspec calls str(signature). I need to
check what now happens with .getfullargspec version .signature for uncoverted
builtins and if any changes should
Terry J. Reedy added the comment:
As I said previously, the only reason for the change was get all the docstring
signature lines for builtins, after they were changed from 1 to many. I was not
thrilled with having to do this. However, I felt that just presenting the
arbitrary first of many
Terry J. Reedy added the comment:
I think it time to make running through all or just some of the tests more
pleasant. If we reversed the order [next], [test name], test instruction, then
[next] would not just up and down. If the window were set to a constant width,
then it would not jump
Terry J. Reedy added the comment:
Ned, I recently saw that some of the builtin extensions call macosxsupport. I
though then that it would be better if such calls were somehow handled
automatically. I have no idea how and when to make them and so I don't know if
the existing calls are n
Changes by Terry J. Reedy :
--
nosy: +terry.reedy
___
Python tracker
<http://bugs.python.org/issue18132>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
I think a patch should reuse the run module function that Idle already has. No
need to re-invent something. I will say more tomorrow after sleeping.
--
___
Python tracker
<http://bugs.python.org/issue17
Changes by Terry J. Reedy :
--
Removed message: http://bugs.python.org/msg219255
___
Python tracker
<http://bugs.python.org/issue1683368>
___
___
Python-bug
Terry J. Reedy added the comment:
>From what I see, you do not need to change either __new__ or __init__, just
>add __enter__ and __exit__ , and you only need to do that in 2.6. Since
>Zipfile is written in Python, you could monkey-patch instead of subclassing,
>if that is ea
Terry J. Reedy added the comment:
My worry about the patch is that is is a bandage covering up a problem
elsewhere.
1. You indicate that you only have a problem with your custom build, but not on
a standard build. This seems odd. Perhaps the problem is with your build.
2. turtledemo.__main__
Terry J. Reedy added the comment:
On my widescreen, the buttons are completely gone when I shrink vertically to
about 720 pixels. So they must be gone on a 600x800 screen or 720x1280 small
widescreen and perhaps on a non-fullscreen window on a 780x10xx screen. I agree
with fixing this if
New submission from Terry J. Reedy:
Turtledemo (python -m turtledemo) has a text pane for code and a canvas pane
for the actual demo. The code pane is fixed at about 60% of the width needed to
display full-width code lines. If the window is expanded horizontally, all the
expansion goes to the
Terry J. Reedy added the comment:
0. My general interest is in running external programs and in particular, for
this issue, python modules intended to be run as main. Some other scripts I
would like to be able to easily launch from Idle include
List/test.test_idle.py, Tools/Scripts
Changes by Terry J. Reedy :
--
versions: +Python 3.5 -Python 3.3
___
Python tracker
<http://bugs.python.org/issue18141>
___
___
Python-bugs-list mailing list
Unsub
Terry J. Reedy added the comment:
I withdraw my suggestion that turtledemo get anything added just for moving
code to Idle. What is does need is the ability to widen the code pane so one
can more easily read or cut (by normal means). See #21597.
One of my concerns about putting turtledemo on
Terry J. Reedy added the comment:
Ned, this patch includes a call to macosxSupport.
_initializeTkVariantTests(root) in htest.run. Does this work on mac or is
something else needed (like doing the same for individual tests that create
another root
Terry J. Reedy added the comment:
Devise a simple test (fail before, work after) that does not require enum34. If
this fix is committed, the message could note that the same issue was fixed
differently in 3.4 mixed in with other changes.
--
nosy: +terry.reedy
stage: -> test nee
Changes by Terry J. Reedy :
--
nosy: +ncoghlan
___
Python tracker
<http://bugs.python.org/issue21568>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
Did you intend to upload a diff with the current changes?
My answers:
* Just describe 466. Don't invite trouble.
* Move the section to its logical place in temporal order, with a clear link.
--
nosy: +terry.
Terry J. Reedy added the comment:
I am glad to see this. Gregor has been inactive for several years, Except for
Ned's recent patch for OSX, it has been years since there was a turtle-specific
code patch (from hg revision history).
Questions: is there project link? are any of the mentors
Terry J. Reedy added the comment:
Your example in #21578 suggests that **kwargs should be deleted.
*args is right.
>>> ImportError(3, 'a')
ImportError(3, 'a')
Should not this be fixed by ArgClinic conversion, and is not there an issue for
that for exceptions?
Terry J. Reedy added the comment:
Since asyncore is depracated, I don't know if tests are being updated, or if
this should be closed.
--
nosy: +josiahcarlson, stutzbach, terry.reedy
title: use support.catpured context managers - test_asyncore -> use
support.captured_stdx
Changes by Terry J. Reedy :
--
nosy: +vinay.sajip
stage: -> patch review
title: use support.catpured_stderr context manager - test_logging -> use
support.captured_stderr context manager - test_logging
type: -> enhancement
___
Python track
Terry J. Reedy added the comment:
The exception appears to be intentional, though I do not know what a
'qualified' exec would be. But since the tuple form is intended to mimic 3.x
exec, and since a reduced version of your example
c = '''
def g():
def f():
Terry J. Reedy added the comment:
To accept contributions, we need a signed (possibly electronically)
contribution form.
https://www.python.org/psf/contrib/contrib-form/
--
nosy: +terry.reedy
___
Python tracker
<http://bugs.python.org/issue21
Terry J. Reedy added the comment:
Since I am 99.999% sure that first is intended, I will change 'a location' to
'the first location'.
--
assignee: docs@python -> terry.reedy
nosy: +terry.reedy
stage: -> needs patch
type: -> enhancement
versions: -Pytho
Terry J. Reedy added the comment:
On Win 7, I also see x.py in the save dialog, both 2.7 and 3.4 as installed.
--
nosy: +terry.reedy
___
Python tracker
<http://bugs.python.org/issue21
Changes by Terry J. Reedy :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Terry J. Reedy added the comment:
When I re-read the top of the file, I remembered that turtle.py has unique
issues in relation to code ownership. (I was once told that Gregor had to
approve any substantive code change.) I asked about that and about code
cleanups on pydev (thread 'upd
New submission from Terry J. Reedy:
In #21569, revising What's New for 2.7, Nick is planning to add the following:
+PEP 434: IDLE Enhancement Exception for All Branches
+
+
+:pep:`434` describes a general exemption for changes made to the
Terry J. Reedy added the comment:
I think the Idle section is such a great idea I propose to add something
similar to future What's New for 3.x. See #21621.
--
___
Python tracker
<http://bugs.python.org/is
Terry J. Reedy added the comment:
I like the proposal and would like to see it happen. My concern is to avoid
having interns write patches that get rejected for non-technical reasons. I
won't make any specific suggestions until I get more information either from
the pydev thread
New submission from Terry J. Reedy:
#21477 was about finishing the htest framework and creating at least a first
draft of each human test. This issue is about refining individual tests. One
remaining issue is placement of the master window and placement of test windows
in relation to the
Terry J. Reedy added the comment:
I regard the goal of this issue as having been accomplished. I opened #21624
for any further work on htests.
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
superseder: -> Idle: p
Terry J. Reedy added the comment:
I re-read turtledemo and it seems that is could exit without calling
root.destroy. The 'if main' block follows:
demo = DemoWindow()
RUN = True
while RUN:
try:
#print("ENTERING mainloop")
Terry J. Reedy added the comment:
I believe I have read more than one warning to not mix grid and pack in the
same master, as your patch does. For example:
http://effbot.org/tkinterbook/grid.htm, An option would be to grid everything.
I believe grid would also fix issue #21597, so I may try
New submission from Terry J. Reedy:
Spinoff of #7136: In pushing the patch for that issue, I discovered that
formatting changes for help.txt (and maybe /Doc/library/idle.rst) had been
applied unevenly. See msg192141, which suggests this issue. 3.3 versus 3.4
differences are moot, so this now
Terry J. Reedy added the comment:
Zach, do you have any further thoughts in light of patches pushed since?
What do you think is the exact remaining issue?
--
assignee: terry.reedy ->
___
Python tracker
<http://bugs.python.org/issu
Terry J. Reedy added the comment:
Please redo 3.3 patch for current 3.4 (after htest change).
--
title: Adds idle test for configHelpSourceEdit -> Idle: test
configHelpSourceEdit
versions: +Python 3.5 -Python 3.3
___
Python tracker
&l
Terry J. Reedy added the comment:
#18592 has a patch for SearchDialogBase.
--
title: IDLE Improvements: Unit test for SearchDialog.py -> Idle: test
SearchDialog.py
versions: +Python 3.5 -Python 3.3
___
Python tracker
<http://bugs.pyth
Terry J. Reedy added the comment:
Probably still need to add note to idle_test/README.txt.
--
stage: commit review -> needs patch
versions: +Python 3.5 -Python 3.3
___
Python tracker
<http://bugs.python.org/issu
Changes by Terry J. Reedy :
--
versions: +Python 3.5 -Python 3.3
___
Python tracker
<http://bugs.python.org/issue20800>
___
___
Python-bugs-list mailing list
Unsub
Changes by Terry J. Reedy :
--
stage: needs patch -> patch review
title: IDLE Improvements: Unit test for AutoComplete.py -> Idle: test
AutoComplete.py
versions: +Python 3.5 -Python 3.3
___
Python tracker
<http://bugs.python.org/i
Changes by Terry J. Reedy :
--
title: IDLE: Unit test for SearchDialogBase.py -> Idle: test
SearchDialogBase.py
versions: +Python 3.5 -Python 3.3
___
Python tracker
<http://bugs.python.org/issu
Changes by Terry J. Reedy :
--
stage: -> patch review
title: IDLE: Unit test for textView.py -> IDle: test textView.py
versions: +Python 3.5 -Python 3.3
___
Python tracker
<http://bugs.python.org/i
Changes by Terry J. Reedy :
--
title: IDLE: Extend tests for PathBrowser -> Idle: test PathBrowser more
versions: +Python 2.7, Python 3.5
___
Python tracker
<http://bugs.python.org/issu
Terry J. Reedy added the comment:
Your report is a bit vague. Idle is supposed to only open a file once in a
particular Idle process. If you have seen otherwise (but see below first),
please complete the report: OS, exact Python version (x.y.z), exactly what you
did.
If you right-clicked in
Terry J. Reedy added the comment:
I think the *some* of the 'adultification' that you refer to is a result of
Gregor reimplementing turtle in a tkinter-independent intermediate language or
two, the lowest layer of which he then implemented in tkinter as one particular
backend. He i
Terry J. Reedy added the comment:
The patch for #18132 replaced pack with grid, But the replacement seemed
partial even within the top frame (but I may have misread). Mixing the two is
known to be a bad idea. http://effbot.org/tkinterbook/grid.htm has a big
warning box about this. I think we
Terry J. Reedy added the comment:
Notepad++, for instance (which I use), has one version installed, multiple
panes, and only allows one instance to run. It matches Idle in only allowing a
file to be opened in one process, which happens to be the only process.
Idle, by contrast, can have
Terry J. Reedy added the comment:
I currently have the same problem with Idle's builtin Search and Replace
dialogs. In that respect, this is a duplicate of #18590. Since the discussion
here shifted to a third party extension, I am closing this issue and leaving
the other one
Terry J. Reedy added the comment:
I closed #18590 as a duplicate of this.
--
nosy: +terry.reedy
___
Python tracker
<http://bugs.python.org/issue18590>
___
___
Changes by Terry J. Reedy :
--
stage: -> patch review
title: IDLE Improvements: Unit test for AutoExpand.py -> Idle: test
AutoExpand.py
versions: +Python 3.5 -Python 3.3
___
Python tracker
<http://bugs.python.org/i
Terry J. Reedy added the comment:
For tests that use a Text widget, I want the first version to be a gui test
using tkinter.Text. This removes mock Text as an issue in writing the tests. I
will not commit without running the test 'live' at least once.
Once the file (or at least a Te
Changes by Terry J. Reedy :
--
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue11387>
___
___
Python-bugs-list
Terry J. Reedy added the comment:
I reconsidered this in the light of #21559. getargs_b requires an integer of
type int in range(256). A non-int properly raises TypeError.
>>> from _testcapi import getargs_b as gb
>>> gb(1.0)
Traceback (most recent call last):
File "&q
Terry J. Reedy added the comment:
I was tempted to close this, but I think there is an issue that 'theme' has
implied but not stated clearly enough. The OverflowError entry might be
re-written as "Raised when the result of an arithmetic operation involving at
least one non-int
Terry J. Reedy added the comment:
1. In activate, change parameter 'index' to 'element'. I agree with Jim about
rejecting this. A (specific). 'index' is routinely used to point to an item in
a sequence; "arrow1", "slider", and "arrow2&q
Terry J. Reedy added the comment:
A Spinbox is not a Listbox. The common feature of the activate methods you
listed is that the parameter is called 'index'. But I think this is a moot
point.
To the best of my knowledge, casually changing parameter names for no
functional benefit
Terry J. Reedy added the comment:
Just in time, as I will be reviewing and committing new Idle unittest module
starting this week (new GSOC student).
--
___
Python tracker
<http://bugs.python.org/issue18
Terry J. Reedy added the comment:
Thanks for catching this, and for the patch.
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Terry J. Reedy added the comment:
Great start. The initial coveraqe is 90%, only missing the 5 lines in getwords
in the bodies of
if dict.get(w):
continue
,,,
for w in wafter:
if dict.get(w):
continue
words.append(w
New submission from Terry J. Reedy:
Idle unittests that use tkinter.Text are developed using the gui widget and
then switched, to the current extent possible, to mock_tk.Text. I have done
this previously by commenting out gui lines and adding new lines, so it would
be possible to switch back
Terry J. Reedy added the comment:
Victor, since you wrote much of the asyncio doc, any comment on this request?
--
nosy: +terry.reedy
___
Python tracker
<http://bugs.python.org/issue21
Changes by Terry J. Reedy :
--
Removed message: http://bugs.python.org/msg219682
___
Python tracker
<http://bugs.python.org/issue13659>
___
___
Python-bugs-list m
Changes by Terry J. Reedy :
--
Removed message: http://bugs.python.org/msg219683
___
Python tracker
<http://bugs.python.org/issue13659>
___
___
Python-bugs-list m
Terry J. Reedy added the comment:
I think what Steve meant is that *if* the 32-bit installer is working right,
then it should be the default because it would then work for everyone, while
the 64-bit installer cannot possibly work for people with 32-bit windows
Terry J. Reedy added the comment:
I had forgotten until I reread Lundh's note. I made the same assumption about
'master window'. Certainly 'conservative' is safest. Lita has not posted a
patch, but since she is a (paid) summer intern (until mid August), I expect she
w
Terry J. Reedy added the comment:
I am planning the make the simplifying change. But does is solve the problem
you had?
--
___
Python tracker
<http://bugs.python.org/issue18
Terry J. Reedy added the comment:
The coverage of Phil's patch is about 60%. I decided to push it with slight
modification so he is properly credited with what he did. Changes:
Move mock AutoCompleteWindow to test file; too special.
Move ac_func to mock_idle for use in other tests; well
Terry J. Reedy added the comment:
According to my local copy of the repository, rev88617 2014 Jan 21 removed what
I believe was the only line with 'if ob.im_self'. The change may have been in
2.7.5, certainly 2.7.6. I cannot find it in the current code. Please recheck
your version
8801 - 8900 of 13135 matches
Mail list logo
