Terry J. Reedy added the comment:
Now that 3.2 is off of maintenance and Idle patches are being applied to both
3.3 and 3.4 (and usually 2.7), I plan to backport the Idle subset of changes to
3.3 so patches are more likely to merge forward without incident. (I have
already done one where this
Changes by Terry J. Reedy :
--
resolution: -> fixed
stage: commit review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
New submission from Terry J. Reedy:
This issue is about uniformly updating the old idiom
try:
f = open('file')
to the current idiom
try:
with open('file') as f:
#16715 changed 'IOError' to 'OSError' everywhere in Lib/* for 3.4 only
New submission from Terry J. Reedy:
Backporting Idle patches from 3.x to 2.7 would be easier with a canned edit
script. Below are the substitutions I can think of immediately. Do any of you
know of others?
Easy (str.replace):
tkinter -> Tkinter
import tkinter.messagebox as tkMessage
Terry J. Reedy added the comment:
Here is the 'OS' version of the fix and update to grep_it. Change 'OS' to 'IO'
on line 17 to apply to current 3.3, without the io2os patch. Besides using
'with', it iterates the files directly instead of iterating bl
Terry J. Reedy added the comment:
Serhiy: I don't care about patch style but I read somewhere that I 'should' set
the hg options file to automatically produce git style diff. However, since the
hg doc says that this setting does not affect pushes, I don't know why, and I
Changes by Terry J. Reedy :
Added file: http://bugs.python.org/file30489/grep_it.diff
___
Python tracker
<http://bugs.python.org/issue18151>
___
___
Python-bugs-list m
Terry J. Reedy added the comment:
Ezio: yes. Once I have written a working-directory diff to a file for upload
(non-trivial on Windows), 'Import' is as easy to use as Graft and as far as I
know, the result when successful is the same. I know I 'should' learn to use
kdiff3
Terry J. Reedy added the comment:
I don't think so. The idle test, test_idle, passed. The patch did not even
affect any of the three idle files that it currently tests. Just because a
commit triggers a test does not mean that it is the cause of any failure that
happens. The log say
Terry J. Reedy added the comment:
I would wait and see if it happens gain or on other buildbots. As I am sure you
know, intermittent failures, not reproducible on demand, are nasty.
--
___
Python tracker
<http://bugs.python.org/issue16
Changes by Terry J. Reedy :
--
assignee: kbk ->
versions: +Python 3.3, Python 3.4 -Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/iss
Changes by Terry J. Reedy :
--
versions: +Python 3.4 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue13179>
___
___
Python-bugs-list mailing list
Unsub
Changes by Terry J. Reedy :
--
versions: +Python 3.4 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue13319>
___
___
Python-bugs-list mailing list
Unsub
Changes by Terry J. Reedy :
--
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issue13504>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
I do not think there is any pydev interest in separately patching tix, any more
than we patch tk itself.
--
resolution: rejected -> invalid
status: open -> closed
___
Python tracker
<http://bugs.p
Changes by Terry J. Reedy :
--
versions: +Python 3.3, Python 3.4 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue13630>
___
___
Python-bugs-list mailin
Changes by Terry J. Reedy :
--
versions: +Python 3.4 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue13519>
___
___
Python-bugs-list mailing list
Unsub
Changes by Terry J. Reedy :
--
versions: +Python 3.3, Python 3.4 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue13586>
___
___
Python-bugs-list mailin
Changes by Terry J. Reedy :
--
versions: +Python 3.4 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue13582>
___
___
Python-bugs-list mailing list
Unsub
Changes by Terry J. Reedy :
--
versions: +Python 2.7, Python 3.3
___
Python tracker
<http://bugs.python.org/issue13659>
___
___
Python-bugs-list mailing list
Unsub
Changes by Terry J. Reedy :
--
versions: +Python 3.4 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue14105>
___
___
Python-bugs-list mailing list
Unsub
Changes by Terry J. Reedy :
--
versions: +Python 3.4 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue13802>
___
___
Python-bugs-list mailing list
Unsub
Changes by Terry J. Reedy :
--
versions: +Python 2.7, Python 3.4
___
Python tracker
<http://bugs.python.org/issue14440>
___
___
Python-bugs-list mailing list
Unsub
Changes by Terry J. Reedy :
--
versions: +Python 3.3, Python 3.4
___
Python tracker
<http://bugs.python.org/issue14111>
___
___
Python-bugs-list mailing list
Unsub
Changes by Terry J. Reedy :
--
versions: +Python 2.7, Python 3.4 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue14576>
___
___
Python-bugs-list mailin
Changes by Terry J. Reedy :
--
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issue15308>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Terry J. Reedy :
--
versions: +Python 3.4 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue14944>
___
___
Python-bugs-list mailing list
Unsub
Changes by Terry J. Reedy :
--
versions: +Python 3.3, Python 3.4 -Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/issue1524639>
___
___
Pytho
Changes by Terry J. Reedy :
--
versions: +Python 2.7, Python 3.3
___
Python tracker
<http://bugs.python.org/issue15335>
___
___
Python-bugs-list mailing list
Unsub
Changes by Terry J. Reedy :
--
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issue15313>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Terry J. Reedy :
--
versions: +Python 3.4 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue15363>
___
___
Python-bugs-list mailing list
Unsub
Changes by Terry J. Reedy :
--
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issue15457>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Terry J. Reedy :
--
versions: -Python 3.2
___
Python tracker
<http://bugs.python.org/issue15786>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Terry J. Reedy :
--
versions: -Python 3.2
___
Python tracker
<http://bugs.python.org/issue16547>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Terry J. Reedy :
--
assignee: docs@python ->
versions: +Python 2.7, Python 3.3
___
Python tracker
<http://bugs.python.org/issue16893>
___
___
Py
Changes by Terry J. Reedy :
--
versions: +Python 3.3, Python 3.4 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue16655>
___
___
Python-bugs-list mailin
Terry J. Reedy added the comment:
This is probably a duplicate of other issues. But please try with the newest
2.7.5.
--
___
Python tracker
<http://bugs.python.org/issue17
Terry J. Reedy added the comment:
Making a list of all possible modules is harder than a list of attributes. With
relative imports, I am not sure its even possible to sensible make a list of
every entry that would work.
--
___
Python tracker
<h
Terry J. Reedy added the comment:
The format looks good.
The content looks skimpy. I am not familiar with Delegator and have not yet
looked to see what more is needed. But this is enough to test working with a
gui test.
This *is* a gui test. See msg190576. So it must be protected by
Terry J. Reedy added the comment:
The basic question for this issue is whether to segregate gui tests in a
separate directory (idle_test_gui?) and run them with a separate
test_idle_gui.py? or to sprinkle gui test cases throughout the test suite,
perhaps one to each test_idle/text_xxx.py file
Terry J. Reedy added the comment:
Thanks. That still leaves the problem of getting all tests to run during
development when running them with unittest. Calling requires('gui') passes
when (_is_gui_available() and (caller is __main__ or 'gui' in use_resources)).
Use_resou
Terry J. Reedy added the comment:
test_idle, which runs the tests in idlelib/idle_test, currently comprises 9
test methods and perhaps 100 lines that do not, as far as I know, use warnings
or logging. However, perhaps this has an effect:
F:\Python\dev\cpython\PCbuild>python_d -m t
Terry J. Reedy added the comment:
I discovered the same thing a different way. Grepping Lib/*.py for
'Warning (from warnings module)' hits
F:\Python\dev\cpython\Lib\idlelib\PyShell.py: 67:
F:\Python\dev\cpython\Lib\idlelib\run.py: 34:
Both monkey-patch warnings, when imported, to sho
Terry J. Reedy added the comment:
Vinay, please comment on this: on my Win7-64 system, as least, test_logging
seems broken without running test_idle first.
F:\Python\dev\cpython\PCbuild>python_d -m test test_logging
[1/1] test_logging
dummy.py:42: UserWarning: Explicit
Warn
Terry J. Reedy added the comment:
I reverted the change to test_logging, reran, and it runs fine, at least twice.
Before the revert, I checked that the only two changes were the intentional
ones.
I tried adding idle_test/test_zdummy.py with a tearDownModule that deletes
sys.modules['war
Terry J. Reedy added the comment:
The only locale setting is IOBinding.py: 21
# Try setting the locale, so that we can find out what encoding to use
locale.setlocale(locale.LC_CTYPE, "")
This section, up to line 65, might be wrapped either by a function or if
statement.
There
Terry J. Reedy added the comment:
I should have explicitly said 'all test methods in one test file'.
I included ' caller is __main__' in the requires 'pass' condition. My first
question was only about, for instance, running test_grep from the 'if __name__
.
Terry J. Reedy added the comment:
Yes, 'support', not 'resource'. However, re-read my message for properly using
requires to avoid the traceback.
def setUpModule():
requires('gui')
may also work, but I am assuming that there might be n
Terry J. Reedy added the comment:
As I discovered by experiment, unittest.SkipTest and subclasses are only
handled properly inside of functions recognized and called by unittest. This
could be better documented.
--
___
Python tracker
<h
Terry J. Reedy added the comment:
Windows 3.3 build still failed today. So I updated back to time it worked, and
them skipped forward every so ofter to current, compiling each time, and it
worked each time except for one problem that was fixed in the next commit. No
problems with 3.4
Terry J. Reedy added the comment:
The problem is the 'putenv' and 'getenv' appear to be parallel, and seem to be
documented as being parallel
"Set the environment variable named key to the string value."
"Return the value of the environment variable key if i
Terry J. Reedy added the comment:
In 2.7.5, the offending line is 1558, not 1560. It is clearer to me as
shell.interp.runcommand("print('%s')" % tkversionwarning)
Amaury is correct about 1541, as seen in the if block itself, but I thing the
shell test should be elevated to
Terry J. Reedy added the comment:
The rationale for install is "For convenience, you want the _() function to be
installed in Python’s builtins namespace, so it is easily accessible in all
modules of your application." As David noted, this also make it easy to update
_ in just one
Terry J. Reedy added the comment:
What is the purpose in touching fieldnames, either in tuple-izing it or in
making it private and wrapped with a property. If someone wants to modify it,
that is up to them. In any case, this change is not germane to the issue and
could break code, so I would
Terry J. Reedy added the comment:
The problem with all of range, slice, and islice is that
[start,] stop [, step] is an impossible signature and needed to be changed.
The actual signature is
start_or_stop, [stop, [step]]
with customized processing to interpret start_or_stop according to the
Terry J. Reedy added the comment:
Ditto, for reasons given
--
nosy: +terry.reedy
resolution: -> rejected
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Terry J. Reedy added the comment:
I do not quite see the need to complicate the interface for most users in a way
that does not really solve all of the realistic problems.
import unittest
unittest.main()
#
Ran 0 tests in 0.000s
OK
---
It seems to me that a continuous integration system should
Terry J. Reedy added the comment:
You stated facts: what is your proposal?
The fact that unicode calls characters 'space' does not make then whitespace as
commonly understood, or as defined by C, or even as defined by the Unicode
database. Unicode apparently has a WSpace property.
Changes by Terry J. Reedy :
--
nosy: +terry.reedy
___
Python tracker
<http://bugs.python.org/issue18237>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
You omitted the crucial control experiment.
>>> t2=tk.Text()
>>> t2.get(1.0, tk.END)
'\n'
Text widgets are initialized to end with \n. I suspect that this is an
intentional invariant of tk Text widgets, done by tk itself and not o
Terry J. Reedy added the comment:
There is a separate issue about killing that warning.
If you leave off '-ugui', you will see the traceback and why I said that
requires('gui') should be wrapped for unittest discovery. As the code is, the
call is executed when the file i
Terry J. Reedy added the comment:
I see your point now. Since RS is not whitespace by any definition I knew of
previously, why is RS.isspace True?
Apparent answer: Doc says '''Return true if there are only whitespace
characters in the string and there is at least one c
New submission from Terry J. Reedy:
Win 7, make html, 2.7 and 3.3.
writing output... [ 20%] howto/advocacy
Exception occurred:
File "F:\Python\dev\py33\Doc\tools\sphinx\environment.py", line 1063, in
get_toc_for
toc = self.tocs[docname].deepcopy()
KeyError: 'howto/advocac
Terry J. Reedy added the comment:
I am not sure what you mean by 'rollback'. My experience and understanding is
that once I start a merge, I must finish it somehow before doing anything else.
Do you mean revert a particular problematic file (like NEWS), and hand edit?
Another bac
Terry J. Reedy added the comment:
Must mention that 'support' was 'test_support' in 2.7.
--
___
Python tracker
<http://bugs.python.org/issue18103>
___
_
Terry J. Reedy added the comment:
Nuking build worked. So did, with less re-work, deleting the advocacy doctree
and html files ;-). Too bad this is not somehow automated.
--
status: pending -> closed
___
Python tracker
<http://bugs.pyth
Changes by Terry J. Reedy :
--
stage: test needed -> needs patch
___
Python tracker
<http://bugs.python.org/issue7267>
___
___
Python-bugs-list mailing list
Un
New submission from Terry J. Reedy:
This is a 2.7 only bug.
F:\Python\mypy\tem2.py
print (__file__)
__file__ should be set to relative or absolute path.
>From command line:
F:\Python\mypy> c:/programs/python27/python.exe tem2.py
tem2.py
F:\Python\mypy> c:/programs/python27/p
Terry J. Reedy added the comment:
Thanks, not specifically Windows then.
--
___
Python tracker
<http://bugs.python.org/issue18288>
___
___
Python-bugs-list mailin
Terry J. Reedy added the comment:
"test.support.requires" returns True if
"called from a context with __name__ = '__main__'" or
"'gui' in test.support.use_resources".
The first clause is never true for buildbots, so the presumption is that
Changes by Terry J. Reedy :
--
assignee: -> terry.reedy
versions: +Python 2.7, Python 3.3
___
Python tracker
<http://bugs.python.org/issue18242>
___
___
Py
Terry J. Reedy added the comment:
I should have changed the Versions sooner, as soon as it became obvious that
this was not just a 3.4 issue. The 'temporary' 3.4-only patch breaks forward
merging of a better patch. I will back it out just before I commit a 3.3 patch
to both eli
Terry J. Reedy added the comment:
Here is a patch that looks much bigger than it really is. Idle was written
before the warnings module, so the warnings system was conditioned on a
successful warnings import. The test is no longer needed, and neither Vinay nor
Victor repeated the test at the
Terry J. Reedy added the comment:
See #18103 for patch that will fix this also.
--
___
Python tracker
<http://bugs.python.org/issue18242>
___
___
Python-bug
Changes by Terry J. Reedy :
--
Removed message: http://bugs.python.org/msg191926
___
Python tracker
<http://bugs.python.org/issue18242>
___
___
Python-bugs-list m
Terry J. Reedy added the comment:
See #18101 for patch that will fix this also.
--
___
Python tracker
<http://bugs.python.org/issue18242>
___
___
Python-bug
New submission from Terry J. Reedy:
In a commiters-list discussion of heuristics for what patches can go into
non-Idle 2.7, Nick Coghlan offered "simplifying cross-version maintenance". (He
also mentioned "addressing issues that arise due to changes in the underlying
platf
Terry J. Reedy added the comment:
I wrote a short script (already uploded) to differ 2.7 and 3.3 versions of an
idlelib file. Applied to PyShell, I see unnecessary differences, like 'a,b'
changed to 'a, b', or 'not a in b' changed to 'a not in b'
Changes by Terry J. Reedy :
--
title: Idle 2.7: update to simply cross-version patches -> Idle 2.7: update to
simplify cross-version patches
___
Python tracker
<http://bugs.python.org/issu
New submission from Terry J. Reedy:
It appears that Idle was originally written to run on *nix after being launched
from a command-line console. Messages related to Idle code (warnings and
exceptions) are sent back to the console, while messages related to user code
go to the shell window
Terry J. Reedy added the comment:
Improved 3.3 patch with tests incorporates Vinay's capture_warnings function to
uncapture at end of import and main exit. I plan to apply after checking other
versions and close this issue.
--
Added file: http://bugs.python.org/file30719/issue
Terry J. Reedy added the comment:
Re-close?
--
nosy: +terry.reedy
___
Python tracker
<http://bugs.python.org/issue18135>
___
___
Python-bugs-list mailin
Terry J. Reedy added the comment:
I find some anonymous I references (Guido? 20 years ago?) off-putting when
reading the doc as formal reference.
--
nosy: +terry.reedy
___
Python tracker
<http://bugs.python.org/issue18
Changes by Terry J. Reedy :
--
nosy: +terry.reedy
___
Python tracker
<http://bugs.python.org/issue18292>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
The 2.7 doc says 'Roughly equivalent to' rather than 'Equivalent to'.
The undecorated Python version of from_iterable actually works as an attribute
of the Python version of chain: chain.from_iterable = from_iterable. I would
just remov
Terry J. Reedy added the comment:
Performance enhancements do not normally go in bugfix releases. The issue of
quadratic performance of sum(sequences, null_seq) is known, which is why the
doc says that sum() is for numbers and recommends .join for strings and
itertools.chain for other
Terry J. Reedy added the comment:
While you are at it, should you just replace test_main with unittest.main?
--
nosy: +terry.reedy
___
Python tracker
<http://bugs.python.org/issue18
Terry J. Reedy added the comment:
If you think you will ever contribute another patch (and we hope you do), and
you have not yet submitted a contributor agreement, please do.
http://www.python.org/psf/contrib/contrib-form/
http://www.python.org/psf/contrib/
Once processed, a * will appear
Terry J. Reedy added the comment:
David, with the addition, this line
"""class FileInput([files[, inplace[, backup[, bufsize[, mode[,
openhook]])
ends at position 83 instead of 80. It should stay on one line. I could reduce
that by removing blanks after ,s. Is it better
Changes by Terry J. Reedy :
Added file: http://bugs.python.org/file30727/18315-fileinput-27.diff
___
Python tracker
<http://bugs.python.org/issue18315>
___
___
Python-bug
Terry J. Reedy added the comment:
I just remembered: the first list of a .py file docstring should be a one line
summary of what the callable does. It should not give the signature because
(unlike C function currently) help does that for us from the callable itself
(using the inspect module
Terry J. Reedy added the comment:
There was one missing 'bufsize' in 3.x also.
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs
Changes by Terry J. Reedy :
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Terry J. Reedy added the comment:
This was sent to #18242 but not here. I expected here also.
New changeset c15d0baac3d6 by Terry Jan Reedy in branch '3.3':
Issue *18081, #18242: Change Idle warnings capture in PyShell and run
http://hg.python.org/cpython/rev/c15d0baac3d6
New
Terry J. Reedy added the comment:
I went with adding ' after changing '...' to "...".
If you think you might ever submit a more substantial patch, and we hope you
do, please submit a Contributor Agreement (now optionally electronic).
http://www.python.org/psf/contri
New submission from Terry J. Reedy:
The purpose of the function is to create a command line for the user
subprocess. Most of its body:
'''
# Maybe IDLE is installed and is being accessed via sys.path,
# or maybe it's not installed and the idle.py script is being
# run
Terry J. Reedy added the comment:
While I have not committed any gui tests, the patch is based on experiments
with a couple of temporary files.
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
_
Terry J. Reedy added the comment:
This issue still seems to be about bad extension modules crashing CPython and
we cannot fix that.
--
resolution: -> wont fix
stage: -> committed/rejected
status: pending -> closed
___
Python track
Changes by Terry J. Reedy :
--
nosy: -terry.reedy
___
Python tracker
<http://bugs.python.org/issue10794>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Terry J. Reedy :
--
versions: +Python 3.3, Python 3.4 -Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/issue11126>
___
___
Python-bug
8001 - 8100 of 13135 matches
Mail list logo
