[issue33904] IDLE: In rstrip, change class RstripExtension to Rstrip

2018-06-19 Thread Terry J. Reedy
New submission from Terry J. Reedy : Rstrip is no longer an extension. Change all occurrences throughout idlelib, including tests. Some may not be covered in tests. Branch after #33855 is merged. -- assignee: terry.reedy components: IDLE messages: 320001 nosy: terry.reedy priority

[issue33905] IDLE: stackbrowser.Stackbrowser should accept exception.

2018-06-19 Thread Terry J. Reedy
New submission from Terry J. Reedy : Stackbrowser is currently initialized with a traceback and/or the sys.last_xyz attributes. The latter are not set when unittesting; the test framework somehow prevents this. The tests needed are the ones that will be enabled by Stackbrower accepting an

[issue33906] IDLE: change windows.py to window.py

2018-06-19 Thread Terry J. Reedy
New submission from Terry J. Reedy : Change module 'windows' to 'window':: 1. 'calltips' and 'windows' are the only two plural module names. 2. The top menu entry was changed from 'Windows' to 'Window' some time ago. 3. 'windows&

[issue33906] IDLE: rename windows.py as window.py

2018-06-19 Thread Terry J. Reedy
Change by Terry J. Reedy : -- title: IDLE: change windows.py to window.py -> IDLE: rename windows.py as window.py ___ Python tracker <https://bugs.python.org/issu

[issue33904] IDLE: In rstrip, rename class RstripExtension as Rstrip

2018-06-19 Thread Terry J. Reedy
Change by Terry J. Reedy : -- title: IDLE: In rstrip, change class RstripExtension to Rstrip -> IDLE: In rstrip, rename class RstripExtension as Rstrip ___ Python tracker <https://bugs.python.org/issu

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
New submission from Terry J. Reedy : Rename module 'calltips' as 'calltip' 1. 'calltips' and 'windows' are the only two plural module names. 2. 'calltip' fits better with 'calltip_w' (which may, however, be merged in 'calltip&#x

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: I am going to change calltips.py and CallTips to calltip.py and Calltip in #33907, but will not change tooltip.py there as I would expect a merge conflict. Once the change is made elsewhere, change should be made to tooltip and test_tooltip directly

[issue33855] IDLE: Minimally test every non-startup module.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 4d92158f4c3917fc4fbfebff15224e74782abf79 by Terry Jan Reedy in branch 'master': bpo-33855: Still more edits and minimal tests for IDLE (GH-7784) https://github.com/python/cpython/commit/4d92158f4c3917fc4fbfebff15224e

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Change by Terry J. Reedy : -- keywords: +patch pull_requests: +7413 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue33855] IDLE: Minimally test every non-startup module.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: Still open for a patch explaining idle_test.template in README. I opened #33904 for rstrip, #33905 for stackbrowser, #33906 for windows, and #33907 for calltips/CallTip renaming. -- stage: patch review -> test nee

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 06e2029dfa500a42e3565ed7ba8573412f153d1c by Terry Jan Reedy in branch 'master': bpo-33907: Rename an IDLE module and class. (GH-7807) https://github.com/python/cpython/commit/06e2029dfa500a42e3565ed7ba8573

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Change by Terry J. Reedy : -- pull_requests: +7415 ___ Python tracker <https://bugs.python.org/issue33907> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: I also changed calltips.CallTips to calltip.Calltip, which is the same class name as for calltip_w.Calltip (formerly CallTip). This is confusing now and would block merging the files. Change the latter to calltip_w.CalltipW (for Window). -- nosy

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: The calltip window class name is only used in 4 places, so I decided to expand to CalltipWindow. -- ___ Python tracker <https://bugs.python.org/issue33

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset e97a685185b82ba6de6de576fc2a4cf3cd6192af by Terry Jan Reedy in branch '3.6': [3.6] bpo-33907: Rename an IDLE module and class. (GH-7807) (GH-7809) https://github.com/python/cpython/commit/e97a685185b82ba6de6de576fc2a4c

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Change by Terry J. Reedy : -- pull_requests: +7416 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issue33907> ___ ___ Python-

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 9af1836664d241fec6e62955ffaa559b3a2eaf1b by Terry Jan Reedy in branch 'master': bpo-33907: Rename an IDLE module and classes. (GH-7810) https://github.com/python/cpython/commit/9af1836664d241fec6e62955ffaa55

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: I just merged 2nd PR for #33907. Combined effect is that module calltips and its class CallTips are now calltip and Calltip. In module calltip_w class CallTip is now CalltipWindow. -- ___ Python tracker <ht

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue33906] IDLE: rename windows.py as window.py

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: Also rename idle_test.test_windows as test_window with git mv. Imports: F:\dev\3x\lib\idlelib\editor.py: 28: from idlelib import windows F:\dev\3x\lib\idlelib\idle_test\test_windows.py: 3: from idlelib import windows F:\dev\3x\lib\idlelib\macosx.py: 131

[issue33905] IDLE: stackbrowser.Stackbrowser should accept exception.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: Only one of tb and exc may be passed. -- ___ Python tracker <https://bugs.python.org/issue33905> ___ ___ Python-bugs-list m

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

2018-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: > if: versus try: The latter is faster if try: succeeds. On the other hand, we > could make the if: fail by mocking it. Since there is no except: or else: > code to test, it hardly seems worth it. A low priority item. Generalizing 'show c

[issue33906] IDLE: rename windows.py as window.py

2018-06-20 Thread Terry J. Reedy
Change by Terry J. Reedy : -- pull_requests: -7421 ___ Python tracker <https://bugs.python.org/issue33906> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33904] IDLE: In rstrip, rename class RstripExtension as Rstrip

2018-06-20 Thread Terry J. Reedy
Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue33855] IDLE: Minimally test every non-startup module.

2018-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: #33917 is about fixing and documenting template.py. -- dependencies: +idlelib/idle_test/template.py has invalid syntax ___ Python tracker <https://bugs.python.org/issue33

[issue33917] Fix and document idlelib/idle_test/template.py

2018-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: I wrote it intentionally the way it is, for #33855, as it made it maximally easily to use to complete the test suite. Since it caused a problem, I added a valid dummy name to be replaced, and fixed the other syntax error. The file now compiles, runs, and

[issue33917] Fix and document idlelib/idle_test/template.py

2018-06-20 Thread Terry J. Reedy
Change by Terry J. Reedy : -- nosy: +ned.deily versions: +Python 3.6, Python 3.7, Python 3.8 ___ Python tracker <https://bugs.python.org/issue33917> ___ ___ Pytho

[issue33917] Fix and document idlelib/idle_test/template.py

2018-06-20 Thread Terry J. Reedy
Change by Terry J. Reedy : -- keywords: +patch pull_requests: +7439 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue33917] Fix and document idlelib/idle_test/template.py

2018-06-20 Thread Terry J. Reedy
Change by Terry J. Reedy : -- stage: needs patch -> commit review ___ Python tracker <https://bugs.python.org/issue33917> ___ ___ Python-bugs-list mai

[issue33917] Fix and document idlelib/idle_test/template.py

2018-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: Tal and Cheryl: I revised the template for IDLE tests, pulled it out of README.txt into template.py, and explained it in the readme. It has new code for cleaning up after instantiating EditorWindow in tests. Please follow for any new test file, including

[issue33917] Fix and document idlelib/idle_test/template.py

2018-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 87a927325e3856621790a39d8718ff24a19510aa by Terry Jan Reedy in branch 'master': bpo-33917: Fix and document idlelib/idle_test/template.py (GH-7830) https://github.com/python/cpython/commit/87a927325e3856621790a39d8718ff

[issue33917] Fix and document idlelib/idle_test/template.py

2018-06-20 Thread Terry J. Reedy
Change by Terry J. Reedy : -- keywords: -patch resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue33906] IDLE: rename windows.py as window.py

2018-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: Marking 2.7 for a search test. -- versions: +Python 2.7 ___ Python tracker <https://bugs.python.org/issue33906> ___ ___ Pytho

[issue33906] IDLE: rename windows.py as window.py

2018-06-20 Thread Terry J. Reedy
Change by Terry J. Reedy : -- versions: -Python 2.7 ___ Python tracker <https://bugs.python.org/issue33906> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33906] IDLE: rename windows.py as window.py

2018-06-20 Thread Terry J. Reedy
Change by Terry J. Reedy : -- pull_requests: +7442 ___ Python tracker <https://bugs.python.org/issue33906> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33906] IDLE: rename windows.py as window.py

2018-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset a361e89d5ae3daefe9e8b8a7e889cd2ad8c45b77 by Terry Jan Reedy in branch 'master': bpo-33906: Rename idlelib.windows as window (#7833) https://github.com/python/cpython/commit/a361e89d5ae3daefe9e8b8a7e889cd

[issue33906] IDLE: rename windows.py as window.py

2018-06-20 Thread Terry J. Reedy
Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue33924] In IDLE menudefs, change 'windows' to 'window'

2018-06-20 Thread Terry J. Reedy
New submission from Terry J. Reedy : Some time ago, IDLE's main menu item 'Windows' was changed to 'Window'. The latter seems to be pretty standard for a list of open windows. Issue #33906 changed the implementation module name accordingly, from 'windows'

[issue33924] In IDLE menudefs, change 'windows' to 'window'

2018-06-20 Thread Terry J. Reedy
Change by Terry J. Reedy : -- keywords: +patch pull_requests: +7445 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue33924] In IDLE menudefs, change 'windows' to 'window'

2018-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 33c7420e7dd9d8e5b2aa15e98da6291bab6fcf33 by Terry Jan Reedy in branch 'master': bpo-33924: Change IDLE mainmenu.menudefs key 'windows' to 'window' (GH-7836) https://github.com/python/cpython/commit/33c7420e7d

[issue33924] In IDLE menudefs, change 'windows' to 'window'

2018-06-20 Thread Terry J. Reedy
Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue33855] IDLE: Minimally test every non-startup module.

2018-06-21 Thread Terry J. Reedy
Change by Terry J. Reedy : -- resolution: -> fixed stage: test needed -> resolved status: open -> closed versions: +Python 2.7, Python 3.5 -Python 3.8 ___ Python tracker <https://bugs.python.or

[issue33855] IDLE: Minimally test every non-startup module.

2018-06-21 Thread Terry J. Reedy
Change by Terry J. Reedy : -- versions: -Python 2.7 ___ Python tracker <https://bugs.python.org/issue33855> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33855] IDLE: Minimally test every non-startup module.

2018-06-21 Thread Terry J. Reedy
Change by Terry J. Reedy : -- versions: +Python 3.8 -Python 3.5 ___ Python tracker <https://bugs.python.org/issue33855> ___ ___ Python-bugs-list mailin

[issue33905] IDLE: stackbrowser.Stackbrowser should accept exception.

2018-06-21 Thread Terry J. Reedy
Change by Terry J. Reedy : -- Removed message: https://bugs.python.org/msg320002 ___ Python tracker <https://bugs.python.org/issue33905> ___ ___ Python-bug

[issue33905] IDLE: stackbrowser.Stackbrowser should accept exception.

2018-06-21 Thread Terry J. Reedy
Change by Terry J. Reedy : -- Removed message: https://bugs.python.org/msg320028 ___ Python tracker <https://bugs.python.org/issue33905> ___ ___ Python-bug

[issue33905] IDLE: stackbrowser.Stackbrowser should accept exception.

2018-06-21 Thread Terry J. Reedy
Change by Terry J. Reedy : -- keywords: +patch pull_requests: +7463 stage: test needed -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue33905] IDLE: stackbrowser.Stackbrowser should accept exception.

2018-06-21 Thread Terry J. Reedy
New submission from Terry J. Reedy : New changeset bcd3a1a18d841338f57c39f6a7de8cf14d0c3e03 by Terry Jan Reedy in branch 'master': bpo-33905: Add test for idlelib.stackview.StackBrowser. (GH-7852) https://github.com/python/cpython/commit/bcd3a1a18d841338f57c39f6a7de8c

[issue33905] IDLE: Test stackbrowser.Stackbrowser

2018-06-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: (My initial messages contained a mistaken idea based on a mis-remembering the details sys.last values and exceptions.) If an exception is not caught and a traceback is printed, sys.last_type, sys.last_value, and sys.last_traceback are set. When an

[issue33942] IDLE: Improve Apple MacOS Tcl/Tk warning and web page

2018-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: Jasper: when you installed 3.6.5 on your 10.11 machine, you had a choice of the 64-/32-bit installer, good back to 10.6, and newer and better 64-bit installer, good back to 10.9. Since it seems that the latter, the new and improved option, should work for

[issue33877] doc Mention Windows along UNIX for script running instructions

2018-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: The paragraph reads: Under Unix, a complete program can be passed to the interpreter in three forms: with the -c string command line option, as a file passed as the first command line argument, or as standard input. If the file or standard input is a tty

[issue33885] doc Replace "hook function" with "callable" in urllib.request.urlretrieve

2018-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: I am not even sure what a 'hook function' is supposed to mean. A beginner might think it means something other than any old callable. Unless Sentil or someone objects within a week, I would merge this. Ping me if nothing happens. -

[issue33930] Segfault with deep recursion into object().__dir__

2018-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: Serhiy, is this one of the cases we decided to leave as won't fix? -- nosy: +serhiy.storchaka, terry.reedy ___ Python tracker <https://bugs.python.org/is

[issue33885] doc Replace "hook function" with "callable" in urllib.request.urlretrieve

2018-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset c45cb479074b5d25f0d382d3109f527520a9f03c by Terry Jan Reedy (Andrés Delfino) in branch '3.6': bpo-33885: Replace "hook function" with "callable" (GH-7765) https://github.com/python/cpython/commit/c45cb47907

[issue33877] doc Mention Windows along UNIX for script running instructions

2018-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: Thanks. I did that and will merge when possible. -- assignee: docs@python -> terry.reedy ___ Python tracker <https://bugs.python.org/issu

[issue33877] doc Mention Windows along UNIX for script running instructions

2018-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset c9d43c702a53804c23ecb22a0dbf6a47c804d2b1 by Terry Jan Reedy (Andrés Delfino) in branch 'master': bpo-33877: Remove UNIX qualification for running complete programs (GH-7744) https://github.com/python/cpyt

[issue33877] Doc: Delete UNIX qualification for script running instructions

2018-06-22 Thread Terry J. Reedy
Change by Terry J. Reedy : -- title: doc Mention Windows along UNIX for script running instructions -> Doc: Delete UNIX qualification for script running instructions ___ Python tracker <https://bugs.python.org/issu

[issue33942] IDLE: Improve Apple MacOS Tcl/Tk warning and web page

2018-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: I agree that an install screen is a better place for the link. And if the 3.6.7 installer links with an included 8.6, the 8.5.7/9 message will be obsolete for the included IDLE, hence no point in patching it. Hooray. I will open separate issues about

[issue33877] Doc: Delete UNIX qualification for script running instructions

2018-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 1c9a72cc99d4f76a18755d7227bd1c375e44b4ad by Terry Jan Reedy (Andrés Delfino) in branch '2.7': [2.7] bpo-33877: Remove UNIX qualification for running complete programs (GH-7744) https://github.com/python/cpyt

[issue33942] IDLE: Problems using IDLE and 2.7, 3.6 macOS 64-/32-bit installer

2018-06-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: Now I see what Ned meant by making 64-bit-only instead of 64-/32-bit the default in 3.6.7. What we directly suggested is https://www.python.org/downloads/release/python-365/, pick 'macOS 64-bit installer', 'for OS X 10.9 and later'.

[issue32942] test_script_helper fails on Windows when run from the source code directory

2018-06-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: Ditto with fresh update and build, except that I used installed 3.7.0rc1 (and it passed). This is not regularly failing on the (Windows) buildbots, so there is something 'different' about the repository on some non-buildbot user machines. I am p

[issue33950] IDLE htest: don't try to test deleted tabbedpages.py

2018-06-23 Thread Terry J. Reedy
New submission from Terry J. Reedy : About last September, idlelib.tabbedpages was replaced in configdialog by ttk.notebook and deleted. Delete the testing spec, which causes htest to fail when attempting to run all htests. -- messages: 320332 nosy: terry.reedy priority: normal

[issue33950] IDLE htest: don't try to test deleted tabbedpages.py

2018-06-23 Thread Terry J. Reedy
Change by Terry J. Reedy : -- keywords: +patch pull_requests: +7490 stage: commit review -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue33950] IDLE htest: remove spec for deleted tabbedpages.py

2018-06-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: This should have been done when the replacement was made. No news needed. -- stage: patch review -> commit review title: IDLE htest: don't try to test deleted tabbedpages.py -> IDLE htest: remove spec for deleted tab

[issue33950] IDLE htest: remove spec for deleted tabbedpages.py

2018-06-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 5ae70f66ff1949eec35ff207c97cfe572c4e74c8 by Terry Jan Reedy in branch 'master': bpo-33950: Remove IDLE htest spec for a deleted file. (GH-7881) https://github.com/python/cpython/commit/5ae70f66ff1949eec35ff207c97cfe

[issue33950] IDLE htest: remove spec for deleted tabbedpages.py

2018-06-23 Thread Terry J. Reedy
Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue33885] doc Replace "hook function" with "callable" in urllib.request.urlretrieve

2018-06-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: The bots occasionally miss. PR 7885 was indeed merged even though the message has not appeared. https://github.com/python/cpython/commit/2c11e23a5a686edc69bcbb4c65f500d50d992bb3 PR 7886 was merged as the message says, even though the status was not changed

[issue33951] IDLE test failing only when called by itself: HighPageTest.test_highlight_target_text_mouse

2018-06-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 2af9f5d334eeca58887d177faf0012c63a03 by Terry Jan Reedy (Tal Einat) in branch 'master': bpo-33951: IDLE test_configdialog: call page.update in setUpClass (GH-7892) https://github.com/python/cpyt

[issue33951] IDLE test failing only when called by itself: HighPageTest.test_highlight_target_text_mouse

2018-06-24 Thread Terry J. Reedy
Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue33960] IDLE REPL: Strange indentation

2018-06-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: Python's secondary prompt in interactive mode is an artifact of the fact the command line consoles work with physical lines while python works with statements that quite possibly comprises multiple lines. As mentioned in the its doc, IDLE works

[issue33924] In IDLE menudefs, change 'windows' to 'window'

2018-06-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 42397731d7ba8bdf63025d48008d133cb2070229 by Terry Jan Reedy (Mark Roseman) in branch 'master': bpo-33924: Add missed mac-specific 'windows' to 'window' changes (GH-7920) https://gi

[issue33924] In IDLE menudefs, change 'windows' to 'window'

2018-06-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: Mark's PR added two conversions, in macosx, that I missed. I rechecked a recursive case sensitive whole-word grep of 'windows' in idlelib and I believe all remaining occurrences refer to the Windows OS (usually capitalized) or m

[issue33962] IDLE: use ttk.spinbox

2018-06-25 Thread Terry J. Reedy
New submission from Terry J. Reedy : Spinoff from #27755, which has a image of tk and ttk versions of a spinbox on Mac and asks about using ttk.spinbox. ttk Spinbox was added to tcl/tk in 8.5.9 and to tkinter.ttk in 3.7. I believe there are three cases to consider. tcl/tk python action

[issue27755] Retire DynOptionMenu with a ttk Combobox

2018-06-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: Yes, we should use ttk.Spinbox: #33962. -- ___ Python tracker <https://bugs.python.org/issue27755> ___ ___ Python-bugs-list m

[issue33963] IDLE macosc: add tests.

2018-06-25 Thread Terry J. Reedy
New submission from Terry J. Reedy : For overrideRootMenu, move nested functions to module level. Try to move 3 imports to module level. Test startup on mac. Mock 'window' with mock functions. -- messages: 320468 nosy: terry.reedy priority: normal severity: normal stage: n

[issue33963] IDLE macosx: add tests.

2018-06-25 Thread Terry J. Reedy
Change by Terry J. Reedy : -- title: IDLE macosc: add tests. -> IDLE macosx: add tests. ___ Python tracker <https://bugs.python.org/issue33963> ___ ___ Python-

[issue33964] IDLE maxosc.overrideRootMenu: remove unused menudict

2018-06-25 Thread Terry J. Reedy
Change by Terry J. Reedy : -- dependencies: +IDLE macosx: add tests. ___ Python tracker <https://bugs.python.org/issue33964> ___ ___ Python-bugs-list mailin

[issue33963] IDLE macosx: add tests.

2018-06-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: Ned, I would like to rename at least some of the functions in idlelib.macosx. For instance, function overrideRootMenu to override_root_menu. Would this affect any of the installation adjustments? IE, does the installer import the module for whatever

[issue33964] IDLE maxosc.overrideRootMenu: remove unused menudict

2018-06-25 Thread Terry J. Reedy
New submission from Terry J. Reedy : Function local name 'menudict' is initialized empty, two key value pairs are added, and it is never touched again. -- messages: 320470 nosy: terry.reedy priority: normal severity: normal stage: needs patch status: open t

[issue33964] IDLE maxosc.overrideRootMenu: remove unused menudict

2018-06-25 Thread Terry J. Reedy
Change by Terry J. Reedy : -- keywords: +patch pull_requests: +7534 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue33962] IDLE: use ttk.spinbox

2018-06-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: ttk.Spinbox inherits from ttk.Entry. My option list left out the options for Entry, which is one of the ttk widget not in the doc. The additional entry options include exportselection, justify, show, state, textvariable, and width. https://www.tcl.tk/man

[issue24137] Force not using _default_root in IDLE

2018-06-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: The net effect of this issue: pyshell.main calls NoDefaultRoot() when running normally, when using a subprocess and testing is not set. It does not call it when in -n mode since that would affect users. idle_test.htest calls NoDefaultRoot

[issue33975] IDLE: only adjust DPI before Tk()

2018-06-26 Thread Terry J. Reedy
New submission from Terry J. Reedy : #33656 patched PyShell to call SetProcessDpiAwareness on Windows nearly first thing, *at module level*, well before calling tkinter.Tk(). The Microsoft docs warn that making the Windows API call after starting the graphics system may not work as expected

[issue33975] IDLE: adjust DPI before Tk()

2018-06-26 Thread Terry J. Reedy
Change by Terry J. Reedy : -- title: IDLE: only adjust DPI before Tk() -> IDLE: adjust DPI before Tk() ___ Python tracker <https://bugs.python.org/issu

[issue33975] IDLE: adjust DPI before Tk()

2018-06-26 Thread Terry J. Reedy
Change by Terry J. Reedy : -- keywords: +patch pull_requests: +7553 ___ Python tracker <https://bugs.python.org/issue33975> ___ ___ Python-bugs-list mailin

[issue33975] IDLE: adjust DPI before Tk()

2018-06-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: Because of import caching, subsequent pyshell imports, after the first, do not re-call the Windows API. Apparently, 'root.destroy()' undoes a previous 'root = Tk()', but not a previous pyshell import. Since IDLE unittests always destr

[issue33975] IDLE: adjust DPI before Tk() for htests.

2018-06-26 Thread Terry J. Reedy
Change by Terry J. Reedy : -- title: IDLE: adjust DPI before Tk() -> IDLE: adjust DPI before Tk() for htests. ___ Python tracker <https://bugs.python.org/issu

[issue33975] IDLE: adjust DPI before Tk() for htests.

2018-06-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 3c8043d8fac4c0d05c0ba9e4e555e2f3165f2fe0 by Terry Jan Reedy in branch 'master': bpo-33975: Avoid small type when running IDLE's htests. (GH-7944) https://github.com/python/cpython/commit/3c8043d8fac4c0d05c0ba9e4e

[issue33975] IDLE: adjust DPI before Tk() for htests.

2018-06-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: Both PRs have been merged. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue33719] Test failures on Python 3.7 beta 5 and Windows 10

2018-06-27 Thread Terry J. Reedy
Terry J. Reedy added the comment: Same test_site and test_tools (#25094) failures on newly installed 3.6.6 and 3.7.0. They pass on repository 3.6,7,8. Was there a fix not pulled into the releases, or are these install dependent? -- nosy: +ned.deily stage: -> needs patch t

[issue25094] [EASY][Windows] test_tools fails on Windows when passing

2018-06-27 Thread Terry J. Reedy
Terry J. Reedy added the comment: For me now, test site fails on installed 3.6.6 and 3.7.0 and passes on repository builds. Serial or parallel, no difference. When I ran as part of the suite, I got --slaveargs message. py -3.7 -m test test_tools says cannot import test tools. py -3.7 -m

[issue33963] IDLE macosx: add tests.

2018-06-28 Thread Terry J. Reedy
Terry J. Reedy added the comment: Mark Roseman emailed me that moving the 3 imports within overrideRootMenu to the top of the module does not appear to cause a problem. -- ___ Python tracker <https://bugs.python.org/issue33

[issue23544] IDLE hangs when selecting Stack View with debug active

2018-06-28 Thread Terry J. Reedy
Terry J. Reedy added the comment: This crashes or hangs the user execution process, but not the IDLE process. So Shell => 'Restart Shell cntl-F6' still works. -- versions: +Python 3.6, Python 3.7, Python 3.8 -Python 3.4, Python 3.5 _

[issue22051] Turtledemo: stop reloading demos

2018-06-28 Thread Terry J. Reedy
Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue14117] Turtledemo: exception and minor glitches.

2018-06-28 Thread Terry J. Reedy
Terry J. Reedy added the comment: #21884 was closed as a duplicate of #21882 and hence not a separate dependency. -- ___ Python tracker <https://bugs.python.org/issue14

[issue14117] Turtledemo: exception and minor glitches.

2018-06-28 Thread Terry J. Reedy
Change by Terry J. Reedy : -- pull_requests: +7609 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issue14117> ___ ___ Python-

[issue14117] Turtledemo: exception and minor glitches.

2018-06-28 Thread Terry J. Reedy
Terry J. Reedy added the comment: PR 8002 fixes the remaining minor problems. -- stage: patch review -> commit review versions: +Python 3.6, Python 3.7, Python 3.8 -Python 2.7, Python 3.4, Python 3.5 ___ Python tracker <https://bugs.pyth

[issue14117] Turtledemo: exception and minor glitches.

2018-06-28 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 891a1f86d415779cf67ca23e626a868e586feb05 by Terry Jan Reedy in branch 'master': bpo-14117: Make minor tweaks to turtledemo (GH-8002) https://github.com/python/cpython/commit/891a1f86d415779cf67ca23e626a86

[issue14117] Turtledemo: exception and minor glitches.

2018-06-28 Thread Terry J. Reedy
Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue33949] tests: allow to select tests using loadTestsFromName

2018-06-29 Thread Terry J. Reedy
Terry J. Reedy added the comment: I have used test -m, but a point in favor of this proposal, for other people, is consistency with running unittest f:\dev\3x>python -m unittest idlelib.idle_test.test_autocomplete.AutoCompleteTest.test_init Running Debug|Win32 interpre

<    71   72   73   74   75   76   77   78   79   80   >