Terry J. Reedy added the comment:
At first glance, 1714 looks great. I hope to merge it tomorrow.
On the issues you raised:
1. I want to leave existing constants alone for now.
2. There are two 'create widgets' styles: create, place, create, place, ...;
and create, create, ..., pl
Terry J. Reedy added the comment:
Roger, Python development has moved from hg and out private server to git and
GitHub. Patches posted on the tracker must be converted to git pull requests
(PRs) to be merged, and also for proper review and editing. Unless you prefer
to do it yourself, we
Changes by Terry J. Reedy :
--
assignee: -> terry.reedy
stage: needs patch -> patch review
versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.org/i
Terry J. Reedy added the comment:
Experiments running 3.6.1 on Windows in console:
>python -c "print('some\0 text')
some text # \0 printed as ' ', as determined by
# >python -c "for c in 'some text': print(ord(c))" printing 32 32
>pyt
Terry J. Reedy added the comment:
As near as I can tell, the patch introduces a regression. The doc for
input(prompt) says "If the prompt argument is present, it is written to
standard output without a trailing newline." The handling of the prompt is up
to stdout.write and thenc
Terry J. Reedy added the comment:
New changeset 5a346d5dbc1f0f70eca706a8ba19f7645bf17837 by terryjreedy
(csabella) in branch 'master':
bpo-30290: IDLE: Refactor help_about to PEP8 names (#1714)
https://github.com/python/cpython/commit/5a346d5dbc1f0f70eca706a8ba19f7
Terry J. Reedy added the comment:
While reviewing, I decided to draw a widget tree. I believe it would have been
easier if packs and grids were grouped.
I want to continue with 'IDLE: modernize help-about' and ditto for textview.
The help_about issue can begin with ttk conversi
New submission from Terry J. Reedy:
First get issue #.
--
assignee: terry.reedy
components: IDLE
messages: 294622
nosy: csabella, terry.reedy
priority: normal
severity: normal
stage: patch review
status: open
title: IDLE: modernize textview module
type: enhancement
versions: Python 3.6
Terry J. Reedy added the comment:
The initial patch, https://github.com/python/cpython/pull/1839, adds missing
docstrings to textview and changes names to conform to PEP 8. It was
originally attached to #30290. I changed the bpo # in the title to 30495. We
will see if Belvedere bot corrects
Terry J. Reedy added the comment:
Grepping shows that other references to textview objects (other than in
test_textview) are to unchanged class and function names.
--
___
Python tracker
<http://bugs.python.org/issue30
Terry J. Reedy added the comment:
pr 1839 is now attached to new issue #30495. This issue is closed except for
trivial bugs in the two merged PRs and backports.
--
___
Python tracker
<http://bugs.python.org/issue30
Terry J. Reedy added the comment:
I plan to merge when checks pass.
Not reusing module names avoids noise when grepping for a module name ;-). A
final search for 'textview', match case, whole word, gave 18 hits, which were
eas
Changes by Terry J. Reedy :
--
pull_requests: +1927
___
Python tracker
<http://bugs.python.org/issue30290>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Terry J. Reedy :
--
pull_requests: -1922
___
Python tracker
<http://bugs.python.org/issue30290>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Terry J. Reedy :
--
pull_requests: -1923
___
Python tracker
<http://bugs.python.org/issue30303>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
New changeset 0aa0a06e8b719533aefd175a5716f1698f474052 by terryjreedy
(csabella) in branch 'master':
bpo-30495: IDLE: Modernize textview.py with docstrings and PEP8 names (#1839)
https://github.com/python/cpython/commit/0aa0a06e8b719533aefd175a5716f1
Terry J. Reedy added the comment:
What I have learned:
1. As with hg, the local master should be updated at least at the beginning of
each work session, and python.exe rebuilt.
2. Patches to master should be developed with all 'other' files updated. For
completely new branche
Terry J. Reedy added the comment:
I believe you said elsewhere that you would like to try the refactoring that
splits a window+frame class into a window class and a frame class. It would be
great if you became good at doing this.
If the current class name is used externally, I might consider
Terry J. Reedy added the comment:
I copied and pasted my code from turtlecrash.py into 3.7 editor, ran, and
probably held key down for 3000 clicks, and it worked as it should.
--
status: pending -> closed
___
Python tracker
<http://bugs.pyth
Terry J. Reedy added the comment:
New changeset e405d4b8dfb8b497e1c3d1f0f8e28030040c165e by terryjreedy (gfyoung)
in branch 'master':
bpo-30361: Use better example for mixed-type operands (#1701)
https://github.com/python/cpython/commit/e405d4b8dfb8b497e1c3d1f0f8e280
Terry J. Reedy added the comment:
Go ahead. I don't care much either way.
--
___
Python tracker
<http://bugs.python.org/issue30361>
___
___
Python-bugs-l
Terry J. Reedy added the comment:
New changeset d52f47a8f7794ee09151973a00d29c8612672e7a by terryjreedy
(Mariatta) in branch '3.6':
[3.6] bpo-30361: Use better example for mixed-type operands (GH-1701) (#1856)
https://github.com/python/cpython/commit/d52f47a8f7794ee09151973a00d29c
Terry J. Reedy added the comment:
New changeset 03c7cfcd52be702957cc174f5cb2ce4c8be8bfca by terryjreedy
(Mariatta) in branch '3.5':
[3.5] bpo-30361: Use better example for mixed-type operands (GH-1701) (#1857)
https://github.com/python/cpython/commit/03c7cfcd52be702957cc174f5cb2ce
Terry J. Reedy added the comment:
Just curious, what sprint?
--
resolution: -> fixed
stage: backport needed -> resolved
status: open -> closed
type: -> enhancement
___
Python tracker
<http://bugs.python
Terry J. Reedy added the comment:
Responses (without yet testing the code):
1. Generally, the only new subclass needed is for the master frame. Existing
Toplevel derivatives may have a single frame in the toplevel, which should
become an instance of a new subclass, in this case TextviewFrame
Terry J. Reedy added the comment:
We should not change simpledialog.py, but we could change bindings after import.
However, since last summer, we can instead replace simpledialog.py with
subclasses of ttk-using query.Query, with custom validators. editor.py uses
askinterger for indent width
Changes by Terry J. Reedy :
--
title: IDLE: replace used of tkinter simpledialog with query.Query -> IDLE:
replace uses of tkinter simpledialog with query.Query
___
Python tracker
<http://bugs.python.org/issu
Terry J. Reedy added the comment:
Click still causes disappearance with fresh binary on Win10.
--
___
Python tracker
<http://bugs.python.org/issue15786>
___
___
Terry J. Reedy added the comment:
Almost there. Clicking on a list item or the scrollbar works to select an item
or scroll. Clicking outside the box *before* clicking elsewhere works to
dismiss box. Clicking outside the box *after* clicking inside dismisses the
box, but also results in the
Terry J. Reedy added the comment:
Louie> If you run your example in Python with -i, you will see the same
behavior, except for the traceback, as with IDLE.
F:\dev\cpython>python -i -c "x=10; print(x); raise SystemExit"
Running Debug|Win32 interpreter...
10
Traceback (most
Terry J. Reedy added the comment:
Louie, please don't revert header corrections made by a core developer.
I see no mention of binding to press versus release in the original query
issue: #27380. Since the original query code is an edited version of previous
code, I suspect I left the bi
Terry J. Reedy added the comment:
1. I prefer to not deal with ttk styles yet, unless forced, and we don't seem
to be here.
2. Yes, I wanted to get rid of that useless frame as part of refactoring.
3. 'self.x = x = expr' is a semi-common idiom. A local name is nice when ther
Terry J. Reedy added the comment:
Old 2, references; my other main bookmark is the tk reference.
https://www.tcl.tk/man/tcl8.6/TkCmd/contents.htm
It is harder to read at first, but more complete, accurate, and up to date.
Unfortunately, even it does not specify all the OS-specific divergences
Terry J. Reedy added the comment:
A possible counter-indication would be if setting a cell could cause a crash,
as opposed to a mysterious exception. Since 3.x already allows writing any
object to a cell from python code,
def outer():
cell = None
def inner(ob):
nonlocal cell
Terry J. Reedy added the comment:
Santiago, an idea like this (one that requests a reversal of previous
decisions) should be discussed first on the python-ideas list. Such a
discussion would need to result in a specific proposal of what to extract from
test_cmd_line_script.py and where to
Terry J. Reedy added the comment:
Starting longer running tests sooner only make sense if one runs them in
parallel with -jn. I just tried installed 64 bit 3.6.1 with -r -j12 (forgot
-ugui). Total duration: 108 seconds. The last to finish was
test_multiprocessing_spawn after 84 seconds, 5
Terry J. Reedy added the comment:
I believe Rietveld does not work with git-format patches. I don't know if git
can produce the format hg did.
--
nosy: +terry.reedy
___
Python tracker
<http://bugs.python.org/is
Terry J. Reedy added the comment:
Please post or upload minimal code that reproduces the problem for you.
--
nosy: +terry.reedy
___
Python tracker
<http://bugs.python.org/issue30
Terry J. Reedy added the comment:
It is good that you included both a short program and the full traceback. Too
many beginners don't do that when asking questions. Three comments: your
program does not have syntax errors and compiled just fine; exceptions almost
never involved the edito
Terry J. Reedy added the comment:
What problem are you trying to solve with this idea and patch? A popup go to
line box is standard enough for editors that beginners have no problem with it.
That asked, I read the sublime-text doc on the go-anywhere bar. While it is a
cute idea, I think
Terry J. Reedy added the comment:
If the bpo profile allows more than one git account, then please add the second
one.
--
___
Python tracker
<http://bugs.python.org/issue30
Terry J. Reedy added the comment:
New changeset e1a60d903276da10d1ac098e59103f4a72bef08e by terryjreedy
(Mariatta) in branch '3.6':
[3.6] bpo-30303: IDLE: Add _utest argument to textview (GH-1499) (#1916)
https://github.com/python/cpython/commit/e1a60d903276da10d1ac098e59103f
Terry J. Reedy added the comment:
A follow-up to my brief remarks about revamping About IDLE, in msg294298:
idle-dev is subscription-required public forum for discussion of idle design
issues. It has been dormant for a year and a half, but I would like to revive
it to get broader user input
Terry J. Reedy added the comment:
#26413 is about fixing shadowing problem.
Current thought for this issue: add a section to IDLE doc listing known
possible causes (message above). Reference section in message, giving web link.
--
___
Python
Terry J. Reedy added the comment:
Output Window definitely needs a scrollbar available on screens where it cannot
be stretched to 160 chars or so. Thinking about it, if one greps idlelib in a
local install, with a url something like
C:/users/somename/appdata/local/python/lib/idlelib/*.py
Terry J. Reedy added the comment:
Yes, I do want to continue this. As I explained in msg270522, I shelved (but
not abandoned) the autocomplete patch because it caused a test failure I did
not (and do not) understand, and because I found another fix for that issue.
The reductions I noted
Changes by Terry J. Reedy :
--
pull_requests: +2084
___
Python tracker
<http://bugs.python.org/issue30303>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Terry J. Reedy :
--
nosy: +rhettinger
___
Python tracker
<http://bugs.python.org/issue30561>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
There is a lot more wrong with the Windows part:
"On Windows machines, the Python installation is usually placed in
C:\Python36," is no longer true. All-users install is, by default, in Program
Files. Current-user install is, by default, buried
Terry J. Reedy added the comment:
For future reference, small code examples should be including in the message or
uploaded as a .py file.
A unicode string is a sequence of codepoints. The length is defined as the
number of codepoints. I cannot see that your example demonstrates a bug in
Terry J. Reedy added the comment:
Richard, when replying by email, please strip quoted text except for an
occasional line or two. (See example of limited in-context quote below.)
A bug, for the purpose of this tracker, is a discrepancy between between the
docs written by the PSF's
Terry J. Reedy added the comment:
A1: yes, add
if __name__ == '__main__':
import unittest
unittest.main('idlelib.idle_test.test_outwin', verbosity=2, exit=False)
I will have to think about whether and how to add an htest. The grep (find in
files) test actually di
Changes by Terry J. Reedy :
--
pull_requests: +2132
___
Python tracker
<http://bugs.python.org/issue30290>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Terry J. Reedy :
--
pull_requests: +2133
___
Python tracker
<http://bugs.python.org/issue30290>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
New changeset 12cbd87ac0bb826d653040044c6b526dcdb6f6d1 by terryjreedy in branch
'3.6':
[3.6] bpo-30290: IDLE - pep8 names and tests for help-about (#2070)
https://github.com/python/cpython/commit/12cbd87ac0bb826d653040044c6b52
Changes by Terry J. Reedy :
--
pull_requests: +2154
___
Python tracker
<http://bugs.python.org/issue30166>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
New changeset c0ef607c52e58e94693fbedb27f2813bc3fed8fa by terryjreedy in branch
'3.6':
[3.6] bpo-30166: backport pyshell changes (GH 1293) (#2098)
https://github.com/python/cpython/commit/c0ef607c52e58e94693fbedb27f281
Changes by Terry J. Reedy :
--
pull_requests: +2156
___
Python tracker
<http://bugs.python.org/issue30495>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
New changeset f3156f8f5cfb820c7deac05beba9f51ec51c by terryjreedy in branch
'3.6':
bpo-30495: IDLE: Modernize textview.py with docstrings and PEP8 names (#1839)
(#2102)
https://github.com/python/cpython/commit/f3156f8f5cfb820c7deac05beb
Terry J. Reedy added the comment:
I will backport idlelib changes that apply.
--
assignee: -> terry.reedy
nosy: +terry.reedy
versions: +Python 3.6
___
Python tracker
<http://bugs.python.org/issu
Changes by Terry J. Reedy :
--
pull_requests: +2158
___
Python tracker
<http://bugs.python.org/issue29919>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Terry J. Reedy :
--
pull_requests: +2159
___
Python tracker
<http://bugs.python.org/issue30144>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
New changeset c6696feb09a8cf13e13e42ed9cc0b8c2e8795800 by terryjreedy in branch
'3.6':
[3.6] bpo-29919 Remove unused imports from idlelib [GH-137] (#2105)
https://github.com/python/cpython/commit/c6696feb09a8cf13e13e42ed9cc0b8
Changes by Terry J. Reedy :
--
type: -> enhancement
___
Python tracker
<http://bugs.python.org/issue29919>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Terry J. Reedy :
--
pull_requests: +2160
___
Python tracker
<http://bugs.python.org/issue30022>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
New changeset a13225e209cfa5f7b458dbcbac19dc4df26feb95 by terryjreedy in branch
'3.6':
[3.6]bpo-30144: change idlelib abc import [GH-1263] (#2106)
https://github.com/python/cpython/commit/a13225e209cfa5f7b458dbcbac19dc4df26feb95
--
nosy: +t
Changes by Terry J. Reedy :
--
assignee: -> terry.reedy
versions: +Python 3.6
___
Python tracker
<http://bugs.python.org/issue30144>
___
___
Python-bugs-lis
Terry J. Reedy added the comment:
New changeset 59422a29ee3a95866c4f7e037bdfffd5768afddd by terryjreedy in branch
'3.6':
[3.6]bpo-30022: idlelib.run IOError -> OSError [GH-1051] (#2107)
https://github.com/python/cpython/commit/59422a29ee3a95866c4f7e037bd
Changes by Terry J. Reedy :
--
assignee: -> terry.reedy
versions: +Python 3.6
___
Python tracker
<http://bugs.python.org/issue30022>
___
___
Python-bugs-lis
Changes by Terry J. Reedy :
--
pull_requests: +2167
___
Python tracker
<http://bugs.python.org/issue29995>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
New changeset a895f91a46c65a6076e8c6a28af0df1a07ed60a2 by terryjreedy in branch
'3.6':
[3.6]bpo-29995: Adjust IDLE test for 3.7 re.escape change [GH-1007] (#2114)
https://github.com/python/cpython/commit/a895f91a46c65a6076e8c6a28af0df
Changes by Terry J. Reedy :
--
pull_requests: +2169
___
Python tracker
<http://bugs.python.org/issue20185>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
New changeset 57d8de80313c536d409d6a104ae577af8ffc57fb by terryjreedy in branch
'3.6':
[3.6]bpo-20185: Adjust IDLE test to 3.7 Clinic change [GH-542] (#2116)
https://github.com/python/cpython/commit/57d8de80313c536d409d6a104ae577af8ffc57fb
-
Terry J. Reedy added the comment:
Serhiy, please nosy me when you change idlelib files.
--
versions: +Python 3.6
___
Python tracker
<http://bugs.python.org/issue29
Terry J. Reedy added the comment:
This issue, and in part the patch, appears to be a duplicate of #30348. What
am I missing? An issue can have multiple PRs, and one can either replace
another one that is closed or augment one that must be applied first
Terry J. Reedy added the comment:
The installed space for /lib/idlelib it is roughly 2% of the total, depending
on other options. The time saved is, I think, roughly comparable to the extra
time it would take to read and think about another option. So the main issue
would be making '
Change by Terry J. Reedy :
--
keywords: +patch
pull_requests: +12038
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue24310>
___
___
Py
Terry J. Reedy added the comment:
I don't think one 4-years-old anonymous report missing essential details, and
not verified since, is sufficient to drive a doc change, especially since the
Mac installer has switched from recommending ActiveState 8.5.18 to installing
our own compilati
Terry J. Reedy added the comment:
New changeset d610116a2e48b55788b62e11f2e6956af06b3de0 by Terry Jan Reedy in
branch 'master':
bpo-24310: Document IDLE settings dialog font tab sample (GH-12007)
https://github.com/python/cpython/commit/d610116a2e48b55788b62e11f2e695
Change by Terry J. Reedy :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Terry J. Reedy added the comment:
Findfiles was more like os.walk than os.listdir. os.walk now uses os.scandir
instead of os.listdir. From 3.7.2 doc:
"By default, errors from the scandir() call are ignored. If optional argument
onerror is specified, it should be a function; it wi
Terry J. Reedy added the comment:
Current module names, docstring status, and note.
grep - present, some args not doc'ed
replace - spotty; do not repetively doc 'event=None' args
search - ditto
searchbase - present
searchengine - present; do not separately docstring 'isxy
Change by Terry J. Reedy :
--
versions: +Python 3.8 -Python 2.7, Python 3.3, Python 3.4, Python 3.7
___
Python tracker
<https://bugs.python.org/issue1442
Terry J. Reedy added the comment:
Squeezer was added last summer, and definitely helps, but I still intend to
consider other points raised here.
--
___
Python tracker
<https://bugs.python.org/issue1442
Terry J. Reedy added the comment:
The squeezer feature added last summer can be used to copy large output in
Shell to the clipboard. '>>> [None]*1' results in a squeezer label
representing 750 wrapped lines. Note that pasting into a new editor disables
it for awhile
Terry J. Reedy added the comment:
I agree that we should properly document all of the types, even if belately.
A PR is premature until we agree in more detail what 'properly' means. The
most recent patch 'complete-patch...' has multiple errors and needs major
revision,
Terry J. Reedy added the comment:
New changeset 488aabafe2f1c5db05a6c1a7a8b49d7b89b1f36b by Terry Jan Reedy (Miss
Islington (bot)) in branch '3.7':
bpo-36096: IDLE: Refactor class variables in colorizer (GH-12002) (GH-12075)
https://github.com/python/cpyt
Change by Terry J. Reedy :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Terry J. Reedy added the comment:
I am pretty sure I have done the same after making all commits to the local
branch. Plus we have the better workflow. So closing until there is a
confirmed problem with the new workflow.
--
resolution: -> out of date
stage: needs pa
Terry J. Reedy added the comment:
To add to Zach's answer:
Please do not mark issues for IDLE just because you use IDLE to send your code
to Python and display the returned string answer. If in any doubt, rerun the
same code directly with Python either interactively or from the command
Terry J. Reedy added the comment:
Thanks for digging up the history. I would have approved without, but feel
better with. Using the colorizer close method to close a window seemed flakey
to me, and it seems someone else thought the same long ago. I suspect the
machinery was left to avoid
Change by Terry J. Reedy :
--
resolution: -> not a bug
type: enhancement -> behavior
___
Python tracker
<https://bugs.python.org/issue36122>
___
___
Pyth
Terry J. Reedy added the comment:
I suspect that this may not be a cpython issue, in which case, it should be
closed here as 'not-a-bug'. I suggest that you present this on python-list and
ask 'where is the bug most likely to be?' You should get more readers the
Terry J. Reedy added the comment:
Syntax changes need PEPs. By default, syntax changes are rejected. This is
especially true for new keywords, as any acceptible word will already be in
use, and hence its introduction *will* break code.
We are still having issues over having temporarily
Terry J. Reedy added the comment:
I agree. The fact the CPython attempts to optimize all_ascii.translate(table)
is a CPython implementation detail, not a language feature.
--
assignee: -> docs@python
components: +Documentation
nosy: +docs@python, terry.reedy
resolution: ->
Terry J. Reedy added the comment:
New changeset 7eebbbd5b3907447eddadf5cb7cb1cc9230d15b2 by Terry Jan Reedy (Ned
Deily) in branch 'master':
bpo-32129: Avoid blurry IDLE application icon on macOS with Tk 8.6. (GH-12031)
https://github.com/python/cpyt
Terry J. Reedy added the comment:
After patching my 3.7.2 Macbook installation, and reviewing #20406 which added
the icon code, I understand this issue better. IDLE, while open and unlike
other Mac apps I later tested, was replacing the initial Mac IDLE app dock icon
(tilted page with
Terry J. Reedy added the comment:
James Lu today posted to python-ideas
'Make Python 2.7’s online docs optionally redirect to Python 3 online docs'
Andra Roberge: There exists browser extensions that do this:
https://addons.mozilla.org/en-US/firefox/addon/py3direct/
https://chrome.
Change by Terry J. Reedy :
--
pull_requests: +12218
___
Python tracker
<https://bugs.python.org/issue34162>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
New changeset 8a1bab92915dd5c88832706c56af2f5611181d50 by Terry Jan Reedy in
branch 'master':
bpo-34162: Add entries for idlelib/NEWS.txt (#12232)
https://github.com/python/cpython/commit/8a1bab92915dd5c88832706c56af2f
6401 - 6500 of 13135 matches
Mail list logo
