[issue31042] Inconsistency in documentation of operator.index

2017-07-28 Thread Terry J. Reedy
Terry J. Reedy added the comment: To me, 'roughly' is wrong. Either the equivalence is exact, or it is completely absent . There is no 'nearly' or 'roughly' about this situation. This is difference from iterator_class_x(args) being mathematically equivalent to

[issue31045] Add a language switch to the Python documentation

2017-07-28 Thread Terry J. Reedy
Terry J. Reedy added the comment: I left out 2.7 because I don't know if the 2.7 docs have been or will be included. I am looking forward to this because I know someone who programs in Python and is also looking to learn 'professional' Japanese, including CS. I myself

[issue31054] Python 2.7.8 Release does not update the system Path variable

2017-07-28 Thread Terry J. Reedy
Terry J. Reedy added the comment: We are guessing that you are using Windows. The 2.7.8 installer is years old and will not be changed. The same is true for any released installer. I believe that the 2.7 installers already give one the *option* to change the path. If so, this issue should

[issue30781] IDLE: configdialog -- switch to ttk widgets.

2017-07-28 Thread Terry J. Reedy
Terry J. Reedy added the comment: I did not try to match the height in that commit. I wanted to see what would happen if we enlarge the dialog to accommodate more widgets. It is now about 10% larger. The highlight sample looks better with a bit more room. The font sample works better in

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

2017-07-28 Thread Terry J. Reedy
Terry J. Reedy added the comment: I will push Notebook when CI passes. We can then do Step 2 for class FontPage(Frame). Consider the font code frozen for now. Pass 'note', not the dialog, as the parent. This makes tab switching work better. Create the highlight frame first and

[issue30781] IDLE: configdialog -- switch to ttk widgets.

2017-07-28 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset b331f80b4765c3201674a7ca8b35c9d4a65efe79 by Terry Jan Reedy in branch 'master': bpo-30781: IDLE - Use ttk Notebook in ConfigDialog (#2938) https://github.com/python/cpython/commit/b331f80b4765c3201674a7ca8b35c9

[issue30781] IDLE: configdialog -- switch to ttk widgets.

2017-07-28 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +2993 ___ Python tracker <http://bugs.python.org/issue30781> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30781] IDLE: configdialog -- switch to ttk widgets.

2017-07-28 Thread Terry J. Reedy
Terry J. Reedy added the comment: The 'this' in 'this is a usability bug' refers to the fact that up and down move the blue selection highlight but not the selection, so that delete does not necessarily delete what ap

[issue30781] IDLE: configdialog -- switch to ttk widgets.

2017-07-28 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 8364feff6730f54063116b607605167d9027ce85 by Terry Jan Reedy in branch '3.6': [3.6] bpo-30781: IDLE - Use ttk Notebook in ConfigDialog (GH-2938) (#2944) https://github.com/python/cpython/commit/8364feff6730f54063116b60760516

[issue31027] test_listcomps fails when run directly

2017-07-29 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset ceb93f4540981e3f9af66bd936920186aba813fc by Terry Jan Reedy (Zackery Spytz) in branch 'master': bpo-31027: Fix test_listcomps failure when run directly (#2939) https://github.com/python/cpython/commit/ceb93f4540981e3f9af66bd9369201

[issue31027] test_listcomps fails when run directly

2017-07-29 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +2994 ___ Python tracker <http://bugs.python.org/issue31027> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30781] IDLE: configdialog -- switch to ttk widgets.

2017-07-29 Thread Terry J. Reedy
Terry J. Reedy added the comment: I will check for anything even vaguely related. In any case, your comment reminded me to give your PR a boost. Too bad it will miss 3.5. -- ___ Python tracker <http://bugs.python.org/issue30

[issue31027] test_listcomps fails when run directly

2017-07-29 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset b26cc82b2252dd54e73661a026b32e7808fef945 by Terry Jan Reedy in branch '3.6': [3.6] bpo-31027: Fix test_listcomps failure when run directly (GH-2939) (#2945) https://github.com/python/cpython/commit/b26cc82b2252dd54e73661a026b32e

[issue31027] test_listcomps fails when run directly

2017-07-29 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- assignee: -> terry.reedy resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python

[issue30803] Truth value of sets not properly documented

2017-07-29 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset caa1280d1ee5f828f346b585169a7592371d3faa by Terry Jan Reedy (Peter Thomassen) in branch 'master': bpo-30803: clarify truth value testing documentation (#2508) https://github.com/python/cpython/commit/caa1280d1ee5f828f346b585169a75

[issue30803] Truth value of sets not properly documented

2017-07-29 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +2995 ___ Python tracker <http://bugs.python.org/issue30803> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30803] Truth value of sets not properly documented

2017-07-29 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 4c7b368de7bcabdd821059c023c46c9d85668d3f by Terry Jan Reedy in branch '3.6': [3.6] bpo-30803: clarify truth value testing documentation (GH-2508) (#2946) https://github.com/python/cpython/commit/4c7b368de7bcabdd821059c023c46c

[issue30803] Truth value of sets not properly documented

2017-07-29 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- resolution: -> fixed stage: -> resolved ___ Python tracker <http://bugs.python.org/issue30803> ___ ___ Python-bugs-list

[issue30803] Truth value of sets not properly documented

2017-07-29 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- status: open -> closed ___ Python tracker <http://bugs.python.org/issue30803> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

2017-07-29 Thread Terry J. Reedy
Terry J. Reedy added the comment: I am going to work on this now. Tracers should be on for the duration of the test class except for the load test. d = self.page is what I planned initially. Argument note is bound to parameter parent and that will remain the name. The one error I see in

[issue30781] IDLE: configdialog -- switch to ttk widgets.

2017-07-29 Thread Terry J. Reedy
Terry J. Reedy added the comment: I fixed the test problem by selecting the General page in the class setup with d.note.select(3). Then the focus_force to a widget on the page must have worked. -- ___ Python tracker <http://bugs.python.

[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog

2017-07-29 Thread Terry J. Reedy
Terry J. Reedy added the comment: Now that we know what we are doing, we can simplify the steps. These assume that #21004, PR2905, which prepares create_widgets and fixes the GeneralTest that was broken by Notebook, has been merged. For configdialog: * copy general block after FontPage

[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog

2017-07-29 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- dependencies: +IDLE, configdialog: Factor out FontTab class from ConfigDialog ___ Python tracker <http://bugs.python.org/issue31

[issue30928] Copy modified blurbs to idlelib/NEWS.txt

2017-07-29 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +2997 ___ Python tracker <http://bugs.python.org/issue30928> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30928] Copy modified blurbs to idlelib/NEWS.txt

2017-07-30 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset c3aa47f655abe564a2c2fb6d091ab19bdc0113b5 by Terry Jan Reedy in branch 'master': bpo-30928: Update IDLE News.txt. (#2948) https://github.com/python/cpython/commit/c3aa47f655abe564a2c2fb6d091ab1

[issue30928] Copy modified blurbs to idlelib/NEWS.txt

2017-07-30 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +2998 ___ Python tracker <http://bugs.python.org/issue30928> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

2017-07-30 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 9397e2a87ed6e0e724ad71a0c751553620cb775e by Terry Jan Reedy (csabella) in branch 'master': bpo-31004: IDLE: Factor out FontPage class from configdialog (step 1) (#2905) https://github.com/python/cpyt

[issue30928] Copy modified blurbs to idlelib/NEWS.txt

2017-07-30 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset c9c85321df7803137a413d26db41aaa377b13d79 by Terry Jan Reedy in branch '3.6': [3.6] bpo-30928: Update IDLE News.txt. (GH-2948) (#2949) https://github.com/python/cpython/commit/c9c85321df7803137a413d26db41aa

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

2017-07-30 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +2999 ___ Python tracker <http://bugs.python.org/issue31004> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

2017-07-30 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 7582226a92481ca63dedbfe14ef465d1349d66a9 by Terry Jan Reedy in branch '3.6': [3.6] bpo-31004: IDLE: Factor out FontPage class from configdialog (step 1) (GH-2905) (#2950) https://github.com/python/cpyt

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

2017-07-30 Thread Terry J. Reedy
Terry J. Reedy added the comment: At last! On to the next one. -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog

2017-07-30 Thread Terry J. Reedy
Terry J. Reedy added the comment: Above, I left out the last step, "* remove old general block". The old configdialog had an unwritten and undocumented template and rules for pages on the dialog. It went something like the following. # def create_widgets(): * Pick names for the pa

[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog

2017-07-30 Thread Terry J. Reedy
Terry J. Reedy added the comment: I did not refresh this before writing the above. It still applies, including deleting the commented out code once tests pass. See review. Whoops: I forgot that using make_default means that we can (and should) delete the replaced var_changed defs. I added

[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog

2017-07-30 Thread Terry J. Reedy
Terry J. Reedy added the comment: I intentionally left using non-default options other than traversal for a new issue or issues, after we finish ttk replacement. I imagine there will be discussions about choices, and I will invite other participants. I would like to direct visual design

[issue31083] IDLE: document new TabPage(Frame) design for configdialog

2017-07-30 Thread Terry J. Reedy
New submission from Terry J. Reedy: We are in the process of moving blocks of ConfigDialog methods pertaining to one tab page to a separate class. FontPage is more or less done. GenPage is in process. This issue is about documenting the generic structure of the classes in a comment block

[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog

2017-07-30 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset e8eb17b2c11dcd1550a94b175e557c234a804482 by Terry Jan Reedy (csabella) in branch 'master': bpo-31050: IDLE: Factor GenPage class from ConfigDialog (#2952) https://github.com/python/cpython/commit/e8eb17b2c11dcd1550a94b175e557c

[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog

2017-07-30 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +3003 ___ Python tracker <http://bugs.python.org/issue31050> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog

2017-07-30 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 8c4e5be1dfb4d1c74e8cc7ac925e3196818e07ac by Terry Jan Reedy in branch '3.6': [3.6] bpo-31050: IDLE: Factor GenPage class from ConfigDialog (GH-2952) (#2955) https://github.com/python/cpython/commit/8c4e5be1dfb4d1c74e8cc7ac925e31

[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog

2017-07-30 Thread Terry J. Reedy
Terry J. Reedy added the comment: Much easier the 2nd time ;-) -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue31083] IDLE: document new TabPage(Frame) design for configdialog

2017-07-31 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 6f446bee4f6ac0c61bb2c3386a0149fd36855793 by Terry Jan Reedy (csabella) in branch 'master': bpo-31083: IDLE: Describe the Page classes in configdialog (#2965) https://github.com/python/cpython/commit/6f446bee4f6ac0c61bb2c3386a0149

[issue31083] IDLE: document new TabPage(Frame) design for configdialog

2017-07-31 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +3018 ___ Python tracker <http://bugs.python.org/issue31083> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31093] IDLE: Add tests for configdialog extensions tab

2017-07-31 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- assignee: terry.reedy components: IDLE nosy: terry.reedy priority: normal severity: normal stage: needs patch status: open title: IDLE: Add tests for configdialog extensions tab type: enhancement versions: Python 3.6, Python 3.7

[issue31001] IDLE: Add tests for configdialog highlight tab

2017-07-31 Thread Terry J. Reedy
New submission from Terry J. Reedy: Pr2908 originally just sorted highlight methods together, but was extended to sort all methods together and relabeled for #31060. (This actually simplified the diff.) Pr2925, the 3.6 backport, appears on the replacement issue

[issue31083] IDLE: document new TabPage(Frame) design for configdialog

2017-07-31 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 48fcc72c83e1b47b200dd39f9dcc9f62fa0d4d17 by Terry Jan Reedy in branch '3.6': [3.6] bpo-31083: IDLE: Describe the Page classes in configdialog (GH-2965) (#2973) https://github.com/python/cpython/commit/48fcc72c83e1b47b200dd39f9dcc9f

[issue31083] IDLE: document new TabPage(Frame) design for configdialog

2017-07-31 Thread Terry J. Reedy
Terry J. Reedy added the comment: The next blockers are the tests for the other 3 tabs: #31001, #31002, #31093. Steps for converting block of ConfigDialog methods for tab X into a class. Steps are updated from #31050. * In create_widgets, change 'self.create_page_/highlight/keys/exten

[issue31083] IDLE: document new TabPage(Frame) design for configdialog

2017-07-31 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue31051] IDLE, configdialog, General tab: re-arrange, test user entries

2017-08-01 Thread Terry J. Reedy
Terry J. Reedy added the comment: Given that I picked the page names without discussion, as part of quickly writing and merging the switch to Notebook (PR (to unblock the FontPage and GenPage conversion), I considered them subject to possible revision. I expect to review both the internal

[issue31002] IDLE: Add tests for configdialog keys tab

2017-08-01 Thread Terry J. Reedy
Terry J. Reedy added the comment: Great. It is non-trivial, so I don't expect perfection first try. Please revise docstring with explanation of how page works, like with Font and General pages. I finished tests using those explanations as a guide. They are also a guide for r

[issue30928] Copy modified blurbs to idlelib/NEWS.txt

2017-08-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: Next patch should correct bp0-30723. -- ___ Python tracker <http://bugs.python.org/issue30928> ___ ___ Python-bugs-list mailin

[issue19903] Idle: Use inspect.signature for calltips

2017-08-03 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- stage: test needed -> commit review ___ Python tracker <http://bugs.python.org/issue19903> ___ ___ Python-bugs-list mai

[issue29910] Ctrl-D eats a character on IDLE

2017-08-03 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +3034 ___ Python tracker <http://bugs.python.org/issue29910> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29910] Ctrl-D eats a character on IDLE

2017-08-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: Adding 'break' to parenmatch.paren_closed_event prevented ')' from closing calltips. Removing it reverts the regression. I am leaving this open to re-review the other optional changes to see if ')' is unique or if anything else

[issue31082] reduce takes iterable, not just sequence

2017-08-04 Thread Terry J. Reedy
Terry J. Reedy added the comment: Serhiy, given that the parameters of reduce are currently positional only (by experiment, it has not gotten the C.A. treatment yet), can 'sequence' in the signature in the docstring be changes to 'iterable'? -- nosy: +serhiy.st

[issue31097] itertools.islice not accepting np.int64

2017-08-04 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Using PyNumber_AsSsize_t in itertools.islice type: crash -> behavior ___ Python tracker <http://bugs.pyt

[issue31097] itertools.islice not accepting np.int64

2017-08-04 Thread Terry J. Reedy
Terry J. Reedy added the comment: LB, an exception is a graceful shutdown, not a crash. A crash is a seg fault, core dump, or an OS message 'Your app has stopped unexpectedly'. In #30537, the exception was regarded as expected, not a bug, and changing islice to accept np ints was r

[issue31100] unable to open python on Windows

2017-08-04 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware title: unable to open python -> unable to open python on Windows ___ Python tracker <http://bugs.python.org/issu

[issue31108] add __contains__ for list_iterator (and others) for better performance

2017-08-04 Thread Terry J. Reedy
Terry J. Reedy added the comment: On my particular Win 10 machine with 3.6, the times are 1.52 and 2.14. But to me, the times are irrelevant. A performance enhancement, by definition, should not change computational results, but this does. If an iterator is a standard iterator, then '

[issue31113] Stack overflow with large program

2017-08-04 Thread Terry J. Reedy
Terry J. Reedy added the comment: We know that compile has undocumented size limits of various sorts that are usually more than sufficient for normal human written code but which can be overwhelmed by machine-generated code. We do not regard this as a bug. However, 20 levels of if-nesting

[issue31108] add __contains__ for list_iterator (and others) for better performance

2017-08-04 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- Removed message: http://bugs.python.org/msg299770 ___ Python tracker <http://bugs.python.org/issue31108> ___ ___ Python-bugs-list m

[issue31108] add __contains__ for list_iterator (and others) for better performance

2017-08-04 Thread Terry J. Reedy
Terry J. Reedy added the comment: Sorry, I mistakenly assumed, without carefully checking the C code, that the speedup was from checking the underlying collection, without advancing the iterator. I presume that " ++it->it_index;" is the statement to the contrary. I should have

[issue27755] Retire DynOptionMenu with a ttk Combobox

2017-08-06 Thread Terry J. Reedy
Terry J. Reedy added the comment: Yes, if nothing else, we can use ttk.OptionMenu. #24776 is about the font tab specifically, including possibly using a spinbox for font size. #24781 is about Highlights tab. Whatever we do with theme selection we will probably copy for keyset selection

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

2017-08-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: Idlelib is a bit exceptional: see PEP 434. Except for one test and the news files, I keep idlelib identical in 3.6 and 3.7. This makes all backports, *including new tests*, trivial and overall reduces the risk of regression (unless IDLE 3.6 were abandoned

[issue31130] test_idle: idlelib.configdialog leaks references

2017-08-07 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +3049 ___ Python tracker <http://bugs.python.org/issue31130> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29910] Ctrl-D eats a character on IDLE

2017-08-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 89225871d314fa675ea9ac292e7bc75320f1aef5 by Terry Jan Reedy in branch 'master': bpo-29910: IDLE - revert `break`s that disabled calltip close. (#2997) https://github.com/python/cpython/commit/89225871d314fa675ea9ac292e7bc7

[issue29910] Ctrl-D eats a character on IDLE

2017-08-07 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +3050 ___ Python tracker <http://bugs.python.org/issue29910> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30642] Fix leaks in idlelib

2017-08-07 Thread Terry J. Reedy
Changes by Terry J. Reedy : Removed file: http://bugs.python.org/file46948/findleak.py ___ Python tracker <http://bugs.python.org/issue30642> ___ ___ Python-bugs-list m

[issue30642] Fix leaks in idlelib

2017-08-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: Unlinked old findleak.py after uploading much improved version to #31130. -- ___ Python tracker <http://bugs.python.org/issue30

[issue31130] test_idle: idlelib.configdialog leaks references

2017-08-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: Attached is an improved idlelib.idle_test.test_* leak checker that uses the --match option. -- assignee: -> terry.reedy components: +IDLE, Tests nosy: +terry.reedy Added file: http://bugs.python.org/file47059/findleak

[issue31130] test_idle: idlelib.configdialog leaks references

2017-08-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 733d0f63c562090a2b840859b96028d6ec0a4803 by Terry Jan Reedy in branch 'master': bpo-31130: IDLE -- stop leaks in test_configdialog. (#3016) https://github.com/python/cpython/commit/733d0f63c562090a2b840859b96028

[issue29910] Ctrl-D eats a character on IDLE

2017-08-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset b61de2d46596ac00dcf2d33bbce2023d0bf4207b by Terry Jan Reedy in branch '3.6': [3.6] bpo-29910: IDLE - revert `break`s that disabled calltip close. (GH-2997) (#3017) https://github.com/python/cpython/commit/b61de2d46596ac00dcf2d33bbce202

[issue31130] test_idle: idlelib.configdialog leaks references

2017-08-07 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +3051 ___ Python tracker <http://bugs.python.org/issue31130> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31130] test_idle: idlelib.configdialog leaks references

2017-08-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 9d7d928b5853b921ed27f1e535dfe8174169854c by Terry Jan Reedy in branch '3.6': [3.6] bpo-31130: IDLE -- stop leaks in test_configdialog. (GH-3016) (#3018) https://github.com/python/cpython/commit/9d7d928b5853b921ed27f1e535dfe8

[issue31130] test_idle: idlelib.configdialog leaks references

2017-08-07 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue31130> ___ ___

[issue31142] python shell crashed while input quotes in print()

2017-08-09 Thread Terry J. Reedy
Terry J. Reedy added the comment: There is still something you left out. Entering either print(") or print(') at either a shell prompt or in a file and running the file should result in "SyntaxError: EOL while scanning string literal", as Steven said. Ditto for eval

[issue19903] Idle: Use inspect.signature for calltips

2017-08-09 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +3086 ___ Python tracker <http://bugs.python.org/issue19903> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19903] Idle: Use inspect.signature for calltips

2017-08-09 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 646f6c3096abfe5bde13f039ebf32bce5baf083a by Terry Jan Reedy in branch '3.6': [3.6] bpo-19903: IDLE: Calltips changed to use inspect.signature (GH-2822) (#3053) https://github.com/python/cpython/commit/646f6c3096abfe5bde13f039ebf32b

[issue31142] python shell crashed while input quotes in print()

2017-08-09 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- assignee: terry.reedy -> ___ Python tracker <http://bugs.python.org/issue31142> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue19903] Idle: Use inspect.signature for calltips

2017-08-09 Thread Terry J. Reedy
Terry J. Reedy added the comment: Although my freshly opened window says PR2822 is open, it was merged with https://github.com/python/cpython/commit/3b0f620c1a2a21272a9e2aeca6ca1d1ac10f8162 4 hours ago, and then backported. Louie, thanks for the patch and the persistence

[issue19903] Idle: Use inspect.signature for calltips

2017-08-09 Thread Terry J. Reedy
Terry J. Reedy added the comment: This issue is about IDLE getting further out of the business of calculating signatures and depending instead on the newest (and tested) inspect function. In 2012, the blogger used getargspec, which was deprecated for 3.x a few years before, in 3.0. I suspect

[issue19903] Idle: Use inspect.signature for calltips

2017-08-09 Thread Terry J. Reedy
Terry J. Reedy added the comment: This is much clearer. What you got is a limitation of getfullargspec relative to signature (see the links). In this case, you want follow_wrapped=True, to get the specific signature of the wrapped function instead of the generic signature of the wrapper

[issue31168] IDLE hangs with absurdly long __repr__s

2017-08-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: I am quite aware that tk text widgets (and probably other widgets) have line-length limitations. Which issue this duplicates depends on what action you propose. #28840 proposes addressing limits in the docs. #1442493 is about code changes

[issue31002] IDLE: Add tests for configdialog keys tab

2017-08-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: I am not sure I agree with all your suggested name changes. But I am looking as more substantive issues first. -- ___ Python tracker <http://bugs.python.org/issue31

[issue31130] test_idle: idlelib.configdialog leaks references

2017-08-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: Victor: Something seems to have changed in the last few days. When I merged, both specific classes python -m test -R 3:3 -u gui -v test_idle -m idlelib.idle_test.test_configdialog.FontPageTest.* and the module as a whole passed. python -m test -R 3:3 -u gui

[issue31002] IDLE: Add tests for configdialog keys tab

2017-08-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: I have thought about factoring out common test code into helper functions either within test_configdialog or in a new module. One example: simulate a click on a listbox, with common before and after code. Another: Testing the group of selection widgets on

[issue31130] test_idle: idlelib.configdialog leaks references

2017-08-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: My message was most a heads-up. As I said, I only get the 1 block leak with a micro test of a class or method. It is possible that even that is Windows-specific. As long as you only care that test_idle not leak, I don't care about this e

[issue1612262] Class Browser doesn't show internal classes

2017-08-14 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- dependencies: +IDLE: add docstrings to browser.py stage: test needed -> patch review ___ Python tracker <http://bugs.python.org/issue1

[issue31205] IDLE, configdialog: Factor out KeysPage class from ConfigDialog

2017-08-14 Thread Terry J. Reedy
New submission from Terry J. Reedy: Do as did with #31050 and GenPage class. This should be done *before* #31001, highlights test. -- assignee: terry.reedy components: IDLE messages: 300273 nosy: terry.reedy priority: normal severity: normal stage: test needed status: open title: IDLE

[issue31002] IDLE: Add tests for configdialog keys tab

2017-08-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 2f8964634918bdf09107c49a2d5ca62460091e54 by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-31002: IDLE: Add tests for configdialog keys tab (#2996) https://github.com/python/cpython/commit/2f8964634918bdf09107c49a2d5ca6

[issue31002] IDLE: Add tests for configdialog keys tab

2017-08-14 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +3132 ___ Python tracker <http://bugs.python.org/issue31002> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31205] IDLE, configdialog: Factor out KeysPage class from ConfigDialog

2017-08-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: Let me know if you start on this. -- nosy: +csabella ___ Python tracker <http://bugs.python.org/issue31205> ___ ___ Python-bug

[issue31001] IDLE: Add tests for configdialog highlight tab

2017-08-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: If we do the same renamings for the theme selection vars and functions as done for keys selection on the keys tab, then the corresponding tests can be copied and slightly altered. However, duplicate names require that KeyPage be separated first. Hence the

[issue31002] IDLE: Add tests for configdialog keys tab

2017-08-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset a31459008c5b3230363d155a2e8616664dc4f0c6 by Terry Jan Reedy in branch '3.6': [3.6] bpo-31002: IDLE: Add tests for configdialog keys tab (GH-2996) (#3092) https://github.com/python/cpython/commit/a31459008c5b3230363d155a2e8616

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

2017-08-14 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- dependencies: +IDLE: Add tests for configdialog highlight tab ___ Python tracker <http://bugs.python.org/issue31206> ___ ___ Pytho

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

2017-08-14 Thread Terry J. Reedy
New submission from Terry J. Reedy: As with #31050, #31205 -- assignee: terry.reedy components: IDLE messages: 300278 nosy: csabella, terry.reedy priority: normal severity: normal stage: test needed status: open title: IDLE, configdialog: Factor out HighPage class from ConfigDialog type

[issue31207] IDLE, configdialog: Factor out ExtPage class from ConfigDialog

2017-08-14 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- assignee: terry.reedy components: IDLE nosy: terry.reedy priority: normal severity: normal stage: test needed status: open title: IDLE, configdialog: Factor out ExtPage class from ConfigDialog versions: Python 3.6, Python 3.7

[issue31207] IDLE, configdialog: Factor out ExtPage class from ConfigDialog

2017-08-14 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- dependencies: +IDLE: Add tests for configdialog extensions tab ___ Python tracker <http://bugs.python.org/issue31207> ___ ___ Pytho

[issue31093] IDLE: Add tests for configdialog extensions tab

2017-08-14 Thread Terry J. Reedy
New submission from Terry J. Reedy: It is not clear what will be left after #27099 -- ___ Python tracker <http://bugs.python.org/issue31093> ___ ___ Python-bug

[issue31002] IDLE: Add tests for configdialog keys tab

2017-08-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: Great work. Thank you. Next: #31205, #31001, #31206, then ... -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue31002] IDLE: Add tests for configdialog keys tab

2017-08-15 Thread Terry J. Reedy
Terry J. Reedy added the comment: Lines not yet covered in keys group, other than deactivate_current_config and activate_config_changes functions: def save_new_key_set if not idleConf.userCfg['keys'].has_section(keyset_name): # never false - minor issue def delete_custom_keys

[issue31205] IDLE, configdialog: Factor out KeysPage class from ConfigDialog

2017-08-15 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset e36d9f5568093b3885da62a0bf0fdfbe3771672b by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-31205: IDLE: Factor KeysPage class from ConfigDialog (#3096) https://github.com/python/cpython/commit/e36d9f5568093b3885da62a0bf0fdf

<    51   52   53   54   55   56   57   58   59   60   >