Changes by Terry J. Reedy :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Terry J. Reedy :
--
pull_requests: +2844
___
Python tracker
<http://bugs.python.org/issue30981>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
New changeset d0969d69245d9c4eea3498ba4bde4b4cd676ad7f by Terry Jan Reedy in
branch 'master':
bpo-30981: IDLE -- Add more configdialog font page tests. (#2794)
https://github.com/python/cpython/commit/d0969d69245d9c4eea3498ba4bde4b
Changes by Terry J. Reedy :
--
pull_requests: +2846
___
Python tracker
<http://bugs.python.org/issue30981>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
I left out gui event tests since they depends on the widgets, which will likely
change. I though about tests for the uncovered load_font_config and
load_tab_config, but am not sure what to do that would not amount to copying
their code
Terry J. Reedy added the comment:
Viktor, I am aware that there are errors in the patch I pushed that will result
in error on the Windows machines that run gui tests. Am working on a fix now.
--
nosy: +haypo
___
Python tracker
<h
Changes by Terry J. Reedy :
--
pull_requests: +2848
___
Python tracker
<http://bugs.python.org/issue30981>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
I am too tired to fix this correctly right now, so I added @skip to class with
failing tests.
--
___
Python tracker
<http://bugs.python.org/issue30
Terry J. Reedy added the comment:
New changeset 7c5798ebfa9b822d6cedf1fc8c034f6ea90644dc by Terry Jan Reedy in
branch 'master':
bpo-30981: temporarity skip failing IDLE test class (#2798)
https://github.com/python/cpython/commit/7c5798ebfa9b822d6cedf1fc8c034f
Changes by Terry J. Reedy :
--
pull_requests: +2861
___
Python tracker
<http://bugs.python.org/issue30981>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
New changeset 616ecf18f3aacbd8d172e01673877b22fe946e54 by Terry Jan Reedy in
branch 'master':
bpo-30981: IDLE: Augment one configdialog font page test (#2810)
https://github.com/python/cpython/commit/616ecf18f3aacbd8d172e01673877b
Terry J. Reedy added the comment:
New changeset 04864b491e3ce0f022e918ad344fb53a99ce2a1b by Terry Jan Reedy in
branch '3.6':
[3.6] bpo-30981: IDLE -- Add more configdialog font page tests. (GH-… (#2796)
https://github.com/python/cpython/commit/04864b491e3ce0f022e918ad344fb5
Changes by Terry J. Reedy :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
title: IDLE: Add config dialog font page tests -> IDLE: Test config dialog font
bold button and sample change
___
Python tr
Terry J. Reedy added the comment:
With the patch, I still see the Creating ... messages but without the LINK:
warning. It *seems* like a no-brainer to apply the patch.
With those gone, it would seem reasonable to intercept the message as Steve
described and only print it if it contains
New submission from Terry J. Reedy:
This follows #30981 and the comments on PR 2805 after the close notice.
* Causal chains in a directed acyclic graph link user actions to provisional
entries in changes and and changes in the example displays. Explain these
better in the docstring. Each font
Changes by Terry J. Reedy :
--
dependencies: +IDLE: Document and fix configdialog font tests.
___
Python tracker
<http://bugs.python.org/issue30780>
___
___
Pytho
Terry J. Reedy added the comment:
Followup issue is #30993.
--
nosy: -haypo
___
Python tracker
<http://bugs.python.org/issue30981>
___
___
Python-bugs-list mailin
Terry J. Reedy added the comment:
Patch ready for test on linux and review.
--
nosy: +csabella, louielu
___
Python tracker
<http://bugs.python.org/issue30
Changes by Terry J. Reedy :
--
pull_requests: +2871
___
Python tracker
<http://bugs.python.org/issue30993>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
I am thinking that the tab title should be 'Font/Indent' rather than
'Font/Tabs' to avoid the confusion between the simulated file-folder tab that
we click on and the tab key that indents. Opinions?
But maybe the indent widget will be mo
Terry J. Reedy added the comment:
This issue is really about managing the set of var,callback pairs. The idea of
wrapping vars just clouded the issue.
class VarTrace:
def __init__(self):
self.tracers = [] # or set if need to delete
def add(self, var, callback):
if
Terry J. Reedy added the comment:
Yes, test_font_set could be split up. But then the setup would have to be
repeated for each, and it would be harder to verify that each .set() call was
being tested the same way.
The event graph for indent_scale is a simple linear chain, and the simple
Terry J. Reedy added the comment:
New changeset 07ba305a4c169e017e076e490a173a6f9b95b38e by Terry Jan Reedy in
branch 'master':
bpo-30993: IDLE - Improve configdialog font page and tests. (#2818)
https://github.com/python/cpython/commit/07ba305a4c169e017e076e490a173a
Changes by Terry J. Reedy :
--
pull_requests: +2878
___
Python tracker
<http://bugs.python.org/issue30993>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
A big issue with changing to tagging individual elements is back compatibility.
Besides which, if the font is not bold, I cannot imaging bolding anything
other than the definition names. This also seems to venture beyond 'keep IDLE
simple for begi
Terry J. Reedy added the comment:
New changeset 5aa3bf041de5ee90ccbfcff103dcf3e54c5af237 by Terry Jan Reedy in
branch '3.6':
[3.6] bpo-30993: IDLE - Improve configdialog font page and tests. (GH-2818)
(#2826)
https://github.com/python/cpython/commit/5aa3bf041de5ee90ccbfcff103dcf3
Changes by Terry J. Reedy :
--
pull_requests: +2880
___
Python tracker
<http://bugs.python.org/issue30993>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
2nd and presumably last PR for this issue: please verify on linux.
--
stage: needs patch -> patch review
title: IDLE: Document and fix configdialog font tests. -> IDLE: Document, fix,
and complete configdialog font
Terry J. Reedy added the comment:
New changeset 77e97ca9ff6f3dbbf98b89b4103c46b43eef5642 by Terry Jan Reedy in
branch 'master':
bpo-30993: IDLE - Improve configdialog font page and tests. (#2831)
https://github.com/python/cpython/commit/77e97ca9ff6f3dbbf98b89b4103c46
Changes by Terry J. Reedy :
--
pull_requests: +2881
___
Python tracker
<http://bugs.python.org/issue30993>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
Ned, in a comment on PR2826, Louie reported "The patch unittest work on Linux,
but on MacOS, I get test.support.ResourceDeined: cannot run without OS X gui
process, it is wierd, I'm inside the GUI mode.
Also, I'm not sure if this only on
Terry J. Reedy added the comment:
Step 1 is to add the class and then add tests. The tests can use artificial
examples. Say 3 vars, 2 callbacks, with the 3rd done as default. I want to
start this now -- see below. Let me know if you start working on this so we
don't duplicate work
Terry J. Reedy added the comment:
New changeset 1daeb259799d0664c9453a3bd8e80411e65b52c9 by Terry Jan Reedy in
branch '3.6':
[3.6] bpo-30993: IDLE - Improve configdialog font page and tests. (GH-2831)
(#2834)
https://github.com/python/cpython/commit/1daeb259799d0664c9453a3bd8e804
Changes by Terry J. Reedy :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Terry J. Reedy :
--
assignee: terry.reedy
components: IDLE
nosy: terry.reedy
priority: normal
severity: normal
stage: needs patch
status: open
title: IDLE: Add tests for configdialog highlight tab
type: enhancement
versions: Python 3.6, Python 3.7
Changes by Terry J. Reedy :
--
assignee: terry.reedy
components: IDLE
nosy: terry.reedy
priority: normal
severity: normal
stage: needs patch
status: open
title: IDLE: Add tests for configdialog keys tab
type: enhancement
versions: Python 3.6, Python 3.7
Changes by Terry J. Reedy :
--
assignee: terry.reedy
components: IDLE
nosy: terry.reedy
priority: normal
severity: normal
stage: needs patch
status: open
title: IDLE: Add tests for help sources on configdialog general tab
type: enhancement
versions: Python 3.6, Python 3.7
New submission from Terry J. Reedy:
I want to follow the safe way to refactor (from a blog post), rather than the
hacker way of refactoring 'in place'.
Step 0: Test code to be refactored. Finished in 30993.
Step 1: Copy code to be refactored and modify as needed to isolate i
Changes by Terry J. Reedy :
--
dependencies: +IDLE: Add tests for configdialog highlight tab, IDLE: Add tests
for configdialog keys tab, IDLE: Add tests for help sources on configdialog
general tab
___
Python tracker
<http://bugs.python.
Terry J. Reedy added the comment:
I am still thinking about how to handle user customization of key defs and
values.
The current extensions tab does not enable custom key defs, so that would be a
new feature, and hence could be handled separately, and normally. I have not
yet looked at the
Changes by Terry J. Reedy :
--
dependencies: -test_bsddb3 crash on x86 Windows XP 2.7
___
Python tracker
<http://bugs.python.org/issue30728>
___
___
Python-bug
Terry J. Reedy added the comment:
Since Mike has not responded in more that a week, please go ahead. Just put
"“Original patch by Mike Short." in the commit comments (if you can, otherwise
add a separate comment). Please add News blurb (see devguide) if you know how,
with at lea
Terry J. Reedy added the comment:
I am going to continue with the tests.
--
___
Python tracker
<http://bugs.python.org/issue30853>
___
___
Python-bugs-list mailin
Terry J. Reedy added the comment:
'Clean break' is easy to say. I won't decide yet. Other opinions? I think I
will post to idle-dev also. Even if no one responds, there will have been the
chance.
--
___
Python tracker
<http
New submission from Terry J. Reedy:
https://docs.python.org/3/faq/programming.html#why-does-22-10-return-3
"Why does -22 // 10 return -3?
It’s primarily driven by the desire that i % j have the same sign as j. If you
want that, and also want:
i == (i // j) * j + (i % j)
then integer div
Terry J. Reedy added the comment:
You must demonstrate that there is a problem with 3.6 or 3.7 and then write a
patch that fixes the problem in those versions.
--
nosy: +terry.reedy
___
Python tracker
<http://bugs.python.org/issue30
New submission from Terry J. Reedy:
Bugs discovered while testing for tests; fix in followup that also streamlines
layout.
Size vars are StringVars and write text strings that give invalid warning when
read. Use IntVars and enforce minimum at least 1? Test what tk allows. Will
IntVar
Changes by Terry J. Reedy :
--
pull_requests: +2910
___
Python tracker
<http://bugs.python.org/issue31003>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
The test added in the PR passes on linux (Travis) and Mac (op's machine), fails
on Windows (Appveyor). The patch itself modifies abstract.c. Could some
Windows expert take a look?
test_string_with_stream_redirection (test.test_print.TestPy2Migratio
Terry J. Reedy added the comment:
There is a reason that I said, in msg266221, that I would experiment with
moving 1 feature ;-). I knew from past experience that changing anything that
affected user configuration would have to consider the effect on previous
releases. A total 'clean
Terry J. Reedy added the comment:
As I read 583, they are planning to fuzz 3.6. Why not branch master? I think
it more likely that we accidentally add a vulnerability to master then that we
accidentally close one.
--
___
Python tracker
<h
Terry J. Reedy added the comment:
PR ready for test and review.
--
nosy: +csabella, louielu
___
Python tracker
<http://bugs.python.org/issue31003>
___
___
Pytho
Changes by Terry J. Reedy :
--
dependencies: +IDLE: configdialog -- factor out Tracer subclass
___
Python tracker
<http://bugs.python.org/issue31004>
___
___
Pytho
Changes by Terry J. Reedy :
--
nosy: +csabella
___
Python tracker
<http://bugs.python.org/issue31004>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Terry J. Reedy:
Followup to 31003, tests, and 30853, tracers, similar to 31004, FontTab.
After creating new class, we can change names without worry about clashing with
names elsewhere in ConfigDialog.
--
messages: 299259
nosy: csabella, terry.reedy
priority
Changes by Terry J. Reedy :
--
assignee: -> terry.reedy
components: +IDLE
stage: -> needs patch
type: -> enhancement
versions: +Python 3.6, Python 3.7
___
Python tracker
<http://bugs.python.or
New submission from Terry J. Reedy:
Fix bugs and enhance the page.
The three little frames are too much, and in the wrong order. Proposal:
Window to open at startup: O Shell O Editor
Initial size:Width [_] Height []
When run code in editor: ... (see bpo-19042 for
Terry J. Reedy added the comment:
In comment for 31003, Cheryl pointed to
https://stackoverflow.com/questions/4140437/interactively-validating-entry-widget-content-in-tkinter#4140988
That prompted me to grep for 'validatecommand'. "validatecommand=is_int" is
used on the
Terry J. Reedy added the comment:
In 31003, Cheryl pointed out that loading helplist could use enumerate.
https://github.com/python/cpython/pull/2859#pullrequestreview-52461722
--
___
Python tracker
<http://bugs.python.org/issue31
Terry J. Reedy added the comment:
Common code in tests: test_helplist_item_actions functions have common code
that could be factored out into a non-test_ method (especially if settings not
needed for one of them is added, like setting anchor).
The listbox simulated click code in
Terry J. Reedy added the comment:
Coverage up to 63%. Will update on another issue as update here will require
another CI round.
--
___
Python tracker
<http://bugs.python.org/issue31
Terry J. Reedy added the comment:
New changeset 45bf723c6c591ec56a18dad8150ae89797450d8b by Terry Jan Reedy
(csabella) in branch 'master':
bpo-30853: IDLE: Factor a VarTrace class from configdialog.ConfigDialog.
(#2872)
https://github.com/python/cpyt
Changes by Terry J. Reedy :
--
pull_requests: +2954
___
Python tracker
<http://bugs.python.org/issue30853>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
I will include new blurb with PR that uses this with font vars. I might do
this tonight.
Test coverage of class is 100%.
--
stage: test needed -> needs patch
versions: +Python 3.6, Python 3.7
___
Python trac
Terry J. Reedy added the comment:
New changeset 0243bea55dc340067247e635442f2a227705315a by Terry Jan Reedy in
branch '3.6':
[3.6] bpo-30853: IDLE: Factor a VarTrace class from configdialog.ConfigDialog.
(GH-2872) (#2903)
https://github.com/python/cpyt
Terry J. Reedy added the comment:
New changeset 2bc8f0e6867f59e5e8444b2bde99bb0fa3dbefc8 by Terry Jan Reedy in
branch 'master':
bpo-31003: IDLE - Add more tests for General tab (#2859)
https://github.com/python/cpython/commit/2bc8f0e6867f59e5e8444b2bde99bb
Changes by Terry J. Reedy :
--
pull_requests: +2957
___
Python tracker
<http://bugs.python.org/issue31003>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
Go ahead. If it works with font, add general tab.
CD.remove_var_callbacks is currently only called in
test_configdialog.tearDownModule. I added the call to prevent getting a
TclError for each callback after the test finished. .destroy does not destroy
Terry J. Reedy added the comment:
New changeset 0c4c65104c951c70f3a2a2fd1a45bdf6540f3a8e by Terry Jan Reedy in
branch '3.6':
[3.6] bpo-31003: IDLE - Add more tests for General tab (GH-2859) (#2906)
https://github.com/python/cpython/commit/0c4c65104c951c70f3a2a2fd1a45bd
Changes by Terry J. Reedy :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Terry J. Reedy :
--
Removed message: http://bugs.python.org/msg299269
___
Python tracker
<http://bugs.python.org/issue31003>
___
___
Python-bugs-list m
Terry J. Reedy added the comment:
See in you can install blurb into 3.6 or even 3.5, (pip should work) and run it
to add the blurb file. I will fill in the body.
--
___
Python tracker
<http://bugs.python.org/issue30
Changes by Terry J. Reedy :
--
pull_requests: +2959
___
Python tracker
<http://bugs.python.org/issue31001>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Terry J. Reedy:
Finish rearranging the methods of configdialog.ConfigDialog to group together
methods pertaining to each tab and the button block. Doing so has and will
help in writing tests. It is also preparation for splitting ConfigDialog,
which currently has more
Changes by Terry J. Reedy :
--
pull_requests: +2974
___
Python tracker
<http://bugs.python.org/issue31060>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
After finishing the patch, I expect that the highlight and keys groups will
need some changes.
--
title: IDLE: Finish rearranging ConfigDialog methods -> IDLE: Finish regrouping
ConfigDialog methods
___
Pyt
Terry J. Reedy added the comment:
New changeset b1660800f4f519dbfab9e5a4ad3eae1cfabab3ed by Terry Jan Reedy in
branch 'master':
bpo-31060: IDLE: Finish regrouping ConfigDialog methods (#2908)
https://github.com/python/cpython/commit/b1660800f4f519dbfab9e5a4ad3eae
Changes by Terry J. Reedy :
--
pull_requests: +2976
___
Python tracker
<http://bugs.python.org/issue31060>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
New changeset 2cbb6733bfe54e87622a6372f83b73bddf3c4078 by Terry Jan Reedy in
branch '3.6':
[3.6] bpo-31060: IDLE: Finish regrouping ConfigDialog methods (GH-2908) (#2925)
https://github.com/python/cpython/commit/2cbb6733bfe54e87622a6372f83b73
Changes by Terry J. Reedy :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Terry J. Reedy added the comment:
A minor change. Complete the path by adding the other var-trace pairs and
after checking carefully, I will be ready to push.
I prefer one easy to remember short-name function to two longer-named
functions. However, the docstring should specify the tuple as
Terry J. Reedy added the comment:
I may have changed the Font group since the copy was made. So unless merges
since are carefully checked, the configdialog part of Step 1 should be redone.
I think the latter would be easier.
Since #30853 might be merged tomorrow, I will 'freeze'
Terry J. Reedy added the comment:
For steps 2 and 3, setUpClass will have to create or retrieve a reverence to
the page class instance. For page functions, 'dialog' will have to be changed
to 'self.page'. For hightlight and key pages, I will write the tests using
Terry J. Reedy added the comment:
New changeset 5b59154c0d3d91c0766b9177f6b737b1abcbf3f6 by Terry Jan Reedy
(csabella) in branch 'master':
bpo-30853: IDLE: Convert font and general vars to use VarTrace (#2914)
https://github.com/python/cpython/commit/5b59154c0d3d91c0766b9177f6b737
Changes by Terry J. Reedy :
--
pull_requests: +2987
___
Python tracker
<http://bugs.python.org/issue30853>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Terry J. Reedy :
--
pull_requests: +2988
___
Python tracker
<http://bugs.python.org/issue30853>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
New changeset 02f88d2a411a6a789b33be281adfc3570c49efd5 by Terry Jan Reedy in
branch '3.6':
[3.6] bpo-30853: IDLE: Convert font and general vars to use VarTrace (GH-2914)
(#2935)
https://github.com/python/cpython/commit/02f88d2a411a6a789b33be281adfc3
Terry J. Reedy added the comment:
When replying by email, snip the quote.
--
___
Python tracker
<http://bugs.python.org/issue31004>
___
___
Python-bugs-list mailin
Terry J. Reedy added the comment:
IDLE *will* fail if idleConf.SetOption is called with a wrong config-type
(KeyError) or the wrong number of other arguments (TypeError). I did not add
the check because it does not cover the non-default callbacks (the majority),
let alone all the other
Terry J. Reedy added the comment:
New changeset 5d0f30aae5fccc99690923fc5c7cb58de8ad7eec by Terry Jan Reedy in
branch 'master':
bpo-30853: IDLE - touch-up configdialog.VarTrace and tests. (#2936)
https://github.com/python/cpython/commit/5d0f30aae5fccc99690923fc5c7cb5
Changes by Terry J. Reedy :
--
pull_requests: +2989
___
Python tracker
<http://bugs.python.org/issue30853>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
New changeset ecc80b3f1b56f1e4df9e592f8527e622a6b45e01 by Terry Jan Reedy in
branch '3.6':
[3.6] bpo-30853: IDLE - touch-up configdialog.VarTrace and tests. (GH-2936)
(#2937)
https://github.com/python/cpython/commit/ecc80b3f1b56f1e4df9e592f8527e6
Changes by Terry J. Reedy :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Terry J. Reedy :
--
title: IDLE: configdialog -- factor out Tracer subclass -> IDLE: configdialog
-- factor out VarTrace class
___
Python tracker
<http://bugs.python.org/issu
Changes by Terry J. Reedy :
--
pull_requests: +2990
___
Python tracker
<http://bugs.python.org/issue30781>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
New PR replaces the custom TabbedPageSet with ttk.Notebook. On Windows, with
default settings, the look is nearly identical, but the selected tab is more
obvious. A method call (note.enable_traversal) will enable navigation between
tabs with cntl-tab and
Changes by Terry J. Reedy :
--
nosy: +bethard
___
Python tracker
<http://bugs.python.org/issue28734>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
OK on Windows, skipping test_whichdb_ndbm (neither _dbm nor _gdbm are present.)
--
nosy: +terry.reedy
___
Python tracker
<http://bugs.python.org/issue31
Terry J. Reedy added the comment:
On Windows, fresh 3.7, python -m test.test_listcomps fails same way.
python -m test test_listcomps is okay.
--
nosy: +terry.reedy
___
Python tracker
<http://bugs.python.org/issue31
Terry J. Reedy added the comment:
On Windows, sys.executable is normalized before or during startup.
C:\Programs\Python36>Lib\..\python -m test test_sys prints
test_executable (__main__.SysModuleTest) ... ok
C:\Programs\Python36>Lib\..\python -c "import sys; print(sys.executable)&q
5401 - 5500 of 13135 matches
Mail list logo
