Terry J. Reedy added the comment:
File loads normally for me. What happens when you load it as is?
If you need to type something, can you produce effect with entering numbers
with keypad, without using any special Korean entry method that I would not
have? If so, give exact directions and
Changes by Terry J. Reedy :
--
pull_requests: +2725
___
Python tracker
<http://bugs.python.org/issue30870>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
My manual test procedure was faulty. Without a unit test, I should have asked
for another person to verify.
--
___
Python tracker
<http://bugs.python.org/issue30
Terry J. Reedy added the comment:
I believe I read somewhere (SO?) that root.withdraw sometimes affects the
effectiveness of event_generate. I will try de-iconifying for just this.
--
___
Python tracker
<http://bugs.python.org/issue30
Terry J. Reedy added the comment:
New changeset 5b62b35e6fcba488da2f809965a5f349a4170b02 by terryjreedy in branch
'master':
bpo-30870: IDLE -- fix logic error in eae2537. (#2660)
https://github.com/python/cpython/commit/5b62b35e6fcba488da2f809965a5f3
Changes by Terry J. Reedy :
--
pull_requests: +2726
___
Python tracker
<http://bugs.python.org/issue30870>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
New changeset 953e527763f5af293668135acdf5f0a20c3f6f4f by terryjreedy in branch
'3.6':
[3.6] bpo-30870: IDLE -- fix logic error in eae2537. (GH-2660) (#2661)
https://github.com/python/cpython/commit/953e527763f5af293668135acdf5f0
Terry J. Reedy added the comment:
I plan to review tomorrow afternoon.
--
nosy: +csabella
___
Python tracker
<http://bugs.python.org/issue30899>
___
___
Python-bug
Changes by Terry J. Reedy :
--
stage: -> patch review
type: -> enhancement
versions: +Python 3.6
___
Python tracker
<http://bugs.python.org/issue30899>
___
__
Terry J. Reedy added the comment:
New changeset ba352270b724d67fc938c335c605acdee7474308 by terryjreedy
(csabella) in branch 'master':
bpo-30881: IDLE: add docstrings to browser.py (#2638)
https://github.com/python/cpython/commit/ba352270b724d67fc938c335c605ac
Changes by Terry J. Reedy :
--
pull_requests: +2728
___
Python tracker
<http://bugs.python.org/issue30881>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Terry J. Reedy :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.6
___
Python tracker
<http://bugs.python.or
Terry J. Reedy added the comment:
New changeset 675c1adfe5c87573e81fb295ccad7b6cfa03a3ee by terryjreedy in branch
'3.6':
[3.6] bpo-30881: IDLE: add docstrings to browser.py (GH-2638) (#2663)
https://github.com/python/cpython/commit/675c1adfe5c87573e81fb295ccad7b
Terry J. Reedy added the comment:
Color me dubious ;-). The change was made because tkinter.__init__, line 1990
has this line
withdraw = wm_withdraw
There is a similar line for all of the around 30 wm_xyz functions. Prefixing
the names of methods of class Wm is an unusual redundancy. I
Terry J. Reedy added the comment:
I first beat my head against event_generate two or three years ago. So I
appreciate you taking a whack at it. It is nice that Variable.set and invoke
can be used for tests, but it would really be nice to have e_v work too
Terry J. Reedy added the comment:
Eventually, we will have tests that would have caught this. I took the
opportunity to improve the test for the call.
--
___
Python tracker
<http://bugs.python.org/issue30
Terry J. Reedy added the comment:
New changeset 6d13b22e3ab262c6b1f068259aebd705e7da316c by terryjreedy
(csabella) in branch 'master':
bpo-30779: IDLE: fix changes.delete_section calls in configdialog (#2667)
https://github.com/python/cpython/commit/6d13b22e3ab262c6b1f068259aebd7
Changes by Terry J. Reedy :
--
pull_requests: +2742
___
Python tracker
<http://bugs.python.org/issue30779>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
I am thinking that this is a artifact of the combination of monitor pixel and
subpixel type, size, and arrangement; font type and size; particular character;
and character generation software. When I load the file in IDLE, the Korean
comment chars are a nice
Terry J. Reedy added the comment:
New changeset c0179483f13be81910ed73889dcad92528e20ef2 by terryjreedy in branch
'3.6':
[3.6] bpo-30779: IDLE: fix changes.delete_section calls in configdialog
(GH-2667) (#2674)
https://github.com/python/cpython/commit/c0179483f13be81910ed73889dcad9
Terry J. Reedy added the comment:
The new gui tests passed on Travis (linux), which I strongly suspect does not
run gui tests. The generate key test failed on Appveyor (Windows), which means
is does run gui tests. It also failed on my machine: generate key release did
not work. The
Terry J. Reedy added the comment:
New changeset 50c9435c9b73b39fcf79cc3e58edc58bb943d0ed by terryjreedy (Louie
Lu) in branch 'master':
bpo-30899: Add unittests, 100% coverage, for IDLE's two ConfigParser
subclasses. (#2662)
https://github.com/python
Changes by Terry J. Reedy :
--
pull_requests: +2750
___
Python tracker
<http://bugs.python.org/issue30899>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Terry J. Reedy :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Terry J. Reedy added the comment:
New changeset a9bf62cadf6ccd55b84a8d4f353529b02a537830 by terryjreedy in branch
'3.6':
[3.6] bpo-30899: Add unittests, 100% coverage, for IDLE's two ConfigParser
subclasses. (GH-2662) (#2685)
https://github.com/python
New submission from Terry J. Reedy:
Among other things, #30777 added docstrings to configdialog. Those for
create_page_x methods included a list of 'Configuration attributes' (Tk
Variables) with an annotation as to what the Var represents. The list for the
font tab already h
Changes by Terry J. Reedy :
--
versions: +Python 3.6, Python 3.7
___
Python tracker
<http://bugs.python.org/issue30913>
___
___
Python-bugs-list mailing list
Unsub
Terry J. Reedy added the comment:
You put one non-tk name in the font page 'Configuration attributes'. I removed
it as not belonging with the tk Vars, but it got me thinking that more would be
useful. In the ConfigChanges docstring we included a list of methods, which I
Terry J. Reedy added the comment:
Serhiy: question about tkinter.wantobjects.
ConfigDialog sets the font options of label font_sample and text
text_highlight_sample with a font tuple such as font=('courier', 12, '').
In the test, I expected retrieval of
Terry J. Reedy added the comment:
I will look at the patch after doing more with config and configdialog.
--
___
Python tracker
<http://bugs.python.org/issue27
Terry J. Reedy added the comment:
PR2666 adds 4% test coverage. 40% left to go. I expect some tests will cover
more lines with less code.
I am working on a test for set_font_sample.
--
___
Python tracker
<http://bugs.python.org/issue30
Terry J. Reedy added the comment:
16 methods so far, + 17 var_changed_x is 35, leaving another 29.
If you are going to give the whole widget structure, then an '*' before bound
names would be sufficient and avoid the duplication.
--
Terry J. Reedy added the comment:
Hi Cedric, I have been 'considering' for at least 7 years, since the core devs
who then cared about IDLE agreed that tabbed windows would be a good idea. The
direst analogy with programming editors with tabs. Notepad++ is the one I
have
Terry J. Reedy added the comment:
https://www.youtube.com/watch?v=nO78ECRighw shows IDLE on Mac with a shell and
editor window. Because Mac pulls the menu off of each window and puts one
above both, which are side by side, it looks like an example of what we want to
have on all systems
Terry J. Reedy added the comment:
Vedran, thank you for the link. The way IDLE looks on Mac is what we want on
all systems. I added a note to #24826.
Do you regularly work on Mac? It would be help if someone were to test PRs on
OSX, especially patches intended to change what users see
Terry J. Reedy added the comment:
New changeset 9b622fb90331f259894e6edb29b5c64b9366491a by terryjreedy (Louie
Lu) in branch 'master':
bpo-30870: IDLE: Add configdialog fontlist selection unittest (#2666)
https://github.com/python/cpython/commit/9b622fb90331f259894e6edb29b5c6
Changes by Terry J. Reedy :
--
pull_requests: +2767
___
Python tracker
<http://bugs.python.org/issue30870>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
New changeset 42abf7f9737f78a5da311a42945d781dfcd6c6c0 by terryjreedy in branch
'3.6':
[3.6] bpo-30870: IDLE: Add configdialog fontlist selection unittest (GH-2666)
(#2701)
https://github.com/python/cpython/commit/42abf7f9737f78a5da311a42945d78
Terry J. Reedy added the comment:
I added missing functions and created attached list with help of Find in (1)
Files.
--
Added file: http://bugs.python.org/file47013/configdialog_funcs.txt
___
Python tracker
<http://bugs.python.org/issue30
Terry J. Reedy added the comment:
New changeset 36329a4dd85c03e2060a306e86ac5ddec6fd2549 by terryjreedy
(csabella) in branch 'master':
bpo-30913: IDLE: Document tk vars, attributes, and methods for ConfigDialog
(#2697)
https://github.com/python/cpyt
Changes by Terry J. Reedy :
--
pull_requests: +2768
___
Python tracker
<http://bugs.python.org/issue30913>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
We can edit details as we examine functions to test and change or refactor.
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
New submission from Terry J. Reedy:
As I prepare blurbs, I copy to a private file, replacing 'IDLE' with bpo-n.
And maybe edit a bit more, maybe not. I occasionally copy batches to
idlelib/NEWS.txt. The first 2 times with git, I marked PR as trivial, but
decided to open this
Terry J. Reedy added the comment:
New changeset 9a09c667cf133e722a3e7ed2185f3e9e5af25a99 by terryjreedy in branch
'3.6':
[3.6] bpo-30913: IDLE: Document tk vars, attributes, and methods for
ConfigDialog (GH-2697) (#2702)
https://github.com/python/cpyt
Changes by Terry J. Reedy :
--
pull_requests: +2769
___
Python tracker
<http://bugs.python.org/issue30928>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
Raymond, if you either unassign yourself or approve the current PR, I will
merge and backport to 3.6 (but not 3.5).
--
___
Python tracker
<http://bugs.python.org/issue30
Terry J. Reedy added the comment:
I think it at least plausible that we should add implementations of some of the
unicode standard's algorithms. Victor and Serhiy, as two of the active core
devs most involved with unicode issues, what do you think?
--
nosy: +haypo, serhiy.stor
Terry J. Reedy added the comment:
Backport of 2703 is 2704, which has been merged. Somehow bpo# on title got
stripped and I did not notice until merged, and merge was allowed without
trivial tag.
NOTE: THE DOUBLE SPACING AFTER THE SEPARATOR LINE IS INTENTIONAL, to avoid
backport merge
Terry J. Reedy added the comment:
If you have more annotations to add now, go ahead and I will review.
--
___
Python tracker
<http://bugs.python.org/issue30
Terry J. Reedy added the comment:
What invocation conditions? If this only happens with Travis, then this may be
a Travis issue. If it only happens with Travis coverage runs, then it might be
intentional, or a coverage issue.
--
nosy: +ezio.melotti, michael.foord, rbcollins
Terry J. Reedy added the comment:
This is a duplicate of #8231. But before I close this, when you do
> set
in the console (command prompt), what HOME* variables are set and is
USERPROFILE?
In python, what does
>>> from os.path import expanduser
>>> expanduser('
Changes by Terry J. Reedy :
--
assignee: -> terry.reedy
components: +IDLE
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue30918>
___
__
Changes by Terry J. Reedy :
--
components: +Library (Lib) -Build
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
New submission from Terry J. Reedy:
I have been using coverage for a few years. Now that I am (again) not the only
one writing IDLE tests (others did 3 and 4 years ago), I should document what I
do and in particular the policy decision -- test with 'branch=True' -- and the
IDL
Changes by Terry J. Reedy :
--
pull_requests: +2775
___
Python tracker
<http://bugs.python.org/issue30934>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
Yes, go ahead next with name changes and use of modern features such as sets
and comprehensions. Please discuss 'general changes before coding. When we
added Linux Modern keys a year ago, I combined two functions into
IdleConf.current_colors_and_key
Terry J. Reedy added the comment:
That would be good; I might need to know someday;-).
--
___
Python tracker
<http://bugs.python.org/issue30934>
___
___
Python-bug
Terry J. Reedy added the comment:
I made this issue a dependency of #24776, which is about redoing the whole font
page.
The fontchooser has good, inappropriate for IDLE, and bad points. I consider
it an alternate mockup proposal for the font page. For this issue: displaying
each font name
Terry J. Reedy added the comment:
This is at least partly a duplicate of #25036, but until I look at the approach
in that patch, versus what I have been thinking of, I cannot tell if this
should be closed.
--
___
Python tracker
<h
Terry J. Reedy added the comment:
I changed the title again to reflect the actual discussion. #25036 (and
#30784) are about extracting an editor component that can be put on a tab.
#25032 is about making a top-level with menu that is not tied to a single
editor. This issue should stick to
Terry J. Reedy added the comment:
New changeset 95bebb7264afad88f31f7cdc3b28bacde7c46f93 by terryjreedy in branch
'master':
bpo-30934: Document coverage details for idlelib tests (#2711)
https://github.com/python/cpython/commit/95bebb7264afad88f31f7cdc3b28ba
Changes by Terry J. Reedy :
--
pull_requests: +2786
___
Python tracker
<http://bugs.python.org/issue30934>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
New changeset 65de1f3672fd0a1e3ec34b654ef5213e15a03e26 by terryjreedy in branch
'3.6':
[3.6] bpo-30934: Document coverage details for idlelib tests (GH-2711) (#2726)
https://github.com/python/cpython/commit/65de1f3672fd0a1e3ec34b654ef521
Terry J. Reedy added the comment:
I generalized the first part so only the .bat file needs a *nix version.
--
___
Python tracker
<http://bugs.python.org/issue30
Terry J. Reedy added the comment:
Cheryl, please try Louie's linux instructions and see if they work on Ubuntu.
--
___
Python tracker
<http://bugs.python.org/is
Terry J. Reedy added the comment:
Vedran, reread "continue ... with multiple windows". What you describe as 'I
have never seen' seems standard for tabbed windows applications. I just
verified that FireFox and Edge allow "separate windows that can be
independently
Terry J. Reedy added the comment:
I suspect that Edit with IDLE would open a new window as it does now, but I
don't really know. I don't think that IDLE would have any control. I seldom
start IDLE that way.
--
___
Python trac
Terry J. Reedy added the comment:
The problem with the Iterable ABC is that 'iterable' and 'iterator' are
*dynamically* defined, with a possibly infinite time required to possibly
destructively check either definition. In general, an algorithmic *static*
check can o
Terry J. Reedy added the comment:
Whatever is merged with PR_2691, further improvements can be made in further
PRs either on this issue or others that work on config code.
I still think this test is slower than it should be -- the change to deep copy
either made no difference or made it
Terry J. Reedy added the comment:
New changeset f776eb0f0e046f2fa3a96540bb42d8cf970f6c55 by terryjreedy (Louie
Lu) in branch 'master':
bpo-30917: IDLE: Add config.IdleConf unittests (#2691)
https://github.com/python/cpython/commit/f776eb0f0e046f2fa3a96540bb42d8
Changes by Terry J. Reedy :
--
pull_requests: +2812
___
Python tracker
<http://bugs.python.org/issue30917>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
The deepcopy does not work on 3.6. Any fix should be applied to 3.7 as well.
If nothing else, we should try to reload with read_string.
This is a blocker for merging anything else into config and test_config
Terry J. Reedy added the comment:
Thanks. I will look at it tomorrow and if it seems ok, prepare a new combined
backport and see if it passes.
--
___
Python tracker
<http://bugs.python.org/issue30
Terry J. Reedy added the comment:
Either the hard-coding in the config test will have to be changed or it will
have to be replaced by something adaptive. I have not quite decided yet. Once
the new tests are merged, I expect to do some followup improvements.
Equal important for this issue is
Terry J. Reedy added the comment:
New changeset ed014f7e135fe021837208960237d6c37afde5be by terryjreedy (Louie
Lu) in branch 'master':
bpo-30917: IDLE: Fix mock_config deepcopy to read_string (#2754)
https://github.com/python/cpython/commit/ed014f7e135fe021837208960237d6
Changes by Terry J. Reedy :
--
pull_requests: +2826
___
Python tracker
<http://bugs.python.org/issue30968>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
I merged pr2754 in pr2753, the 3.6 backport of pr2691. To avoid breaking 3.6
buildbots more than one test, I will hold off merging pr2753 until a fix is
available.
--
___
Python tracker
<http://bugs.python.
Terry J. Reedy added the comment:
Louie, I am fixing this (I believe).
--
___
Python tracker
<http://bugs.python.org/issue30968>
___
___
Python-bugs-list mailin
Changes by Terry J. Reedy :
--
pull_requests: +2827
___
Python tracker
<http://bugs.python.org/issue30968>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
New changeset 9f9192afbb4e45d09f0d3d717b457d157dc46398 by terryjreedy in branch
'master':
bpo-30968: Fix test_get_font in IDLE's test_config. (#2769)
https://github.com/python/cpython/commit/9f9192afbb4e45d09f0d3d717
Terry J. Reedy added the comment:
Fix worked: test_idle passed in build 897.
http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/897/steps/test/logs/stdio
I also included the fix of PR2769 in PR2753 (3.6 backport).
--
resolution: -> fixed
stage: -> resolved
Changes by Terry J. Reedy :
--
pull_requests: +2828
___
Python tracker
<http://bugs.python.org/issue30917>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
New changeset 65c24c846797b93d7adb72fc400f95a570f43fa9 by terryjreedy in branch
'3.6':
[3.6] bpo-30917: IDLE: Add config.IdleConf unittests (GH-2691) (#2753)
https://github.com/python/cpython/commit/65c24c846797b93d7adb72fc400f95
Terry J. Reedy added the comment:
I don't understand 'format your name' as there is no formatting that I did.
Github copies account name and email as they are.
I have no idea about commit message. The PR title has no extra spaces. But
github does not always
Terry J. Reedy added the comment:
I will try to look at the first line more carefully before hitting the 2nd
green button.
--
___
Python tracker
<http://bugs.python.org/issue30
Terry J. Reedy added the comment:
Same place is good for now as testing will be easier. Moving menu items will
be a separate issue later.
--
___
Python tracker
<http://bugs.python.org/issue27
Terry J. Reedy added the comment:
I saw the python-ideas post. I have no experience with http.server, but I just
read the doc, and know something of our general enhancement policies. I hope
these comments help.
There are two questions: Should compression support be added to http.server
Terry J. Reedy added the comment:
PR2769 is the fix for master for test_get_font for #30968. The listing here is
a cross-reference. The fix was incorporated into the 3.6 backport PR2753
before it was merged.
This issue is closed, having increased coverage from 46% to 96%. Further work
on
Changes by Terry J. Reedy :
--
pull_requests: +2837
___
Python tracker
<http://bugs.python.org/issue28523>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
Thanks. I will see what that does.
--
___
Python tracker
<http://bugs.python.org/issue30968>
___
___
Python-bugs-list mailin
Changes by Terry J. Reedy :
--
assignee: terry.reedy
components: IDLE
nosy: terry.reedy
priority: normal
severity: normal
stage: needs patch
status: open
title: IDLE: Add config dialog font page tests
type: enhancement
versions: Python 3.6, Python 3.7
Terry J. Reedy added the comment:
I am closing this as basically complete. I opened #30981 to add and perhaps
complete font page tests.
--
___
Python tracker
<http://bugs.python.org/issue30
Changes by Terry J. Reedy :
--
resolution: -> fixed
stage: test needed -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
New submission from Terry J. Reedy:
I am working on this.
* Change 'test_highlight_sample' to 'highlight_sample.
* Change 'set_font_sample()' to 'set_samples()', since it also changes
highlight_sample, and test.
* Add gui event test for 'bold' check
Terry J. Reedy added the comment:
I decided to rearrange page #24776 before changing sample #13802.
--
dependencies: +IDLE: Improve config dialog font change user interface
___
Python tracker
<http://bugs.python.org/issue13
Terry J. Reedy added the comment:
I decided to rearrange page #24776 before changing sample #13802.
--
dependencies: +IDLE: Add config dialog font page tests -IDLE Prefernces/Fonts:
use multiple alphabets in examples
___
Python tracker
<h
Changes by Terry J. Reedy :
--
dependencies: +IDLE: Add config dialog font page tests
___
Python tracker
<http://bugs.python.org/issue30780>
___
___
Python-bug
Terry J. Reedy added the comment:
New changeset a54a8f188a803cd41bdc8758c10d34ba3328c566 by Terry Jan Reedy in
branch 'master':
bpo-28523: IDLE: Use 'color' instead of 'colour'. (#2787)
https://github.com/python/cpython/commit/a54a8f188a
Changes by Terry J. Reedy :
--
pull_requests: +2841
___
Python tracker
<http://bugs.python.org/issue28523>
___
___
Python-bugs-list mailing list
Unsubscribe:
Terry J. Reedy added the comment:
New changeset ac5c1e2ea311d11714f89476c86936f9388d19a4 by Terry Jan Reedy in
branch '3.6':
[3.6] bpo-28523: IDLE: Use 'color' instead of 'colour'. (GH-2787) (#2791)
https://github.com/python/cpython/commit/ac5c1e2ea3
5301 - 5400 of 13135 matches
Mail list logo
