[issue30715] Test_winreg, test_dynamic_key hangs on my Win 10

2017-06-20 Thread Terry J. Reedy
New submission from Terry J. Reedy: On my Win10-64 machine, test_winreg hangs, impervious to ^C. I have to close Command Prompt. (With IDLE I can run just test_winreg and then Restart Shell.) This happened with repository builds last Friday and today, and with installed 3.6.2rc1. But I

[issue30715] Test_winreg, test_dynamic_key hangs on my Win 10

2017-06-20 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- type: behavior -> crash ___ Python tracker <http://bugs.python.org/issue30715> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue30716] Failing tests with installed 3.6.2rc1 on Win 10-64

2017-06-20 Thread Terry J. Reedy
New submission from Terry J. Reedy: 3.6.2rc1, 64 bit version, installed on my Win10 machine, has 5 failures not present in my 32-bit debug repository builds. Auto Windows updates is on. Results same after uninstall and re-install. F:\dev\3x>py -3 -c "import sys; print(sys.version)&q

[issue6739] IDLE: refuse invalid key bindings

2017-06-20 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- assignee: -> terry.reedy title: IDLE window won't start or show up after assgining new key in options v2.5.2 and 3.1.1 -> IDLE: refuse invalid key bindings versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.4,

[issue21519] IDLE : Bug in keybinding validity check

2017-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: #6739 also has a patch to refuse invalid key bindings. -- assignee: -> terry.reedy versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.4 ___ Python tracker <http://bugs.python.org/issu

[issue6699] IDLE: Warn user about overwriting a file that has a newer version on filesystem

2017-06-20 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- assignee: roger.serwy -> terry.reedy nosy: +terry.reedy -BreamoreBoy versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.4, Python 3.5 ___ Python tracker <http://bugs.python.org/iss

[issue1074333] On linux, numeric pad input is ignored when numlock off

2017-06-20 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- assignee: -> terry.reedy versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.4, Python 3.5 ___ Python tracker <http://bugs.python.org/issue1

[issue17822] Save on Close windows (IDLE)

2017-06-20 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- assignee: -> terry.reedy nosy: -BreamoreBoy stage: -> test needed versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.3, Python 3.4 ___ Python tracker <http://bugs.python.org/i

[issue27245] IDLE: Fix deletion of custom themes and key bindings

2017-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: In #4765, which I just closed as a duplicate, G Polo had same idea of applying change at top. https://bugs.python.org/file14645/removekeybindingswhiletheyexist.diff -- assignee: -> terry.reedy ___ Python trac

[issue4765] IDLE fails to "Delete Custom Key Set" properly

2017-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: This issue (and a similar one for custom themes) was fixed in #27245 with a different patch, but to the same effect. -- nosy: -BreamoreBoy resolution: -> duplicate stage: test needed -> resolved status: open -> closed superseder: -&g

[issue28889] IDLE needs the ability to pass in command-line arguments

2017-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: Another duplicate of #5680, which already has three patches. I retitled the PR and it is now listed on #5680. -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Command-line arguments when run

[issue5680] Command-line arguments when running in IDLE

2017-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: I closed #28889, with a 4th patch, in favor of this one. Gabriel, you somehow never signed the PSF Contributor License Agreement. Until you do, I will assume that anything you did is covered by the other 3 patches. -- versions: +Python 3.7 -Python

[issue5680] Command-line arguments when running in IDLE

2017-06-20 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- nosy: +louielu ___ Python tracker <http://bugs.python.org/issue5680> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24718] Specify interpreter when running in IDLE

2017-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: >From your post, it was unclear to me what you are actually asking for. From >reading the bitbucket thread, it appears that you want something I cannot give >you -- a built-in privileged position in IDLE. However, as I said before, you >can

[issue19042] Idle: run from editor without explicit save

2017-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: I rewrote title to slightly generalize, and add and document here on the tracker additional variations that have been requested or that I have thought of. 1. Autosave to somewhere, like .idlerc/untitled.py 2. Run without saving, by stuffing code lines into

[issue5680] Command-line arguments when running in IDLE

2017-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: Running with arguments is only one requested or possible deviation from the standard F5 mode. See #19042, msg296498, for many more. I am thinking that there should be one menu entry (Custom Run, Alt-F5)? that brings up a box with alternatives, initially

[issue30719] IDLE: Make PyShell visible upon error.

2017-06-20 Thread Terry J. Reedy
New submission from Terry J. Reedy: Spinoff from #10079. "PseudoStderrFile" in PyShell.py brings the shell forward if an error occurs. It should be possible to extract G. Polo's patch for that class from the megapatch. A possible issue is that PseudoStdoutFile and PseudoStder

[issue30719] IDLE: Make PyShell visible upon error.

2017-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: The lift action should only happen in the IDLE GUI process. When I retrace the data flow, I should document it. -- ___ Python tracker <http://bugs.python.org/issue30

[issue10079] idlelib for Python 3 with Guilherme Polo GSoC enhancements

2017-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: In msg149930, Roger said "There are two major changes that are not covered by other issues (AFAIK). 1) The "PseudoStderrFile" in PyShell.py brings the shell forward if an error occurs. I like this behavior. 2) Run a script without saving

[issue27425] Tests fail because of git's newline preferences on Windows

2017-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: Why de we would 'want' /r/n on Windows? What beside Notepad can't handle /n? -- ___ Python tracker <http://bugs.pyt

[issue27425] Tests fail because of git's newline preferences on Windows

2017-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: Installed 3.6.2rc1 is showing the same errors for test_random and test_sax. #30716. -- nosy: +terry.reedy ___ Python tracker <http://bugs.python.org/issue27

[issue21519] IDLE : Bug in keybinding validity check

2017-06-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: I believe patch affects same area of file as patch for #6739. -- ___ Python tracker <http://bugs.python.org/issue21519> ___ ___

[issue6739] IDLE: refuse invalid key bindings

2017-06-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: I believe patch for #21519 affects area of file patched here. -- ___ Python tracker <http://bugs.python.org/issue6739> ___ ___

[issue27620] IDLE: Add keyboard equivalents for mouse actions.

2017-06-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: ConfigDialgo.__init__ has commented out key bindings for the buttons, including Esc for [Cancel]. We should establish 'IDLE Dialog Conventions', document (add to README.txt?), and follow consistently. #27621 is about polishing Query box behavior.

[issue30723] IDLE parenmatch - left and right highlighting, independent flash-delay

2017-06-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: On bugs.python.org tracker a number prefixed by '#' refers an issue number on this tracker. On the other hand, PR2306 or PR 2306 should do what you meant. https://docs.python.org/devguide/triaging.html#generating-special-links-in-a-comment In a pu

[issue30723] IDLE parenmatch - left and right highlighting, independent flash-delay

2017-06-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: Hi Charles. Welcome to CPython development and its issue tracker. Everyone starts 'new at this'. Can you please describe, in detail, a simple, minimal example of how to invoke the existing behavior that you want to change, then what change you wa

[issue30716] Failing tests with installed 3.6.2rc1 on Win 10-64

2017-06-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: Steve, what should I do to answer you line-ending question, or do you still need the info? Victor Stinner reopened #27425, which was about the exact same line-ending failures. -- ___ Python tracker <h

[issue30728] IDLE: Modernize configdialog code.

2017-06-21 Thread Terry J. Reedy
New submission from Terry J. Reedy: Depending on the file, modernizing includes: * Add docstrings. * Change non-class names with caps to PEP8 no-caps names; this often means, for example, changing embedded 'A' to '_a'. * Make most comments be sentences, like this sent

[issue27388] IDLE configdialog: reduce multiple references to Var names

2017-06-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: I moved PR 2307 to a new issue, #30728 Modernize configdialog. My comment that internal Var names "can lowercased (PEP8) and otherwised changed" was anticipating such an issue. The point for this issue was to contrast Var names with the cross-vers

[issue27388] IDLE configdialog: reduce multiple references to Var names

2017-06-21 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: -2354 ___ Python tracker <http://bugs.python.org/issue27388> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30723] IDLE parenmatch - left and right highlighting, independent flash-delay

2017-06-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: Thanks. That gives me something to work with. -- ___ Python tracker <http://bugs.python.org/issue30723> ___ ___ Python-bug

[issue30728] IDLE: Modernize configdialog code.

2017-06-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: I moved PR 2307 here. I made trivial PR 2322 for the config_key typo. Cheryl, how did you do the name changes? Did you prepare a rename mapping or script that could be applied to other patch files? If so, please upload. If sensibly possible, I would like

[issue29366] os.listdir has inconsistent behavior when run on a non-directory

2017-06-21 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- resolution: -> not a bug stage: test needed -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue24813] Redesign Help => About IDLE, make it non-modal

2017-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: The proposed patch does several things that can be considered independently. 1. Give the 'title' parameter a default value 'About IDLE'. Instead, add the python/IDLE version, as done for IDLE doc in help.py. (In both cases, one might w

[issue24813] Redesign Help => About IDLE, make it non-modal

2017-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: Cheryl, I suggest to start with any of 1, 3, and 4. My preference is 3. To be sure of avoiding merge conflicts, I would do one at a time. Narrowly focused PRs should be quick to review, test, and merge. -- nosy: +csabella

[issue21519] IDLE : Bug in keybinding validity check

2017-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: #6739 is about rejecting *invalid* sequences, this is about rejecting a *duplicate* valid sequence. Both fixes are needed. -- ___ Python tracker <http://bugs.python.org/issue21

[issue6739] IDLE: refuse invalid key bindings

2017-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: Patch mostly looks good. To apply now, keybindingDialog.py must become config_key.py. I have no idea what other merge issues there might be. The name of the new function'KeySequenceCheck()' should be 'sequence_ok()'. A minimal

[issue30728] IDLE: Modernize configdialog code.

2017-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: Yes, I intend to add the expanded list, further edited, to the roadmap, or something not tied to one issue. I should add changing messagebox and font imports. Except for switching to ttk widgets, the changes listed are invisible to users. The purpose of

[issue26143] Ensure that IDLE's stdlib imports are from the stdlib

2017-06-22 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- keywords: +patch ___ Python tracker <http://bugs.python.org/issue26143> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24813] Redesign Help => About IDLE, make it non-modal

2017-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: I experimented with how the icon looks with different backgrounds, for point 4. Because the paper holes are transparent, white is bad, proposed light gray okay, black is good. Overall white on black is better than white on current dingy gray, so I consider

[issue30303] IDLE: Add _utest to textview and add textview tests

2017-06-22 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- resolution: -> fixed stage: backport needed -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue30016] No sideways scrolling in IDLE

2017-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: I believe this is about, or would be satisfied, by a horizontal scrollbar, the subject of #1207613. -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Idle Editor: Botto

[issue29910] Ctrl-D eats a character on IDLE

2017-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: I have since discovered the [unified][split] buttons in the diff windows. I have also starting applying the return run elsewhere in idlelib. I had to think about paren_match_event. It is bound to KeyRelease-parenright, etc, via config-extentions.def and

[issue15308] IDLE - add an "Interrupt Execution" to shell menu

2017-06-22 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue15308> ___ ___

[issue16198] IDLE - tabbing in a string always brings up file completion window

2017-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: I pushed a patch on another issue that fixed tabbing on lines after the first line within multiline strings. With 3.6, I verified that tabbing anywhere on the same line of an opening quote, except immediately after the quote, brings up the box

[issue27162] Add idlelib.interface module

2017-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: Nick later suggested against this, and in the absence of requests, I don't want to do this, at least not before 3.7, if ever. What if we make a change that makes the public promise awkward? The docstring for colordelegator should say how it is used (in

[issue26993] Copy idlelib *.py files with new names

2017-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: Files were renamed later in May. Some things were backported to 3.5 and even 2.7 for 3.5.3 and 2.7.13. Anything involving ttk, which will soon be nearly all tkinter code, could not and cannot be backported. -- resolution: postponed -> rejected st

[issue26627] IDLE incorrectly labeling error as internal

2017-06-22 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- assignee: -> terry.reedy resolution: -> duplicate stage: test needed -> resolved status: open -> closed superseder: -> IDLE removes elements from tracebacks. ___ Python tracker <http://bugs.pyt

[issue24252] IDLE removes elements from tracebacks.

2017-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: #26627 was closed as an apparent duplicate of this. It should be rechecked if this is fixed. -- assignee: -> terry.reedy versions: +Python 3.7 -Python 2.7, Python 3.4, Python 3.5 ___ Python tracker &l

[issue25125] "Edit with IDLE" does not work for shortcuts

2017-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: This is not an IDLE code issue, but an installation issue, and I think one main entry with a submenu is proper. I just tried clicking on '3.5.3' and '3.6.2' and both opened an editor for a .py file with the corresponding version. -

[issue25224] Replace Idle's README.txt with annotated file list

2017-06-22 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue1080387] Making IDLE Themes and Keys Config more Robust

2017-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: These additions happened years ago, though the foreground is now different. +builtin-foreground= #ca00ca +builtin-background= #ff -- assignee: kbk -> terry.reedy nosy: +terry.reedy resolution: -> out of date stage: needs patch -> resolv

[issue25032] IDLE - same menubar across application

2017-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: I agree. Better to gray-out inactive items. I believe bar is already somewhat shared on mac. We are working on other changes needed to use tabbed notebooks. -- assignee: -> terry.reedy stage: -> needs patch type: -> enhancement versions

[issue22460] idle editor: replace all in selection

2017-06-22 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- assignee: -> terry.reedy stage: needs patch -> test needed versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.4, Python 3.5 ___ Python tracker <http://bugs.python.org/i

[issue25020] IDLE - centralize ui policies and small utilities

2017-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: The specific patch is out-of-date. IDLE 3.6+ requires tk 8.5+. We should finish converting everything to ttk before 3.7.0. In practice, I believe people are using late 8.5 or 8.6. 8.5.9 on Apple is too buggy to really use and latest ActiveState 8.5 for mac

[issue24860] Can IDLE's query box be improved

2017-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: The patch is mostly obsolete. I added query.py a year ago, which replaced the open-module box and those used in configdialog. The code began with one of the existing boxes, but it has the two improvements listed above: a) stay open on error (really helpful

[issue24860] Can IDLE's query box be improved

2017-06-22 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- assignee: -> terry.reedy ___ Python tracker <http://bugs.python.org/issue24860> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue22133] IDLE: Set correct WM_CLASS on X11

2017-06-22 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- assignee: -> terry.reedy stage: -> test needed type: -> behavior versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.4, Python 3.5 ___ Python tracker <http://bugs.python.or

[issue23922] turtle.py and turtledemo use the default tkinter icon

2017-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: PyShell is now pyshell. I think factoring the icon setting into a separate function is a good idea, separate from turtle and turtledemo. I am leaving this issue open for that, for 3.6/7. I don't think the turtle/turtledemo icons matter that much. I

[issue23616] Idle: conflict between loop execution and undo shortcut.

2017-06-22 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- assignee: -> terry.reedy versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.4, Python 3.5 ___ Python tracker <http://bugs.python.org/issu

[issue23337] [IDLE/Windows] Run python with restricted rights

2017-06-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: There is insufficient information to establish that this is a bug in IDLE, hence it is not possible to write a patch. -- resolution: -> not a bug stage: test needed -> resolved status: open -> closed _

[issue23069] IDLE's F5 Run Module doesn't transfer effects of future import

2017-06-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: I am no longer patching 2.7 but there is one __future__ import active in 3.6: generator_stop. If I remember right, there is code that would work without future import and fail with it. In 3.7, it would always fail. -- assignee: -> terry.re

[issue22897] IDLE hangs on OS X with Cocoa Tk if encoding dialog is required during save

2017-06-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: I am no longer patching IDLE for 2.7 -- nosy: +terry.reedy resolution: -> wont fix stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue10909] thread hang, possibly related to print

2017-06-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: If there is no bug in 3.6/7, this should be closed. -- ___ Python tracker <http://bugs.python.org/issue10909> ___ ___ Python-bug

[issue14304] Implement utf-8-bmp codec

2017-06-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: In 3.6, Python's use of the Windows console was changed to work much better with unicode. As a result, IDLE is now worse rather than better than the console on Windows. I plan to do something before 3.7.0. -- components: +IDLE versions: +Pytho

[issue14326] IDLE - allow shell to support different locales

2017-06-23 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- resolution: -> rejected stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue14326> ___ ___

[issue24813] Redesign Help => About IDLE, make it non-modal

2017-06-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset d352d689775699c289e011e8cec52c23c600b7fa by terryjreedy (csabella) in branch 'master': bpo-24813: IDLE: Add icon to help_about (#2335) https://github.com/python/cpython/commit/d352d689775699c289e011e8cec52c

[issue24813] Redesign Help => About IDLE, make it non-modal

2017-06-23 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +2408 ___ Python tracker <http://bugs.python.org/issue24813> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24813] Redesign Help => About IDLE, make it non-modal

2017-06-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 1b7474dedcbbd731a362b17abfbd7e5a60b64f63 by terryjreedy in branch '3.6': [3.6] bpo-24813: IDLE: Add icon to help_about (GH-2335) (#2359) https://github.com/python/cpython/commit/1b7474dedcbbd731a362b17abfbd7e

[issue30734] 200000 indexes crashes eval and python (without eval)

2017-06-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: To be clear, as the title and version suggest, the bug is the 2.7 segfault versus the 3.x exception during compile. It is normal for the compiler to have limits and to exit when they are exceeded. I have no idea if the 3.x code can be backported. I added

[issue30728] IDLE: Modernize configdialog code.

2017-06-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: I reviewed IDLE issues with patches. I will post my updated issues list on the roadmap issue, #30422. Of relevance to this issue is that config related patches are split between config, configdialog, and config_key, and limited to 3 or 4 each. I decided

[issue24813] Redesign Help => About IDLE, make it non-modal

2017-06-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 18ede062581edb7e8d359d02cd3419466114cf5a by terryjreedy (csabella) in branch 'master': bpo-24813: IDLE: Add default title to help_about (#2366) https://github.com/python/cpython/commit/18ede062581edb7e8d359d02cd3419

[issue24813] Redesign Help => About IDLE, make it non-modal

2017-06-23 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +2419 ___ Python tracker <http://bugs.python.org/issue24813> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24813] Redesign Help => About IDLE, make it non-modal

2017-06-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: tk Text does not have a ttk version and does have default and tab settable colors. Maybe I should start experimenting with tagged text instead of Labels and Buttons. Let's skip 4 for now. You can work on 'default non-model' (I don't wa

[issue24813] Redesign Help => About IDLE, make it non-modal

2017-06-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset bd570f42110b99bade6e58e3ed2d620f27a92fc3 by terryjreedy in branch '3.6': [3.6] bpo-24813: IDLE: Add default title to help_about (GH-2366) (#2369) https://github.com/python/cpython/commit/bd570f42110b99bade6e58e3ed2d62

[issue24813] Redesign Help => About IDLE, make it non-modal

2017-06-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: There is something more I want to add: the bitness of the machine. >>> platform.architecture() ('64bit', 'WindowsPE') Display as '(64 bit)' or '(32 bit). For the moment, add this to the title since it will not ne

[issue30715] Test_winreg, test_dynamic_key hangs on my Win 10

2017-06-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: Ping. I still cannot run the test suite to completion, so I cannot tell whether I add a warning failure regression. Does anyone else have the same problem? Should I patch the file to skip this test

[issue24813] Redesign Help => About IDLE, make it non-modal

2017-06-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: Please run the full test suite to see if it ends with a warning about test_idle altering something. I cannot because of #30715. I usually save and restore original objects when mocking, but I don't really know when this is and is not n

[issue24813] Redesign Help => About IDLE, make it non-modal

2017-06-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: I should have been clearer - the full *python* test suite, not just IDLE, an with gui available -- "python -m test -ugui". I don't think the check is applied with just one file, and definitely not with 'test.test_idle' versus &#x

[issue21519] IDLE : Bug in keybinding validity check

2017-06-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: configdialog.ConfigDialog.getNewKeys() calls config_key.GetKeysDialog with a list of lists of one or more sequences (currentKeySequences). GetKeysDialog.KeysOK looks for keys.split() in currentKeySequences. Since KeysOK on only called for the no-space '

[issue24813] Redesign Help => About IDLE, make it non-modal

2017-06-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: There are no *nix buildbots running gui tests. Please run python3 -m test.test_ttk_guionly -v and post failure part of result on core_mentorship or open a tracker issue. -- ___ Python tracker <h

[issue30751] IDLE: Display entry errors for key sequence entry in entry box

2017-06-24 Thread Terry J. Reedy
New submission from Terry J. Reedy: One of the features of query.Query boxes is that error messages are displayed in the box (in red) rather than in a separate tkinter.messagebox error box (showerror). This issue is about copying the idea and implementation to config_key.GetKeysDialog. To

[issue24813] Redesign Help => About IDLE, make it non-modal

2017-06-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: You should have enough data to open an issue; make Serhiy Storchaka (and me) nosy. Does the same test fail consistently or not? % of failures. When it takes longer, is there a particular place in the stream of results where it pauses? When I run it on

[issue30756] ttk: GUI tests fail on Ubuntu

2017-06-25 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- stage: -> needs patch type: -> behavior ___ Python tracker <http://bugs.python.org/issue30756> ___ ___ Python-bugs-list

[issue30756] ttk: GUI tests fail on Ubuntu

2017-06-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: My Win 10 machine consistently runs 272 tests OK in 3 seconds. -- ___ Python tracker <http://bugs.python.org/issue30756> ___ ___

[issue6739] IDLE: refuse invalid key bindings

2017-06-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 8c78aa70c888a370af18896a72cabd00e4120f09 by terryjreedy (csabella) in branch 'master': bpo-6739: IDLE: Check for valid keybinding in config_keys (#2377) https://github.com/python/cpython/commit/8c78aa70c888a370af18896a72cabd

[issue6739] IDLE: refuse invalid key bindings

2017-06-25 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +2444 ___ Python tracker <http://bugs.python.org/issue6739> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue6739] IDLE: refuse invalid key bindings

2017-06-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 64a0c266e78c6b5363668012fa7fb614f6018930 by terryjreedy in branch '3.6': [3.6] bpo-6739: IDLE: Check for valid keybinding in config_keys (GH-2377) (#2397) https://github.com/python/cpython/commit/64a0c266e78c6b5363668012fa7fb6

[issue6739] IDLE: refuse invalid key bindings

2017-06-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: Guilherme, thank you for the patch. Sorry it took so long to be applied. Cheryl, thank you for making the PR. Writing invalid, exception-raising sequences to user config files was a definite bug. -- resolution: -> fixed stage: test nee

[issue30728] IDLE: Modernize configdialog code.

2017-06-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset bac7d3363b099d0cdef3e541f8581859edfddc85 by terryjreedy (csabella) in branch 'master': bpo-30728: IDLE: Refactor configdialog to PEP8 names (#2307) https://github.com/python/cpython/commit/bac7d3363b099d0cdef3e541f85818

[issue30728] IDLE: Modernize configdialog code.

2017-06-26 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +2471 ___ Python tracker <http://bugs.python.org/issue30728> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30777] IDLE: configdialog -- add docstrings and improve comments

2017-06-26 Thread Terry J. Reedy
New submission from Terry J. Reedy: Spinoff from #30728. Docstrings are a form of comment. Both leave behavior alone and do not require testing, just human review. Add the docstrings from the original version of PR 2307, and any others. Review and fix comments in light of the comments on

[issue30779] IDLE: configdialog -- factor out Changes class

2017-06-26 Thread Terry J. Reedy
New submission from Terry J. Reedy: configdialog.ConfigDialog mixes together two things: a user interface for changing options and a mechanism for storing proposed changes and applying them to the configuration dictionaries managed by config. The change mechanism is based on a 3-level dict

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

2017-06-26 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- assignee: -> terry.reedy components: +IDLE dependencies: +IDLE: configdialog -- factor out Changes class ___ Python tracker <http://bugs.python.org/issu

[issue30779] IDLE: configdialog -- factor out Changes class

2017-06-26 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- assignee: -> terry.reedy components: +IDLE ___ Python tracker <http://bugs.python.org/issue30779> ___ ___ Python-bugs-list mai

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

2017-06-26 Thread Terry J. Reedy
New submission from Terry J. Reedy: A complete test of the GUI will simulate user interaction with every widget and then query Changes() to see that the proper changes orders have been recorded. This issue depends on #30779, factor out Changes class. -- messages: 296963 nosy

[issue30777] IDLE: configdialog -- add docstrings and improve comments

2017-06-26 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- assignee: -> terry.reedy components: +IDLE versions: +Python 3.6 ___ Python tracker <http://bugs.python.org/issue30777> ___ _

[issue30781] IDLE: configdialog -- switch to ttk widgets.

2017-06-26 Thread Terry J. Reedy
New submission from Terry J. Reedy: Change imports and see what else needs fixing. #27755 is one specific ttk switch that could be done before, as part of, or after this. This issue depends on #30780 test GUI -- assignee: terry.reedy components: IDLE messages: 296964 nosy: terry.reedy

[issue30781] IDLE: configdialog -- switch to ttk widgets.

2017-06-26 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- dependencies: +IDLE: configdialog - add tests for ConfigDialog GUI. ___ Python tracker <http://bugs.python.org/issue30781> ___ ___

[issue30728] IDLE: Modernize configdialog code.

2017-06-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: I decided that most other changes should be separate issues that are dependencies of this one. 30779 Docstrings and comments 28523 Colour to color 30779 Factor out Changes class 30780 Test GUI - depends on 30779 30781 Switch to ttk - depends on 30780

<    46   47   48   49   50   51   52   53   54   55   >