Ismail Donmez added the comment:
Reported as a gcc bug, http://gcc.gnu.org/PR34454
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1608>
__
___
Python-bugs-list
Ismail Donmez added the comment:
Ok so this is a code bug according to GCC developers see comment 1 & 2
at http://gcc.gnu.org/PR34454 .
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.
Ismail Donmez added the comment:
-fwrapv fixes the issue, thanks!
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1608>
__
___
Python-bugs-list mailing list
Ismail Donmez added the comment:
Looks like -fwrapv is there since gcc 2.95.3 attached patch adds -fwrapv
when debugging disabled, also removes gcc 4.x part from README as it no
longer applies.
Added file: http://bugs.python.org/file8942/fwrapv.patch
__
Tracker
Ismail Donmez added the comment:
After applying patch you need to run autoconf to update configure file
and svn commit afterwards.
Regards,
ismail
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Ismail Donmez added the comment:
Ok gcc developers say -fwrapv is there since gcc 3.3 so I think its
still fine, if not I will prepare another patch.
Regards.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Ismail Donmez added the comment:
Attached patch exactly checks if compiler supports -fwrapv otherwise
doesn't use it. Is this ok?
Added file: http://bugs.python.org/file8944/wrap.patch
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Ismail Donmez added the comment:
Last patch had a grammar error in comment, fix that.
Added file: http://bugs.python.org/file8945/wrap.patch
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1608>
__Index:
Ismail Donmez added the comment:
Removing --with-wctype-functions in total fixes following regression tests,
test_codecs
test_re
test_ucn
test_unicodedata
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Ismail Donmez added the comment:
Remove test_ucn from the list, it still fails but its for another bug
report.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Ismail Donmez added the comment:
Any ideas/comments on how to move forward with this?
Thanks,
ismail
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1609>
__
___
Ismail Donmez added the comment:
Any other thing I can do to debug this?
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1610>
__
___
Python-bugs-list
Ismail Donmez added the comment:
This was a glibc regression on my side, it can be closed as invalid. Thanks!
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Ismail Donmez added the comment:
Python README says --with-wctype-functions is deprecated and will be
removed in Python 2.6 , I don't think its worth to fix it now. Also test
failures with --with-wctype-functions is seems to be known according to
Google.
What I wonder if removing --with-w
Ismail Donmez added the comment:
Indeed there seems to be regressions:
Python 2.4 :
[~]> python
Python 2.4.4 (#1, Oct 23 2007, 11:25:50)
[GCC 3.4.6] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>&
Ismail Donmez added the comment:
Situation is even more complicated, following functions behave
_correctly_ when wctypes is enabled :
>>> print unicode("i").upper()
İ
>>> print unicode("").lower()
Following doesn't work even if wc
Ismail Donmez added the comment:
Same here for Pardus Linux, applied the patch without a regression.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1179>
__
___
Ismail Donmez added the comment:
Test works fine when using the \u syntax. You have to use the unicode()
with Turkish characters to get the error. See attached test2.py
With python 2.4 :
[~]> python test2.py
Following should print I
I
Following should print i
i
With python 2.5
Ismail Donmez added the comment:
So in conclusion,
- Enabling wctypes makes Turkish support work with \u syntax, breaks
unicode()
- Disabling wctypes breaks Turkish support with \u and/or unicode()
Attached test.py tests Turkish corner cases of lower()/upper() . Correct
output is which python
Ismail Donmez added the comment:
Replacing Turkish characters with hex versions in test2.py still results
in UnicodeDecodeError and works with python 2.4.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Ismail Donmez added the comment:
Ok that was because we had modified default encoding in Lib/site.py to
be utf-8. Sorry!
The only problem left is last 2 conversions in test.py gives wrong
results when wctypes is disabled, that is :
print u"\u0069".upper()
should give \u0130 (LAT
Ismail Donmez added the comment:
But it should be affected by locale, thats the point of locale.setlocale
call. This is how libc's wc functions behave.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Ismail Donmez added the comment:
Ok then what is the suggested way to get back the Turkish way of doing
upper/lower on i & I ?
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.
Ismail Donmez added the comment:
Hi Martin,
Actually the only problem is how can I get wctype functionality with
8-bit strings, any example is appreciated.
This bug itself is invalid because --with-wctype-functions is
deprecated. But as I said I just hope removing that doesn't regress
Tu
Ismail Donmez added the comment:
Funnily,
print "".encode("iso-8859-9").decode("iso-8859-9").upper()
works, but
print "".encode("iso-8859-9").upper().decode("iso-8859-9")
not.
__
T
Ismail Donmez added the comment:
I guess so, I will no longer spam this bug. Thanks for the suggestions.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1609>
__
__
Ismail Donmez added the comment:
Tried like ,
unicode("iii").encode("iso-8859-9").upper()
doesn't work, I'll ask on python users list. Thanks.
__
Tracker <[EMAIL PROTECTED]&g
New submission from Ismail Donmez:
Running python 2.5 maintainance branch,
Test code is :
import tarfile
f = file(r"nss-3.12_alpha2.tar.bz2", "rb")
tar = tarfile.open(fileobj=f, mode="r|bz2")
try:
for m in tar:
tar.extract
Changes by Ismail Donmez:
--
type: -> behavior
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1718>
__
___
Python-bugs-list mailing list
Uns
Ismail Donmez added the comment:
Argh stupid me, this is due a patch on my side, grr. ı am really sorry.
Please close as invalid :(
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Ismail Donmez added the comment:
-Wstrict-overflow=3 with gcc 4.3 trunk here shows :
Modules/cPickle.c: In function 'Unpickler_noload':
Modules/cPickle.c:4232: warning: assuming signed overflow does not occur
when assuming that (X - c) > X is always false
Modules/cPickle.c
Ismail Donmez added the comment:
Make sure you use gcc 4.3 trunk and at least -O2 is enabled. I tested
revision 59895 from release25-maint branch.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Ismail Donmez added the comment:
FWIW gcc hacker Ian Lance Taylor has a nice article about signed
overflow optimizations in gcc, see http://www.airs.com/blog/archives/120
. Reading that it might be better to use -fno-strict-overflow instead of
-fwrapv.
Regards,
ismail
Ismail Donmez added the comment:
Ian says -fno-strict-overflow still allows some optimizations, and his
example code shows less assembly is produced with -fno-strict-overflow.
But of course your opinion matters on this one, not mine.
Regards,
ismail
__
Tracker
Ismail Donmez added the comment:
FWIW I reported this to GCC bugzilla as a missing diagnostic @
http://gcc.gnu.org/PR34843
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Ismail Donmez added the comment:
Problem was that -Wall at the end was resetting -Wstrict-overflow, so
here is the current results for signed overflow warnings (python 2.5
branch SVN), a lot of them :
Parser/acceler.c: In function 'fixstate':
Parser/acceler.c:90: warning: assum
Ismail Donmez added the comment:
-Wstrict-overflow=5 is not valid afaik its 1-3, 3 for most verbose also
you need a recent gcc 4.3 snapshot for best results, check your
distribution for gcc-snapshot package.
About the -Wall thing it seems to be a gcc bug, but for now workaround
is easy
Ismail Donmez added the comment:
Replace -fwrapv with -Wstrict-overflow=3 -Werror=strict-overflow when
supported. Guido, does this do what you wanted?
Regards,
ismail
Added file: http://bugs.python.org/file9205/overflow-error.patch
__
Tracker <[EMAIL PROTEC
Ismail Donmez added the comment:
First stub at fixing overflows, regresses following tests :
test_doctests.py
test_locale.py
test_long.py
test_long_future.py
test_optparse.py
test_pickle.py
test_str.py (crash)
test_string.py (crash)
test_unicode.py (crash)
test_userstring.py (crash
Changes by Ismail Donmez:
Added file: http://bugs.python.org/file9210/overflow-error4.patch
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1621>
__
___
Pyth
Ismail Donmez added the comment:
No I mean we need a new unsigned variant. Else we will have to cast it
to unsigned for many overflow cases which is ugly.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Ismail Donmez added the comment:
Btw I think we need an unsigned version of Py_ssize_t to fix this
problem cleanly. I am not sure if you would agree with me though.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Ismail Donmez added the comment:
Yes it breaks compilation with gcc 4.3. Fixing these bugs are mostly
s/int/unsigned int. But some parts of code need Python wisdom :/
New patch attached adressing your comment.
Added file: http://bugs.python.org/file9207/overflow-error2.patch
Changes by Ismail Donmez:
Added file: http://bugs.python.org/file9209/overflow-error3.patch
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1621>
__
___
Pyth
Ismail Donmez added the comment:
I created a git repo for my fixes over
http://repo.or.cz/w/pytest.git?a=shortlog;h=overflow-fix .
Now as tiran suggested I fix one file and make sure nothing regressed.
But! Feel free to beat me to it and fix this. I am all new to this and
progress might be and
Ismail Donmez added the comment:
With second patch now python builds without any overflow warnings, no
new regressions. Please test and/or review.
Only thing left is fixing Modules subdirectory.
Thanks.
Added file: http://bugs.python.org/file9238/fix-overflows-try2.patch
Ismail Donmez added the comment:
Possibly last one before final patch, only Modules/_sre.c left to fix, I
appreciate help on that. Please ignore tab problems, I think that can be
fixed later on.
Thanks.
Added file: http://bugs.python.org/file9239/fix-overflows-try3.patch
Ismail Donmez added the comment:
Final patch should be complete. Used a trick in _sre.c, instead of i < 0
, I used
i + i < i to trick gcc.
Added file: http://bugs.python.org/file9242/fix-overflows-final.patch
__
Tracker <[EMAIL PROTECTE
Ismail Donmez added the comment:
Hi Christian,
unsigned cast is actually suggested by GCC developers to force correct
wrapping for signed types. And thanks to Martin, it makes sense :-)
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Ismail Donmez added the comment:
Thanks for the through review! I will add -Wsign-compare and fix new
warnings.
Btw current state is with the patch -fwrapv is not needed and no
regressions.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Ismail Donmez added the comment:
To Neal,
Can you try with -Wstrict-overflow=3 , but yes I am using gcc 4.3 trunk.
To Guido,
I'll check _csv.c issue closely. Shall I create the new bug reports or
will reviewers will do so and CC me maybe?
__
Tracker &l
Ismail Donmez added the comment:
Neal,
I'll try to answer your questions one by one, first with _csv.c compiler
issues :
Modules/_csv.c:969: warning: assuming signed overflow does not occur
when simplifying conditional to constant
There is a check inside loop like this:
Ismail Donmez added the comment:
_sre.c case is the most interesting one , compiler says :
./Modules/_sre.c:1002: warning: assuming signed overflow does not occur
when simplifying conditional to constant
./Modules/_sre.c:1069: warning: assuming signed overflow does not occur
when simplifying
Ismail Donmez added the comment:
For xmlparse.c compiler says :
Modules/expat/xmlparse.c:5337: warning: assuming signed overflow does
not occur when simplifying conditional to constant
Its impossible for j to overflow here due to name[i] check but I am not
sure what gcc is optimizing here
Ismail Donmez added the comment:
Hah strlen in a loop, a nice beginner mistake but its 5.30 AM here so
please excuse me, Guido your version of course is way better. But with
that version compiler issues
Modules/_csv.c:969: warning: assuming signed overflow does not occur when
simplifying
Ismail Donmez added the comment:
Moving the empty check before the loop will fix this and possibly
optimize empty string handling.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Ismail Donmez added the comment:
> Guido van Rossum added the comment:
>
> I wonder if it would help making i a Py_ssize_t instead of an int?
gcc still issues the same warning with that.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.py
Ismail Donmez added the comment:
Neal,
You could btw check
http://repo.or.cz/w/pytest.git?a=shortlog;h=overflow-fix which have each
fix seperate so that reviewing is easy. Just ignore configure changes
thats for later.
Thanks,
ismail
__
Tracker <[EM
Ismail Donmez added the comment:
gcc is optimizing the second if check , for specifically i == 0 seems to
redundant according to gcc.
if (i == 0 && quote_empty) {
if (dialect->quoting == QUOTE_NONE) {
PyErr_Forma
Changes by Ismail Donmez:
--
nosy: +cartman
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1391>
__
___
Python-bugs-list mailing list
Unsubs
Ismail Donmez added the comment:
Any news on this? Also gcc 4.3 & gcc 4.2.3 fixed the -Wall clobbering -
Wstrict-overflow problem, which is good news.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.
New submission from Ismail Donmez <[EMAIL PROTECTED]>:
At top it says "This document is placed in the public doman." should do
a s/doman/domain .
--
assignee: georg.brandl
components: Documentation
messages: 65612
nosy: cartman, georg.brandl
severity: normal
status: ope
Ismail Donmez <[EMAIL PROTECTED]> added the comment:
This _must_ be a release blocker for Python 3.0, Its a shame that this
bug still is not fixed and a patch is available for months now.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Ismail Donmez <[EMAIL PROTECTED]> added the comment:
I am sorry for the drama then, :)
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1179>
__
___
Python
Changes by Ismail Donmez <[EMAIL PROTECTED]>:
--
nosy: +cartman
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue4561>
___
___
Python
Ismail Donmez added the comment:
The documentation helped a lot, so thanks for that! But it misses the final
crucial step:
copy /b zastub.exe+app.pyz app.exe
The documentation talks about prepending the zastub.exe to the zip file but
never mentions how, which is very confusing
Changes by Ismail Donmez :
--
nosy: +cartman
___
Python tracker
<http://bugs.python.org/issue9687>
___
___
Python-bugs-list mailing list
Unsubscribe:
Ismail Donmez added the comment:
See http://sourceware.org/ml/libffi-discuss/2011/msg00024.html for the libffi
patch.
--
___
Python tracker
<http://bugs.python.org/issue11
Ismail Donmez added the comment:
Chiming in here as a SUSE guy;
Can you make sure
/usr/local/lib/python3.4/lib-dynload/_sqlite3.cpython-34m.so
does exist. If yes run ldd on it
ldd /usr/local/lib/python3.4/lib-dynload/_sqlite3.cpython-34m.so
And also give output of "which python3.4&quo
Ismail Donmez added the comment:
Can we please get a review on this?
--
nosy: +cartman
___
Python tracker
<http://bugs.python.org/issue20631>
___
___
Python-bug
Changes by Ismail Donmez :
--
nosy: +cartman
___
Python tracker
<http://bugs.python.org/issue20763>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Ismail Donmez :
Two failures in test_importlib:
==
FAIL: test_case_insensitivity
(importlib.test.extension.test_case_sensitivity.ExtensionModuleCaseSensi
tivityTest
Ismail Donmez added the comment:
Yes its case sensitive.
--
message_count: 2.0 -> 3.0
___
Python tracker
<http://bugs.python.org/issue5442>
___
___
Python-
Ismail Donmez added the comment:
Well the test is now skipped on _all_ platforms. This looks wrong.
--
nosy: +cartman
___
Python tracker
<http://bugs.python.org/issue3
Ismail Donmez added the comment:
Sure thing, I am waiting for alpha2.
Regards.
--
status: pending -> open
___
Python tracker
<http://bugs.python.org/iss
Ismail Donmez added the comment:
Still fails with 3.1 alpha2:
==
ERROR: test_is_package
(importlib.test.frozen.test_loader.InspectLoaderTests)
--
Traceback
Ismail Donmez added the comment:
[~]> python3.1 tester.py
original name: .CFUserTextEncoding
changed name: .CFUSERTEXTENCODING
case-sensitive
I'll do a rebuild just in case. Thanks.
--
___
Python tracker
<http://bugs.python.or
New submission from Ismail Donmez :
Using latest python 2.6 branch; test_asynchat fails with the following
error:
error: uncaptured python exception, closing channel
(:[Errno 9] Bad file descriptor
[/Users/cartman/Sources/python-2.6/Lib/asyncore.py|readwrite|107]
[/Users/cartman/Sources/python
Ismail Donmez added the comment:
Fails in beta1.
--
title: [3.1alpha1,2] test_importlib fails on Mac OSX 10.5.6 ->
[3.1alpha1,2,beta1] test_importlib fails on Mac OSX 10.5.6
___
Python tracker
<http://bugs.python.org/iss
Ismail Donmez added the comment:
Still fails in 3.1 beta1.
--
___
Python tracker
<http://bugs.python.org/issue5798>
___
___
Python-bugs-list mailing list
Unsub
Ismail Donmez added the comment:
Tested with: ./python -m test.regrtest -v test_importlib
3 failures:
==
FAIL: test_case_insensitivity
(importlib.test.extension.test_case_sensitivity.ExtensionModuleCaseSensi
tivityTest
Ismail Donmez added the comment:
Down to 1 failure:
FAILED (failures=1)
test test_importlib failed -- Traceback (most recent call last):
File "/Users/cartman/Python-
3.1b1/Lib/importlib/test/source/test_abc_loader.py", line 271, in
test_lacking_parent
self.verify_bytecode(
Ismail Donmez added the comment:
1 Fail:
test test_importlib crashed -- : 'module' object
has no attribute 'writes_bytecode'
Traceback (most recent call last):
File "/Users/cartman/Python-3.1b1/Lib/test/regrtest.py", line 620, in
runtest_inner
indirect
Ismail Donmez added the comment:
Applied skip_bytecode.diff and test_file_loader.diff clean build
results in:
==
FAIL: test_case_insensitivity
(importlib.test.extension.test_case_sensitivity.ExtensionModuleCaseSensi
Ismail Donmez added the comment:
You should be using gcc 4.4 to get the best warning behaviour.
--
___
Python tracker
<http://bugs.python.org/issue1621>
___
___
Ismail Donmez added the comment:
What's the status on this? Can you please create a pull request on Github so we
can continue there?
--
___
Python tracker
<http://bugs.python.org/is
Ismail Donmez added the comment:
We are now hitting this on openSUSE 12.3, here is the relevant log (ignore the
timestamps) :
[ 1041s] ==
[ 1041s] FAIL: test_close_fds (test.test_subprocess.POSIXProcessTestCase)
[ 1041s
Ismail Donmez added the comment:
I can reproduce the error locally. But I see something in the log might be
related to this (possibly not but anyway):
[352/368/1] test_multiprocessing
test_multiprocessing skipped -- This platform lacks a functioning sem_open
implementation, therefore, the
Ismail Donmez added the comment:
Jan, thanks for the excellent explanation. We can close this bug I guess then?
--
___
Python tracker
<http://bugs.python.org/issue12
Ismail Donmez added the comment:
Time to say ping here. This patch is still would be useful for Python.
--
nosy: +cartman
___
Python tracker
<http://bugs.python.org/issue4
Ismail Donmez added the comment:
FWIW OpenSSL patch is now upstream
https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=cf6da05304d554aaa885151451aa4ecaa977e601
https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=fb0e87fb67a358b40a1d56d2df3a611a09899780
--
nosy
Changes by Ismail Donmez :
--
nosy: +cartman
___
Python tracker
<http://bugs.python.org/issue13501>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Ismail Donmez:
ncurses6 turned on NCURSES_OPAQUE, so now you have to use some helper functions
instead of accessing the structs directly. This _should_ be compatible with
ncurses5 though I didn't test it.
Original patch is from openSUSE.
--
components: Exte
Changes by Ismail Donmez :
--
nosy: +donmez
___
Python tracker
<http://bugs.python.org/issue25843>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Ismail Donmez:
Installed Python 3.5.1 windows x64 version and ended up having
C:\Users\ismail\AppData\Local\Programs\Python\Python35\curl.exe
which is outdated:
C:\Users\ismail>C:\Users\ismail\AppData\Local\Programs\Python\Python35\curl.exe
-V
curl 7.37.0 (Wind
Ismail Donmez added the comment:
Indeed, I am sorry! It was pycurl.
--
___
Python tracker
<http://bugs.python.org/issue25932>
___
___
Python-bugs-list mailin
Ismail Donmez added the comment:
Any patch review/comment ?
--
___
Python tracker
<http://bugs.python.org/issue25720>
___
___
Python-bugs-list mailing list
Unsub
Ismail Donmez added the comment:
Thats not an issue for ncurses because Include/py_curses.h does:
#ifdef HAVE_NCURSES_H
/* configure was checking , but we will
use , which has all these features. */
#ifndef WINDOW_HAS_FLAGS
#define WINDOW_HAS_FLAGS 1
#endif
#ifndef
Ismail Donmez added the comment:
ping?
--
___
Python tracker
<http://bugs.python.org/issue25720>
___
___
Python-bugs-list mailing list
Unsubscribe:
Ismail Donmez added the comment:
Any update on this? Would be nice to have this for 3.5 release.
--
nosy: +cartman
___
Python tracker
<http://bugs.python.org/issue10
101 - 200 of 202 matches
Mail list logo
